cosmos 3.0.1 → 3.1.0

data/lib/cosmos/tools/tlm_grapher/data_object_editors/linegraph_data_object_editor.rb

@@ -1,141 +1,141 @@
-# encoding: ascii-8bit
-
-# Copyright 2014 Ball Aerospace & Technologies Corp.
-# All Rights Reserved.
-#
-# This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
-# as published by the Free Software Foundation; version 3 with
-# attribution addendums as found in the LICENSE.txt
-
-# This file contains the implementation of the LinegraphDataObjectEditor class.   This class
-# provides dialog box content to create/edit linegraph data objects.
-
-require 'cosmos'
-require 'cosmos/tools/tlm_grapher/data_object_editors/data_object_editor'
-require 'cosmos/gui/choosers/float_chooser'
-require 'cosmos/gui/choosers/combobox_chooser'
-
-module Cosmos
-
-  # Widget which creates an editor for a line graph data object
-  class LinegraphDataObjectEditor < DataObjectEditor
-
-    def initialize(parent)
-      super(parent)
-    end
-
-    def set_data_object(data_object)
-      local_layout = Qt::VBoxLayout.new
-      local_layout.setContentsMargins(0,0,0,0)
-
-      # Float Chooser for y_offset
-      @y_offset = FloatChooser.new(self, 'Y Offset:', 0)
-      @y_offset.value = data_object.y_offset if data_object.y_offset
-      local_layout.addWidget(@y_offset)
-
-      # Chooser for Y Axis
-      @y_axis = ComboboxChooser.new(self, 'Y Axis:', LinegraphDataObject::Y_AXIS_CHOICES.map {|x| x.to_s})
-      @y_axis.set_current(data_object.y_axis) if data_object.y_axis
-      local_layout.addWidget(@y_axis)
-
-      # Chooser for Horizontal Lines
-      @button_layout = Qt::HBoxLayout.new
-      @horizontal_label = Qt::Label.new('Horizontal Lines:')
-      @button_layout.addWidget(@horizontal_label)
-      @button_layout.addStretch()
-      @add_button = Qt::PushButton.new('Add', self)
-      @add_button.setAutoDefault(false)
-      @add_button.connect(SIGNAL('clicked()')) { handle_add_button() }
-      @button_layout.addWidget(@add_button)
-      @delete_button = Qt::PushButton.new('Delete', self)
-      @delete_button.setAutoDefault(false)
-      @delete_button.connect(SIGNAL('clicked()')) { handle_delete_button() }
-      @button_layout.addWidget(@delete_button)
-      local_layout.addLayout(@button_layout)
-
-      @horizontal_lines = Qt::ColorListWidget.new(self)
-      @horizontal_lines.setMinimumHeight(50)
-      sync_gui_lines_with_data_object(data_object)
-      local_layout.addWidget(@horizontal_lines)
-      @layout.addLayout(local_layout)
-
-      super(data_object)
-    end
-
-    # Get the data object from the editor
-    def get_data_object
-      data_object = super()
-      horizontal_lines = []
-      index = 0
-      @horizontal_lines.each do |list_item|
-        horizontal_lines << [list_item.text.to_f, @horizontal_lines.getItemColor(index)]
-        index += 1
-      end
-      data_object.horizontal_lines = horizontal_lines
-      data_object.y_offset = @y_offset.value
-      data_object.y_axis = @y_axis.symbol
-      data_object
-    end
-
-    # Handle the Add Horizontal Line button being pressed
-    def handle_add_button
-      dialog = Qt::Dialog.new(self) #'Add Horizontal Line'
-      layout = Qt::VBoxLayout.new
-      colors = LinegraphDataObject::COLOR_LIST.clone
-      color = ComboboxChooser.new(dialog, 'Color:', colors, color_chooser: true)
-      layout.addWidget(color)
-      y_value = FloatChooser.new(dialog, 'Y Value:', 0.0)
-      layout.addWidget(y_value)
-
-      # Create OK and Cancel buttons
-      button_layout = Qt::HBoxLayout.new
-      ok_button = Qt::PushButton.new('OK')
-      ok_button.connect(SIGNAL('clicked()')) { dialog.accept }
-      button_layout.addWidget(ok_button)
-      cancel_button = Qt::PushButton.new('Cancel')
-      cancel_button.connect(SIGNAL('clicked()')) { dialog.reject }
-      button_layout.addWidget(cancel_button)
-
-      layout.addLayout(button_layout)
-      dialog.setLayout(layout)
-      result = dialog.exec
-      if result != 0
-        # Horizontal Line Added
-        @horizontal_lines.addItemColor(y_value.string, color.string)
-      end
-      dialog.dispose
-    end
-
-    # Handle the delete horizontal line button being pressed
-    def handle_delete_button
-      horizontal_line_indexes = selected_horizontal_lines()
-      unless horizontal_line_indexes.empty?
-        horizontal_line_indexes.reverse.each do |index|
-          @horizontal_lines.takeItemColor(index)
-        end
-      end
-    end
-
-    protected
-
-    # Update the horizontal line list to match the data object
-    def sync_gui_lines_with_data_object(data_object)
-      @horizontal_lines.clearItems
-      data_object.horizontal_lines.each {|y_value, color| @horizontal_lines.addItemColor(y_value.to_s, color)}
-    end
-
-    # Returns an array of the indexes of the selected horizontal lines
-    def selected_horizontal_lines
-      selected = []
-      index = 0
-      @horizontal_lines.each do |list_item|
-        selected << index if list_item.selected?
-        index += 1
-      end
-      selected
-    end
-
-  end # class LinegraphDataObjectEditor
-
-end # module Cosmos
+# encoding: ascii-8bit
+
+# Copyright 2014 Ball Aerospace & Technologies Corp.
+# All Rights Reserved.
+#
+# This program is free software; you can modify and/or redistribute it
+# under the terms of the GNU General Public License
+# as published by the Free Software Foundation; version 3 with
+# attribution addendums as found in the LICENSE.txt
+
+# This file contains the implementation of the LinegraphDataObjectEditor class.   This class
+# provides dialog box content to create/edit linegraph data objects.
+
+require 'cosmos'
+require 'cosmos/tools/tlm_grapher/data_object_editors/data_object_editor'
+require 'cosmos/gui/choosers/float_chooser'
+require 'cosmos/gui/choosers/combobox_chooser'
+
+module Cosmos
+
+  # Widget which creates an editor for a line graph data object
+  class LinegraphDataObjectEditor < DataObjectEditor
+
+    def initialize(parent)
+      super(parent)
+    end
+
+    def set_data_object(data_object)
+      local_layout = Qt::VBoxLayout.new
+      local_layout.setContentsMargins(0,0,0,0)
+
+      # Float Chooser for y_offset
+      @y_offset = FloatChooser.new(self, 'Y Offset:', 0)
+      @y_offset.value = data_object.y_offset if data_object.y_offset
+      local_layout.addWidget(@y_offset)
+
+      # Chooser for Y Axis
+      @y_axis = ComboboxChooser.new(self, 'Y Axis:', LinegraphDataObject::Y_AXIS_CHOICES.map {|x| x.to_s})
+      @y_axis.set_current(data_object.y_axis) if data_object.y_axis
+      local_layout.addWidget(@y_axis)
+
+      # Chooser for Horizontal Lines
+      @button_layout = Qt::HBoxLayout.new
+      @horizontal_label = Qt::Label.new('Horizontal Lines:')
+      @button_layout.addWidget(@horizontal_label)
+      @button_layout.addStretch()
+      @add_button = Qt::PushButton.new('Add', self)
+      @add_button.setAutoDefault(false)
+      @add_button.connect(SIGNAL('clicked()')) { handle_add_button() }
+      @button_layout.addWidget(@add_button)
+      @delete_button = Qt::PushButton.new('Delete', self)
+      @delete_button.setAutoDefault(false)
+      @delete_button.connect(SIGNAL('clicked()')) { handle_delete_button() }
+      @button_layout.addWidget(@delete_button)
+      local_layout.addLayout(@button_layout)
+
+      @horizontal_lines = Qt::ColorListWidget.new(self)
+      @horizontal_lines.setMinimumHeight(50)
+      sync_gui_lines_with_data_object(data_object)
+      local_layout.addWidget(@horizontal_lines)
+      @layout.addLayout(local_layout)
+
+      super(data_object)
+    end
+
+    # Get the data object from the editor
+    def get_data_object
+      data_object = super()
+      horizontal_lines = []
+      index = 0
+      @horizontal_lines.each do |list_item|
+        horizontal_lines << [list_item.text.to_f, @horizontal_lines.getItemColor(index)]
+        index += 1
+      end
+      data_object.horizontal_lines = horizontal_lines
+      data_object.y_offset = @y_offset.value
+      data_object.y_axis = @y_axis.symbol
+      data_object
+    end
+
+    # Handle the Add Horizontal Line button being pressed
+    def handle_add_button
+      dialog = Qt::Dialog.new(self) #'Add Horizontal Line'
+      layout = Qt::VBoxLayout.new
+      colors = LinegraphDataObject::COLOR_LIST.clone
+      color = ComboboxChooser.new(dialog, 'Color:', colors, color_chooser: true)
+      layout.addWidget(color)
+      y_value = FloatChooser.new(dialog, 'Y Value:', 0.0)
+      layout.addWidget(y_value)
+
+      # Create OK and Cancel buttons
+      button_layout = Qt::HBoxLayout.new
+      ok_button = Qt::PushButton.new('OK')
+      ok_button.connect(SIGNAL('clicked()')) { dialog.accept }
+      button_layout.addWidget(ok_button)
+      cancel_button = Qt::PushButton.new('Cancel')
+      cancel_button.connect(SIGNAL('clicked()')) { dialog.reject }
+      button_layout.addWidget(cancel_button)
+
+      layout.addLayout(button_layout)
+      dialog.setLayout(layout)
+      result = dialog.exec
+      if result != 0
+        # Horizontal Line Added
+        @horizontal_lines.addItemColor(y_value.string, color.string)
+      end
+      dialog.dispose
+    end
+
+    # Handle the delete horizontal line button being pressed
+    def handle_delete_button
+      horizontal_line_indexes = selected_horizontal_lines()
+      unless horizontal_line_indexes.empty?
+        horizontal_line_indexes.reverse.each do |index|
+          @horizontal_lines.takeItemColor(index)
+        end
+      end
+    end
+
+    protected
+
+    # Update the horizontal line list to match the data object
+    def sync_gui_lines_with_data_object(data_object)
+      @horizontal_lines.clearItems
+      data_object.horizontal_lines.each {|y_value, color| @horizontal_lines.addItemColor(y_value.to_s, color)}
+    end
+
+    # Returns an array of the indexes of the selected horizontal lines
+    def selected_horizontal_lines
+      selected = []
+      index = 0
+      @horizontal_lines.each do |list_item|
+        selected << index if list_item.selected?
+        index += 1
+      end
+      selected
+    end
+
+  end # class LinegraphDataObjectEditor
+
+end # module Cosmos

data/lib/cosmos/tools/tlm_grapher/data_object_editors/singlexy_data_object_editor.rb

@@ -1,30 +1,30 @@
-# encoding: ascii-8bit
-
-# Copyright 2014 Ball Aerospace & Technologies Corp.
-# All Rights Reserved.
-#
-# This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
-# as published by the Free Software Foundation; version 3 with
-# attribution addendums as found in the LICENSE.txt
-
-# This file contains the implementation of the SinglexyDataObjectEditor class.   This class
-# provides dialog box content to create/edit single x-y data objects.
-
-require 'cosmos'
-require 'cosmos/tools/tlm_grapher/data_object_editors/xy_data_object_editor'
-require 'cosmos/tools/tlm_grapher/data_objects/singlexy_data_object'
-
-module Cosmos
-
-  # Widget which creates an editor for a single X-Y data object
-  class SinglexyDataObjectEditor < XyDataObjectEditor
-
-    def initialize(parent)
-      super(parent)
-      @data_object_class = SinglexyDataObject
-    end
-
-  end # class SinglexyDataObjectEditor
-
-end # module Cosmos
+# encoding: ascii-8bit
+
+# Copyright 2014 Ball Aerospace & Technologies Corp.
+# All Rights Reserved.
+#
+# This program is free software; you can modify and/or redistribute it
+# under the terms of the GNU General Public License
+# as published by the Free Software Foundation; version 3 with
+# attribution addendums as found in the LICENSE.txt
+
+# This file contains the implementation of the SinglexyDataObjectEditor class.   This class
+# provides dialog box content to create/edit single x-y data objects.
+
+require 'cosmos'
+require 'cosmos/tools/tlm_grapher/data_object_editors/xy_data_object_editor'
+require 'cosmos/tools/tlm_grapher/data_objects/singlexy_data_object'
+
+module Cosmos
+
+  # Widget which creates an editor for a single X-Y data object
+  class SinglexyDataObjectEditor < XyDataObjectEditor
+
+    def initialize(parent)
+      super(parent)
+      @data_object_class = SinglexyDataObject
+    end
+
+  end # class SinglexyDataObjectEditor
+
+end # module Cosmos

data/lib/cosmos/tools/tlm_grapher/data_object_editors/xy_data_object_editor.rb

@@ -1,173 +1,173 @@
-# encoding: ascii-8bit
-
-# Copyright 2014 Ball Aerospace & Technologies Corp.
-# All Rights Reserved.
-#
-# This program is free software; you can modify and/or redistribute it
-# under the terms of the GNU General Public License
-# as published by the Free Software Foundation; version 3 with
-# attribution addendums as found in the LICENSE.txt
-
-# This file contains the implementation of the XyDataObjectEditor class.   This class
-# provides dialog box content to create/edit xy data objects.
-
-require 'cosmos'
-require 'cosmos/tools/tlm_grapher/data_object_editors/data_object_editor'
-require 'cosmos/gui/choosers/float_chooser'
-require 'cosmos/gui/choosers/combobox_chooser'
-require 'cosmos/tools/tlm_grapher/data_objects/xy_data_object'
-
-module Cosmos
-
-  # Widget which creates an editor for a X-Y data object
-  class XyDataObjectEditor < DataObjectEditor
-
-    def initialize(parent)
-      super(parent)
-      @data_object_class = XyDataObject
-    end
-
-    def set_data_object(data_object)
-      if data_object
-        # We are editing data, so make a copy
-        data_object = data_object.copy
-      else
-        # We are creating a new data object
-        data_object = @data_object_class.new
-
-        # Default items
-        packet = System.telemetry.first_non_hidden
-        data_object.target_name = packet.target_name
-        data_object.packet_name = packet.packet_name
-        data_object.y_item_name = 'RECEIVED_TIMESECONDS'
-        data_object.x_item_name = 'RECEIVED_TIMESECONDS'
-        data_object.time_item_name = 'RECEIVED_TIMESECONDS'
-      end
-      super(data_object)
-
-      @local_layout = Qt::VBoxLayout.new
-      @local_layout.setContentsMargins(0,0,0,0)
-
-      # Telemetry Chooser for x item
-      @telemetry_chooser = TelemetryChooser.new(self, Qt::Vertical, true, false)
-      @telemetry_chooser.set_item(data_object.target_name, data_object.packet_name, data_object.y_item_name)
-      @telemetry_chooser.target_changed_callback = method(:target_packet_changed_callback)
-      @telemetry_chooser.packet_changed_callback = method(:target_packet_changed_callback)
-      @telemetry_chooser.item_changed_callback = method(:y_item_changed_callback)
-      @telemetry_chooser.target_label.text = '*Target:'
-      @telemetry_chooser.packet_label.text = '*Packet:'
-      @telemetry_chooser.item_label.text   = '*Y Item:'
-      @local_layout.addWidget(@telemetry_chooser)
-
-      # Chooser for y item
-      x_item_names = @telemetry_chooser.item_names
-      if data_object.x_item_name
-        x_item_names.delete(data_object.x_item_name)
-        x_item_names.unshift(data_object.x_item_name)
-      end
-      @x_item_name = ComboboxChooser.new(self, '*X Item:', x_item_names)
-      @x_item_name.sel_command_callback = method(:x_item_changed_callback)
-      @local_layout.addWidget(@x_item_name)
-
-      # Chooser for time item
-      time_item_names = @telemetry_chooser.item_names
-      if data_object.time_item_name
-        time_item_names.delete(data_object.time_item_name)
-        time_item_names.unshift(data_object.time_item_name)
-      end
-      @time_item_name = ComboboxChooser.new(self, '*Time Item:', time_item_names)
-      @local_layout.addWidget(@time_item_name)
-
-      # Chooser for y value type
-      value_types = XyDataObject::VALUE_TYPES.clone
-      @y_value_type = ComboboxChooser.new(self, '*Y Value Type:', value_types)
-      @y_value_type.set_current(data_object.y_value_type.to_s) if data_object.y_value_type
-      @local_layout.addWidget(@y_value_type)
-
-      # Chooser for x value type
-      value_types = XyDataObject::VALUE_TYPES.clone
-      @x_value_type = ComboboxChooser.new(self, '*X Value Type:', value_types)
-      @x_value_type.set_current(data_object.x_value_type.to_s) if data_object.x_value_type
-      @local_layout.addWidget(@x_value_type)
-
-      @layout.insertLayout(0, @local_layout)
-    end
-
-    # Gets the data object from the editor
-    def get_data_object
-      data_object = super()
-      data_object.target_name = @telemetry_chooser.target_name
-      data_object.packet_name = @telemetry_chooser.packet_name
-      data_object.y_item_name = @telemetry_chooser.item_name
-      begin
-        data_object.x_item_name = @x_item_name.string
-      rescue Exception
-        # No valid y_item_name - should be corrected by callback
-      end
-      begin
-        data_object.time_item_name = @time_item_name.string if @time_item_name
-      rescue Exception
-        # No valid time_item_name - should be corrected by callback
-      end
-      data_object.y_value_type = @y_value_type.symbol
-      data_object.x_value_type = @x_value_type.symbol
-      data_object
-    end
-
-    protected
-
-    # Handles the target or packet name changing
-    def target_packet_changed_callback(target = nil, packet = nil)
-      x_item_names = @telemetry_chooser.item_names
-      time_item_names = @telemetry_chooser.item_names
-      data_object = get_data_object()
-      if data_object.x_item_name
-        x_item_names.unshift(data_object.x_item_name) if x_item_names.delete(data_object.x_item_name)
-      end
-      if data_object.time_item_name
-        time_item_names.unshift(data_object.time_item_name) if time_item_names.delete(data_object.time_item_name)
-      end
-      @x_item_name.update_items(x_item_names, false)
-      @time_item_name.update_items(time_item_names, false) if @time_item_name
-      data_object.target_name = @telemetry_chooser.target_name
-      data_object.packet_name = @telemetry_chooser.packet_name
-      data_object.y_item_name = @telemetry_chooser.item_name
-      data_object.x_item_name = x_item_names[0]
-      data_object.time_item_name = time_item_names[0] if @time_item_name
-      value_types = XyDataObject::VALUE_TYPES.clone
-      value_types.delete(data_object.y_value_type)
-      value_types.unshift(data_object.y_value_type)
-      @y_value_type.update_items(value_types, false)
-      value_types = XyDataObject::VALUE_TYPES.clone
-      value_types.delete(data_object.x_value_type)
-      value_types.unshift(data_object.x_value_type)
-      @x_value_type.update_items(value_types, false)
-    end
-
-    # Handles the y item name changing
-    def y_item_changed_callback(target_name, packet_name, item_name)
-      data_object = get_data_object()
-      data_object.target_name = @telemetry_chooser.target_name
-      data_object.packet_name = @telemetry_chooser.packet_name
-      data_object.y_item_name = @telemetry_chooser.item_name
-      value_types = XyDataObject::VALUE_TYPES.clone
-      value_types.delete(data_object.y_value_type)
-      value_types.unshift(data_object.y_value_type)
-      @y_value_type.update_items(value_types, false)
-    end
-
-    # Handles the x item name changing
-    def x_item_changed_callback(string)
-      if string and !string.empty?
-        data_object = get_data_object()
-        data_object.x_item_name = string
-        value_types = XyDataObject::VALUE_TYPES.clone
-        value_types.delete(data_object.x_value_type)
-        value_types.unshift(data_object.x_value_type)
-        @x_value_type.update_items(value_types, false)
-      end
-    end
-
-  end # class XyDataObjectEditor
-
-end # module Cosmos
+# encoding: ascii-8bit
+
+# Copyright 2014 Ball Aerospace & Technologies Corp.
+# All Rights Reserved.
+#
+# This program is free software; you can modify and/or redistribute it
+# under the terms of the GNU General Public License
+# as published by the Free Software Foundation; version 3 with
+# attribution addendums as found in the LICENSE.txt
+
+# This file contains the implementation of the XyDataObjectEditor class.   This class
+# provides dialog box content to create/edit xy data objects.
+
+require 'cosmos'
+require 'cosmos/tools/tlm_grapher/data_object_editors/data_object_editor'
+require 'cosmos/gui/choosers/float_chooser'
+require 'cosmos/gui/choosers/combobox_chooser'
+require 'cosmos/tools/tlm_grapher/data_objects/xy_data_object'
+
+module Cosmos
+
+  # Widget which creates an editor for a X-Y data object
+  class XyDataObjectEditor < DataObjectEditor
+
+    def initialize(parent)
+      super(parent)
+      @data_object_class = XyDataObject
+    end
+
+    def set_data_object(data_object)
+      if data_object
+        # We are editing data, so make a copy
+        data_object = data_object.copy
+      else
+        # We are creating a new data object
+        data_object = @data_object_class.new
+
+        # Default items
+        packet = System.telemetry.first_non_hidden
+        data_object.target_name = packet.target_name
+        data_object.packet_name = packet.packet_name
+        data_object.y_item_name = 'RECEIVED_TIMESECONDS'
+        data_object.x_item_name = 'RECEIVED_TIMESECONDS'
+        data_object.time_item_name = 'RECEIVED_TIMESECONDS'
+      end
+      super(data_object)
+
+      @local_layout = Qt::VBoxLayout.new
+      @local_layout.setContentsMargins(0,0,0,0)
+
+      # Telemetry Chooser for x item
+      @telemetry_chooser = TelemetryChooser.new(self, Qt::Vertical, true, false)
+      @telemetry_chooser.set_item(data_object.target_name, data_object.packet_name, data_object.y_item_name)
+      @telemetry_chooser.target_changed_callback = method(:target_packet_changed_callback)
+      @telemetry_chooser.packet_changed_callback = method(:target_packet_changed_callback)
+      @telemetry_chooser.item_changed_callback = method(:y_item_changed_callback)
+      @telemetry_chooser.target_label.text = '*Target:'
+      @telemetry_chooser.packet_label.text = '*Packet:'
+      @telemetry_chooser.item_label.text   = '*Y Item:'
+      @local_layout.addWidget(@telemetry_chooser)
+
+      # Chooser for y item
+      x_item_names = @telemetry_chooser.item_names
+      if data_object.x_item_name
+        x_item_names.delete(data_object.x_item_name)
+        x_item_names.unshift(data_object.x_item_name)
+      end
+      @x_item_name = ComboboxChooser.new(self, '*X Item:', x_item_names)
+      @x_item_name.sel_command_callback = method(:x_item_changed_callback)
+      @local_layout.addWidget(@x_item_name)
+
+      # Chooser for time item
+      time_item_names = @telemetry_chooser.item_names
+      if data_object.time_item_name
+        time_item_names.delete(data_object.time_item_name)
+        time_item_names.unshift(data_object.time_item_name)
+      end
+      @time_item_name = ComboboxChooser.new(self, '*Time Item:', time_item_names)
+      @local_layout.addWidget(@time_item_name)
+
+      # Chooser for y value type
+      value_types = XyDataObject::VALUE_TYPES.clone
+      @y_value_type = ComboboxChooser.new(self, '*Y Value Type:', value_types)
+      @y_value_type.set_current(data_object.y_value_type.to_s) if data_object.y_value_type
+      @local_layout.addWidget(@y_value_type)
+
+      # Chooser for x value type
+      value_types = XyDataObject::VALUE_TYPES.clone
+      @x_value_type = ComboboxChooser.new(self, '*X Value Type:', value_types)
+      @x_value_type.set_current(data_object.x_value_type.to_s) if data_object.x_value_type
+      @local_layout.addWidget(@x_value_type)
+
+      @layout.insertLayout(0, @local_layout)
+    end
+
+    # Gets the data object from the editor
+    def get_data_object
+      data_object = super()
+      data_object.target_name = @telemetry_chooser.target_name
+      data_object.packet_name = @telemetry_chooser.packet_name
+      data_object.y_item_name = @telemetry_chooser.item_name
+      begin
+        data_object.x_item_name = @x_item_name.string
+      rescue Exception
+        # No valid y_item_name - should be corrected by callback
+      end
+      begin
+        data_object.time_item_name = @time_item_name.string if @time_item_name
+      rescue Exception
+        # No valid time_item_name - should be corrected by callback
+      end
+      data_object.y_value_type = @y_value_type.symbol
+      data_object.x_value_type = @x_value_type.symbol
+      data_object
+    end
+
+    protected
+
+    # Handles the target or packet name changing
+    def target_packet_changed_callback(target = nil, packet = nil)
+      x_item_names = @telemetry_chooser.item_names
+      time_item_names = @telemetry_chooser.item_names
+      data_object = get_data_object()
+      if data_object.x_item_name
+        x_item_names.unshift(data_object.x_item_name) if x_item_names.delete(data_object.x_item_name)
+      end
+      if data_object.time_item_name
+        time_item_names.unshift(data_object.time_item_name) if time_item_names.delete(data_object.time_item_name)
+      end
+      @x_item_name.update_items(x_item_names, false)
+      @time_item_name.update_items(time_item_names, false) if @time_item_name
+      data_object.target_name = @telemetry_chooser.target_name
+      data_object.packet_name = @telemetry_chooser.packet_name
+      data_object.y_item_name = @telemetry_chooser.item_name
+      data_object.x_item_name = x_item_names[0]
+      data_object.time_item_name = time_item_names[0] if @time_item_name
+      value_types = XyDataObject::VALUE_TYPES.clone
+      value_types.delete(data_object.y_value_type)
+      value_types.unshift(data_object.y_value_type)
+      @y_value_type.update_items(value_types, false)
+      value_types = XyDataObject::VALUE_TYPES.clone
+      value_types.delete(data_object.x_value_type)
+      value_types.unshift(data_object.x_value_type)
+      @x_value_type.update_items(value_types, false)
+    end
+
+    # Handles the y item name changing
+    def y_item_changed_callback(target_name, packet_name, item_name)
+      data_object = get_data_object()
+      data_object.target_name = @telemetry_chooser.target_name
+      data_object.packet_name = @telemetry_chooser.packet_name
+      data_object.y_item_name = @telemetry_chooser.item_name
+      value_types = XyDataObject::VALUE_TYPES.clone
+      value_types.delete(data_object.y_value_type)
+      value_types.unshift(data_object.y_value_type)
+      @y_value_type.update_items(value_types, false)
+    end
+
+    # Handles the x item name changing
+    def x_item_changed_callback(string)
+      if string and !string.empty?
+        data_object = get_data_object()
+        data_object.x_item_name = string
+        value_types = XyDataObject::VALUE_TYPES.clone
+        value_types.delete(data_object.x_value_type)
+        value_types.unshift(data_object.x_value_type)
+        @x_value_type.update_items(value_types, false)
+      end
+    end
+
+  end # class XyDataObjectEditor
+
+end # module Cosmos