odoo-addon-contract 17.0.1.4.3.2__py3-none-any.whl → 18.0.2.0.8__py3-none-any.whl

odoo/addons/contract/models/contract.py

@@ -6,14 +6,14 @@
 # Copyright 2018 ACSONE SA/NV
 # Copyright 2021 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
 import logging
 
 from markupsafe import Markup
 
 from odoo import Command, api, fields, models
-from odoo.exceptions import UserError, ValidationError
+from odoo.exceptions import ValidationError
 from odoo.osv import expression
-from odoo.tools.translate import _
 
 _logger = logging.getLogger(__name__)
 
@@ -23,24 +23,52 @@ class ContractContract(models.Model):
     _description = "Contract"
     _order = "code, name asc"
     _inherit = [
+        "contract.template",
+        "portal.mixin",
         "mail.thread",
         "mail.activity.mixin",
-        "contract.abstract.contract",
-        "contract.recurrency.mixin",
-        "portal.mixin",
     ]
 
-    active = fields.Boolean(
-        default=True,
-    )
-    code = fields.Char(
-        string="Reference",
+    # === Basic Information ===
+    active = fields.Boolean(default=True)
+    code = fields.Char(string="Reference")
+    name = fields.Char()
+    user_id = fields.Many2one(
+        comodel_name="res.users",
+        string="Responsible",
+        index=True,
+        default=lambda self: self.env.user,
     )
     group_id = fields.Many2one(
         string="Group",
         comodel_name="account.analytic.account",
         ondelete="restrict",
     )
+    tag_ids = fields.Many2many(comodel_name="contract.tag", string="Tags")
+    note = fields.Text(string="Notes")
+
+    # === Partner and Commercial Info ===
+    partner_id = fields.Many2one(
+        comodel_name="res.partner",
+        inverse="_inverse_partner_id",
+        required=True,
+    )
+    invoice_partner_id = fields.Many2one(
+        string="Invoicing contact",
+        comodel_name="res.partner",
+        ondelete="restrict",
+        domain="['|',('id', 'parent_of', partner_id), ('id', 'child_of', partner_id)]",
+    )
+    commercial_partner_id = fields.Many2one(
+        "res.partner",
+        compute_sudo=True,
+        related="partner_id.commercial_partner_id",
+        store=True,
+        string="Commercial Entity",
+        index=True,
+    )
+
+    # === Financial & Invoicing Info ===
     currency_id = fields.Many2one(
         compute="_compute_currency_id",
         inverse="_inverse_currency_id",
@@ -51,8 +79,25 @@ class ContractContract(models.Model):
         comodel_name="res.currency",
         readonly=True,
     )
+    payment_term_id = fields.Many2one(
+        comodel_name="account.payment.term",
+        string="Payment Terms",
+        index=True,
+    )
+    fiscal_position_id = fields.Many2one(
+        comodel_name="account.fiscal.position",
+        string="Fiscal Position",
+        ondelete="restrict",
+    )
+    invoice_count = fields.Integer(compute="_compute_invoice_count")
+    create_invoice_visibility = fields.Boolean(
+        compute="_compute_create_invoice_visibility"
+    )
+
+    # === Contract Template and Lines ===
     contract_template_id = fields.Many2one(
-        string="Contract Template", comodel_name="contract.template"
+        string="Contract Template",
+        comodel_name="contract.template",
     )
     contract_line_ids = fields.One2many(
         string="Contract lines",
@@ -61,11 +106,6 @@ class ContractContract(models.Model):
         copy=True,
         context={"active_test": False},
     )
-    # Trick for being able to have 2 different views for the same o2m
-    # We need this as one2many widget doesn't allow to define in the view
-    # the same field 2 times with different views. 2 views are needed because
-    # one of them must be editable inline and the other not, which can't be
-    # parametrized through attrs.
     contract_line_fixed_ids = fields.One2many(
         string="Contract lines (fixed)",
         comodel_name="contract.line",
@@ -73,188 +113,22 @@ class ContractContract(models.Model):
         context={"active_test": False},
     )
 
-    user_id = fields.Many2one(
-        comodel_name="res.users",
-        string="Responsible",
-        index=True,
-        default=lambda self: self.env.user,
-    )
-    create_invoice_visibility = fields.Boolean(
-        compute="_compute_create_invoice_visibility"
-    )
-    date_end = fields.Date(compute="_compute_date_end", store=True, readonly=False)
-    payment_term_id = fields.Many2one(
-        comodel_name="account.payment.term", string="Payment Terms", index=True
-    )
-    invoice_count = fields.Integer(compute="_compute_invoice_count")
-    fiscal_position_id = fields.Many2one(
-        comodel_name="account.fiscal.position",
-        string="Fiscal Position",
-        ondelete="restrict",
-    )
-    invoice_partner_id = fields.Many2one(
-        string="Invoicing contact",
-        comodel_name="res.partner",
-        ondelete="restrict",
-        domain="['|',('id', 'parent_of', partner_id), ('id', 'child_of', partner_id)]",
-    )
-    partner_id = fields.Many2one(
-        comodel_name="res.partner", inverse="_inverse_partner_id", required=True
-    )
-
-    commercial_partner_id = fields.Many2one(
-        "res.partner",
-        compute_sudo=True,
-        related="partner_id.commercial_partner_id",
-        store=True,
-        string="Commercial Entity",
-        index=True,
-    )
-    tag_ids = fields.Many2many(comodel_name="contract.tag", string="Tags")
-    note = fields.Text(string="Notes")
-    is_terminated = fields.Boolean(string="Terminated", readonly=True, copy=False)
-    terminate_reason_id = fields.Many2one(
-        comodel_name="contract.terminate.reason",
-        string="Termination Reason",
-        ondelete="restrict",
-        readonly=True,
-        copy=False,
-        tracking=True,
-    )
-    terminate_comment = fields.Text(
-        string="Termination Comment",
-        readonly=True,
-        copy=False,
-        tracking=True,
-    )
-    terminate_date = fields.Date(
-        string="Termination Date",
-        readonly=True,
-        copy=False,
-        tracking=True,
-    )
+    # === Modification tracking ===
     modification_ids = fields.One2many(
         comodel_name="contract.modification",
         inverse_name="contract_id",
         string="Modifications",
     )
 
-    def get_formview_id(self, access_uid=None):
-        if self.contract_type == "sale":
-            return self.env.ref("contract.contract_contract_customer_form_view").id
-        else:
-            return self.env.ref("contract.contract_contract_supplier_form_view").id
-
-    @api.model_create_multi
-    def create(self, vals_list):
-        records = super().create(vals_list)
-        records._set_start_contract_modification()
-        return records
-
-    def write(self, vals):
-        if "modification_ids" in vals:
-            res = super(
-                ContractContract, self.with_context(bypass_modification_send=True)
-            ).write(vals)
-            self._modification_mail_send()
-        else:
-            res = super().write(vals)
-        return res
-
-    @api.model
-    def _set_start_contract_modification(self):
-        subtype_id = self.env.ref("contract.mail_message_subtype_contract_modification")
-        for record in self:
-            if record.contract_line_ids:
-                date_start = min(record.contract_line_ids.mapped("date_start"))
-            else:
-                date_start = record.create_date
-            record.message_subscribe(
-                partner_ids=[record.partner_id.id], subtype_ids=[subtype_id.id]
-            )
-            record.with_context(skip_modification_mail=True).write(
-                {
-                    "modification_ids": [
-                        (0, 0, {"date": date_start, "description": _("Contract start")})
-                    ]
-                }
-            )
+    # === Dates ===
+    date_end = fields.Date(compute="_compute_date_end", store=True, readonly=False)
 
-    @api.model
-    def _modification_mail_send(self):
-        for record in self:
-            modification_ids_not_sent = record.modification_ids.filtered(
-                lambda x: not x.sent
-            )
-            if modification_ids_not_sent:
-                if not self.env.context.get("skip_modification_mail"):
-                    subtype_id = self.env["ir.model.data"]._xmlid_to_res_id(
-                        "contract.mail_message_subtype_contract_modification"
-                    )
-                    template_id = self.env.ref(
-                        "contract.mail_template_contract_modification"
-                    )
-                    record.message_post_with_source(
-                        template_id,
-                        subtype_id=subtype_id,
-                    )
-                modification_ids_not_sent.write({"sent": True})
+    # === Compute Methods ===
 
     def _compute_access_url(self):
         for record in self:
             record.access_url = f"/my/contracts/{record.id}"
 
-    def action_preview(self):
-        """Invoked when 'Preview' button in contract form view is clicked."""
-        self.ensure_one()
-        return {
-            "type": "ir.actions.act_url",
-            "target": "self",
-            "url": self.get_portal_url(),
-        }
-
-    def _inverse_partner_id(self):
-        for rec in self:
-            if not rec.invoice_partner_id:
-                rec.invoice_partner_id = rec.partner_id.address_get(["invoice"])[
-                    "invoice"
-                ]
-
-    def _get_related_invoices(self):
-        self.ensure_one()
-
-        invoices = (
-            self.env["account.move.line"]
-            .search(
-                [
-                    (
-                        "contract_line_id",
-                        "in",
-                        self.contract_line_ids.ids,
-                    )
-                ]
-            )
-            .mapped("move_id")
-        )
-        # we are forced to always search for this for not losing possible <=v11
-        # generated invoices
-        invoices |= self.env["account.move"].search([("old_contract_id", "=", self.id)])
-        return invoices
-
-    def _get_computed_currency(self):
-        """Helper method for returning the theoretical computed currency."""
-        self.ensure_one()
-        currency = self.env["res.currency"]
-        if any(self.contract_line_ids.mapped("automatic_price")):
-            # Use pricelist currency
-            currency = (
-                self.pricelist_id.currency_id
-                or self.partner_id.with_company(
-                    self.company_id
-                ).property_product_pricelist.currency_id
-            )
-        return currency or self.journal_id.currency_id or self.company_id.currency_id
-
     @api.depends(
         "manual_currency_id",
         "pricelist_id",
@@ -283,42 +157,16 @@ class ContractContract(models.Model):
         for rec in self:
             rec.invoice_count = len(rec._get_related_invoices())
 
-    def action_show_invoices(self):
-        self.ensure_one()
-        tree_view = self.env.ref("account.view_invoice_tree", raise_if_not_found=False)
-        form_view = self.env.ref("account.view_move_form", raise_if_not_found=False)
-        ctx = dict(self.env.context)
-        if ctx.get("default_contract_type"):
-            ctx["default_move_type"] = (
-                "out_invoice"
-                if ctx.get("default_contract_type") == "sale"
-                else "in_invoice"
-            )
-        action = {
-            "type": "ir.actions.act_window",
-            "name": "Invoices",
-            "res_model": "account.move",
-            "view_mode": "tree,kanban,form,calendar,pivot,graph,activity",
-            "domain": [("id", "in", self._get_related_invoices().ids)],
-            "context": ctx,
-        }
-        if tree_view and form_view:
-            action["views"] = [(tree_view.id, "tree"), (form_view.id, "form")]
-        return action
-
-    @api.depends("contract_line_ids.date_end")
-    def _compute_date_end(self):
-        for contract in self:
-            contract.date_end = False
-            date_end = contract.contract_line_ids.mapped("date_end")
-            if date_end and all(date_end):
-                contract.date_end = max(date_end)
-
     @api.depends(
+        "next_period_date_start",
+        "recurring_invoicing_type",
+        "recurring_invoicing_offset",
+        "recurring_rule_type",
+        "recurring_interval",
+        "date_end",
         "contract_line_ids.recurring_next_date",
         "contract_line_ids.is_canceled",
     )
-    # pylint: disable=missing-return
     def _compute_recurring_next_date(self):
         for contract in self:
             recurring_next_date = contract.contract_line_ids.filtered(
@@ -334,7 +182,14 @@ class ContractContract(models.Model):
                 and contract._origin.date_start != contract.date_start
                 or not recurring_next_date
             ):
-                super(ContractContract, contract)._compute_recurring_next_date()
+                contract.recurring_next_date = self.get_next_invoice_date(
+                    contract.next_period_date_start,
+                    contract.recurring_invoicing_type,
+                    contract.recurring_invoicing_offset,
+                    contract.recurring_rule_type,
+                    contract.recurring_interval,
+                    max_date_end=contract.date_end,
+                )
             else:
                 contract.recurring_next_date = min(recurring_next_date)
 
@@ -345,6 +200,23 @@ class ContractContract(models.Model):
                 contract.contract_line_ids.mapped("create_invoice_visibility")
             )
 
+    @api.depends("contract_line_ids.date_end")
+    def _compute_date_end(self):
+        for contract in self:
+            contract.date_end = False
+            date_end = contract.contract_line_ids.mapped("date_end")
+            if date_end and all(date_end):
+                contract.date_end = max(date_end)
+
+    def _inverse_partner_id(self):
+        for rec in self:
+            if not rec.invoice_partner_id:
+                rec.invoice_partner_id = rec.partner_id.address_get(["invoice"])[
+                    "invoice"
+                ]
+
+    # === Onchange Methods ===
+
     @api.onchange("contract_template_id")
     def _onchange_contract_template_id(self):
         """Update the contract fields with that of the template.
@@ -371,7 +243,10 @@ class ContractContract(models.Model):
                     field.name in self.NO_SYNC,
                 )
             ):
-                if self.contract_template_id[field_name]:
+                if (
+                    self.contract_template_id[field_name]
+                    and self.contract_template_id[field_name] != self[field_name]
+                ):
                     self[field_name] = self.contract_template_id[field_name]
 
     @api.onchange("partner_id", "company_id")
@@ -391,6 +266,180 @@ class ContractContract(models.Model):
             self.payment_term_id = partner.property_payment_term_id
         self.invoice_partner_id = self.partner_id.address_get(["invoice"])["invoice"]
 
+    # === CRUD ===
+    @api.model_create_multi
+    def create(self, vals_list):
+        records = super().create(vals_list)
+        records._set_start_contract_modification()
+        return records
+
+    def write(self, vals):
+        if "modification_ids" in vals:
+            res = super(
+                ContractContract, self.with_context(bypass_modification_send=True)
+            ).write(vals)
+            self._modification_mail_send()
+        else:
+            res = super().write(vals)
+        return res
+
+    # === Actions ===
+
+    def action_preview(self):
+        """Invoked when 'Preview' button in contract form view is clicked."""
+        self.ensure_one()
+        return {
+            "type": "ir.actions.act_url",
+            "target": "self",
+            "url": self.get_portal_url(),
+        }
+
+    def action_show_invoices(self):
+        self.ensure_one()
+        tree_view = self.env.ref("account.view_invoice_tree", raise_if_not_found=False)
+        form_view = self.env.ref("account.view_move_form", raise_if_not_found=False)
+        ctx = dict(self.env.context)
+        if ctx.get("default_contract_type"):
+            ctx["default_move_type"] = (
+                "out_invoice"
+                if ctx.get("default_contract_type") == "sale"
+                else "in_invoice"
+            )
+        action = {
+            "type": "ir.actions.act_window",
+            "name": "Invoices",
+            "res_model": "account.move",
+            "view_mode": "list,kanban,form,calendar,pivot,graph,activity",
+            "domain": [("id", "in", self._get_related_invoices().ids)],
+            "context": ctx,
+        }
+        if tree_view and form_view:
+            action["views"] = [(tree_view.id, "list"), (form_view.id, "form")]
+        return action
+
+    def action_contract_send(self):
+        self.ensure_one()
+        template = self.env.ref("contract.email_contract_template", False)
+        compose_form = self.env.ref("mail.email_compose_message_wizard_form")
+        ctx = dict(
+            default_model="contract.contract",
+            default_res_ids=self.ids,
+            default_use_template=bool(template),
+            default_template_id=template and template.id or False,
+            default_composition_mode="comment",
+        )
+        return {
+            "name": self.env._("Compose Email"),
+            "type": "ir.actions.act_window",
+            "view_mode": "form",
+            "res_model": "mail.compose.message",
+            "views": [(compose_form.id, "form")],
+            "view_id": compose_form.id,
+            "target": "new",
+            "context": ctx,
+        }
+
+    def recurring_create_invoice(self):
+        """
+        Button action
+        This method triggers the creation of the next invoices of the contracts
+        even if their next invoicing date is in the future.
+        """
+        self.ensure_one()
+        invoices = self._recurring_create_invoice()
+        for invoice in invoices:
+            body = Markup(
+                self.env._("Contract manually invoiced: %(invoice_link)s")
+            ) % {"invoice_link": invoice._get_html_link(title=invoice.name)}
+            self.message_post(body=body)
+        return invoices
+
+    # === Helpers and Utilities ===
+
+    def get_formview_id(self, access_uid=None):
+        if self.contract_type == "sale":
+            return self.env.ref("contract.contract_contract_customer_form_view").id
+        else:
+            return self.env.ref("contract.contract_contract_supplier_form_view").id
+
+    def _set_start_contract_modification(self):
+        subtype_id = self.env.ref("contract.mail_message_subtype_contract_modification")
+        for record in self:
+            if record.contract_line_ids:
+                date_start = min(record.contract_line_ids.mapped("date_start"))
+            else:
+                date_start = record.create_date
+            record.message_subscribe(
+                partner_ids=[record.partner_id.id], subtype_ids=[subtype_id.id]
+            )
+            record.with_context(skip_modification_mail=True).write(
+                {
+                    "modification_ids": [
+                        Command.create(
+                            {
+                                "date": date_start,
+                                "description": self.env._("Contract start"),
+                            }
+                        )
+                    ]
+                }
+            )
+
+    def _modification_mail_send(self):
+        for record in self:
+            modification_ids_not_sent = record.modification_ids.filtered(
+                lambda x: not x.sent
+            )
+            if modification_ids_not_sent:
+                if not self.env.context.get("skip_modification_mail"):
+                    subtype_id = self.env["ir.model.data"]._xmlid_to_res_id(
+                        "contract.mail_message_subtype_contract_modification"
+                    )
+                    template_id = self.env.ref(
+                        "contract.mail_template_contract_modification"
+                    )
+                    record.message_post_with_source(
+                        template_id,
+                        subtype_id=subtype_id,
+                        email_layout_xmlid="contract.template_contract_modification",
+                    )
+                modification_ids_not_sent.write({"sent": True})
+
+    def _get_related_invoices(self):
+        self.ensure_one()
+
+        invoices = (
+            self.env["account.move.line"]
+            .search(
+                [
+                    (
+                        "contract_line_id",
+                        "in",
+                        self.contract_line_ids.ids,
+                    )
+                ]
+            )
+            .mapped("move_id")
+        )
+        # we are forced to always search for this for not losing possible <=v11
+        # generated invoices
+        invoices |= self.env["account.move"].search([("old_contract_id", "=", self.id)])
+        return invoices
+
+    def _get_computed_currency(self):
+        """Helper method for returning the theoretical computed currency."""
+        self.ensure_one()
+        currency = self.env["res.currency"]
+        if any(self.contract_line_ids.mapped("automatic_price")):
+            # Use pricelist currency
+            currency = (
+                self.pricelist_id.currency_id
+                or self.partner_id.with_company(
+                    self.company_id
+                ).property_product_pricelist.currency_id
+            )
+        return currency or self.journal_id.currency_id or self.company_id.currency_id
+
     def _convert_contract_lines(self, contract):
         self.ensure_one()
         new_lines = self.env["contract.line"]
@@ -402,7 +451,6 @@ class ContractContract(models.Model):
             vals["date_start"] = fields.Date.context_today(contract_line)
             vals["recurring_next_date"] = fields.Date.context_today(contract_line)
             new_lines += contract_line_model.new(vals)
-        new_lines._onchange_is_auto_renew()
         return new_lines
 
     def _prepare_invoice(self, date_invoice, journal=None):
@@ -425,7 +473,7 @@ class ContractContract(models.Model):
             )
         if not journal:
             raise ValidationError(
-                _(
+                self.env._(
                     "Please define a %(contract_type)s journal "
                     "for the company '%(company)s'."
                 )
@@ -468,28 +516,6 @@ class ContractContract(models.Model):
             )
         return vals
 
-    def action_contract_send(self):
-        self.ensure_one()
-        template = self.env.ref("contract.email_contract_template", False)
-        compose_form = self.env.ref("mail.email_compose_message_wizard_form")
-        ctx = dict(
-            default_model="contract.contract",
-            default_res_ids=self.ids,
-            default_use_template=bool(template),
-            default_template_id=template and template.id or False,
-            default_composition_mode="comment",
-        )
-        return {
-            "name": _("Compose Email"),
-            "type": "ir.actions.act_window",
-            "view_mode": "form",
-            "res_model": "mail.compose.message",
-            "views": [(compose_form.id, "form")],
-            "view_id": compose_form.id,
-            "target": "new",
-            "context": ctx,
-        }
-
     @api.model
     def _get_contracts_to_invoice_domain(self, date_ref=None):
         """
@@ -579,22 +605,9 @@ class ContractContract(models.Model):
                     )
             invoices_values.append(invoice_vals)
             # Force the recomputation of journal items
-            contract_lines._update_recurring_next_date()
+            contract_lines._update_last_date_invoiced()
         return invoices_values
 
-    def recurring_create_invoice(self):
-        """
-        This method triggers the creation of the next invoices of the contracts
-        even if their next invoicing date is in the future.
-        """
-        invoices = self._recurring_create_invoice()
-        for invoice in invoices:
-            body = Markup(_("Contract manually invoiced: %(invoice_link)s")) % {
-                "invoice_link": invoice._get_html_link(title=invoice.name)
-            }
-            self.message_post(body=body)
-        return invoices
-
     @api.model
     def _invoice_followers(self, invoices):
         invoice_create_subtype = self.env.ref(
@@ -613,7 +626,7 @@ class ContractContract(models.Model):
     def _add_contract_origin(self, invoices):
         for item in self:
             for move in invoices & item._get_related_invoices():
-                translation = _("by contract")
+                translation = self.env._("by contract")
                 move.message_post(
                     body=Markup(
                         f"{move._creation_message()} {translation} "
@@ -673,52 +686,3 @@ class ContractContract(models.Model):
     @api.model
     def cron_recurring_create_invoice(self, date_ref=None):
         return self._cron_recurring_create(date_ref, create_type="invoice")
-
-    def action_terminate_contract(self):
-        self.ensure_one()
-        context = {"default_contract_id": self.id}
-        return {
-            "type": "ir.actions.act_window",
-            "name": _("Terminate Contract"),
-            "res_model": "contract.contract.terminate",
-            "view_mode": "form",
-            "target": "new",
-            "context": context,
-        }
-
-    def _terminate_contract(
-        self,
-        terminate_reason_id,
-        terminate_comment,
-        terminate_date,
-        terminate_lines_with_last_date_invoiced=False,
-    ):
-        self.ensure_one()
-        if not self.env.user.has_group("contract.can_terminate_contract"):
-            raise UserError(_("You are not allowed to terminate contracts."))
-        for line in self.contract_line_ids.filtered("is_stop_allowed"):
-            line.stop(
-                max(terminate_date, line.last_date_invoiced)
-                if terminate_lines_with_last_date_invoiced and line.last_date_invoiced
-                else terminate_date
-            )
-        self.write(
-            {
-                "is_terminated": True,
-                "terminate_reason_id": terminate_reason_id.id,
-                "terminate_comment": terminate_comment,
-                "terminate_date": terminate_date,
-            }
-        )
-        return True
-
-    def action_cancel_contract_termination(self):
-        self.ensure_one()
-        self.write(
-            {
-                "is_terminated": False,
-                "terminate_reason_id": False,
-                "terminate_comment": False,
-                "terminate_date": False,
-            }
-        )