chrome-devtools-frontend 1.0.1402249 → 1.0.1418433

package/front_end/models/persistence/PlatformFileSystem.ts

@@ -3,8 +3,8 @@
 // found in the LICENSE file.
 
 import type * as Common from '../../core/common/common.js';
-import type * as Platform from '../../core/platform/platform.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import type * as Platform from '../../core/platform/platform.js';
 import type * as TextUtils from '../text_utils/text_utils.js';
 
 const UIStrings = {

package/front_end/models/persistence/WorkspaceSettingsTab.ts

@@ -2,9 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import '../../ui/components/cards/cards.js';
+
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
-import * as Cards from '../../ui/components/cards/cards.js';
+import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
@@ -49,6 +51,7 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
 
   constructor() {
     super();
+    this.registerRequiredCSS(workspaceSettingsTabStyles);
 
     this.element.setAttribute('jslog', `${VisualLogging.pane('workspace')}`);
 
@@ -67,12 +70,9 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
     mappingsAreInferredInfo.classList.add('mappings-info');
     UI.UIUtils.createTextChild(mappingsAreInferredInfo, i18nString(UIStrings.mappingsAreInferredAutomatically));
 
-    const card = new Cards.Card.Card();
-    this.containerElement.appendChild(card);
-    card.data = {
-      heading: i18nString(UIStrings.workspace),
-      content: [folderExcludePatternInput, mappingsAreInferredInfo],
-    };
+    const card = this.containerElement.createChild('devtools-card');
+    card.heading = i18nString(UIStrings.workspace);
+    card.append(folderExcludePatternInput, mappingsAreInferredInfo);
 
     this.elementByPath = new Map();
     this.mappingViewByPath = new Map();
@@ -90,11 +90,6 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
     this.#addButtonContainer.appendChild(addButton);
   }
 
-  override wasShown(): void {
-    super.wasShown();
-    this.registerCSSFiles([workspaceSettingsTabStyles]);
-  }
-
   private createFolderExcludePatternInput(): HTMLElement {
     const excludePatternElement = document.createElement('div');
     excludePatternElement.classList.add('folder-exclude-pattern');
@@ -114,7 +109,7 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
       let regex;
       try {
         regex = new RegExp(value);
-      } catch (e) {
+      } catch {
       }
       const valid = Boolean(regex);
       return {valid, errorMessage: undefined};
@@ -136,17 +131,16 @@ export class WorkspaceSettingsTab extends UI.Widget.VBox {
     const removeButton = UI.UIUtils.createTextButton(
         i18nString(UIStrings.remove), this.removeFileSystemClicked.bind(this, fileSystem),
         {jslogContext: 'settings.remove-file-system'});
+    removeButton.slot = 'heading-suffix';
+    const folderIcon = IconButton.Icon.create('folder');
+    folderIcon.slot = 'heading-prefix';
 
     const mappingViewContainer = document.createElement('div');
     mappingViewContainer.classList.add('mapping-view-container');
-    const fileSystemExcludeCard = new Cards.Card.Card();
+    const fileSystemExcludeCard = document.createElement('devtools-card');
+    fileSystemExcludeCard.heading = filename;
+    fileSystemExcludeCard.append(folderIcon, removeButton, mappingViewContainer);
     this.containerElement.insertBefore(fileSystemExcludeCard, this.#addButtonContainer);
-    fileSystemExcludeCard.data = {
-      heading: filename,
-      headingIconName: 'folder',
-      headingSuffix: removeButton,
-      content: [mappingViewContainer],
-    };
     const mappingView = new EditFileSystemView(fileSystem.path());
     this.mappingViewByPath.set(fileSystem.path(), mappingView);
     mappingView.element.classList.add('file-system-mapping-view');

package/front_end/models/project_settings/ProjectSettingsModel.test.ts

@@ -0,0 +1,138 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Platform from '../../core/platform/platform.js';
+import * as SDK from '../../core/sdk/sdk.js';
+
+import * as ProjectSettings from './project_settings.js';
+
+const {urlString} = Platform.DevToolsPath;
+
+describe('ProjectSettingsModel', () => {
+  const {ProjectSettingsModel} = ProjectSettings.ProjectSettingsModel;
+
+  afterEach(() => {
+    ProjectSettingsModel.removeInstance();
+  });
+
+  it('yields an empty configuration initially', () => {
+    const hostConfig = {devToolsWellKnown: {enabled: true}};
+    const pageResourceLoader = sinon.createStubInstance(SDK.PageResourceLoader.PageResourceLoader);
+    const targetManager = sinon.createStubInstance(SDK.TargetManager.TargetManager);
+
+    const projectSettingsModel = ProjectSettingsModel.instance({
+      forceNew: true,
+      hostConfig,
+      pageResourceLoader,
+      targetManager,
+    });
+
+    assert.deepEqual(projectSettingsModel.projectSettings, {});
+  });
+
+  it('yields an empty configuration if `devToolsWellKnown` is disabled', () => {
+    const hostConfig = {devToolsWellKnown: {enabled: false}};
+    const pageResourceLoader = sinon.createStubInstance(SDK.PageResourceLoader.PageResourceLoader);
+    const targetManager = sinon.createStubInstance(SDK.TargetManager.TargetManager);
+
+    const projectSettingsModel = ProjectSettingsModel.instance({
+      forceNew: true,
+      hostConfig,
+      pageResourceLoader,
+      targetManager,
+    });
+
+    assert.deepEqual(projectSettingsModel.projectSettings, {});
+  });
+
+  it('doesn\'t load the devtools.json from non-local origins', async () => {
+    const hostConfig = {devToolsWellKnown: {enabled: true}};
+    const pageResourceLoader = sinon.createStubInstance(SDK.PageResourceLoader.PageResourceLoader);
+    const targetManager = sinon.createStubInstance(SDK.TargetManager.TargetManager);
+
+    const target = sinon.createStubInstance(SDK.Target.Target);
+    targetManager.primaryPageTarget.returns(target);
+
+    const resourceTreeModel = sinon.createStubInstance(SDK.ResourceTreeModel.ResourceTreeModel);
+    target.model.withArgs(SDK.ResourceTreeModel.ResourceTreeModel).returns(resourceTreeModel);
+
+    const frame = sinon.createStubInstance(SDK.ResourceTreeModel.ResourceTreeFrame);
+    resourceTreeModel.mainFrame = frame;
+    sinon.stub(frame, 'securityOriginDetails').get(() => ({isLocalhost: false}));
+
+    const projectSettingsModel = ProjectSettingsModel.instance({
+      forceNew: true,
+      hostConfig,
+      pageResourceLoader,
+      targetManager,
+    });
+
+    const projectSettings = await projectSettingsModel.projectSettingsPromise;
+    assert.deepEqual(projectSettings, {});
+  });
+
+  it('correctly loads the devtools.json from local origins', async () => {
+    const hostConfig = {devToolsWellKnown: {enabled: true}};
+    const pageResourceLoader = sinon.createStubInstance(SDK.PageResourceLoader.PageResourceLoader);
+    const targetManager = sinon.createStubInstance(SDK.TargetManager.TargetManager);
+
+    const target = sinon.createStubInstance(SDK.Target.Target);
+    targetManager.primaryPageTarget.returns(target);
+
+    const resourceTreeModel = sinon.createStubInstance(SDK.ResourceTreeModel.ResourceTreeModel);
+    target.model.withArgs(SDK.ResourceTreeModel.ResourceTreeModel).returns(resourceTreeModel);
+
+    const url = urlString`http://localhost:8090/.well-known/appspecific/com.chrome.devtools.json`;
+    const frameId = 'frame1';
+    const initiatorUrl = urlString`http://localhost:8090/foo`;
+    const frame = sinon.createStubInstance(SDK.ResourceTreeModel.ResourceTreeFrame);
+    resourceTreeModel.mainFrame = frame;
+    sinon.stub(frame, 'securityOriginDetails').get(() => ({isLocalhost: true}));
+    sinon.stub(frame, 'url').get(() => initiatorUrl);
+    sinon.stub(frame, 'id').get(() => frameId);
+
+    pageResourceLoader.loadResource.withArgs(url, sinon.match({target, frameId, initiatorUrl}))
+        .returns(Promise.resolve({content: '{"workspace":{"root":"/home/foo"}}'}));
+
+    const projectSettingsModel = ProjectSettingsModel.instance({
+      forceNew: true,
+      hostConfig,
+      pageResourceLoader,
+      targetManager,
+    });
+
+    const projectSettings = await projectSettingsModel.projectSettingsPromise;
+    assert.deepEqual(projectSettings, {workspace: {root: '/home/foo'}});
+  });
+
+  it('listens for navigations', () => {
+    const hostConfig = {devToolsWellKnown: {enabled: true}};
+    const pageResourceLoader = sinon.createStubInstance(SDK.PageResourceLoader.PageResourceLoader);
+    const targetManager = sinon.createStubInstance(SDK.TargetManager.TargetManager);
+
+    ProjectSettingsModel.instance({
+      forceNew: true,
+      hostConfig,
+      pageResourceLoader,
+      targetManager,
+    });
+
+    assert.isTrue(targetManager.addEventListener.calledOnceWith(SDK.TargetManager.Events.INSPECTED_URL_CHANGED));
+  });
+
+  it('doesn\'t listen for navigations if `devToolsWellKnown` is disabled', () => {
+    const hostConfig = {devToolsWellKnown: {enabled: false}};
+    const pageResourceLoader = sinon.createStubInstance(SDK.PageResourceLoader.PageResourceLoader);
+    const targetManager = sinon.createStubInstance(SDK.TargetManager.TargetManager);
+
+    ProjectSettingsModel.instance({
+      forceNew: true,
+      hostConfig,
+      pageResourceLoader,
+      targetManager,
+    });
+
+    assert.isTrue(targetManager.addEventListener.notCalled);
+  });
+});

package/front_end/models/project_settings/ProjectSettingsModel.ts

@@ -0,0 +1,157 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Common from '../../core/common/common.js';
+import * as Platform from '../../core/platform/platform.js';
+import type * as Root from '../../core/root/root.js';
+import * as SDK from '../../core/sdk/sdk.js';
+
+/**
+ * The structure of the project settings.
+ *
+ * @see https://goo.gle/devtools-json-design
+ */
+export interface ProjectSettings {
+  readonly workspace?: {readonly root?: string};
+}
+
+const EMPTY_PROJECT_SETTINGS: ProjectSettings = Object.freeze({});
+const IDLE_PROMISE: Promise<void> = Promise.resolve();
+
+let projectSettingsModelInstance: ProjectSettingsModel|undefined;
+
+export class ProjectSettingsModel extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
+  readonly #pageResourceLoader: SDK.PageResourceLoader.PageResourceLoader;
+  readonly #targetManager: SDK.TargetManager.TargetManager;
+  #projectSettings: ProjectSettings = EMPTY_PROJECT_SETTINGS;
+  #promise: Promise<void> = IDLE_PROMISE;
+
+  /**
+   * Yields the current project settings.
+   *
+   * @return the current project settings.
+   */
+  get projectSettings(): ProjectSettings {
+    return this.#projectSettings;
+  }
+
+  get projectSettingsPromise(): Promise<ProjectSettings> {
+    return this.#promise.then(() => this.#projectSettings);
+  }
+
+  private constructor(
+      hostConfig: Root.Runtime.HostConfig,
+      pageResourceLoader: SDK.PageResourceLoader.PageResourceLoader,
+      targetManager: SDK.TargetManager.TargetManager,
+  ) {
+    super();
+    this.#pageResourceLoader = pageResourceLoader;
+    this.#targetManager = targetManager;
+    if (hostConfig.devToolsWellKnown?.enabled) {
+      this.#targetManager.addEventListener(
+          SDK.TargetManager.Events.INSPECTED_URL_CHANGED,
+          this.#inspectedURLChanged,
+          this,
+      );
+      const target = this.#targetManager.primaryPageTarget();
+      if (target !== null) {
+        this.#inspectedURLChanged({data: target});
+      }
+    }
+  }
+
+  /**
+   * Yields the `ProjectSettingsModel` singleton.
+   *
+   * @returns the singleton.
+   */
+  static instance({forceNew, hostConfig, pageResourceLoader, targetManager}: {
+    forceNew: boolean|null,
+    hostConfig: Root.Runtime.HostConfig|null,
+    pageResourceLoader: SDK.PageResourceLoader.PageResourceLoader|null,
+    targetManager: SDK.TargetManager.TargetManager|null,
+  }): ProjectSettingsModel {
+    if (!projectSettingsModelInstance || forceNew) {
+      if (!hostConfig || !pageResourceLoader || !targetManager) {
+        throw new Error(
+            'Unable to create ProjectSettingsModel: ' +
+            'hostConfig, pageResourceLoader, and targetManager must be provided');
+      }
+      projectSettingsModelInstance = new ProjectSettingsModel(hostConfig, pageResourceLoader, targetManager);
+    }
+    return projectSettingsModelInstance;
+  }
+
+  /**
+   * Clears the `ProjectSettingsModel` singleton (if any).
+   */
+  static removeInstance(): void {
+    if (projectSettingsModelInstance) {
+      projectSettingsModelInstance.#dispose();
+      projectSettingsModelInstance = undefined;
+    }
+  }
+
+  #dispose(): void {
+    this.#targetManager.removeEventListener(
+        SDK.TargetManager.Events.INSPECTED_URL_CHANGED,
+        this.#inspectedURLChanged,
+        this,
+    );
+  }
+
+  #inspectedURLChanged(event: Common.EventTarget.EventTargetEvent<SDK.Target.Target>): void {
+    const target = event.data;
+
+    const promise = this.#promise = this.#promise.then(async(): Promise<void> => {
+      let projectSettings: ProjectSettings = EMPTY_PROJECT_SETTINGS;
+      try {
+        projectSettings = await this.#loadAndValidateProjectSettings(target);
+      } catch (error) {
+        // eslint-disable-next-line no-console
+        console.debug(`Could not load project settings for ${target.inspectedURL()}: ${error.message}`);
+      }
+      if (this.#promise === promise) {
+        if (this.#projectSettings !== projectSettings) {
+          this.#projectSettings = projectSettings;
+          this.dispatchEventToListeners(Events.PROJECT_SETTINGS_CHANGED, projectSettings);
+        }
+        this.#promise = IDLE_PROMISE;
+      }
+    });
+  }
+
+  async #loadAndValidateProjectSettings(target: SDK.Target.Target): Promise<ProjectSettings> {
+    const frame = target.model(SDK.ResourceTreeModel.ResourceTreeModel)?.mainFrame;
+    if (!frame || !frame.securityOriginDetails?.isLocalhost) {
+      return EMPTY_PROJECT_SETTINGS;
+    }
+    const initiatorUrl = frame.url;
+    const frameId = frame.id;
+    const url = new URL('/.well-known/appspecific/com.chrome.devtools.json', initiatorUrl);
+    const {content} = await this.#pageResourceLoader.loadResource(
+        Platform.DevToolsPath.urlString`${url}`,
+        {target, frameId, initiatorUrl},
+    );
+    const devtoolsJSON = JSON.parse(content);
+    if (typeof devtoolsJSON.workspace !== 'undefined') {
+      const {workspace} = devtoolsJSON;
+      if (typeof workspace !== 'object' || workspace === null) {
+        throw new Error('Invalid "workspace" field');
+      }
+      if (!['string', 'undefined'].includes(typeof workspace.root)) {
+        throw new Error('Invalid "workspace.root" field');
+      }
+    }
+    return Object.freeze(devtoolsJSON);
+  }
+}
+
+export const enum Events {
+  PROJECT_SETTINGS_CHANGED = 'ProjectSettingsChanged',
+}
+
+export interface EventTypes {
+  [Events.PROJECT_SETTINGS_CHANGED]: ProjectSettings;
+}

package/front_end/models/project_settings/project_settings.ts

@@ -0,0 +1,9 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as ProjectSettingsModel from './ProjectSettingsModel.js';
+
+export {
+  ProjectSettingsModel,
+};

package/front_end/models/source_map_scopes/NamesResolver.test.ts

@@ -2,19 +2,22 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as Platform from '../../core/platform/platform.js';
+import * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import {createTarget} from '../../testing/EnvironmentHelpers.js';
 import {describeWithMockConnection} from '../../testing/MockConnection.js';
 import {MockProtocolBackend} from '../../testing/MockScopeChain.js';
+import {encodeVlqList} from '../../testing/SourceMapEncoder.js';
 import {createContentProviderUISourceCode} from '../../testing/UISourceCodeHelpers.js';
 import * as Bindings from '../bindings/bindings.js';
 import * as SourceMapScopes from '../source_map_scopes/source_map_scopes.js';
 import * as Workspace from '../workspace/workspace.js';
 
+const {urlString} = Platform.DevToolsPath;
+
 describeWithMockConnection('NameResolver', () => {
-  const URL = 'file:///tmp/example.js' as Platform.DevToolsPath.UrlString;
+  const URL = urlString`file:///tmp/example.js`;
   let target: SDK.Target.Target;
   let backend: MockProtocolBackend;
 
@@ -441,7 +444,12 @@ describeWithMockConnection('NameResolver', () => {
           '(function () {\n  function log(m) {\n    console.log(m);\n  }\n\n  function main() {\n\t  log("hello");\n\t  log("world");\n  }\n  \n  main();\n})();',
         ],
         mappings: 'CAAA,WACE,SAAS,EAAI,GACX,QAAQ,IAAI,EACd,CAEA,SAAS,IACR,EAAI,SACJ,EAAI,QACL,CAEA,GACD,EAXD',
-        x_com_bloomberg_sourcesFunctionMappings: ['AAAWK,CACAJ,CCCRE,CIAKA'],
+        x_com_bloomberg_sourcesFunctionMappings: [[
+          encodeVlqList([0, 0, 0, 11, 5]),
+          encodeVlqList([1, -11, 1, 11, -4]),
+          encodeVlqList([1, -10, 1, 2, 2]),
+          encodeVlqList([1, 2, 0, 3, 0]),
+        ].join(',')],
       });
 
       const source = '(function(){function o(o){console.log(o)}function n(){o("hello");o("world")}n()})();\n';

package/front_end/models/source_map_scopes/NamesResolver.ts

@@ -776,18 +776,16 @@ async function getFunctionNameFromScopeStart(
     return null;
   }
 
+  const scopeName = sourceMap.findOriginalFunctionName({line: lineNumber, column: columnNumber});
+  if (scopeName !== null) {
+    return scopeName;
+  }
+
   const mappingEntry = sourceMap.findEntry(lineNumber, columnNumber);
   if (!mappingEntry || !mappingEntry.sourceURL) {
     return null;
   }
 
-  const scopeName =
-      sourceMap.findScopeEntry(mappingEntry.sourceURL, mappingEntry.sourceLineNumber, mappingEntry.sourceColumnNumber)
-          ?.scopeName();
-  if (scopeName) {
-    return scopeName;
-  }
-
   const name = mappingEntry.name;
   if (!name) {
     return null;

package/front_end/models/source_map_scopes/ScopeChainModel.ts

@@ -68,9 +68,9 @@ export const enum Events {
   SCOPE_CHAIN_UPDATED = 'ScopeChainUpdated',
 }
 
-export type EventTypes = {
-  [Events.SCOPE_CHAIN_UPDATED]: ScopeChain,
-};
+export interface EventTypes {
+  [Events.SCOPE_CHAIN_UPDATED]: ScopeChain;
+}
 
 /**
  * A scope chain ready to be shown in the UI with debugging info applied.

package/front_end/models/text_utils/StaticContentProvider.test.ts

@@ -3,13 +3,15 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import type * as Platform from '../../core/platform/platform.js';
+import * as Platform from '../../core/platform/platform.js';
 
 import * as TextUtils from './text_utils.js';
 
+const {urlString} = Platform.DevToolsPath;
+
 describe('StaticContentProvider', () => {
   const jsonResource = Common.ResourceType.ResourceType.fromMimeType('application/json');
-  const testUrl = 'www.testurl.com' as Platform.DevToolsPath.UrlString;
+  const testUrl = urlString`www.testurl.com`;
 
   it('can be created from a string source', () => {
     const provider =

package/front_end/models/text_utils/StreamingContentData.ts

@@ -103,6 +103,6 @@ export const enum Events {
   CHUNK_ADDED = 'ChunkAdded',
 }
 
-export type EventTypes = {
-  [Events.CHUNK_ADDED]: {content: StreamingContentData, chunk: string},
-};
+export interface EventTypes {
+  [Events.CHUNK_ADDED]: {content: StreamingContentData, chunk: string};
+}

package/front_end/models/text_utils/TextUtils.ts

@@ -155,7 +155,7 @@ export class FilterParser {
             text: undefined,
             negative: Boolean(startsWithMinus),
           });
-        } catch (e) {
+        } catch {
           parsedFilters.push({
             key: undefined,
             regex: undefined,

package/front_end/models/trace/LanternComputationData.ts

@@ -23,14 +23,14 @@ function createProcessedNavigation(parsedTrace: Handlers.Types.ParsedTrace, fram
   }
 
   const getTimestampOrUndefined =
-      (metric: Handlers.ModelHandlers.PageLoadMetrics.MetricName): Types.Timing.MicroSeconds|undefined => {
+      (metric: Handlers.ModelHandlers.PageLoadMetrics.MetricName): Types.Timing.Micro|undefined => {
         const metricScore = scores.get(metric);
         if (!metricScore?.event) {
           return;
         }
         return metricScore.event.ts;
       };
-  const getTimestamp = (metric: Handlers.ModelHandlers.PageLoadMetrics.MetricName): Types.Timing.MicroSeconds => {
+  const getTimestamp = (metric: Handlers.ModelHandlers.PageLoadMetrics.MetricName): Types.Timing.Micro => {
     const metricScore = scores.get(metric);
     if (!metricScore?.event) {
       throw new Lantern.Core.LanternError(`missing metric: ${metric}`);
@@ -94,7 +94,7 @@ function createLanternRequest(
   let url;
   try {
     url = new URL(request.args.data.url);
-  } catch (e) {
+  } catch {
     return;
   }
 
@@ -155,10 +155,11 @@ function createLanternRequest(
   // TODO: set decodedBodyLength for data urls in Trace Engine.
   let resourceSize = request.args.data.decodedBodyLength ?? 0;
   if (url.protocol === 'data:' && resourceSize === 0) {
-    const needle = 'base64,';
-    const index = url.pathname.indexOf(needle);
-    if (index !== -1) {
-      resourceSize = atob(url.pathname.substring(index + needle.length)).length;
+    const commaIndex = url.pathname.indexOf(',');
+    if (url.pathname.substring(0, commaIndex).includes(';base64')) {
+      resourceSize = atob(url.pathname.substring(commaIndex + 1)).length;
+    } else {
+      resourceSize = url.pathname.length - commaIndex - 1;
     }
   }
 
@@ -353,7 +354,7 @@ function createNetworkRequests(
     }
 
     // Apply the `:redirect` requestId convention: only redirects[0].requestId is the actual
-    // requestId, all the rest have n occurences of `:redirect` as a suffix.
+    // requestId, all the rest have n occurrences of `:redirect` as a suffix.
     for (let i = 1; i < requestChain.length; i++) {
       requestChain[i].requestId = `${requestChain[i - 1].requestId}:redirect`;
     }
@@ -427,7 +428,7 @@ function createGraph(
 }
 
 export {
-  createProcessedNavigation,
-  createNetworkRequests,
   createGraph,
+  createNetworkRequests,
+  createProcessedNavigation,
 };

package/front_end/models/trace/ModelImpl.test.ts

@@ -113,9 +113,9 @@ describeWithEnvironment('TraceModel', function() {
 
     const initialBreadcrumb = {
       window: {
-        max: 0 as Trace.Types.Timing.MicroSeconds,
-        min: 10 as Trace.Types.Timing.MicroSeconds,
-        range: 10 as Trace.Types.Timing.MicroSeconds,
+        max: 0 as Trace.Types.Timing.Micro,
+        min: 10 as Trace.Types.Timing.Micro,
+        range: 10 as Trace.Types.Timing.Micro,
       },
       child: null,
     };
@@ -135,9 +135,9 @@ describeWithEnvironment('TraceModel', function() {
       labelledTimeRanges: [
         {
           bounds: {
-            min: Trace.Types.Timing.MicroSeconds(0),
-            max: Trace.Types.Timing.MicroSeconds(10),
-            range: Trace.Types.Timing.MicroSeconds(10),
+            min: Trace.Types.Timing.Micro(0),
+            max: Trace.Types.Timing.Micro(10),
+            range: Trace.Types.Timing.Micro(10),
           },
           label: 'range label',
         },

package/front_end/models/trace/ModelImpl.ts

@@ -222,18 +222,18 @@ export const enum ModelUpdateType {
 
 export type ModelUpdateEventData = ModelUpdateEventComplete|ModelUpdateEventProgress;
 
-export type ModelUpdateEventComplete = {
-  type: ModelUpdateType.COMPLETE,
-  data: 'done',
-};
-export type ModelUpdateEventProgress = {
-  type: ModelUpdateType.PROGRESS_UPDATE,
-  data: TraceParseEventProgressData,
-};
+export interface ModelUpdateEventComplete {
+  type: ModelUpdateType.COMPLETE;
+  data: 'done';
+}
+export interface ModelUpdateEventProgress {
+  type: ModelUpdateType.PROGRESS_UPDATE;
+  data: TraceParseEventProgressData;
+}
 
-export type TraceParseEventProgressData = {
-  percent: number,
-};
+export interface TraceParseEventProgressData {
+  percent: number;
+}
 
 export class ModelUpdateEvent extends Event {
   static readonly eventName = 'modelupdate';
@@ -251,7 +251,3 @@ declare global {
 export function isModelUpdateDataComplete(eventData: ModelUpdateEventData): eventData is ModelUpdateEventComplete {
   return eventData.type === ModelUpdateType.COMPLETE;
 }
-
-export function isModelUpdateDataProgress(eventData: ModelUpdateEventData): eventData is ModelUpdateEventProgress {
-  return eventData.type === ModelUpdateType.PROGRESS_UPDATE;
-}

package/front_end/models/trace/Processor.test.ts

@@ -261,6 +261,10 @@ describeWithEnvironment('TraceProcessor', function() {
       sinon.stub(Trace.Processor.TraceProcessor, 'getEnabledInsightRunners').callsFake(() => {
         return {
           RenderBlocking: {
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            UIStrings: {} as any,
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            i18nString: (() => {}) as any,
             generateInsight: () => {
               throw new Error('forced error');
             },
@@ -408,6 +412,8 @@ describeWithEnvironment('TraceProcessor', function() {
         'DOMSize',
         'ThirdParties',
         'SlowCSSSelector',
+        'LongCriticalNetworkTree',
+        'ForcedReflow',
       ]);
 
       const orderWithMetadata = await getInsightOrder(true);
@@ -425,6 +431,8 @@ describeWithEnvironment('TraceProcessor', function() {
         'DOMSize',
         'ThirdParties',
         'SlowCSSSelector',
+        'LongCriticalNetworkTree',
+        'ForcedReflow',
       ]);
     });
   });