chrome-devtools-frontend 1.0.1380117 → 1.0.1386602

package/front_end/panels/freestyler/AiHistoryStorage.test.ts

@@ -0,0 +1,159 @@
+// Copyright 2023 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {
+  describeWithEnvironment,
+} from '../../testing/EnvironmentHelpers.js';
+
+import * as Freestyler from './freestyler.js';
+
+describeWithEnvironment('Freestyler.AiHistoryStorage', () => {
+  const agent1: Freestyler.SerializedAgent = {
+    id: 'id1',
+    type: Freestyler.AgentType.FREESTYLER,
+    history: [],
+  };
+  const agent2: Freestyler.SerializedAgent = {
+    id: 'id2',
+    type: Freestyler.AgentType.DRJONES_FILE,
+    history: [],
+  };
+  const agent3: Freestyler.SerializedAgent = {
+    id: 'id3',
+    type: Freestyler.AgentType.DRJONES_NETWORK_REQUEST,
+    history: [],
+  };
+
+  afterEach(() => {
+    Freestyler.AiHistoryStorage.instance().clearForTest();
+  });
+
+  it('should create and retrieve history entry', async () => {
+    const storage = Freestyler.AiHistoryStorage.instance();
+    await storage.upsertHistoryEntry(agent1);
+    assert.deepEqual(
+        storage.getHistory(),
+        [{
+          id: 'id1',
+          type: 'freestyler' as Freestyler.AgentType,
+          history: [],
+        }],
+    );
+    await storage.upsertHistoryEntry(agent2);
+    assert.deepEqual(
+        storage.getHistory(),
+        [
+          {
+            id: 'id1',
+            type: 'freestyler' as Freestyler.AgentType,
+            history: [],
+          },
+          {
+            id: 'id2',
+            type: 'drjones-file' as Freestyler.AgentType,
+            history: [],
+          },
+        ],
+    );
+  });
+
+  it('should update history entries correctly', async () => {
+    const storage = Freestyler.AiHistoryStorage.instance();
+    await storage.upsertHistoryEntry(agent1);
+    await storage.upsertHistoryEntry(agent2);
+    await storage.upsertHistoryEntry({
+      ...agent1,
+      history: [
+        {
+          type: Freestyler.ResponseType.USER_QUERY,
+          query: 'text',
+        },
+      ],
+    });
+    assert.deepEqual(
+        storage.getHistory(),
+        [
+          {
+            id: 'id1',
+            type: 'freestyler' as Freestyler.AgentType,
+            history: [
+              {
+                type: Freestyler.ResponseType.USER_QUERY,
+                query: 'text',
+              },
+            ],
+          },
+          {
+            id: 'id2',
+            type: 'drjones-file' as Freestyler.AgentType,
+            history: [],
+          },
+        ],
+    );
+
+    await storage.upsertHistoryEntry(agent3);
+    assert.deepEqual(
+        storage.getHistory(),
+        [
+          {
+            id: 'id1',
+            type: 'freestyler' as Freestyler.AgentType,
+            history: [
+              {
+                type: Freestyler.ResponseType.USER_QUERY,
+                query: 'text',
+              },
+            ],
+          },
+          {
+            id: 'id2',
+            type: 'drjones-file' as Freestyler.AgentType,
+            history: [],
+          },
+          {
+            id: 'id3',
+            type: 'drjones-network-request' as Freestyler.AgentType,
+            history: [],
+          },
+        ],
+    );
+  });
+
+  it('should delete a single entry', async () => {
+    const storage = Freestyler.AiHistoryStorage.instance();
+    await storage.upsertHistoryEntry(agent1);
+    await storage.upsertHistoryEntry(agent2);
+    await storage.upsertHistoryEntry(agent3);
+    await storage.deleteHistoryEntry('id2');
+    assert.deepEqual(
+        storage.getHistory(),
+        [
+          {
+            id: 'id1',
+            type: 'freestyler' as Freestyler.AgentType,
+            history: [
+
+            ],
+          },
+          {
+            id: 'id3',
+            type: 'drjones-network-request' as Freestyler.AgentType,
+            history: [],
+          },
+        ],
+    );
+  });
+
+  it('should delete all entries', async () => {
+    const storage = Freestyler.AiHistoryStorage.instance();
+    await storage.upsertHistoryEntry(agent1);
+    await storage.upsertHistoryEntry(agent2);
+    await storage.upsertHistoryEntry(agent3);
+    await storage.deleteAll();
+    assert.deepEqual(
+        storage.getHistory(),
+        [],
+    );
+  });
+});

package/front_end/panels/freestyler/AiHistoryStorage.ts

@@ -0,0 +1,73 @@
+
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Common from '../../core/common/common.js';
+
+import type {SerializedAgent} from './AiAgent.js';
+
+let instance: AiHistoryStorage|null = null;
+export class AiHistoryStorage {
+  #historySetting: Common.Settings.Setting<SerializedAgent[]>;
+  #mutex = new Common.Mutex.Mutex();
+
+  constructor() {
+    this.#historySetting = Common.Settings.Settings.instance().createSetting(
+        'ai-assistance-history-entries',
+        [],
+    );
+  }
+
+  clearForTest(): void {
+    this.#historySetting.set([]);
+  }
+
+  async upsertHistoryEntry(agentEntry: SerializedAgent): Promise<void> {
+    const release = await this.#mutex.acquire();
+    try {
+      const history = await this.#historySetting.forceGet();
+      const historyEntryIndex = history.findIndex(entry => entry.id === agentEntry.id);
+      if (historyEntryIndex !== -1) {
+        history[historyEntryIndex] = agentEntry;
+      } else {
+        history.push(agentEntry);
+      }
+      this.#historySetting.set(history);
+    } finally {
+      release();
+    }
+  }
+
+  async deleteHistoryEntry(id: string): Promise<void> {
+    const release = await this.#mutex.acquire();
+    try {
+      const history = await this.#historySetting.forceGet();
+      this.#historySetting.set(
+          history.filter(entry => entry.id !== id),
+      );
+    } finally {
+      release();
+    }
+  }
+
+  async deleteAll(): Promise<void> {
+    const release = await this.#mutex.acquire();
+    try {
+      this.#historySetting.set([]);
+    } finally {
+      release();
+    }
+  }
+
+  getHistory(): SerializedAgent[] {
+    return this.#historySetting.get();
+  }
+
+  static instance(): AiHistoryStorage {
+    if (!instance) {
+      instance = new AiHistoryStorage();
+    }
+    return instance;
+  }
+}

package/front_end/panels/freestyler/DrJonesFileAgent.test.ts

@@ -84,21 +84,20 @@ describeWithMockConnection('DrJonesFileAgent', () => {
         serverSideLoggingEnabled: true,
       });
       sinon.stub(agent, 'preamble').value('preamble');
-      agent.chatNewHistoryForTesting = new Map([
-        [
-          0,
-          [
-            {
-              type: ResponseType.QUERYING,
-              query: 'question',
-            },
-            {
-              type: ResponseType.ANSWER,
-              text: 'answer',
-            },
-          ],
-        ],
-      ]);
+      agent.chatNewHistoryForTesting = [
+        {
+          type: ResponseType.USER_QUERY,
+          query: 'question',
+        },
+        {
+          type: ResponseType.QUERYING,
+          query: 'question',
+        },
+        {
+          type: ResponseType.ANSWER,
+          text: 'answer',
+        },
+      ];
       assert.deepStrictEqual(
           agent.buildRequest({
             input: 'test input',

package/front_end/panels/freestyler/DrJonesFileAgent.ts

@@ -12,11 +12,11 @@ import * as PanelUtils from '../utils/utils.js';
 import {
   AgentType,
   AiAgent,
-  type AidaRequestOptions,
   type ContextDetail,
   type ContextResponse,
   ConversationContext,
   type ParsedResponse,
+  type RequestOptions,
   ResponseType,
 } from './AiAgent.js';
 
@@ -101,14 +101,14 @@ export class FileContext extends ConversationContext<Workspace.UISourceCode.UISo
  * instance for a new conversation.
  */
 export class DrJonesFileAgent extends AiAgent<Workspace.UISourceCode.UISourceCode> {
-  override type = AgentType.DRJONES_FILE;
+  override readonly type = AgentType.DRJONES_FILE;
   readonly preamble = preamble;
   readonly clientFeature = Host.AidaClient.ClientFeature.CHROME_DRJONES_FILE_AGENT;
   get userTier(): string|undefined {
     const config = Common.Settings.Settings.instance().getHostConfig();
     return config.devToolsAiAssistanceFileAgent?.userTier;
   }
-  get options(): AidaRequestOptions {
+  get options(): RequestOptions {
     const config = Common.Settings.Settings.instance().getHostConfig();
     const temperature = config.devToolsAiAssistanceFileAgent?.temperature;
     const modelId = config.devToolsAiAssistanceFileAgent?.modelId;
@@ -212,14 +212,3 @@ export function formatSourceMapDetails(
   }
   return sourceMapDetails;
 }
-
-function setDebugFreestylerEnabled(enabled: boolean): void {
-  if (enabled) {
-    localStorage.setItem('debugFreestylerEnabled', 'true');
-  } else {
-    localStorage.removeItem('debugFreestylerEnabled');
-  }
-}
-
-// @ts-ignore
-globalThis.setDebugFreestylerEnabled = setDebugFreestylerEnabled;

package/front_end/panels/freestyler/DrJonesNetworkAgent.test.ts

@@ -82,19 +82,20 @@ describeWithMockConnection('DrJonesNetworkAgent', () => {
         serverSideLoggingEnabled: true,
       });
       sinon.stub(agent, 'preamble').value('preamble');
-      agent.chatNewHistoryForTesting = new Map([[
-        0,
-        [
-          {
-            type: ResponseType.QUERYING,
-            query: 'questions',
-          },
-          {
-            type: ResponseType.ANSWER,
-            text: 'answer',
-          },
-        ],
-      ]]);
+      agent.chatNewHistoryForTesting = [
+        {
+          type: ResponseType.USER_QUERY,
+          query: 'questions',
+        },
+        {
+          type: ResponseType.QUERYING,
+          query: 'questions',
+        },
+        {
+          type: ResponseType.ANSWER,
+          text: 'answer',
+        },
+      ];
       assert.deepStrictEqual(
           agent.buildRequest({
             input: 'test input',

package/front_end/panels/freestyler/DrJonesNetworkAgent.ts

@@ -13,11 +13,11 @@ import * as PanelUtils from '../utils/utils.js';
 import {
   AgentType,
   AiAgent,
-  type AidaRequestOptions,
   type ContextDetail,
   type ContextResponse,
   ConversationContext,
   type ParsedResponse,
+  type RequestOptions,
   ResponseType,
 } from './AiAgent.js';
 
@@ -129,14 +129,14 @@ export class RequestContext extends ConversationContext<SDK.NetworkRequest.Netwo
  * instance for a new conversation.
  */
 export class DrJonesNetworkAgent extends AiAgent<SDK.NetworkRequest.NetworkRequest> {
-  override type = AgentType.DRJONES_NETWORK_REQUEST;
+  override readonly type = AgentType.DRJONES_NETWORK_REQUEST;
   readonly preamble = preamble;
   readonly clientFeature = Host.AidaClient.ClientFeature.CHROME_DRJONES_NETWORK_AGENT;
   get userTier(): string|undefined {
     const config = Common.Settings.Settings.instance().getHostConfig();
     return config.devToolsAiAssistanceNetworkAgent?.userTier;
   }
-  get options(): AidaRequestOptions {
+  get options(): RequestOptions {
     const config = Common.Settings.Settings.instance().getHostConfig();
     const temperature = config.devToolsAiAssistanceNetworkAgent?.temperature;
     const modelId = config.devToolsAiAssistanceNetworkAgent?.modelId;

package/front_end/panels/freestyler/DrJonesPerformanceAgent.test.ts

@@ -63,19 +63,20 @@ describeWithEnvironment('DrJonesPerformanceAgent', () => {
         serverSideLoggingEnabled: true,
       });
       sinon.stub(agent, 'preamble').value('preamble');
-      agent.chatNewHistoryForTesting = new Map([[
-        0,
-        [
-          {
-            type: ResponseType.QUERYING,
-            query: 'question',
-          },
-          {
-            type: ResponseType.ANSWER,
-            text: 'answer',
-          },
-        ],
-      ]]);
+      agent.chatNewHistoryForTesting = [
+        {
+          type: ResponseType.USER_QUERY,
+          query: 'question',
+        },
+        {
+          type: ResponseType.QUERYING,
+          query: 'question',
+        },
+        {
+          type: ResponseType.ANSWER,
+          text: 'answer',
+        },
+      ];
       assert.deepStrictEqual(
           agent.buildRequest({
             input: 'test input',
@@ -202,29 +203,30 @@ self: 3
       assert.strictEqual(enhancedQuery1, 'Mock call tree\n\n# User request\n\nWhat is this?');
 
       // Create history state of the above query
-      agent.chatNewHistoryForTesting = new Map([[
-        0,
-        [
-          {
-            type: ResponseType.CONTEXT,
-            title: 'Analyzing call tree',
-            details: [
-              {
-                title: 'Selected call tree',
-                text: mockAiCallTree.serialize(),
-              },
-            ],
-          },
-          {
-            type: ResponseType.QUERYING,
-            query: enhancedQuery1,
-          },
-          {
-            type: ResponseType.ANSWER,
-            text: 'test answer',
-          },
-        ],
-      ]]);
+      agent.chatNewHistoryForTesting = [
+        {
+          type: ResponseType.USER_QUERY,
+          query: 'What is this?',
+        },
+        {
+          type: ResponseType.CONTEXT,
+          title: 'Analyzing call tree',
+          details: [
+            {
+              title: 'Selected call tree',
+              text: mockAiCallTree.serialize(),
+            },
+          ],
+        },
+        {
+          type: ResponseType.QUERYING,
+          query: enhancedQuery1,
+        },
+        {
+          type: ResponseType.ANSWER,
+          text: 'test answer',
+        },
+      ];
 
       const query2 = 'But what about this follow-up question?';
       const enhancedQuery2 = await agent.enhanceQuery(query2, new CallTreeContext(mockAiCallTree));

package/front_end/panels/freestyler/DrJonesPerformanceAgent.ts

@@ -11,10 +11,10 @@ import * as PanelUtils from '../utils/utils.js';
 import {
   AgentType,
   AiAgent,
-  type AidaRequestOptions,
   type ContextResponse,
   ConversationContext,
   type ParsedResponse,
+  type RequestOptions,
   ResponseType,
 } from './AiAgent.js';
 
@@ -164,14 +164,14 @@ export class CallTreeContext extends ConversationContext<TimelineUtils.AICallTre
  * instance for a new conversation.
  */
 export class DrJonesPerformanceAgent extends AiAgent<TimelineUtils.AICallTree.AICallTree> {
-  override type = AgentType.DRJONES_PERFORMANCE;
+  override readonly type = AgentType.DRJONES_PERFORMANCE;
   readonly preamble = preamble;
   readonly clientFeature = Host.AidaClient.ClientFeature.CHROME_DRJONES_PERFORMANCE_AGENT;
   get userTier(): string|undefined {
     const config = Common.Settings.Settings.instance().getHostConfig();
     return config.devToolsAiAssistancePerformanceAgent?.userTier;
   }
-  get options(): AidaRequestOptions {
+  get options(): RequestOptions {
     const config = Common.Settings.Settings.instance().getHostConfig();
     const temperature = config.devToolsAiAssistancePerformanceAgent?.temperature;
     const modelId = config.devToolsAiAssistancePerformanceAgent?.modelId;
@@ -224,14 +224,3 @@ export class DrJonesPerformanceAgent extends AiAgent<TimelineUtils.AICallTree.AI
     };
   }
 }
-
-function setDebugFreestylerEnabled(enabled: boolean): void {
-  if (enabled) {
-    localStorage.setItem('debugFreestylerEnabled', 'true');
-  } else {
-    localStorage.removeItem('debugFreestylerEnabled');
-  }
-}
-
-// @ts-ignore
-globalThis.setDebugFreestylerEnabled = setDebugFreestylerEnabled;