chrome-devtools-frontend 1.0.1380117 → 1.0.1402249

package/front_end/third_party/puppeteer/package/src/node/PuppeteerNode.ts

@@ -14,10 +14,7 @@ import {
 
 import type {Browser} from '../api/Browser.js';
 import type {Configuration} from '../common/Configuration.js';
-import type {
-  ConnectOptions,
-  BrowserConnectOptions,
-} from '../common/ConnectOptions.js';
+import type {ConnectOptions} from '../common/ConnectOptions.js';
 import {type CommonPuppeteerSettings, Puppeteer} from '../common/Puppeteer.js';
 import type {SupportedBrowser} from '../common/SupportedBrowser.js';
 import {PUPPETEER_REVISIONS} from '../revisions.js';
@@ -25,22 +22,7 @@ import {PUPPETEER_REVISIONS} from '../revisions.js';
 import type {BrowserLauncher} from './BrowserLauncher.js';
 import {ChromeLauncher} from './ChromeLauncher.js';
 import {FirefoxLauncher} from './FirefoxLauncher.js';
-import type {
-  BrowserLaunchArgumentOptions,
-  ChromeReleaseChannel,
-  LaunchOptions,
-} from './LaunchOptions.js';
-
-/**
- * @public
- */
-export interface PuppeteerLaunchOptions
-  extends LaunchOptions,
-    BrowserLaunchArgumentOptions,
-    BrowserConnectOptions {
-  browser?: SupportedBrowser;
-  extraPrefsFirefox?: Record<string, unknown>;
-}
+import type {ChromeReleaseChannel, LaunchOptions} from './LaunchOptions.js';
 
 /**
  * Extends the main {@link Puppeteer} class with Node specific behaviour for
@@ -78,7 +60,7 @@ export interface PuppeteerLaunchOptions
  * @public
  */
 export class PuppeteerNode extends Puppeteer {
-  #_launcher?: BrowserLauncher;
+  #launcher?: BrowserLauncher;
   #lastLaunchedBrowser?: SupportedBrowser;
 
   /**
@@ -167,42 +149,68 @@ export class PuppeteerNode extends Puppeteer {
    *
    * @param options - Options to configure launching behavior.
    */
-  launch(options: PuppeteerLaunchOptions = {}): Promise<Browser> {
-    const {browser: product = this.defaultBrowser} = options;
-    this.#lastLaunchedBrowser = product;
+  launch(options: LaunchOptions = {}): Promise<Browser> {
+    const {browser = this.defaultBrowser} = options;
+    this.#lastLaunchedBrowser = browser;
+    switch (browser) {
+      case 'chrome':
+        this.defaultBrowserRevision = PUPPETEER_REVISIONS.chrome;
+        break;
+      case 'firefox':
+        this.defaultBrowserRevision = PUPPETEER_REVISIONS.firefox;
+        break;
+      default:
+        throw new Error(`Unknown product: ${browser}`);
+    }
+    this.#launcher = this.#getLauncher(browser);
     return this.#launcher.launch(options);
   }
 
   /**
    * @internal
    */
-  get #launcher(): BrowserLauncher {
-    if (
-      this.#_launcher &&
-      this.#_launcher.browser === this.lastLaunchedBrowser
-    ) {
-      return this.#_launcher;
+  #getLauncher(browser: SupportedBrowser): BrowserLauncher {
+    if (this.#launcher && this.#launcher.browser === browser) {
+      return this.#launcher;
     }
-    switch (this.lastLaunchedBrowser) {
+    switch (browser) {
       case 'chrome':
-        this.defaultBrowserRevision = PUPPETEER_REVISIONS.chrome;
-        this.#_launcher = new ChromeLauncher(this);
-        break;
+        return new ChromeLauncher(this);
       case 'firefox':
-        this.defaultBrowserRevision = PUPPETEER_REVISIONS.firefox;
-        this.#_launcher = new FirefoxLauncher(this);
-        break;
+        return new FirefoxLauncher(this);
       default:
-        throw new Error(`Unknown product: ${this.#lastLaunchedBrowser}`);
+        throw new Error(`Unknown product: ${browser}`);
     }
-    return this.#_launcher;
   }
 
+  /**
+   * The default executable path for a given ChromeReleaseChannel.
+   */
+  executablePath(channel: ChromeReleaseChannel): string;
+  /**
+   * The default executable path given LaunchOptions.
+   */
+  executablePath(options: LaunchOptions): string;
   /**
    * The default executable path.
    */
-  executablePath(channel?: ChromeReleaseChannel): string {
-    return this.#launcher.executablePath(channel);
+  executablePath(): string;
+  executablePath(optsOrChannel?: ChromeReleaseChannel | LaunchOptions): string {
+    if (optsOrChannel === undefined) {
+      return this.#getLauncher(this.lastLaunchedBrowser).executablePath(
+        undefined,
+        /* validatePath= */ false,
+      );
+    }
+    if (typeof optsOrChannel === 'string') {
+      return this.#getLauncher('chrome').executablePath(
+        optsOrChannel,
+        /* validatePath= */ false,
+      );
+    }
+    return this.#getLauncher(
+      optsOrChannel.browser ?? this.lastLaunchedBrowser,
+    ).resolveExecutablePath(optsOrChannel.headless, /* validatePath= */ false);
   }
 
   /**
@@ -250,16 +258,18 @@ export class PuppeteerNode extends Puppeteer {
    * @returns The name of the browser that is under automation.
    */
   get product(): string {
-    return this.#launcher.browser;
+    return this.lastLaunchedBrowser;
   }
 
   /**
    * @param options - Set of configurable options to set on the browser.
    *
-   * @returns The default flags that Chromium will be launched with.
+   * @returns The default arguments that the browser will be launched with.
    */
-  defaultArgs(options: BrowserLaunchArgumentOptions = {}): string[] {
-    return this.#launcher.defaultArgs(options);
+  defaultArgs(options: LaunchOptions = {}): string[] {
+    return this.#getLauncher(
+      options.browser ?? this.lastLaunchedBrowser,
+    ).defaultArgs(options);
   }
 
   /**

package/front_end/third_party/puppeteer/package/src/revisions.ts

@@ -8,7 +8,7 @@
  * @internal
  */
 export const PUPPETEER_REVISIONS = Object.freeze({
-  chrome: '130.0.6723.116',
-  'chrome-headless-shell': '130.0.6723.116',
-  firefox: 'stable_132.0.1',
+  chrome: '131.0.6778.204',
+  'chrome-headless-shell': '131.0.6778.204',
+  firefox: 'stable_133.0.3',
 });

package/front_end/third_party/puppeteer/puppeteer-tsconfig.json

@@ -104,6 +104,7 @@
     "package/lib/esm/puppeteer/common/CustomQueryHandler.js",
     "package/lib/esm/puppeteer/common/Debug.js",
     "package/lib/esm/puppeteer/common/Device.js",
+    "package/lib/esm/puppeteer/common/DownloadBehavior.js",
     "package/lib/esm/puppeteer/common/Errors.js",
     "package/lib/esm/puppeteer/common/EventEmitter.js",
     "package/lib/esm/puppeteer/common/FileChooser.js",

package/front_end/ui/components/adorners/Adorner.test.ts

@@ -12,7 +12,7 @@ const ADORNER_TAG_NAME = 'DEVTOOLS-ADORNER';
 describe('Adorner', () => {
   function assertIsAdorner(element: HTMLElement) {
     assert.strictEqual(element.tagName, ADORNER_TAG_NAME, `element tag name is not ${ADORNER_TAG_NAME}`);
-    assert.isTrue(element instanceof Adorners.Adorner.Adorner, 'element is not an instance of Adorner');
+    assert.instanceOf(element, Adorners.Adorner.Adorner, 'element is not an instance of Adorner');
     assert.strictEqual(
         Object.getPrototypeOf(element), Adorners.Adorner.Adorner.prototype,
         'element is not on Adorner\'s prototype chain');
@@ -127,7 +127,7 @@ describe('Adorner', () => {
     };
 
     const slottedChildren = adorner.querySelectorAll('[slot="content"]');
-    assert.strictEqual(slottedChildren.length, 1, 'adorner light dom should only have one child with [slot="content"]');
+    assert.lengthOf(slottedChildren, 1, 'adorner light dom should only have one child with [slot="content"]');
     assert.strictEqual(
         slottedChildren[0].textContent, 'content 3', 'adorner content slot should have the most recent content');
   });

package/front_end/ui/components/buttons/button.css

@@ -216,7 +216,7 @@ button {
     }
   }
 
-  &:not(.icon):not(.toolbar).only-icon {
+  &:not(.icon, .toolbar).only-icon {
     width: 100%;
     padding: 0;
 
@@ -252,11 +252,11 @@ button {
     background-color: var(--hover-layer-color); /* stylelint-disable-line plugin/use_theme_colors */
 
     &.primary {
-      border: var(--button-border-size) solid color-mix(in sRGB, var(--sys-color-primary), var(--sys-color-state-hover-on-prominent) 6%);
+      border: var(--button-border-size) solid color-mix(in srgb, var(--sys-color-primary), var(--sys-color-state-hover-on-prominent) 6%);
     }
 
     &.tonal {
-      background: color-mix(in sRGB, var(--sys-color-tonal-container), var(--sys-color-state-hover-on-subtle));
+      background: color-mix(in srgb, var(--sys-color-tonal-container), var(--sys-color-state-hover-on-subtle));
     }
 
     &.toobar {
@@ -278,11 +278,11 @@ button {
     background-color: var(--active-layer-color); /* stylelint-disable-line plugin/use_theme_colors */
 
     &.primary {
-      border: var(--button-border-size) solid color-mix(in sRGB, var(--sys-color-primary), var(--sys-color-state-ripple-primary) 32%);
+      border: var(--button-border-size) solid color-mix(in srgb, var(--sys-color-primary), var(--sys-color-state-ripple-primary) 32%);
     }
 
     &.tonal {
-      background: color-mix(in sRGB, var(--sys-color-tonal-container), var(--sys-color-state-ripple-primary) 50%);
+      background: color-mix(in srgb, var(--sys-color-tonal-container), var(--sys-color-state-ripple-primary) 50%);
     }
 
     &.toolbar {

package/front_end/ui/components/cards/Card.test.ts

@@ -16,7 +16,7 @@ import * as Cards from './cards.js';
 function assertCardContent(card: Cards.Card.Card, slotName: string, expectedContent: string[]) {
   const slot = getElementWithinComponent(card, `slot[name="${slotName}"]`, HTMLSlotElement);
   const textContents = Array.from(slot.assignedElements()).map(child => child.textContent);
-  assert.deepStrictEqual(textContents, expectedContent);
+  assert.deepEqual(textContents, expectedContent);
 }
 
 describe('Card', () => {

package/front_end/ui/components/cards/card.css

@@ -45,9 +45,9 @@ slot[name="heading-suffix"]::slotted(*) {
 }
 
 slot[name="content"]::slotted(*) {
-  padding: var(--sys-size-5) var(--sys-size-6);
+  padding: var(--sys-size-4) var(--sys-size-6);
 }
 
 slot[name="content"]::slotted(*:not(:first-child)) {
-  border-top: var(--sys-size-1) solid var(--sys-color-divider);
+  border-top: var(--sys-size-1) solid var(--app-color-card-divider);
 }

package/front_end/ui/components/chrome_link/ChromeLink.test.ts

@@ -7,14 +7,12 @@ import {renderElementIntoDOM} from '../../../testing/DOMHelpers.js';
 import {createTarget} from '../../../testing/EnvironmentHelpers.js';
 import {describeWithMockConnection} from '../../../testing/MockConnection.js';
 import * as LitHtml from '../../lit-html/lit-html.js';
-import * as Coordinator from '../render_coordinator/render_coordinator.js';
+import * as RenderCoordinator from '../render_coordinator/render_coordinator.js';
 
 import * as ChromeLink from './chrome_link.js';
 
 const {html} = LitHtml;
 
-const coordinator = Coordinator.RenderCoordinator.RenderCoordinator.instance();
-
 describeWithMockConnection('ChromeLink', () => {
   it('renders a link when given a \'chrome://\' URL', async () => {
     const target = createTarget();
@@ -32,7 +30,7 @@ describeWithMockConnection('ChromeLink', () => {
     );
     // clang-format on
     renderElementIntoDOM(container);
-    await coordinator.done();
+    await RenderCoordinator.done();
 
     const chromeLink = container.querySelector('devtools-chrome-link');
     assert.instanceOf(chromeLink, ChromeLink.ChromeLink.ChromeLink);

package/front_end/ui/components/chrome_link/ChromeLink.ts

@@ -63,7 +63,7 @@ export class ChromeLink extends HTMLElement {
     // clang-format off
     LitHtml.render(
       /* x-link doesn't work with custom click/keydown handlers */
-      /* eslint-disable rulesdir/ban_a_tags_in_lit_html */
+      /* eslint-disable rulesdir/no-a-tags-in-lit-html */
       html`
         <a href=${this.#href} class="link" target="_blank"
           jslog=${VisualLogging.link().track({click: true}).context(jslogContext)}