chrome-devtools-frontend 1.0.1380117 → 1.0.1402249

package/front_end/third_party/puppeteer/package/src/cdp/Accessibility.ts

@@ -99,6 +99,13 @@ export interface SnapshotOptions {
    * @defaultValue `true`
    */
   interestingOnly?: boolean;
+  /**
+   * If true, gets accessibility trees for each of the iframes in the frame
+   * subtree.
+   *
+   * @defaultValue `false`
+   */
+  includeIframes?: boolean;
   /**
    * Root node to get the accessibility tree for
    * @defaultValue The root node of the entire page.
@@ -130,12 +137,14 @@ export interface SnapshotOptions {
  */
 export class Accessibility {
   #realm: Realm;
+  #frameId: string;
 
   /**
    * @internal
    */
-  constructor(realm: Realm) {
+  constructor(realm: Realm, frameId = '') {
     this.#realm = realm;
+    this.#frameId = frameId;
   }
 
   /**
@@ -180,9 +189,16 @@ export class Accessibility {
   public async snapshot(
     options: SnapshotOptions = {},
   ): Promise<SerializedAXNode | null> {
-    const {interestingOnly = true, root = null} = options;
+    const {
+      interestingOnly = true,
+      root = null,
+      includeIframes = false,
+    } = options;
     const {nodes} = await this.#realm.environment.client.send(
       'Accessibility.getFullAXTree',
+      {
+        frameId: this.#frameId,
+      },
     );
     let backendNodeId: number | undefined;
     if (root) {
@@ -195,15 +211,44 @@ export class Accessibility {
       backendNodeId = node.backendNodeId;
     }
     const defaultRoot = AXNode.createTree(this.#realm, nodes);
+    const populateIframes = async (root: AXNode): Promise<void> => {
+      if (root.payload.role?.value === 'Iframe') {
+        if (!root.payload.backendDOMNodeId) {
+          return;
+        }
+        using handle = (await this.#realm.adoptBackendNode(
+          root.payload.backendDOMNodeId,
+        )) as ElementHandle<Element>;
+        if (!handle || !('contentFrame' in handle)) {
+          return;
+        }
+        const frame = await handle.contentFrame();
+        if (!frame) {
+          return;
+        }
+        const iframeSnapshot = await frame.accessibility.snapshot(options);
+        root.iframeSnapshot = iframeSnapshot ?? undefined;
+      }
+      for (const child of root.children) {
+        await populateIframes(child);
+      }
+    };
+
     let needle: AXNode | null = defaultRoot;
     if (!defaultRoot) {
       return null;
     }
+
+    if (includeIframes) {
+      await populateIframes(defaultRoot);
+    }
+
     if (backendNodeId) {
       needle = defaultRoot.find(node => {
         return node.payload.backendDOMNodeId === backendNodeId;
       });
     }
+
     if (!needle) {
       return null;
     }
@@ -237,6 +282,12 @@ export class Accessibility {
     if (children.length) {
       serializedNode.children = children;
     }
+    if (node.iframeSnapshot) {
+      if (!serializedNode.children) {
+        serializedNode.children = [];
+      }
+      serializedNode.children.push(node.iframeSnapshot);
+    }
     return [serializedNode];
   }
 
@@ -245,7 +296,7 @@ export class Accessibility {
     node: AXNode,
     insideControl: boolean,
   ): void {
-    if (node.isInteresting(insideControl)) {
+    if (node.isInteresting(insideControl) || node.iframeSnapshot) {
       collection.add(node);
     }
     if (node.isLeafNode()) {
@@ -261,6 +312,7 @@ export class Accessibility {
 class AXNode {
   public payload: Protocol.Accessibility.AXNode;
   public children: AXNode[] = [];
+  public iframeSnapshot?: SerializedAXNode;
 
   #richlyEditable = false;
   #editable = false;

package/front_end/third_party/puppeteer/package/src/cdp/Browser.ts

@@ -21,6 +21,7 @@ import {BrowserContextEvent} from '../api/BrowserContext.js';
 import {CDPSessionEvent, type CDPSession} from '../api/CDPSession.js';
 import type {Page} from '../api/Page.js';
 import type {Target} from '../api/Target.js';
+import type {DownloadBehavior} from '../common/DownloadBehavior.js';
 import type {Viewport} from '../common/Viewport.js';
 
 import {CdpBrowserContext} from './BrowserContext.js';
@@ -49,6 +50,7 @@ export class CdpBrowser extends BrowserBase {
     contextIds: string[],
     acceptInsecureCerts: boolean,
     defaultViewport?: Viewport | null,
+    downloadBehavior?: DownloadBehavior,
     process?: ChildProcess,
     closeCallback?: BrowserCloseCallback,
     targetFilterCallback?: TargetFilterCallback,
@@ -71,7 +73,7 @@ export class CdpBrowser extends BrowserBase {
         ignore: true,
       });
     }
-    await browser._attach();
+    await browser._attach(downloadBehavior);
     return browser;
   }
   #defaultViewport?: Viewport | null;
@@ -134,8 +136,11 @@ export class CdpBrowser extends BrowserBase {
     this.emit(BrowserEvent.Disconnected, undefined);
   };
 
-  async _attach(): Promise<void> {
+  async _attach(downloadBehavior: DownloadBehavior | undefined): Promise<void> {
     this.#connection.on(CDPSessionEvent.Disconnected, this.#emitDisconnected);
+    if (downloadBehavior) {
+      await this.#defaultContext.setDownloadBehavior(downloadBehavior);
+    }
     this.#targetManager.on(
       TargetManagerEvent.TargetAvailable,
       this.#onAttachedToTarget,
@@ -202,7 +207,7 @@ export class CdpBrowser extends BrowserBase {
   override async createBrowserContext(
     options: BrowserContextOptions = {},
   ): Promise<CdpBrowserContext> {
-    const {proxyServer, proxyBypassList} = options;
+    const {proxyServer, proxyBypassList, downloadBehavior} = options;
 
     const {browserContextId} = await this.#connection.send(
       'Target.createBrowserContext',
@@ -216,6 +221,9 @@ export class CdpBrowser extends BrowserBase {
       this,
       browserContextId,
     );
+    if (downloadBehavior) {
+      await context.setDownloadBehavior(downloadBehavior);
+    }
     this.#contexts.set(browserContextId, context);
     return context;
   }

package/front_end/third_party/puppeteer/package/src/cdp/BrowserConnector.ts

@@ -5,10 +5,7 @@
  */
 
 import type {ConnectionTransport} from '../common/ConnectionTransport.js';
-import type {
-  BrowserConnectOptions,
-  ConnectOptions,
-} from '../common/ConnectOptions.js';
+import type {ConnectOptions} from '../common/ConnectOptions.js';
 import {debugError, DEFAULT_VIEWPORT} from '../common/util.js';
 
 import {CdpBrowser} from './Browser.js';
@@ -23,11 +20,12 @@ import {Connection} from './Connection.js';
 export async function _connectToCdpBrowser(
   connectionTransport: ConnectionTransport,
   url: string,
-  options: BrowserConnectOptions & ConnectOptions,
+  options: ConnectOptions,
 ): Promise<CdpBrowser> {
   const {
     acceptInsecureCerts = false,
     defaultViewport = DEFAULT_VIEWPORT,
+    downloadBehavior,
     targetFilter,
     _isPageTarget: isPageTarget,
     slowMo = 0,
@@ -55,6 +53,7 @@ export async function _connectToCdpBrowser(
     browserContextIds,
     acceptInsecureCerts,
     defaultViewport,
+    downloadBehavior,
     undefined,
     () => {
       return connection.send('Browser.close').catch(debugError);

package/front_end/third_party/puppeteer/package/src/cdp/BrowserContext.ts

@@ -10,10 +10,13 @@ import {
 } from '../api/Browser.js';
 import {BrowserContext} from '../api/BrowserContext.js';
 import type {Page} from '../api/Page.js';
+import type {Cookie, CookieData} from '../common/Cookie.js';
+import type {DownloadBehavior} from '../common/DownloadBehavior.js';
 import {assert} from '../util/assert.js';
 
 import type {CdpBrowser} from './Browser.js';
 import type {Connection} from './Connection.js';
+import {convertCookiesPartitionKeyFromPuppeteerToCdp} from './Page.js';
 import type {CdpTarget} from './Target.js';
 
 /**
@@ -98,4 +101,45 @@ export class CdpBrowserContext extends BrowserContext {
     assert(this.#id, 'Default BrowserContext cannot be closed!');
     await this.#browser._disposeContext(this.#id);
   }
+
+  override async cookies(): Promise<Cookie[]> {
+    const {cookies} = await this.#connection.send('Storage.getCookies', {
+      browserContextId: this.#id,
+    });
+    return cookies.map(cookie => {
+      return {
+        ...cookie,
+        partitionKey: cookie.partitionKey
+          ? {
+              sourceOrigin: cookie.partitionKey.topLevelSite,
+              hasCrossSiteAncestor: cookie.partitionKey.hasCrossSiteAncestor,
+            }
+          : undefined,
+      };
+    });
+  }
+
+  override async setCookie(...cookies: CookieData[]): Promise<void> {
+    return await this.#connection.send('Storage.setCookies', {
+      browserContextId: this.#id,
+      cookies: cookies.map(cookie => {
+        return {
+          ...cookie,
+          partitionKey: convertCookiesPartitionKeyFromPuppeteerToCdp(
+            cookie.partitionKey,
+          ),
+        };
+      }),
+    });
+  }
+
+  public async setDownloadBehavior(
+    downloadBehavior: DownloadBehavior,
+  ): Promise<void> {
+    await this.#connection.send('Browser.setDownloadBehavior', {
+      behavior: downloadBehavior.policy,
+      downloadPath: downloadBehavior.downloadPath,
+      browserContextId: this.#id,
+    });
+  }
 }

package/front_end/third_party/puppeteer/package/src/cdp/CDPSession.ts

@@ -31,6 +31,7 @@ export class CdpCDPSession extends CDPSession {
   #connection?: Connection;
   #parentSessionId?: string;
   #target?: CdpTarget;
+  #rawErrors = false;
 
   /**
    * @internal
@@ -40,12 +41,14 @@ export class CdpCDPSession extends CDPSession {
     targetType: string,
     sessionId: string,
     parentSessionId: string | undefined,
+    rawErrors: boolean,
   ) {
     super();
     this.#connection = connection;
     this.#targetType = targetType;
     this.#sessionId = sessionId;
     this.#parentSessionId = parentSessionId;
+    this.#rawErrors = rawErrors;
   }
 
   /**
@@ -113,11 +116,15 @@ export class CdpCDPSession extends CDPSession {
   }): void {
     if (object.id) {
       if (object.error) {
-        this.#callbacks.reject(
-          object.id,
-          createProtocolErrorMessage(object),
-          object.error.message,
-        );
+        if (this.#rawErrors) {
+          this.#callbacks.rejectRaw(object.id, object.error);
+        } else {
+          this.#callbacks.reject(
+            object.id,
+            createProtocolErrorMessage(object),
+            object.error.message,
+          );
+        }
       } else {
         this.#callbacks.resolve(object.id, object.result);
       }

package/front_end/third_party/puppeteer/package/src/cdp/Connection.ts

@@ -36,15 +36,19 @@ export class Connection extends EventEmitter<CDPSessionEvents> {
   #sessions = new Map<string, CdpCDPSession>();
   #closed = false;
   #manuallyAttached = new Set<string>();
-  #callbacks = new CallbackRegistry();
+  #callbacks: CallbackRegistry;
+  #rawErrors = false;
 
   constructor(
     url: string,
     transport: ConnectionTransport,
     delay = 0,
     timeout?: number,
+    rawErrors = false,
   ) {
     super();
+    this.#rawErrors = rawErrors;
+    this.#callbacks = new CallbackRegistry();
     this.#url = url;
     this.#delay = delay;
     this.#timeout = timeout ?? 180_000;
@@ -159,6 +163,7 @@ export class Connection extends EventEmitter<CDPSessionEvents> {
         object.params.targetInfo.type,
         sessionId,
         object.sessionId,
+        this.#rawErrors,
       );
       this.#sessions.set(sessionId, session);
       this.emit(CDPSessionEvent.SessionAttached, session);
@@ -185,11 +190,15 @@ export class Connection extends EventEmitter<CDPSessionEvents> {
       }
     } else if (object.id) {
       if (object.error) {
-        this.#callbacks.reject(
-          object.id,
-          createProtocolErrorMessage(object),
-          object.error.message,
-        );
+        if (this.#rawErrors) {
+          this.#callbacks.rejectRaw(object.id, object.error);
+        } else {
+          this.#callbacks.reject(
+            object.id,
+            createProtocolErrorMessage(object),
+            object.error.message,
+          );
+        }
       } else {
         this.#callbacks.resolve(object.id, object.result);
       }

package/front_end/third_party/puppeteer/package/src/cdp/ElementHandle.ts

@@ -36,7 +36,8 @@ const NON_ELEMENT_NODE_ROLES = new Set(['StaticText', 'InlineTextBox']);
 export class CdpElementHandle<
   ElementType extends Node = Element,
 > extends ElementHandle<ElementType> {
-  protected declare readonly handle: CdpJSHandle<ElementType>;
+  declare protected readonly handle: CdpJSHandle<ElementType>;
+  #backendNodeId?: number;
 
   constructor(
     world: IsolatedWorld,
@@ -201,4 +202,15 @@ export class CdpElementHandle<
       >;
     });
   }
+
+  override async backendNodeId(): Promise<number> {
+    if (this.#backendNodeId) {
+      return this.#backendNodeId;
+    }
+    const {node} = await this.client.send('DOM.describeNode', {
+      objectId: this.handle.id,
+    });
+    this.#backendNodeId = node.backendNodeId;
+    return this.#backendNodeId;
+  }
 }

package/front_end/third_party/puppeteer/package/src/cdp/EmulationManager.ts

@@ -385,6 +385,7 @@ export class EmulationManager implements ClientProvider {
       'blurredVision',
       'deuteranopia',
       'protanopia',
+      'reducedContrast',
       'tritanopia',
     ]);
     assert(

package/front_end/third_party/puppeteer/package/src/cdp/Frame.ts

@@ -79,7 +79,7 @@ export class CdpFrame extends Frame {
       ),
     };
 
-    this.accessibility = new Accessibility(this.worlds[MAIN_WORLD]);
+    this.accessibility = new Accessibility(this.worlds[MAIN_WORLD], frameId);
 
     this.on(FrameEvent.FrameSwappedByActivation, () => {
       // Emulate loading process for swapped frames.

package/front_end/third_party/puppeteer/package/src/cdp/HTTPRequest.ts

@@ -46,6 +46,10 @@ export class CdpHTTPRequest extends HTTPRequest {
     return this.#client;
   }
 
+  override set client(newClient: CDPSession) {
+    this.#client = newClient;
+  }
+
   constructor(
     client: CDPSession,
     frame: Frame | null,

package/front_end/third_party/puppeteer/package/src/cdp/HTTPResponse.ts

@@ -5,7 +5,6 @@
  */
 import type {Protocol} from 'devtools-protocol';
 
-import type {CDPSession} from '../api/CDPSession.js';
 import type {Frame} from '../api/Frame.js';
 import {HTTPResponse, type RemoteAddress} from '../api/HTTPResponse.js';
 import {ProtocolError} from '../common/Errors.js';
@@ -19,7 +18,6 @@ import type {CdpHTTPRequest} from './HTTPRequest.js';
  * @internal
  */
 export class CdpHTTPResponse extends HTTPResponse {
-  #client: CDPSession;
   #request: CdpHTTPRequest;
   #contentPromise: Promise<Uint8Array> | null = null;
   #bodyLoadedDeferred = Deferred.create<void, Error>();
@@ -34,13 +32,11 @@ export class CdpHTTPResponse extends HTTPResponse {
   #timing: Protocol.Network.ResourceTiming | null;
 
   constructor(
-    client: CDPSession,
     request: CdpHTTPRequest,
     responsePayload: Protocol.Network.Response,
     extraInfo: Protocol.Network.ResponseReceivedExtraInfoEvent | null,
   ) {
     super();
-    this.#client = client;
     this.#request = request;
 
     this.#remoteAddress = {
@@ -128,7 +124,9 @@ export class CdpHTTPResponse extends HTTPResponse {
         .valueOrThrow()
         .then(async () => {
           try {
-            const response = await this.#client.send(
+            // Use CDPSession from corresponding request to retrieve body, as it's client
+            // might have been updated (e.g. for an adopted OOPIF).
+            const response = await this.#request.client.send(
               'Network.getResponseBody',
               {
                 requestId: this.#request.id,

package/front_end/third_party/puppeteer/package/src/cdp/NetworkManager.ts

@@ -514,17 +514,12 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
   }
 
   #handleRequestRedirect(
-    client: CDPSession,
+    _client: CDPSession,
     request: CdpHTTPRequest,
     responsePayload: Protocol.Network.Response,
     extraInfo: Protocol.Network.ResponseReceivedExtraInfoEvent | null,
   ): void {
-    const response = new CdpHTTPResponse(
-      client,
-      request,
-      responsePayload,
-      extraInfo,
-    );
+    const response = new CdpHTTPResponse(request, responsePayload, extraInfo);
     request._response = response;
     request._redirectChain.push(request);
     response._resolveBody(
@@ -536,7 +531,7 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
   }
 
   #emitResponseEvent(
-    client: CDPSession,
+    _client: CDPSession,
     responseReceived: Protocol.Network.ResponseReceivedEvent,
     extraInfo: Protocol.Network.ResponseReceivedExtraInfoEvent | null,
   ): void {
@@ -568,7 +563,6 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
     }
 
     const response = new CdpHTTPResponse(
-      client,
       request,
       responseReceived.response,
       extraInfo,
@@ -627,10 +621,10 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
         event,
       );
       if (queuedEvents.loadingFinishedEvent) {
-        this.#emitLoadingFinished(queuedEvents.loadingFinishedEvent);
+        this.#emitLoadingFinished(client, queuedEvents.loadingFinishedEvent);
       }
       if (queuedEvents.loadingFailedEvent) {
-        this.#emitLoadingFailed(queuedEvents.loadingFailedEvent);
+        this.#emitLoadingFailed(client, queuedEvents.loadingFailedEvent);
       }
       return;
     }
@@ -654,7 +648,7 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
   }
 
   #onLoadingFinished(
-    _client: CDPSession,
+    client: CDPSession,
     event: Protocol.Network.LoadingFinishedEvent,
   ): void {
     // If the response event for this request is still waiting on a
@@ -665,11 +659,14 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
     if (queuedEvents) {
       queuedEvents.loadingFinishedEvent = event;
     } else {
-      this.#emitLoadingFinished(event);
+      this.#emitLoadingFinished(client, event);
     }
   }
 
-  #emitLoadingFinished(event: Protocol.Network.LoadingFinishedEvent): void {
+  #emitLoadingFinished(
+    client: CDPSession,
+    event: Protocol.Network.LoadingFinishedEvent,
+  ): void {
     const request = this.#networkEventManager.getRequest(event.requestId);
     // For certain requestIds we never receive requestWillBeSent event.
     // @see https://crbug.com/750469
@@ -677,6 +674,8 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
       return;
     }
 
+    this.#maybeReassignOOPIFRequestClient(client, request);
+
     // Under certain conditions we never get the Network.responseReceived
     // event from protocol. @see https://crbug.com/883475
     if (request.response()) {
@@ -687,7 +686,7 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
   }
 
   #onLoadingFailed(
-    _client: CDPSession,
+    client: CDPSession,
     event: Protocol.Network.LoadingFailedEvent,
   ): void {
     // If the response event for this request is still waiting on a
@@ -698,17 +697,21 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
     if (queuedEvents) {
       queuedEvents.loadingFailedEvent = event;
     } else {
-      this.#emitLoadingFailed(event);
+      this.#emitLoadingFailed(client, event);
     }
   }
 
-  #emitLoadingFailed(event: Protocol.Network.LoadingFailedEvent): void {
+  #emitLoadingFailed(
+    client: CDPSession,
+    event: Protocol.Network.LoadingFailedEvent,
+  ): void {
     const request = this.#networkEventManager.getRequest(event.requestId);
     // For certain requestIds we never receive requestWillBeSent event.
     // @see https://crbug.com/750469
     if (!request) {
       return;
     }
+    this.#maybeReassignOOPIFRequestClient(client, request);
     request._failureText = event.errorText;
     const response = request.response();
     if (response) {
@@ -717,4 +720,18 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
     this.#forgetRequest(request, true);
     this.emit(NetworkManagerEvent.RequestFailed, request);
   }
+
+  #maybeReassignOOPIFRequestClient(
+    client: CDPSession,
+    request: CdpHTTPRequest,
+  ): void {
+    // Document requests for OOPIFs start in the parent frame but are adopted by their
+    // child frame, meaning their loadingFinished and loadingFailed events are fired on
+    // the child session. In this case we reassign the request CDPSession to ensure all
+    // subsequent actions use the correct session (e.g. retrieving response body in
+    // HTTPResponse).
+    if (client !== request.client && request.isNavigationRequest()) {
+      request.client = client;
+    }
+  }
 }

package/front_end/third_party/puppeteer/package/src/cdp/Page.ts

@@ -34,6 +34,7 @@ import type {
   Cookie,
   DeleteCookiesRequest,
   CookieParam,
+  CookiePartitionKey,
 } from '../common/Cookie.js';
 import {TargetCloseError} from '../common/Errors.js';
 import {EventEmitter} from '../common/EventEmitter.js';
@@ -552,6 +553,10 @@ export class CdpPage extends Page {
     return this._timeoutSettings.timeout();
   }
 
+  override getDefaultNavigationTimeout(): number {
+    return this._timeoutSettings.navigationTimeout();
+  }
+
   override async queryObjects<Prototype>(
     prototypeHandle: JSHandle<Prototype>,
   ): Promise<JSHandle<Prototype[]>> {
@@ -606,11 +611,9 @@ export class CdpPage extends Page {
     for (const cookie of cookies) {
       const item = {
         ...cookie,
-        // TODO: a breaking change neeeded to change the partition key
-        // type in Puppeteer.
-        partitionKey: cookie.partitionKey
-          ? {topLevelSite: cookie.partitionKey, hasCrossSiteAncestor: false}
-          : undefined,
+        partitionKey: convertCookiesPartitionKeyFromPuppeteerToCdp(
+          cookie.partitionKey,
+        ),
       };
       if (!cookie.url && pageURL.startsWith('http')) {
         item.url = pageURL;
@@ -654,14 +657,9 @@ export class CdpPage extends Page {
         cookies: items.map(cookieParam => {
           return {
             ...cookieParam,
-            partitionKey: cookieParam.partitionKey
-              ? {
-                  // TODO: a breaking change neeeded to change the partition key
-                  // type in Puppeteer.
-                  topLevelSite: cookieParam.partitionKey,
-                  hasCrossSiteAncestor: false,
-                }
-              : undefined,
+            partitionKey: convertCookiesPartitionKeyFromPuppeteerToCdp(
+              cookieParam.partitionKey,
+            ),
           };
         }),
       });
@@ -1230,3 +1228,21 @@ function getIntersectionRect(
     ),
   };
 }
+
+export function convertCookiesPartitionKeyFromPuppeteerToCdp(
+  partitionKey: CookiePartitionKey | string | undefined,
+): Protocol.Network.CookiePartitionKey | undefined {
+  if (partitionKey === undefined) {
+    return undefined;
+  }
+  if (typeof partitionKey === 'string') {
+    return {
+      topLevelSite: partitionKey,
+      hasCrossSiteAncestor: false,
+    };
+  }
+  return {
+    topLevelSite: partitionKey.sourceOrigin,
+    hasCrossSiteAncestor: partitionKey.hasCrossSiteAncestor ?? false,
+  };
+}

package/front_end/third_party/puppeteer/package/src/common/BrowserConnector.ts

@@ -13,7 +13,6 @@ import {isErrorLike} from '../util/ErrorLike.js';
 
 import type {ConnectionTransport} from './ConnectionTransport.js';
 import type {ConnectOptions} from './ConnectOptions.js';
-import type {BrowserConnectOptions} from './ConnectOptions.js';
 
 const getWebSocketTransportClass = async () => {
   return isNode
@@ -56,7 +55,7 @@ export async function _connectToBrowser(
  * endpoint url the transport is connected to.
  */
 async function getConnectionTransport(
-  options: BrowserConnectOptions & ConnectOptions,
+  options: ConnectOptions,
 ): Promise<{connectionTransport: ConnectionTransport; endpointUrl: string}> {
   const {browserWSEndpoint, browserURL, transport, headers = {}} = options;