chrome-devtools-frontend 1.0.1380117 → 1.0.1402249

package/front_end/models/issues_manager/CookieIssue.ts

@@ -8,6 +8,7 @@ import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
+import * as ThirdPartyWeb from '../../third_party/third-party-web/third-party-web.js';
 
 import {Issue, IssueCategory, IssueKind} from './Issue.js';
 import {
@@ -28,11 +29,11 @@ const UIStrings = {
   /**
    *@description Phrase used to describe the security of a context. Substitued like 'a secure context' or 'a secure origin'.
    */
-  aSecure: 'a secure',  // eslint-disable-line rulesdir/l10n_no_unused_message
+  aSecure: 'a secure',  // eslint-disable-line rulesdir/l10n-no-unused-message
   /**
    * @description Phrase used to describe the security of a context. Substitued like 'an insecure context' or 'an insecure origin'.
    */
-  anInsecure: 'an insecure',  // eslint-disable-line rulesdir/l10n_no_unused_message
+  anInsecure: 'an insecure',  // eslint-disable-line rulesdir/l10n-no-unused-message
   /**
    * @description Label for a link for SameParty Issues. 'Attribute' refers to a cookie attribute.
    */
@@ -67,6 +68,23 @@ export const enum CookieIssueSubCategory {
   THIRD_PARTY_PHASEOUT_COOKIE = 'ThirdPartyPhaseoutCookie',
 }
 
+// Enum to show cookie status from the security panel's third-party cookie report tool
+export const enum CookieStatus {
+  BLOCKED = 0,
+  ALLOWED = 1,
+  ALLOWED_BY_GRACE_PERIOD = 2,
+  ALLOWED_BY_HEURISTICS = 3,
+}
+
+export interface CookieReportInfo {
+  name: string;
+  domain: string;
+  type?: string;
+  platform?: string;
+  status: CookieStatus;
+  insight?: Protocol.Audits.CookieIssueInsight;
+}
+
 export class CookieIssue extends Issue {
   #issueDetails: Protocol.Audits.CookieIssueDetails;
 
@@ -77,7 +95,7 @@ export class CookieIssue extends Issue {
     this.#issueDetails = issueDetails;
   }
 
-  #cookieId(): string {
+  cookieId(): string {
     if (this.#issueDetails.cookie) {
       const {domain, path, name} = this.#issueDetails.cookie;
       const cookieId = `${domain};${path};${name}`;
@@ -88,7 +106,7 @@ export class CookieIssue extends Issue {
 
   primaryKey(): string {
     const requestId = this.#issueDetails.request ? this.#issueDetails.request.requestId : 'no-request';
-    return `${this.code()}-(${this.#cookieId()})-(${requestId})`;
+    return `${this.code()}-(${this.cookieId()})-(${requestId})`;
   }
 
   /**
@@ -197,6 +215,14 @@ export class CookieIssue extends Issue {
         reason === Protocol.Audits.CookieWarningReason.WarnSameSiteLaxCrossDowngradeStrict) {
       return [Protocol.Audits.InspectorIssueCode.CookieIssue, 'WarnCrossDowngrade', operation, secure].join('::');
     }
+
+    if (reason === Protocol.Audits.CookieExclusionReason.ExcludePortMismatch) {
+      return [Protocol.Audits.InspectorIssueCode.CookieIssue, 'ExcludePortMismatch'].join('::');
+    }
+
+    if (reason === Protocol.Audits.CookieExclusionReason.ExcludeSchemeMismatch) {
+      return [Protocol.Audits.InspectorIssueCode.CookieIssue, 'ExcludeSchemeMismatch'].join('::');
+    }
     return [Protocol.Audits.InspectorIssueCode.CookieIssue, reason, operation].join('::');
   }
 
@@ -245,6 +271,46 @@ export class CookieIssue extends Issue {
     return IssueKind.BREAKING_CHANGE;
   }
 
+  makeCookieReportEntry(): CookieReportInfo|undefined {
+    const status = CookieIssue.getCookieStatus(this.#issueDetails);
+    if (this.#issueDetails.cookie && this.#issueDetails.cookieUrl && status !== undefined) {
+      const entity = ThirdPartyWeb.ThirdPartyWeb.getEntity(this.#issueDetails.cookieUrl);
+      return {
+        name: this.#issueDetails.cookie.name,
+        domain: this.#issueDetails.cookie.domain,
+        type: entity?.category,
+        platform: entity?.name,
+        status,
+        insight: this.#issueDetails.insight,
+      };
+    }
+
+    return;
+  }
+
+  static getCookieStatus(cookieIssueDetails: Protocol.Audits.CookieIssueDetails): CookieStatus|undefined {
+    if (cookieIssueDetails.cookieExclusionReasons.includes(
+            Protocol.Audits.CookieExclusionReason.ExcludeThirdPartyPhaseout)) {
+      return CookieStatus.BLOCKED;
+    }
+
+    if (cookieIssueDetails.cookieWarningReasons.includes(
+            Protocol.Audits.CookieWarningReason.WarnDeprecationTrialMetadata)) {
+      return CookieStatus.ALLOWED_BY_GRACE_PERIOD;
+    }
+
+    if (cookieIssueDetails.cookieWarningReasons.includes(
+            Protocol.Audits.CookieWarningReason.WarnThirdPartyCookieHeuristic)) {
+      return CookieStatus.ALLOWED_BY_HEURISTICS;
+    }
+
+    if (cookieIssueDetails.cookieWarningReasons.includes(Protocol.Audits.CookieWarningReason.WarnThirdPartyPhaseout)) {
+      return CookieStatus.ALLOWED;
+    }
+
+    return;
+  }
+
   static fromInspectorIssue(issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue):
       CookieIssue[] {
     const cookieIssueDetails = inspectorIssue.details.cookieIssueDetails;
@@ -542,6 +608,16 @@ const cookieCrossSiteRedirectDowngrade: LazyMarkdownIssueDescription = {
   }],
 };
 
+const ExcludePortMismatch: LazyMarkdownIssueDescription = {
+  file: 'cookieExcludePortMismatch.md',
+  links: [],
+};
+
+const ExcludeSchemeMismatch: LazyMarkdownIssueDescription = {
+  file: 'cookieExcludeSchemeMismatch.md',
+  links: [],
+};
+
 // This description will be used by cookie issues that need to be added to the
 // issueManager, but aren't intended to be surfaced in the issues pane. This
 // is why they are using a placeholder description
@@ -600,4 +676,6 @@ const issueDescriptions: Map<string, LazyMarkdownIssueDescription> = new Map([
   ['CookieIssue::ExcludeThirdPartyPhaseout::ReadCookie', cookieExcludeThirdPartyPhaseoutRead],
   ['CookieIssue::ExcludeThirdPartyPhaseout::SetCookie', cookieExcludeThirdPartyPhaseoutSet],
   ['CookieIssue::CrossSiteRedirectDowngradeChangesInclusion', cookieCrossSiteRedirectDowngrade],
+  ['CookieIssue::ExcludePortMismatch', ExcludePortMismatch],
+  ['CookieIssue::ExcludeSchemeMismatch', ExcludeSchemeMismatch],
 ]);

package/front_end/models/issues_manager/DeprecationIssue.test.ts

@@ -60,9 +60,9 @@ describeWithLocale('DeprecationIssue', () => {
           IssuesManager.IssuesManager.Events.ISSUE_ADDED, {issuesModel: mockModel, issue});
     }
     const aggregatedIssues = Array.from(aggregator.aggregatedIssues());
-    assert.strictEqual(aggregatedIssues.length, 1);
+    assert.lengthOf(aggregatedIssues, 1);
     const deprecationIssues = Array.from(aggregatedIssues[0].getDeprecationIssues());
-    assert.strictEqual(deprecationIssues.length, 2);
+    assert.lengthOf(deprecationIssues, 2);
   });
 
   it('does not aggregate issues with different types', () => {
@@ -76,6 +76,6 @@ describeWithLocale('DeprecationIssue', () => {
           IssuesManager.IssuesManager.Events.ISSUE_ADDED, {issuesModel: mockModel, issue});
     }
     const aggregatedIssues = Array.from(aggregator.aggregatedIssues());
-    assert.strictEqual(aggregatedIssues.length, 2);
+    assert.lengthOf(aggregatedIssues, 2);
   });
 });

package/front_end/models/issues_manager/DeprecationIssue.ts

@@ -30,7 +30,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/DeprecationIssue.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
-// eslint-disable-next-line rulesdir/l10n_filename_matches
+// eslint-disable-next-line rulesdir/l10n-filename-matches
 const strDeprecation = i18n.i18n.registerUIStrings('generated/Deprecation.ts', Deprecation.UIStrings);
 const i18nLazyDeprecationString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, strDeprecation);
 

package/front_end/models/issues_manager/FederatedAuthUserInfoRequestIssue.test.ts

@@ -44,7 +44,7 @@ describeWithLocale('FederatedAuthUserInfoRequestIssue', () => {
       const federatedAuthUserInfoRequestIssue = federatedAuthUserInfoRequestIssues[0];
 
       assert.strictEqual(federatedAuthUserInfoRequestIssue.getCategory(), IssuesManager.Issue.IssueCategory.OTHER);
-      assert.deepStrictEqual(federatedAuthUserInfoRequestIssue.details(), issueDetails);
+      assert.deepEqual(federatedAuthUserInfoRequestIssue.details(), issueDetails);
       assert.strictEqual(federatedAuthUserInfoRequestIssue.getKind(), IssuesManager.Issue.IssueKind.PAGE_ERROR);
       assert.isNotNull(federatedAuthUserInfoRequestIssue.getDescription());
     }

package/front_end/models/issues_manager/GenericIssue.test.ts

@@ -42,7 +42,7 @@ describeWithLocale('GenericIssue', () => {
     const issue = createProtocolIssueWithDetails(issueDetails);
 
     const genericIssues = IssuesManager.GenericIssue.GenericIssue.fromInspectorIssue(mockModel, issue);
-    assert.strictEqual(genericIssues.length, 1);
+    assert.lengthOf(genericIssues, 1);
     const genericIssue = genericIssues[0];
 
     assert.strictEqual(genericIssue.getCategory(), IssuesManager.Issue.IssueCategory.GENERIC);
@@ -69,7 +69,7 @@ describeWithLocale('GenericIssue', () => {
     const issue = createProtocolIssueWithDetails(issueDetails);
 
     const genericIssues = IssuesManager.GenericIssue.GenericIssue.fromInspectorIssue(mockModel, issue);
-    assert.strictEqual(genericIssues.length, 1);
+    assert.lengthOf(genericIssues, 1);
     const genericIssue = genericIssues[0];
 
     assert.strictEqual(genericIssue.getCategory(), IssuesManager.Issue.IssueCategory.GENERIC);

package/front_end/models/issues_manager/IssueResolver.test.ts

@@ -29,7 +29,7 @@ describe('IssueResolver', () => {
         throw new Error('This should not get called');
       });
       assert.isTrue(issuesManager.hasEventListeners(IssuesManager.IssuesManager.Events.ISSUE_ADDED));
-      assert.strictEqual(issue, null);
+      assert.isNull(issue);
       issueResolver.clear();
     });
 
@@ -39,7 +39,7 @@ describe('IssueResolver', () => {
       const issueResolver = new IssuesManager.IssueResolver.IssueResolver(issuesManager);
       const waitForCall = new Promise<IssuesManager.Issue.Issue>(resolve => {
         const issue = issueResolver.tryGet(issueId1, resolve);
-        assert.strictEqual(issue, null);
+        assert.isNull(issue);
       });
       assert.isTrue(issuesManager.hasEventListeners(IssuesManager.IssuesManager.Events.ISSUE_ADDED));
       const mockIssue = StubIssue.createFromIssueId(issueId1);

package/front_end/models/issues_manager/IssuesManager.test.ts

@@ -38,10 +38,10 @@ describeWithMockConnection('IssuesManager', () => {
         SDK.IssuesModel.Events.ISSUE_ADDED, {issuesModel: model, inspectorIssue: mkInspectorCspIssue('url2')});
 
     const expected = ['ContentSecurityPolicyIssue::kURLViolation', 'ContentSecurityPolicyIssue::kURLViolation'];
-    assert.deepStrictEqual(dispatchedIssues.map(i => i.code()), expected);
+    assert.deepEqual(dispatchedIssues.map(i => i.code()), expected);
 
     const issueCodes = Array.from(issuesManager.issues()).map(r => r.code());
-    assert.deepStrictEqual(issueCodes, expected);
+    assert.deepEqual(issueCodes, expected);
   });
 
   function getBlockedUrl(issue: IssuesManager.Issue.Issue): string|undefined {
@@ -66,9 +66,9 @@ describeWithMockConnection('IssuesManager', () => {
         SDK.IssuesModel.Events.ISSUE_ADDED, {issuesModel: prerenderModel, inspectorIssue: mkInspectorCspIssue('url2')});
 
     const expected = ['url1'];
-    assert.deepStrictEqual(dispatchedIssues.map(getBlockedUrl), expected);
+    assert.deepEqual(dispatchedIssues.map(getBlockedUrl), expected);
 
-    assert.deepStrictEqual(Array.from(issuesManager.issues()).map(getBlockedUrl), expected);
+    assert.deepEqual(Array.from(issuesManager.issues()).map(getBlockedUrl), expected);
     return {issuesManager, prerenderTarget};
   }
 
@@ -76,7 +76,7 @@ describeWithMockConnection('IssuesManager', () => {
     const {issuesManager, prerenderTarget} = assertOutOfScopeIssuesAreFiltered();
 
     SDK.TargetManager.TargetManager.instance().setScopeTarget(prerenderTarget);
-    assert.deepStrictEqual(Array.from(issuesManager.issues()).map(getBlockedUrl), ['url2']);
+    assert.deepEqual(Array.from(issuesManager.issues()).map(getBlockedUrl), ['url2']);
   });
 
   it('keeps issues of prerendered page upon activation', () => {
@@ -84,7 +84,7 @@ describeWithMockConnection('IssuesManager', () => {
 
     SDK.TargetManager.TargetManager.instance().setScopeTarget(prerenderTarget);
     activate(prerenderTarget);
-    assert.deepStrictEqual(Array.from(issuesManager.issues()).map(getBlockedUrl), ['url2']);
+    assert.deepEqual(Array.from(issuesManager.issues()).map(getBlockedUrl), ['url2']);
   });
 
   const updatesOnPrimaryPageChange = (primary: boolean) => () => {
@@ -122,13 +122,13 @@ describeWithMockConnection('IssuesManager', () => {
     }
 
     let issueCodes = Array.from(issuesManager.issues()).map(i => i.code());
-    assert.deepStrictEqual(issueCodes, ['AllowedStubIssue1', 'AllowedStubIssue3']);
-    assert.deepStrictEqual(firedIssueAddedEventCodes, ['AllowedStubIssue1', 'AllowedStubIssue3']);
+    assert.deepEqual(issueCodes, ['AllowedStubIssue1', 'AllowedStubIssue3']);
+    assert.deepEqual(firedIssueAddedEventCodes, ['AllowedStubIssue1', 'AllowedStubIssue3']);
 
     showThirdPartyIssuesSetting.set(true);
 
     issueCodes = Array.from(issuesManager.issues()).map(i => i.code());
-    assert.deepStrictEqual(issueCodes, ['AllowedStubIssue1', 'StubIssue2', 'AllowedStubIssue3', 'StubIssue4']);
+    assert.deepEqual(issueCodes, ['AllowedStubIssue1', 'StubIssue2', 'AllowedStubIssue3', 'StubIssue4']);
   });
 
   it('reports issue counts by kind', () => {
@@ -142,10 +142,10 @@ describeWithMockConnection('IssuesManager', () => {
     issuesManager.addIssue(model, issue2);
     issuesManager.addIssue(model, issue3);
 
-    assert.deepStrictEqual(issuesManager.numberOfIssues(), 3);
-    assert.deepStrictEqual(issuesManager.numberOfIssues(IssuesManager.Issue.IssueKind.IMPROVEMENT), 2);
-    assert.deepStrictEqual(issuesManager.numberOfIssues(IssuesManager.Issue.IssueKind.BREAKING_CHANGE), 1);
-    assert.deepStrictEqual(issuesManager.numberOfIssues(IssuesManager.Issue.IssueKind.PAGE_ERROR), 0);
+    assert.deepEqual(issuesManager.numberOfIssues(), 3);
+    assert.deepEqual(issuesManager.numberOfIssues(IssuesManager.Issue.IssueKind.IMPROVEMENT), 2);
+    assert.deepEqual(issuesManager.numberOfIssues(IssuesManager.Issue.IssueKind.BREAKING_CHANGE), 1);
+    assert.deepEqual(issuesManager.numberOfIssues(IssuesManager.Issue.IssueKind.PAGE_ERROR), 0);
   });
 
   describe('instance', () => {
@@ -190,7 +190,7 @@ describeWithMockConnection('IssuesManager', () => {
       issuesManager.addIssue(model, issue);
     }
 
-    assert.deepStrictEqual(hiddenIssues, ['HiddenStubIssue1', 'HiddenStubIssue2']);
+    assert.deepEqual(hiddenIssues, ['HiddenStubIssue1', 'HiddenStubIssue2']);
   });
 
   it('hides issues present in IssuesManager when setting is updated', () => {
@@ -222,13 +222,13 @@ describeWithMockConnection('IssuesManager', () => {
     hideIssueByCodeSetting.set({
       HiddenStubIssue1: IssuesManager.IssuesManager.IssueStatus.HIDDEN,
     });
-    assert.deepStrictEqual(hiddenIssues, ['HiddenStubIssue1']);
+    assert.deepEqual(hiddenIssues, ['HiddenStubIssue1']);
 
     hideIssueByCodeSetting.set({
       HiddenStubIssue1: IssuesManager.IssuesManager.IssueStatus.HIDDEN,
       HiddenStubIssue2: IssuesManager.IssuesManager.IssueStatus.HIDDEN,
     });
-    assert.deepStrictEqual(hiddenIssues, ['HiddenStubIssue1', 'HiddenStubIssue2']);
+    assert.deepEqual(hiddenIssues, ['HiddenStubIssue1', 'HiddenStubIssue2']);
   });
 
   it('unhides issues present in IssuesManager when setting is updated', () => {
@@ -269,7 +269,7 @@ describeWithMockConnection('IssuesManager', () => {
       UnhiddenStubIssue1: IssuesManager.IssuesManager.IssueStatus.UNHIDDEN,
       UnhiddenStubIssue2: IssuesManager.IssuesManager.IssueStatus.HIDDEN,
     });
-    assert.deepStrictEqual(unhiddenIssues, ['UnhiddenStubIssue1']);
+    assert.deepEqual(unhiddenIssues, ['UnhiddenStubIssue1']);
 
     hideIssueByCodeSetting.set({
       HiddenStubIssue1: IssuesManager.IssuesManager.IssueStatus.HIDDEN,
@@ -277,7 +277,7 @@ describeWithMockConnection('IssuesManager', () => {
       UnhiddenStubIssue1: IssuesManager.IssuesManager.IssueStatus.UNHIDDEN,
       UnhiddenStubIssue2: IssuesManager.IssuesManager.IssueStatus.UNHIDDEN,
     });
-    assert.deepStrictEqual(unhiddenIssues, ['UnhiddenStubIssue1', 'UnhiddenStubIssue2']);
+    assert.deepEqual(unhiddenIssues, ['UnhiddenStubIssue1', 'UnhiddenStubIssue2']);
   });
 
   it('unhides all issues correctly', () => {
@@ -311,7 +311,7 @@ describeWithMockConnection('IssuesManager', () => {
       }
     });
     issuesManager.unhideAllIssues();
-    assert.deepStrictEqual(
+    assert.deepEqual(
         unhiddenIssues, ['HiddenStubIssue1', 'HiddenStubIssue2', 'UnhiddenStubIssue1', 'UnhiddenStubIssue2']);
   });
 

package/front_end/models/issues_manager/IssuesManager.ts

@@ -129,7 +129,7 @@ const issueCodeHandlers = new Map<
  * Each issue reported by the backend can result in multiple `Issue` instances.
  * Handlers are simple functions hard-coded into a map.
  */
-function createIssuesFromProtocolIssue(
+export function createIssuesFromProtocolIssue(
     issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue): Issue[] {
   const handler = issueCodeHandlers.get(inspectorIssue.code);
   if (handler) {

package/front_end/models/issues_manager/LowTextContrastIssue.test.ts

@@ -45,9 +45,9 @@ describe('LowTextContrastIssue', () => {
     }
 
     const aggregatedIssues = Array.from(aggregator.aggregatedIssues());
-    assert.strictEqual(aggregatedIssues.length, 1);
+    assert.lengthOf(aggregatedIssues, 1);
     const lowContrastIssues = Array.from(aggregatedIssues[0].getLowContrastIssues());
-    assert.strictEqual(lowContrastIssues.length, 3);
+    assert.lengthOf(lowContrastIssues, 3);
     const violatingNodeIds = [];
     for (const contrastIssue of lowContrastIssues) {
       violatingNodeIds.push(contrastIssue.details().violatingNodeId);

package/front_end/models/issues_manager/PropertyRuleIssue.test.ts

@@ -38,7 +38,7 @@ describeWithLocale('PropertyRuleIssue', () => {
     const propertyRuleIssue = propertyRuleIssues[0];
 
     assert.strictEqual(propertyRuleIssue.getCategory(), IssuesManager.Issue.IssueCategory.OTHER);
-    assert.deepStrictEqual(propertyRuleIssue.sources(), [issueDetails.sourceCodeLocation]);
+    assert.deepEqual(propertyRuleIssue.sources(), [issueDetails.sourceCodeLocation]);
     assert.strictEqual(propertyRuleIssue.getKind(), IssuesManager.Issue.IssueKind.PAGE_ERROR);
     assert.isNotNull(propertyRuleIssue.getDescription());
     assert.strictEqual(propertyRuleIssue.getPropertyName(), 'initial-value');

package/front_end/models/issues_manager/RelatedIssue.test.ts

@@ -15,7 +15,7 @@ describe('issuesAssociatedWith', () => {
   it('should return no issues if no issues exist', () => {
     const request = SDK.NetworkRequest.NetworkRequest.create(
         requestId1, Platform.DevToolsPath.EmptyUrlString, Platform.DevToolsPath.EmptyUrlString, null, null, null);
-    assert.strictEqual(IssuesManager.RelatedIssue.issuesAssociatedWith([], request).length, 0);
+    assert.lengthOf(IssuesManager.RelatedIssue.issuesAssociatedWith([], request), 0);
   });
 
   it('should return no issues if issues dont affect any resources', () => {
@@ -23,7 +23,7 @@ describe('issuesAssociatedWith', () => {
     const request = SDK.NetworkRequest.NetworkRequest.create(
         requestId1, Platform.DevToolsPath.EmptyUrlString, Platform.DevToolsPath.EmptyUrlString, null, null, null);
 
-    assert.strictEqual(IssuesManager.RelatedIssue.issuesAssociatedWith([issue], request).length, 0);
+    assert.lengthOf(IssuesManager.RelatedIssue.issuesAssociatedWith([issue], request), 0);
   });
 
   it('should correctly filter issues associated with a given request id', () => {
@@ -36,8 +36,8 @@ describe('issuesAssociatedWith', () => {
     const request2 = SDK.NetworkRequest.NetworkRequest.create(
         requestId2, Platform.DevToolsPath.EmptyUrlString, Platform.DevToolsPath.EmptyUrlString, null, null, null);
 
-    assert.deepStrictEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, request1), issues);
-    assert.deepStrictEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, request2), [issue1]);
+    assert.deepEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, request1), issues);
+    assert.deepEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, request2), [issue1]);
   });
 
   function createTestCookie(name: string): SDK.Cookie.Cookie {
@@ -57,8 +57,8 @@ describe('issuesAssociatedWith', () => {
     const cookie2 = createTestCookie('c2');
     const cookie3 = createTestCookie('c3');
 
-    assert.deepStrictEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, cookie1), [issue1, issue3]);
-    assert.deepStrictEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, cookie2), [issue1]);
-    assert.deepStrictEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, cookie3), [issue2]);
+    assert.deepEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, cookie1), [issue1, issue3]);
+    assert.deepEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, cookie2), [issue1]);
+    assert.deepEqual(IssuesManager.RelatedIssue.issuesAssociatedWith(issues, cookie3), [issue2]);
   });
 });

package/front_end/models/issues_manager/SharedDictionaryIssue.test.ts

@@ -60,7 +60,7 @@ describeWithLocale('SharedDictionaryIssue', () => {
       const sharedDictionaryIssue = sharedDictionaryIssues[0];
 
       assert.strictEqual(sharedDictionaryIssue.getCategory(), IssuesManager.Issue.IssueCategory.OTHER);
-      assert.deepStrictEqual(sharedDictionaryIssue.details(), issueDetails);
+      assert.deepEqual(sharedDictionaryIssue.details(), issueDetails);
       assert.strictEqual(sharedDictionaryIssue.getKind(), IssuesManager.Issue.IssueKind.PAGE_ERROR);
       assert.isNotNull(sharedDictionaryIssue.getDescription());
     }

package/front_end/models/issues_manager/StylesheetLoadingIssue.test.ts

@@ -40,9 +40,9 @@ describeWithLocale('StylesheetLoadingIssue', () => {
     const stylesheetIssue = stylesheetIssues[0];
 
     assert.strictEqual(stylesheetIssue.getCategory(), IssuesManager.Issue.IssueCategory.OTHER);
-    assert.deepStrictEqual(stylesheetIssue.sources(), [issueDetails.sourceCodeLocation]);
+    assert.deepEqual(stylesheetIssue.sources(), [issueDetails.sourceCodeLocation]);
     const {url, requestId} = issueDetails.failedRequestInfo;
-    assert.deepStrictEqual(stylesheetIssue.requests(), [{url, requestId}]);
+    assert.deepEqual(stylesheetIssue.requests(), [{url, requestId}]);
     assert.strictEqual(stylesheetIssue.getKind(), IssuesManager.Issue.IssueKind.PAGE_ERROR);
     assert.isNotNull(stylesheetIssue.getDescription());
   });
@@ -63,7 +63,7 @@ describeWithLocale('StylesheetLoadingIssue', () => {
     const stylesheetIssue = stylesheetIssues[0];
 
     assert.strictEqual(stylesheetIssue.getCategory(), IssuesManager.Issue.IssueCategory.OTHER);
-    assert.deepStrictEqual(stylesheetIssue.sources(), [issueDetails.sourceCodeLocation]);
+    assert.deepEqual(stylesheetIssue.sources(), [issueDetails.sourceCodeLocation]);
     assert.strictEqual(stylesheetIssue.getKind(), IssuesManager.Issue.IssueKind.PAGE_ERROR);
     assert.isNotNull(stylesheetIssue.getDescription());
   });
@@ -124,15 +124,15 @@ describeWithLocale('StylesheetLoadingIssue', () => {
     const aggregatedIssues = Array.from(aggregator.aggregatedIssues());
     assert.lengthOf(aggregatedIssues, 2);
 
-    assert.deepStrictEqual(
+    assert.deepEqual(
         Array.from(aggregatedIssues[0].sources()),
         [issueDetails[0].sourceCodeLocation, issueDetails[1].sourceCodeLocation]);
-    assert.deepStrictEqual(
+    assert.deepEqual(
         Array.from(aggregatedIssues[1].sources()),
         [issueDetails[2].sourceCodeLocation, issueDetails[3].sourceCodeLocation]);
-    assert.deepStrictEqual(Array.from(aggregatedIssues[0].requests()), []);
+    assert.deepEqual(Array.from(aggregatedIssues[0].requests()), []);
     const {url, requestId} = issueDetails[3].failedRequestInfo as Protocol.Audits.FailedRequestInfo;
     assert.exists(requestId);
-    assert.deepStrictEqual(Array.from(aggregatedIssues[1].requests()), [{url, requestId}]);
+    assert.deepEqual(Array.from(aggregatedIssues[1].requests()), [{url, requestId}]);
   });
 });

package/front_end/models/issues_manager/descriptions/cookieExcludePortMismatch.md

@@ -0,0 +1,8 @@
+# Cookie was not sent due to port mismatch
+
+Cookies can only be accessed by origins that share the same port as the origin
+that initially set the cookie.
+
+If this cookie is required for the request, the cookie will need to be set by an
+origin with the same port as the request. Alternatively, you can utilize the
+Domain attribute, which allows access to a cookie with a mismatched port.

package/front_end/models/issues_manager/descriptions/cookieExcludeSchemeMismatch.md

@@ -0,0 +1,7 @@
+# Cookie was not sent due to scheme mismatch
+
+The cookie can only be accessed by origins that share the same scheme as
+the origin that initially set it.
+
+If this cookie is required for the request, the cookie will need to be set
+by an origin with the same scheme as the request.

package/front_end/models/javascript_metadata/JavaScriptMetadata.test.ts

@@ -18,7 +18,7 @@ describe('JavaScriptMetadata', () => {
 
   it('does not retrieve native signatures that are bound to an instance', () => {
     const signatures = metadata.signaturesForNativeFunction('find');
-    assert.deepEqual(signatures, null);
+    assert.isNull(signatures);
   });
 
   describe('with static methods', () => {
@@ -29,12 +29,12 @@ describe('JavaScriptMetadata', () => {
 
     it('does not retrieve methods that are bound to an instance', () => {
       const signatures = metadata.signaturesForStaticMethod('includes', 'Array');
-      assert.deepEqual(signatures, null);
+      assert.isNull(signatures);
     });
 
     it('handles a non-existing class', () => {
       const signatures = metadata.signaturesForStaticMethod('includes', 'bogus');
-      assert.deepEqual(signatures, null);
+      assert.isNull(signatures);
     });
   });
 
@@ -46,17 +46,17 @@ describe('JavaScriptMetadata', () => {
 
     it('does not retrieve methods that are unbound', () => {
       const signatures = metadata.signaturesForInstanceMethod('webkitRequestFullScreen', 'window');
-      assert.deepEqual(signatures, null);
+      assert.isNull(signatures);
     });
 
     it('does not retrieve static methods', () => {
       const signatures = metadata.signaturesForInstanceMethod('from', 'Array');
-      assert.deepEqual(signatures, null);
+      assert.isNull(signatures);
     });
 
     it('handles a non-existing class', () => {
       const signatures = metadata.signaturesForInstanceMethod('from', 'Sheep');
-      assert.deepEqual(signatures, null);
+      assert.isNull(signatures);
     });
   });
 });