chrome-devtools-frontend 1.0.1040857 → 1.0.1070764

package/front_end/core/dom_extension/DOMExtension.ts

@@ -38,104 +38,6 @@
 
 import * as Platform from '../platform/platform.js';
 
-export function rangeOfWord(
-    rootNode: Node, offset: number, stopCharacters: string, stayWithinNode: Node, direction?: string): Range {
-  let startNode;
-  let startOffset = 0;
-  let endNode;
-  let endOffset = 0;
-
-  if (!stayWithinNode) {
-    stayWithinNode = rootNode;
-  }
-
-  if (!direction || direction === 'backward' || direction === 'both') {
-    let node: Node = rootNode;
-    while (node) {
-      if (node === stayWithinNode) {
-        if (!startNode) {
-          startNode = stayWithinNode;
-        }
-        break;
-      }
-
-      if (node.nodeType === Node.TEXT_NODE) {
-        const start = (node === rootNode ? (offset - 1) : (node.nodeValue.length - 1));
-        for (let i = start; i >= 0; --i) {
-          if (stopCharacters.indexOf(node.nodeValue[i]) !== -1) {
-            startNode = node;
-            startOffset = i + 1;
-            break;
-          }
-        }
-      }
-
-      if (startNode) {
-        break;
-      }
-
-      node = node.traversePreviousNode(stayWithinNode);
-    }
-
-    if (!startNode) {
-      startNode = stayWithinNode;
-      startOffset = 0;
-    }
-  } else {
-    startNode = rootNode;
-    startOffset = offset;
-  }
-
-  if (!direction || direction === 'forward' || direction === 'both') {
-    let node: (Node|null)|Node = rootNode;
-    while (node) {
-      if (node === stayWithinNode) {
-        if (!endNode) {
-          endNode = stayWithinNode;
-        }
-        break;
-      }
-
-      if (node.nodeType === Node.TEXT_NODE) {
-        const start = (node === rootNode ? offset : 0);
-        for (let i = start; i < node.nodeValue.length; ++i) {
-          if (stopCharacters.indexOf(node.nodeValue[i]) !== -1) {
-            endNode = node;
-            endOffset = i;
-            break;
-          }
-        }
-      }
-
-      if (endNode) {
-        break;
-      }
-
-      node = node.traverseNextNode(stayWithinNode);
-    }
-
-    if (!endNode) {
-      endNode = stayWithinNode;
-      endOffset = stayWithinNode.nodeType === Node.TEXT_NODE ? stayWithinNode.nodeValue.length :
-                                                               stayWithinNode.childNodes.length;
-    }
-  } else {
-    endNode = rootNode;
-    endOffset = offset;
-  }
-
-  const result = rootNode.ownerDocument.createRange();
-  result.setStart(startNode, startOffset);
-  result.setEnd(endNode, endOffset);
-
-  return result;
-}
-
-Node.prototype.rangeOfWord = function(
-    offset: number, stopCharacters: string, stayWithinNode: Node, direction?: string): Range {
-  return rangeOfWord(this, offset, stopCharacters, stayWithinNode, direction);
-};
-
 Node.prototype.traverseNextTextNode = function(stayWithin?: Node): Node|null {
   let node = this.traverseNextNode(stayWithin);
   if (!node) {
@@ -199,20 +101,6 @@ Node.prototype.enclosingNodeOrSelfWithClassList = function(classNames: string[],
   return null;
 };
 
-Node.prototype.enclosingShadowRoot = function(): Node|null {
-  let parentNode = this.parentNodeOrShadowHost();
-  while (parentNode) {
-    if (parentNode instanceof ShadowRoot) {
-      return parentNode;
-    }
-    parentNode = parentNode.parentNodeOrShadowHost();
-  }
-  return null;
-};
-
-Node.prototype.hasSameShadowRoot = function(node: Node): boolean {
-  return this.enclosingShadowRoot() === node.enclosingShadowRoot();
-};
 Node.prototype.parentElementOrShadowHost = function(): Element|null {
   if (this.nodeType === Node.DOCUMENT_FRAGMENT_NODE && this.host) {
     return this.host as Element;
@@ -370,23 +258,6 @@ Event.prototype.consume = function(preventDefault?: boolean): void {
   this.handled = true;
 };
 
-Text.prototype.select = function(start?: number, end?: number): Text {
-  start = start || 0;
-  end = end || this.textContent.length;
-
-  if (start < 0) {
-    start = end + start;
-  }
-
-  const selection = this.getComponentSelection();
-  selection.removeAllRanges();
-  const range = this.ownerDocument.createRange();
-  range.setStart(this, start);
-  range.setEnd(this, end);
-  selection.addRange(range);
-  return this;
-};
-
 Element.prototype.selectionLeftOffset = function(): number|null {
   // Calculate selection offset relative to the current element.
 
@@ -546,21 +417,13 @@ Node.prototype.getComponentRoot = function(): Document|DocumentFragment|null {
 
 self.onInvokeElement = function(element: Element, callback: (arg0: Event) => void): void {
   element.addEventListener('keydown', event => {
-    if (self.isEnterOrSpaceKey(event)) {
+    if (Platform.KeyboardUtilities.isEnterOrSpaceKey(event)) {
       callback(event);
     }
   });
   element.addEventListener('click', event => callback(event));
 };
 
-self.isEnterOrSpaceKey = function(event: Event): boolean {
-  return event.key === 'Enter' || event.key === ' ';
-};
-
-self.isEscKey = function(event: Event): boolean {
-  return event.keyCode === 27;
-};
-
 // DevTools front-end still assumes that
 //   classList.toggle('a', undefined) works as
 //   classList.toggle('a', false) rather than as

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -350,6 +350,8 @@ export interface SyncInformation {
 // eslint-disable-next-line rulesdir/const_enum
 export enum EnumeratedHistogram {
   ActionTaken = 'DevTools.ActionTaken',
+  BreakpointWithConditionAdded = 'DevTools.BreakpointWithConditionAdded',
+  BreakpointEditDialogRevealedFrom = 'DevTools.BreakpointEditDialogRevealedFrom',
   PanelClosed = 'DevTools.PanelClosed',
   PanelShown = 'DevTools.PanelShown',
   SidebarPaneShown = 'DevTools.SidebarPaneShown',

package/front_end/core/host/ResourceLoader.ts

@@ -106,9 +106,9 @@ export let load = function(
           [x: string]: string,
         },
         arg2: string, arg3: LoadErrorDescription) => void,
-    allowFileUNCPaths: boolean): void {
+    allowRemoteFilePaths: boolean): void {
   const stream = new Common.StringOutputStream.StringOutputStream();
-  loadAsStream(url, headers, stream, mycallback, allowFileUNCPaths);
+  loadAsStream(url, headers, stream, mycallback, allowRemoteFilePaths);
 
   function mycallback(
       success: boolean, headers: {
@@ -234,6 +234,15 @@ const loadXHR = (url: string): Promise<string> => {
   });
 };
 
+function canBeRemoteFilePath(url: string): boolean {
+  try {
+    const urlObject = new URL(url);
+    return urlObject.protocol === 'file:' && urlObject.host !== '';
+  } catch (exception) {
+    return false;
+  }
+}
+
 export const loadAsStream = function(
     url: string, headers: {
       [x: string]: string,
@@ -244,7 +253,7 @@ export const loadAsStream = function(
            [x: string]: string,
          },
           arg2: LoadErrorDescription) => void),
-    allowFileUNCPaths?: boolean): void {
+    allowRemoteFilePaths?: boolean): void {
   const streamId = _bindOutputStream(stream);
   const parsedURL = new Common.ParsedURL.ParsedURL(url);
   if (parsedURL.isDataURL()) {
@@ -252,13 +261,14 @@ export const loadAsStream = function(
     return;
   }
 
-  if (!allowFileUNCPaths && url.startsWith('file:////')) {
+  if (!allowRemoteFilePaths && canBeRemoteFilePath(url)) {
+    // Remote file paths can cause security problems, see crbug.com/1342722.
     if (callback) {
       callback(/* success */ false, /* headers */ {}, {
         statusCode: 400,  // BAD_REQUEST
         netError: -20,    // BLOCKED_BY_CLIENT
         netErrorName: 'net::BLOCKED_BY_CLIENT',
-        message: 'Loading from a Windows Share via UNC path is prohibited for security reasons.',
+        message: 'Loading from a remote file path is prohibited for security reasons.',
       });
     }
     return;

package/front_end/core/host/UserMetrics.ts

@@ -41,6 +41,24 @@ export class UserMetrics {
     this.#launchPanelName = '';
   }
 
+  breakpointWithConditionAdded(breakpointWithConditionAdded: BreakpointWithConditionAdded): void {
+    if (breakpointWithConditionAdded >= BreakpointWithConditionAdded.MaxValue) {
+      return;
+    }
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(
+        EnumeratedHistogram.BreakpointWithConditionAdded, breakpointWithConditionAdded,
+        BreakpointWithConditionAdded.MaxValue);
+  }
+
+  breakpointEditDialogRevealedFrom(breakpointEditDialogRevealedFrom: BreakpointEditDialogRevealedFrom): void {
+    if (breakpointEditDialogRevealedFrom >= BreakpointEditDialogRevealedFrom.MaxValue) {
+      return;
+    }
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(
+        EnumeratedHistogram.BreakpointEditDialogRevealedFrom, breakpointEditDialogRevealedFrom,
+        BreakpointEditDialogRevealedFrom.MaxValue);
+  }
+
   panelShown(panelName: string): void {
     const code = PanelCodes[panelName as keyof typeof PanelCodes] || 0;
     InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.PanelShown, code, PanelCodes.MaxValue);
@@ -358,7 +376,9 @@ export enum Action {
   PerfPanelTraceExported = 55,
   StackFrameRestarted = 56,
   CaptureTestProtocolClicked = 57,
-  MaxValue = 58,
+  BreakpointRemovedFromRemoveButton = 58,
+  BreakpointGroupExpandedStateChanged = 59,
+  MaxValue = 60,
 }
 
 /* eslint-disable @typescript-eslint/naming-convention */
@@ -613,7 +633,6 @@ export enum DevtoolsExperiments {
   'timelineInvalidationTracking' = 26,
   'timelineShowAllEvents' = 27,
   'timelineV8RuntimeCallStats' = 28,
-  'timelineWebGL' = 29,
   'timelineReplayEvent' = 30,
   'wasmDWARFDebugging' = 31,
   'dualScreenSupport' = 32,
@@ -625,18 +644,13 @@ export enum DevtoolsExperiments {
   'ignoreListJSFramesOnTimeline' = 43,
   'contrastIssues' = 44,
   'experimentalCookieFeatures' = 45,
-  'hideIssuesFeature' = 48,
-  'reportingApiDebugging' = 49,
-  'syncSettings' = 50,
   'groupAndHideIssuesByKind' = 51,
   'cssTypeComponentLength' = 52,
   'preciseChanges' = 53,
   'bfcacheDisplayTree' = 54,
   'stylesPaneCSSChanges' = 55,
   'headerOverrides' = 56,
-  'lighthousePanelFR' = 57,
   'evaluateExpressionsWithSourceMaps' = 58,
-  'cssLayers' = 59,
   'eyedropperColorPicker' = 60,
   'instrumentationBreakpoints' = 61,
   'cssAuthoringHints' = 62,
@@ -644,11 +658,27 @@ export enum DevtoolsExperiments {
   'importantDOMProperties' = 64,
   'justMyCode' = 65,
   'breakpointView' = 66,
+  'timelineAsConsoleProfileResultPanel' = 67,
   // Increment this when new experiments are added.
-  'MaxValue' = 67,
+  'MaxValue' = 68,
 }
 /* eslint-enable @typescript-eslint/naming-convention */
 
+export const enum BreakpointWithConditionAdded {
+  Logpoint = 0,
+  ConditionalBreakpoint = 1,
+  MaxValue = 2,
+}
+
+export const enum BreakpointEditDialogRevealedFrom {
+  BreakpointSidebarContextMenu = 0,
+  BreakpointSidebarEditButton = 1,
+  BreakpointMarkerContextMenu = 2,
+  LineGutterContextMenu = 3,
+  KeyboardShortcut = 4,
+  MaxValue = 5,
+}
+
 // TODO(crbug.com/1167717): Make this a const enum again
 // eslint-disable-next-line rulesdir/const_enum
 export enum IssueExpanded {
@@ -959,7 +989,8 @@ export enum RecordingExported {
   ToJSON = 2,
   ToPuppeteerReplay = 3,
   ToExtension = 4,
-  MaxValue = 5,
+  ToLighthouse = 5,
+  MaxValue = 6,
 }
 
 /* eslint-disable @typescript-eslint/naming-convention */
@@ -1013,7 +1044,9 @@ export enum CSSHintType {
   Padding = 8,
   Position = 9,
   ZIndex = 10,
-  MaxValue = 11,
+  Sizing = 11,
+  FlexOrGridItem = 12,
+  MaxValue = 13,
 }
 
 /* eslint-enable @typescript-eslint/naming-convention */