chrome-devtools-frontend 1.0.1040857 → 1.0.1070764

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -591,10 +591,8 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     if (this.lineToScrollTo !== null) {
       if (this.loaded && this.isShowing()) {
         const {textEditor} = this;
-        // DevTools history items are 0-based, but CodeMirror is 1-based, so we have to increment the
-        // line we want to scroll to by 1.
-        const position = textEditor.toOffset({lineNumber: this.lineToScrollTo + 1, columnNumber: 0});
-        textEditor.dispatch({effects: CodeMirror.EditorView.scrollIntoView(position, {y: 'start'})});
+        const position = textEditor.toOffset({lineNumber: this.lineToScrollTo, columnNumber: 0});
+        textEditor.dispatch({effects: CodeMirror.EditorView.scrollIntoView(position, {y: 'start', yMargin: 0})});
         this.lineToScrollTo = null;
       }
     }
@@ -655,42 +653,12 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     this.prettyToggle.setEnabled(true);
   }
 
-  private simplifyMimeType(content: string|CodeMirror.Text, mimeType: string): string {
-    if (!mimeType) {
-      return '';
-    }
-    // There are plenty of instances where TSX/JSX files are served with out the trailing x, i.e. JSX with a 'js' suffix
-    // which breaks the formatting. Therefore, if the mime type is TypeScript or JavaScript, we switch to the TSX/JSX
-    // superset so that we don't break formatting.
-    if (mimeType.indexOf('typescript') >= 0) {
-      return 'text/typescript-jsx';
-    }
-    if (mimeType.indexOf('javascript') >= 0 || mimeType.indexOf('jscript') >= 0 ||
-        mimeType.indexOf('ecmascript') >= 0) {
-      return 'text/jsx';
-    }
-    // A hack around the fact that files with "php" extension might be either standalone or html embedded php scripts.
-    if (mimeType === 'text/x-php') {
-      const strContent = typeof content === 'string' ? content : content.sliceString(0);
-      if (strContent.match(/\<\?.*\?\>/g)) {
-        return 'application/x-httpd-php';
-      }
-    }
-    if (mimeType === 'application/wasm') {
-      // text/webassembly is not a proper MIME type, but CodeMirror uses it for WAT syntax highlighting.
-      // We generally use application/wasm, which is the correct MIME type for Wasm binary data.
-      return 'text/webassembly';
-    }
-    return mimeType;
-  }
-
-  protected async getLanguageSupport(content: string|CodeMirror.Text): Promise<CodeMirror.Extension> {
-    const mimeType = this.simplifyMimeType(content, this.contentType) || '';
-    const languageDesc = await CodeHighlighter.CodeHighlighter.languageFromMIME(mimeType);
+  protected async getLanguageSupport(): Promise<CodeMirror.Extension> {
+    const languageDesc = await CodeHighlighter.CodeHighlighter.languageFromMIME(this.contentType);
     if (!languageDesc) {
       return [];
     }
-    if (mimeType === 'text/jsx') {
+    if (this.contentType === 'text/jsx') {
       return [
         languageDesc,
         CodeMirror.javascript.javascriptLanguage.data.of({autocomplete: CodeMirror.completeAnyWord}),
@@ -699,8 +667,8 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     return languageDesc;
   }
 
-  async updateLanguageMode(content: string): Promise<void> {
-    const langExtension = await this.getLanguageSupport(content);
+  async updateLanguageMode(): Promise<void> {
+    const langExtension = await this.getLanguageSupport();
     this.textEditor.dispatch({effects: config.language.reconfigure(langExtension)});
   }
 
@@ -711,7 +679,7 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     const scrollTop = textEditor.editor.scrollDOM.scrollTop;
     this.loadedInternal = true;
 
-    const languageSupport = await this.getLanguageSupport(content);
+    const languageSupport = await this.getLanguageSupport();
     const editorState = CodeMirror.EditorState.create({
       doc: content,
       extensions: [
@@ -1171,7 +1139,7 @@ function markNonBreakableLines(disassembly: Common.WasmDisassembly.WasmDisassemb
 const sourceFrameTheme = CodeMirror.EditorView.theme({
   '&.cm-editor': {height: '100%'},
   '.cm-scroller': {overflow: 'auto'},
-  '.cm-lineNumbers .cm-gutterElement.cm-nonBreakableLine': {color: 'var(--color-non-breakable-line)'},
+  '.cm-lineNumbers .cm-gutterElement.cm-nonBreakableLine': {color: 'var(--color-non-breakable-line) !important'},
   '.cm-searchMatch': {
     border: '1px solid var(--color-search-match-border)',
     borderRadius: '3px',

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -308,8 +308,8 @@ export class Linkifier implements SDK.TargetManager.Observer {
         linkifyOptions);
   }
 
-  linkifyStackTraceTopFrame(target: SDK.Target.Target, stackTrace: Protocol.Runtime.StackTrace, className?: string):
-      HTMLElement {
+  linkifyStackTraceTopFrame(
+      target: SDK.Target.Target|null, stackTrace: Protocol.Runtime.StackTrace, className?: string): HTMLElement {
     console.assert(stackTrace.callFrames.length > 0);
 
     const {url, lineNumber, columnNumber} = stackTrace.callFrames[0];
@@ -323,6 +323,11 @@ export class Linkifier implements SDK.TargetManager.Observer {
       preventClick: true,
     });
 
+    // HAR imported network logs have no associated NetworkManager.
+    if (!target) {
+      return fallbackAnchor;
+    }
+
     // The contract is that disposed targets don't have a LiveLocationPool
     // associated, whereas all active targets have one such pool. This ensures
     // that the fallbackAnchor is only ever used when the target was disposed.

package/front_end/ui/legacy/inspectorCommon.css

@@ -256,6 +256,7 @@ iframe.widget {
   cursor: pointer;
   text-decoration: underline;
   color: var(--color-link);
+  outline-offset: 2px;
 }
 
 button,
@@ -404,6 +405,28 @@ input::placeholder {
   border-color: transparent;
 }
 
+@media (forced-colors: active) and (prefers-color-scheme: light) {
+  .chrome-select {
+    background-image: var(--image-file-chromeSelect);
+  }
+
+  .-theme-with-dark-background .chrome-select,
+  :host-context(.-theme-with-dark-background) .chrome-select {
+    background-image: var(--image-file-chromeSelect);
+  }
+}
+
+@media (forced-colors: active) and (prefers-color-scheme: dark) {
+  .chrome-select {
+    background-image: var(--image-file-chromeSelectDark);
+  }
+
+  .-theme-with-dark-background .chrome-select,
+  :host-context(.-theme-with-dark-background) .chrome-select {
+    background-image: var(--image-file-chromeSelectDark);
+  }
+}
+
 .-theme-with-dark-background .chrome-select:enabled:active,
 .-theme-with-dark-background .chrome-select:enabled:focus,
 .-theme-with-dark-background .chrome-select:enabled:hover,

package/front_end/ui/legacy/inspectorSyntaxHighlight.css

@@ -89,6 +89,7 @@
 .devtools-link {
   color: var(--color-link);
   text-decoration: underline;
+  outline-offset: 2px;
 }
 
 .elements-disclosure .devtools-link {

package/front_end/ui/legacy/reportView.css

@@ -125,3 +125,13 @@
 .show-mask .image-wrapper {
   background: var(--image-file-checker);
 }
+
+@media (forced-colors: active) {
+  .report-field-value .inline-icon {
+    --icon-color: ButtonText;
+  }
+
+  .report-field-value .multiline-value {
+    --icon-color: ButtonText;
+  }
+}

package/front_end/ui/legacy/softContextMenu.css

@@ -148,12 +148,22 @@
     color: canvastext;
   }
 
-  .soft-context-menu-item-mouse-over {
+  .soft-context-menu-item-mouse-over,
+  .-theme-with-dark-background .soft-context-menu-item-mouse-over,
+  :host-context(.-theme-with-dark-background) .soft-context-menu-item-mouse-over {
     background-color: Highlight;
     color: HighlightText;
     forced-color-adjust: none;
   }
 
+  .soft-context-menu .soft-context-menu-item devtools-icon {
+    --icon-color: ButtonText;
+  }
+
+  .soft-context-menu .soft-context-menu-item-mouse-over devtools-icon {
+    --icon-color: HighlightText;
+  }
+
   .soft-context-menu-shortcut {
     color: ButtonText;
   }

package/front_end/ui/legacy/splitWidget.css

@@ -35,7 +35,7 @@
   display: flex;
   position: relative;
   flex-direction: column;
-  contain: size style;
+  contain: layout size style;
 }
 
 .shadow-split-widget-sidebar {

package/front_end/ui/legacy/tabbedPane.css

@@ -375,14 +375,23 @@
     background-color: ButtonFace;
   }
 
-  .tabbed-pane-header-tab,
-  .tabbed-pane-header-tab.selected {
+  .tabbed-pane-header-contents .tabbed-pane-header-tabs .tabbed-pane-header-tab {
     background: ButtonFace;
     color: ButtonText;
   }
 
-  .tabbed-pane-header-tab:hover,
-  .tabbed-pane-shadow .tabbed-pane-header-tab:focus-visible {
+  .tabbed-pane-header-tabs .tabbed-pane-header-tab:hover,
+  .tabbed-pane-header-tabs .tabbed-pane-shadow .tabbed-pane-header-tab:focus-visible {
+    background-color: Highlight;
+    color: HighlightText;
+  }
+
+  .tabbed-pane-header-tab .tabbed-pane-header-tab-title {
+    color: inherit;
+  }
+
+  .tabbed-pane-header-contents .tabbed-pane-header-tabs .tabbed-pane-header-tab.selected,
+  .tabbed-pane-header-contents .tabbed-pane-header-tabs .tabbed-pane-header-tab.selected:focus-visible {
     background-color: Highlight;
     color: HighlightText;
   }
@@ -410,6 +419,15 @@
     background-color: HighlightText;
   }
 
+  .tabbed-pane-header-tabs .tabbed-pane-header-tab .preview-icon {
+    --override-tabbed-pane-preview-icon-color: ButtonText;
+  }
+
+  .tabbed-pane-header-tab.selected .preview-icon,
+  .tabbed-pane-header-tab:hover .preview-icon {
+    --override-tabbed-pane-preview-icon-color: HighlightText;
+  }
+
   .close-button {
     --tabbed-pane-close-icon-color: ButtonText;
 
@@ -422,4 +440,8 @@
 
     background-color: Highlight;
   }
+
+  .selected .close-button {
+    --tabbed-pane-close-icon-color: HighlightText;
+  }
 }

package/front_end/ui/legacy/theme_support/theme_support_impl.ts

@@ -136,12 +136,10 @@ export class ThemeSupport extends EventTarget {
 
   applyTheme(document: Document): void {
     const isForcedColorsMode = window.matchMedia('(forced-colors: active)').matches;
-    if (isForcedColorsMode) {
-      return;
-    }
-
     const systemPreferredTheme = window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'default';
-    this.themeNameInternal = this.setting.get() === 'systemPreferred' ? systemPreferredTheme : this.setting.get();
+
+    const useSystemPreferred = this.setting.get() === 'systemPreferred' || isForcedColorsMode;
+    this.themeNameInternal = useSystemPreferred ? systemPreferredTheme : this.setting.get();
 
     const wasDarkThemed = document.documentElement.classList.contains('-theme-with-dark-background');
     document.documentElement.classList.toggle('-theme-with-dark-background', this.themeNameInternal === 'dark');

package/front_end/ui/legacy/toolbar.css

@@ -48,6 +48,7 @@
   height: var(--toolbar-height);
   border: none;
   white-space: pre;
+  overflow: hidden;
 }
 
 .toolbar-item,
@@ -55,6 +56,11 @@
   color: var(--color-text-secondary);
 }
 
+.toolbar-item:last-of-type {
+  flex-shrink: 1;
+  justify-content: left;
+}
+
 .toolbar-shadow.vertical .toolbar-item {
   height: auto;
   min-height: var(--toolbar-height);
@@ -334,7 +340,7 @@ select.toolbar-item:disabled {
   opacity: 50%;
 }
 
-button.toolbar-item:focus-visible,
+button.soft-dropdown.toolbar-item:focus-visible,
 select.toolbar-item:focus-visible {
   background: var(--color-background-elevation-2);
   border-radius: 2px;

package/package.json

@@ -25,6 +25,7 @@
     "auto-e2etest": "npm run build && npm run e2etest --",
     "auto-interactionstest": "npm run build && npm run interactionstest --",
     "auto-unittest": "scripts/test/run_auto_unittests.py --no-text-coverage",
+    "auto-unittest-coverage": "scripts/test/run_auto_unittests.py --no-text-coverage --coverage",
     "prebuild": "gn gen out/Default",
     "build": "autoninja -C out/Default",
     "build-release": "autoninja -C out/Release",
@@ -56,5 +57,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1040857"
+  "version": "1.0.1070764"
 }

package/scripts/eslint_rules/lib/no_only.js

@@ -0,0 +1,27 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+'use strict';
+
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'usage of .only() in mocha tests',
+      category: 'Possible Errors',
+    },
+    fixable: 'code',
+    messages: {noOnly: 'Unexpected exlcusive mocha test'},
+    schema: []  // no options
+  },
+  create: function(context) {
+    return {
+     MemberExpression(node) {
+        if (node.property.name === 'only' && node.property.type === 'Identifier' && node.parent.type === 'CallExpression' && node.parent.callee === node) {
+          context.report({node, messageId: 'noOnly'});
+        }
+      }
+    };
+  }
+};

package/scripts/eslint_rules/tests/no_only_test.js

@@ -0,0 +1,95 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const rule = require('../lib/no_only.js');
+const ruleTester = new (require('eslint').RuleTester)({
+  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
+});
+
+ruleTester.run('no_only', rule, {
+  valid: [
+    {
+      code: 'wrapDescribe(Mocha.describe.only, title, fn);',
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+    },
+    {
+      code: 'describe.only = function() {}',
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+    },
+    {
+      code: 'wrapDescribe(Mocha.it.only, title, fn);',
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+    },
+    {
+      code: 'it.only = function() {}',
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+    },
+  ],
+
+  invalid: [
+    {
+      code: `describeWithEnvironment.only('ConsoleMessage', () => {
+        it('tests', () => {});
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: `describeWithMockConnection.only('ConsoleMessage', () => {
+        it('tests', () => {});
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: `it.only('ConsoleMessage', () => {
+        it('tests', () => {});
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: `it.only('ConsoleMessage', () => {
+        it('tests', () => {});
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: 'describe.only("Some describe block", function() {});',
+      output: 'describe.only("Some describe block", function() {});',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: 'it.only("Some assertion", function() {});',
+      output: 'it.only("Some assertion", function() {});',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: 'context.only("Some context", function() {});',
+      output: 'context.only("Some context", function() {});',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: 'test.only("Some test", function() {});',
+      output: 'test.only("Some test", function() {});',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: 'tape.only("A tape", function() {});',
+      output: 'tape.only("A tape", function() {});',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: 'fixture.only("A fixture", function() {});',
+      output: 'fixture.only("A fixture", function() {});',
+      errors: [{messageId: 'noOnly'}],
+    },
+    {
+      code: 'serial.only("A serial test", function() {});',
+      output: 'serial.only("A serial test", function() {});',
+      errors: [{messageId: 'noOnly'}],
+    },
+  ]
+});

package/docs/localization/README.md

@@ -1,6 +0,0 @@
-# Localization FAQs
-
-- [How to add a localizable string?](adding_strings.md)
-- [What are the localization APIs?](localization_apis.md)
-- [How to write good descriptions for strings?](descriptions.md)
-- [How to prevent specific terms being localized?](locked_terms.md)

package/docs/localization/adding_strings.md

@@ -1,133 +0,0 @@
-When you introduce a new UI string or modify an existing one that will be displayed to the users, or remove a string that is localized, follow these steps so that it can be localized.
-
-**Table of Contents**
-- [Adding a string](#adding-a-string)
-- [Modifying a string](#modifying-a-string)
-- [Removing a string](#removing-a-string)
-
-## Adding a string
-Before proceeding, make sure you know the different [localization APIs](localization_apis_V2.md) and know which one you should use.
-
-Code example:
-  ```javascript
-  import * as i18n from '../i18n/i18n.js';
-
-  // at the top of example.js file, after import statements
-  const UIStrings = {
-    /**
-      * @description A string that is already added
-      */
-    alreadyAddedString: 'Someone already created a "UIStrings = {}" and added this string',
-    /**
-      * @description This is an example description for my new string
-      */
-    addThisString: 'The new string I want to add',
-    /**
-      * @description This is an example description for my new string with placeholder
-      * @example {example for placeholder} PH1
-      */
-    addAnotherString: 'Another new string I want to add, with {PH1}',
-  };
-  const str_ = i18n.i18n.registerUIStrings('example.js', UIStrings);
-  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-  ```
-
-  ```javascript
-  // in example.js file, where you want to call the string
-
-  const message1 = i18nString(UIStrings.addThisString);
-  console.log(message1); // The new string I want to add
-
-  const message2 = i18nString(UIStrings.addAnotherString, {PH1: 'a placeholder'});
-  console.log(message2); // Another new string I want to add, with a placeholder
-  ```
-1. If there is already `UIStrings = {}` declared in the file, add your string to it.
-  If there isn't `UIStrings = {}` in the file, create one and add your string, also register the new UIStrings into the `en-US.json` by adding:
-    1. `const str_ = i18n.i18n.registerUIStrings({the current fileName.js, relative to front_end}, UIStrings);`
-    1. `const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);`
-
-
-2. Add description and examples for placeholder(if any):
-    1. To specify the description, use `@description …`
-    `@description This is an example description for my new string`
-    2. To specify an example for placeholder, use `@example {…} …`
-    `@example {example for placeholder} PH1`
-
-3. Make sure your string is localizable:
-
-   1. Do not assume word order by using concatenation. Use the whole string.
-      ❌
-      ```javascript
-      'Add' + 'breakpoint'
-      ```
-      ✔️
-      ```javascript
-      'Add breakpoint'
-      ```
-      or
-      ❌
-      ```javascript
-      let description = 'first part'
-      if (condition)
-        description += ' second part'
-      ```
-      ✔️
-      ```javascript
-      let description
-      if (condition)
-        description = 'first part second part'
-      else
-        description = 'first part'
-      ```
-   2. Use placeholder over concatenation. This is so that the translators can adjust variable order based on what works in another language. For example:
-      ❌
-      ```javascript
-      'Check ' + title + ' for more information.'
-      ```
-      ✔️
-      ```javascript
-      'Check {PH1} for more information.', {PH1: title}
-      ```
-   3. If your string contains <b>leading or trailing white space</b>, it's usually an indication that it's half of a sentence. This decreases localizability as it's essentially concatenating. Modify it so that it doesn't contain leading or trailing white space anymore if you can.
-   4. <b>Backticks</b> are only used for the text that should not be localized. They cannot be escaped as part of the string. Check if there are something should not be localized (see [locked_terms](locked_terms_V2.md) for more details).
-
-      ❌ Not localized
-
-      - Numbers: 1, 1.23, 1.2e3, etc.
-      - Application data: error codes, enums, database names, rgba, urls, etc.
-
-      ✔️ Can be localized
-
-      - Words and sentences
-      - Punctuation
-      - Units of measurement: kb/s, mph, etc.
-4. The following commands would add the new strings to `en-US.json`:
-  - `git cl presubmit --upload`, or
-  - `node third_party/i18n/collect-strings.js` under the DevTools src folder
-5. Strings containing possible plurals have a special format in ICU. This is because plurals work quite differently in other languages, e.g. special forms for two or three items.
-
-    ❌
-    ```javascript
-    if (count === 1) {
-      str = '1 breakpoint';
-    } else {
-      str = '{n} breakpoints', {n: count};
-    }
-    ```
-
-    ✔️
-    ```javascript
-    '{n, plural, =1 {# breakpoint} other {# breakpoints}}', {n: count};
-    ```
-    - '#' is replaced with the value of `n`
-    - 'n' is a naming convention, but any name can be used
-    - Nesting placeholders inside of plurals is allowed
-    - Put the entire string within the plural switch, e.g. `{# breakpoints were found}`, not `{# breakpoints} were found`
-    - Always provide the `=1` and the `other` case, even if they are the same for English.
-
-## Modifying a string
-1. Update the string you want to modify in `UIStrings`
-2. Update the description and placeholders of the string if necessary
-
-## Removing a string
-1. Remove your string and the metadata from `UIStrings`

package/docs/localization/descriptions.md

@@ -1,30 +0,0 @@
-## How to write good descriptions
-Good descriptions can improve localizability by providing more context to the translators.
-There are some details that are very important to have in other languages!
-
-**Good description**:
-```javascript
-const UIStrings = {
-  /**
-   * @description Tooltip text that appears when hovering over the 'Focusable' attribute name under the Computed Properties section in the Accessibility pane of the Elements pane.
-   */
-  computedPropertyTooltip: 'If true, this element can receive focus.',
-};
-```
-**Bad description**:
-```javascript
-const UIStrings = {
-  /**
-   * @description Elements pane 'Focusable' tooltip.
-   */
-  computedPropertyTooltip: 'If true, this element can receive focus.',
-};
-```
-
-### What information should I provide in the message description?
-- The type of UI element where the text is displayed. Is it regular text, a label, button text, a tooltip, a link, or an accessible label? Button text is often imperative i.e. a command to do something, which is important to know in some languages.
-- _When_: What triggers the string and/or what is the result? What page or text comes before and after? e.g. "Status text while waiting for X", "Shown when the audit is finished and X error was encountered".
-- What do the placeholders stand for? Placeholder examples are sent to translators, but extra information in the description will help too. e.g. "Total time in ms that the profile took to complete", "The CSS property name that is being edited"
-- Is this a verb or a noun? Many words in English can be both, e.g. 'request', 'address', 'change', 'display', 'increase'. Particularly if the string is short, this can be hard to guess. If it's an adjective, what does it refer to? This is important for inflection in some languages, where the ending of the adjective must change for gender or case.
-- Explain or name any complex terms, e.g. "Trust Tokens are a web API - https://web.dev/trust-tokens/"
-- Where is the text located? e.g. A table header in the Sources panel, a context-menu item in the Network panel. Many strings in the code base have _only_ the location, which is not the most important context.