chrome-devtools-frontend 1.0.1386602 → 1.0.1418433

package/scripts/watch_build.js

@@ -2,14 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const chokidar = require('chokidar');
-const path = require('path');
 const childProcess = require('child_process');
 const fs = require('fs');
+const path = require('path');
 const cwd = process.cwd();
 const frontEndDir = path.join(cwd, 'front_end');
 const testsDir = path.join(cwd, 'test');
-const {WebSocketServer} = require('ws');
 const env = process.env;
 
 const extractArgument = argName => {
@@ -34,12 +32,10 @@ const NODE_PATH = path.join('third_party', 'node', 'node.py');
 const ESBUILD_PATH = path.join('third_party', 'esbuild', 'esbuild');
 const GENERATE_CSS_JS_FILES_PATH = path.join('scripts', 'build', 'generate_css_js_files.js');
 
-const connections = {};
-let lastConnectionId = 0;
+let tId = -1;
 
 // Extract the target if it's provided.
 const target = extractArgument('--target') || 'Default';
-const PORT = 8080;
 const TARGET_GEN_DIR = path.join('out', target, 'gen');
 
 // Make sure that the target has
@@ -59,6 +55,9 @@ const assertTargetArgsForWatchBuild = async () => {
   try {
     args = JSON.parse(stdoutText);
   } catch (err) {
+    if (stdoutText.includes('devtools_css_hot_reload_enabled')) {
+      console.error('\n❗❗ You must remove `devtools_css_hot_reload_enabled` from your args.gn.\n');
+    }
     throw `Parsing args of target ${target} is failed\n${err}`;
   }
 
@@ -80,76 +79,36 @@ const assertTargetArgsForWatchBuild = async () => {
   }
 };
 
-const startWebSocketServerForCssChanges = () => {
-  const wss = new WebSocketServer({port: PORT});
-
-  wss.on('listening', () => {
-    console.log(`Listening connections for CSS changes at ${PORT}\n`);
-  });
-
-  wss.on('connection', ws => {
-    const connection = {
-      id: ++lastConnectionId,
-      ws,
-    };
-
-    connections[connection.id] = connection;
-    ws.on('close', () => {
-      delete connections[connection.id];
-    });
-  });
-};
-
-const runGenerateCssFiles = ({fileName, isLegacy}) => {
+const runGenerateCssFiles = ({fileName}) => {
   const scriptArgs = [
     /* buildTimestamp */ Date.now(),
     /* isDebugString */ 'true',
-    /* isLegacyString */ isLegacy ? 'true' : 'false',
     /* targetName */ target,
     /* srcDir */ '',
     /* targetGenDir */ TARGET_GEN_DIR,
     /* files */ relativeFileName(fileName),
-    /* hotReloadEnabledString */ 'true'
   ];
 
   childProcess.spawnSync(
       'vpython3', [NODE_PATH, '--output', GENERATE_CSS_JS_FILES_PATH, ...scriptArgs], {cwd, env, stdio: 'inherit'});
 };
 
-const isLegacyCss = absoluteFilePath => {
-  if (!absoluteFilePath.endsWith('.css')) {
-    return false;
-  }
-
-  const relativePath = path.relative(cwd, absoluteFilePath);
-  const possibleLegacyCssPath = path.join(TARGET_GEN_DIR, `${relativePath}.legacy.js`);
-  return fs.existsSync(possibleLegacyCssPath);
-};
-
-const notifyWebSocketConections = message => {
-  Object.values(connections).forEach(connection => connection.ws.send(message));
-};
-
 const changedFiles = new Set();
-let buildScheduled = false;
 
 const onFileChange = async fileName => {
   changedFiles.add(fileName);
-  // Debounce to handle them in batch
-  if (!buildScheduled) {
-    buildScheduled = true;
-    setTimeout(() => {
-      buildScheduled = false;
-      buildFiles();
-    }, 100);
-  }
+  // Debounce to handle them in batch.
+  // At 250ms, we're optimizing for individual file changes.
+  // On branch changes, its possible a ninja rebuild may start before the checkout is complete, but it will likely quickly error out. Either way, another rebuild will be attempted immediately after.
+  clearTimeout(tId);
+  tId = setTimeout(buildFiles, 250);
 };
 
 const buildFiles = async () => {
   // If we need a ninja rebuild, do that and quit
-  const nonJSOrCSSFileName = Array.from(changedFiles).find(f => !f.endsWith('.css') && !f.endsWith('.ts'));
-  if (nonJSOrCSSFileName) {
-    console.log(`${currentTimeString()} - ${relativeFileName(nonJSOrCSSFileName)} changed, running ninja`);
+  const nonTSOrCSSFileNames = Array.from(changedFiles).filter(f => !f.endsWith('.css') && !f.endsWith('.ts'));
+  if (nonTSOrCSSFileNames.length) {
+    console.log(`${currentTimeString()} - ${nonTSOrCSSFileNames.map(relativeFileName)} changed, running ninja`);
     changedFiles.clear();
     childProcess.spawnSync('autoninja', ['-C', `out/${target}`], {cwd, env, stdio: 'inherit'});
     return;
@@ -162,20 +121,8 @@ const buildFiles = async () => {
 const fastRebuildFile = async fileName => {
   if (fileName.endsWith('.css')) {
     console.log(`${currentTimeString()} - ${relativeFileName(fileName)} changed, notifying frontend`);
-    const isLegacy = isLegacyCss(fileName);
-    const content = fs.readFileSync(fileName, {encoding: 'utf8', flag: 'r'});
-    runGenerateCssFiles({fileName: relativeFileName(fileName), isLegacy});
+    runGenerateCssFiles({fileName: relativeFileName(fileName)});
     changedFiles.delete(fileName);
-
-    if (isLegacy) {
-      notifyWebSocketConections(JSON.stringify({
-        event: 'log-warn',
-        message: `a legacy css file \x1B[1m${
-            path.relative(cwd, fileName)}\x1B[m is updated, you need to refresh the page to see changes.`
-      }));
-    } else {
-      notifyWebSocketConections(JSON.stringify({event: 'css-change', file: fileName, content}));
-    }
     return;
   }
 
@@ -193,11 +140,8 @@ const fastRebuildFile = async fileName => {
         [fileName, `--outfile=${outFile}`, '--sourcemap', `--tsconfig=${tsConfigLocation}`, ...cjsForTests],
         {cwd, env, stdio: 'inherit'});
 
-    if (res && res.status === 1) {
-      notifyWebSocketConections(JSON.stringify({
-        event: 'log-warn',
-        message: `TS compilation failed for \x1B[1m${path.relative(cwd, fileName)}\x1B[m, check your terminal.`
-      }));
+    if (res?.status === 1) {
+      console.warn(`TS compilation failed for \x1B[1m${path.relative(cwd, fileName)}\x1B`);
     }
     return;
   }
@@ -209,6 +153,5 @@ childProcess.spawnSync('autoninja', ['-C', `out/${target}`], {cwd, env, stdio: '
 
 // Watch the front_end and test folder and build on any change.
 console.log(`Watching for changes in ${frontEndDir} and ${testsDir}`);
-chokidar.watch(frontEndDir, {usePolling: false, useFsEvents: true}).on('change', onFileChange);
-chokidar.watch(testsDir, {usePolling: false, useFsEvents: true}).on('change', onFileChange);
-startWebSocketServerForCssChanges();
+fs.watch(frontEndDir, {recursive: true}).on('change', (_, fileName) => onFileChange(path.join(frontEndDir, fileName)));
+fs.watch(testsDir, {recursive: true}).on('change', (_, fileName) => onFileChange(path.join(testsDir, fileName)));

package/tsconfig.json

@@ -16,7 +16,8 @@
         "rules": {
           "no-complex-attribute-binding": "off",
           "no-missing-import": "error",
-          "no-unknown-tag-name": "error"
+          "no-unknown-tag-name": "error",
+          "no-unclosed-tag": "error"
         }
       }
     ]

package/.eslintignore

@@ -1,41 +0,0 @@
-front_end/diff/diff_match_patch.jD
-front_end/models/javascript_metadata/NativeFunctions.js
-
-// All of these scripts are auto-generated so don't lint them.
-front_end/generated/ARIAProperties.js
-front_end/generated/Deprecation.ts
-front_end/generated/InspectorBackendCommands.js
-front_end/generated/protocol-mapping.d.ts
-front_end/generated/protocol-proxy-api.d.ts
-front_end/generated/protocol.ts
-
-
-// Any third_party addition has its source code checked out into
-// third_party/X/package, so we ignore that code as it's not code we author or
-// own.
-front_end/third_party/*/package/
-// Any JS files are also not authored by devtools-frontend, so we ignore those.
-front_end/third_party/**/*.js
-// Lighthouse doesn't have a package/ folder but has other nested folders, so
-// we ignore any folders within the lighthouse directory.
-front_end/third_party/lighthouse/*/
-// The CodeMirror bundle file is auto-generated and rolled-up as part of the
-// install script, so we don't need to lint it.
-front_end/third_party/codemirror.next/bundle.ts
-// Lit lib files are auto-generated and rolled up as part of the install script.
-front_end/third_party/lit/src/*.ts
-// @puppeteer/replay is auto-generated.
-front_end/third_party/puppeteer-replay/**/*.ts
-
-extensions/cxx_debugging/third_party/
-
-node_modules
-scripts/build/typescript/tests
-scripts/migration/**/*.js
-scripts/protocol_typescript/*.js
-scripts/deps/tests/fixtures
-test/**/fixtures/
-test/e2e/**/*.js
-test/shared/**/*.js
-
-*.d.ts

package/.eslintrc.js

@@ -1,315 +0,0 @@
-// Copyright 2020 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// clang-format off
-
-const path = require('path');
-const rulesDirPlugin = require('eslint-plugin-rulesdir');
-rulesDirPlugin.RULES_DIR = path.join(__dirname, 'scripts', 'eslint_rules', 'lib');
-
-module.exports = {
-  root: true,
-
-  env: {browser: true, es6: true},
-
-  parser: '@typescript-eslint/parser',
-
-  plugins: [
-    '@typescript-eslint',
-    'mocha',
-    'rulesdir',
-    'import',
-    'jsdoc',
-  ],
-
-  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
-
-  /**
-   * ESLint rules
-   *
-   * All available rules: http://eslint.org/docs/rules/
-   */
-  rules: {
-    /**
-     * Enforced rules
-     */
-
-    // syntax preferences
-    quotes: ['error', 'single', {avoidEscape: true, allowTemplateLiterals: false}],
-    semi: 'error',
-    'no-extra-semi': 'error',
-    'comma-style': ['error', 'last'],
-    'wrap-iife': ['error', 'inside'],
-    'spaced-comment': ['error', 'always', {markers: ['*']}],
-    eqeqeq: 'error',
-    'accessor-pairs': ['error', {getWithoutSet: false, setWithoutGet: false}],
-    curly: 'error',
-    'new-parens': 'error',
-    'func-call-spacing': 'error',
-    'arrow-parens': ['error', 'as-needed'],
-    'eol-last': 'error',
-    'object-shorthand': ['error', 'properties'],
-    'no-useless-rename': 'error',
-
-    // anti-patterns
-    'no-caller': 'error',
-    'no-case-declarations': 'error',
-    'no-cond-assign': 'error',
-    'no-console': ['error', {allow: ['assert', 'context', 'error', 'timeStamp', 'time', 'timeEnd', 'warn']}],
-    'no-debugger': 'error',
-    'no-dupe-keys': 'error',
-    'no-duplicate-case': 'error',
-    'no-else-return': ['error', {allowElseIf: false}],
-    'no-empty-character-class': 'error',
-    'no-global-assign': 'error',
-    'no-implied-eval': 'error',
-    'no-labels': 'error',
-    'no-multi-str': 'error',
-    'no-new-object': 'error',
-    'no-octal-escape': 'error',
-    'no-self-compare': 'error',
-    'no-shadow-restricted-names': 'error',
-    'no-unreachable': 'error',
-    'no-unsafe-negation': 'error',
-    'no-unused-vars': ['error', {args: 'none', vars: 'local'}],
-    'no-var': 'error',
-    'no-with': 'error',
-    'prefer-const': 'error',
-    radix: 'error',
-    'valid-typeof': 'error',
-    'no-return-assign': ['error', 'always'],
-    'no-implicit-coercion': 'error',
-
-    // es2015 features
-    'require-yield': 'error',
-    'template-curly-spacing': ['error', 'never'],
-
-    // file whitespace
-    'no-multiple-empty-lines': ['error', {max: 1}],
-    'no-mixed-spaces-and-tabs': 'error',
-    'no-trailing-spaces': 'error',
-    'linebreak-style': ['error', 'unix'],
-
-    /**
-     * Disabled, aspirational rules
-     */
-
-    indent: ['off', 2, {SwitchCase: 1, CallExpression: {arguments: 2}, MemberExpression: 2}],
-
-    // brace-style is disabled, as eslint cannot enforce 1tbs as default, but allman for functions
-    'brace-style': ['off', 'allman', {allowSingleLine: true}],
-
-    // key-spacing is disabled, as some objects use value-aligned spacing, some not.
-    'key-spacing': ['off', {beforeColon: false, afterColon: true, align: 'value'}],
-
-    'quote-props': ['error', 'as-needed'],
-
-    // no-implicit-globals will prevent accidental globals
-    'no-implicit-globals': 'off',
-    'no-unused-private-class-members': 'error',
-
-    // forbids interfaces starting with an I prefix.
-    '@typescript-eslint/naming-convention':
-        ['error', {selector: 'interface', format: ['PascalCase'], custom: {regex: '^I[A-Z]', match: false}}],
-    '@typescript-eslint/explicit-member-accessibility': 'off',
-    '@typescript-eslint/no-explicit-any': [
-      'error',
-      {
-        ignoreRestArgs: true
-      }
-    ],
-
-    // Closure does not properly typecheck default exports
-    'import/no-default-export': 'error',
-
-    /**
-     * Catch duplicate import paths. For example this would catch the following example:
-     * import {Foo} from './foo.js'
-     * import * as FooModule from './foo.js'
-     **/
-    'import/no-duplicates': 'error',
-
-    // Try to spot '// console.log()' left over from debugging
-    'rulesdir/commented_out_console': 'error',
-
-    // Prevent imports being commented out rather than deleted.
-    'rulesdir/commented_out_import': 'error',
-
-    // DevTools specific rules
-    'rulesdir/es_modules_import': 'error',
-    'rulesdir/check_license_header': 'error',
-    'rulesdir/html_tagged_template': 'error',
-    /**
-     * Ensures that JS Doc comments are properly aligned - all the starting
-     * `*` are in the right place.
-     */
-    'jsdoc/check-alignment': 'error',
-  },
-  overrides: [{
-    files: ['*.ts'],
-    parserOptions: {
-      allowAutomaticSingleRunInference: true,
-      project: path.join(__dirname, 'config', 'typescript', 'tsconfig.eslint.json'),
-    },
-    rules: {
-      '@typescript-eslint/explicit-member-accessibility': ['error', {accessibility: 'no-public'}],
-      'comma-dangle': 'off',
-      '@typescript-eslint/comma-dangle': ['error', 'always-multiline'],
-
-      // run just the TypeScript unused-vars rule, else we get duplicate errors
-      'no-unused-vars': 'off',
-      '@typescript-eslint/no-unused-vars': ['error', {argsIgnorePattern: '^_'}],
-      // run just the TypeScript semi rule, else we get duplicate errors
-      semi: 'off',
-      '@typescript-eslint/semi': 'error',
-      '@typescript-eslint/member-delimiter-style': [
-        'error', {
-          multiline: {delimiter: 'semi', requireLast: true},
-          singleline: {delimiter: 'comma', requireLast: false},
-          overrides: {
-            interface: {
-              singleline: {delimiter: 'semi', requireLast: false},
-              multiline: {delimiter: 'semi', requireLast: true}
-            },
-            typeLiteral: {
-              singleline: {delimiter: 'comma', requireLast: false},
-              multiline: {delimiter: 'comma', requireLast: true}
-            }
-          }
-        }
-      ],
-      '@typescript-eslint/no-floating-promises': ['error', {ignoreVoid: true}],
-      // func-call-spacing doesn't work well with .ts
-      'func-call-spacing': 'off',
-      '@typescript-eslint/func-call-spacing': 'error',
-
-      /**
-       * Enforce that enum members are explicitly defined:
-       * const enum Foo { A = 'a' } rather than const enum Foo { A }
-       */
-      '@typescript-eslint/prefer-enum-initializers': 'error',
-      /**
-       * Ban non-null assertion operator, e.g.:
-       * this.foo!.toLowerCase()
-       */
-      '@typescript-eslint/no-non-null-assertion': 'error',
-      '@typescript-eslint/consistent-type-imports': 'error',
-      'rulesdir/no_underscored_properties': 'error',
-      'rulesdir/prefer_readonly_keyword': 'error',
-      'rulesdir/inline_type_imports': 'error',
-      'rulesdir/enforce_default_import_name': ['error', {
-        // Enforce that any import of models/trace/trace.js names the import Trace.
-        modulePath: path.join(__dirname, 'front_end', 'models', 'trace', 'trace.js'),
-        importName: 'Trace'
-      }]
-    }
-  }, {
-    files : ['*.ts'],
-    rules : {
-      '@typescript-eslint/naming-convention' :
-      [
-        'error', {
-          selector : ['function', 'accessor', 'method', 'property', 'parameterProperty'],
-          format : ['camelCase'],
-        },
-        {
-          selector: 'variable',
-          filter: {
-            // Ignore localization variables.
-            regex: '^(UIStrings|str_)$',
-            match: false
-          },
-          format: ['camelCase'],
-        },
-        {
-          // We are using camelCase, PascalCase and UPPER_CASE for top-level constants, allow the for now.
-          selector: 'variable',
-          modifiers: ['const'],
-          filter: {
-            // Ignore localization variables.
-            regex: '^(UIStrings|str_)$',
-            match: false
-          },
-          format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
-        },
-        {
-          selector : 'classProperty',
-          modifiers : ['static', 'readonly'],
-          format : ['UPPER_CASE', 'camelCase'],
-        },
-        {
-          selector : 'enumMember',
-          format : ['UPPER_CASE'],
-        },
-        {
-          selector : ['typeLike'],
-          format : ['PascalCase'],
-        },
-        {
-          selector : 'parameter',
-          format : ['camelCase'],
-          leadingUnderscore : 'allow',
-        },
-        {
-          // Public methods are currently in transition and may still have leading underscores.
-          selector: 'method',
-          modifiers: ['public'],
-          format: ['camelCase'],
-          leadingUnderscore: 'allow',
-        },
-        {
-          selector: 'property',
-          modifiers: ['public'],
-          format: ['camelCase'],
-          leadingUnderscore: 'allow',
-        },
-        {
-          // Object literals may be constructed as arguments to external libraries which follow different styles.
-          selector: ['objectLiteralMethod', 'objectLiteralProperty'],
-          modifiers: ['public'],
-          format: null,
-        },
-        {
-          // Ignore type properties that require quotes
-          selector : 'typeProperty',
-          format : null,
-          modifiers : ['requiresQuotes']
-        }
-      ]
-    }
-  }, {
-    files: ['*.test.ts', 'test/**/*.ts', '**/testing/*.ts'],
-    rules: {
-      // errors on it('test') with no body
-      'mocha/no-pending-tests' : 'error',
-
-      // errors on {describe, it}.only
-      'mocha/no-exclusive-tests' : 'error',
-
-      'mocha/no-async-describe': 'error',
-      'mocha/no-global-tests': 'error',
-      'mocha/no-nested-tests': 'error',
-
-      'rulesdir/check_test_definitions' : 'error',
-      'rulesdir/avoid_assert_equal' : 'error',
-      'rulesdir/no_repeated_tests' : 'error',
-      'rulesdir/compare_arrays_with_assert_deepequal' : 'error',
-      'rulesdir/ban_screenshot_test_outside_perf_panel' : 'error',
-      'rulesdir/trace_engine_test_timeouts' : 'error',
-      '@typescript-eslint/no-non-null-assertion' : 'off',
-    },
-    settings: {
-      'mocha/additionalCustomNames': [
-        { name: 'describeWithDevtoolsExtension', type: 'suite', interfaces: [ 'BDD', 'TDD' ] },
-        { name: 'describeWithEnvironment', type: 'suite', interfaces: [ 'BDD', 'TDD' ] },
-        { name: 'describeWithLocale', type: 'suite', interfaces: [ 'BDD', 'TDD' ] },
-        { name: 'describeWithMockConnection', type: 'suite', interfaces: [ 'BDD', 'TDD' ] },
-        { name: 'describeWithRealConnection', type: 'suite', interfaces: [ 'BDD', 'TDD' ] },
-        { name: 'itScreenshot', type: 'testCase', interfaces: [ 'BDD', 'TDD' ] },
-      ]
-    }
-  }],
-};
-
-// clang-format on

package/front_end/.eslintrc.js

@@ -1,96 +0,0 @@
-// Copyright 2020 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// clang-format off
-const path = require('path');
-const rulesDirPlugin = require('eslint-plugin-rulesdir');
-rulesDirPlugin.RULES_DIR = path.join(__dirname, '..', 'scripts', 'eslint_rules', 'lib');
-
-module.exports = {
-  rules: {
-    // L10n rules are only relevant in 'front_end'.
-    'rulesdir/l10n_filename_matches': [
-      'error', {
-        rootFrontendDirectory: __dirname,
-      }
-    ],
-    'rulesdir/l10n_i18nString_call_only_with_uistrings': 'error',
-    'rulesdir/l10n_no_i18nString_calls_module_instantiation': 'error',
-    'rulesdir/l10n_no_locked_or_placeholder_only_phrase': 'error',
-    'rulesdir/l10n_no_uistrings_export': 'error',
-    'rulesdir/l10n_no_unused_message': 'error',
-  },
-  overrides: [
-    {
-      files: ['*.ts'],
-      rules: {
-        '@typescript-eslint/explicit-function-return-type': [
-            'error', {
-              allowExpressions: true,
-              allowConciseArrowFunctionExpressionsStartingWithVoid: true,
-              allowIIFEs:true,
-            },
-        ],
-        'rulesdir/no_importing_images_from_src': 'error',
-        'rulesdir/enforce_bound_render_for_schedule_render': 'error',
-        'rulesdir/enforce_custom_event_names': 'error',
-        'rulesdir/set_data_type_reference': 'error',
-        'rulesdir/no_bound_component_methods': 'error',
-        'rulesdir/lit_no_style_interpolation': 'error',
-        'rulesdir/ban_self_closing_custom_element_tagnames': 'error',
-        'rulesdir/ban_style_tags_in_lit_html': 'error',
-        'rulesdir/ban_a_tags_in_lit_html': 'error',
-        'rulesdir/check_css_import': 'error',
-        'rulesdir/enforce-optional-properties-last': 'error',
-        'rulesdir/check_enumerated_histograms': 'error',
-        'rulesdir/check_was_shown_methods': 'error',
-        'rulesdir/static_custom_event_names': 'error',
-        'rulesdir/lit_html_host_this': 'error',
-        'rulesdir/lit_html_no_attribute_quotes': 'error',
-        'rulesdir/lit_template_result_or_nothing': 'error',
-        'rulesdir/inject_checkbox_styles': 'error',
-        'rulesdir/jslog_context_list': 'error',
-      }
-    },
-    {
-      files: ['*-meta.ts'],
-      rules: {
-        '@typescript-eslint/naming-convention': [
-          'error', {
-            selector: 'parameter',
-            format: ['camelCase', 'PascalCase'],
-            leadingUnderscore: 'allow',
-          }
-        ]
-      }
-    },
-    {
-      files: ['*.test.ts', '**/testing/*.ts'],
-      rules: {
-        '@typescript-eslint/explicit-function-return-type': 'off',
-      },
-    },
-    {
-      files: ['panels/**/components/*.ts', 'ui/components/**/*.ts', 'entrypoints/**/*.ts'],
-      rules: {
-        'rulesdir/use_private_class_members': 'error',
-      }
-    },
-    // TODO(crbug/1402569): Remove once LitElement is fully adopted.
-    {
-      files: ['panels/recorder/**/*.ts', 'panels/protocol_monitor/**/*.ts', 'ui/components/suggestion_input/*.ts'],
-      rules: {
-        // TODO(crbug/1402569): Reenable once https://github.com/microsoft/TypeScript/issues/48885 is closed.
-        'rulesdir/use_private_class_members': 'off',
-      }
-    },
-    {
-      files: ['generated/SupportedCSSProperties.js'],
-      rules: {
-        'rulesdir/jslog_context_list': 'error',
-      }
-    }
-  ]
-};
-// clang-format on

package/front_end/core/sdk/CPUProfileDataModel.ts

@@ -1,17 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as CPUProfile from '../../models/cpu_profile/cpu_profile.js';
-
-// This is a temporary approach to prevent Profiler panel layout tests
-// failures. These tests depend on this class being defined under SDK.
-// However in order to use this library in the reconciled performance
-// panel, we have extracted it out to models/. Given that the profiler
-// panel is deprecated and it (and its tests) will be removed soon,
-// these tests are not ported to unit tests, instead we use this
-// workaround to prevent failures. Once the panel is gone, this file can
-// be removed.
-// TODO(crbug.com/1354548): remove this file once the Profiler Panel
-// and its tests are removed.
-export class CPUProfileDataModel extends CPUProfile.CPUProfileDataModel.CPUProfileDataModel {}

package/front_end/core/sdk/ProfileTreeModel.ts

@@ -1,17 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as CPUProfile from '../../models/cpu_profile/cpu_profile.js';
-
-// This is a temporary approach to prevent Profiler panel layout tests
-// failures. These tests depend on this class being defined under SDK.
-// However in order to use this library in the reconciled performance
-// panel, we have extracted it out to models/. Given that the profiler
-// panel is deprecated and it (and its tests) will be removed soon,
-// these tests are not ported to unit tests, instead we use this
-// workaround to prevent failures. Once the panel is gone, this file can
-// be removed.
-// TODO(crbug.com/1354548): remove this file once the Profiler Panel
-// and its tests are removed.
-export class ProfileTreeModel extends CPUProfile.ProfileTreeModel.ProfileTreeModel {}