rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/unless_else_spec.rb

@@ -1,23 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::UnlessElse do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for an unless with else' do
-    inspect_source(cop, ['unless x',
-                         '  a = 1',
-                         'else',
-                         '  a = 0',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts an unless without else' do
-    inspect_source(cop, ['unless x',
-                         '  a = 1',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/unneeded_capital_w_spec.rb

@@ -1,90 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::UnneededCapitalW do
-  subject(:cop) { described_class.new }
-
-  it 'registers no offense for normal arrays of strings' do
-    inspect_source(cop, '["one", "two", "three"]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers no offense for normal arrays of strings with interpolation' do
-    inspect_source(cop, '["one", "two", "th#{ ?r }ee"]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for misused %W' do
-    inspect_source(cop, '%W(cat dog)')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers no offense for %W with interpolation' do
-    inspect_source(cop, '%W(c#{ ?a }t dog)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers no offense for %W with special characters' do
-    source = ['def dangerous_characters',
-              '  %W(\000) +',
-              '  %W(\001) +',
-              '  %W(\027) +',
-              '  %W(\002) +',
-              '  %W(\003) +',
-              '  %W(\004) +',
-              '  %W(\005) +',
-              '  %W(\006) +',
-              '  %W(\007) +',
-              '  %W(\00) +',
-              '  %W(\a)',
-              'end']
-    inspect_source(cop, source)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers no offense for %w without interpolation' do
-    inspect_source(cop, '%w(cat dog)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers no offense for %w with interpolation-like syntax' do
-    inspect_source(cop, '%w(c#{ ?a }t dog)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers no offense for arrays with character constants' do
-    inspect_source(cop, '["one", ?\n]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for array of non-words' do
-    inspect_source(cop, '["one space", "two", "three"]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for array containing non-string' do
-    inspect_source(cop, '["one", "two", 3]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for array with one element' do
-    inspect_source(cop, '["three"]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for array with empty strings' do
-    inspect_source(cop, '["", "two", "three"]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects an array of words' do
-    new_source = autocorrect_source(cop, '%W(one two three)')
-    expect(new_source).to eq('%w(one two three)')
-  end
-
-  it 'auto-corrects an array of words with different bracket' do
-    new_source = autocorrect_source(cop, '%W[one two three]')
-    expect(new_source).to eq('%w[one two three]')
-  end
-end

data/spec/rubocop/cop/style/unneeded_percent_q_spec.rb

@@ -1,127 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::UnneededPercentQ do
-  subject(:cop) { described_class.new }
-
-  context 'with %q strings' do
-    let(:source) do
-      <<-END.strip_indent
-        %q('hi') # line 1
-        %q("hi")
-        %q(hi)
-        %q('"hi"')
-        %q('hi\\t') # line 5
-      END
-    end
-    let(:corrected) do
-      <<-END.strip_indent
-        "'hi'" # line 1
-        '"hi"'
-        'hi'
-        %q('"hi"')
-        %q('hi\\t') # line 5
-      END
-    end
-    before { inspect_source(cop, source) }
-
-    it 'registers an offense for only single quotes' do
-      expect(cop.offenses.map(&:line)).to include(1)
-      expect(cop.messages).to eq(['Use `%q` only for strings that contain ' \
-                                  'both single quotes and double quotes.'] * 3)
-    end
-
-    it 'registers an offense for only double quotes' do
-      expect(cop.offenses.map(&:line)).to include(2)
-    end
-
-    it 'registers an offense for no quotes' do
-      expect(cop.offenses.map(&:line)).to include(3)
-    end
-
-    it 'accepts a string with single quotes and double quotes' do
-      expect(cop.offenses.map(&:line)).not_to include(4)
-    end
-
-    it 'accepts a string with a tab character' do
-      expect(cop.offenses.map(&:line)).not_to include(5)
-    end
-
-    it 'auto-corrects' do
-      new_source = autocorrect_source(cop, source)
-      expect(new_source).to eq(corrected)
-    end
-  end
-
-  context 'with %Q strings' do
-    let(:source) do
-      <<-END.strip_indent
-        %Q(hi) # line 1
-        %Q("hi")
-        %Q(hi\#{4})
-        %Q('"hi"')
-        %Q("\\thi")
-        %Q("hi\#{4}")
-        /%Q?/ # line 7
-      END
-    end
-    let(:corrected) do
-      <<-END.strip_indent
-        "hi" # line 1
-        '"hi"'
-        "hi\#{4}"
-        %Q('"hi"')
-        %Q("\\thi")
-        %Q("hi\#{4}")
-        /%Q?/ # line 7
-      END
-    end
-    before { inspect_source(cop, source) }
-
-    it 'registers an offense for static string without quotes' do
-      expect(cop.offenses.map(&:line)).to include(1)
-      expect(cop.messages).to eq(['Use `%Q` only for strings that contain ' \
-                                  'both single quotes and double quotes, or ' \
-                                  'for dynamic strings that contain double ' \
-                                  'quotes.'] * 3)
-    end
-
-    it 'registers an offense for static string with only double quotes' do
-      expect(cop.offenses.map(&:line)).to include(2)
-    end
-
-    it 'registers an offense for dynamic string without quotes' do
-      expect(cop.offenses.map(&:line)).to include(3)
-    end
-
-    it 'accepts a string with single quotes and double quotes' do
-      expect(cop.offenses.map(&:line)).not_to include(4)
-    end
-
-    it 'accepts a string with double quotes and tab character' do
-      expect(cop.offenses.map(&:line)).not_to include(5)
-    end
-
-    it 'accepts a dynamic %Q string with double quotes' do
-      expect(cop.offenses.map(&:line)).not_to include(6)
-    end
-
-    it 'accepts regular expressions starting with %Q' do
-      expect(cop.offenses.map(&:line)).not_to include(7)
-    end
-
-    it 'auto-corrects' do
-      new_source = autocorrect_source(cop, source)
-      expect(new_source).to eq(corrected)
-    end
-  end
-
-  it 'accepts a heredoc string that contains %q' do
-    inspect_source(cop, ['  s = <<END',
-                         "%q('hi') # line 1",
-                         '%q("hi")',
-                         'END'])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/unneeded_percent_x_spec.rb

@@ -1,34 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::UnneededPercentX do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for a %x string without backquotes' do
-    inspect_source(cop, '%x(ls)')
-    expect(cop.messages)
-      .to eq(['Do not use `%x` unless the command string contains ' \
-              'backquotes.'])
-  end
-
-  it 'accepts a %x string with backquotes' do
-    inspect_source(cop, '%x(echo `ls`)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a `` string without inner backquotes' do
-    inspect_source(cop, '`ls`')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a `` string with inner backquotes' do
-    inspect_source(cop, '`echo \`ls\``')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects' do
-    new_source = autocorrect_source(cop, '%x(ls)')
-    expect(new_source).to eq('`ls`')
-  end
-end

data/spec/rubocop/cop/style/variable_interpolation_spec.rb

@@ -1,76 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::VariableInterpolation do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for interpolated global variables in string' do
-    inspect_source(cop,
-                   'puts "this is a #$test"')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['$test'])
-    expect(cop.messages)
-      .to eq(['Replace interpolated variable `$test`' \
-              ' with expression `#{$test}`.'])
-  end
-
-  it 'registers an offense for interpolated global variables in regexp' do
-    inspect_source(cop,
-                   'puts /this is a #$test/')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['$test'])
-    expect(cop.messages)
-      .to eq(['Replace interpolated variable `$test`' \
-              ' with expression `#{$test}`.'])
-  end
-
-  it 'registers an offense for interpolated global variables in regexp' do
-    inspect_source(cop,
-                   'puts `this is a #$test`')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['$test'])
-    expect(cop.messages)
-      .to eq(['Replace interpolated variable `$test`' \
-              ' with expression `#{$test}`.'])
-  end
-
-  it 'registers an offense for interpolated regexp back references' do
-    inspect_source(cop,
-                   'puts "this is a #$1"')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['$1'])
-    expect(cop.messages)
-      .to eq(['Replace interpolated variable `$1` with expression `#{$1}`.'])
-  end
-
-  it 'registers an offense for interpolated instance variables' do
-    inspect_source(cop,
-                   'puts "this is a #@test"')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['@test'])
-    expect(cop.messages)
-      .to eq(['Replace interpolated variable `@test`' \
-              ' with expression `#{@test}`.'])
-  end
-
-  it 'registers an offense for interpolated class variables' do
-    inspect_source(cop,
-                   'puts "this is a #@@t"')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['@@t'])
-    expect(cop.messages)
-      .to eq(['Replace interpolated variable `@@t` with expression `#{@@t}`.'])
-  end
-
-  it 'does not register an offense for variables in expressions' do
-    inspect_source(cop,
-                   'puts "this is a #{@test} #{@@t} #{$t} #{$1}"')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'autocorrects by adding the missing {}' do
-    corrected = autocorrect_source(cop, ['"some #@var"'])
-    expect(corrected).to eq '"some #{@var}"'
-  end
-end

data/spec/rubocop/cop/style/variable_name_spec.rb

@@ -1,107 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::VariableName, :config do
-  subject(:cop) { described_class.new(config) }
-
-  shared_examples 'always accepted' do
-    it 'accepts screaming snake case globals' do
-      inspect_source(cop, '$MY_GLOBAL = 0')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts screaming snake case constants' do
-      inspect_source(cop, 'MY_CONSTANT = 0')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts assigning to camel case constant' do
-      inspect_source(cop, 'Paren = Struct.new :left, :right, :kind')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts assignment with indexing of self' do
-      inspect_source(cop, 'self[:a] = b')
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when configured for snake_case' do
-    let(:cop_config) { { 'EnforcedStyle' => 'snake_case' } }
-
-    it 'registers an offense for camel case in local variable name' do
-      inspect_source(cop, 'myLocal = 1')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.highlights).to eq(['myLocal'])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
-                                                 'camelCase')
-    end
-
-    it 'registers an offense for correct + opposite' do
-      inspect_source(cop, ['my_local = 1',
-                           'myLocal = 1'])
-      expect(cop.highlights).to eq(['myLocal'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'registers an offense for camel case in instance variable name' do
-      inspect_source(cop, '@myAttribute = 3')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.highlights).to eq(['@myAttribute'])
-    end
-
-    it 'registers an offense for camel case in class variable name' do
-      inspect_source(cop, '@@myAttr = 2')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.highlights).to eq(['@@myAttr'])
-    end
-
-    include_examples 'always accepted'
-  end
-
-  context 'when configured for camelCase' do
-    let(:cop_config) { { 'EnforcedStyle' => 'camelCase' } }
-
-    it 'registers an offense for snake case in local variable name' do
-      inspect_source(cop, 'my_local = 1')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.highlights).to eq(['my_local'])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
-                                                 'snake_case')
-    end
-
-    it 'registers an offense for opposite + correct' do
-      inspect_source(cop, ['my_local = 1',
-                           'myLocal = 1'])
-      expect(cop.highlights).to eq(['my_local'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts camel case in local variable name' do
-      inspect_source(cop, 'myLocal = 1')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts camel case in instance variable name' do
-      inspect_source(cop, '@myAttribute = 3')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts camel case in class variable name' do
-      inspect_source(cop, '@@myAttr = 2')
-      expect(cop.offenses).to be_empty
-    end
-
-    include_examples 'always accepted'
-  end
-
-  context 'when configured with a bad value' do
-    let(:cop_config) { { 'EnforcedStyle' => 'other' } }
-
-    it 'fails' do
-      expect { inspect_source(cop, 'a = 3') }
-        .to raise_error(RuntimeError)
-    end
-  end
-end