rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/file_name_spec.rb

@@ -1,84 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::FileName do
-  subject(:cop) { described_class.new(config) }
-
-  let(:config) do
-    RuboCop::Config.new(
-      { 'AllCops' => { 'Include' => includes } },
-      '/some/.rubocop.yml'
-    )
-  end
-
-  let(:includes) { [] }
-  let(:source) { ['print 1'] }
-  let(:processed_source) { parse_source(source) }
-
-  before do
-    allow(processed_source.buffer)
-      .to receive(:name).and_return(filename)
-    _investigate(cop, processed_source)
-  end
-
-  context 'with camelCase file names ending in .rb' do
-    let(:filename) { '/some/dir/testCase.rb' }
-
-    it 'reports an offense' do
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'with camelCase file names without file extension' do
-    let(:filename) { '/some/dir/testCase' }
-
-    it 'reports an offense' do
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'with snake_case file names ending in .rb' do
-    let(:filename) { '/some/dir/test_case.rb' }
-
-    it 'reports an offense' do
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'with snake_case file names without file extension' do
-    let(:filename) { '/some/dir/test_case' }
-
-    it 'does not report an offense' do
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'with snake_case file names with non-rb extension' do
-    let(:filename) { '/some/dir/some_task.rake' }
-
-    it 'does not report an offense' do
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'with snake_case file names with multiple extensions' do
-    let(:filename) { 'some/dir/some_view.html.slim_spec.rb' }
-
-    it 'does not report an offense' do
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when the file is specified in AllCops/Include' do
-    let(:includes) { ['**/Gemfile'] }
-
-    context 'with a non-snake_case file name' do
-      let(:filename) { '/some/dir/Gemfile' }
-
-      it 'does not report an offense' do
-        expect(cop.offenses).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cop/style/first_parameter_indentation_spec.rb

@@ -1,304 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::FirstParameterIndentation, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:config) do
-    RuboCop::Config
-      .new('Style/FirstParameterIndentation' => {
-             'EnforcedStyle' => style,
-             'SupportedStyles' =>
-               %w(consistent special_for_inner_method_call
-                  special_for_inner_method_call_in_parentheses)
-           },
-           'Style/IndentationWidth' => { 'Width' => indentation_width })
-  end
-
-  shared_examples 'common behavior' do
-    context 'when IndentationWidth:Width is 2' do
-      let(:indentation_width) { 2 }
-
-      it 'registers an offense for an over-indented first parameter' do
-        inspect_source(cop, ['run(',
-                             '    :foo,',
-                             '    bar: 3',
-                             ')'])
-        expect(cop.messages).to eq(['Indent the first parameter one step ' \
-                                    'more than the previous line.'])
-        expect(cop.highlights).to eq([':foo'])
-      end
-
-      it 'registers an offense for an under-indented first parameter' do
-        inspect_source(cop, ['run(',
-                             ' :foo,',
-                             '    bar: 3',
-                             ')'])
-        expect(cop.highlights).to eq([':foo'])
-      end
-
-      context 'for assignment' do
-        it 'accepts a correctly indented first parameter and does not care ' \
-           'about the second parameter' do
-          inspect_source(cop, ['x = run(',
-                               '  :foo,',
-                               '    bar: 3',
-                               ')'])
-          expect(cop.offenses).to be_empty
-        end
-
-        context 'with line break' do
-          it 'accepts a correctly indented first parameter' do
-            inspect_source(cop, ['x =',
-                                 '  run(',
-                                 '    :foo)'])
-            expect(cop.offenses).to be_empty
-          end
-
-          it 'registers an offense for an under-indented first parameter' do
-            inspect_source(cop, ['@x =',
-                                 '  run(',
-                                 '  :foo)'])
-            expect(cop.highlights).to eq([':foo'])
-          end
-        end
-      end
-
-      it 'accepts a first parameter that is not preceded by a line break' do
-        inspect_source(cop, ['run :foo,',
-                             '    bar: 3'])
-        expect(cop.offenses).to be_empty
-      end
-
-      context 'when the receiver contains a line break' do
-        it 'accepts a correctly indented first parameter' do
-          inspect_source(cop, ['puts x.',
-                               '  merge(',
-                               '    b: 2',
-                               '  )'])
-          expect(cop.offenses).to be_empty
-        end
-
-        it 'registers an offense for an over-indented first parameter' do
-          inspect_source(cop, ['puts x.',
-                               '  merge(',
-                               '      b: 2',
-                               '  )'])
-          expect(cop.messages).to eq(['Indent the first parameter one step ' \
-                                      'more than the previous line.'])
-          expect(cop.highlights).to eq(['b: 2'])
-        end
-
-        it 'accepts a correctly indented first parameter preceded by an ' \
-           'empty line' do
-          inspect_source(cop, ['puts x.',
-                               '  merge(',
-                               '',
-                               '    b: 2',
-                               '  )'])
-          expect(cop.offenses).to be_empty
-        end
-
-        context 'when preceded by a comment line' do
-          it 'accepts a correctly indented first parameter' do
-            inspect_source(cop, ['puts x.',
-                                 '  merge( # EOL comment',
-                                 '    # comment',
-                                 '    b: 2',
-                                 '  )'])
-            expect(cop.offenses).to be_empty
-          end
-
-          it 'registers an offense for an under-indented first parameter' do
-            inspect_source(cop, ['puts x.',
-                                 '  merge(',
-                                 '  # comment',
-                                 '  b: 2',
-                                 '  )'])
-            expect(cop.messages).to eq(['Indent the first parameter one ' \
-                                        'step more than the previous line ' \
-                                        '(not counting the comment).'])
-            expect(cop.highlights).to eq(['b: 2'])
-          end
-        end
-      end
-
-      it 'accepts method calls with no parameters' do
-        inspect_source(cop, ['run()',
-                             'run_again'])
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'accepts operator calls' do
-        inspect_source(cop, ['params = default_cfg.keys - %w(Description) -',
-                             '         cfg.keys'])
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'does not view []= as an outer method call' do
-        inspect_source(cop, ['@subject_results[subject] = original.update(',
-                             '  mutation_results: (dup << mutation_result),',
-                             '  tests:            test_result.tests',
-                             ')'])
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'does not view chained call as an outer method call' do
-        inspect_source(cop, ['  A = Regexp.union(',
-                             '    /[A-Za-z_][A-Za-z\d_]*[!?=]?/,',
-                             '    *AST::Types::OPERATOR_METHODS.map(&:to_s)',
-                             '  ).freeze'])
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'auto-corrects an under-indented first parameter' do
-        new_source = autocorrect_source(cop, ['x =',
-                                              '  run(',
-                                              '  :foo,',
-                                              '    bar: 3',
-                                              ')'])
-        expect(new_source).to eq(['x =',
-                                  '  run(',
-                                  '    :foo,',
-                                  '    bar: 3',
-                                  ')'].join("\n"))
-      end
-    end
-
-    context 'when IndentationWidth:Width is 4' do
-      let(:indentation_width) { 4 }
-
-      it 'auto-corrects an over-indented first parameter' do
-        new_source = autocorrect_source(cop, ['run(',
-                                              '        :foo,',
-                                              '    bar: 3)'])
-        expect(new_source).to eq(['run(',
-                                  '    :foo,',
-                                  '    bar: 3)'].join("\n"))
-      end
-    end
-  end
-
-  context 'when EnforcedStyle is special_for_inner_method_call' do
-    let(:style) { 'special_for_inner_method_call' }
-    let(:indentation_width) { 2 }
-
-    include_examples 'common behavior'
-
-    context 'for method calls within method calls' do
-      context 'with outer parentheses' do
-        it 'registers an offense for an over-indented first parameter' do
-          inspect_source(cop, ['run(:foo, defaults.merge(',
-                               '                        bar: 3))'])
-          expect(cop.messages).to eq(['Indent the first parameter one step ' \
-                                      'more than `defaults.merge(`.'])
-          expect(cop.highlights).to eq(['bar: 3'])
-        end
-      end
-
-      context 'without outer parentheses' do
-        it 'accepts a first parameter with special indentation' do
-          inspect_source(cop, ['run :foo, defaults.merge(',
-                               '            bar: 3)'])
-          expect(cop.offenses).to be_empty
-        end
-      end
-
-      it 'auto-corrects an over-indented first parameter' do
-        new_source = autocorrect_source(cop,
-                                        ['run(:foo, defaults.merge(',
-                                         '                        bar: 3))'])
-        expect(new_source).to eq(['run(:foo, defaults.merge(',
-                                  '            bar: 3))'].join("\n"))
-      end
-    end
-  end
-
-  context 'when EnforcedStyle is ' \
-          'special_for_inner_method_call_in_parentheses' do
-    let(:style) { 'special_for_inner_method_call_in_parentheses' }
-    let(:indentation_width) { 2 }
-
-    include_examples 'common behavior'
-
-    context 'for method calls within method calls' do
-      context 'with outer parentheses' do
-        it 'registers an offense for an over-indented first parameter' do
-          inspect_source(cop, ['run(:foo, defaults.merge(',
-                               '                        bar: 3))'])
-          expect(cop.messages).to eq(['Indent the first parameter one step ' \
-                                      'more than `defaults.merge(`.'])
-          expect(cop.highlights).to eq(['bar: 3'])
-        end
-
-        it 'registers an offense for an under-indented first parameter' do
-          inspect_source(cop, ['run(:foo, defaults.',
-                               '          merge(',
-                               '  bar: 3))'])
-          expect(cop.messages).to eq(['Indent the first parameter one step ' \
-                                      'more than the previous line.'])
-          expect(cop.highlights).to eq(['bar: 3'])
-        end
-
-        it 'accepts a correctly indented first parameter in interpolation' do
-          inspect_source(cop, ['puts %(',
-                               '  <p>',
-                               '    #{Array(',
-                               '      42',
-                               '    )}',
-                               '  </p>',
-                               ')'])
-          expect(cop.offenses).to be_empty
-        end
-      end
-
-      context 'without outer parentheses' do
-        it 'accepts a first parameter with consistent style indentation' do
-          inspect_source(cop, ['run :foo, defaults.merge(',
-                               '  bar: 3)'])
-          expect(cop.offenses).to be_empty
-        end
-      end
-
-      it 'auto-corrects an over-indented first parameter' do
-        new_source = autocorrect_source(cop,
-                                        ['run(:foo, defaults.merge(',
-                                         '                        bar: 3))'])
-        expect(new_source).to eq(['run(:foo, defaults.merge(',
-                                  '            bar: 3))'].join("\n"))
-      end
-    end
-  end
-
-  context 'when EnforcedStyle is consistent' do
-    let(:style) { 'consistent' }
-    let(:indentation_width) { 2 }
-
-    include_examples 'common behavior'
-
-    context 'for method calls within method calls' do
-      it 'registers an offense for an over-indented first parameter' do
-        inspect_source(cop, ['run(:foo, defaults.merge(',
-                             '            bar: 3))'])
-        expect(cop.messages).to eq(['Indent the first parameter one step ' \
-                                    'more than the previous line.'])
-        expect(cop.highlights).to eq(['bar: 3'])
-      end
-
-      it 'accepts first parameter indented relative to previous line' do
-        inspect_source(cop,
-                       ['  @diagnostics.process(Diagnostic.new(',
-                        '    :error, :token, { :token => name }, location))'])
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'auto-corrects an over-indented first parameter' do
-        new_source = autocorrect_source(cop,
-                                        ['run(:foo, defaults.merge(',
-                                         '                        bar: 3))'])
-        expect(new_source).to eq(['run(:foo, defaults.merge(',
-                                  '  bar: 3))'].join("\n"))
-      end
-    end
-  end
-end

data/spec/rubocop/cop/style/flip_flop_spec.rb

@@ -1,23 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::FlipFlop do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for inclusive flip flops' do
-    inspect_source(cop,
-                   ['DATA.each_line do |line|',
-                    'print line if (line =~ /begin/)..(line =~ /end/)',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for exclusive flip flops' do
-    inspect_source(cop,
-                   ['DATA.each_line do |line|',
-                    'print line if (line =~ /begin/)...(line =~ /end/)',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-end

data/spec/rubocop/cop/style/for_spec.rb

@@ -1,105 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::For, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when each is the enforced style' do
-    let(:cop_config) { { 'EnforcedStyle' => 'each' } }
-
-    it 'registers an offense for for' do
-      inspect_source(cop,
-                     ['def func',
-                      '  for n in [1, 2, 3] do',
-                      '    puts n',
-                      '  end',
-                      'end'])
-      expect(cop.messages).to eq(['Prefer `each` over `for`.'])
-      expect(cop.highlights).to eq(['for'])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'for')
-    end
-
-    it 'registers an offense for opposite + correct style' do
-      inspect_source(cop,
-                     ['def func',
-                      '  for n in [1, 2, 3] do',
-                      '    puts n',
-                      '  end',
-                      '  [1, 2, 3].each do |n|',
-                      '    puts n',
-                      '  end',
-                      'end'])
-      expect(cop.messages).to eq(['Prefer `each` over `for`.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts multiline each' do
-      inspect_source(cop,
-                     ['def func',
-                      '  [1, 2, 3].each do |n|',
-                      '    puts n',
-                      '  end',
-                      'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts :for' do
-      inspect_source(cop, '[:for, :ala, :bala]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts def for' do
-      inspect_source(cop, 'def for; end')
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when for is the enforced style' do
-    let(:cop_config) { { 'EnforcedStyle' => 'for' } }
-
-    it 'accepts for' do
-      inspect_source(cop,
-                     ['def func',
-                      '  for n in [1, 2, 3] do',
-                      '    puts n',
-                      '  end',
-                      'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for multiline each' do
-      inspect_source(cop,
-                     ['def func',
-                      '  [1, 2, 3].each do |n|',
-                      '    puts n',
-                      '  end',
-                      'end'])
-      expect(cop.messages).to eq(['Prefer `for` over `each`.'])
-      expect(cop.highlights).to eq(['each'])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'each')
-    end
-
-    it 'registers an offense for correct + opposite style' do
-      inspect_source(cop,
-                     ['def func',
-                      '  for n in [1, 2, 3] do',
-                      '    puts n',
-                      '  end',
-                      '  [1, 2, 3].each do |n|',
-                      '    puts n',
-                      '  end',
-                      'end'])
-      expect(cop.messages).to eq(['Prefer `for` over `each`.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts single line each' do
-      inspect_source(cop,
-                     ['def func',
-                      '  [1, 2, 3].each { |n| puts n }',
-                      'end'])
-      expect(cop.offenses).to be_empty
-    end
-  end
-end