rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/character_literal_spec.rb

@@ -1,37 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::CharacterLiteral do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for character literals' do
-    inspect_source(cop, 'x = ?x')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for literals like \n' do
-    inspect_source(cop, 'x = ?\n')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts literals like ?\C-\M-d' do
-    inspect_source(cop, 'x = ?\C-\M-d')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts ? in a %w literal' do
-    inspect_source(cop, '%w{? A}')
-    expect(cop.offenses).to be_empty
-  end
-
-  it "auto-corrects ?x to 'x'" do
-    new_source = autocorrect_source(cop, 'x = ?x')
-    expect(new_source).to eq("x = 'x'")
-  end
-
-  it 'auto-corrects ?\n to "\\n"' do
-    new_source = autocorrect_source(cop, 'x = ?\n')
-    expect(new_source).to eq('x = "\\n"')
-  end
-end

data/spec/rubocop/cop/style/class_and_module_camel_case_spec.rb

@@ -1,40 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ClassAndModuleCamelCase do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for underscore in class and module name' do
-    inspect_source(cop,
-                   ['class My_Class',
-                    'end',
-                    '',
-                    'module My_Module',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(2)
-  end
-
-  it 'is not fooled by qualified names' do
-    inspect_source(cop,
-                   ['class Top::My_Class',
-                    'end',
-                    '',
-                    'module My_Module::Ala',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(2)
-  end
-
-  it 'accepts CamelCase names' do
-    inspect_source(cop,
-                   ['class MyClass',
-                    'end',
-                    '',
-                    'module Mine',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/class_and_module_children_spec.rb

@@ -1,133 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ClassAndModuleChildren, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'nested style' do
-    let(:cop_config) { { 'EnforcedStyle' => 'nested' } }
-
-    it 'registers an offense for not nested classes' do
-      inspect_source(cop, ['class FooClass::BarClass',
-                           'end'])
-
-      expect(cop.offenses.size).to eq 1
-      expect(cop.messages).to eq [
-        'Use nested module/class definitions instead of compact style.'
-      ]
-      expect(cop.highlights).to eq ['FooClass::BarClass']
-    end
-
-    it 'registers an offense for not nested modules' do
-      inspect_source(cop, ['module FooModule::BarModule',
-                           'end'])
-
-      expect(cop.offenses.size).to eq 1
-      expect(cop.messages).to eq [
-        'Use nested module/class definitions instead of compact style.'
-      ]
-      expect(cop.highlights).to eq ['FooModule::BarModule']
-    end
-
-    it 'accepts nested children' do
-      inspect_source(cop,
-                     ['class FooClass',
-                      '  class BarClass',
-                      '  end',
-                      'end',
-                      '',
-                      'module FooModule',
-                      '  module BarModule',
-                      '  end',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts :: in parent class on inheritance' do
-      inspect_source(cop,
-                     ['class FooClass',
-                      '  class BarClass',
-                      '  end',
-                      'end',
-                      '',
-                      'class BazClass < FooClass::BarClass',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'compact style' do
-    let(:cop_config) { { 'EnforcedStyle' => 'compact' } }
-
-    it 'registers a offense for classes with nested children' do
-      inspect_source(cop,
-                     ['class FooClass',
-                      '  class BarClass',
-                      '  end',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq 1
-      expect(cop.messages).to eq [
-        'Use compact module/class definition instead of nested style.'
-      ]
-      expect(cop.highlights).to eq ['FooClass']
-    end
-
-    it 'registers a offense for modules with nested children' do
-      inspect_source(cop,
-                     ['module FooModule',
-                      '  module BarModule',
-                      '  end',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq 1
-      expect(cop.messages).to eq [
-        'Use compact module/class definition instead of nested style.'
-      ]
-      expect(cop.highlights).to eq ['FooModule']
-    end
-
-    it 'accepts compact style for classes / modules' do
-      inspect_source(cop,
-                     ['class FooClass::BarClass',
-                      'end',
-                      '',
-                      'module FooClass::BarModule',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts nesting for classes / modules with more than one child' do
-      inspect_source(cop,
-                     ['class FooClass',
-                      '  class BarClass',
-                      '  end',
-                      '  class BazClass',
-                      '  end',
-                      'end',
-                      '',
-                      'module FooModule',
-                      '  module BarModule',
-                      '  end',
-                      '  class BazModule',
-                      '  end',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts class / module with single method' do
-      inspect_source(cop,
-                     ['class FooClass',
-                      '  def bar_method',
-                      '  end',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/style/class_check_spec.rb

@@ -1,41 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ClassCheck, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when enforced style is is_a?' do
-    let(:cop_config) { { 'EnforcedStyle' => 'is_a?' } }
-
-    it 'registers an offense for kind_of?' do
-      inspect_source(cop, 'x.kind_of? y')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.highlights).to eq(['kind_of?'])
-      expect(cop.messages)
-        .to eq(['Prefer `Object#is_a?` over `Object#kind_of?`.'])
-    end
-
-    it 'auto-corrects kind_of? to is_a?' do
-      corrected = autocorrect_source(cop, ['x.kind_of? y'])
-      expect(corrected).to eq 'x.is_a? y'
-    end
-  end
-
-  context 'when enforced style is kind_of?' do
-    let(:cop_config) { { 'EnforcedStyle' => 'kind_of?' } }
-
-    it 'registers an offense for is_a?' do
-      inspect_source(cop, 'x.is_a? y')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.highlights).to eq(['is_a?'])
-      expect(cop.messages)
-        .to eq(['Prefer `Object#kind_of?` over `Object#is_a?`.'])
-    end
-
-    it 'auto-corrects is_a? to kind_of?' do
-      corrected = autocorrect_source(cop, ['x.is_a? y'])
-      expect(corrected).to eq 'x.kind_of? y'
-    end
-  end
-end

data/spec/rubocop/cop/style/class_methods_spec.rb

@@ -1,80 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ClassMethods do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for methods using a class name' do
-    inspect_source(cop,
-                   ['class Test',
-                    '  def Test.some_method',
-                    '    do_something',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Use `self.some_method` instead of `Test.some_method`.'])
-    expect(cop.highlights).to eq(['Test'])
-  end
-
-  it 'registers an offense for methods using a module name' do
-    inspect_source(cop,
-                   ['module Test',
-                    '  def Test.some_method',
-                    '    do_something',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Use `self.some_method` instead of `Test.some_method`.'])
-    expect(cop.highlights).to eq(['Test'])
-  end
-
-  it 'does not register an offense for methods using self' do
-    inspect_source(cop,
-                   ['module Test',
-                    '  def self.some_method',
-                    '    do_something',
-                    '  end',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for other top-level singleton methods' do
-    inspect_source(cop,
-                   ['class Test',
-                    '  X = Something.new',
-                    '',
-                    '  def X.some_method',
-                    '    do_something',
-                    '  end',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense outside class/module bodies' do
-    inspect_source(cop,
-                   ['def Test.some_method',
-                    '  do_something',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'autocorrects class name to self' do
-    src = ['class Test',
-           '  def Test.some_method',
-           '    do_something',
-           '  end',
-           'end']
-
-    correct_source = ['class Test',
-                      '  def self.some_method',
-                      '    do_something',
-                      '  end',
-                      'end'].join("\n")
-
-    new_source = autocorrect_source(cop, src)
-    expect(new_source).to eq(correct_source)
-  end
-end

data/spec/rubocop/cop/style/class_vars_spec.rb

@@ -1,19 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ClassVars do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for class variable declaration' do
-    inspect_source(cop, 'class TestClass; @@test = 10; end')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Replace class var @@test with a class instance var.'])
-  end
-
-  it 'does not register an offense for class variable usage' do
-    inspect_source(cop, '@@test.test(20)')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/collection_methods_spec.rb

@@ -1,48 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::CollectionMethods, :config do
-  cop_config = {
-    'PreferredMethods' => {
-      'collect' => 'map',
-      'inject' => 'reduce',
-      'detect' => 'find',
-      'find_all' => 'select'
-    }
-  }
-
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) { cop_config }
-
-  cop_config['PreferredMethods'].each do |method, preferred_method|
-    it "registers an offense for #{method} with block" do
-      inspect_source(cop, "[1, 2, 3].#{method} { |e| e + 1 }")
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(["Prefer `#{preferred_method}` over `#{method}`."])
-    end
-
-    it "registers an offense for #{method} with proc param" do
-      inspect_source(cop, "[1, 2, 3].#{method}(&:test)")
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(["Prefer `#{preferred_method}` over `#{method}`."])
-    end
-
-    it "accepts #{method} with more than 1 param" do
-      inspect_source(cop, "[1, 2, 3].#{method}(other, &:test)")
-      expect(cop.offenses).to be_empty
-    end
-
-    it "accepts #{method} without a block" do
-      inspect_source(cop, "[1, 2, 3].#{method}")
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects to preferred method' do
-      new_source = autocorrect_source(cop, 'some.collect(&:test)')
-      expect(new_source).to eq('some.map(&:test)')
-    end
-  end
-end

data/spec/rubocop/cop/style/colon_method_call_spec.rb

@@ -1,65 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ColonMethodCall do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for instance method call' do
-    inspect_source(cop,
-                   'test::method_name')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for instance method call with arg' do
-    inspect_source(cop,
-                   'test::method_name(arg)')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for class method call' do
-    inspect_source(cop,
-                   'Class::method_name')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for class method call with arg' do
-    inspect_source(cop,
-                   'Class::method_name(arg, arg2)')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not register an offense for constant access' do
-    inspect_source(cop,
-                   'Tip::Top::SOME_CONST')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for nested class' do
-    inspect_source(cop,
-                   'Tip::Top.some_method')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for op methods' do
-    inspect_source(cop,
-                   'Tip::Top.some_method[3]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense when for constructor methods' do
-    inspect_source(cop,
-                   'Tip::Top(some_arg)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for Java static types' do
-    inspect_source(cop, 'Java::int')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects "::" with "."' do
-    new_source = autocorrect_source(cop, 'test::method')
-    expect(new_source).to eq('test.method')
-  end
-end