rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/infinite_loop_spec.rb

@@ -1,48 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::InfiniteLoop do
-  subject(:cop) { described_class.new }
-
-  %w(1 2.0 [1] {}).each do |lit|
-    it "registers an offense for a while loop with #{lit} as condition" do
-      inspect_source(cop,
-                     ["while #{lit}",
-                      '  top',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  %w(false nil).each do |lit|
-    it "registers an offense for a until loop with #{lit} as condition" do
-      inspect_source(cop,
-                     ["until #{lit}",
-                      '  top',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  it 'accepts Kernel#loop' do
-    inspect_source(cop,
-                   'loop { break if something }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects the usage of "while/until" with do' do
-    new_source = autocorrect_source(cop, ['while true do',
-                                          'end'])
-    expect(new_source).to eq("loop do\nend")
-  end
-
-  it 'auto-corrects the usage of "while/until" without do' do
-    new_source = autocorrect_source(cop, ['while 1',
-                                          'end'])
-    expect(new_source).to eq("loop do\nend")
-  end
-end

data/spec/rubocop/cop/style/inline_comment_spec.rb

@@ -1,13 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::InlineComment do
-  it 'registers an offense for a inline comment' do
-    code = 'two = 1 + 1 # An inline comment'
-
-    expect(subject).to find_offenses_in(code)
-      .with_message('Avoid inline comments.')
-      .with_highlight('# An inline comment')
-  end
-end

data/spec/rubocop/cop/style/lambda_call_spec.rb

@@ -1,65 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::LambdaCall, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when style is set to call' do
-    let(:cop_config) { { 'EnforcedStyle' => 'call' } }
-
-    it 'registers an offense for x.()' do
-      inspect_source(cop,
-                     'x.(a, b)')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'braces')
-    end
-
-    it 'registers an offense for correct + opposite' do
-      inspect_source(cop,
-                     ['x.call(a, b)',
-                      'x.(a, b)'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts x.call()' do
-      inspect_source(cop, 'x.call(a, b)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects x.() to x.call()' do
-      new_source = autocorrect_source(cop, ['a.(x)'])
-      expect(new_source).to eq('a.call(x)')
-    end
-  end
-
-  context 'when style is set to braces' do
-    let(:cop_config) { { 'EnforcedStyle' => 'braces' } }
-
-    it 'registers an offense for x.call()' do
-      inspect_source(cop,
-                     'x.call(a, b)')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'call')
-    end
-
-    it 'registers an offense for opposite + correct' do
-      inspect_source(cop,
-                     ['x.call(a, b)',
-                      'x.(a, b)'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts x.()' do
-      inspect_source(cop, 'x.(a, b)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects x.call() to x.()' do
-      new_source = autocorrect_source(cop, ['a.call(x)'])
-      expect(new_source).to eq('a.(x)')
-    end
-  end
-end

data/spec/rubocop/cop/style/lambda_spec.rb

@@ -1,76 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::Lambda do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for an old single-line lambda call' do
-    inspect_source(cop, 'f = lambda { |x| x }')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Use the new lambda literal syntax `->(params) {...}`.'])
-  end
-
-  it 'registers an offense for an old single-line no-argument lambda call' do
-    inspect_source(cop, 'f = lambda { x }')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Use the new lambda literal syntax `-> {...}`.'])
-  end
-
-  it 'accepts the new lambda literal with single-line body' do
-    inspect_source(cop, ['lambda = ->(x) { x }',
-                         'lambda.(1)'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for a new multi-line lambda call' do
-    inspect_source(cop, ['f = ->(x) do',
-                         '  x',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Use the `lambda` method for multi-line lambdas.'])
-  end
-
-  it 'accepts the old lambda syntax with multi-line body' do
-    inspect_source(cop, ['l = lambda do |x|',
-                         '  x',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts the lambda call outside of block' do
-    inspect_source(cop, 'l = lambda.test')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects an old single-line lambda call' do
-    new_source = autocorrect_source(cop, 'f = lambda { |x| x }')
-    expect(new_source).to eq('f = ->(x) { x }')
-  end
-
-  it 'auto-corrects an old single-line no-argument lambda call' do
-    new_source = autocorrect_source(cop, 'f = lambda { x }')
-    expect(new_source).to eq('f = -> { x }')
-  end
-
-  it 'auto-corrects a new multi-line lambda call' do
-    new_source = autocorrect_source(cop, ['f = ->(x) do',
-                                          '  x',
-                                          'end'])
-    expect(new_source).to eq(['f = lambda do |x|',
-                              '  x',
-                              'end'].join("\n"))
-  end
-
-  it 'auto-corrects a new multi-line no-argument lambda call' do
-    new_source = autocorrect_source(cop, ['f = -> do',
-                                          '  x',
-                                          'end'])
-    expect(new_source).to eq(['f = lambda do',
-                              '  x',
-                              'end'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/leading_comment_space_spec.rb

@@ -1,64 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::LeadingCommentSpace do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for comment without leading space' do
-    inspect_source(cop, '#missing space')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not register an offense for # followed by no text' do
-    inspect_source(cop, '#')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for more than one space' do
-    inspect_source(cop, '#   heavily indented')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for more than one #' do
-    inspect_source(cop, '###### heavily indented')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for only #s' do
-    inspect_source(cop, '######')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for #! on first line' do
-    inspect_source(cop,
-                   ['#!/usr/bin/ruby',
-                    'test'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for #! after the first line' do
-    inspect_source(cop, ['test',
-                         '#!/usr/bin/ruby'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts rdoc syntax' do
-    inspect_source(cop,
-                   ['#++',
-                    '#--',
-                    '#:nodoc:'])
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts sprockets directives' do
-    inspect_source(cop, '#= require_tree .')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects missing space' do
-    new_source = autocorrect_source(cop, '#comment')
-    expect(new_source).to eq('# comment')
-  end
-end

data/spec/rubocop/cop/style/line_end_concatenation_spec.rb

@@ -1,184 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::LineEndConcatenation do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for string concat at line end' do
-    inspect_source(cop,
-                   ['top = "test" +',
-                    '"top"'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['+'])
-  end
-
-  it 'registers an offense for string concat with << at line end' do
-    inspect_source(cop,
-                   ['top = "test" <<',
-                    '"top"'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['<<'])
-  end
-
-  it 'registers an offense for string concat with << and \ at line ends' do
-    inspect_source(cop,
-                   ['top = "test " \\',
-                    '"foo" <<',
-                    '"bar"'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for dynamic string concat at line end' do
-    inspect_source(cop,
-                   ['top = "test#{x}" +',
-                    '"top"'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for dynamic string concat with << at line end' do
-    inspect_source(cop,
-                   ['top = "test#{x}" <<',
-                    '"top"'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers multiple offenses when there are chained << methods' do
-    inspect_source(cop,
-                   ['top = "test#{x}" <<',
-                    '"top" <<',
-                    '"ubertop"'])
-    expect(cop.offenses.size).to eq(2)
-  end
-
-  it 'registers multiple offenses when there are chained concatenations' do
-    inspect_source(cop,
-                   ['top = "test#{x}" +',
-                    '"top" +',
-                    '"foo"'])
-    expect(cop.offenses.size).to eq(2)
-  end
-
-  it 'registers multiple offenses when there are chained concatenations' \
-     'combined with << calls' do
-    inspect_source(cop,
-                   ['top = "test#{x}" <<',
-                    '"top" +',
-                    '"foo" <<',
-                    '"bar"'])
-    expect(cop.offenses.size).to eq(3)
-  end
-
-  it 'accepts string concat on the same line' do
-    inspect_source(cop,
-                   'top = "test" + "top"')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts string concat with a return value of method on a string' do
-    inspect_source(cop,
-                   [
-                     # What we want here is 'content   ', not '
-                     # content content content '.
-                     'content_and_three_spaces = "content" +',
-                     '  " " * 3',
-                     # Method call with dot on a string literal.
-                     "a_thing = 'a ' +",
-                     "  'gniht'.reverse",
-                     # Formatting operator.
-                     "output = 'value: ' +",
-                     "  '%d' % value",
-                     # Index operator.
-                     "'letter: ' +",
-                     "  'abcdefghij'[ix]"
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts string concat with a return value of method on an interpolated ' \
-     'string' do
-    source = <<-END
-      x3a = 'x' +
-        "\#{'a' + "\#{3}"}".reverse
-    END
-    inspect_source(cop, source)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts string concat at line end when followed by comment' do
-    inspect_source(cop,
-                   ['top = "test" + # something',
-                    '"top"'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts string concat at line end when followed by a comment line' do
-    inspect_source(cop,
-                   ['top = "test" +',
-                    '# something',
-                    '"top"'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts string concat at line end when % literals are involved' do
-    inspect_source(cop,
-                   ['top = %(test) +',
-                    '"top"'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts string concat at line end for special strings like __FILE__' do
-    inspect_source(cop,
-                   ['top = __FILE__ +',
-                    '"top"'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers offenses only for the appropriate lines in chained concats' do
-    # only the last concatenation is an offense
-    inspect_source(cop,
-                   ['top = "test#{x}" + # comment',
-                    '"foo" +',
-                    '%(bar) +',
-                    '"baz" +',
-                    '"qux"'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'autocorrects in the simple case by replacing + with \\' do
-    corrected = autocorrect_source(cop,
-                                   ['top = "test" +',
-                                    '"top"'])
-    expect(corrected).to eq ['top = "test" \\', '"top"'].join("\n")
-  end
-
-  it 'autocorrects for chained concatenations and << calls' do
-    corrected = autocorrect_source(cop,
-                                   ['top = "test#{x}" <<',
-                                    '"top" +',
-                                    '"ubertop" <<',
-                                    '"foo"'])
-
-    expect(corrected).to eq ['top = "test#{x}" \\',
-                             '"top" \\',
-                             '"ubertop" \\',
-                             '"foo"'].join("\n")
-  end
-
-  it 'autocorrects only the lines that should be autocorrected' do
-    corrected = autocorrect_source(cop,
-                                   ['top = "test#{x}" <<',
-                                    '"top" + # comment',
-                                    '"foo" +',
-                                    '"bar" +',
-                                    '%(baz) +',
-                                    '"qux"'])
-
-    expect(corrected).to eq ['top = "test#{x}" \\',
-                             '"top" + # comment',
-                             '"foo" \\',
-                             '"bar" +',
-                             '%(baz) +',
-                             '"qux"'].join("\n")
-  end
-end