rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/string_literals_spec.rb

@@ -1,228 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::StringLiterals, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'configured with single quotes preferred' do
-    let(:cop_config) { { 'EnforcedStyle' => 'single_quotes' } }
-
-    it 'registers offense for double quotes when single quotes ' \
-       'suffice' do
-      inspect_source(cop, ['s = "abc"',
-                           'x = "a\\\\b"',
-                           'y ="\\\\b"',
-                           'z = "a\\\\"'])
-      expect(cop.highlights).to eq(['"abc"',
-                                    '"a\\\\b"',
-                                    '"\\\\b"',
-                                    '"a\\\\"'])
-      expect(cop.messages)
-        .to eq(["Prefer single-quoted strings when you don't need " \
-                'string interpolation or special symbols.'] * 4)
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
-                                                 'double_quotes')
-    end
-
-    it 'registers offense for correct + opposite' do
-      inspect_source(cop, ['s = "abc"',
-                           "x = 'abc'"])
-      expect(cop.messages)
-        .to eq(["Prefer single-quoted strings when you don't need " \
-                'string interpolation or special symbols.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts single quotes' do
-      inspect_source(cop, "a = 'x'")
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts single quotes in interpolation' do
-      inspect_source(cop, %q("hello#{hash['there']}"))
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts %q and %Q quotes' do
-      inspect_source(cop, 'a = %q(x) + %Q[x]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts % quotes' do
-      inspect_source(cop, 'a = %(x)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts heredocs' do
-      inspect_source(cop,
-                     ['execute <<-SQL',
-                      '  SELECT name from users',
-                      'SQL'])
-
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts double quotes when they are needed' do
-      src = ['a = "\n"',
-             'b = "#{encode_severity}:' \
-             '#{sprintf(\'%3d\', line_number)}: #{m}"',
-             'c = "\'"',
-             'd = "#@test"',
-             'e = "#$test"',
-             'f = "\e"',
-             'g = "#@@test"']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts double quotes at the start of regexp literals' do
-      inspect_source(cop, 's = /"((?:[^\\"]|\\.)*)"/')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts double quotes with some other special symbols' do
-      # "Substitutions in double-quoted strings"
-      # http://www.ruby-doc.org/docs/ProgrammingRuby/html/language.html
-      src = ['g = "\xf9"',
-             'copyright = "\u00A9"']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts " in a %w' do
-      inspect_source(cop, '%w(")')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts \\\\\n in a string' do # this would be: "\\\n"
-      inspect_source(cop, '"foo \\\\\n bar"')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts double quotes in interpolation' do
-      src = '"#{"A"}"'
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'detects unneeded double quotes within concatenated string' do
-      src = ['"#{x}" \\', '"y"']
-      inspect_source(cop, src)
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'can handle a built-in constant parsed as string' do
-      # Parser will produce str nodes for constants such as __FILE__.
-      src = ['if __FILE__ == $PROGRAM_NAME',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'can handle character literals' do
-      src = 'a = ?/'
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects " with \'' do
-      new_source = autocorrect_source(cop, 's = "abc"')
-      expect(new_source).to eq("s = 'abc'")
-    end
-  end
-
-  context 'configured with double quotes preferred' do
-    let(:cop_config) { { 'EnforcedStyle' => 'double_quotes' } }
-
-    it 'registers offense for single quotes when double quotes would ' \
-      'be equivalent' do
-      inspect_source(cop, "s = 'abc'")
-      expect(cop.highlights).to eq(["'abc'"])
-      expect(cop.messages)
-        .to eq(['Prefer double-quoted strings unless you need ' \
-                'single quotes to avoid extra backslashes for ' \
-                'escaping.'])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
-                                                 'single_quotes')
-    end
-
-    it 'registers offense for opposite + correct' do
-      inspect_source(cop, ['s = "abc"',
-                           "x = 'abc'"])
-      expect(cop.messages)
-        .to eq(['Prefer double-quoted strings unless you need ' \
-                'single quotes to avoid extra backslashes for ' \
-                'escaping.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts double quotes' do
-      inspect_source(cop, 'a = "x"')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts single quotes in interpolation' do
-      inspect_source(cop, %q("hello#{hash['there']}"))
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts %q and %Q quotes' do
-      inspect_source(cop, 'a = %q(x) + %Q[x]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts % quotes' do
-      inspect_source(cop, 'a = %(x)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts heredocs' do
-      inspect_source(cop,
-                     ['execute <<-SQL',
-                      '  SELECT name from users',
-                      'SQL'])
-
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts single quotes when they are needed' do
-      src = ["a = '\\n'",
-             "b = '\"'"]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts single quotes at the start of regexp literals' do
-      inspect_source(cop, "s = /'((?:[^\\']|\\.)*)'/")
-      expect(cop.offenses).to be_empty
-    end
-
-    it "accepts ' in a %w" do
-      inspect_source(cop, "%w(')")
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'can handle a built-in constant parsed as string' do
-      # Parser will produce str nodes for constants such as __FILE__.
-      src = ['if __FILE__ == $PROGRAM_NAME',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it "auto-corrects ' with \"" do
-      new_source = autocorrect_source(cop, "s = 'abc'")
-      expect(new_source).to eq('s = "abc"')
-    end
-  end
-
-  context 'when configured with a bad value' do
-    let(:cop_config) { { 'EnforcedStyle' => 'other' } }
-
-    it 'fails' do
-      expect { inspect_source(cop, 'a = "b"') }
-        .to raise_error(RuntimeError)
-    end
-  end
-end

data/spec/rubocop/cop/style/struct_inheritance_spec.rb

@@ -1,44 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::StructInheritance do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense when extending instance of Struct' do
-    inspect_source(cop,
-                   ['class Person < Struct.new(:first_name, :last_name)',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense when extending instance of Struct' do
-    inspect_source(cop,
-                   ['class Person < Struct.new(:first_name, :last_name) do end',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts plain class' do
-    inspect_source(cop,
-                   ['class Person',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts extending DelegateClass' do
-    inspect_source(cop,
-                   ['class Person < DelegateClass(Animal)',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts assignment to Struct.new' do
-    inspect_source(cop, 'Person = Struct.new(:first_name, :last_name)')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/symbol_array_spec.rb

@@ -1,37 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SymbolArray do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for arrays of symbols', ruby: 2 do
-    inspect_source(cop,
-                   '[:one, :two, :three]')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not reg an offense for array with non-syms', ruby: 2 do
-    inspect_source(cop,
-                   '[:one, :two, "three"]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not reg an offense for array starting with %i', ruby: 2 do
-    inspect_source(cop,
-                   '%i(one two three)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not reg an offense for array with one element', ruby: 2 do
-    inspect_source(cop,
-                   '[:three]')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does nothing on Ruby 1.9', ruby: 1.9 do
-    inspect_source(cop,
-                   '[:one, :two, :three]')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/symbol_proc_spec.rb

@@ -1,100 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SymbolProc, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) { { 'IgnoredMethods' => %w(respond_to) } }
-
-  it 'registers an offense for a block with parameterless method call on ' \
-     'param' do
-    inspect_source(cop, 'coll.map { |e| e.upcase }')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Pass `&:upcase` as an argument to `map` instead of a block.'])
-  end
-
-  it 'registers an offense for a block when method in body is unary -/=' do
-    inspect_source(cop, 'something.map { |x| -x }')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Pass `&:-@` as an argument to `map` instead of a block.'])
-  end
-
-  it 'accepts method receiving another argument beside the block' do
-    inspect_source(cop, 'File.open(file) { |f| f.readlines }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts block with more than 1 arguments' do
-    inspect_source(cop, 'something { |x, y| x.method }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts lambda with 1 argument' do
-    inspect_source(cop, '->(x) { x.method }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts proc with 1 argument' do
-    inspect_source(cop, 'proc { |x| x.method }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts Proc.new with 1 argument' do
-    inspect_source(cop, 'Proc.new { |x| x.method }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts ignored method' do
-    inspect_source(cop, 'respond_to { |format| format.xml }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts block with no arguments' do
-    inspect_source(cop, 'something { x.method }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts empty block body' do
-    inspect_source(cop, 'something { |x| }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts block with more than 1 expression in body' do
-    inspect_source(cop, 'something { |x| x.method; something_else }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts block when method in body is not called on block arg' do
-    inspect_source(cop, 'something { |x| y.method }')
-
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'autocorrects alias with symbols as proc' do
-    corrected = autocorrect_source(cop, ['coll.map { |s| s.upcase }'])
-    expect(corrected).to eq 'coll.map(&:upcase)'
-  end
-
-  it 'autocorrects multiple aliases with symbols as proc' do
-    corrected = autocorrect_source(cop, ['coll.map { |s| s.upcase }' \
-                                         '.map { |s| s.downcase }'])
-    expect(corrected).to eq 'coll.map(&:upcase).map(&:downcase)'
-  end
-
-  it 'does not crash with a bare method call' do
-    run = -> { inspect_source(cop, 'coll.map { |s| bare_method }') }
-    expect(&run).not_to raise_error
-  end
-end

data/spec/rubocop/cop/style/tab_spec.rb

@@ -1,47 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::Tab do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for a line indented with tab' do
-    inspect_source(cop, "\tx = 0")
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for a line indented with multiple tabs' do
-    inspect_source(cop, "\t\t\tx = 0")
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for a line indented with mixed whitespace' do
-    inspect_source(cop, " \tx = 0")
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts a line with tab in a string' do
-    inspect_source(cop, "(x = \"\t\")")
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects a line indented with tab' do
-    new_source = autocorrect_source(cop, ["\tx = 0"])
-    expect(new_source).to eq('  x = 0')
-  end
-
-  it 'auto-corrects a line indented with multiple tabs' do
-    new_source = autocorrect_source(cop, ["\t\t\tx = 0"])
-    expect(new_source).to eq('      x = 0')
-  end
-
-  it 'auto-corrects a line indented with mixed whitespace' do
-    new_source = autocorrect_source(cop, [" \tx = 0"])
-    expect(new_source).to eq('   x = 0')
-  end
-
-  it 'auto-corrects a line with tab in a string indented with tab' do
-    new_source = autocorrect_source(cop, ["\t(x = \"\t\")"])
-    expect(new_source).to eq("  (x = \"\t\")")
-  end
-end