rubocop 0.29.1 → 0.30.0

data/spec/rubocop/comment_config_spec.rb

@@ -1,105 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::CommentConfig do
-  subject(:comment_config) { described_class.new(parse_source(source)) }
-
-  describe '#cop_enabled_at_line?' do
-    let(:source) do
-      [
-        '# encoding: utf-8',
-        '',
-        '# rubocop:disable Metrics/MethodLength',
-        'def some_method',
-        "  puts 'foo'",
-        'end',
-        '# rubocop:enable Metrics/MethodLength',
-        '',
-        '# rubocop:disable all',
-        'some_method',
-        '# rubocop:enable all',
-        '',
-        "code = 'This is evil.'",
-        'eval(code) # rubocop:disable Lint/Eval',
-        "puts 'This is not evil.'",
-        '',
-        'def some_method',
-        "  puts 'Disabling indented single line' # rubocop:disable " \
-        'Metrics/LineLength',
-        'end',
-        '',
-        'string = <<END',
-        'This is a string not a real comment # rubocop:disable Style/Loop',
-        'END',
-        '',
-        'foo # rubocop:disable Style/MethodCallParentheses',
-        '',
-        '# rubocop:enable Lint/Void',
-        '',
-        '# rubocop:disable Style/For',
-        'foo'
-      ]
-    end
-
-    def disabled_lines_of_cop(cop)
-      (1..source.size).each_with_object([]) do |line_number, disabled_lines|
-        enabled = comment_config.cop_enabled_at_line?(cop, line_number)
-        disabled_lines << line_number unless enabled
-      end
-    end
-
-    it 'supports disabling multiple lines with a pair of directive' do
-      method_length_disabled_lines =
-        disabled_lines_of_cop('Metrics/MethodLength')
-      expected_part = (3..6).to_a
-      expect(method_length_disabled_lines & expected_part)
-        .to eq(expected_part)
-    end
-
-    it 'supports disabling all lines after a directive' do
-      for_disabled_lines = disabled_lines_of_cop('Style/For')
-      expected_part = (29..source.size).to_a
-      expect(for_disabled_lines & expected_part)
-        .to eq(expected_part)
-    end
-
-    it 'just ignores unpaired enabling directives' do
-      void_disabled_lines = disabled_lines_of_cop('Lint/Void')
-      expected_part = (27..source.size).to_a
-      expect(void_disabled_lines & expected_part).to be_empty
-    end
-
-    it 'supports disabling single line with a directive at end of line' do
-      eval_disabled_lines = disabled_lines_of_cop('Lint/Eval')
-      expect(eval_disabled_lines).to include(14)
-      expect(eval_disabled_lines).not_to include(15)
-    end
-
-    it 'handles indented single line' do
-      line_length_disabled_lines = disabled_lines_of_cop('Metrics/LineLength')
-      expect(line_length_disabled_lines).to include(18)
-      expect(line_length_disabled_lines).not_to include(19)
-    end
-
-    it 'does not confuse a comment directive embedded in a string literal ' \
-       'with a real comment' do
-      loop_disabled_lines = disabled_lines_of_cop('Loop')
-      expect(loop_disabled_lines).not_to include(22)
-    end
-
-    it 'supports disabling all cops with keyword all' do
-      expected_part = (9..10).to_a
-
-      RuboCop::Cop::Cop.all.each do |cop|
-        disabled_lines = disabled_lines_of_cop(cop)
-        expect(disabled_lines & expected_part).to eq(expected_part)
-      end
-    end
-
-    it 'does not confuse a cop name including "all" with all cops' do
-      alias_disabled_lines = disabled_lines_of_cop('Alias')
-      expect(alias_disabled_lines).not_to include(25)
-    end
-  end
-end

data/spec/rubocop/config_loader_spec.rb

@@ -1,377 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::ConfigLoader do
-  include FileHelper
-
-  let(:default_config) { described_class.default_configuration }
-
-  describe '.configuration_file_for', :isolated_environment do
-    subject(:configuration_file_for) do
-      described_class.configuration_file_for(dir_path)
-    end
-
-    context 'when no config file exists in ancestor directories' do
-      let(:dir_path) { 'dir' }
-      before { create_file('dir/example.rb', '') }
-
-      context 'but a config file exists in home directory' do
-        before { create_file('~/.rubocop.yml', '') }
-
-        it 'returns the path to the file in home directory' do
-          expect(configuration_file_for).to end_with('home/.rubocop.yml')
-        end
-      end
-
-      context 'and no config file exists in home directory' do
-        it 'falls back to the provided default file' do
-          expect(configuration_file_for).to end_with('config/default.yml')
-        end
-      end
-    end
-
-    context 'when a config file exists in the parent directory' do
-      let(:dir_path) { 'dir' }
-
-      before do
-        create_file('dir/example.rb', '')
-        create_file('.rubocop.yml', '')
-      end
-
-      it 'returns the path to that configuration file' do
-        expect(configuration_file_for).to end_with('work/.rubocop.yml')
-      end
-    end
-
-    context 'when multiple config files exist in ancestor directories' do
-      let(:dir_path) { 'dir' }
-
-      before do
-        create_file('dir/example.rb', '')
-        create_file('dir/.rubocop.yml', '')
-        create_file('.rubocop.yml', '')
-      end
-
-      it 'prefers closer config file' do
-        expect(configuration_file_for).to end_with('dir/.rubocop.yml')
-      end
-    end
-  end
-
-  describe '.configuration_from_file', :isolated_environment do
-    subject(:configuration_from_file) do
-      described_class.configuration_from_file(file_path)
-    end
-
-    context 'with any config file' do
-      let(:file_path) { '.rubocop.yml' }
-
-      before do
-        create_file(file_path, ['Style/Encoding:',
-                                '  Enabled: false'])
-      end
-      it 'returns a configuration inheriting from default.yml' do
-        config = default_config['Style/Encoding'].dup
-        config['Enabled'] = false
-        expect(configuration_from_file)
-          .to eql(default_config.merge('Style/Encoding' => config))
-      end
-    end
-
-    context 'when multiple config files exist in ancestor directories' do
-      let(:file_path) { 'dir/.rubocop.yml' }
-
-      before do
-        create_file('.rubocop.yml',
-                    ['AllCops:',
-                     '  Exclude:',
-                     '    - vendor/**'
-                    ])
-
-        create_file(file_path,
-                    ['AllCops:',
-                     '  Exclude: []'
-                    ])
-      end
-
-      it 'gets AllCops/Exclude from the highest directory level' do
-        excludes = configuration_from_file['AllCops']['Exclude']
-        expect(excludes).to eq([File.expand_path('vendor/**')])
-      end
-    end
-
-    context 'when a file inherits from a parent file' do
-      let(:file_path) { 'dir/.rubocop.yml' }
-
-      before do
-        create_file('.rubocop.yml',
-                    ['AllCops:',
-                     '  Exclude:',
-                     '    - vendor/**',
-                     '    - !ruby/regexp /[A-Z]/'
-                    ])
-
-        create_file(file_path, ['inherit_from: ../.rubocop.yml'])
-      end
-
-      it 'gets an absolute AllCops/Exclude' do
-        excludes = configuration_from_file['AllCops']['Exclude']
-        expect(excludes).to eq([File.expand_path('vendor/**'), /[A-Z]/])
-      end
-    end
-
-    context 'when a file inherits from an empty parent file' do
-      let(:file_path) { 'dir/.rubocop.yml' }
-
-      before do
-        create_file('.rubocop.yml', [''])
-
-        create_file(file_path, ['inherit_from: ../.rubocop.yml'])
-      end
-
-      it 'does not fail to load' do
-        expect { configuration_from_file }.not_to raise_error
-      end
-    end
-
-    context 'when a file inherits from a sibling file' do
-      let(:file_path) { 'dir/.rubocop.yml' }
-
-      before do
-        create_file('src/.rubocop.yml',
-                    ['AllCops:',
-                     '  Exclude:',
-                     '    - vendor/**'
-                    ])
-
-        create_file(file_path, ['inherit_from: ../src/.rubocop.yml'])
-      end
-
-      it 'gets an absolute AllCops/Exclude' do
-        excludes = configuration_from_file['AllCops']['Exclude']
-        expect(excludes).to eq([File.expand_path('src/vendor/**')])
-      end
-    end
-
-    context 'when a file inherits from a parent and grandparent file' do
-      let(:file_path) { 'dir/subdir/.rubocop.yml' }
-
-      before do
-        create_file('dir/subdir/example.rb', '')
-
-        create_file('.rubocop.yml',
-                    ['Metrics/LineLength:',
-                     '  Enabled: false',
-                     '  Max: 77'])
-
-        create_file('dir/.rubocop.yml',
-                    ['inherit_from: ../.rubocop.yml',
-                     '',
-                     'Metrics/MethodLength:',
-                     '  Enabled: true',
-                     '  CountComments: false',
-                     '  Max: 10'
-                    ])
-
-        create_file(file_path,
-                    ['inherit_from: ../.rubocop.yml',
-                     '',
-                     'Metrics/LineLength:',
-                     '  Enabled: true',
-                     '',
-                     'Metrics/MethodLength:',
-                     '  Max: 5'
-                    ])
-      end
-
-      it 'returns the ancestor configuration plus local overrides' do
-        config =
-          default_config.merge(
-            'Metrics/LineLength' => {
-              'Description' =>
-              default_config['Metrics/LineLength']['Description'],
-              'StyleGuide' =>
-              'https://github.com/bbatsov/ruby-style-guide#80-character-limits',
-              'Enabled' => true,
-              'Max' => 77,
-              'AllowURI' => true,
-              'URISchemes' => %w(http https)
-            },
-            'Metrics/MethodLength' => {
-              'Description' =>
-              default_config['Metrics/MethodLength']['Description'],
-              'StyleGuide' =>
-              'https://github.com/bbatsov/ruby-style-guide#short-methods',
-              'Enabled' => true,
-              'CountComments' => false,
-              'Max' => 5
-            })
-        expect(configuration_from_file).to eq(config)
-      end
-    end
-
-    context 'when a file inherits from two configurations' do
-      let(:file_path) { '.rubocop.yml' }
-
-      before do
-        create_file('example.rb', '')
-
-        create_file('normal.yml',
-                    ['Metrics/MethodLength:',
-                     '  Enabled: false',
-                     '  CountComments: true',
-                     '  Max: 80'])
-
-        create_file('special.yml',
-                    ['Metrics/MethodLength:',
-                     '  Enabled: false',
-                     '  Max: 200'])
-
-        create_file(file_path,
-                    ['inherit_from:',
-                     '  - normal.yml',
-                     '  - special.yml',
-                     '',
-                     'Metrics/MethodLength:',
-                     '  Enabled: true'
-                    ])
-      end
-
-      it 'returns values from the last one when possible' do
-        expected = { 'Enabled' => true,        # overridden in .rubocop.yml
-                     'CountComments' => true,  # only defined in normal.yml
-                     'Max' => 200 }            # special.yml takes precedence
-        expect(configuration_from_file['Metrics/MethodLength'].to_set)
-          .to be_superset(expected.to_set)
-      end
-    end
-
-    context 'when a file inherits from an expanded path' do
-      let(:file_path) { '.rubocop.yml' }
-
-      before do
-        create_file('~/.rubocop.yml', [''])
-        create_file(file_path, ['inherit_from: ~/.rubocop.yml'])
-      end
-
-      it 'does not fail to load expanded path' do
-        expect { configuration_from_file }.not_to raise_error
-      end
-    end
-  end
-
-  describe '.load_file', :isolated_environment do
-    subject(:load_file) do
-      described_class.load_file(configuration_path)
-    end
-
-    let(:configuration_path) { '.rubocop.yml' }
-
-    it 'returns a configuration loaded from the passed path' do
-      create_file(configuration_path, [
-        'Style/Encoding:',
-        '  Enabled: true'
-      ])
-      configuration = load_file
-      expect(configuration['Style/Encoding']).to eq(
-        'Enabled' => true
-      )
-    end
-
-    it 'fails with a TypeError when loading a malformed configuration file' do
-      create_file(configuration_path, 'This string is not a YAML hash')
-      expect { load_file }.to raise_error(
-        TypeError, /^Malformed configuration in .*\.rubocop\.yml$/
-      )
-    end
-
-    it 'returns an empty configuration loaded from an empty file' do
-      create_file(configuration_path, '')
-      configuration = load_file
-      expect(configuration).to eq({})
-    end
-  end
-
-  describe '.merge' do
-    subject(:merge) { described_class.merge(base, derived) }
-
-    let(:base) do
-      {
-        'AllCops' => {
-          'Include' => ['**/*.gemspec', '**/Rakefile'],
-          'Exclude' => []
-        }
-      }
-    end
-    let(:derived) do
-      { 'AllCops' => { 'Exclude' => ['example.rb', 'exclude_*'] } }
-    end
-
-    it 'returns a recursive merge of its two arguments' do
-      expect(merge).to eq('AllCops' => {
-                            'Include' => ['**/*.gemspec', '**/Rakefile'],
-                            'Exclude' => ['example.rb', 'exclude_*']
-                          })
-    end
-  end
-
-  describe 'configuration for SymbolArray', :isolated_environment do
-    let(:config) do
-      config_path = described_class.configuration_file_for('.')
-      described_class.configuration_from_file(config_path)
-    end
-
-    context 'when no config file exists for the target file' do
-      it 'is disabled' do
-        expect(config.cop_enabled?('Style/SymbolArray')).to be_falsey
-      end
-    end
-
-    context 'when a config file which does not mention SymbolArray exists' do
-      it 'is disabled' do
-        create_file('.rubocop.yml', [
-          'Metrics/LineLength:',
-          '  Max: 80'
-        ])
-        expect(config.cop_enabled?('Style/SymbolArray')).to be_falsey
-      end
-    end
-
-    context 'when a config file which explicitly enables SymbolArray exists' do
-      it 'is enabled' do
-        create_file('.rubocop.yml', [
-          'Style/SymbolArray:',
-          '  Enabled: true'
-        ])
-        expect(config.cop_enabled?('Style/SymbolArray')).to be_truthy
-      end
-    end
-  end
-
-  describe 'configuration for AssignmentInCondition' do
-    describe 'AllowSafeAssignment' do
-      it 'is enabled by default' do
-        default_config = described_class.default_configuration
-        symbol_name_config =
-          default_config.for_cop('Lint/AssignmentInCondition')
-        expect(symbol_name_config['AllowSafeAssignment']).to be_truthy
-      end
-    end
-  end
-
-  describe 'when a requirement is defined', :isolated_environment do
-    let(:required_file_path) { './required_file.rb' }
-
-    before do
-      create_file('.rubocop.yml', ['require:', "  - #{required_file_path}"])
-      create_file(required_file_path, ['class MyClass', 'end'])
-    end
-
-    it 'requires the passed path' do
-      config_path = described_class.configuration_file_for('.')
-      described_class.configuration_from_file(config_path)
-      expect(defined?(MyClass)).to be_truthy
-    end
-  end
-end