rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/encoding_spec.rb

@@ -1,139 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::Encoding, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when_needed' do
-    let(:cop_config) do
-      { 'EnforcedStyle' => 'when_needed' }
-    end
-
-    it 'registers no offense when no encoding present but only ASCII ' \
-       'characters' do
-      inspect_source(cop, 'def foo() end')
-
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense when there is no encoding present but non ' \
-       'ASCII characters' do
-      inspect_source(cop, 'def foo() \'ä\' end')
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages).to eq(
-        ['Missing utf-8 encoding comment.'])
-    end
-
-    it 'registers an offense when encoding present but only ASCII ' \
-       'characters' do
-      inspect_source(cop, ['# encoding: utf-8',
-                           'def foo() end'])
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages).to eq(
-        ['Unnecessary utf-8 encoding comment.'])
-    end
-
-    it 'accepts an empty file' do
-      inspect_source(cop, '')
-
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts encoding on first line' do
-      inspect_source(cop, ['# encoding: utf-8',
-                           'def foo() \'ä\' end'])
-
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts encoding on second line when shebang present' do
-      inspect_source(cop, ['#!/usr/bin/env ruby',
-                           '# encoding: utf-8',
-                           'def foo() \'ä\' end'])
-
-      expect(cop.messages).to be_empty
-    end
-
-    it 'books an offense when encoding is in the wrong place' do
-      inspect_source(cop, ['def foo() \'ä\' end',
-                           '# encoding: utf-8'])
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages).to eq(
-        ['Missing utf-8 encoding comment.'])
-    end
-
-    it 'accepts encoding inserted by magic_encoding gem' do
-      inspect_source(cop, ['# -*- encoding : utf-8 -*-',
-                           'def foo() \'ä\' end'])
-
-      expect(cop.messages).to be_empty
-    end
-
-    it 'accepts vim-style encoding comments' do
-      inspect_source(cop, ['# vim:fileencoding=utf-8',
-                           'def foo() \'ä\' end'])
-      expect(cop.messages).to be_empty
-    end
-  end
-
-  context 'always' do
-    let(:cop_config) do
-      { 'EnforcedStyle' => 'always' }
-    end
-
-    it 'registers an offense when no encoding present' do
-      inspect_source(cop, 'def foo() end')
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages).to eq(
-        ['Missing utf-8 encoding comment.'])
-    end
-
-    it 'accepts an empty file' do
-      inspect_source(cop, '')
-
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts encoding on first line' do
-      inspect_source(cop, ['# encoding: utf-8',
-                           'def foo() end'])
-
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts encoding on second line when shebang present' do
-      inspect_source(cop, ['#!/usr/bin/env ruby',
-                           '# encoding: utf-8',
-                           'def foo() end'])
-
-      expect(cop.messages).to be_empty
-    end
-
-    it 'books an offense when encoding is in the wrong place' do
-      inspect_source(cop, ['def foo() end',
-                           '# encoding: utf-8'])
-
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages).to eq(
-        ['Missing utf-8 encoding comment.'])
-    end
-
-    it 'accepts encoding inserted by magic_encoding gem' do
-      inspect_source(cop, ['# -*- encoding : utf-8 -*-',
-                           'def foo() end'])
-
-      expect(cop.messages).to be_empty
-    end
-
-    it 'accepts vim-style encoding comments' do
-      inspect_source(cop, ['# vim:fileencoding=utf-8',
-                           'def foo() end'])
-      expect(cop.messages).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/style/end_block_spec.rb

@@ -1,13 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::EndBlock do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offense for an END block' do
-    src = 'END { test }'
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-end

data/spec/rubocop/cop/style/end_of_line_spec.rb

@@ -1,65 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-require 'tempfile'
-
-describe RuboCop::Cop::Style::EndOfLine do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for CR+LF' do
-    inspect_source_file(cop, ['x=0', '', "y=1\r"])
-    expect(cop.messages).to eq(['Carriage return character detected.'])
-  end
-
-  it 'highlights the whole offending line' do
-    inspect_source_file(cop, ['x=0', '', "y=1\r"])
-    expect(cop.highlights).to eq(["y=1\r"])
-  end
-
-  it 'registers an offense for CR at end of file' do
-    inspect_source_file(cop, "x=0\r")
-    expect(cop.messages).to eq(['Carriage return character detected.'])
-  end
-
-  shared_examples 'iso-8859-15' do
-    it 'can inspect non-UTF-8 encoded source with proper encoding comment' do
-      inspect_source_file(cop, ['# coding: ISO-8859-15\r',
-                                "# Euro symbol: \xa4\r"])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'when there are many lines ending with CR+LF' do
-    it 'registers only one offense' do
-      inspect_source_file(cop, ['x=0', '', 'y=1'].join("\r\n"))
-      expect(cop.messages.size).to eq(1)
-    end
-
-    include_examples 'iso-8859-15'
-  end
-
-  context 'when the default external encoding is US_ASCII' do
-    let(:orig_encoding) { Encoding.default_external }
-    before(:each) { Encoding.default_external = Encoding::US_ASCII }
-    after(:each) { Encoding.default_external = orig_encoding }
-
-    it 'does not crash on UTF-8 encoded non-ascii characters' do
-      inspect_source_file(cop,
-                          ['# encoding: UTF-8',
-                           'class Epd::ReportsController < EpdAreaController',
-                           "  'terecht bij uw ROM-coördinator.'",
-                           'end'].join("\n"))
-      expect(cop.offenses).to be_empty
-    end
-
-    include_examples 'iso-8859-15'
-  end
-
-  context 'when source is a string' do
-    it 'registers an offense' do
-      inspect_source(cop, "x=0\r")
-
-      expect(cop.messages).to eq(['Carriage return character detected.'])
-    end
-  end
-end

data/spec/rubocop/cop/style/even_odd_spec.rb

@@ -1,164 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::EvenOdd do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for x % 2 == 0' do
-    inspect_source(cop, 'x % 2 == 0')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#even?`.'])
-  end
-
-  it 'registers an offense for x % 2 != 0' do
-    inspect_source(cop, 'x % 2 != 0')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#odd?`.'])
-  end
-
-  it 'registers an offense for (x % 2) == 0' do
-    inspect_source(cop, '(x % 2) == 0')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#even?`.'])
-  end
-
-  it 'registers an offense for (x % 2) != 0' do
-    inspect_source(cop, '(x % 2) != 0')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#odd?`.'])
-  end
-
-  it 'registers an offense for x % 2 == 1' do
-    inspect_source(cop, 'x % 2 == 1')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#odd?`.'])
-  end
-
-  it 'registers an offense for x % 2 != 1' do
-    inspect_source(cop, 'x % 2 != 1')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#even?`.'])
-  end
-
-  it 'registers an offense for (x % 2) == 1' do
-    inspect_source(cop, '(x % 2) == 1')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#odd?`.'])
-  end
-
-  it 'registers an offense for (x % 2) != 1' do
-    inspect_source(cop, '(x % 2) != 1')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#even?`.'])
-  end
-
-  it 'registers an offense for (x.y % 2) != 1' do
-    inspect_source(cop, '(x.y % 2) != 1')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#even?`.'])
-  end
-
-  it 'registers an offense for (x(y) % 2) != 1' do
-    inspect_source(cop, '(x(y) % 2) != 1')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Replace with `Fixnum#even?`.'])
-  end
-
-  it 'accepts x % 3 == 0' do
-    inspect_source(cop, 'x % 3 == 0')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts x % 3 != 0' do
-    inspect_source(cop, 'x % 3 != 0')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'converts x % 2 == 0 to #even?' do
-    corrected = autocorrect_source(cop, 'x % 2 == 0')
-    expect(corrected).to eq('x.even?')
-  end
-
-  it 'converts x % 2 != 0 to #odd?' do
-    corrected = autocorrect_source(cop, 'x % 2 != 0')
-    expect(corrected).to eq('x.odd?')
-  end
-
-  it 'converts (x % 2) == 0 to #even?' do
-    corrected = autocorrect_source(cop, '(x % 2) == 0')
-    expect(corrected).to eq('x.even?')
-  end
-
-  it 'converts (x % 2) != 0 to #odd?' do
-    corrected = autocorrect_source(cop, '(x % 2) != 0')
-    expect(corrected).to eq('x.odd?')
-  end
-
-  it 'converts x % 2 == 1 to odd?' do
-    corrected = autocorrect_source(cop, 'x % 2 == 1')
-    expect(corrected).to eq('x.odd?')
-  end
-
-  it 'converts x % 2 != 1 to even?' do
-    corrected = autocorrect_source(cop, 'x % 2 != 1')
-    expect(corrected).to eq('x.even?')
-  end
-
-  it 'converts (x % 2) == 1 to odd?' do
-    corrected = autocorrect_source(cop, '(x % 2) == 1')
-    expect(corrected).to eq('x.odd?')
-  end
-
-  it 'converts (y % 2) != 1 to even?' do
-    corrected = autocorrect_source(cop, '(y % 2) != 1')
-    expect(corrected).to eq('y.even?')
-  end
-
-  it 'converts (x.y % 2) != 1 to even?' do
-    corrected = autocorrect_source(cop, '(x.y % 2) != 1')
-    expect(corrected).to eq('x.y.even?')
-  end
-
-  it 'converts (x(y) % 2) != 1 to even?' do
-    corrected = autocorrect_source(cop, '(x(y) % 2) != 1')
-    expect(corrected).to eq('x(y).even?')
-  end
-
-  it 'converts (x._(y) % 2) != 1 to even?' do
-    corrected = autocorrect_source(cop, '(x._(y) % 2) != 1')
-    expect(corrected).to eq('x._(y).even?')
-  end
-
-  it 'converts (x._(y)) % 2 != 1 to even?' do
-    corrected = autocorrect_source(cop, '(x._(y)) % 2 != 1')
-    expect(corrected).to eq('(x._(y)).even?')
-  end
-
-  it 'converts x._(y) % 2 != 1 to even?' do
-    corrected = autocorrect_source(cop, 'x._(y) % 2 != 1')
-    expect(corrected).to eq('x._(y).even?')
-  end
-
-  it 'converts 1 % 2 != 1 to even?' do
-    corrected = autocorrect_source(cop, '1 % 2 != 1')
-    expect(corrected).to eq('1.even?')
-  end
-
-  it 'converts complex examples' do
-    corrected = autocorrect_source(cop, [
-      'if (y % 2) != 1',
-      '  method == :== ? :even : :odd',
-      'elsif x % 2 == 1',
-      '  method == :== ? :odd : :even',
-      'end'
-    ])
-    expect(corrected).to eq([
-      'if y.even?',
-      '  method == :== ? :even : :odd',
-      'elsif x.odd?',
-      '  method == :== ? :odd : :even',
-      'end'
-    ].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/extra_spacing_spec.rb

@@ -1,68 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ExtraSpacing do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for double extra spacing on variable assignment' do
-    inspect_source(cop, 'm    = "hello"')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'ignores whitespace at the beginning of the line' do
-    inspect_source(cop, '  m = "hello"')
-    expect(cop.offenses.size).to eq(0)
-  end
-
-  it 'ignores whitespace inside a string' do
-    inspect_source(cop, 'm = "hello   this"')
-    expect(cop.offenses.size).to eq(0)
-  end
-
-  it 'does not permit you to line up assignments' do
-    inspect_source(cop, [
-      'website = "example.org"',
-      'name    = "Jill"'
-    ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'gives the correct line' do
-    inspect_source(cop, [
-      'website = "example.org"',
-      'name    = "Jill"'
-    ])
-    expect(cop.offenses.first.location.line).to eq(2)
-  end
-
-  it 'registers an offense on class inheritance' do
-    inspect_source(cop, [
-      'class A   < String',
-      'end'
-    ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'auto-corrects a line indented with mixed whitespace' do
-    new_source = autocorrect_source(cop, [
-      'website = "example.org"',
-      'name    = "Jill"'
-    ])
-    expect(new_source).to eq([
-      'website = "example.org"',
-      'name = "Jill"'
-    ].join("\n"))
-  end
-
-  it 'auto-corrects the class inheritance' do
-    new_source = autocorrect_source(cop, [
-      'class A   < String',
-      'end'
-    ])
-    expect(new_source).to eq([
-      'class A < String',
-      'end'
-    ].join("\n"))
-  end
-end