rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/array_join_spec.rb

@@ -1,29 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ArrayJoin do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for an array followed by string' do
-    inspect_source(cop,
-                   '%w(one two three) * ", "')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not register an offense for numbers' do
-    inspect_source(cop,
-                   '%w(one two three) * 4')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for ambiguous cases' do
-    inspect_source(cop,
-                   'test * ", "')
-    expect(cop.offenses).to be_empty
-
-    inspect_source(cop,
-                   '%w(one two three) * test')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/ascii_comments_spec.rb

@@ -1,21 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::AsciiComments do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for a comment with non-ascii chars' do
-    inspect_source(cop,
-                   ['# encoding: utf-8',
-                    '# 这是什么？'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Use only ascii symbols in comments.'])
-  end
-
-  it 'accepts comments with only ascii chars' do
-    inspect_source(cop, '# AZaz1@$%~,;*_`|')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/ascii_identifiers_spec.rb

@@ -1,36 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::AsciiIdentifiers do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for a variable name with non-ascii chars' do
-    inspect_source(cop,
-                   ['# encoding: utf-8',
-                    'älg = 1'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Use only ascii symbols in identifiers.'])
-  end
-
-  it 'accepts identifiers with only ascii chars' do
-    inspect_source(cop,
-                   'x.empty?')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not get confused by a byte order mark' do
-    bom = "\xef\xbb\xbf"
-    inspect_source(cop,
-                   [bom + '# encoding: utf-8',
-                    "puts 'foo'"])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not get confused by an empty file' do
-    inspect_source(cop,
-                   '')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/attr_spec.rb

@@ -1,29 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::Attr do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense attr' do
-    inspect_source(cop, ['class SomeClass',
-                         '  attr :name',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts attr when it does not take arguments' do
-    inspect_source(cop, 'func(attr)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts attr when it has a receiver' do
-    inspect_source(cop, 'x.attr arg')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects attr to attr_reader' do
-    new_source = autocorrect_source(cop, 'attr :name')
-    expect(new_source).to eq('attr_reader :name')
-  end
-end

data/spec/rubocop/cop/style/bare_percent_literals_spec.rb

@@ -1,132 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::BarePercentLiterals, :config do
-  subject(:cop) { described_class.new(config) }
-
-  shared_examples 'accepts other delimiters' do
-    it 'accepts __FILE__' do
-      inspect_source(cop, '__FILE__')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts regular expressions' do
-      inspect_source(cop, '/%Q?/')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts ""' do
-      inspect_source(cop, '""')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts "" string with interpolation' do
-      inspect_source(cop, '"#{file}hi"')
-      expect(cop.offenses).to be_empty
-    end
-
-    it "accepts ''" do
-      inspect_source(cop, "'hi'")
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts %q' do
-      inspect_source(cop, '%q(hi)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts heredoc' do
-      inspect_source(cop, ['func <<END',
-                           'hi',
-                           'END'])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when EnforcedStyle is percent_q' do
-    let(:cop_config) { { 'EnforcedStyle' => 'percent_q' } }
-
-    context 'and strings are static' do
-      it 'registers an offense for %()' do
-        inspect_source(cop, '%(hi)')
-        expect(cop.messages).to eq(['Use `%Q` instead of `%`.'])
-        expect(cop.highlights).to eq(['%('])
-      end
-
-      it 'auto-corrects' do
-        new_source = autocorrect_source(cop, '%(hi)')
-        expect(new_source).to eq('%Q(hi)')
-      end
-
-      it 'accepts %Q()' do
-        inspect_source(cop, '%Q(hi)')
-        expect(cop.offenses).to be_empty
-      end
-
-      include_examples 'accepts other delimiters'
-    end
-
-    context 'and strings are dynamic' do
-      it 'registers an offense for %()' do
-        inspect_source(cop, '%(#{x})')
-        expect(cop.messages).to eq(['Use `%Q` instead of `%`.'])
-      end
-
-      it 'auto-corrects' do
-        new_source = autocorrect_source(cop, '%(#{x})')
-        expect(new_source).to eq('%Q(#{x})')
-      end
-
-      it 'accepts %Q()' do
-        inspect_source(cop, '%Q(#{x})')
-        expect(cop.offenses).to be_empty
-      end
-
-      include_examples 'accepts other delimiters'
-    end
-  end
-
-  context 'when EnforcedStyle is bare_percent' do
-    let(:cop_config) { { 'EnforcedStyle' => 'bare_percent' } }
-
-    context 'and strings are static' do
-      it 'registers an offense for %Q()' do
-        inspect_source(cop, '%Q(hi)')
-        expect(cop.messages).to eq(['Use `%` instead of `%Q`.'])
-        expect(cop.highlights).to eq(['%Q('])
-      end
-
-      it 'auto-corrects' do
-        new_source = autocorrect_source(cop, '%Q(hi)')
-        expect(new_source).to eq('%(hi)')
-      end
-
-      it 'accepts %()' do
-        inspect_source(cop, '%(hi)')
-        expect(cop.offenses).to be_empty
-      end
-
-      include_examples 'accepts other delimiters'
-    end
-
-    context 'and strings are dynamic' do
-      it 'registers an offense for %Q()' do
-        inspect_source(cop, '%Q(#{x})')
-        expect(cop.messages).to eq(['Use `%` instead of `%Q`.'])
-      end
-
-      it 'auto-corrects' do
-        new_source = autocorrect_source(cop, '%Q(#{x})')
-        expect(new_source).to eq('%(#{x})')
-      end
-
-      it 'accepts %()' do
-        inspect_source(cop, '%(#{x})')
-        expect(cop.offenses).to be_empty
-      end
-
-      include_examples 'accepts other delimiters'
-    end
-  end
-end

data/spec/rubocop/cop/style/begin_block_spec.rb

@@ -1,13 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::BeginBlock do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offense for a BEGIN block' do
-    src = 'BEGIN { test }'
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-end

data/spec/rubocop/cop/style/block_comments_spec.rb

@@ -1,45 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::BlockComments do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for block comments' do
-    inspect_source(cop,
-                   ['=begin',
-                    'comment',
-                    '=end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts regular comments' do
-    inspect_source(cop,
-                   '# comment')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects a block comment into a regular comment' do
-    new_source = autocorrect_source(cop, ['=begin',
-                                          'comment line 1',
-                                          '',
-                                          'comment line 2',
-                                          '=end',
-                                          'def foo',
-                                          'end'])
-    expect(new_source).to eq(['# comment line 1',
-                              '#',
-                              '# comment line 2',
-                              'def foo',
-                              'end'].join("\n"))
-  end
-
-  it 'auto-corrects an empty block comment by removing it' do
-    new_source = autocorrect_source(cop, ['=begin',
-                                          '=end',
-                                          'def foo',
-                                          'end'])
-    expect(new_source).to eq(['def foo',
-                              'end'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/block_end_newline_spec.rb

@@ -1,61 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::BlockEndNewline do
-  subject(:cop) { described_class.new }
-
-  it 'does not register an offense for a one-liner' do
-    inspect_source(cop, 'test do foo end')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'does not register an offense for multiline blocks with newlines before '\
-     'the end' do
-    inspect_source(cop,
-                   ['test do',
-                    '  foo',
-                    'end'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'registers an offense when multiline block end is not on its own line' do
-    inspect_source(cop,
-                   ['test do',
-                    '  foo end'
-                   ])
-    expect(cop.messages)
-      .to eq(['Expression at 2, 7 should be on its own line.'])
-  end
-
-  it 'registers an offense when multiline block } is not on its own line' do
-    inspect_source(cop,
-                   ['test {',
-                    '  foo }'
-                   ])
-    expect(cop.messages)
-      .to eq(['Expression at 2, 7 should be on its own line.'])
-  end
-
-  it 'autocorrects a do/end block where the end is not on its own line' do
-    src =  ['test do',
-            '  foo end']
-
-    new_source = autocorrect_source(cop, src)
-
-    expect(new_source).to eq(['test do',
-                              '  foo ',
-                              'end'].join("\n"))
-  end
-
-  it 'autocorrects a {} block where the } is not on its own line' do
-    src =  ['test {',
-            '  foo }']
-
-    new_source = autocorrect_source(cop, src)
-
-    expect(new_source).to eq(['test {',
-                              '  foo ',
-                              '}'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/blocks_spec.rb

@@ -1,121 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::Blocks do
-  subject(:cop) { described_class.new }
-
-  it 'accepts a multiline block with do-end' do
-    inspect_source(cop, ['each do |x|',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for a single line block with do-end' do
-    inspect_source(cop, 'each do |x| end')
-    expect(cop.messages)
-      .to eq(['Prefer {...} over do...end for single-line blocks.'])
-  end
-
-  it 'accepts a single line block with braces' do
-    inspect_source(cop, 'each { |x| }')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects do and end for single line blocks to { and }' do
-    new_source = autocorrect_source(cop, 'block do |x| end')
-    expect(new_source).to eq('block { |x| }')
-  end
-
-  it 'does not auto-correct do-end if {} would change the meaning' do
-    src = "s.subspec 'Subspec' do |sp| end"
-    new_source = autocorrect_source(cop, src)
-    expect(new_source).to eq(src)
-  end
-
-  it 'does not auto-correct {} if do-end would change the meaning' do
-    src = ['foo :bar, :baz, qux: lambda { |a|',
-           '  bar a',
-           '}'].join("\n")
-    new_source = autocorrect_source(cop, src)
-    expect(new_source).to eq(src)
-  end
-
-  context 'when there are braces around a multi-line block' do
-    it 'registers an offense in the simple case' do
-      inspect_source(cop, ['each { |x|',
-                           '}'])
-      expect(cop.messages)
-        .to eq(['Avoid using {...} for multi-line blocks.'])
-    end
-
-    it 'accepts braces if do-end would change the meaning' do
-      src = ['scope :foo, lambda { |f|',
-             '  where(condition: "value")',
-             '}',
-             '',
-             'expect { something }.to raise_error(ErrorClass) { |error|',
-             '  # ...',
-             '}',
-             '',
-             'expect { x }.to change {',
-             '  Counter.count',
-             '}.from(0).to(1)']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for braces if do-end would not change ' \
-       'the meaning' do
-      src = ['scope :foo, (lambda { |f|',
-             '  where(condition: "value")',
-             '})',
-             '',
-             'expect { something }.to(raise_error(ErrorClass) { |error|',
-             '  # ...',
-             '})']
-      inspect_source(cop, src)
-      expect(cop.offenses.size).to eq(2)
-    end
-
-    it 'can handle special method names such as []= and done?' do
-      src = ['h2[k2] = Hash.new { |h3,k3|',
-             '  h3[k3] = 0',
-             '}',
-             '',
-             'x = done? list.reject { |e|',
-             '  e.nil?',
-             '}']
-      inspect_source(cop, src)
-      expect(cop.messages)
-        .to eq(['Avoid using {...} for multi-line blocks.'])
-    end
-
-    it 'auto-corrects { and } to do and end' do
-      source = <<-END.strip_indent
-        each{ |x|
-          some_method
-          other_method
-        }
-      END
-
-      expected_source = <<-END.strip_indent
-        each do |x|
-          some_method
-          other_method
-        end
-      END
-
-      new_source = autocorrect_source(cop, source)
-      expect(new_source).to eq(expected_source)
-    end
-
-    it 'does not auto-correct {} if do-end would introduce a syntax error' do
-      src = ['my_method :arg1, arg2: proc {',
-             '  something',
-             '}, arg3: :another_value'].join("\n")
-      new_source = autocorrect_source(cop, src)
-      expect(new_source).to eq(src)
-    end
-  end
-end