rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/space_after_not_spec.rb

@@ -1,22 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceAfterNot do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offense for space after !' do
-    inspect_source(cop, '! something')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts no space after !' do
-    inspect_source(cop, '!something')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects by removing redundant space' do
-    new_source = autocorrect_source(cop, '!  something')
-    expect(new_source).to eq('!something')
-  end
-end

data/spec/rubocop/cop/style/space_after_semicolon_spec.rb

@@ -1,23 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceAfterSemicolon do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for semicolon without space after it' do
-    inspect_source(cop, 'x = 1;y = 2')
-    expect(cop.messages).to eq(
-      ['Space missing after semicolon.'])
-  end
-
-  it 'does not crash if semicolon is the last character of the file' do
-    inspect_source(cop, 'x = 1;')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'auto-corrects missing space' do
-    new_source = autocorrect_source(cop, 'x = 1;y = 2')
-    expect(new_source).to eq('x = 1; y = 2')
-  end
-end

data/spec/rubocop/cop/style/space_around_block_parameters_spec.rb

@@ -1,155 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceAroundBlockParameters, :config do
-  subject(:cop) { described_class.new(config) }
-
-  shared_examples 'common behavior' do
-    it 'accepts an empty block' do
-      inspect_source(cop, '{}.each {}')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'skips lambda without args' do
-      inspect_source(cop, '->() { puts "a" }')
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when EnforcedStyleInsidePipes is no_space' do
-    let(:cop_config) { { 'EnforcedStyleInsidePipes' => 'no_space' } }
-
-    include_examples 'common behavior'
-
-    it 'accepts a block with spaces in the right places' do
-      inspect_source(cop, '{}.each { |x, y| puts x }')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a block with parameters but no body' do
-      inspect_source(cop, '{}.each { |x, y| }')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a block parameter without preceding space' do
-      # This is checked by Style/SpaceAfterComma.
-      inspect_source(cop, '{}.each { |x,y| puts x }')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for space before first parameter' do
-      inspect_source(cop, '{}.each { | x| puts x }')
-      expect(cop.messages)
-        .to eq(['Space before first block parameter detected.'])
-      expect(cop.highlights).to eq([' '])
-    end
-
-    it 'registers an offense for space after last parameter' do
-      inspect_source(cop, '{}.each { |x, y  | puts x }')
-      expect(cop.messages).to eq(['Space after last block parameter detected.'])
-      expect(cop.highlights).to eq(['  '])
-    end
-
-    it 'registers an offense for no space after closing pipe' do
-      inspect_source(cop, '{}.each { |x, y|puts x }')
-      expect(cop.messages).to eq(['Space after closing `|` missing.'])
-      expect(cop.highlights).to eq(['|'])
-    end
-
-    it 'accepts line break after closing pipe' do
-      inspect_source(cop, ['{}.each do |x, y|',
-                           '  puts x',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for multiple spaces before parameter' do
-      inspect_source(cop, '{}.each { |x,   y| puts x }')
-      expect(cop.messages)
-        .to eq(['Extra space before block parameter detected.'])
-      expect(cop.highlights).to eq(['  '])
-    end
-
-    it 'auto-corrects offenses' do
-      new_source = autocorrect_source(cop,
-                                      '{}.each { |  x=5,  (y,*z) |puts x }')
-      expect(new_source).to eq('{}.each { |x=5, (y,*z)| puts x }')
-    end
-  end
-
-  context 'when EnforcedStyleInsidePipes is space' do
-    let(:cop_config) { { 'EnforcedStyleInsidePipes' => 'space' } }
-
-    include_examples 'common behavior'
-
-    it 'accepts a block with spaces in the right places' do
-      inspect_source(cop, '{}.each { | x, y | puts x }')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a block with parameters but no body' do
-      inspect_source(cop, '{}.each { | x, y | }')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a block parameter without preceding space' do
-      # This is checked by Style/SpaceAfterComma.
-      inspect_source(cop, '{}.each { | x,y | puts x }')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for no space before first parameter' do
-      inspect_source(cop, '{}.each { |x | puts x }')
-      expect(cop.messages)
-        .to eq(['Space before first block parameter missing.'])
-      expect(cop.highlights).to eq(['x'])
-    end
-
-    it 'registers an offense for no space after last parameter' do
-      inspect_source(cop, '{}.each { | x, y| puts x }')
-      expect(cop.messages).to eq(['Space after last block parameter missing.'])
-      expect(cop.highlights).to eq(['y'])
-    end
-
-    it 'registers an offense for extra space before first parameter' do
-      inspect_source(cop, '{}.each { |  x | puts x }')
-      expect(cop.messages)
-        .to eq(['Extra space before first block parameter detected.'])
-      expect(cop.highlights).to eq([' '])
-    end
-
-    it 'registers an offense for no space after last parameter' do
-      inspect_source(cop, '{}.each { | x, y   | puts x }')
-      expect(cop.messages)
-        .to eq(['Extra space after last block parameter detected.'])
-      expect(cop.highlights).to eq(['  '])
-    end
-
-    it 'registers an offense for no space after closing pipe' do
-      inspect_source(cop, '{}.each { | x, y |puts x }')
-      expect(cop.messages).to eq(['Space after closing `|` missing.'])
-      expect(cop.highlights).to eq(['|'])
-    end
-
-    it 'accepts line break after closing pipe' do
-      inspect_source(cop, ['{}.each do | x, y |',
-                           '  puts x',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for multiple spaces before parameter' do
-      inspect_source(cop, '{}.each { | x,   y | puts x }')
-      expect(cop.messages)
-        .to eq(['Extra space before block parameter detected.'])
-      expect(cop.highlights).to eq(['  '])
-    end
-
-    it 'auto-corrects offenses' do
-      new_source = autocorrect_source(cop,
-                                      '{}.each { |  x=5,  (y,*z)|puts x }')
-      expect(new_source).to eq('{}.each { | x=5, (y,*z) | puts x }')
-    end
-  end
-end

data/spec/rubocop/cop/style/space_around_equals_in_parameter_default_spec.rb

@@ -1,95 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceAroundEqualsInParameterDefault, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when EnforcedStyle is space' do
-    let(:cop_config) { { 'EnforcedStyle' => 'space' } }
-
-    it 'registers an offense for default value assignment without space' do
-      inspect_source(cop, ['def f(x, y=0, z= 1)',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Surrounding space missing in default value assignment.'] * 2)
-      expect(cop.highlights).to eq(['=', '= '])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'registers an offense for assignment empty string without space' do
-      inspect_source(cop, ['def f(x, y="", z=1)',
-                           'end'])
-      expect(cop.offenses.size).to eq(2)
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'no_space')
-    end
-
-    it 'registers an offense for assignment of empty list without space' do
-      inspect_source(cop, ['def f(x, y=[])',
-                           'end'])
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'accepts default value assignment with space' do
-      inspect_source(cop, ['def f(x, y = 0, z = {})',
-                           'end'])
-      expect(cop.messages).to be_empty
-    end
-
-    it 'auto-corrects missing space' do
-      new_source = autocorrect_source(cop, ['def f(x, y=0, z=1)', 'end'])
-      expect(new_source).to eq(['def f(x, y = 0, z = 1)', 'end'].join("\n"))
-    end
-
-    it 'accepts default value assignment with space' do
-      inspect_source(cop, ['def f(x, y = +1, z = {})',
-                           'end'])
-      expect(cop.messages).to be_empty
-    end
-
-    it 'auto-corrects missing space' do
-      new_source = autocorrect_source(cop, ['def f(x=-1, y= 0, z =+1)', 'end'])
-      expect(new_source).to eq(['def f(x = -1, y = 0, z = +1)',
-                                'end'].join("\n"))
-    end
-  end
-
-  context 'when EnforcedStyle is no_space' do
-    let(:cop_config) { { 'EnforcedStyle' => 'no_space' } }
-
-    it 'registers an offense for default value assignment with space' do
-      inspect_source(cop, ['def f(x, y = 0, z =1, w= 2)',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Surrounding space detected in default value assignment.'] * 3)
-      expect(cop.highlights).to eq([' = ', ' =', '= '])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'registers an offense for assignment empty string with space' do
-      inspect_source(cop, ['def f(x, y = "", z = 1)',
-                           'end'])
-      expect(cop.offenses.size).to eq(2)
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'space')
-    end
-
-    it 'registers an offense for assignment of empty list with space' do
-      inspect_source(cop, ['def f(x, y = [])',
-                           'end'])
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'accepts default value assignment without space' do
-      inspect_source(cop, ['def f(x, y=0, z={})',
-                           'end'])
-      expect(cop.messages).to be_empty
-    end
-
-    it 'auto-corrects unwanted space' do
-      new_source = autocorrect_source(cop, ['def f(x, y = 0, z= 1, w= 2)',
-                                            'end'])
-      expect(new_source).to eq(['def f(x, y=0, z=1, w=2)',
-                                'end'].join("\n"))
-    end
-  end
-end

data/spec/rubocop/cop/style/space_around_operators_spec.rb

@@ -1,330 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceAroundOperators do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for assignment without space on both sides' do
-    inspect_source(cop, ['x=0', 'y+= 0', 'z[0] =0'])
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '='.",
-              "Surrounding space missing for operator '+='.",
-              "Surrounding space missing for operator '='."])
-  end
-
-  it 'auto-corrects assignment without space on both sides' do
-    new_source = autocorrect_source(cop, ['x=0', 'y= 0', 'z =0'])
-    expect(new_source).to eq(['x = 0', 'y = 0', 'z = 0'].join("\n"))
-  end
-
-  it 'registers an offense for ternary operator without space' do
-    inspect_source(cop, 'x == 0?1:2')
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '?'.",
-       "Surrounding space missing for operator ':'."])
-  end
-
-  it 'auto-corrects a ternary operator without space' do
-    new_source = autocorrect_source(cop, 'x == 0?1:2')
-    expect(new_source).to eq('x == 0 ? 1 : 2')
-  end
-
-  it 'registers an offense in presence of modifier if statement' do
-    check_modifier('if')
-  end
-
-  it 'registers an offense in presence of modifier unless statement' do
-    check_modifier('unless')
-  end
-
-  it 'registers an offense in presence of modifier while statement' do
-    check_modifier('unless')
-  end
-
-  it 'registers an offense in presence of modifier until statement' do
-    check_modifier('unless')
-  end
-
-  def check_modifier(keyword)
-    src = ["a=1 #{keyword} condition",
-           'c=2']
-    inspect_source(cop, src)
-    expect(cop.offenses.map(&:line)).to eq([1, 2])
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '='."] * 2)
-
-    new_source = autocorrect_source(cop, src)
-    expect(new_source)
-      .to eq(src.map { |line| line.sub(/=/, ' = ') }.join("\n"))
-  end
-
-  it 'registers an offense for binary operators that could be unary' do
-    inspect_source(cop, ['a-3', 'x&0xff', 'z+0'])
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '-'.",
-       "Surrounding space missing for operator '&'.",
-       "Surrounding space missing for operator '+'."])
-  end
-
-  it 'auto-corrects missing space in binary operators that could be unary' do
-    new_source = autocorrect_source(cop, ['a-3', 'x&0xff', 'z+0'])
-    expect(new_source).to eq(['a - 3', 'x & 0xff', 'z + 0'].join("\n"))
-  end
-
-  it 'registers an offense for arguments to a method' do
-    inspect_source(cop, 'puts 1+2')
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '+'."])
-  end
-
-  it 'auto-corrects missing space in arguments to a method' do
-    new_source = autocorrect_source(cop, 'puts 1+2')
-    expect(new_source).to eq('puts 1 + 2')
-  end
-
-  it 'accepts operator surrounded by tabs' do
-    inspect_source(cop, "a\t+\tb")
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts operator symbols' do
-    inspect_source(cop, 'func(:-)')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts ranges' do
-    inspect_source(cop, 'a, b = (1..2), (1...3)')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts scope operator' do
-    source = '@io.class == Zlib::GzipWriter'
-    inspect_source(cop, source)
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts ::Kernel::raise' do
-    source = '::Kernel::raise IllegalBlockError.new'
-    inspect_source(cop, source)
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts exclamation point negation' do
-    inspect_source(cop, 'x = !a&&!b')
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '&&'."])
-  end
-
-  it 'accepts exclamation point definition' do
-    inspect_source(cop, ['  def !',
-                         '    !__getobj__',
-                         '  end'])
-    expect(cop.offenses).to be_empty
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts a unary' do
-    inspect_source(cop,
-                   ['  def bm(label_width = 0, *labels, &blk)',
-                    '    benchmark(CAPTION, label_width, FORMAT,',
-                    '              *labels, &blk)',
-                    '  end',
-                    '',
-                    '  def each &block',
-                    '    +11',
-                    '  end',
-                    '',
-                    '  def self.search *args',
-                    '  end',
-                    '',
-                    '  def each *args',
-                    '  end',
-                    ''])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts splat operator' do
-    inspect_source(cop, 'return *list if options')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts def of operator' do
-    inspect_source(cop, ['def +(other); end',
-                         'def self.===(other); end'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts an operator at the end of a line' do
-    inspect_source(cop,
-                   ["['Favor unless over if for negative ' +",
-                    " 'conditions.'] * 2"])
-    expect(cop.messages).to eq([])
-  end
-
-  it 'accepts an assignment with spaces' do
-    inspect_source(cop, 'x = 0')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts an operator called with method syntax' do
-    inspect_source(cop, 'Date.today.+(1).to_s')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for operators without spaces' do
-    inspect_source(cop,
-                   ['x+= a+b-c*d/e%f^g|h&i||j',
-                    'y -=k&&l'])
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '+='.",
-              "Surrounding space missing for operator '+'.",
-              "Surrounding space missing for operator '-'.",
-              "Surrounding space missing for operator '*'.",
-              "Surrounding space missing for operator '/'.",
-              "Surrounding space missing for operator '%'.",
-              "Surrounding space missing for operator '^'.",
-              "Surrounding space missing for operator '|'.",
-              "Surrounding space missing for operator '&'.",
-              "Surrounding space missing for operator '||'.",
-              "Surrounding space missing for operator '-='.",
-              "Surrounding space missing for operator '&&'."])
-  end
-
-  it 'auto-corrects missing space' do
-    new_source = autocorrect_source(cop, ['x+= a+b-c*d/e%f^g|h&i||j',
-                                          'y -=k&&l'])
-    expect(new_source).to eq(['x += a + b - c * d / e % f ^ g | h & i || j',
-                              'y -= k && l'].join("\n"))
-  end
-
-  it 'accepts operators with spaces' do
-    inspect_source(cop,
-                   ['x += a + b - c * d / e % f ^ g | h & i || j',
-                    'y -= k && l'])
-    expect(cop.messages).to eq([])
-  end
-
-  it "accepts some operators that are exceptions & don't need spaces" do
-    inspect_source(cop, ['(1..3)',
-                         'ActionController::Base',
-                         'each { |s, t| }'])
-    expect(cop.messages).to eq([])
-  end
-
-  it 'accepts an assignment followed by newline' do
-    inspect_source(cop, ['x =', '0'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offenses for exponent operator with spaces' do
-    inspect_source(cop, 'x = a * b ** 2')
-    expect(cop.messages).to eq(
-      ['Space around operator ** detected.'])
-  end
-
-  it 'auto-corrects unwanted space around **' do
-    new_source = autocorrect_source(cop, ['x = a * b ** 2',
-                                          'y = a * b** 2'])
-    expect(new_source).to eq(['x = a * b**2',
-                              'y = a * b**2'].join("\n"))
-  end
-
-  it 'accepts exponent operator without spaces' do
-    inspect_source(cop, 'x = a * b**2')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for a setter call without spaces' do
-    inspect_source(cop, 'x.y=2')
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '='."])
-  end
-
-  it 'registers an offense for a hash rocket without spaces' do
-    inspect_source(cop, '{ 1=>2, a: b }')
-    expect(cop.messages).to eq(
-      ["Surrounding space missing for operator '=>'."])
-  end
-
-  it 'accepts unary operators without space' do
-    inspect_source(cop, ['[].map(&:size)',
-                         'a.(b)',
-                         '-3',
-                         'arr.collect { |e| -e }',
-                         'x = +2'])
-    expect(cop.messages).to eq([])
-  end
-
-  it 'accepts [] without space' do
-    inspect_source(cop, 'files[2]')
-    expect(cop.messages).to eq([])
-  end
-
-  it 'accepts argument default values without space' do
-    # These are handled by SpaceAroundEqualsInParameterDefault,
-    # so SpaceAroundOperators leaves them alone.
-    inspect_source(cop,
-                   ['def init(name=nil)',
-                    'end'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts the construct class <<self with no space after <<' do
-    inspect_source(cop, ['class <<self',
-                         'end'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'registers an offense for match operators without space' do
-    inspect_source(cop, ['x=~/abc/',
-                         'y !~/abc/'])
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '=~'.",
-              "Surrounding space missing for operator '!~'."])
-  end
-
-  it 'registers an offense for various assignments without space' do
-    inspect_source(cop, ['x||=0', 'y&&=0', 'z*=2',
-                         '@a=0', '@@a=0', 'a,b=0', 'A=0', 'x[3]=0', '$A=0'])
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '||='.",
-              "Surrounding space missing for operator '&&='.",
-              "Surrounding space missing for operator '*='.",
-              "Surrounding space missing for operator '='.",
-              "Surrounding space missing for operator '='.",
-              "Surrounding space missing for operator '='.",
-              "Surrounding space missing for operator '='.",
-              "Surrounding space missing for operator '='.",
-              "Surrounding space missing for operator '='."])
-  end
-
-  it 'registers an offense for equality operators without space' do
-    inspect_source(cop, ['x==0', 'y!=0', 'Hash===z'])
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '=='.",
-              "Surrounding space missing for operator '!='.",
-              "Surrounding space missing for operator '==='."])
-  end
-
-  it 'registers an offense for - without space with negative lhs operand' do
-    inspect_source(cop, '-1-arg')
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '-'."])
-  end
-
-  it 'registers an offense for inheritance < without space' do
-    inspect_source(cop, ['class ShowSourceTestClass<ShowSourceTestSuperClass',
-                         'end'])
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '<'."])
-  end
-
-  it 'registers an offense for hash rocket without space at rescue' do
-    inspect_source(cop, ['begin',
-                         'rescue Exception=>e',
-                         'end'])
-    expect(cop.messages)
-      .to eq(["Surrounding space missing for operator '=>'."])
-  end
-end