rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/space_before_block_braces_spec.rb

@@ -1,73 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceBeforeBlockBraces do
-  subject(:cop) { described_class.new(config) }
-  let(:config) do
-    merged = RuboCop::ConfigLoader
-             .default_configuration['Style/SpaceBeforeBlockBraces']
-             .merge(cop_config)
-    RuboCop::Config.new('Style/Blocks' => { 'Enabled' => false },
-                        'Style/SpaceBeforeBlockBraces' => merged)
-  end
-  let(:cop_config) { { 'EnforcedStyle' => 'space' } }
-
-  context 'when EnforcedStyle is space' do
-    it 'accepts braces surrounded by spaces' do
-      inspect_source(cop, 'each { puts }')
-      expect(cop.messages).to be_empty
-      expect(cop.highlights).to be_empty
-    end
-
-    it 'registers an offense for left brace without outer space' do
-      inspect_source(cop, 'each{ puts }')
-      expect(cop.messages).to eq(['Space missing to the left of {.'])
-      expect(cop.highlights).to eq(['{'])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'no_space')
-    end
-
-    it 'registers an offense for opposite + correct style' do
-      inspect_source(cop,
-                     ['each{ puts }',
-                      'each { puts }'])
-      expect(cop.messages).to eq(['Space missing to the left of {.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'auto-corrects missing space' do
-      new_source = autocorrect_source(cop, 'each{}')
-      expect(new_source).to eq('each {}')
-    end
-  end
-
-  context 'when EnforcedStyle is no_space' do
-    let(:cop_config) { { 'EnforcedStyle' => 'no_space' } }
-
-    it 'registers an offense for braces surrounded by spaces' do
-      inspect_source(cop, 'each { puts }')
-      expect(cop.messages).to eq(['Space detected to the left of {.'])
-      expect(cop.highlights).to eq([' '])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'space')
-    end
-
-    it 'registers an offense for correct + opposite style' do
-      inspect_source(cop,
-                     ['each{ puts }',
-                      'each { puts }'])
-      expect(cop.messages).to eq(['Space detected to the left of {.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'auto-corrects unwanted space' do
-      new_source = autocorrect_source(cop, 'each {}')
-      expect(new_source).to eq('each{}')
-    end
-
-    it 'accepts left brace without outer space' do
-      inspect_source(cop, 'each{ puts }')
-      expect(cop.messages).to be_empty
-      expect(cop.highlights).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/style/space_before_comma_spec.rb

@@ -1,42 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceBeforeComma do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for block argument with space before comma' do
-    inspect_source(cop, 'each { |s , t| }')
-    expect(cop.messages).to eq(
-      ['Space found before comma.'])
-  end
-
-  it 'registers an offense for array index with space before comma' do
-    inspect_source(cop, 'formats[0 , 1]')
-    expect(cop.messages).to eq(
-      ['Space found before comma.'])
-  end
-
-  it 'registers an offense for method call arg with space before comma' do
-    inspect_source(cop, 'a(1 , 2)')
-    expect(cop.messages).to eq(
-      ['Space found before comma.'])
-  end
-
-  it 'does not register an offense for no spaces before comma' do
-    inspect_source(cop, 'a(1, 2)')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'auto-corrects space before comma' do
-    new_source = autocorrect_source(cop,
-                                    'each { |s , t| a(1 , formats[0 , 1])}')
-    expect(new_source).to eq('each { |s, t| a(1, formats[0, 1])}')
-  end
-
-  it 'handles more than one space before a comma' do
-    new_source = autocorrect_source(cop,
-                                    'each { |s  , t| a(1  , formats[0  , 1])}')
-    expect(new_source).to eq('each { |s, t| a(1, formats[0, 1])}')
-  end
-end

data/spec/rubocop/cop/style/space_before_comment_spec.rb

@@ -1,34 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceBeforeComment do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for missing space before an EOL comment' do
-    inspect_source(cop, 'a += 1# increment')
-    expect(cop.highlights).to eq(['# increment'])
-  end
-
-  it 'accepts an EOL comment with a preceding space' do
-    inspect_source(cop, 'a += 1 # increment')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a comment that begins a line' do
-    inspect_source(cop, '# comment')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a doc comment' do
-    inspect_source(cop, ['=begin',
-                         'Doc comment',
-                         '=end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects missing space' do
-    new_source = autocorrect_source(cop, 'a += 1# increment')
-    expect(new_source).to eq('a += 1 # increment')
-  end
-end

data/spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb

@@ -1,70 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceBeforeModifierKeyword do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for missing space before if/unless' do
-    inspect_source(cop, ['(a = 3)if a == 2',
-                         'a = "test"if a == 2',
-                         'a = 42unless a == 2',
-                         'a = [1,2,3]unless a == 2',
-                         'a = {:a => "b"}if a == 2'])
-    expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
-  end
-
-  it 'registers an offense for missing space before while/until' do
-    inspect_source(cop, ['(a = 3)while b',
-                         'a = "test"until b',
-                         'a = 42while b',
-                         'a = [1,2,3]until b',
-                         'a = {:a => "b"}while b'])
-    expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
-  end
-
-  it 'accepts modifiers with preceding space' do
-    inspect_source(cop, ['(a = 3) if b',
-                         'a = "test" unless b',
-                         'a = 42 while b',
-                         'a = [1,2,3] until b'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts elsif at beginning of line' do
-    inspect_source(cop, ["if RUBY_VERSION.between?('1.9.2', '2.0.0')",
-                         "  require 'testing/performance/ruby/yarv'",
-                         'elsif RUBY_VERSION.between?("1.8.6", "1.9")',
-                         "  require 'testing/performance/ruby/mri'",
-                         'end'])
-    expect(cop.highlights).to eq([])
-  end
-
-  it 'does not crash on ternary conditionals' do
-    inspect_source(cop, 'a ? b : c')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects missing space' do
-    new_source = autocorrect_source(cop, ['(a = 3)if a == 2',
-                                          'a = "test"if a == 2',
-                                          'a = 42unless a == 2',
-                                          'a = [1,2,3]unless a == 2',
-                                          'a = {:a => "b"}if a == 2',
-                                          '(a = 3)while b',
-                                          'a = "test"until b',
-                                          'a = 42while b',
-                                          'a = [1,2,3]until b',
-                                          'a = {:a => "b"}while b'])
-    expect(new_source).to eq(['(a = 3) if a == 2',
-                              'a = "test" if a == 2',
-                              'a = 42 unless a == 2',
-                              'a = [1,2,3] unless a == 2',
-                              'a = {:a => "b"} if a == 2',
-                              '(a = 3) while b',
-                              'a = "test" until b',
-                              'a = 42 while b',
-                              'a = [1,2,3] until b',
-                              'a = {:a => "b"} while b'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/space_before_semicolon_spec.rb

@@ -1,28 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceBeforeSemicolon do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for space before semicolon' do
-    inspect_source(cop, 'x = 1 ; y = 2')
-    expect(cop.messages).to eq(
-      ['Space found before semicolon.'])
-  end
-
-  it 'does not register an offense for no space before semicolons' do
-    inspect_source(cop, 'x = 1; y = 2')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'auto-corrects space before semicolon' do
-    new_source = autocorrect_source(cop, 'x = 1 ; y = 2')
-    expect(new_source).to eq('x = 1; y = 2')
-  end
-
-  it 'handles more than one space before a semicolon' do
-    new_source = autocorrect_source(cop, 'x = 1  ; y = 2')
-    expect(new_source).to eq('x = 1; y = 2')
-  end
-end

data/spec/rubocop/cop/style/space_inside_block_braces_spec.rb

@@ -1,317 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceInsideBlockBraces do
-  SUPPORTED_STYLES = %w(space no_space)
-
-  subject(:cop) { described_class.new(config) }
-  let(:config) do
-    merged = RuboCop::ConfigLoader
-             .default_configuration['Style/SpaceInsideBlockBraces']
-             .merge(cop_config)
-    RuboCop::Config.new('Style/Blocks' => { 'Enabled' => false },
-                        'Style/SpaceInsideBlockBraces' => merged)
-  end
-  let(:cop_config) do
-    {
-      'EnforcedStyle' => 'space',
-      'SupportedStyles' => SUPPORTED_STYLES,
-      'SpaceBeforeBlockParameters' => true
-    }
-  end
-
-  context 'with space inside empty braces not allowed' do
-    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'no_space' } }
-
-    it 'accepts empty braces with no space inside' do
-      inspect_source(cop, 'each {}')
-      expect(cop.messages).to be_empty
-    end
-
-    it 'accepts empty braces with line break inside' do
-      inspect_source(cop, ['  each {',
-                           '  }'])
-      expect(cop.messages).to be_empty
-    end
-
-    it 'accepts empty braces with comment and line break inside' do
-      inspect_source(cop, ['  each { # Comment',
-                           '  }'])
-      expect(cop.messages).to be_empty
-    end
-
-    it 'registers an offense for empty braces with space inside' do
-      inspect_source(cop, 'each { }')
-      expect(cop.messages).to eq(['Space inside empty braces detected.'])
-      expect(cop.highlights).to eq([' '])
-    end
-
-    it 'auto-corrects unwanted space' do
-      new_source = autocorrect_source(cop, 'each { }')
-      expect(new_source).to eq('each {}')
-    end
-
-    it 'does not auto-correct when braces are not empty' do
-      old_source = <<-END
-        a {
-          b
-        }
-      END
-      new_source = autocorrect_source(cop, old_source)
-      expect(new_source).to eq(old_source)
-    end
-  end
-
-  context 'with space inside empty braces allowed' do
-    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'space' } }
-
-    it 'accepts empty braces with space inside' do
-      inspect_source(cop, 'each { }')
-      expect(cop.messages).to be_empty
-    end
-
-    it 'registers an offense for empty braces with no space inside' do
-      inspect_source(cop, 'each {}')
-      expect(cop.messages).to eq(['Space missing inside empty braces.'])
-      expect(cop.highlights).to eq(['{}'])
-    end
-
-    it 'auto-corrects missing space' do
-      new_source = autocorrect_source(cop, 'each {}')
-      expect(new_source).to eq('each { }')
-    end
-  end
-
-  context 'with invalid value for EnforcedStyleForEmptyBraces' do
-    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'unknown' } }
-
-    it 'fails with an error' do
-      expect { inspect_source(cop, 'each { }') }
-        .to raise_error('Unknown EnforcedStyleForEmptyBraces selected!')
-    end
-  end
-
-  it 'accepts braces surrounded by spaces' do
-    inspect_source(cop, 'each { puts }')
-    expect(cop.messages).to be_empty
-    expect(cop.highlights).to be_empty
-  end
-
-  it 'accepts left brace without outer space' do
-    inspect_source(cop, 'each{ puts }')
-    expect(cop.highlights).to be_empty
-  end
-
-  it 'registers an offense for left brace without inner space' do
-    inspect_source(cop, 'each {puts }')
-    expect(cop.messages).to eq(['Space missing inside {.'])
-    expect(cop.highlights).to eq(['p'])
-  end
-
-  it 'registers an offense for right brace without inner space' do
-    inspect_source(cop, 'each { puts}')
-    expect(cop.messages).to eq(['Space missing inside }.'])
-    expect(cop.highlights).to eq(['}'])
-    expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-  end
-
-  it 'registers offenses for both braces without inner space' do
-    inspect_source(cop, ['a {}',
-                         'b { }',
-                         'each {puts}'])
-    expect(cop.messages).to eq(['Space inside empty braces detected.',
-                                'Space missing inside {.',
-                                'Space missing inside }.'])
-    expect(cop.highlights).to eq([' ', 'p', '}'])
-
-    # Both correct and incorrect code has been found in relation to
-    # EnforcedStyleForEmptyBraces, but that doesn't matter. EnforcedStyle can
-    # be changed to get rid of the EnforcedStyle offenses.
-    expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
-                                               'no_space')
-  end
-
-  it 'auto-corrects missing space' do
-    new_source = autocorrect_source(cop, 'each {puts}')
-    expect(new_source).to eq('each { puts }')
-  end
-
-  context 'with passed in parameters' do
-    it 'accepts left brace with inner space' do
-      inspect_source(cop, 'each { |x| puts }')
-      expect(cop.messages).to be_empty
-      expect(cop.highlights).to be_empty
-    end
-
-    it 'registers an offense for left brace without inner space' do
-      inspect_source(cop, 'each {|x| puts }')
-      expect(cop.messages).to eq(['Space between { and | missing.'])
-      expect(cop.highlights).to eq(['{|'])
-    end
-
-    it 'accepts new lambda syntax' do
-      inspect_source(cop, '->(x) { x }')
-      expect(cop.messages).to be_empty
-    end
-
-    it 'auto-corrects missing space' do
-      new_source = autocorrect_source(cop, 'each {|x| puts }')
-      expect(new_source).to eq('each { |x| puts }')
-    end
-
-    context 'and Blocks cop enabled' do
-      let(:config) do
-        RuboCop::Config.new('Style/Blocks' => { 'Enabled' => true },
-                            'Style/SpaceInsideBlockBraces' => cop_config)
-      end
-
-      it 'does auto-correction for single-line blocks' do
-        new_source = autocorrect_source(cop, 'each {|x| puts}')
-        expect(new_source).to eq('each { |x| puts }')
-      end
-
-      it 'does not do auto-correction for multi-line blocks' do
-        # {} will be changed to do..end by the Blocks cop, and then this cop is
-        # not relevant anymore.
-        old_source = ['each {|x|',
-                      '  puts',
-                      '}']
-        new_source = autocorrect_source(cop, old_source)
-        expect(new_source).to eq(old_source.join("\n"))
-      end
-    end
-
-    context 'and space before block parameters not allowed' do
-      let(:cop_config) do
-        {
-          'EnforcedStyle'              => 'space',
-          'SupportedStyles'            => SUPPORTED_STYLES,
-          'SpaceBeforeBlockParameters' => false
-        }
-      end
-
-      it 'registers an offense for left brace with inner space' do
-        inspect_source(cop, 'each { |x| puts }')
-        expect(cop.messages).to eq(['Space between { and | detected.'])
-        expect(cop.highlights).to eq([' '])
-      end
-
-      it 'accepts new lambda syntax' do
-        inspect_source(cop, '->(x) { x }')
-        expect(cop.messages).to be_empty
-      end
-
-      it 'auto-corrects unwanted space' do
-        new_source = autocorrect_source(cop, 'each { |x| puts }')
-        expect(new_source).to eq('each {|x| puts }')
-      end
-
-      it 'accepts left brace without inner space' do
-        inspect_source(cop, 'each {|x| puts }')
-        expect(cop.messages).to be_empty
-        expect(cop.highlights).to be_empty
-      end
-    end
-  end
-
-  context 'configured with no_space' do
-    let(:cop_config) do
-      {
-        'EnforcedStyle'              => 'no_space',
-        'SupportedStyles'            => SUPPORTED_STYLES,
-        'SpaceBeforeBlockParameters' => true
-      }
-    end
-
-    it 'accepts braces without spaces inside' do
-      inspect_source(cop, 'each {puts}')
-      expect(cop.messages).to be_empty
-      expect(cop.highlights).to be_empty
-    end
-
-    it 'registers an offense for left brace with inner space' do
-      inspect_source(cop, 'each { puts}')
-      expect(cop.messages).to eq(['Space inside { detected.'])
-      expect(cop.highlights).to eq([' '])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'registers an offense for right brace with inner space' do
-      inspect_source(cop, 'each {puts  }')
-      expect(cop.messages).to eq(['Space inside } detected.'])
-      expect(cop.highlights).to eq(['  '])
-    end
-
-    it 'registers offenses for both braces with inner space' do
-      inspect_source(cop, 'each { puts  }')
-      expect(cop.messages).to eq(['Space inside { detected.',
-                                  'Space inside } detected.'])
-      expect(cop.highlights).to eq([' ', '  '])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' =>
-                                                 'space')
-    end
-
-    it 'accepts left brace without outer space' do
-      inspect_source(cop, 'each {puts}')
-      expect(cop.highlights).to be_empty
-    end
-
-    it 'auto-corrects unwanted space' do
-      new_source = autocorrect_source(cop, 'each{ puts }')
-      expect(new_source).to eq('each{puts}')
-    end
-
-    context 'with passed in parameters' do
-      context 'and space before block parameters allowed' do
-        it 'accepts left brace with inner space' do
-          inspect_source(cop, 'each { |x| puts}')
-          expect(cop.messages).to eq([])
-          expect(cop.highlights).to eq([])
-        end
-
-        it 'registers an offense for left brace without inner space' do
-          inspect_source(cop, 'each {|x| puts}')
-          expect(cop.messages).to eq(['Space between { and | missing.'])
-          expect(cop.highlights).to eq(['{|'])
-        end
-
-        it 'accepts new lambda syntax' do
-          inspect_source(cop, '->(x) {x}')
-          expect(cop.messages).to be_empty
-        end
-
-        it 'auto-corrects missing space' do
-          new_source = autocorrect_source(cop, 'each {|x| puts}')
-          expect(new_source).to eq('each { |x| puts}')
-        end
-      end
-
-      context 'and space before block parameters not allowed' do
-        let(:cop_config) do
-          {
-            'EnforcedStyle'              => 'no_space',
-            'SupportedStyles'            => SUPPORTED_STYLES,
-            'SpaceBeforeBlockParameters' => false
-          }
-        end
-
-        it 'registers an offense for left brace with inner space' do
-          inspect_source(cop, 'each { |x| puts}')
-          expect(cop.messages).to eq(['Space between { and | detected.'])
-          expect(cop.highlights).to eq([' '])
-        end
-
-        it 'accepts new lambda syntax' do
-          inspect_source(cop, '->(x) {x}')
-          expect(cop.messages).to be_empty
-        end
-
-        it 'auto-corrects unwanted space' do
-          new_source = autocorrect_source(cop, 'each { |x| puts}')
-          expect(new_source).to eq('each {|x| puts}')
-        end
-      end
-    end
-  end
-end