rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/predicate_name_spec.rb

@@ -1,57 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::PredicateName, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'with blacklisted prefices' do
-    let(:cop_config) do
-      { 'NamePrefix' => %w(has_ is_),
-        'NamePrefixBlacklist' => %w(has_ is_) }
-    end
-
-    %w(has is).each do |prefix|
-      it 'registers an offense when method name starts with known prefix' do
-        inspect_source(cop, ["def #{prefix}_attr",
-                             '  # ...',
-                             'end'])
-        expect(cop.offenses.size).to eq(1)
-        expect(cop.messages).to eq(["Rename `#{prefix}_attr` to `attr?`."])
-        expect(cop.highlights).to eq(["#{prefix}_attr"])
-      end
-    end
-
-    it 'accepts method name that starts with unknown prefix' do
-      inspect_source(cop, ['def have_attr',
-                           '  # ...',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    context 'with blacklisted prefices' do
-      let(:cop_config) do
-        { 'NamePrefix' => %w(has_ is_), 'NamePrefixBlacklist' => [] }
-      end
-
-      %w(has is).each do |prefix|
-        it 'registers an offense when method name starts with known prefix' do
-          inspect_source(cop, ["def #{prefix}_attr",
-                               '  # ...',
-                               'end'])
-          expect(cop.offenses.size).to eq(1)
-          expect(cop.messages)
-            .to eq(["Rename `#{prefix}_attr` to `#{prefix}_attr?`."])
-          expect(cop.highlights).to eq(["#{prefix}_attr"])
-        end
-      end
-
-      it 'accepts method name that starts with unknown prefix' do
-        inspect_source(cop, ['def have_attr',
-                             '  # ...',
-                             'end'])
-        expect(cop.offenses).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cop/style/proc_spec.rb

@@ -1,27 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::Proc do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for a Proc.new call' do
-    inspect_source(cop, 'f = Proc.new { |x| puts x }')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts the proc method' do
-    inspect_source(cop, 'f = proc { |x| puts x }')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts the Proc.new call outside of block' do
-    inspect_source(cop, 'p = Proc.new')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects Proc.new to proc' do
-    corrected = autocorrect_source(cop, ['Proc.new { test }'])
-    expect(corrected).to eq 'proc { test }'
-  end
-end

data/spec/rubocop/cop/style/raise_args_spec.rb

@@ -1,87 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::RaiseArgs, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when enforced style is compact' do
-    let(:cop_config) { { 'EnforcedStyle' => 'compact' } }
-
-    it 'reports an offense for a raise with 2 args' do
-      inspect_source(cop, 'raise RuntimeError, msg')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'exploded')
-    end
-
-    it 'reports an offense for correct + opposite' do
-      inspect_source(cop, ['if a',
-                           '  raise RuntimeError, msg',
-                           'else',
-                           '  raise Ex.new(msg)',
-                           'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Provide an exception object as an argument to `raise`.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'reports an offense for a raise with 3 args' do
-      inspect_source(cop, 'raise RuntimeError, msg, caller')
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'accepts a raise with msg argument' do
-      inspect_source(cop, 'raise msg')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a raise with an exception argument' do
-      inspect_source(cop, 'raise Ex.new(msg)')
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when enforced style is exploded' do
-    let(:cop_config) { { 'EnforcedStyle' => 'exploded' } }
-
-    it 'reports an offense for a raise with exception object' do
-      inspect_source(cop, 'raise Ex.new(msg)')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Provide an exception class and message ' \
-                'as arguments to `raise`.'])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'compact')
-    end
-
-    it 'reports an offense for opposite + correct' do
-      inspect_source(cop, ['if a',
-                           '  raise RuntimeError, msg',
-                           'else',
-                           '  raise Ex.new(msg)',
-                           'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'accepts exception constructor with more than 1 argument' do
-      inspect_source(cop, 'raise RuntimeError.new(a1, a2, a3)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a raise with 3 args' do
-      inspect_source(cop, 'raise RuntimeError, msg, caller')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a raise with 2 args' do
-      inspect_source(cop, 'raise RuntimeError, msg')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a raise with msg argument' do
-      inspect_source(cop, 'raise msg')
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/style/redundant_begin_spec.rb

@@ -1,121 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::RedundantBegin do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offense for single line def with redundant begin block' do
-    src = '  def func; begin; x; y; rescue; z end end'
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'reports an offense for def with redundant begin block' do
-    src = ['def func',
-           '  begin',
-           '    ala',
-           '  rescue => e',
-           '    bala',
-           '  end',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'reports an offense for defs with redundant begin block' do
-    src = ['def Test.func',
-           '  begin',
-           '    ala',
-           '  rescue => e',
-           '    bala',
-           '  end',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts a def with required begin block' do
-    src = ['def func',
-           '  begin',
-           '    ala',
-           '  rescue => e',
-           '    bala',
-           '  end',
-           '  something',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a defs with required begin block' do
-    src = ['def Test.func',
-           '  begin',
-           '    ala',
-           '  rescue => e',
-           '    bala',
-           '  end',
-           '  something',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects by removing redundant begin blocks' do
-    src = ['  def func',
-           '    begin',
-           '      foo',
-           '      bar',
-           '    rescue',
-           '      baz',
-           '    end',
-           '  end'].join("\n")
-    result_src = ['  def func',
-                  '    foo',
-                  '    bar',
-                  '  rescue',
-                  '    baz',
-                  '  end'].join("\n")
-    new_source = autocorrect_source(cop, src)
-    expect(new_source).to eq(result_src)
-  end
-
-  it 'auto-corrects by removing redundant begin blocks' do
-    src = '  def func; begin; x; y; rescue; z end end'
-    result_src = '  def func; x; y; rescue; z end'
-    new_source = autocorrect_source(cop, src)
-    expect(new_source).to eq(result_src)
-  end
-
-  it "doesn't modify spacing when auto-correcting" do
-    src = ['def method',
-           '  begin',
-           '    BlockA do |strategy|',
-           '      foo',
-           '    end',
-           '',
-           '    BlockB do |portfolio|',
-           '      foo',
-           '    end',
-           '',
-           '  rescue => e',
-           '    bar',
-           '  end',
-           'end']
-
-    result_src = ['def method',
-                  '  BlockA do |strategy|',
-                  '    foo',
-                  '  end',
-                  '',
-                  '  BlockB do |portfolio|',
-                  '    foo',
-                  '  end',
-                  '',
-                  'rescue => e',
-                  '  bar',
-                  'end'].join("\n")
-    new_source = autocorrect_source(cop, src)
-    expect(new_source).to eq(result_src)
-  end
-end

data/spec/rubocop/cop/style/redundant_exception_spec.rb

@@ -1,59 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::RedundantException do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offense for a raise with RuntimeError' do
-    inspect_source(cop, 'raise RuntimeError, msg')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'reports an offense for a fail with RuntimeError' do
-    inspect_source(cop, 'fail RuntimeError, msg')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts a raise with RuntimeError if it does not have 2 args' do
-    inspect_source(cop, 'raise RuntimeError, msg, caller')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a fail with RuntimeError if it does not have 2 args' do
-    inspect_source(cop, 'fail RuntimeError, msg, caller')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects a raise by removing RuntimeError' do
-    src = 'raise RuntimeError, msg'
-    result_src = 'raise msg'
-    new_src = autocorrect_source(cop, src)
-    expect(new_src).to eq(result_src)
-  end
-
-  it 'auto-corrects a fil by removing RuntimeError' do
-    src = 'fail RuntimeError, msg'
-    result_src = 'fail msg'
-    new_src = autocorrect_source(cop, src)
-    expect(new_src).to eq(result_src)
-  end
-
-  it 'does not modify raise w/ RuntimeError if it does not have 2 args' do
-    src = 'raise runtimeError, msg, caller'
-    new_src = autocorrect_source(cop, src)
-    expect(new_src).to eq(src)
-  end
-
-  it 'does not modify fail w/ RuntimeError if it does not have 2 args' do
-    src = 'fail RuntimeError, msg, caller'
-    new_src = autocorrect_source(cop, src)
-    expect(new_src).to eq(src)
-  end
-
-  it 'does not modify rescue w/ non redundant error' do
-    src = 'fail OtherError, msg'
-    new_src = autocorrect_source(cop, src)
-    expect(new_src).to eq(src)
-  end
-end

data/spec/rubocop/cop/style/redundant_return_spec.rb

@@ -1,171 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::RedundantReturn, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) { { 'AllowMultipleReturnValues' => false } }
-
-  it 'reports an offense for def with only a return' do
-    src = ['def func',
-           '  return something',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'reports an offense for defs with only a return' do
-    src = ['def Test.func',
-           '  return something',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'reports an offense for def ending with return' do
-    src = ['def func',
-           '  one',
-           '  two',
-           '  return something',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'reports an offense for defs ending with return' do
-    src = ['def func',
-           '  one',
-           '  two',
-           '  return something',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts return in a non-final position' do
-    src = ['def func',
-           '  return something if something_else',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not blow up on empty method body' do
-    src = ['def func',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects by removing redundant returns' do
-    src = ['def func',
-           '  one',
-           '  two',
-           '  return something',
-           'end'].join("\n")
-    result_src = ['def func',
-                  '  one',
-                  '  two',
-                  '  something',
-                  'end'].join("\n")
-    new_source = autocorrect_source(cop, src)
-    expect(new_source).to eq(result_src)
-  end
-
-  context 'when multi-value returns are not allowed' do
-    it 'reports an offense for def with only a return' do
-      src = ['def func',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'reports an offense for defs with only a return' do
-      src = ['def Test.func',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'reports an offense for def ending with return' do
-      src = ['def func',
-             '  one',
-             '  two',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'reports an offense for defs ending with return' do
-      src = ['def func',
-             '  one',
-             '  two',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'auto-corrects by making implicit arrays explicit' do
-      src = ['def func',
-             '  return  1, 2',
-             'end'].join("\n")
-      result_src = ['def func',
-                    '  [1, 2]', # Just 1, 2 is not valid Ruby.
-                    'end'].join("\n")
-      new_source = autocorrect_source(cop, src)
-      expect(new_source).to eq(result_src)
-    end
-  end
-
-  context 'when multi-value returns are allowed' do
-    let(:cop_config) { { 'AllowMultipleReturnValues' => true } }
-
-    it 'accepts def with only a return' do
-      src = ['def func',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts defs with only a return' do
-      src = ['def Test.func',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts def ending with return' do
-      src = ['def func',
-             '  one',
-             '  two',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts defs ending with return' do
-      src = ['def func',
-             '  one',
-             '  two',
-             '  return something, test',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'does not auto-correct' do
-      src = ['def func',
-             '  return  1, 2',
-             'end'].join("\n")
-      new_source = autocorrect_source(cop, src)
-      expect(new_source).to eq(src)
-    end
-  end
-end