rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/percent_literal_delimiters_spec.rb

@@ -1,316 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) do
-    {
-      'PreferredDelimiters' => {
-        '%'  => '[]',
-        '%i' => '[]',
-        '%q' => '[]',
-        '%Q' => '[]',
-        '%r' => '[]',
-        '%s' => '[]',
-        '%w' => '[]',
-        '%W' => '[]',
-        '%x' => '[]'
-      }
-    }
-  end
-
-  context '`%` interpolated string' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%[string]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%(string)')
-      expect(cop.messages).to eq([
-        '`%`-literals should be delimited by `[` and `]`'
-      ])
-    end
-
-    it 'does not register an offense for other delimiters ' \
-       'when containing preferred delimiter characters' do
-      inspect_source(cop, '%([string])')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters ' \
-       'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, '%(#{[1].first})')
-      expect(cop.messages.size).to eq(1)
-    end
-  end
-
-  context '`%q` string' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%q[string]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%q(string)')
-      expect(cop.messages).to eq([
-        '`%q`-literals should be delimited by `[` and `]`'
-      ])
-    end
-
-    it 'does not register an offense for other delimiters ' \
-       'when containing preferred delimiter characters' do
-      inspect_source(cop, '%q([string])')
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context '`%Q` interpolated string' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%Q[string]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%Q(string)')
-      expect(cop.messages).to eq([
-        '`%Q`-literals should be delimited by `[` and `]`'
-      ])
-    end
-
-    it 'does not register an offense for other delimiters ' \
-       'when containing preferred delimiter characters' do
-      inspect_source(cop, '%Q([string])')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters ' \
-       'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, '%Q(#{[1].first})')
-      expect(cop.messages.size).to eq(1)
-    end
-  end
-
-  context '`%w` string array' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%w[some words]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%w(some words)')
-      expect(cop.messages).to eq([
-        '`%w`-literals should be delimited by `[` and `]`'
-      ])
-    end
-
-    it 'does not register an offense for other delimiters ' \
-       'when containing preferred delimiter characters' do
-      inspect_source(cop, '%w([some] [words])')
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context '`%W` interpolated string array' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%W[some words]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%W(some words)')
-      expect(cop.messages).to eq([
-        '`%W`-literals should be delimited by `[` and `]`'
-      ])
-    end
-
-    it 'does not register an offense for other delimiters ' \
-       'when containing preferred delimiter characters' do
-      inspect_source(cop, '%W([some] [words])')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters ' \
-       'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, '%W(#{[1].first})')
-      expect(cop.messages.size).to eq(1)
-    end
-  end
-
-  context '`%r` interpolated regular expression' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%r[regexp]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%r(regexp)')
-      expect(cop.messages).to eq([
-        '`%r`-literals should be delimited by `[` and `]`'
-      ])
-    end
-
-    it 'does not register an offense for other delimiters ' \
-       'when containing preferred delimiter characters' do
-      inspect_source(cop, '%r([regexp])')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters ' \
-       'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, '%r(#{[1].first})')
-      expect(cop.messages.size).to eq(1)
-    end
-  end
-
-  context '`%i` symbol array', ruby: 2 do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%i[some symbols]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%i(some symbols)')
-      expect(cop.messages).to eq([
-        '`%i`-literals should be delimited by `[` and `]`'
-      ])
-    end
-  end
-
-  context '`%s` symbol' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%s[symbol]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%s(symbol)')
-      expect(cop.messages).to eq([
-        '`%s`-literals should be delimited by `[` and `]`'
-      ])
-    end
-  end
-
-  context '`%x` interpolated system call' do
-    it 'does not register an offense for preferred delimiters' do
-      inspect_source(cop, '%x[command]')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters' do
-      inspect_source(cop, '%x(command)')
-      expect(cop.messages).to eq([
-        '`%x`-literals should be delimited by `[` and `]`'
-      ])
-    end
-
-    it 'does not register an offense for other delimiters ' \
-       'when containing preferred delimiter characters' do
-      inspect_source(cop, '%x([command])')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for other delimiters ' \
-       'when containing preferred delimiter characters in interpolation' do
-      inspect_source(cop, '%x(#{[1].first})')
-      expect(cop.messages.size).to eq(1)
-    end
-  end
-
-  context 'auto-correct' do
-    it 'fixes a string' do
-      new_source = autocorrect_source(cop, '%(string)')
-      expect(new_source).to eq('%[string]')
-    end
-
-    it 'fixes a string array' do
-      new_source = autocorrect_source(cop, '%w(some words)')
-      expect(new_source).to eq('%w[some words]')
-    end
-
-    it 'fixes a string array in a scope' do
-      new_source = autocorrect_source(cop, ['module Foo',
-                                            '   class Bar',
-                                            '     def baz',
-                                            '       %(one two)',
-                                            '     end',
-                                            '   end',
-                                            ' end'])
-      expect(new_source).to eq(['module Foo',
-                                '   class Bar',
-                                '     def baz',
-                                '       %[one two]',
-                                '     end',
-                                '   end',
-                                ' end'].join("\n"))
-    end
-
-    it 'fixes a regular expression' do
-      original_source = '%r(.*)'
-      new_source = autocorrect_source(cop, original_source)
-      expect(new_source).to eq('%r[.*]')
-    end
-
-    it 'fixes a string with interpolation' do
-      original_source = '%Q|#{with_interpolation}|'
-      new_source = autocorrect_source(cop, original_source)
-      expect(new_source).to eq('%Q[#{with_interpolation}]')
-    end
-
-    it 'fixes a regular expression with interpolation' do
-      original_source = '%r|#{with_interpolation}|'
-      new_source = autocorrect_source(cop, original_source)
-      expect(new_source).to eq('%r[#{with_interpolation}]')
-    end
-
-    it 'fixes a regular expression with option' do
-      original_source = '%r(.*)i'
-      new_source = autocorrect_source(cop, original_source)
-      expect(new_source).to eq('%r[.*]i')
-    end
-
-    it 'preserves line breaks when fixing a multiline array' do
-      new_source = autocorrect_source(cop, ['%w(', 'some', 'words', ')'])
-      expect(new_source).to eq(['%w[',
-                                'some',
-                                'words',
-                                ']'].join("\n"))
-    end
-
-    it 'preserves indentation when correcting a multiline array' do
-      original_source = [
-        '  array = %w(',
-        '    first',
-        '    second',
-        '  )'
-      ]
-      corrected_source = [
-        '  array = %w[',
-        '    first',
-        '    second',
-        '  ]'
-      ].join("\n")
-      new_source = autocorrect_source(cop, original_source)
-      expect(new_source).to eq(corrected_source)
-    end
-
-    it 'preserves irregular indentation when correcting a multiline array' do
-      original_source = [
-        '  array = %w(',
-        '    first',
-        '  second',
-        ')'
-      ]
-      corrected_source = [
-        '  array = %w[',
-        '    first',
-        '  second',
-        ']'
-      ].join("\n")
-      new_source = autocorrect_source(cop, original_source)
-      expect(new_source).to eq(corrected_source)
-    end
-  end
-end

data/spec/rubocop/cop/style/percent_q_literals_spec.rb

@@ -1,122 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::PercentQLiterals, :config do
-  subject(:cop) { described_class.new(config) }
-
-  shared_examples 'accepts quote characters' do
-    it 'accepts single quotes' do
-      inspect_source(cop, "'hi'")
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts double quotes' do
-      inspect_source(cop, '"hi"')
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  shared_examples 'accepts any q string with backslash t' do
-    context 'with special characters' do
-      it 'accepts %q' do
-        inspect_source(cop, '%q(\t)')
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'accepts %Q' do
-        inspect_source(cop, '%Q(\t)')
-        expect(cop.offenses).to be_empty
-      end
-    end
-  end
-
-  context 'when EnforcedStyle is lower_case_q' do
-    let(:cop_config) { { 'EnforcedStyle' => 'lower_case_q' } }
-
-    context 'without interpolation' do
-      it 'accepts %q' do
-        inspect_source(cop, '%q(hi)')
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'registers offense for %Q' do
-        inspect_source(cop, '%Q(hi)')
-        expect(cop.messages)
-          .to eq(['Do not use `%Q` unless interpolation is needed.  Use `%q`.'])
-        expect(cop.highlights).to eq(['%Q('])
-      end
-
-      it 'auto-corrects' do
-        new_source = autocorrect_source(cop, '%Q(hi)')
-        expect(new_source).to eq('%q(hi)')
-      end
-
-      include_examples 'accepts quote characters'
-      include_examples 'accepts any q string with backslash t'
-    end
-
-    context 'with interpolation' do
-      it 'accepts %Q' do
-        inspect_source(cop, '%Q(#{1 + 2})')
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'accepts %q' do
-        # This is most probably a mistake, but not this cop's responsibility.
-        inspect_source(cop, '%q(#{1 + 2})')
-        expect(cop.offenses).to be_empty
-      end
-
-      include_examples 'accepts quote characters'
-    end
-  end
-
-  context 'when EnforcedStyle is upper_case_q' do
-    let(:cop_config) { { 'EnforcedStyle' => 'upper_case_q' } }
-
-    context 'without interpolation' do
-      it 'registers offense for %q' do
-        inspect_source(cop, '%q(hi)')
-        expect(cop.messages).to eq(['Use `%Q` instead of `%q`.'])
-        expect(cop.highlights).to eq(['%q('])
-      end
-
-      it 'accepts %Q' do
-        inspect_source(cop, '%Q(hi)')
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'auto-corrects' do
-        new_source = autocorrect_source(cop, '%q[hi]')
-        expect(new_source).to eq('%Q[hi]')
-      end
-
-      include_examples 'accepts quote characters'
-      include_examples 'accepts any q string with backslash t'
-    end
-
-    context 'with interpolation' do
-      it 'accepts %Q' do
-        inspect_source(cop, '%Q(#{1 + 2})')
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'accepts %q' do
-        # It's strange if interpolation syntax appears inside a static string,
-        # but we can't be sure if it's a mistake or not. Changing it to %Q
-        # would alter semantics, so we leave it as it is.
-        inspect_source(cop, '%q(#{1 + 2})')
-        expect(cop.offenses).to be_empty
-      end
-
-      it 'does not auto-correct' do
-        source = '%q(#{1 + 2})'
-        new_source = autocorrect_source(cop, source)
-        expect(new_source).to eq(source)
-      end
-
-      include_examples 'accepts quote characters'
-    end
-  end
-end

data/spec/rubocop/cop/style/perl_backrefs_spec.rb

@@ -1,22 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::PerlBackrefs do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for $1' do
-    inspect_source(cop, 'puts $1')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'auto-corrects $1 to Regexp.last_match[1]' do
-    new_source = autocorrect_source(cop, '$1')
-    expect(new_source).to eq('Regexp.last_match(1)')
-  end
-
-  it 'auto-corrects #$1 to #{Regexp.last_match[1]}' do
-    new_source = autocorrect_source(cop, '"#$1"')
-    expect(new_source).to eq('"#{Regexp.last_match(1)}"')
-  end
-end