rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/braces_around_hash_parameters_spec.rb

@@ -1,288 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::BracesAroundHashParameters, :config do
-  subject(:cop) { described_class.new(config) }
-
-  shared_examples 'general non-offenses' do
-    after(:each) { expect(cop.offenses).to be_empty }
-
-    it 'accepts one non-hash parameter' do
-      inspect_source(cop, 'where(2)')
-    end
-
-    it 'accepts multiple non-hash parameters' do
-      inspect_source(cop, 'where(1, "2")')
-    end
-
-    it 'accepts one empty hash parameter' do
-      inspect_source(cop, 'where({})')
-    end
-
-    it 'accepts one empty hash parameter with whitespace' do
-      inspect_source(cop, ['where(  {     ',
-                           " }\t   )  "])
-    end
-  end
-
-  shared_examples 'no_braces and context_dependent non-offenses' do
-    after(:each) { expect(cop.offenses).to be_empty }
-
-    it 'accepts one hash parameter without braces' do
-      inspect_source(cop, 'where(x: "y")')
-    end
-
-    it 'accepts one hash parameter without braces and with multiple keys' do
-      inspect_source(cop, 'where(x: "y", foo: "bar")')
-    end
-
-    it 'accepts one hash parameter without braces and with one hash value' do
-      inspect_source(cop, 'where(x: { "y" => "z" })')
-    end
-
-    it 'accepts property assignment with braces' do
-      inspect_source(cop, 'x.z = { y: "z" }')
-    end
-
-    it 'accepts operator with a hash parameter with braces' do
-      inspect_source(cop, 'x.z - { y: "z" }')
-    end
-  end
-
-  shared_examples 'no_braces and context_dependent offenses' do
-    let(:msg) { 'Redundant curly braces around a hash parameter.' }
-
-    it 'registers an offense for one non-hash parameter followed by a hash ' \
-       'parameter with braces' do
-      inspect_source(cop, 'where(1, { y: 2 })')
-      expect(cop.messages).to eq([msg])
-      expect(cop.highlights).to eq(['{ y: 2 }'])
-    end
-
-    it 'registers an offense for one object method hash parameter with ' \
-       'braces' do
-      inspect_source(cop, 'x.func({ y: "z" })')
-      expect(cop.messages).to eq([msg])
-      expect(cop.highlights).to eq(['{ y: "z" }'])
-    end
-
-    it 'registers an offense for one hash parameter with braces' do
-      inspect_source(cop, 'where({ x: 1 })')
-      expect(cop.messages).to eq([msg])
-      expect(cop.highlights).to eq(['{ x: 1 }'])
-    end
-
-    it 'registers an offense for one hash parameter with braces and ' \
-       'whitespace' do
-      inspect_source(cop, "where(  \n { x: 1 }   )")
-      expect(cop.messages).to eq([msg])
-      expect(cop.highlights).to eq(['{ x: 1 }'])
-    end
-
-    it 'registers an offense for one hash parameter with braces and multiple ' \
-       'keys' do
-      inspect_source(cop, 'where({ x: 1, foo: "bar" })')
-      expect(cop.messages).to eq([msg])
-      expect(cop.highlights).to eq(['{ x: 1, foo: "bar" }'])
-    end
-  end
-
-  shared_examples 'no_braces and context_dependent auto-corrections' do
-    it 'corrects one non-hash parameter followed by a hash parameter with ' \
-       'braces' do
-      corrected = autocorrect_source(cop, ['where(1, { y: 2 })'])
-      expect(corrected).to eq('where(1, y: 2)')
-    end
-
-    it 'corrects one object method hash parameter with braces' do
-      corrected = autocorrect_source(cop, ['x.func({ y: "z" })'])
-      expect(corrected).to eq('x.func(y: "z")')
-    end
-
-    it 'corrects one hash parameter with braces' do
-      corrected = autocorrect_source(cop, ['where({ x: 1 })'])
-      expect(corrected).to eq('where(x: 1)')
-    end
-
-    it 'corrects one hash parameter with braces and whitespace' do
-      corrected = autocorrect_source(cop, ['where(  ',
-                                           ' { x: 1 }   )'])
-      expect(corrected).to eq(['where(  ',
-                               ' x: 1   )'].join("\n"))
-    end
-
-    it 'corrects one hash parameter with braces and multiple keys' do
-      corrected = autocorrect_source(cop, ['where({ x: 1, foo: "bar" })'])
-      expect(corrected).to eq('where(x: 1, foo: "bar")')
-    end
-
-    it 'corrects one hash parameter with braces and extra leading whitespace' do
-      corrected = autocorrect_source(cop, ['where({   x: 1, y: 2 })'])
-      expect(corrected).to eq('where(x: 1, y: 2)')
-    end
-
-    it 'corrects one hash parameter with braces and extra trailing ' \
-       'whitespace' do
-      corrected = autocorrect_source(cop, ['where({ x: 1, y: 2   })'])
-      expect(corrected).to eq('where(x: 1, y: 2)')
-    end
-
-    it 'corrects one hash parameter with braces and a trailing comma' do
-      corrected = autocorrect_source(cop, ['where({ x: 1, y: 2, })'])
-      expect(corrected).to eq('where(x: 1, y: 2,)')
-    end
-
-    it 'corrects one hash parameter with braces and trailing comma and ' \
-       'whitespace' do
-      corrected = autocorrect_source(cop, ['where({ x: 1, y: 2,   })'])
-      expect(corrected).to eq('where(x: 1, y: 2,)')
-    end
-
-    it 'corrects one hash parameter with braces without adding extra space' do
-      corrected = autocorrect_source(cop, 'get :i, { q: { x: 1 } }')
-      expect(corrected).to eq('get :i, q: { x: 1 }')
-    end
-  end
-
-  context 'when EnforcedStyle is no_braces' do
-    let(:cop_config) { { 'EnforcedStyle' => 'no_braces' } }
-
-    context 'for correct code' do
-      include_examples 'general non-offenses'
-      include_examples 'no_braces and context_dependent non-offenses'
-    end
-
-    context 'for incorrect code' do
-      include_examples 'no_braces and context_dependent offenses'
-
-      after(:each) do
-        expect(cop.messages)
-          .to eq(['Redundant curly braces around a hash parameter.'])
-      end
-
-      it 'registers an offense for two hash parameters with braces' do
-        inspect_source(cop, 'where({ x: 1 }, { y: 2 })')
-        expect(cop.highlights).to eq(['{ y: 2 }'])
-      end
-    end
-
-    describe '#autocorrect' do
-      include_examples 'no_braces and context_dependent auto-corrections'
-
-      it 'corrects one hash parameter with braces' do
-        corrected = autocorrect_source(cop, ['where(1, { x: 1 })'])
-        expect(corrected).to eq('where(1, x: 1)')
-      end
-
-      it 'corrects two hash parameters with braces' do
-        corrected = autocorrect_source(cop, ['where(1, { x: 1 }, { y: 2 })'])
-        expect(corrected).to eq('where(1, { x: 1 }, y: 2)')
-      end
-    end
-  end
-
-  context 'when EnforcedStyle is context_dependent' do
-    let(:cop_config) { { 'EnforcedStyle' => 'context_dependent' } }
-
-    context 'for correct code' do
-      include_examples 'general non-offenses'
-      include_examples 'no_braces and context_dependent non-offenses'
-
-      it 'accepts two hash parameters with braces' do
-        inspect_source(cop, 'where({ x: 1 }, { y: 2 })')
-        expect(cop.offenses).to be_empty
-      end
-    end
-
-    context 'for incorrect code' do
-      include_examples 'no_braces and context_dependent offenses'
-
-      it 'registers an offense for one hash parameter with braces and one ' \
-         'without' do
-        inspect_source(cop, 'where({ x: 1 }, y: 2)')
-        expect(cop.messages)
-          .to eq(['Missing curly braces around a hash parameter.'])
-        expect(cop.highlights).to eq(['y: 2'])
-      end
-    end
-
-    describe '#autocorrect' do
-      include_examples 'no_braces and context_dependent auto-corrections'
-
-      it 'corrects one hash parameter with braces and one without' do
-        corrected = autocorrect_source(cop, ['where(1, { x: 1 }, y: 2)'])
-        expect(corrected).to eq('where(1, { x: 1 }, {y: 2})')
-      end
-
-      it 'corrects one hash parameter with braces' do
-        corrected = autocorrect_source(cop, ['where(1, { x: 1 })'])
-        expect(corrected).to eq('where(1, x: 1)')
-      end
-    end
-  end
-
-  context 'when EnforcedStyle is braces' do
-    let(:cop_config) { { 'EnforcedStyle' => 'braces' } }
-
-    context 'for correct code' do
-      include_examples 'general non-offenses'
-
-      after(:each) { expect(cop.offenses).to be_empty }
-
-      it 'accepts one hash parameter with braces' do
-        inspect_source(cop, 'where({ x: 1 })')
-      end
-
-      it 'accepts multiple hash parameters with braces' do
-        inspect_source(cop, 'where({ x: 1 }, { y: 2 })')
-      end
-
-      it 'accepts one hash parameter with braces and whitespace' do
-        inspect_source(cop, ["where( \t    {  x: 1 ",
-                             '  }   )'])
-      end
-    end
-
-    context 'for incorrect code' do
-      after(:each) do
-        expect(cop.messages)
-          .to eq(['Missing curly braces around a hash parameter.'])
-      end
-
-      it 'registers an offense for one hash parameter without braces' do
-        inspect_source(cop, 'where(x: "y")')
-        expect(cop.highlights).to eq(['x: "y"'])
-      end
-
-      it 'registers an offense for one hash parameter with multiple keys and ' \
-         'without braces' do
-        inspect_source(cop, 'where(x: "y", foo: "bar")')
-        expect(cop.highlights).to eq(['x: "y", foo: "bar"'])
-      end
-
-      it 'registers an offense for one hash parameter without braces with ' \
-         'one hash value' do
-        inspect_source(cop, 'where(x: { "y" => "z" })')
-        expect(cop.highlights).to eq(['x: { "y" => "z" }'])
-      end
-    end
-
-    describe '#autocorrect' do
-      it 'corrects one hash parameter without braces' do
-        corrected = autocorrect_source(cop, ['where(x: "y")'])
-        expect(corrected).to eq('where({x: "y"})')
-      end
-
-      it 'corrects one hash parameter with multiple keys and without braces' do
-        corrected = autocorrect_source(cop, ['where(x: "y", foo: "bar")'])
-        expect(corrected).to eq('where({x: "y", foo: "bar"})')
-      end
-
-      it 'corrects one hash parameter without braces with one hash value' do
-        corrected = autocorrect_source(cop, ['where(x: { "y" => "z" })'])
-        expect(corrected).to eq('where({x: { "y" => "z" }})')
-      end
-    end
-  end
-end

data/spec/rubocop/cop/style/case_equality_spec.rb

@@ -1,13 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::CaseEquality do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for ===' do
-    inspect_source(cop, 'Array === var')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.highlights).to eq(['==='])
-  end
-end

data/spec/rubocop/cop/style/case_indentation_spec.rb

@@ -1,293 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::CaseIndentation do
-  subject(:cop) { described_class.new(config) }
-  let(:config) do
-    merged = RuboCop::ConfigLoader
-             .default_configuration['Style/CaseIndentation'].merge(cop_config)
-    RuboCop::Config.new('Style/CaseIndentation' => merged,
-                        'Style/IndentationWidth' => { 'Width' => 2 })
-  end
-
-  context 'with IndentWhenRelativeTo: case' do
-    context 'with IndentOneStep: false' do
-      let(:cop_config) do
-        { 'IndentWhenRelativeTo' => 'case', 'IndentOneStep' => false }
-      end
-
-      context 'regarding assignment where the right hand side is a case' do
-        it 'accepts a correctly indented assignment' do
-          source = ['output = case variable',
-                    "         when 'value1'",
-                    "           'output1'",
-                    '         else',
-                    "           'output2'",
-                    '         end']
-          inspect_source(cop, source)
-          expect(cop.offenses).to be_empty
-        end
-
-        it 'registers an offense for an assignment indented as end' do
-          source = ['output = case variable',
-                    "when 'value1'",
-                    "  'output1'",
-                    'else',
-                    "  'output2'",
-                    'end']
-          inspect_source(cop, source)
-          expect(cop.messages).to eq(['Indent `when` as deep as `case`.'])
-          expect(cop.config_to_allow_offenses).to eq('IndentWhenRelativeTo' =>
-                                                     'end')
-        end
-
-        it 'registers an offense for an assignment indented some other way' do
-          source = ['output = case variable',
-                    "  when 'value1'",
-                    "    'output1'",
-                    '  else',
-                    "    'output2'",
-                    'end']
-          inspect_source(cop, source)
-          expect(cop.messages).to eq(['Indent `when` as deep as `case`.'])
-          expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-        end
-
-        it 'registers an offense for correct + opposite' do
-          source = ['output = case variable',
-                    "         when 'value1'",
-                    "           'output1'",
-                    '         else',
-                    "           'output2'",
-                    '         end',
-                    'output = case variable',
-                    "when 'value1'",
-                    "  'output1'",
-                    'else',
-                    "  'output2'",
-                    'end']
-          inspect_source(cop, source)
-          expect(cop.messages).to eq(['Indent `when` as deep as `case`.'])
-          expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-        end
-      end
-
-      it "registers an offense for a when clause that's deeper than case" do
-        source = ['case a',
-                  '    when 0 then return',
-                  '    else',
-                  '        case b',
-                  '         when 1 then return',
-                  '        end',
-                  'end']
-        inspect_source(cop, source)
-        expect(cop.messages).to eq(['Indent `when` as deep as `case`.'] * 2)
-      end
-
-      it "accepts a when clause that's equally indented with case" do
-        source = ['y = case a',
-                  '    when 0 then break',
-                  '    when 0 then return',
-                  '    else',
-                  '      z = case b',
-                  '          when 1 then return',
-                  '          when 1 then break',
-                  '          end',
-                  '    end',
-                  'case c',
-                  'when 2 then encoding',
-                  'end',
-                  '']
-        inspect_source(cop, source)
-        expect(cop.offenses).to be_empty
-      end
-
-      it "doesn't get confused by strings with case in them" do
-        source = ['a = "case"',
-                  'case x',
-                  'when 0',
-                  'end',
-                  '']
-        inspect_source(cop, source)
-        expect(cop.messages).to be_empty
-      end
-
-      it "doesn't get confused by symbols named case or when" do
-        source = ['KEYWORDS = { :case => true, :when => true }',
-                  'case type',
-                  'when 0',
-                  '  ParameterNode',
-                  'when 1',
-                  '  MethodCallNode',
-                  'end',
-                  '']
-        inspect_source(cop, source)
-        expect(cop.messages).to be_empty
-      end
-
-      it 'accepts correctly indented whens in complex combinations' do
-        source = ['each {',
-                  '  case state',
-                  '  when 0',
-                  '    case name',
-                  '    when :a',
-                  '    end',
-                  '  when 1',
-                  '    loop {',
-                  '      case name',
-                  '      when :b',
-                  '      end',
-                  '    }',
-                  '  end',
-                  '}',
-                  'case s',
-                  'when Array',
-                  'end',
-                  '']
-        inspect_source(cop, source)
-        expect(cop.messages).to be_empty
-      end
-    end
-
-    context 'with IndentOneStep: true' do
-      let(:cop_config) do
-        { 'IndentWhenRelativeTo' => 'case', 'IndentOneStep' => true }
-      end
-
-      context 'regarding assignment where the right hand side is a case' do
-        it 'accepts a correctly indented assignment' do
-          source = ['output = case variable',
-                    "           when 'value1'",
-                    "             'output1'",
-                    '           else',
-                    "             'output2'",
-                    '         end']
-          inspect_source(cop, source)
-          expect(cop.offenses).to be_empty
-        end
-
-        it 'registers an offense for an assignment indented some other way' do
-          source = ['output = case variable',
-                    "         when 'value1'",
-                    "           'output1'",
-                    '         else',
-                    "           'output2'",
-                    '         end']
-          inspect_source(cop, source)
-          expect(cop.messages)
-            .to eq(['Indent `when` one step more than `case`.'])
-        end
-      end
-
-      it "accepts a when clause that's 2 spaces deeper than case" do
-        source = ['case a',
-                  '  when 0 then return',
-                  '  else',
-                  '        case b',
-                  '          when 1 then return',
-                  '        end',
-                  'end']
-        inspect_source(cop, source)
-        expect(cop.offenses).to be_empty
-      end
-
-      it "registers an offense for a when clause that's equally indented " \
-         'with case' do
-        source = ['y = case a',
-                  '    when 0 then break',
-                  '    when 0 then return',
-                  '      z = case b',
-                  '          when 1 then return',
-                  '          when 1 then break',
-                  '          end',
-                  '    end',
-                  'case c',
-                  'when 2 then encoding',
-                  'end',
-                  '']
-        inspect_source(cop, source)
-        expect(cop.messages)
-          .to eq(['Indent `when` one step more than `case`.'] * 5)
-      end
-    end
-  end
-
-  context 'with IndentWhenRelativeTo: end' do
-    context 'with IndentOneStep: false' do
-      let(:cop_config) do
-        { 'IndentWhenRelativeTo' => 'end', 'IndentOneStep' => false }
-      end
-
-      context 'regarding assignment where the right hand side is a case' do
-        it 'accepts a correctly indented assignment' do
-          source = ['output = case variable',
-                    "when 'value1'",
-                    "  'output1'",
-                    'else',
-                    "  'output2'",
-                    'end']
-          inspect_source(cop, source)
-          expect(cop.offenses).to be_empty
-        end
-
-        it 'registers an offense for an assignment indented some other way' do
-          source = ['output = case variable',
-                    "  when 'value1'",
-                    "    'output1'",
-                    '  else',
-                    "    'output2'",
-                    'end']
-          inspect_source(cop, source)
-          expect(cop.messages).to eq(['Indent `when` as deep as `end`.'])
-        end
-      end
-    end
-
-    context 'with IndentOneStep: true' do
-      let(:cop_config) do
-        { 'IndentWhenRelativeTo' => 'end', 'IndentOneStep' => true }
-      end
-
-      context 'regarding assignment where the right hand side is a case' do
-        it 'accepts a correctly indented assignment' do
-          source = ['output = case variable',
-                    "  when 'value1'",
-                    "    'output1'",
-                    '  else',
-                    "    'output2'",
-                    'end']
-          inspect_source(cop, source)
-          expect(cop.offenses).to be_empty
-        end
-
-        it 'registers an offense for an assignment indented as case' do
-          source = ['output = case variable',
-                    "         when 'value1'",
-                    "           'output1'",
-                    '         else',
-                    "           'output2'",
-                    '         end']
-          inspect_source(cop, source)
-          expect(cop.messages)
-            .to eq(['Indent `when` one step more than `end`.'])
-          expect(cop.config_to_allow_offenses).to eq('IndentWhenRelativeTo' =>
-                                                     'case')
-        end
-
-        it 'registers an offense for an assignment indented some other way' do
-          source = ['output = case variable',
-                    "       when 'value1'",
-                    "         'output1'",
-                    '       else',
-                    "         'output2'",
-                    '       end']
-          inspect_source(cop, source)
-          expect(cop.messages)
-            .to eq(['Indent `when` one step more than `end`.'])
-          expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-        end
-      end
-    end
-  end
-end