rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/lint/literal_in_interpolation_spec.rb

@@ -1,31 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::LiteralInInterpolation do
-  subject(:cop) { described_class.new }
-
-  %w(1 2.0 [1] {}).each do |lit|
-    it "registers an offense for #{lit} in interpolation" do
-      inspect_source(cop,
-                     "\"this is the \#{#{lit}}\"")
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it "registers an offense only for final #{lit} in interpolation" do
-      inspect_source(cop,
-                     "\"this is the \#{#{lit};#{lit}}\"")
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  it 'accepts empty interpolation' do
-    inspect_source(cop, '"this is #{} silly"')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts strings like __FILE__' do
-    inspect_source(cop, '"this is #{__FILE__} silly"')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/lint/loop_spec.rb

@@ -1,27 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::Loop do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for begin/end/while' do
-    inspect_source(cop, 'begin something; top; end while test')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for begin/end/until' do
-    inspect_source(cop, 'begin something; top; end until test')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts normal while' do
-    inspect_source(cop, 'while test; one; two; end')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts normal until' do
-    inspect_source(cop, 'until test; one; two; end')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/lint/parentheses_as_grouped_expression_spec.rb

@@ -1,57 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::ParenthesesAsGroupedExpression do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for method call with space before the ' \
-     'parenthesis' do
-    inspect_source(cop, 'a.func (x)')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for predicate method call with space ' \
-     'before the parenthesis' do
-    inspect_source(cop, 'is? (x)')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for math expression' do
-    inspect_source(cop, 'puts (2 + 3) * 4')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts a method call without arguments' do
-    inspect_source(cop, 'func')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a method call with arguments but no parentheses' do
-    inspect_source(cop, 'puts x')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a chain of method calls' do
-    inspect_source(cop, ['a.b',
-                         'a.b 1',
-                         'a.b(1)'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts method with parens as arg to method without' do
-    inspect_source(cop, 'a b(c)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts an operator call with argument in parentheses' do
-    inspect_source(cop, ['a % (b + c)',
-                         'a.b = (c == d)'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a space inside opening paren followed by left paren' do
-    inspect_source(cop, 'a( (b) )')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/lint/require_parentheses_spec.rb

@@ -1,82 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::RequireParentheses do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for missing parentheses around expression with ' \
-     '&& operator' do
-    inspect_source(cop, ["if day.is? 'monday' && month == :jan",
-                         '  foo',
-                         'end'])
-    expect(cop.highlights).to eq(["day.is? 'monday' && month == :jan"])
-    expect(cop.messages)
-      .to eq(['Use parentheses in the method call to avoid confusion about ' \
-              'precedence.'])
-  end
-
-  it 'registers an offense for missing parentheses around expression with ' \
-     '|| operator' do
-    inspect_source(cop, "day_is? 'tuesday' || true")
-    expect(cop.highlights).to eq(["day_is? 'tuesday' || true"])
-  end
-
-  it 'registers an offense for missing parentheses around expression in ' \
-     'ternary' do
-    inspect_source(cop, "wd.include? 'tuesday' && true == true ? a : b")
-    expect(cop.highlights).to eq(["wd.include? 'tuesday' && true == true"])
-  end
-
-  it 'accepts missing parentheses around expression with + operator' do
-    inspect_source(cop, ["if day_is? 'tuesday' + rest",
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts method calls without parentheses followed by keyword and/or' do
-    inspect_source(cop, ["if day.is? 'tuesday' and month == :jan",
-                         'end',
-                         "if day.is? 'tuesday' or month == :jan",
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts method calls that are all operations' do
-    inspect_source(cop, ['if current_level == max + 1',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts condition that is not a call' do
-    inspect_source(cop, ['if @debug',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts parentheses around expression with boolean operator' do
-    inspect_source(cop, ["if day.is?('tuesday' && true == true)",
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts method call with parentheses in ternary' do
-    inspect_source(cop, "wd.include?('tuesday' && true == true) ? a : b")
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts missing parentheses when method is not a predicate' do
-    inspect_source(cop, "weekdays.foo 'tuesday' && true == true")
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts calls to methods that are setters' do
-    inspect_source(cop, 's.version = @version || ">= 1.8.5"')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts calls to methods that are operators' do
-    inspect_source(cop, 'a[b || c]')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/lint/rescue_exception_spec.rb

@@ -1,123 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::RescueException do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for rescue from Exception' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    'rescue Exception',
-                    '  #do nothing',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for rescue with ::Exception' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    'rescue ::Exception',
-                    '  #do nothing',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for rescue with StandardError, Exception' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    'rescue StandardError, Exception',
-                    '  #do nothing',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for rescue with Exception => e' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    'rescue Exception => e',
-                    '  #do nothing',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not register an offense for rescue with no class' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    '  return',
-                    'rescue',
-                    '  file.close',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for rescue with no class and => e' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    '  return',
-                    'rescue => e',
-                    '  file.close',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for rescue with other class' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    '  return',
-                    'rescue ArgumentError => e',
-                    '  file.close',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for rescue with other classes' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    '  return',
-                    'rescue EOFError, ArgumentError => e',
-                    '  file.close',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for rescue with a module prefix' do
-    inspect_source(cop,
-                   ['begin',
-                    '  something',
-                    '  return',
-                    'rescue Test::Exception => e',
-                    '  file.close',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not crash when the splat operator is used in a rescue' do
-    inspect_source(cop,
-                   ['ERRORS = [Exception]',
-                    'begin',
-                    '  a = 3 / 0',
-                    'rescue *ERRORS',
-                    '  puts e',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not crash when the namespace of a rescued class is in a local ' \
-     'variable' do
-    inspect_source(cop,
-                   ['adapter = current_adapter',
-                    'begin',
-                    'rescue adapter::ParseError',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/lint/shadowing_outer_local_variable_spec.rb

@@ -1,237 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::ShadowingOuterLocalVariable do
-  subject(:cop) { described_class.new }
-
-  context 'when a block argument has same name ' \
-          'as an outer scope variable' do
-    let(:source) do
-      [
-        'def some_method',
-        '  foo = 1',
-        '  puts foo',
-        '  1.times do |foo|',
-        '  end',
-        'end'
-      ]
-    end
-
-    it 'registers an offense' do
-      inspect_source(cop, source)
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.first.message)
-        .to eq('Shadowing outer local variable - `foo`.')
-      expect(cop.offenses.first.line).to eq(4)
-    end
-
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when a splat block argument has same name ' \
-          'as an outer scope variable' do
-    let(:source) do
-      [
-        'def some_method',
-        '  foo = 1',
-        '  puts foo',
-        '  1.times do |*foo|',
-        '  end',
-        'end'
-      ]
-    end
-
-    it 'registers an offense' do
-      inspect_source(cop, source)
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.first.message)
-        .to eq('Shadowing outer local variable - `foo`.')
-      expect(cop.offenses.first.line).to eq(4)
-    end
-
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when a block block argument has same name ' \
-          'as an outer scope variable' do
-    let(:source) do
-      [
-        'def some_method',
-        '  foo = 1',
-        '  puts foo',
-        '  proc_taking_block = proc do |&foo|',
-        '  end',
-        '  proc_taking_block.call do',
-        '  end',
-        'end'
-      ]
-    end
-
-    it 'registers an offense' do
-      inspect_source(cop, source)
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.first.message)
-        .to eq('Shadowing outer local variable - `foo`.')
-      expect(cop.offenses.first.line).to eq(4)
-    end
-
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when a block local variable has same name ' \
-          'as an outer scope variable' do
-    let(:source) do
-      [
-        'def some_method',
-        '  foo = 1',
-        '  puts foo',
-        '  1.times do |i; foo|',
-        '    puts foo',
-        '  end',
-        'end'
-      ]
-    end
-
-    it 'registers an offense' do
-      inspect_source(cop, source)
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.first.message)
-        .to eq('Shadowing outer local variable - `foo`.')
-      expect(cop.offenses.first.line).to eq(4)
-    end
-
-    include_examples 'mimics MRI 2.1', 'shadowing'
-  end
-
-  context 'when a block argument has different name ' \
-          'with outer scope variables' do
-    let(:source) do
-      [
-        'def some_method',
-        '  foo = 1',
-        '  puts foo',
-        '  1.times do |bar|',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts'
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when an outer scope variable is reassigned in a block' do
-    let(:source) do
-      [
-        'def some_method',
-        '  foo = 1',
-        '  puts foo',
-        '  1.times do',
-        '    foo = 2',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts'
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when an outer scope variable is referenced in a block' do
-    let(:source) do
-      [
-        'def some_method',
-        '  foo = 1',
-        '  puts foo',
-        '  1.times do',
-        '    puts foo',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts'
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when multiple block arguments have same name "_"' do
-    let(:source) do
-      [
-        'def some_method',
-        '  1.times do |_, foo, _|',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts'
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when multiple block arguments have ' \
-          'a same name starts with "_"' do
-    let(:source) do
-      [
-        'def some_method',
-        '  1.times do |_foo, bar, _foo|',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts' unless RUBY_VERSION < '2.0'
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when a block argument has same name "_" ' \
-          'as outer scope variable "_"' do
-    let(:source) do
-      [
-        'def some_method',
-        '  _ = 1',
-        '  puts _',
-        '  1.times do |_|',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts'
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when a block argument has a same name starts with "_" ' \
-          'as an outer scope variable' do
-    let(:source) do
-      [
-        'def some_method',
-        '  _foo = 1',
-        '  puts _foo',
-        '  1.times do |_foo|',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts'
-    include_examples 'mimics MRI 2.1'
-  end
-
-  context 'when a method argument has same name ' \
-          'as an outer scope variable' do
-    let(:source) do
-      [
-        'class SomeClass',
-        '  foo = 1',
-        '  puts foo',
-        '  def some_method(foo)',
-        '  end',
-        'end'
-      ]
-    end
-
-    include_examples 'accepts'
-    include_examples 'mimics MRI 2.1'
-  end
-end