rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/metrics/line_length_spec.rb

@@ -1,136 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Metrics::LineLength, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) { { 'Max' => 80 } }
-
-  it "registers an offense for a line that's 81 characters wide" do
-    inspect_source(cop, '#' * 81)
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.first.message).to eq('Line is too long. [81/80]')
-    expect(cop.config_to_allow_offenses).to eq('Max' => 81)
-  end
-
-  it 'highlights excessive characters' do
-    inspect_source(cop, '#' * 80 + 'abc')
-    expect(cop.highlights).to eq(['abc'])
-  end
-
-  it "accepts a line that's 80 characters wide" do
-    inspect_source(cop, '#' * 80)
-    expect(cop.offenses).to be_empty
-  end
-
-  context 'when AllowURI option is enabled' do
-    let(:cop_config) { { 'Max' => 80, 'AllowURI' => true } }
-
-    context 'and all the excessive characters are part of an URL' do
-      # This code example is allowed by AllowURI feature itself :).
-      let(:source) { <<-END }
-        # Some documentation comment...
-        # See: https://github.com/bbatsov/rubocop/commit/3b48d8bdf5b1c2e05e35061837309890f04ab08c
-      END
-
-      it 'accepts the line' do
-        inspect_source(cop, source)
-        expect(cop.offenses).to be_empty
-      end
-    end
-
-    context 'and the excessive characters include a complete URL' do
-      # rubocop:disable Metrics/LineLength
-      let(:source) { <<-END }
-        # See: http://google.com/, http://gmail.com/, https://maps.google.com/, http://plus.google.com/
-      END
-      # rubocop:enable Metrics/LineLength
-
-      it 'registers an offense for the line' do
-        inspect_source(cop, source)
-        expect(cop.offenses.size).to eq(1)
-      end
-
-      it 'highlights all the excessive characters' do
-        inspect_source(cop, source)
-        expect(cop.highlights).to eq(['http://plus.google.com/'])
-      end
-    end
-
-    context 'and the excessive characters include part of an URL ' \
-            'and another word' do
-      # rubocop:disable Metrics/LineLength
-      let(:source) { <<-END }
-        # See: https://github.com/bbatsov/rubocop/commit/3b48d8bdf5b1c2e05e35061837309890f04ab08c and
-        #   http://google.com/
-      END
-      # rubocop:enable Metrics/LineLength
-
-      it 'registers an offense for the line' do
-        inspect_source(cop, source)
-        expect(cop.offenses.size).to eq(1)
-      end
-
-      it 'highlights only the non-URL part' do
-        inspect_source(cop, source)
-        expect(cop.highlights).to eq([' and'])
-      end
-    end
-
-    context 'and an error other than URI::InvalidURIError is raised ' \
-            'while validating an URI-ish string' do
-      let(:cop_config) do
-        { 'Max' => 80, 'AllowURI' => true, 'URISchemes' => %w(LDAP) }
-      end
-
-      # rubocop:disable Metrics/LineLength
-      let(:source) { <<-END }
-        xxxxxxxxxxxxxxxxxxxxxxxxxxxxzxxxxxxxxxxx = LDAP::DEFAULT_GROUP_UNIQUE_MEMBER_LIST_KEY
-      END
-      # rubocop:enable Metrics/LineLength
-
-      it 'does not crash' do
-        expect { inspect_source(cop, source) }.not_to raise_error
-      end
-    end
-
-    context 'and the URL does not have a http(s) scheme' do
-      # rubocop:disable Metrics/LineLength
-      let(:source) { <<-END }
-        xxxxxxxxxxxxxxxxxxxxxxxxxxxxzxxxxxxxxxxx = 'otherprotocol://a.very.long.line.which.violates.LineLength/sadf'
-      END
-      # rubocop:enable Metrics/LineLength
-
-      it 'rejects the line' do
-        inspect_source(cop, source)
-        expect(cop.offenses.size).to eq(1)
-      end
-
-      context 'and the scheme has been configured' do
-        let(:cop_config) do
-          { 'Max' => 80, 'AllowURI' => true, 'URISchemes' => %w(otherprotocol) }
-        end
-
-        it 'accepts the line' do
-          inspect_source(cop, source)
-          expect(cop.offenses).to be_empty
-        end
-      end
-    end
-  end
-
-  context 'when AllowURI option is disabled' do
-    let(:cop_config) { { 'Max' => 80, 'AllowURI' => false } }
-
-    context 'and all the excessive characters are part of an URL' do
-      let(:source) { <<-END }
-        # See: https://github.com/bbatsov/rubocop/commit/3b48d8bdf5b1c2e05e35061837309890f04ab08c
-      END
-
-      it 'registers an offense for the line' do
-        inspect_source(cop, source)
-        expect(cop.offenses.size).to eq(1)
-      end
-    end
-  end
-end

data/spec/rubocop/cop/metrics/method_length_spec.rb

@@ -1,147 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Metrics::MethodLength, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) { { 'Max' => 5, 'CountComments' => false } }
-
-  it 'rejects a method with more than 5 lines' do
-    inspect_source(cop, ['def m()',
-                         '  a = 1',
-                         '  a = 2',
-                         '  a = 3',
-                         '  a = 4',
-                         '  a = 5',
-                         '  a = 6',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([1])
-    expect(cop.config_to_allow_offenses).to eq('Max' => 6)
-  end
-
-  it 'accepts a method with less than 5 lines' do
-    inspect_source(cop, ['def m()',
-                         '  a = 1',
-                         '  a = 2',
-                         '  a = 3',
-                         '  a = 4',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not count blank lines' do
-    inspect_source(cop, ['def m()',
-                         '  a = 1',
-                         '  a = 2',
-                         '  a = 3',
-                         '  a = 4',
-                         '',
-                         '',
-                         '  a = 7',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts empty methods' do
-    inspect_source(cop, ['def m()',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'is not fooled by one-liner methods, syntax #1' do
-    inspect_source(cop, ['def one_line; 10 end',
-                         'def self.m()',
-                         '  a = 1',
-                         '  a = 2',
-                         '  a = 4',
-                         '  a = 5',
-                         '  a = 6',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'is not fooled by one-liner methods, syntax #2' do
-    inspect_source(cop, ['def one_line(test) 10 end',
-                         'def self.m()',
-                         '  a = 1',
-                         '  a = 2',
-                         '  a = 4',
-                         '  a = 5',
-                         '  a = 6',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'checks class methods, syntax #1' do
-    inspect_source(cop, ['def self.m()',
-                         '  a = 1',
-                         '  a = 2',
-                         '  a = 3',
-                         '  a = 4',
-                         '  a = 5',
-                         '  a = 6',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([1])
-  end
-
-  it 'checks class methods, syntax #2' do
-    inspect_source(cop, ['class K',
-                         '  class << self',
-                         '    def m()',
-                         '      a = 1',
-                         '      a = 2',
-                         '      a = 3',
-                         '      a = 4',
-                         '      a = 5',
-                         '      a = 6',
-                         '    end',
-                         '  end',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([3])
-  end
-
-  it 'properly counts lines when method ends with block' do
-    inspect_source(cop, ['def m()',
-                         '  something do',
-                         '    a = 2',
-                         '    a = 3',
-                         '    a = 4',
-                         '    a = 5',
-                         '  end',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([1])
-  end
-
-  it 'does not count commented lines by default' do
-    inspect_source(cop, ['def m()',
-                         '  a = 1',
-                         '  #a = 2',
-                         '  a = 3',
-                         '  #a = 4',
-                         '  a = 5',
-                         '  a = 6',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  context 'when CountComments is enabled' do
-    before { cop_config['CountComments'] = true }
-
-    it 'also counts commented lines' do
-      inspect_source(cop, ['def m()',
-                           '  a = 1',
-                           '  #a = 2',
-                           '  a = 3',
-                           '  #a = 4',
-                           '  a = 5',
-                           '  a = 6',
-                           'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([1])
-    end
-  end
-end

data/spec/rubocop/cop/metrics/parameter_lists_spec.rb

@@ -1,44 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Metrics::ParameterLists, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) do
-    {
-      'Max' => 4,
-      'CountKeywordArgs' => true
-    }
-  end
-
-  it 'registers an offense for a method def with 5 parameters' do
-    inspect_source(cop, ['def meth(a, b, c, d, e)',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.config_to_allow_offenses).to eq('Max' => 5)
-  end
-
-  it 'accepts a method def with 4 parameters' do
-    inspect_source(cop, ['def meth(a, b, c, d)',
-                         'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  context 'When CountKeywordArgs is true' do
-    it 'counts keyword arguments as well', ruby: 2 do
-      inspect_source(cop, ['def meth(a, b, c, d: 1, e: 2)',
-                           'end'])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'When CountKeywordArgs is false' do
-    before { cop_config['CountKeywordArgs'] = false }
-
-    it 'it does not count keyword arguments', ruby: 2 do
-      inspect_source(cop, ['def meth(a, b, c, d: 1, e: 2)',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/metrics/perceived_complexity_spec.rb

@@ -1,222 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Metrics::PerceivedComplexity, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when Max is 1' do
-    let(:cop_config) { { 'Max' => 1 } }
-
-    it 'accepts a method with no decision points' do
-      inspect_source(cop, ['def method_name',
-                           '  call_foo',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts complex code outside of methods' do
-      inspect_source(cop,
-                     ['def method_name',
-                      '  call_foo',
-                      'end',
-                      '',
-                      'if first_condition then',
-                      '  call_foo if second_condition && third_condition',
-                      '  call_bar if fourth_condition || fifth_condition',
-                      'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for an if modifier' do
-      inspect_source(cop, ['def self.method_name',
-                           '  call_foo if some_condition',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-      expect(cop.highlights).to eq(['def'])
-      expect(cop.config_to_allow_offenses).to eq('Max' => 2)
-    end
-
-    it 'registers an offense for an unless modifier' do
-      inspect_source(cop, ['def method_name',
-                           '  call_foo unless some_condition',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for elsif and else blocks' do
-      inspect_source(cop, ['def method_name',
-                           '  if first_condition then',
-                           '    call_foo',
-                           '  elsif second_condition then',
-                           '    call_bar',
-                           '  else',
-                           '    call_bam',
-                           '  end',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [4/1]'])
-    end
-
-    it 'registers an offense for a ternary operator' do
-      inspect_source(cop, ['def method_name',
-                           '  value = some_condition ? 1 : 2',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for a while block' do
-      inspect_source(cop, ['def method_name',
-                           '  while some_condition do',
-                           '    call_foo',
-                           '  end',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for an until block' do
-      inspect_source(cop, ['def method_name',
-                           '  until some_condition do',
-                           '    call_foo',
-                           '  end',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for a for block' do
-      inspect_source(cop, ['def method_name',
-                           '  for i in 1..2 do',
-                           '    call_method',
-                           '  end',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for a rescue block' do
-      inspect_source(cop, ['def method_name',
-                           '  begin',
-                           '    call_foo',
-                           '  rescue Exception',
-                           '    call_bar',
-                           '  end',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for a case/when block' do
-      inspect_source(cop, ['def method_name',
-                           '  case value',
-                           '  when 1 then call_foo_1',
-                           '  when 2 then call_foo_2',
-                           '  when 3 then call_foo_3',
-                           '  when 4 then call_foo_4',
-                           '  end',
-                           'end'])
-      # The `case` node plus the first `when` score one complexity point
-      # together. The other `when` nodes get 0.2 complexity points.
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [3/1]'])
-    end
-
-    it 'registers an offense for a case/when block without an expression ' \
-       'after case' do
-      inspect_source(cop, ['def method_name',
-                           '  case',
-                           '  when value == 1',
-                           '    call_foo',
-                           '  when value == 2',
-                           '    call_bar',
-                           '  end',
-                           'end'])
-      # Here, the `case` node doesn't count, but each when scores one
-      # complexity point.
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [3/1]'])
-    end
-
-    it 'registers an offense for &&' do
-      inspect_source(cop, ['def method_name',
-                           '  call_foo && call_bar',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for and' do
-      inspect_source(cop, ['def method_name',
-                           '  call_foo and call_bar',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for ||' do
-      inspect_source(cop, ['def method_name',
-                           '  call_foo || call_bar',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'registers an offense for or' do
-      inspect_source(cop, ['def method_name',
-                           '  call_foo or call_bar',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [2/1]'])
-    end
-
-    it 'deals with nested if blocks containing && and ||' do
-      inspect_source(cop,
-                     ['def method_name',
-                      '  if first_condition then',
-                      '    call_foo if second_condition && third_condition',
-                      '    call_bar if fourth_condition || fifth_condition',
-                      '  end',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [6/1]'])
-    end
-
-    it 'counts only a single method' do
-      inspect_source(cop, ['def method_name_1',
-                           '  call_foo if some_condition',
-                           'end',
-                           '',
-                           'def method_name_2',
-                           '  call_foo if some_condition',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name_1 is too high. [2/1]',
-                'Perceived complexity for method_name_2 is too high. [2/1]'])
-    end
-  end
-
-  context 'when Max is 2' do
-    let(:cop_config) { { 'Max' => 2 } }
-
-    it 'counts stupid nested if and else blocks' do
-      inspect_source(cop, ['def method_name',                   # 1
-                           '  if first_condition then',         # 2
-                           '    call_foo',
-                           '  else',                            # 3
-                           '    if second_condition then',      # 4
-                           '      call_bar',
-                           '    else',                          # 5
-                           '      call_bam if third_condition', # 6
-                           '    end',
-                           '    call_baz if fourth_condition',  # 7
-                           '  end',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Perceived complexity for method_name is too high. [7/2]'])
-    end
-  end
-end