rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/empty_lines_around_class_body_spec.rb

@@ -1,135 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::EmptyLinesAroundClassBody, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when EnforcedStyle is no_empty_lines' do
-    let(:cop_config) { { 'EnforcedStyle' => 'no_empty_lines' } }
-
-    it 'registers an offense for class body starting with a blank' do
-      inspect_source(cop,
-                     ['class SomeClass',
-                      '',
-                      '  do_something',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Extra empty line detected at class body beginning.'])
-    end
-
-    it 'autocorrects class body containing only a blank' do
-      corrected = autocorrect_source(cop,
-                                     ['class SomeClass',
-                                      '',
-                                      'end'])
-      expect(corrected).to eq ['class SomeClass',
-                               'end'].join("\n")
-    end
-
-    it 'registers an offense for class body ending with a blank' do
-      inspect_source(cop,
-                     ['class SomeClass',
-                      '  do_something',
-                      '',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Extra empty line detected at class body end.'])
-    end
-
-    it 'registers an offense for singleton class body starting with a blank' do
-      inspect_source(cop,
-                     ['class << self',
-                      '',
-                      '  do_something',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Extra empty line detected at class body beginning.'])
-    end
-
-    it 'autocorrects singleton class body containing only a blank' do
-      corrected = autocorrect_source(cop,
-                                     ['class << self',
-                                      '',
-                                      'end'])
-      expect(corrected).to eq ['class << self',
-                               'end'].join("\n")
-    end
-
-    it 'registers an offense for singleton class body ending with a blank' do
-      inspect_source(cop,
-                     ['class << self',
-                      '  do_something',
-                      '',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Extra empty line detected at class body end.'])
-    end
-  end
-
-  context 'when EnforcedStyle is empty_lines' do
-    let(:cop_config) { { 'EnforcedStyle' => 'empty_lines' } }
-
-    it 'registers an offense for class body not starting or ending with a ' \
-       'blank' do
-      inspect_source(cop,
-                     ['class SomeClass',
-                      '  do_something',
-                      'end'])
-      expect(cop.messages).to eq(['Empty line missing at class body beginning.',
-                                  'Empty line missing at class body end.'])
-    end
-
-    it 'autocorrects class body containing nothing' do
-      corrected = autocorrect_source(cop,
-                                     ['class SomeClass',
-                                      'end'])
-      expect(corrected).to eq ['class SomeClass',
-                               '',
-                               'end'].join("\n")
-    end
-
-    it 'autocorrects beginning and end' do
-      new_source = autocorrect_source(cop,
-                                      ['class SomeClass',
-                                       '  do_something',
-                                       'end'])
-      expect(new_source).to eq(['class SomeClass',
-                                '',
-                                '  do_something',
-                                '',
-                                'end'].join("\n"))
-    end
-
-    it 'registers an offense for singleton class body not starting or ending ' \
-       'with a blank' do
-      inspect_source(cop,
-                     ['class << self',
-                      '  do_something',
-                      'end'])
-      expect(cop.messages).to eq(['Empty line missing at class body beginning.',
-                                  'Empty line missing at class body end.'])
-    end
-
-    it 'autocorrects singleton class body containing nothing' do
-      corrected = autocorrect_source(cop,
-                                     ['class << self',
-                                      'end'])
-      expect(corrected).to eq ['class << self',
-                               '',
-                               'end'].join("\n")
-    end
-
-    it 'autocorrects beginning and end' do
-      new_source = autocorrect_source(cop,
-                                      ['class << self',
-                                       '  do_something',
-                                       'end'])
-      expect(new_source).to eq(['class << self',
-                                '',
-                                '  do_something',
-                                '',
-                                'end'].join("\n"))
-    end
-  end
-end

data/spec/rubocop/cop/style/empty_lines_around_method_body_spec.rb

@@ -1,90 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::EmptyLinesAroundMethodBody do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for method body starting with a blank' do
-    inspect_source(cop,
-                   ['def some_method',
-                    '',
-                    '  do_something',
-                    'end'])
-    expect(cop.messages)
-      .to eq(['Extra empty line detected at method body beginning.'])
-  end
-
-  # The cop only registers an offense if the extra line is completely empty. If
-  # there is trailing whitespace, then that must be dealt with first. Having
-  # two cops registering offense for the line with only spaces would cause
-  # havoc in auto-correction.
-  it 'accepts method body starting with a line with spaces' do
-    inspect_source(cop,
-                   ['def some_method',
-                    '  ',
-                    '  do_something',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'autocorrects method body starting with a blank' do
-    corrected = autocorrect_source(cop,
-                                   ['def some_method',
-                                    '',
-                                    '  do_something',
-                                    'end'])
-    expect(corrected).to eq ['def some_method',
-                             '  do_something',
-                             'end'].join("\n")
-  end
-
-  it 'registers an offense for class method body starting with a blank' do
-    inspect_source(cop,
-                   ['def Test.some_method',
-                    '',
-                    '  do_something',
-                    'end'])
-    expect(cop.messages)
-      .to eq(['Extra empty line detected at method body beginning.'])
-  end
-
-  it 'autocorrects class method body starting with a blank' do
-    corrected = autocorrect_source(cop,
-                                   ['def Test.some_method',
-                                    '',
-                                    '  do_something',
-                                    'end'])
-    expect(corrected).to eq ['def Test.some_method',
-                             '  do_something',
-                             'end'].join("\n")
-  end
-
-  it 'registers an offense for method body ending with a blank' do
-    inspect_source(cop,
-                   ['def some_method',
-                    '  do_something',
-                    '',
-                    'end'])
-    expect(cop.messages)
-      .to eq(['Extra empty line detected at method body end.'])
-  end
-
-  it 'registers an offense for class method body ending with a blank' do
-    inspect_source(cop,
-                   ['def Test.some_method',
-                    '  do_something',
-                    '',
-                    'end'])
-    expect(cop.messages)
-      .to eq(['Extra empty line detected at method body end.'])
-  end
-
-  it 'is not fooled by single line methods' do
-    inspect_source(cop,
-                   ['def some_method; do_something; end',
-                    '',
-                    'something_else'])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/empty_lines_around_module_body_spec.rb

@@ -1,79 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::EmptyLinesAroundModuleBody, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when EnforcedStyle is no_empty_lines' do
-    let(:cop_config) { { 'EnforcedStyle' => 'no_empty_lines' } }
-
-    it 'registers an offense for module body starting with a blank' do
-      inspect_source(cop,
-                     ['module SomeModule',
-                      '',
-                      '  do_something',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Extra empty line detected at module body beginning.'])
-    end
-
-    it 'registers an offense for module body ending with a blank' do
-      inspect_source(cop,
-                     ['module SomeModule',
-                      '  do_something',
-                      '',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Extra empty line detected at module body end.'])
-    end
-
-    it 'autocorrects beginning and end' do
-      new_source = autocorrect_source(cop,
-                                      ['module SomeModule',
-                                       '',
-                                       '  do_something',
-                                       '',
-                                       'end'])
-      expect(new_source).to eq(['module SomeModule',
-                                '  do_something',
-                                'end'].join("\n"))
-    end
-  end
-
-  context 'when EnforcedStyle is empty_lines' do
-    let(:cop_config) { { 'EnforcedStyle' => 'empty_lines' } }
-
-    it 'registers an offense for module body not starting or ending with a ' \
-       'blank' do
-      inspect_source(cop,
-                     ['module SomeModule',
-                      '  do_something',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Empty line missing at module body beginning.',
-                'Empty line missing at module body end.'])
-    end
-
-    it 'registers an offense for module body not ending with a blank' do
-      inspect_source(cop,
-                     ['module SomeModule',
-                      '',
-                      '  do_something',
-                      'end'])
-      expect(cop.messages).to eq(['Empty line missing at module body end.'])
-    end
-
-    it 'autocorrects beginning and end' do
-      new_source = autocorrect_source(cop,
-                                      ['module SomeModule',
-                                       '  do_something',
-                                       'end'])
-      expect(new_source).to eq(['module SomeModule',
-                                '',
-                                '  do_something',
-                                '',
-                                'end'].join("\n"))
-    end
-  end
-end

data/spec/rubocop/cop/style/empty_lines_spec.rb

@@ -1,51 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::EmptyLines do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for consecutive empty lines' do
-    inspect_source(cop,
-                   ['test = 5', '', '', '', 'top'])
-    expect(cop.offenses.size).to eq(2)
-  end
-
-  it 'auto-corrects consecutive empty lines' do
-    corrected = autocorrect_source(cop,
-                                   ['test = 5', '', '', '', 'top'])
-    expect(corrected).to eq ['test = 5', '', 'top'].join("\n")
-  end
-
-  it 'works when there are no tokens' do
-    inspect_source(cop,
-                   '#comment')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'handles comments' do
-    inspect_source(cop,
-                   ['test', '', '#comment', 'top'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for empty lines in a string' do
-    inspect_source(cop, 'result = "test
-
-
-
-                                  string"')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for heredocs with empty lines inside' do
-    inspect_source(cop, ['str = <<-TEXT',
-                         'line 1',
-                         '',
-                         '',
-                         'line 2',
-                         'TEXT',
-                         'puts str'])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/empty_literal_spec.rb

@@ -1,117 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::EmptyLiteral do
-  subject(:cop) { described_class.new }
-
-  describe 'Empty Array' do
-    it 'registers an offense for Array.new()' do
-      inspect_source(cop,
-                     'test = Array.new()')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Use array literal `[]` instead of `Array.new`.'])
-    end
-
-    it 'registers an offense for Array.new' do
-      inspect_source(cop,
-                     'test = Array.new')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Use array literal `[]` instead of `Array.new`.'])
-    end
-
-    it 'does not register an offense for Array.new(3)' do
-      inspect_source(cop,
-                     'test = Array.new(3)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects Array.new to []' do
-      new_source = autocorrect_source(cop, 'test = Array.new')
-      expect(new_source).to eq('test = []')
-    end
-  end
-
-  describe 'Empty Hash' do
-    it 'registers an offense for Hash.new()' do
-      inspect_source(cop,
-                     'test = Hash.new()')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Use hash literal `{}` instead of `Hash.new`.'])
-    end
-
-    it 'registers an offense for Hash.new' do
-      inspect_source(cop,
-                     'test = Hash.new')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Use hash literal `{}` instead of `Hash.new`.'])
-    end
-
-    it 'does not register an offense for Hash.new(3)' do
-      inspect_source(cop,
-                     'test = Hash.new(3)')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'does not register an offense for Hash.new { block }' do
-      inspect_source(cop,
-                     'test = Hash.new { block }')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects Hash.new to {}' do
-      new_source = autocorrect_source(cop, 'Hash.new')
-      expect(new_source).to eq('{}')
-    end
-
-    it 'auto-corrects Hash.new to {} in various contexts' do
-      new_source =
-        autocorrect_source(cop, ['test = Hash.new',
-                                 'Hash.new.merge("a" => 3)',
-                                 'yadayada.map { a }.reduce(Hash.new, :merge)'])
-      expect(new_source)
-        .to eq(['test = {}',
-                '{}.merge("a" => 3)',
-                'yadayada.map { a }.reduce({}, :merge)'].join("\n"))
-    end
-
-    it 'does not auto-correct Hash.new to {} if changing code meaning' do
-      source = 'yadayada.map { a }.reduce Hash.new, :merge'
-      new_source = autocorrect_source(cop, source)
-      expect(new_source).to eq(source)
-    end
-  end
-
-  describe 'Empty String' do
-    it 'registers an offense for String.new()' do
-      inspect_source(cop,
-                     'test = String.new()')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(["Use string literal `''` instead of `String.new`."])
-    end
-
-    it 'registers an offense for String.new' do
-      inspect_source(cop,
-                     'test = String.new')
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(["Use string literal `''` instead of `String.new`."])
-    end
-
-    it 'does not register an offense for String.new("top")' do
-      inspect_source(cop,
-                     'test = String.new("top")')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects String.new to empty string literal' do
-      new_source = autocorrect_source(cop, 'test = String.new')
-      expect(new_source).to eq("test = ''")
-    end
-  end
-end