rubocop 0.29.1 → 0.30.0

data/spec/rubocop/config_spec.rb

@@ -1,235 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Config do
-  include FileHelper
-
-  subject(:configuration) { described_class.new(hash, loaded_path) }
-  let(:hash) { {} }
-  let(:loaded_path) { 'example/.rubocop.yml' }
-
-  describe '#validate', :isolated_environment do
-    # TODO: Because Config.load_file now outputs the validation warning,
-    #       it is inserting text into the rspec test output here.
-    #       The next 2 lines should be removed eventually.
-    before(:each) { $stderr = StringIO.new }
-    after(:each) { $stderr = STDERR }
-
-    subject(:configuration) do
-      RuboCop::ConfigLoader.load_file(configuration_path)
-    end
-
-    let(:configuration_path) { '.rubocop.yml' }
-
-    context 'when the configuration includes any unrecognized cop name' do
-      before do
-        create_file(configuration_path, [
-          'LyneLenth:',
-          '  Enabled: true',
-          '  Max: 100'
-        ])
-      end
-
-      it 'raises validation error' do
-        expect { configuration.validate }
-          .to raise_error(described_class::ValidationError,
-                          /^unrecognized cop LyneLenth/)
-      end
-    end
-
-    context 'when the configuration includes any unrecognized parameter' do
-      before do
-        create_file(configuration_path, [
-          'Metrics/LineLength:',
-          '  Enabled: true',
-          '  Min: 10'
-        ])
-      end
-
-      it 'raises validation error' do
-        expect { configuration.validate }
-          .to raise_error(described_class::ValidationError,
-                          /^unrecognized parameter Metrics\/LineLength:Min/)
-      end
-    end
-
-    context 'when the configuration includes any common parameter' do
-      # Common parameters are parameters that are not in the default
-      # configuration, but are nonetheless allowed for any cop.
-      before do
-        create_file(configuration_path, [
-          'Metrics/LineLength:',
-          '  Exclude:',
-          '    - lib/file.rb',
-          '  Include:',
-          '    - lib/file.xyz',
-          '  Severity: warning'
-        ])
-      end
-
-      it 'does not raise validation error' do
-        expect { configuration.validate }.to_not raise_error
-      end
-    end
-  end
-
-  describe '#file_to_include?' do
-    let(:hash) do
-      {
-        'AllCops' => {
-          'Include' => ['**/Gemfile', 'config/unicorn.rb.example']
-        }
-      }
-    end
-
-    let(:loaded_path) { '/home/foo/project/.rubocop.yml' }
-
-    context 'when the passed path matches any of patterns to include' do
-      it 'returns true' do
-        file_path = '/home/foo/project/Gemfile'
-        expect(configuration.file_to_include?(file_path)).to be_truthy
-      end
-    end
-
-    context 'when the passed path does not match any of patterns to include' do
-      it 'returns false' do
-        file_path = '/home/foo/project/Gemfile.lock'
-        expect(configuration.file_to_include?(file_path)).to be_falsey
-      end
-    end
-  end
-
-  describe '#file_to_exclude?' do
-    before { $stderr = StringIO.new }
-    after { $stderr = STDERR }
-
-    let(:hash) do
-      {
-        'AllCops' => {
-          'Exclude' => [
-            "#{Dir.pwd}/log/**/*",
-            '**/bar.rb'
-          ]
-        }
-      }
-    end
-
-    let(:loaded_path) { '/home/foo/project/.rubocop.yml' }
-
-    context 'when the passed path matches any of patterns to exclude' do
-      it 'returns true' do
-        file_path = "#{Dir.pwd}/log/foo.rb"
-        expect(configuration.file_to_exclude?(file_path)).to be_truthy
-
-        expect(configuration.file_to_exclude?('log/foo.rb')).to be_truthy
-
-        expect(configuration.file_to_exclude?('bar.rb')).to be_truthy
-      end
-    end
-
-    context 'when the passed path does not match any of patterns to exclude' do
-      it 'returns false' do
-        file_path = "#{Dir.pwd}/log_file.rb"
-        expect(configuration.file_to_exclude?(file_path)).to be_falsey
-
-        expect(configuration.file_to_exclude?('app/controller.rb')).to be_falsey
-
-        expect(configuration.file_to_exclude?('baz.rb')).to be_falsey
-      end
-    end
-  end
-
-  describe '#patterns_to_include' do
-    subject(:patterns_to_include) do
-      configuration = described_class.new(hash, loaded_path)
-      configuration.patterns_to_include
-    end
-
-    let(:hash) { {} }
-    let(:loaded_path) { 'example/.rubocop.yml' }
-
-    context 'when config file has AllCops => Include key' do
-      let(:hash) do
-        {
-          'AllCops' => {
-            'Include' => ['**/Gemfile', 'config/unicorn.rb.example']
-          }
-        }
-      end
-
-      it 'returns the Include value' do
-        expect(patterns_to_include).to eq([
-          '**/Gemfile',
-          'config/unicorn.rb.example'
-        ])
-      end
-    end
-  end
-
-  describe '#patterns_to_exclude' do
-    subject(:patterns_to_exclude) do
-      configuration = described_class.new(hash, loaded_path)
-      configuration.patterns_to_exclude
-    end
-
-    let(:hash) { {} }
-    let(:loaded_path) { 'example/.rubocop.yml' }
-
-    context 'when config file has AllCops => Exclude key' do
-      let(:hash) do
-        {
-          'AllCops' => {
-            'Exclude' => ['log/*']
-          }
-        }
-      end
-
-      it 'returns the Exclude value' do
-        expect(patterns_to_exclude).to eq(['log/*'])
-      end
-    end
-  end
-
-  describe '#deprecation_check' do
-    context 'when there is no AllCops configuration' do
-      let(:hash) { {} }
-
-      it 'does not yield' do
-        expect { |b| configuration.deprecation_check(&b) }.not_to yield_control
-      end
-    end
-
-    context 'when there is AllCops configuration' do
-      context 'if there are no Excludes or Includes keys' do
-        let(:hash) { { 'AllCops' => { 'Exclude' => [], 'Include' => [] } } }
-
-        it 'does not yield' do
-          expect do |b|
-            configuration.deprecation_check(&b)
-          end.not_to yield_control
-        end
-      end
-
-      context 'if there are is an Includes key' do
-        let(:hash) { { 'AllCops' => { 'Includes' => [] } } }
-
-        it 'yields' do
-          expect do |b|
-            configuration.deprecation_check(&b)
-          end.to yield_with_args(String)
-        end
-      end
-
-      context 'if there are is an Excludes key' do
-        let(:hash) { { 'AllCops' => { 'Excludes' => [] } } }
-
-        it 'yields' do
-          expect do |b|
-            configuration.deprecation_check(&b)
-          end.to yield_with_args(String)
-        end
-      end
-    end
-  end
-end

data/spec/rubocop/config_store_spec.rb

@@ -1,53 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::ConfigStore do
-  subject(:config_store) { described_class.new }
-
-  before do
-    allow(RuboCop::ConfigLoader).to receive(:configuration_file_for) do |arg|
-      # File tree:
-      # file1
-      # dir/.rubocop.yml
-      # dir/file2
-      # dir/subdir/file3
-      (arg =~ /dir/ ? 'dir' : '.') + '/.rubocop.yml'
-    end
-    allow(RuboCop::ConfigLoader)
-      .to receive(:configuration_from_file) { |arg| arg }
-    allow(RuboCop::ConfigLoader)
-      .to receive(:load_file) { |arg| RuboCop::Config.new(arg) }
-    allow(RuboCop::ConfigLoader)
-      .to receive(:merge_with_default) { |config| "merged #{config}" }
-  end
-
-  describe '.for' do
-    it 'always uses config specified in command line' do
-      config_store.options_config = :options_config
-      expect(config_store.for('file1')).to eq('merged options_config')
-    end
-
-    context 'when no config specified in command line' do
-      it 'gets config path and config from cache if available' do
-        expect(RuboCop::ConfigLoader).to receive(:configuration_file_for).once
-          .with('dir')
-        expect(RuboCop::ConfigLoader).to receive(:configuration_file_for).once
-          .with('dir/subdir')
-        # The stub returns the same config path for dir and dir/subdir.
-        expect(RuboCop::ConfigLoader).to receive(:configuration_from_file).once
-          .with('dir/.rubocop.yml')
-
-        config_store.for('dir/file2')
-        config_store.for('dir/file2')
-        config_store.for('dir/subdir/file3')
-      end
-
-      it 'searches for config path if not available in cache' do
-        expect(RuboCop::ConfigLoader).to receive(:configuration_file_for).once
-        expect(RuboCop::ConfigLoader).to receive(:configuration_from_file).once
-        config_store.for('file1')
-      end
-    end
-  end
-end

data/spec/rubocop/cop/commissioner_spec.rb

@@ -1,85 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Commissioner do
-  describe '#investigate' do
-    let(:cop) { double(RuboCop::Cop, offenses: []).as_null_object }
-    let(:force) { double(RuboCop::Cop::Force).as_null_object }
-
-    it 'returns all offenses found by the cops' do
-      allow(cop).to receive(:offenses).and_return([1])
-
-      commissioner = described_class.new([cop], [])
-      source = []
-      processed_source = parse_source(source)
-
-      expect(commissioner.investigate(processed_source)).to eq [1]
-    end
-
-    context 'when a cop has no interest in the file' do
-      it 'returns all offenses except the ones of the cop' do
-        cops = []
-        cops << double('cop A', offenses: %w(foo), relevant_file?: true)
-        cops << double('cop B', offenses: %w(bar), relevant_file?: false)
-        cops << double('cop C', offenses: %w(baz), relevant_file?: true)
-        cops.each(&:as_null_object)
-
-        commissioner = described_class.new(cops, [])
-        source = []
-        processed_source = parse_source(source)
-
-        expect(commissioner.investigate(processed_source)).to eq %w(foo baz)
-      end
-    end
-
-    it 'traverses the AST and invoke cops specific callbacks' do
-      expect(cop).to receive(:on_def)
-
-      commissioner = described_class.new([cop], [])
-      source = ['def method', '1', 'end']
-      processed_source = parse_source(source)
-
-      commissioner.investigate(processed_source)
-    end
-
-    it 'passes the input params to all cops/forces that implement their own' \
-       ' #investigate method' do
-      source = []
-      processed_source = parse_source(source)
-      expect(cop).to receive(:investigate).with(processed_source)
-      expect(force).to receive(:investigate).with(processed_source)
-
-      commissioner = described_class.new([cop], [force])
-
-      commissioner.investigate(processed_source)
-    end
-
-    it 'stores all errors raised by the cops' do
-      allow(cop).to receive(:on_def) { fail RuntimeError }
-
-      commissioner = described_class.new([cop], [])
-      source = ['def method', '1', 'end']
-      processed_source = parse_source(source)
-
-      commissioner.investigate(processed_source)
-
-      expect(commissioner.errors[cop].size).to eq(1)
-      expect(commissioner.errors[cop][0]).to be_instance_of(RuntimeError)
-    end
-
-    context 'when passed :raise_error option' do
-      it 're-raises the exception received while processing' do
-        allow(cop).to receive(:on_def) { fail RuntimeError }
-
-        commissioner = described_class.new([cop], [], raise_error: true)
-        source = ['def method', '1', 'end']
-        processed_source = parse_source(source)
-
-        expect do
-          commissioner.investigate(processed_source)
-        end.to raise_error(RuntimeError)
-      end
-    end
-  end
-end

data/spec/rubocop/cop/cop_spec.rb

@@ -1,135 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Cop do
-  subject(:cop) { described_class.new }
-  let(:location) do
-    source_buffer = Parser::Source::Buffer.new('test', 1)
-    source_buffer.source = "a\n"
-    Parser::Source::Range.new(source_buffer, 0, 1)
-  end
-
-  it 'initially has 0 offenses' do
-    expect(cop.offenses).to be_empty
-  end
-
-  describe '.qualified_cop_name' do
-    it 'adds namespace if the cop name is found in exactly one namespace' do
-      expect(described_class.qualified_cop_name('LineLength', '--only'))
-        .to eq('Metrics/LineLength')
-    end
-
-    it 'returns the given cop name if it is not found in any namespace' do
-      expect(described_class.qualified_cop_name('UnknownCop', '--only'))
-        .to eq('UnknownCop')
-    end
-
-    it 'returns the given cop name if it already has a namespace' do
-      expect(described_class.qualified_cop_name('Metrics/LineLength', '--only'))
-        .to eq('Metrics/LineLength')
-    end
-
-    it 'raises an error if the cop name is in more than one namespace' do
-      skip 'Example needs a cop with same name in two namespaces'
-      expect { described_class.qualified_cop_name('ExampleCop', '--only') }
-        .to raise_error(RuboCop::Cop::AmbiguousCopName)
-    end
-  end
-
-  it 'keeps track of offenses' do
-    cop.add_offense(nil, location, 'message')
-
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'will report registered offenses' do
-    cop.add_offense(nil, location, 'message')
-
-    expect(cop.offenses).not_to be_empty
-  end
-
-  it 'will set default severity' do
-    cop.add_offense(nil, location, 'message')
-
-    expect(cop.offenses.first.severity).to eq(:convention)
-  end
-
-  it 'will set custom severity if present' do
-    cop.config[cop.name] = { 'Severity' => 'warning' }
-    cop.add_offense(nil, location, 'message')
-
-    expect(cop.offenses.first.severity).to eq(:warning)
-  end
-
-  it 'will warn if custom severity is invalid' do
-    cop.config[cop.name] = { 'Severity' => 'superbad' }
-    expect(cop).to receive(:warn)
-    cop.add_offense(nil, location, 'message')
-  end
-
-  it 'registers offense with its name' do
-    cop = RuboCop::Cop::Style::For.new
-    cop.add_offense(nil, location, 'message')
-    expect(cop.offenses.first.cop_name).to eq('Style/For')
-  end
-
-  context 'with no submodule' do
-    subject(:cop) { described_class }
-    it('has right name') { expect(cop.cop_name).to eq('Cop/Cop') }
-    it('has right type') { expect(cop.cop_type).to eq(:cop) }
-  end
-
-  context 'with style cops' do
-    subject(:cop) { RuboCop::Cop::Style::For }
-    it('has right name') { expect(cop.cop_name).to eq('Style/For') }
-    it('has right type') { expect(cop.cop_type).to eq(:style) }
-  end
-
-  context 'with lint cops' do
-    subject(:cop) { RuboCop::Cop::Lint::Loop }
-    it('has right name') { expect(cop.cop_name).to eq('Lint/Loop') }
-    it('has right type') { expect(cop.cop_type).to eq(:lint) }
-  end
-
-  context 'with rails cops' do
-    subject(:cop) { RuboCop::Cop::Rails::Validation }
-    it('has right name') { expect(cop.cop_name).to eq('Rails/Validation') }
-    it('has right type') { expect(cop.cop_type).to eq(:rails) }
-  end
-
-  describe 'CopStore' do
-    context '#types' do
-      subject { described_class.all.types }
-      it('has types') { expect(subject.length).not_to eq(0) }
-      it { should include :lint }
-      it do
-        should include :rails
-      end
-      it { should include :style }
-      it 'contains every value only once' do
-        expect(subject.length).to eq(subject.uniq.length)
-      end
-    end
-    context '#with_type' do
-      let(:types) { described_class.all.types }
-      it 'has at least one cop per type' do
-        types.each do |c|
-          expect(described_class.all.with_type(c).length).to be > 0
-        end
-      end
-
-      it 'has each cop in exactly one type' do
-        sum = 0
-        types.each do |c|
-          sum += described_class.all.with_type(c).length
-        end
-        expect(sum).to be described_class.all.length
-      end
-
-      it 'returns 0 for an invalid type' do
-        expect(described_class.all.with_type('x').length).to be 0
-      end
-    end
-  end
-end