rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/redundant_self_spec.rb

@@ -1,186 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::RedundantSelf do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offense a self receiver on an rvalue' do
-    src = 'a = self.b'
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts a self receiver on an lvalue of an assignment' do
-    src = 'self.a = b'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a self receiver on an lvalue of an or-assignment' do
-    src = 'self.logger ||= Rails.logger'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a self receiver on an lvalue of an and-assignment' do
-    src = 'self.flag &&= value'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a self receiver on an lvalue of a plus-assignment' do
-    src = 'self.sum += 10'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a self receiver with the square bracket operator' do
-    src = 'self[a]'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a self receiver with the double less-than operator' do
-    src = 'self << a'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a self receiver for methods named like ruby keywords' do
-    src = ['a = self.class',
-           'self.for(deps, [], true)',
-           'self.and(other)',
-           'self.or(other)',
-           'self.alias',
-           'self.begin',
-           'self.break',
-           'self.case',
-           'self.def',
-           'self.defined',
-           'self.do',
-           'self.else',
-           'self.elsif',
-           'self.end',
-           'self.ensure',
-           'self.false',
-           'self.if',
-           'self.in',
-           'self.module',
-           'self.next',
-           'self.nil',
-           'self.not',
-           'self.redo',
-           'self.rescue',
-           'self.retry',
-           'self.return',
-           'self.self',
-           'self.super',
-           'self.then',
-           'self.true',
-           'self.undef',
-           'self.unless',
-           'self.until',
-           'self.when',
-           'self.while',
-           'self.yield'
-          ]
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  describe 'instance methods' do
-    it 'accepts a self receiver used to distinguish from blockarg' do
-      src = ['def requested_specs(&groups)',
-             '  some_method(self.groups)',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a self receiver used to distinguish from argument' do
-      src = ['def requested_specs(groups)',
-             '  some_method(self.groups)',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a self receiver used to distinguish from argument' do
-      src = ['def requested_specs(final = true)',
-             '  something if self.final != final',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a self receiver used to distinguish from local variable' do
-      src = ['def requested_specs',
-             '  @requested_specs ||= begin',
-             '    groups = self.groups - Bundler.settings.without',
-             '    groups.map! { |g| g.to_sym }',
-             '    specs_for(groups)',
-             '  end',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  describe 'class methods' do
-    it 'accepts a self receiver used to distinguish from blockarg' do
-      src = ['def self.requested_specs(&groups)',
-             '  some_method(self.groups)',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a self receiver used to distinguish from argument' do
-      src = ['def self.requested_specs(groups)',
-             '  some_method(self.groups)',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a self receiver used to distinguish from argument' do
-      src = ['def self.requested_specs(final = true)',
-             '  something if self.final != final',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a self receiver used to distinguish from local variable' do
-      src = ['def self.requested_specs',
-             '  @requested_specs ||= begin',
-             '    groups = self.groups - Bundler.settings.without',
-             '    groups.map! { |g| g.to_sym }',
-             '    specs_for(groups)',
-             '  end',
-             'end'
-            ]
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  it 'accepts a self receiver used to distinguish from constant' do
-    src = 'self.Foo'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects by removing redundant self' do
-    new_source = autocorrect_source(cop, 'self.x')
-    expect(new_source).to eq('x')
-  end
-end

data/spec/rubocop/cop/style/regexp_literal_spec.rb

@@ -1,188 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::RegexpLiteral, :config do
-  subject(:cop) { described_class.new(config) }
-
-  before { described_class.slash_count = nil }
-
-  context 'when MaxSlashes is -1' do
-    let(:cop_config) { { 'MaxSlashes' => -1 } }
-
-    it 'fails' do
-      expect { inspect_source(cop, 'x =~ /home/') }
-        .to raise_error(RuntimeError)
-    end
-  end
-
-  context 'when MaxSlashes is 0' do
-    let(:cop_config) { { 'MaxSlashes' => 0 } }
-
-    it 'registers an offense for one slash in // regexp' do
-      inspect_source(cop, 'x =~ /home\//')
-      expect(cop.messages)
-        .to eq(['Use %r for regular expressions matching more ' \
-                "than 0 '/' characters."])
-    end
-
-    it 'accepts zero slashes in // regexp' do
-      inspect_source(cop, 'z =~ /a/')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for zero slashes in %r regexp' do
-      inspect_source(cop, 'y =~ %r(etc)')
-      expect(cop.messages)
-        .to eq(['Use %r only for regular expressions matching more ' \
-                "than 0 '/' characters."])
-    end
-
-    it 'accepts %r regexp with one slash' do
-      inspect_source(cop, 'x =~ %r(/home)')
-      expect(cop.offenses).to be_empty
-    end
-
-    describe '--auto-gen-config' do
-      subject(:cop) { described_class.new(config, auto_gen_config: true) }
-
-      it 'sets MaxSlashes: 1 for one slash in // regexp' do
-        inspect_source(cop, 'x =~ /home\//')
-        expect(cop.config_to_allow_offenses).to eq('MaxSlashes' => 1)
-      end
-
-      it 'disables the cop for zero slashes in %r regexp' do
-        inspect_source(cop, 'y =~ %r(etc)')
-        expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-      end
-
-      it 'generates nothing if there are no offenses' do
-        inspect_source(cop, 'x =~ %r(/home)')
-        expect(cop.config_to_allow_offenses).to eq(nil)
-      end
-    end
-  end
-
-  context 'when MaxSlashes is 1' do
-    let(:cop_config) { { 'MaxSlashes' => 1 } }
-
-    it 'registers an offense for two slashes in // regexp' do
-      inspect_source(cop, ['x =~ /home\/\//',
-                           'y =~ /etc\/top\//'])
-      expect(cop.messages)
-        .to eq(['Use %r for regular expressions matching more ' \
-                "than 1 '/' character."] * 2)
-    end
-
-    it 'registers offenses for slashes with too many' do
-      inspect_source(cop, 'x =~ /home\/\/\//')
-      expect(cop.messages)
-        .to eq(['Use %r for regular expressions matching more ' \
-                "than 1 '/' character."])
-    end
-
-    it 'registers offenses for %r with too few' do
-      inspect_source(cop, ['x =~ /home\/\/\//',
-                           'y =~ %r{home}'])
-      expect(cop.messages)
-        .to eq(['Use %r for regular expressions matching more ' \
-                "than 1 '/' character.",
-                'Use %r only for regular expressions matching more ' \
-                "than 1 '/' character."])
-    end
-
-    it 'accepts zero or one slash in // regexp' do
-      inspect_source(cop, ['x =~ /\/home/',
-                           'y =~ /\//',
-                           'w =~ /\//m',
-                           'z =~ /a/'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'ignores slashes do not belong // regexp' do
-      inspect_source(cop, 'x =~ /\s{#{x[/\s+/].length}}/')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for zero or one slash in %r regexp' do
-      inspect_source(cop, ['x =~ %r(/home)',
-                           'y =~ %r(etc)'])
-      expect(cop.messages)
-        .to eq(['Use %r only for regular expressions matching more ' \
-                "than 1 '/' character."] * 2)
-    end
-
-    it 'accepts %r regexp with two or more slashes' do
-      inspect_source(cop, ['x =~ %r(/home/)',
-                           'y =~ %r(/////)'])
-      expect(cop.offenses).to be_empty
-    end
-
-    describe '--auto-gen-config' do
-      subject(:cop) { described_class.new(config, auto_gen_config: true) }
-
-      it 'sets MaxSlashes: 2 for two slashes in // and 3 in %r' do
-        inspect_source(cop, ['x =~ /home\/\//',
-                             'y =~ %r{/usr/lib/ext}'])
-        expect(cop.config_to_allow_offenses).to eq('MaxSlashes' => 2)
-      end
-
-      it 'sets MaxSlashes: 0 for one slash in %r regexp' do
-        inspect_source(cop, 'x =~ %r{/home}')
-        expect(cop.config_to_allow_offenses).to eq('MaxSlashes' => 0)
-      end
-
-      it 'disables the cop for zero or one slash in %r regexp' do
-        inspect_source(cop, ['x =~ %r(/home)',
-                             'y =~ %r(etc)'])
-        expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-      end
-
-      it 'disables the cop for // with too many and %r with too few' do
-        inspect_source(cop, ['x =~ /home\/\/\//',
-                             'y =~ %r{home}'])
-        expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-      end
-
-      it 'disables the cop for %r with too few and // with too many' do
-        inspect_source(cop, ['y =~ %r{home}',
-                             'x =~ /home\/\//'])
-        expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-      end
-
-      context 'when Enabled has been set to false' do
-        before do
-          inspect_source(cop, ['x =~ /home\/\/\//',
-                               'y =~ %r{/home/}'])
-        end
-
-        it 'does not change it' do
-          inspect_source(cop, 'x =~ %r{/home}')
-          expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-        end
-      end
-    end
-
-    context 'when --auto-gen-config is not given' do
-      subject(:cop) { described_class.new(config) }
-
-      it 'does not set MaxSlashes' do
-        inspect_source(cop, ['x =~ /home\/\//',
-                             'y =~ %r{/usr/lib/ext}'])
-        expect(cop.config_to_allow_offenses).to eq(nil)
-      end
-    end
-  end
-
-  context 'across multiple files (instances)' do
-    let(:cop_config) { { 'MaxSlashes' => 0 } }
-
-    it 'preserves slash count for --auto-gen-config' do
-      2.times do |i|
-        cop = described_class.new(config, auto_gen_config: true)
-        inspect_source(cop, "/http:#{'\/' * (i + 1)}/")
-      end
-      expect(described_class.slash_count['/']).to eq(Set.new([0, 1, 2]))
-    end
-  end
-end

data/spec/rubocop/cop/style/rescue_modifier_spec.rb

@@ -1,116 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::RescueModifier do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for modifier rescue' do
-    inspect_source(cop,
-                   'method rescue handle')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Avoid using `rescue` in its modifier form.'])
-  end
-
-  it 'handles more complex expression with modifier rescue' do
-    inspect_source(cop,
-                   'method1 or method2 rescue handle')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Avoid using `rescue` in its modifier form.'])
-  end
-
-  it 'handles modifier rescue in normal rescue' do
-    inspect_source(cop,
-                   ['begin',
-                    '  test rescue modifier_handle',
-                    'rescue',
-                    '  normal_handle',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.first.line).to eq(2)
-  end
-
-  it 'does not register an offense for normal rescue' do
-    inspect_source(cop,
-                   ['begin',
-                    '  test',
-                    'rescue',
-                    '  handle',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for normal rescue with ensure' do
-    inspect_source(cop,
-                   ['begin',
-                    '  test',
-                    'rescue',
-                    '  handle',
-                    'ensure',
-                    '  cleanup',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not register an offense for nested normal rescue' do
-    inspect_source(cop,
-                   ['begin',
-                    '  begin',
-                    '    test',
-                    '  rescue',
-                    '    handle_inner',
-                    '  end',
-                    'rescue',
-                    '  handle_outer',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  context 'when an instance method has implicit begin' do
-    it 'accepts normal rescue' do
-      inspect_source(cop,
-                     ['def some_method',
-                      '  test',
-                      'rescue',
-                      '  handle',
-                      'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'handles modifier rescue in body of implicit begin' do
-      inspect_source(cop,
-                     ['def some_method',
-                      '  test rescue modifier_handle',
-                      'rescue',
-                      '  normal_handle',
-                      'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.first.line).to eq(2)
-    end
-  end
-
-  context 'when a singleton method has implicit begin' do
-    it 'accepts normal rescue' do
-      inspect_source(cop,
-                     ['def self.some_method',
-                      '  test',
-                      'rescue',
-                      '  handle',
-                      'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'handles modifier rescue in body of implicit begin' do
-      inspect_source(cop,
-                     ['def self.some_method',
-                      '  test rescue modifier_handle',
-                      'rescue',
-                      '  normal_handle',
-                      'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.first.line).to eq(2)
-    end
-  end
-end