rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/lint/condition_position_spec.rb

@@ -1,51 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::ConditionPosition do
-  subject(:cop) { described_class.new }
-
-  %w(if unless while until).each do |keyword|
-    it 'registers an offense for condition on the next line' do
-      inspect_source(cop,
-                     ["#{keyword}",
-                      'x == 10',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-
-    it 'accepts condition on the same line' do
-      inspect_source(cop,
-                     ["#{keyword} x == 10",
-                      ' bala',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts condition on a different line for modifiers' do
-      inspect_source(cop,
-                     ["do_something #{keyword}",
-                      '  something && something_else'])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  it 'registers an offense for elsif condition on the next line' do
-    inspect_source(cop,
-                   ['if something',
-                    '  test',
-                    'elsif',
-                    '  something',
-                    '  test',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'handles ternary ops' do
-    inspect_source(cop, 'x ? a : b')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/lint/debugger_spec.rb

@@ -1,73 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::Debugger do
-  subject(:cop) { described_class.new  }
-
-  it 'reports an offense for a debugger call' do
-    src = 'debugger'
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Remove debugger entry point `debugger`.'])
-    expect(cop.highlights).to eq(['debugger'])
-  end
-
-  it 'reports an offense for a byebug call' do
-    src = 'byebug'
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages).to eq(['Remove debugger entry point `byebug`.'])
-    expect(cop.highlights).to eq(['byebug'])
-  end
-
-  it 'reports an offense for pry bindings' do
-    src = ['binding.pry',
-           'binding.remote_pry',
-           'binding.pry_remote']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(3)
-    expect(cop.messages)
-      .to eq(['Remove debugger entry point `binding.pry`.',
-              'Remove debugger entry point `binding.remote_pry`.',
-              'Remove debugger entry point `binding.pry_remote`.'])
-    expect(cop.highlights).to eq(['binding.pry',
-                                  'binding.remote_pry',
-                                  'binding.pry_remote'])
-  end
-
-  it 'reports an offense for capybara debug methods' do
-    src = %w(save_and_open_page save_and_open_screenshot)
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(2)
-    expect(cop.messages)
-      .to eq(['Remove debugger entry point `save_and_open_page`.',
-              'Remove debugger entry point `save_and_open_screenshot`.'])
-    expect(cop.highlights)
-      .to eq(%w(save_and_open_page save_and_open_screenshot))
-  end
-
-  it 'does not report an offense for non-pry binding' do
-    src = 'binding.pirate'
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  %w(debugger byebug pry remote_pry pry_remote
-     save_and_open_page save_and_open_screenshot).each do |comment|
-    it "does not report an offense for #{comment} in comments" do
-      src = "# #{comment}"
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  %w(debugger byebug pry remote_pry pry_remote
-     save_and_open_page save_and_open_screenshot).each do |method_name|
-    it "does not report an offense for a #{method_name} method" do
-      src = "code.#{method_name}"
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/lint/def_end_alignment_spec.rb

@@ -1,108 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::DefEndAlignment, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:opposite) do
-    cop_config['AlignWith'] == 'def' ? 'start_of_line' : 'def'
-  end
-
-  context 'when AlignWith is start_of_line' do
-    let(:cop_config) { { 'AlignWith' => 'start_of_line' } }
-
-    include_examples 'misaligned', '', 'def', 'test',      '  end'
-    include_examples 'misaligned', '', 'def', 'Test.test', '  end', 'defs'
-
-    include_examples 'aligned', 'def', 'test',      'end'
-    include_examples 'aligned', 'def', 'Test.test', 'end', 'defs'
-
-    context 'in ruby 2.1 or later' do
-      include_examples 'aligned', 'public def',          'test', 'end'
-      include_examples 'aligned', 'protected def',       'test', 'end'
-      include_examples 'aligned', 'private def',         'test', 'end'
-      include_examples 'aligned', 'module_function def', 'test', 'end'
-
-      include_examples('misaligned', '',
-                       'public def', 'test',
-                       '       end')
-      include_examples('misaligned', '',
-                       'protected def', 'test',
-                       '          end')
-      include_examples('misaligned', '',
-                       'private def', 'test',
-                       '        end')
-      include_examples('misaligned', '',
-                       'module_function def', 'test',
-                       '                end')
-    end
-
-    it 'registers an offense for correct + opposite' do
-      inspect_source(cop, ['private def a',
-                           '  a1',
-                           'end',
-                           '',
-                           'private def b',
-                           '          b1',
-                           '        end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages.first)
-        .to eq('`end` at 7, 8 is not aligned with `private def` at 5, 8')
-      expect(cop.highlights.first).to eq('end')
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-  end
-
-  context 'when AlignWith is def' do
-    let(:cop_config) { { 'AlignWith' => 'def' } }
-
-    include_examples 'misaligned', '', 'def', 'test',      '  end'
-    include_examples 'misaligned', '', 'def', 'Test.test', '  end', 'defs'
-
-    include_examples 'aligned', 'def', 'test',      'end'
-    include_examples 'aligned', 'def', 'Test.test', 'end', 'defs'
-
-    context 'in ruby 2.1 or later' do
-      include_examples('aligned',
-                       'public def',          'test',
-                       '       end')
-      include_examples('aligned',
-                       'protected def',       'test',
-                       '          end')
-      include_examples('aligned',
-                       'private def', 'test',
-                       '        end')
-      include_examples('aligned',
-                       'module_function def', 'test',
-                       '                end')
-
-      include_examples('misaligned',
-                       'public ', 'def', 'test',
-                       'end')
-      include_examples('misaligned',
-                       'protected ', 'def', 'test',
-                       'end')
-      include_examples('misaligned',
-                       'private ', 'def', 'test',
-                       'end')
-      include_examples('misaligned',
-                       'module_function ', 'def', 'test',
-                       'end')
-
-      it 'registers an offense for correct + opposite' do
-        inspect_source(cop, ['private def a',
-                             '  a1',
-                             'end',
-                             '',
-                             'private def b',
-                             '          b1',
-                             '        end'])
-        expect(cop.offenses.size).to eq(1)
-        expect(cop.messages.first)
-          .to eq('`end` at 3, 0 is not aligned with `def` at 1, 8')
-        expect(cop.highlights.first).to eq('end')
-        expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-      end
-    end
-  end
-end

data/spec/rubocop/cop/lint/deprecated_class_methods_spec.rb

@@ -1,38 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::DeprecatedClassMethods do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for File.exists?' do
-    inspect_source(cop, 'File.exists?(o)')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['`File.exists?` is deprecated in favor of `File.exist?`.'])
-  end
-
-  it 'registers an offense for ::File.exists?' do
-    inspect_source(cop, '::File.exists?(o)')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['`File.exists?` is deprecated in favor of `File.exist?`.'])
-  end
-
-  it 'registers an offense for Dir.exists?' do
-    inspect_source(cop, 'Dir.exists?(o)')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['`Dir.exists?` is deprecated in favor of `Dir.exist?`.'])
-  end
-
-  it 'auto-corrects File.exists? with File.exist?' do
-    new_source = autocorrect_source(cop, 'File.exists?(something)')
-    expect(new_source).to eq('File.exist?(something)')
-  end
-
-  it 'auto-corrects Dir.exists? with Dir.exist?' do
-    new_source = autocorrect_source(cop, 'Dir.exists?(something)')
-    expect(new_source).to eq('Dir.exist?(something)')
-  end
-end

data/spec/rubocop/cop/lint/duplicate_methods_spec.rb

@@ -1,189 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::DuplicateMethods do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for duplicate method in class' do
-    inspect_source(cop,
-                   ['class A',
-                    '  def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def some_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not register an offense for non-duplicate method in class' do
-    inspect_source(cop,
-                   ['class A',
-                    '  def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def any_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for duplicate method in module' do
-    inspect_source(cop,
-                   ['module A',
-                    '  def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def some_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not register an offense for non-duplicate method in module' do
-    inspect_source(cop,
-                   ['module A',
-                    '  def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def any_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for duplicate class methods in module' do
-    inspect_source(cop,
-                   ['module A',
-                    '  def self.some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def self.some_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-  it 'doesn`t registers an offense for non-duplicate class methods in module' do
-    inspect_source(cop,
-                   ['module A',
-                    '  def self.some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def self.any_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(0)
-  end
-
-  it 'differ instance and class methods in module' do
-    inspect_source(cop,
-                   ['module A',
-                    '  def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def self.some_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(0)
-  end
-
-  it %(registers an offense for duplicate private methods in class) do
-    inspect_source(cop,
-                   ['class A',
-                    '  private def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  private def some_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it %(registers an offense for duplicate private self methods in class) do
-    inspect_source(cop,
-                   ['class A',
-                    '  private def self.some_method',
-                    '    implement 1',
-                    '  end',
-                    '  private def self.some_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it %(don`t registers an offense for different private methods in class) do
-    inspect_source(cop,
-                   ['class A',
-                    '  private def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  private def any_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(0)
-  end
-
-  it %(registers an offense for duplicate protected methods in class) do
-    inspect_source(cop,
-                   ['class A',
-                    '  protected def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  protected def some_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it %(registers 2 offenses for pair of duplicate methods in class) do
-    inspect_source(cop,
-                   ['class A',
-                    '  def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def some_method',
-                    '    implement 2',
-                    '  end',
-                    '  def any_method',
-                    '    implement 1',
-                    '  end',
-                    '  def any_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.offenses.size).to eq(2)
-  end
-
-  it %(generate 2 offenses with specified messages) do
-    inspect_source(cop,
-                   ['class A',
-                    '  def some_method',
-                    '    implement 1',
-                    '  end',
-                    '  def some_method',
-                    '    implement 2',
-                    '  end',
-                    '  def any_method',
-                    '    implement 1',
-                    '  end',
-                    '  def any_method',
-                    '    implement 2',
-                    '  end',
-                    'end'])
-    expect(cop.messages).to match_array([
-      %(Duplicate methods `some_method` at lines `2, 5` detected.),
-      %(Duplicate methods `any_method` at lines `8, 11` detected.)])
-  end
-end