rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/space_inside_brackets_spec.rb

@@ -1,83 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceInsideBrackets do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for an array literal with spaces inside' do
-    inspect_source(cop, ['a = [1, 2 ]',
-                         'b = [ 1, 2]'])
-    expect(cop.messages).to eq(
-      ['Space inside square brackets detected.',
-       'Space inside square brackets detected.'])
-  end
-
-  it 'registers an offense for Hash#[] with symbol key and spaces inside' do
-    inspect_source(cop, ['a[ :key]',
-                         'b[:key ]'])
-    expect(cop.messages).to eq(
-      ['Space inside square brackets detected.',
-       'Space inside square brackets detected.'])
-  end
-
-  it 'registers an offense for Hash#[] with string key and spaces inside' do
-    inspect_source(cop, ['a[\'key\' ]',
-                         'b[ \'key\']'])
-    expect(cop.messages).to eq(
-      ['Space inside square brackets detected.',
-       'Space inside square brackets detected.'])
-  end
-
-  it 'accepts space inside strings within square brackets' do
-    inspect_source(cop, ["['Encoding:',",
-                         " '  Enabled: false']"])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts space inside square brackets if on its own row' do
-    inspect_source(cop, ['a = [',
-                         '     1, 2',
-                         '    ]'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts space inside square brackets if with comment' do
-    inspect_source(cop, ['a = [ # Comment',
-                         '     1, 2',
-                         '    ]'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts square brackets as method name' do
-    inspect_source(cop, ['def Vector.[](*array)',
-                         'end'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts square brackets called with method call syntax' do
-    inspect_source(cop, 'subject.[](0)')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'only reports a single space once' do
-    inspect_source(cop, '[ ]')
-    expect(cop.messages).to eq(
-      ['Space inside square brackets detected.'])
-  end
-
-  it 'auto-corrects unwanted space' do
-    new_source = autocorrect_source(cop, ['a = [1, 2 ]',
-                                          'b = [ 1, 2]',
-                                          'c[ :key]',
-                                          'd[:key ]',
-                                          'e["key" ]',
-                                          'f[ "key"]'])
-    expect(new_source).to eq(['a = [1, 2]',
-                              'b = [1, 2]',
-                              'c[:key]',
-                              'd[:key]',
-                              'e["key"]',
-                              'f["key"]'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/space_inside_hash_literal_braces_spec.rb

@@ -1,147 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) { { 'EnforcedStyle' => 'space' } }
-
-  context 'with space inside empty braces not allowed' do
-    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'no_space' } }
-
-    it 'accepts empty braces with no space inside' do
-      inspect_source(cop, 'h = {}')
-      expect(cop.messages).to be_empty
-    end
-
-    it 'registers an offense for empty braces with space inside' do
-      inspect_source(cop, 'h = { }')
-      expect(cop.messages)
-        .to eq(['Space inside empty hash literal braces detected.'])
-      expect(cop.highlights).to eq([' '])
-    end
-
-    it 'auto-corrects unwanted space' do
-      new_source = autocorrect_source(cop, 'h = { }')
-      expect(new_source).to eq('h = {}')
-    end
-  end
-
-  context 'with space inside empty braces allowed' do
-    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'space' } }
-
-    it 'accepts empty braces with space inside' do
-      inspect_source(cop, 'h = { }')
-      expect(cop.messages).to be_empty
-    end
-
-    it 'registers an offense for empty braces with no space inside' do
-      inspect_source(cop, 'h = {}')
-      expect(cop.messages)
-        .to eq(['Space inside empty hash literal braces missing.'])
-      expect(cop.highlights).to eq(['{'])
-    end
-
-    it 'auto-corrects missing space' do
-      new_source = autocorrect_source(cop, 'h = {}')
-      expect(new_source).to eq('h = { }')
-    end
-  end
-
-  it 'registers an offense for hashes with no spaces if so configured' do
-    inspect_source(cop,
-                   ['h = {a: 1, b: 2}',
-                    'h = {a => 1}'])
-    expect(cop.messages).to eq(['Space inside { missing.',
-                                'Space inside } missing.',
-                                'Space inside { missing.',
-                                'Space inside } missing.'])
-    expect(cop.highlights).to eq(['{', '}', '{', '}'])
-    expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'no_space')
-  end
-
-  it 'registers an offense for correct + opposite' do
-    inspect_source(cop,
-                   'h = { a: 1}')
-    expect(cop.messages).to eq(['Space inside } missing.'])
-    expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-  end
-
-  it 'auto-corrects missing space' do
-    new_source = autocorrect_source(cop, ['h = {a: 1, b: 2}',
-                                          'h = {a => 1 }'])
-    expect(new_source).to eq(['h = { a: 1, b: 2 }',
-                              'h = { a => 1 }'].join("\n"))
-  end
-
-  context 'when EnforcedStyle is no_space' do
-    let(:cop_config) { { 'EnforcedStyle' => 'no_space' } }
-
-    it 'registers an offense for hashes with spaces' do
-      inspect_source(cop,
-                     'h = { a: 1, b: 2 }')
-      expect(cop.messages).to eq(['Space inside { detected.',
-                                  'Space inside } detected.'])
-      expect(cop.highlights).to eq([' ', ' '])
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'space')
-    end
-
-    it 'registers an offense for opposite + correct' do
-      inspect_source(cop,
-                     'h = {a: 1 }')
-      expect(cop.messages).to eq(['Space inside } detected.'])
-      expect(cop.config_to_allow_offenses).to eq('Enabled' => false)
-    end
-
-    it 'auto-corrects unwanted space' do
-      new_source = autocorrect_source(cop, ['h = { a: 1, b: 2 }',
-                                            'h = {a => 1 }'])
-      expect(new_source).to eq(['h = {a: 1, b: 2}',
-                                'h = {a => 1}'].join("\n"))
-    end
-
-    it 'accepts hashes with no spaces' do
-      inspect_source(cop,
-                     ['h = {a: 1, b: 2}',
-                      'h = {a => 1}'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts multiline hash' do
-      inspect_source(cop,
-                     ['h = {',
-                      '      a: 1,',
-                      '      b: 2,',
-                      '}'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts multiline hash with comment' do
-      inspect_source(cop,
-                     ['h = { # Comment',
-                      '      a: 1,',
-                      '      b: 2,',
-                      '}'])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  it 'accepts hashes with spaces by default' do
-    inspect_source(cop,
-                   ['h = { a: 1, b: 2 }',
-                    'h = { a => 1 }'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts hash literals with no braces' do
-    inspect_source(cop, 'x(a: b.c)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'can handle interpolation in a braceless hash literal' do
-    # A tricky special case where the closing brace of the
-    # interpolation risks getting confused for a hash literal brace.
-    inspect_source(cop, 'f(get: "#{x}")')
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/style/space_inside_parens_spec.rb

@@ -1,44 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceInsideParens do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for spaces inside parens' do
-    inspect_source(cop, ['f( 3)',
-                         'g = (a + 3 )'])
-    expect(cop.messages).to eq(['Space inside parentheses detected.'] * 2)
-  end
-
-  it 'accepts parentheses in block parameter list' do
-    inspect_source(cop,
-                   ['list.inject(Tms.new) { |sum, (label, item)|',
-                    '}'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts parentheses with no spaces' do
-    inspect_source(cop, 'split("\n")')
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts parentheses with line break' do
-    inspect_source(cop, ['f(',
-                         '  1)'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'accepts parentheses with comment and line break' do
-    inspect_source(cop, ['f( # Comment',
-                         '  1)'])
-    expect(cop.messages).to be_empty
-  end
-
-  it 'auto-corrects unwanted space' do
-    new_source = autocorrect_source(cop, ['f( 3)',
-                                          'g = ( a + 3 )'])
-    expect(new_source).to eq(['f(3)',
-                              'g = (a + 3)'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/space_inside_range_literal_spec.rb

@@ -1,64 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpaceInsideRangeLiteral do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for space inside .. literal' do
-    inspect_source(cop,
-                   ['1 .. 2',
-                    '1.. 2',
-                    '1 ..2'])
-    expect(cop.offenses.size).to eq(3)
-    expect(cop.messages)
-      .to eq(['Space inside range literal.'] * 3)
-  end
-
-  it 'accepts no space inside .. literal' do
-    inspect_source(cop, '1..2')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for space inside ... literal' do
-    inspect_source(cop,
-                   ['1 ... 2',
-                    '1... 2',
-                    '1 ...2'])
-    expect(cop.offenses.size).to eq(3)
-    expect(cop.messages)
-      .to eq(['Space inside range literal.'] * 3)
-  end
-
-  it 'accepts no space inside ... literal' do
-    inspect_source(cop, '1...2')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts complex range literal with space in it' do
-    inspect_source(cop, '0...(line - 1)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts multiline range literal with no space in it' do
-    inspect_source(cop, ['x = 0..',
-                         '    10'])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense in multiline range literal with space in it' do
-    inspect_source(cop, ['x = 0 ..',
-                         '    10'])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'autocorrects space around .. literal' do
-    corrected = autocorrect_source(cop, ['1  .. 2'])
-    expect(corrected).to eq '1..2'
-  end
-
-  it 'autocorrects space around ... literal' do
-    corrected = autocorrect_source(cop, ['1  ... 2'])
-    expect(corrected).to eq '1...2'
-  end
-end

data/spec/rubocop/cop/style/special_global_vars_spec.rb

@@ -1,62 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::SpecialGlobalVars do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for $:' do
-    inspect_source(cop, 'puts $:')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Prefer `$LOAD_PATH` over `$:`.'])
-  end
-
-  it 'registers an offense for $"' do
-    inspect_source(cop, 'puts $"')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Prefer `$LOADED_FEATURES` over `$"`.'])
-  end
-
-  it 'registers an offense for $0' do
-    inspect_source(cop, 'puts $0')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Prefer `$PROGRAM_NAME` over `$0`.'])
-  end
-
-  it 'registers an offense for $$' do
-    inspect_source(cop, 'puts $$')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['Prefer `$PROCESS_ID` or `$PID` from the English ' \
-              'library over `$$`.'])
-  end
-
-  it 'is clear about variables from the English library vs those not' do
-    inspect_source(cop, 'puts $*')
-    expect(cop.messages)
-      .to eq(['Prefer `$ARGV` from the English library, or `ARGV` over `$*`.'])
-  end
-
-  it 'does not register an offense for backrefs like $1' do
-    inspect_source(cop, 'puts $1')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects $: to $LOAD_PATH' do
-    new_source = autocorrect_source(cop, '$:')
-    expect(new_source).to eq('$LOAD_PATH')
-  end
-
-  it 'auto-corrects $/ to $INPUT_RECORD_SEPARATOR' do
-    new_source = autocorrect_source(cop, '$/')
-    expect(new_source).to eq('$INPUT_RECORD_SEPARATOR')
-  end
-
-  it 'auto-corrects #$: to #{$LOAD_PATH}' do
-    new_source = autocorrect_source(cop, '"#$:"')
-    expect(new_source).to eq('"#{$LOAD_PATH}"')
-  end
-end

data/spec/rubocop/cop/style/string_literals_in_interpolation_spec.rb

@@ -1,99 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::StringLiteralsInInterpolation, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'configured with single quotes preferred' do
-    let(:cop_config) { { 'EnforcedStyle' => 'single_quotes' } }
-
-    it 'registers an offense for double quotes within embedded expression' do
-      src = '"#{"A"}"'
-      inspect_source(cop, src)
-      expect(cop.messages)
-        .to eq(['Prefer single-quoted strings inside interpolations.'])
-    end
-
-    it 'registers an offense for double quotes within embedded expression in ' \
-       'a heredoc string' do
-      src = ['<<END',
-             '#{"A"}',
-             'END']
-      inspect_source(cop, src)
-      expect(cop.messages)
-        .to eq(['Prefer single-quoted strings inside interpolations.'])
-    end
-
-    it 'accepts double quotes on a static string' do
-      src = '"A"'
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts double quotes on a broken static string' do
-      src = ['"A" \\',
-             '  "B"']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts double quotes on static strings within a method' do
-      src = ['def m',
-             '  puts "A"',
-             '  puts "B"',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'can handle a built-in constant parsed as string' do
-      # Parser will produce str nodes for constants such as __FILE__.
-      src = ['if __FILE__ == $PROGRAM_NAME',
-             'end']
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'can handle character literals' do
-      src = 'a = ?/'
-      inspect_source(cop, src)
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'auto-corrects " with \'' do
-      new_source = autocorrect_source(cop, 's = "#{"abc"}"')
-      expect(new_source).to eq(%q(s = "#{'abc'}"))
-    end
-  end
-
-  context 'configured with double quotes preferred' do
-    let(:cop_config) { { 'EnforcedStyle' => 'double_quotes' } }
-
-    it 'registers an offense for single quotes within embedded expression' do
-      src = %q("#{'A'}")
-      inspect_source(cop, src)
-      expect(cop.messages)
-        .to eq(['Prefer double-quoted strings inside interpolations.'])
-    end
-
-    it 'registers an offense for single quotes within embedded expression in ' \
-       'a heredoc string' do
-      src = ['<<END',
-             '#{\'A\'}',
-             'END']
-      inspect_source(cop, src)
-      expect(cop.messages)
-        .to eq(['Prefer double-quoted strings inside interpolations.'])
-    end
-  end
-
-  context 'when configured with a bad value' do
-    let(:cop_config) { { 'EnforcedStyle' => 'other' } }
-
-    it 'fails' do
-      expect { inspect_source(cop, 'a = "#{"b"}"') }
-        .to raise_error(RuntimeError)
-    end
-  end
-end