rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/style/comment_annotation_spec.rb

@@ -1,86 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::CommentAnnotation, :config do
-  subject(:cop) { described_class.new(config) }
-  let(:cop_config) do
-    { 'Keywords' => %w(TODO FIXME OPTIMIZE HACK REVIEW) }
-  end
-
-  it 'registers an offense for a missing colon' do
-    inspect_source(cop, '# TODO make better')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  context 'with configured keyword' do
-    let(:cop_config) { { 'Keywords' => %w(ISSUE) } }
-
-    it 'registers an offense for a missing colon after the word' do
-      inspect_source(cop, '# ISSUE wrong order')
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'when used with the clang formatter' do
-    let(:formatter) { RuboCop::Formatter::ClangStyleFormatter.new(output) }
-    let(:output) { StringIO.new }
-
-    it 'marks the annotation keyword' do
-      inspect_source(cop, '# TODO:make better')
-      formatter.report_file('t', cop.offenses)
-      expect(output.string).to eq(["t:1:3: C: #{described_class::MSG}",
-                                   '# TODO:make better',
-                                   '  ^^^^^',
-                                   ''].join("\n"))
-    end
-  end
-
-  it 'registers an offense for lower case' do
-    inspect_source(cop, '# fixme: does not work')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for capitalized annotation keyword' do
-    inspect_source(cop, '# Optimize: does not work')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for upper case with colon but no note' do
-    inspect_source(cop, '# HACK:')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts upper case keyword with colon, space and note' do
-    inspect_source(cop, '# REVIEW: not sure about this')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts upper case keyword alone' do
-    inspect_source(cop, '# OPTIMIZE')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a comment that is obviously a code example' do
-    inspect_source(cop, '# Todo.destroy(1)')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts a keyword that is just the beginning of a sentence' do
-    inspect_source(cop,
-                   ["# Optimize if you want. I wouldn't recommend it.",
-                    '# Hack is a fun game.'])
-    expect(cop.offenses).to be_empty
-  end
-
-  context 'when a keyword is not in the configuration' do
-    let(:cop_config) do
-      { 'Keywords' => %w(FIXME OPTIMIZE HACK REVIEW) }
-    end
-
-    it 'accepts the word without colon' do
-      inspect_source(cop, '# TODO make better')
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/style/comment_indentation_spec.rb

@@ -1,179 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::CommentIndentation do
-  subject(:cop) { described_class.new(config) }
-  let(:config) do
-    RuboCop::Config
-      .new('Style/IndentationWidth' => { 'Width' => indentation_width })
-  end
-  let(:indentation_width) { 2 }
-
-  context 'on outer level' do
-    it 'accepts a correctly indented comment' do
-      inspect_source(cop, '# comment')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a comment that follows code' do
-      inspect_source(cop, 'hello # comment')
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'accepts a documentation comment' do
-      inspect_source(cop, ['=begin',
-                           'Doc comment',
-                           '=end',
-                           '  hello',
-                           ' #',
-                           'hi'])
-      expect(cop.highlights).to eq(['#'])
-    end
-
-    it 'registers an offense for an incorrectly indented (1) comment' do
-      inspect_source(cop, ' # comment')
-      expect(cop.messages)
-        .to eq(['Incorrect indentation detected (column 1 instead of 0).'])
-      expect(cop.highlights).to eq(['# comment'])
-    end
-
-    it 'registers an offense for an incorrectly indented (2) comment' do
-      inspect_source(cop, '  # comment')
-      expect(cop.messages)
-        .to eq(['Incorrect indentation detected (column 2 instead of 0).'])
-    end
-
-    it 'registers an offense for each incorrectly indented comment' do
-      inspect_source(cop, ['# a',
-                           '  # b',
-                           '    # c',
-                           '# d',
-                           'def test; end'])
-      expect(cop.messages)
-        .to eq(['Incorrect indentation detected (column 0 instead of 2).',
-                'Incorrect indentation detected (column 2 instead of 4).',
-                'Incorrect indentation detected (column 4 instead of 0).'])
-    end
-  end
-
-  context 'around program structure keywords' do
-    it 'accepts correctly indented comments' do
-      inspect_source(cop, ['#',
-                           'def m',
-                           '  #',
-                           '  if a',
-                           '    #',
-                           '    b',
-                           '  # this is accepted',
-                           '  elsif aa',
-                           '    # this is accepted',
-                           '  else',
-                           '    #',
-                           '  end',
-                           '  #',
-                           '  case a',
-                           '  # this is accepted',
-                           '  when 0',
-                           '    #',
-                           '    b',
-                           '  end',
-                           '  # this is accepted',
-                           'rescue',
-                           '# this is accepted',
-                           'ensure',
-                           '  #',
-                           'end',
-                           '#'])
-      expect(cop.offenses).to eq([])
-    end
-
-    context 'with a blank line following the comment' do
-      it 'accepts a correctly indented comment' do
-        inspect_source(cop, ['def m',
-                             '  # comment',
-                             '',
-                             'end'])
-        expect(cop.offenses).to be_empty
-      end
-    end
-  end
-
-  context 'near various kinds of brackets' do
-    it 'accepts correctly indented comments' do
-      inspect_source(cop, ['#',
-                           'a = {',
-                           '  #',
-                           '  x: [',
-                           '    1',
-                           '    #',
-                           '  ],',
-                           '  #',
-                           '  y: func(',
-                           '          1',
-                           '          #',
-                           '          )',
-                           '  #',
-                           '}',
-                           '#'])
-      expect(cop.offenses).to eq([])
-    end
-
-    it 'is unaffected by closing bracket that does not begin a line' do
-      inspect_source(cop, ['#',
-                           'result = []'])
-      expect(cop.messages).to eq([])
-    end
-  end
-
-  it 'auto-corrects' do
-    new_source = autocorrect_source(cop, [' # comment',
-                                          'hash1 = { a: 0,',
-                                          '     # comment',
-                                          '          bb: 1,',
-                                          '          ccc: 2 }',
-                                          '  if a',
-                                          '  #',
-                                          '    b',
-                                          '  # this is accepted',
-                                          '  elsif aa',
-                                          '    # so is this',
-                                          '  elsif bb',
-                                          '#',
-                                          '  else',
-                                          '   #',
-                                          '  end',
-                                          '  case a',
-                                          '  # this is accepted',
-                                          '  when 0',
-                                          '    # so is this',
-                                          '  when 1',
-                                          '     #',
-                                          '    b',
-                                          '  end'])
-    expect(new_source).to eq(['# comment',
-                              'hash1 = { a: 0,',
-                              '          # comment',
-                              '          bb: 1,',
-                              '          ccc: 2 }',
-                              '  if a',
-                              '    #',
-                              '    b',
-                              '  # this is accepted',
-                              '  elsif aa',
-                              '    # so is this',
-                              '  elsif bb',
-                              '  #',
-                              '  else',
-                              '    #',
-                              '  end',
-                              '  case a',
-                              '  # this is accepted',
-                              '  when 0',
-                              '    # so is this',
-                              '  when 1',
-                              '    #',
-                              '    b',
-                              '  end'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/constant_name_spec.rb

@@ -1,65 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::ConstantName do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for camel case in const name' do
-    inspect_source(cop,
-                   'TopCase = 5')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers offenses for camel case in multiple const assignment' do
-    inspect_source(cop,
-                   'TopCase, Test2, TEST_3 = 5, 6, 7')
-    expect(cop.offenses.size).to eq(2)
-  end
-
-  it 'registers an offense for snake case in const name' do
-    inspect_source(cop,
-                   'TOP_test = 5')
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'allows screaming snake case in const name' do
-    inspect_source(cop,
-                   'TOP_TEST = 5')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows screaming snake case in multiple const assignment' do
-    inspect_source(cop,
-                   'TOP_TEST, TEST_2 = 5, 6')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not check names if rhs is a method call' do
-    inspect_source(cop,
-                   'AnythingGoes = test')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not check names if rhs is a method call with block' do
-    inspect_source(cop,
-                   ['AnythingGoes = test do',
-                    '  do_something',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not check if rhs is another constant' do
-    inspect_source(cop,
-                   'Parser::CurrentRuby = Parser::Ruby20')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'checks qualified const names' do
-    inspect_source(cop,
-                   ['::AnythingGoes = 30',
-                    'a::Bar_foo = 10'])
-    expect(cop.offenses.size).to eq(2)
-  end
-end

data/spec/rubocop/cop/style/def_with_parentheses_spec.rb

@@ -1,43 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::DefWithParentheses do
-  subject(:cop) { described_class.new }
-
-  it 'reports an offense for def with empty parens' do
-    src = ['def func()',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'reports an offense for class def with empty parens' do
-    src = ['def Test.func()',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts def with arg and parens' do
-    src = ['def func(a)',
-           'end']
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts empty parentheses in one liners' do
-    src = "def to_s() join '/' end"
-    inspect_source(cop, src)
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-removes unneeded parens' do
-    new_source = autocorrect_source(cop, ['def test();',
-                                          'something',
-                                          'end'])
-    expect(new_source).to eq(['def test;',
-                              'something',
-                              'end'].join("\n"))
-  end
-end

data/spec/rubocop/cop/style/deprecated_hash_methods_spec.rb

@@ -1,45 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::DeprecatedHashMethods do
-  subject(:cop) { described_class.new }
-
-  it 'registers an offense for has_key? with one arg' do
-    inspect_source(cop,
-                   'o.has_key?(o)')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['`Hash#has_key?` is deprecated in favor of `Hash#key?`.'])
-  end
-
-  it 'accepts has_key? with no args' do
-    inspect_source(cop,
-                   'o.has_key?')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for has_value? with one arg' do
-    inspect_source(cop,
-                   'o.has_value?(o)')
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.messages)
-      .to eq(['`Hash#has_value?` is deprecated in favor of `Hash#value?`.'])
-  end
-
-  it 'accepts has_value? with no args' do
-    inspect_source(cop,
-                   'o.has_value?')
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'auto-corrects has_key? with key?' do
-    new_source = autocorrect_source(cop, 'hash.has_key?(:test)')
-    expect(new_source).to eq('hash.key?(:test)')
-  end
-
-  it 'auto-corrects has_value? with value?' do
-    new_source = autocorrect_source(cop, 'hash.has_value?(value)')
-    expect(new_source).to eq('hash.value?(value)')
-  end
-end

data/spec/rubocop/cop/style/documentation_spec.rb

@@ -1,146 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Style::Documentation do
-  subject(:cop) { described_class.new(config) }
-  let(:config) do
-    RuboCop::Config.new('Style/CommentAnnotation' => {
-                          'Keywords' => %w(TODO FIXME OPTIMIZE HACK REVIEW)
-                        })
-  end
-
-  it 'registers an offense for non-empty class' do
-    inspect_source(cop,
-                   ['class My_Class',
-                    '  TEST = 20',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'does not consider comment followed by empty line to be class ' \
-     'documentation' do
-    inspect_source(cop,
-                   ['# Copyright 2014',
-                    '# Some company',
-                    '',
-                    'class My_Class',
-                    '  TEST = 20',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for non-namespace' do
-    inspect_source(cop,
-                   ['module My_Class',
-                    '  TEST = 20',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'registers an offense for empty module without documentation' do
-    # Because why would you have an empty module? It requires some
-    # explanation.
-    inspect_source(cop,
-                   ['module Test',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts non-empty class with documentation' do
-    inspect_source(cop,
-                   ['# class comment',
-                    'class My_Class',
-                    '  TEST = 20',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'registers an offense for non-empty class with annotation comment' do
-    inspect_source(cop,
-                   ['# OPTIMIZE: Make this faster.',
-                    'class My_Class',
-                    '  TEST = 20',
-                    'end'
-                   ])
-    expect(cop.offenses.size).to eq(1)
-  end
-
-  it 'accepts non-empty class with annotation comment followed by other ' \
-     'comment' do
-    inspect_source(cop,
-                   ['# OPTIMIZE: Make this faster.',
-                    '# Class comment.',
-                    'class My_Class',
-                    '  TEST = 20',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts non-empty class with comment that ends with an annotation' do
-    inspect_source(cop,
-                   ['# Does fooing.',
-                    '# FIXME: Not yet implemented.',
-                    'class Foo',
-                    '  def initialize',
-                    '  end',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts non-empty module with documentation' do
-    inspect_source(cop,
-                   ['# class comment',
-                    'module My_Class',
-                    '  TEST = 20',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts empty class without documentation' do
-    inspect_source(cop,
-                   ['class My_Class',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts namespace module without documentation' do
-    inspect_source(cop,
-                   ['module Test',
-                    '  class A; end',
-                    '  class B; end',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'accepts namespace class without documentation' do
-    inspect_source(cop,
-                   ['class Test',
-                    '  class A; end',
-                    '  class B; end',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'does not raise an error for an implicit match conditional' do
-    expect do
-      inspect_source(cop,
-                     ['class Test',
-                      '  if //',
-                      '  end',
-                      'end'
-                     ])
-    end.to_not raise_error
-  end
-end