rubocop 0.29.1 → 0.30.0

data/spec/rubocop/cop/lint/useless_comparison_spec.rb

@@ -1,30 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::UselessComparison do
-  subject(:cop) { described_class.new }
-
-  described_class::OPS.each do |op|
-    it "registers an offense for a simple comparison with #{op}" do
-      inspect_source(cop,
-                     ["5 #{op} 5",
-                      "a #{op} a"
-                     ])
-      expect(cop.offenses.size).to eq(2)
-    end
-
-    it "registers an offense for a complex comparison with #{op}" do
-      inspect_source(cop,
-                     ["5 + 10 * 30 #{op} 5 + 10 * 30",
-                      "a.top(x) #{op} a.top(x)"
-                     ])
-      expect(cop.offenses.size).to eq(2)
-    end
-  end
-
-  it 'works with lambda.()' do
-    inspect_source(cop, 'a.(x) > a.(x)')
-    expect(cop.offenses.size).to eq(1)
-  end
-end

data/spec/rubocop/cop/lint/useless_else_without_rescue_spec.rb

@@ -1,48 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::UselessElseWithoutRescue do
-  subject(:cop) { described_class.new }
-
-  before do
-    inspect_source(cop, source)
-  end
-
-  context 'with `else` without `rescue`' do
-    let(:source) do
-      [
-        'begin',
-        '  do_something',
-        'else',
-        '  handle_unknown_errors',
-        'end'
-      ]
-    end
-
-    it 'registers an offense' do
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.first.message)
-        .to eq('`else` without `rescue` is useless.')
-      expect(cop.highlights).to eq(['else'])
-    end
-  end
-
-  context 'with `else` with `rescue`' do
-    let(:source) do
-      [
-        'begin',
-        '  do_something',
-        'rescue ArgumentError',
-        '  handle_argument_error',
-        'else',
-        '  handle_unknown_errors',
-        'end'
-      ]
-    end
-
-    it 'accepts' do
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/lint/useless_setter_call_spec.rb

@@ -1,211 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::UselessSetterCall do
-  subject(:cop) { described_class.new }
-
-  context 'with method ending with setter call on local object' do
-    it 'registers an offense' do
-      inspect_source(cop,
-                     ['def test',
-                      '  top = Top.new',
-                      '  top.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Useless setter call to local variable `top`.'])
-    end
-  end
-
-  context 'with singleton method ending with setter call on local object' do
-    it 'registers an offense' do
-      inspect_source(cop,
-                     ['def Top.test',
-                      '  top = Top.new',
-                      '  top.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'with method ending with square bracket setter on local object' do
-    it 'registers an offense' do
-      inspect_source(cop,
-                     ['def test',
-                      '  top = Top.new',
-                      '  top[:attr] = 5',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.messages)
-        .to eq(['Useless setter call to local variable `top`.'])
-    end
-  end
-
-  context 'with method ending with ivar assignment' do
-    it 'accepts' do
-      inspect_source(cop,
-                     ['def test',
-                      '  something',
-                      '  @top = 5',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'with method ending with setter call on ivar' do
-    it 'accepts' do
-      inspect_source(cop,
-                     ['def test',
-                      '  something',
-                      '  @top.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'with method ending with setter call on argument' do
-    it 'accepts' do
-      inspect_source(cop,
-                     ['def test(some_arg)',
-                      '  unrelated_local_variable = Top.new',
-                      '  some_arg.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when a lvar contains an object passed as argument ' \
-          'at the end of the method' do
-    it 'accepts the setter call on the lvar' do
-      inspect_source(cop,
-                     ['def test(some_arg)',
-                      '  @some_ivar = some_arg',
-                      '  @some_ivar.do_something',
-                      '  some_lvar = @some_ivar',
-                      '  some_lvar.do_something',
-                      '  some_lvar.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when a lvar contains an object passed as argument ' \
-          'by multiple-assignment at the end of the method' do
-    it 'accepts the setter call on the lvar' do
-      inspect_source(cop,
-                     ['def test(some_arg)',
-                      '  _first, some_lvar, _third  = 1, some_arg, 3',
-                      '  some_lvar.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when a lvar does not contain any object passed as argument ' \
-          'with multiple-assignment at the end of the method' do
-    it 'registers an offense' do
-      inspect_source(cop,
-                     ['def test(some_arg)',
-                      '  _first, some_lvar, _third  = do_something',
-                      '  some_lvar.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'when a lvar possibly contains an object passed as argument ' \
-          'by logical-operator-assignment at the end of the method' do
-    it 'accepts the setter call on the lvar' do
-      inspect_source(cop,
-                     ['def test(some_arg)',
-                      '  some_lvar = nil',
-                      '  some_lvar ||= some_arg',
-                      '  some_lvar.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when a lvar does not contain any object passed as argument ' \
-          'by binary-operator-assignment at the end of the method' do
-    it 'registers an offense' do
-      inspect_source(cop,
-                     ['def test(some_arg)',
-                      '  some_lvar = some_arg',
-                      '  some_lvar += some_arg',
-                      '  some_lvar.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'when a lvar declared as an argument ' \
-          'is no longer the passed object at the end of the method' do
-    it 'registers an offense for the setter call on the lvar' do
-      inspect_source(cop,
-                     ['def test(some_arg)',
-                      '  some_arg = Top.new',
-                      '  some_arg.attr = 5',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'when a lvar contains a local object instantiated with literal' do
-    it 'registers an offense for the setter call on the lvar' do
-      inspect_source(cop,
-                     ['def test',
-                      '  some_arg = {}',
-                      '  some_arg[:attr] = 1',
-                      'end'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  context 'when a lvar contains a non-local object returned by a method' do
-    it 'accepts' do
-      inspect_source(cop,
-                     ['def test',
-                      '  some_lvar = Foo.shared_object',
-                      '  some_lvar[:attr] = 1',
-                      'end'
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  it 'is not confused by operators ending with =' do
-    inspect_source(cop,
-                   ['def test',
-                    '  top.attr == 5',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'handles exception assignments without exploding' do
-    inspect_source(cop,
-                   ['def foo(bar)',
-                    '  begin',
-                    '  rescue StandardError => _',
-                    '  end',
-                    '  bar[:baz] = true',
-                    'end'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/lint/void_spec.rb

@@ -1,64 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Lint::Void do
-  subject(:cop) { described_class.new }
-
-  described_class::OPS.each do |op|
-    it "registers an offense for void op #{op} if not on last line" do
-      inspect_source(cop,
-                     ["a #{op} b",
-                      "a #{op} b",
-                      "a #{op} b"
-                     ])
-      expect(cop.offenses.size).to eq(2)
-    end
-  end
-
-  described_class::OPS.each do |op|
-    it "accepts void op #{op} if on last line" do
-      inspect_source(cop,
-                     ['something',
-                      "a #{op} b"
-                     ])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  described_class::OPS.each do |op|
-    it "accepts void op #{op} by itself without a begin block" do
-      inspect_source(cop, "a #{op} b")
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  %w(var @var @@var VAR).each do |var|
-    it "registers an offense for void var #{var} if not on last line" do
-      inspect_source(cop,
-                     ["#{var} = 5",
-                      "#{var}",
-                      'top'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  %w(1 2.0 /test/ [1] {}).each do |lit|
-    it "registers an offense for void lit #{lit} if not on last line" do
-      inspect_source(cop,
-                     ["#{lit}",
-                      'top'
-                     ])
-      expect(cop.offenses.size).to eq(1)
-    end
-  end
-
-  it 'accepts short call syntax' do
-    inspect_source(cop,
-                   ['lambda.(a)',
-                    'top'
-                   ])
-    expect(cop.offenses).to be_empty
-  end
-end

data/spec/rubocop/cop/metrics/abc_size_spec.rb

@@ -1,109 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe RuboCop::Cop::Metrics::AbcSize, :config do
-  subject(:cop) { described_class.new(config) }
-
-  context 'when Max is 0' do
-    let(:cop_config) { { 'Max' => 0 } }
-
-    it 'accepts an empty method' do
-      inspect_source(cop, ['def method_name',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'registers an offense for an if modifier' do
-      inspect_source(cop, ['def method_name',
-                           '  call_foo if some_condition', # 0 + 2*2 + 1*1
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Assignment Branch Condition size for method_name is too ' \
-                'high. [2.24/0]'])
-      expect(cop.highlights).to eq(['def'])
-      expect(cop.config_to_allow_offenses).to eq('Max' => 3)
-    end
-
-    it 'registers an offense for an assignment of a local variable' do
-      inspect_source(cop, ['def method_name',
-                           '  x = 1',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Assignment Branch Condition size for method_name is too ' \
-                'high. [1/0]'])
-      expect(cop.config_to_allow_offenses).to eq('Max' => 1)
-    end
-
-    it 'registers an offense for an assignment of an element' do
-      inspect_source(cop, ['def method_name',
-                           '  x[0] = 1',
-                           'end'])
-      expect(cop.messages)
-        .to eq(['Assignment Branch Condition size for method_name is too ' \
-                'high. [2/0]'])
-      expect(cop.config_to_allow_offenses).to eq('Max' => 2)
-    end
-
-    it 'registers an offense for complex content including A, B, and C ' \
-       'scores' do
-      inspect_source(cop,
-                     ['def method_name',
-                      '  my_options = Hash.new if 1 == 1 || 2 == 2', # 1, 3, 2
-                      '  my_options.each do |key, value|',           # 0, 1, 0
-                      '    p key',                                   # 0, 1, 0
-                      '    p value',                                 # 0, 1, 0
-                      '  end',
-                      'end'])
-      expect(cop.messages)
-        .to eq(['Assignment Branch Condition size for method_name is too ' \
-                'high. [6.4/0]']) # square root of 1*1 + 5*5 + 2*2 => 6.4
-    end
-  end
-
-  context 'when Max is 2' do
-    let(:cop_config) { { 'Max' => 2 } }
-
-    it 'accepts two assignments' do
-      inspect_source(cop, ['def method_name',
-                           '  x = 1',
-                           '  y = 2',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  context 'when Max is 1.8' do
-    let(:cop_config) { { 'Max' => 1.8 } }
-
-    it 'accepts a total score of 1.7' do
-      inspect_source(cop, ['def method_name',
-                           '  y = 1 if y == 1',
-                           'end'])
-      expect(cop.offenses).to be_empty
-    end
-  end
-
-  {
-    1.3     => '3.74/1.3',    # no more than 2 decimals reported
-    10.3    => '37.42/10.3',
-    100.321 => '374.2/100.3', # 4 significant digits, so only 1 decimal here
-    1000.3  => '3742/1000'
-  }.each do |max, presentation|
-    context "when Max is #{max}" do
-      let(:cop_config) { { 'Max' => max } }
-
-      it "reports size and max as #{presentation}" do
-        # Build an amount of code large enough to register an offense.
-        code = ['  x = Hash.new if 1 == 1 || 2 == 2'] * max
-
-        inspect_source(cop, ['def method_name',
-                             *code,
-                             'end'])
-        expect(cop.messages)
-          .to eq(['Assignment Branch Condition size for method_name is too ' \
-                  "high. [#{presentation}]"])
-      end
-    end
-  end
-end