chrome-devtools-frontend 1.0.1376716 → 1.0.1386602

package/front_end/models/trace/handlers/ImagePaintingHandler.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as Platform from '../../../core/platform/platform.js';
 import * as Types from '../types/types.js';
 
 /**
@@ -37,11 +38,14 @@ const paintImageByLazyPixelRef: Map<number, Types.Events.PaintImage> = new Map()
 // have a relationship to a individual PaintImage event.
 const eventToPaintImage: Map<Types.Events.Event, Types.Events.PaintImage> = new Map();
 
+const urlToPaintImage: Map<string, Types.Events.PaintImage[]> = new Map();
+
 export function reset(): void {
   paintImageEvents.clear();
   decodeLazyPixelRefEvents.clear();
   paintImageByLazyPixelRef.clear();
   eventToPaintImage.clear();
+  urlToPaintImage.clear();
 }
 
 export function handleEvent(event: Types.Events.Event): void {
@@ -51,6 +55,12 @@ export function handleEvent(event: Types.Events.Event): void {
     forThread.push(event);
     forProcess.set(event.tid, forThread);
     paintImageEvents.set(event.pid, forProcess);
+
+    if (event.args.data.url) {
+      const paintsForUrl = Platform.MapUtilities.getWithDefault(urlToPaintImage, event.args.data.url, () => []);
+      paintsForUrl.push(event);
+    }
+
     return;
   }
 
@@ -112,14 +122,19 @@ export function handleEvent(event: Types.Events.Event): void {
   }
 }
 
+export async function finalize(): Promise<void> {
+}
+
 export interface ImagePaintData {
   paintImageByDrawLazyPixelRef: Map<number, Types.Events.PaintImage>;
   paintImageForEvent: Map<Types.Events.Event, Types.Events.PaintImage>;
+  paintImageEventForUrl: Map<string, Types.Events.PaintImage[]>;
 }
 
 export function data(): ImagePaintData {
   return {
     paintImageByDrawLazyPixelRef: paintImageByLazyPixelRef,
     paintImageForEvent: eventToPaintImage,
+    paintImageEventForUrl: urlToPaintImage,
   };
 }

package/front_end/models/trace/handlers/InitiatorsHandler.test.ts

@@ -8,7 +8,6 @@ import * as Trace from '../trace.js';
 describe('InitiatorsHandler', () => {
   beforeEach(() => {
     Trace.Handlers.ModelHandlers.Initiators.reset();
-    Trace.Handlers.ModelHandlers.Initiators.initialize();
   });
 
   it('for an UpdateLayoutTree event it sets the initiator to the previous ScheduledStyleRecalculation event',

package/front_end/models/trace/handlers/InitiatorsHandler.ts

@@ -5,10 +5,6 @@
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
-import {HandlerState} from './types.js';
-
-let handlerState = HandlerState.UNINITIALIZED;
-
 const lastScheduleStyleRecalcByFrame = new Map<string, Types.Events.ScheduleStyleRecalculation>();
 
 // This tracks the last event that is considered to have invalidated the layout
@@ -54,16 +50,6 @@ export function reset(): void {
   schedulePostTaskCallbackEventsById.clear();
   schedulePostMessageEventByTraceId.clear();
   postMessageHandlerEvents.length = 0;
-
-  handlerState = HandlerState.UNINITIALIZED;
-}
-
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('InitiatorsHandler was not reset before being initialized');
-  }
-
-  handlerState = HandlerState.INITIALIZED;
 }
 
 function storeInitiator(data: {initiator: Types.Events.Event, event: Types.Events.Event}): void {
@@ -202,16 +188,10 @@ function finalizeInitiatorRelationship(): void {
 }
 
 export async function finalize(): Promise<void> {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('InitiatorsHandler is not initialized');
-  }
-
   // During event processing, we may encounter initiators before the handler events themselves
   // (e.g dispatch events on worker and handler events on the main thread)
   // we don't want to miss out on events whose initiators haven't been processed yet
   finalizeInitiatorRelationship();
-
-  handlerState = HandlerState.FINALIZED;
 }
 
 export interface InitiatorsData {

package/front_end/models/trace/handlers/InvalidationsHandler.test.ts

@@ -23,7 +23,6 @@ function invalidationDataForTestAssertion(invalidation: Trace.Types.Events.Inval
 describe('InvalidationsHandler', () => {
   beforeEach(() => {
     Trace.Handlers.ModelHandlers.Invalidations.reset();
-    Trace.Handlers.ModelHandlers.Invalidations.initialize();
   });
 
   it('finds the right invalidators for a layout where attributes have been changed', async function() {

package/front_end/models/trace/handlers/InvalidationsHandler.ts

@@ -4,10 +4,6 @@
 
 import * as Types from '../types/types.js';
 
-import {HandlerState} from './types.js';
-
-let handlerState = HandlerState.UNINITIALIZED;
-
 const invalidationsForEvent = new Map<Types.Events.Event, Types.Events.InvalidationTrackingEvent[]>();
 const invalidationCountForEvent = new Map<Types.Events.Event, number>();
 
@@ -19,7 +15,6 @@ let hasPainted = false;
 const allInvalidationTrackingEvents: Array<Types.Events.InvalidationTrackingEvent> = [];
 
 export function reset(): void {
-  handlerState = HandlerState.UNINITIALIZED;
   invalidationsForEvent.clear();
   lastRecalcStyleEvent = null;
   allInvalidationTrackingEvents.length = 0;
@@ -32,14 +27,6 @@ export function handleUserConfig(userConfig: Types.Configuration.Configuration):
   maxInvalidationsPerEvent = userConfig.maxInvalidationEventsPerEvent;
 }
 
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('InvalidationsHandler was not reset before being initialized');
-  }
-
-  handlerState = HandlerState.INITIALIZED;
-}
-
 function addInvalidationToEvent(event: Types.Events.Event, invalidation: Types.Events.InvalidationTrackingEvent): void {
   const existingInvalidations = invalidationsForEvent.get(event) || [];
   existingInvalidations.push(invalidation);
@@ -132,11 +119,6 @@ export function handleEvent(event: Types.Events.Event): void {
 }
 
 export async function finalize(): Promise<void> {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('InvalidationsHandler is not initialized');
-  }
-
-  handlerState = HandlerState.FINALIZED;
 }
 
 interface InvalidationsData {

package/front_end/models/trace/handlers/LargestImagePaintHandler.test.ts

@@ -18,8 +18,8 @@ describe('LargestImagePaintHandler', function() {
     }
 
     const data = Trace.Handlers.ModelHandlers.LargestImagePaint.data();
-    assert.strictEqual(data.size, 1);
-    const imageForLCP = data.get(10 as Protocol.DOM.BackendNodeId);
+    assert.strictEqual(data.imageByDOMNodeId.size, 1);
+    const imageForLCP = data.imageByDOMNodeId.get(10 as Protocol.DOM.BackendNodeId);
     assert.exists(imageForLCP);
     assert.strictEqual(imageForLCP?.args.data?.DOMNodeId, 10 as Protocol.DOM.BackendNodeId);
     assert.strictEqual(imageForLCP?.args.data?.imageUrl, 'https://via.placeholder.com/2000.jpg');

package/front_end/models/trace/handlers/LargestImagePaintHandler.ts

@@ -2,8 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Types from '../types/types.js';
 import type * as Protocol from '../../../generated/protocol.js';
+import * as Types from '../types/types.js';
+
+import {data as metaData} from './MetaHandler.js';
+import {data as networkRequestsData} from './NetworkRequestsHandler.js';
+import type {HandlerName} from './types.js';
+
 /**
  * If the LCP resource was an image, and that image was fetched over the
  * network, we want to be able to find the network request in order to construct
@@ -22,12 +27,23 @@ import type * as Protocol from '../../../generated/protocol.js';
  * to the image.
  **/
 const imageByDOMNodeId = new Map<Protocol.DOM.BackendNodeId, Types.Events.LargestImagePaintCandidate>();
+const lcpRequestByNavigation = new Map<Types.Events.NavigationStart|null, Types.Events.SyntheticNetworkRequest>();
+const lcpPaintEventByNavigation = new Map<Types.Events.NavigationStart|null, Types.Events.LargestImagePaintCandidate>();
+let currentNavigation: Types.Events.NavigationStart|null;
 
 export function reset(): void {
   imageByDOMNodeId.clear();
+  lcpRequestByNavigation.clear();
+  lcpPaintEventByNavigation.clear();
+  currentNavigation = null;
 }
 
 export function handleEvent(event: Types.Events.Event): void {
+  if (Types.Events.isNavigationStart(event)) {
+    currentNavigation = event;
+    return;
+  }
+
   if (!Types.Events.isLargestImagePaintCandidate(event)) {
     return;
   }
@@ -37,8 +53,52 @@ export function handleEvent(event: Types.Events.Event): void {
   }
 
   imageByDOMNodeId.set(event.args.data.DOMNodeId, event);
+  lcpPaintEventByNavigation.set(currentNavigation, event);
+}
+
+export async function finalize(): Promise<void> {
+  const requests = networkRequestsData().byTime;
+  const traceBounds = metaData().traceBounds;
+
+  for (const [navigation, event] of lcpPaintEventByNavigation) {
+    const lcpUrl = event.args.data?.imageUrl;
+    if (!lcpUrl) {
+      continue;
+    }
+
+    const startTime = navigation?.ts ?? traceBounds.min;
+    const endTime = event.ts;
+
+    let lcpRequest;
+    for (const request of requests) {
+      if (request.ts < startTime) {
+        continue;
+      }
+      if (request.ts >= endTime) {
+        break;
+      }
+
+      if (request.args.data.url === lcpUrl || request.args.data.redirects.some(r => r.url === lcpUrl)) {
+        lcpRequest = request;
+        break;
+      }
+    }
+
+    if (lcpRequest) {
+      lcpRequestByNavigation.set(navigation, lcpRequest);
+    }
+  }
+}
+
+export interface LargestImagePaintData {
+  imageByDOMNodeId: Map<Protocol.DOM.BackendNodeId, Types.Events.LargestImagePaintCandidate>;
+  lcpRequestByNavigation: Map<Types.Events.NavigationStart|null, Types.Events.SyntheticNetworkRequest>;
+}
+
+export function data(): LargestImagePaintData {
+  return {imageByDOMNodeId, lcpRequestByNavigation};
 }
 
-export function data(): Map<Protocol.DOM.BackendNodeId, Types.Events.LargestImagePaintCandidate> {
-  return imageByDOMNodeId;
+export function deps(): HandlerName[] {
+  return ['Meta', 'NetworkRequests'];
 }

package/front_end/models/trace/handlers/LargestTextPaintHandler.ts

@@ -27,6 +27,9 @@ export function handleEvent(event: Types.Events.Event): void {
   textPaintByDOMNodeId.set(event.args.data.DOMNodeId, event);
 }
 
+export async function finalize(): Promise<void> {
+}
+
 export function data(): Map<Protocol.DOM.BackendNodeId, Types.Events.LargestTextPaintCandidate> {
   return textPaintByDOMNodeId;
 }

package/front_end/models/trace/handlers/LayerTreeHandler.test.ts

@@ -15,8 +15,6 @@ describe('LayerTreeHandler', function() {
   beforeEach(() => {
     Trace.Handlers.ModelHandlers.Meta.reset();
     Trace.Handlers.ModelHandlers.LayerTree.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
-    Trace.Handlers.ModelHandlers.LayerTree.initialize();
   });
 
   it('creates a relationship between paint events and the snapshot event', async function() {

package/front_end/models/trace/handlers/LayerTreeHandler.ts

@@ -6,9 +6,7 @@ import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
 import {data as metaHandlerData} from './MetaHandler.js';
-import {type HandlerName, HandlerState} from './types.js';
-
-let handlerState = HandlerState.UNINITIALIZED;
+import type {HandlerName} from './types.js';
 
 const paintEvents: Types.Events.Paint[] = [];
 const snapshotEvents: Types.Events.DisplayItemListSnapshot[] = [];
@@ -24,7 +22,6 @@ type RelevantLayerTreeEvent =
 
 const relevantEvents: RelevantLayerTreeEvent[] = [];
 export function reset(): void {
-  handlerState = HandlerState.UNINITIALIZED;
   paintEvents.length = 0;
   snapshotEvents.length = 0;
   paintToSnapshotMap.clear();
@@ -35,14 +32,6 @@ export function reset(): void {
   relevantEvents.length = 0;
 }
 
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('LayerTree Handler was not reset before being initialized');
-  }
-
-  handlerState = HandlerState.INITIALIZED;
-}
-
 export function handleEvent(event: Types.Events.Event): void {
   // We gather up the events here but do all the processing in finalize(). This
   // is because we need to have all the events before we process them, and we
@@ -55,10 +44,6 @@ export function handleEvent(event: Types.Events.Event): void {
 }
 
 export async function finalize(): Promise<void> {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('LayerTree Handler is not initialized');
-  }
-
   const metaData = metaHandlerData();
   Helpers.Trace.sortTraceEventsInPlace(relevantEvents);
 
@@ -117,8 +102,6 @@ export async function finalize(): Promise<void> {
       paintToSnapshotMap.set(paintEvent, event);
     }
   }
-
-  handlerState = HandlerState.FINALIZED;
 }
 
 export interface LayerTreeData {

package/front_end/models/trace/handlers/LayoutShiftsHandler.test.ts

@@ -7,10 +7,8 @@ import * as Trace from '../trace.js';
 
 async function processTrace(context: Mocha.Suite|Mocha.Context|null, url: string): Promise<void> {
   Trace.Handlers.ModelHandlers.Meta.reset();
-  Trace.Handlers.ModelHandlers.Meta.initialize();
 
   Trace.Handlers.ModelHandlers.LayoutShifts.reset();
-  Trace.Handlers.ModelHandlers.LayoutShifts.initialize();
 
   try {
     const events = await TraceLoader.rawEvents(context, url);
@@ -33,7 +31,6 @@ describe('LayoutShiftsHandler', function() {
     // run the meta handler here, too, so that later on we can get the IDs of
     // the main renderer process and thread.
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
 
     Trace.Handlers.ModelHandlers.LayoutShifts.reset();
   });

package/front_end/models/trace/handlers/LayoutShiftsHandler.ts

@@ -10,7 +10,7 @@ import * as Types from '../types/types.js';
 import {data as metaHandlerData} from './MetaHandler.js';
 import {ScoreClassification} from './PageLoadMetricsHandler.js';
 import {data as screenshotsHandlerData} from './ScreenshotsHandler.js';
-import {type HandlerName, HandlerState} from './types.js';
+import type {HandlerName} from './types.js';
 
 // We start with a score of zero and step through all Layout Shift records from
 // all renderers. Each record not only tells us which renderer it is, but also
@@ -114,17 +114,7 @@ type ScoreRecord = {
 // Includes drops to 0 when session windows end.
 const scoreRecords: ScoreRecord[] = [];
 
-let handlerState = HandlerState.UNINITIALIZED;
-
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('LayoutShifts Handler was not reset');
-  }
-  handlerState = HandlerState.INITIALIZED;
-}
-
 export function reset(): void {
-  handlerState = HandlerState.UNINITIALIZED;
   layoutShiftEvents.length = 0;
   layoutInvalidationEvents.length = 0;
   scheduleStyleInvalidationEvents.length = 0;
@@ -144,10 +134,6 @@ export function reset(): void {
 }
 
 export function handleEvent(event: Types.Events.Event): void {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Handler is not initialized');
-  }
-
   if (Types.Events.isLayoutShift(event) && !event.args.data?.had_recent_input) {
     layoutShiftEvents.push(event);
     return;
@@ -273,7 +259,6 @@ export async function finalize(): Promise<void> {
   await buildLayoutShiftsClusters();
   buildScoreRecords();
   collectNodes();
-  handlerState = HandlerState.FINALIZED;
 }
 
 async function buildLayoutShiftsClusters(): Promise<void> {
@@ -509,10 +494,6 @@ async function buildLayoutShiftsClusters(): Promise<void> {
 }
 
 export function data(): LayoutShifts {
-  if (handlerState !== HandlerState.FINALIZED) {
-    throw new Error('Layout Shifts Handler is not finalized');
-  }
-
   return {
     clusters,
     sessionMaxScore,

package/front_end/models/trace/handlers/MemoryHandler.test.ts

@@ -13,7 +13,6 @@ describe('MemoryHandler', function() {
 
   it('gathers update counters', async function() {
     const events = await TraceLoader.rawEvents(this, 'web-dev.json.gz');
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of events) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       Trace.Handlers.ModelHandlers.Memory.handleEvent(event);

package/front_end/models/trace/handlers/MemoryHandler.ts

@@ -23,6 +23,9 @@ export function handleEvent(event: Types.Events.Event): void {
   }
 }
 
+export async function finalize(): Promise<void> {
+}
+
 export function data(): MemoryData {
   return {updateCountersByProcess};
 }

package/front_end/models/trace/handlers/MetaHandler.test.ts

@@ -50,7 +50,7 @@ describe('MetaHandler', function() {
         tid: Trace.Types.Events.ThreadID(775),
         ts: Trace.Types.Timing.MicroSeconds(800),
         name: 'navigationStart',
-      } as Trace.Types.Events.NavigationStart,
+      } as Trace.Types.Events.NavigationStartUnreliable,
       {
         ...defaultTraceEvent,
         args: {
@@ -69,27 +69,6 @@ describe('MetaHandler', function() {
     ];
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
-  });
-
-  describe('error handling', function() {
-    it('throws if data is called before finalize', function() {
-      for (const event of baseEvents) {
-        Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
-      }
-
-      assert.throws(() => {
-        Trace.Handlers.ModelHandlers.Meta.data();
-      }, 'Handler is not finalized');
-    });
-
-    it('throws if initialize is called without a reset', function() {
-      // Due to the beforeEach the handler is already initialized, so calling
-      // it a second time should throw an error.
-      assert.throws(() => {
-        Trace.Handlers.ModelHandlers.Meta.initialize();
-      }, 'Handler was not reset');
-    });
   });
 
   describe('browser process ID', function() {
@@ -154,7 +133,6 @@ describe('MetaHandler', function() {
     it('provides a list of main frame only navigations', async function() {
       const events = await TraceLoader.rawEvents(this, 'multiple-navigations-with-iframes.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -183,7 +161,6 @@ describe('MetaHandler', function() {
     it('finds the main frame ID for a trace that started with a page reload', async function() {
       const events = await TraceLoader.rawEvents(this, 'reload-and-trace-page.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -195,7 +172,6 @@ describe('MetaHandler', function() {
     it('tracks the frames for found processes', async function() {
       const events = await TraceLoader.rawEvents(this, 'reload-and-trace-page.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -215,7 +191,6 @@ describe('MetaHandler', function() {
     it('finds the GPU process and GPU Thread', async function() {
       const events = await TraceLoader.rawEvents(this, 'threejs-gpu.json.gz');
       Trace.Handlers.ModelHandlers.Meta.reset();
-      Trace.Handlers.ModelHandlers.Meta.initialize();
       for (const event of events) {
         Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
       }
@@ -250,7 +225,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -288,7 +262,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -345,7 +318,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -403,7 +375,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -433,7 +404,6 @@ describe('MetaHandler', function() {
     });
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }
@@ -455,7 +425,6 @@ describe('MetaHandler', function() {
     }
 
     Trace.Handlers.ModelHandlers.Meta.reset();
-    Trace.Handlers.ModelHandlers.Meta.initialize();
     for (const event of traceEvents) {
       Trace.Handlers.ModelHandlers.Meta.handleEvent(event);
     }

package/front_end/models/trace/handlers/MetaHandler.ts

@@ -6,8 +6,6 @@ import * as Platform from '../../../core/platform/platform.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
-import {HandlerState} from './types.js';
-
 // We track the renderer processes we see in each frame on the way through the trace.
 const rendererProcessesByFrameId: FrameProcessData = new Map();
 
@@ -67,7 +65,6 @@ const eventPhasesOfInterestForTraceBounds = new Set([
   Types.Events.Phase.INSTANT,
 ]);
 
-let handlerState = HandlerState.UNINITIALIZED;
 // Tracks if the trace is a generic trace, which here means that it did not come from athe DevTools Performance Panel recording.
 // We assume a trace is generic, and mark it as not generic if we see any of:
 // - TracingStartedInPage
@@ -104,16 +101,6 @@ export function reset(): void {
   traceStartedTimeFromTracingStartedEvent = Types.Timing.MicroSeconds(-1);
 
   traceIsGeneric = true;
-
-  handlerState = HandlerState.UNINITIALIZED;
-}
-
-export function initialize(): void {
-  if (handlerState !== HandlerState.UNINITIALIZED) {
-    throw new Error('Meta Handler was not reset');
-  }
-
-  handlerState = HandlerState.INITIALIZED;
 }
 
 function updateRendererProcessByFrame(event: Types.Events.Event, frame: Types.Events.TraceFrame): void {
@@ -147,10 +134,6 @@ function updateRendererProcessByFrame(event: Types.Events.Event, frame: Types.Ev
 }
 
 export function handleEvent(event: Types.Events.Event): void {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Meta Handler is not initialized');
-  }
-
   if (traceIsGeneric && CHROME_WEB_TRACE_EVENTS.has(event.name as Types.Events.Name)) {
     traceIsGeneric = false;
   }
@@ -311,9 +294,8 @@ export function handleEvent(event: Types.Events.Event): void {
   // Track all navigation events. Note that there can be navigation start events
   // but where the documentLoaderURL is empty. As far as the trace rendering is
   // concerned, these events are noise so we filter them out here.
-  // (The filtering of empty URLs is done in the
-  // isNavigationStartWithURL check)
-  if (Types.Events.isNavigationStartWithURL(event) && event.args.data) {
+  // (The filtering of empty URLs is done in the isNavigationStart check)
+  if (Types.Events.isNavigationStart(event) && event.args.data) {
     const navigationId = event.args.data.navigationId;
     if (navigationsByNavigationId.has(navigationId)) {
       // We have only ever seen this situation once, in crbug.com/1503982, where the user ran:
@@ -336,10 +318,6 @@ export function handleEvent(event: Types.Events.Event): void {
 }
 
 export async function finalize(): Promise<void> {
-  if (handlerState !== HandlerState.INITIALIZED) {
-    throw new Error('Handler is not initialized');
-  }
-
   // We try to set the minimum time by finding the event with the smallest
   // timestamp. However, if we also got a timestamp from the
   // TracingStartedInBrowser event, we should always use that.
@@ -412,8 +390,6 @@ export async function finalize(): Promise<void> {
       mainFrameURL = firstMainFrameNav.args.data.documentLoaderURL;
     }
   }
-
-  handlerState = HandlerState.FINALIZED;
 }
 
 export type MetaHandlerData = {
@@ -464,10 +440,6 @@ export type FrameProcessData =
         Map<Types.Events.ProcessID, {frame: Types.Events.TraceFrame, window: Types.Timing.TraceWindowMicroSeconds}[]>>;
 
 export function data(): MetaHandlerData {
-  if (handlerState !== HandlerState.FINALIZED) {
-    throw new Error('Meta Handler is not finalized');
-  }
-
   return {
     traceBounds: {...traceBounds},
     browserProcessId,