chrome-devtools-frontend 1.0.1376716 → 1.0.1386602

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -479,7 +479,6 @@ export const enum EnumeratedHistogram {
   SourcesPanelFileOpened = 'DevTools.SourcesPanelFileOpened',
   NetworkPanelResponsePreviewOpened = 'DevTools.NetworkPanelResponsePreviewOpened',
   StyleTextCopied = 'DevTools.StyleTextCopied',
-  ManifestSectionSelected = 'DevTools.ManifestSectionSelected',
   CSSHintShown = 'DevTools.CSSHintShown',
   LighthouseModeRun = 'DevTools.LighthouseModeRun',
   LighthouseCategoryUsed = 'DevTools.LighthouseCategoryUsed',

package/front_end/core/host/UserMetrics.ts

@@ -290,13 +290,6 @@ export class UserMetrics {
         EnumeratedHistogram.StyleTextCopied, value, StyleTextCopied.MAX_VALUE);
   }
 
-  manifestSectionSelected(sectionTitle: string): void {
-    const code =
-        ManifestSectionCodes[sectionTitle as keyof typeof ManifestSectionCodes] || ManifestSectionCodes.OtherSection;
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.ManifestSectionSelected, code, ManifestSectionCodes.MAX_VALUE);
-  }
-
   cssHintShown(type: CSSHintType): void {
     InspectorFrontendHostInstance.recordEnumeratedHistogram(
         EnumeratedHistogram.CSSHintShown, type, CSSHintType.MAX_VALUE);
@@ -1024,7 +1017,6 @@ export enum DevtoolsExperiments {
   'timeline-rpp-sidebar' = 95,
   'timeline-observations' = 96,
   'timeline-server-timings' = 98,
-  'extension-storage-viewer' = 100,
   'floating-entry-points-for-ai-assistance' = 101,
   'timeline-experimental-insights' = 102,
   'timeline-dim-unrelated-events' = 103,

package/front_end/core/i18n/ByteUtilities.test.ts

@@ -0,0 +1,34 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {describeWithLocale} from '../../testing/EnvironmentHelpers.js';
+
+import * as i18n from './i18n.js';
+
+describeWithLocale('ByteUtilities', () => {
+  describe('bytesToString', () => {
+    it('formats for < 1000 bytes', () => {
+      assert.deepEqual(i18n.ByteUtilities.bytesToString(50), '50\xA0B');
+    });
+
+    it('formats for < 100 kilobytes', () => {
+      assert.deepEqual(i18n.ByteUtilities.bytesToString(5 * 1000), '5.0\xA0kB');
+    });
+
+    it('formats for < 1000 kilobytes', () => {
+      assert.deepEqual(i18n.ByteUtilities.bytesToString(500 * 1000), '500\xA0kB');
+    });
+
+    it('formats for < 100 megabytes', () => {
+      const oneAndAHalfMegabytes = 1500 * 1000;
+      assert.deepEqual(i18n.ByteUtilities.bytesToString(oneAndAHalfMegabytes), '1.5\xA0MB');
+    });
+
+    it('formats for > 100 megabytes', () => {
+      const oneMegabyte = 1000 * 1000;
+      const twoHundredAndTenMegabytes = oneMegabyte * 210;
+      assert.deepEqual(i18n.ByteUtilities.bytesToString(twoHundredAndTenMegabytes), '210\xA0MB');
+    });
+  });
+});

package/front_end/core/i18n/ByteUtilities.ts

@@ -0,0 +1,65 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {defineFormatter} from './NumberFormatter.js';
+
+const narrowBytes = defineFormatter({
+  style: 'unit',
+  unit: 'byte',
+  unitDisplay: 'narrow',
+  minimumFractionDigits: 0,
+  maximumFractionDigits: 0,
+});
+
+const narrowKilobytesDecimal = defineFormatter({
+  style: 'unit',
+  unit: 'kilobyte',
+  unitDisplay: 'narrow',
+  minimumFractionDigits: 1,
+  maximumFractionDigits: 1,
+});
+
+const narrowKilobytesInteger = defineFormatter({
+  style: 'unit',
+  unit: 'kilobyte',
+  unitDisplay: 'narrow',
+  minimumFractionDigits: 0,
+  maximumFractionDigits: 0,
+});
+
+const narrowMegabytesDecimal = defineFormatter({
+  style: 'unit',
+  unit: 'megabyte',
+  unitDisplay: 'narrow',
+  minimumFractionDigits: 1,
+  maximumFractionDigits: 1,
+});
+
+const narrowMegabytesInteger = defineFormatter({
+  style: 'unit',
+  unit: 'megabyte',
+  unitDisplay: 'narrow',
+  minimumFractionDigits: 0,
+  maximumFractionDigits: 0,
+});
+
+export const bytesToString = (bytes: number): string => {
+  if (bytes < 1000) {
+    return narrowBytes.format(bytes);
+  }
+
+  const kilobytes = bytes / 1000;
+  if (kilobytes < 100) {
+    return narrowKilobytesDecimal.format(kilobytes);
+  }
+  if (kilobytes < 1000) {
+    return narrowKilobytesInteger.format(kilobytes);
+  }
+
+  const megabytes = kilobytes / 1000;
+  if (megabytes < 100) {
+    return narrowMegabytesDecimal.format(megabytes);
+  }
+  return narrowMegabytesInteger.format(megabytes);
+};

package/front_end/core/i18n/NumberFormatter.ts

@@ -0,0 +1,75 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {DevToolsLocale} from './DevToolsLocale.js';
+
+export interface NumberFormatter {
+  format(value: number): string;
+  formatToParts(value: number): Intl.NumberFormatPart[];
+}
+
+/**
+ * Creates an instance of NumberFormatter.
+ *
+ * Safe to call in top-level of a module, since the creation of Intl.NumberFormat is deferred
+ * until first usage.
+ */
+export function defineFormatter(options: Intl.NumberFormatOptions): NumberFormatter {
+  let intlNumberFormat: Intl.NumberFormat;
+
+  return {
+    format(value) {
+      if (!intlNumberFormat) {
+        intlNumberFormat = new Intl.NumberFormat(DevToolsLocale.instance().locale, options);
+      }
+      return formatAndEnsureSpace(intlNumberFormat, value);
+    },
+    formatToParts(value) {
+      if (!intlNumberFormat) {
+        intlNumberFormat = new Intl.NumberFormat(DevToolsLocale.instance().locale, options);
+      }
+      return intlNumberFormat.formatToParts(value);
+    },
+  };
+}
+
+/**
+ * When using 'narrow' unitDisplay, many locales exclude the space between the literal and the unit.
+ * We don't like that, so when there is no space literal we inject an nbsp manually.
+ */
+function formatAndEnsureSpace(formatter: Intl.NumberFormat, value: number): string {
+  const parts = formatter.formatToParts(value);
+
+  let hasSpace = false;
+  for (const part of parts) {
+    if (part.type === 'literal') {
+      if (part.value === ' ') {
+        hasSpace = true;
+        part.value = '\xA0';
+      } else if (part.value === '\xA0') {
+        hasSpace = true;
+      }
+    }
+  }
+
+  if (hasSpace) {
+    return parts.map(part => part.value).join('');
+  }
+
+  const unitIndex = parts.findIndex(part => part.type === 'unit');
+
+  // Unexpected for there to be no unit, but just in case, handle that.
+  if (unitIndex === -1) {
+    return parts.map(part => part.value).join('');
+  }
+
+  // For locales where the unit comes first (sw), the space has to come after the unit.
+  if (unitIndex === 0) {
+    return parts[0].value + '\xA0' + parts.slice(1).map(part => part.value).join('');
+  }
+
+  // Otherwise, it comes before.
+  return parts.slice(0, unitIndex).map(part => part.value).join('') + '\xA0' +
+      parts.slice(unitIndex).map(part => part.value).join('');
+}

package/front_end/core/i18n/i18n.ts

@@ -2,12 +2,16 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as ByteUtilities from './ByteUtilities.js';
 import * as DevToolsLocale from './DevToolsLocale.js';
 import * as i18n from './i18nImpl.js';
+import * as NumberFormatter from './NumberFormatter.js';
 import * as TimeUtilities from './time-utilities.js';
 
 export {
+  ByteUtilities,
   DevToolsLocale,
   i18n,
+  NumberFormatter,
   TimeUtilities,
 };