chrome-devtools-frontend 1.0.1376716 → 1.0.1386602

package/front_end/panels/whats_new/releaseNoteView.css

@@ -0,0 +1,121 @@
+/*
+ * Copyright 2024 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+* {
+  box-sizing: border-box;
+}
+
+.hbox {
+  overflow-y: auto;
+  overflow-x: hidden;
+  display: flex;
+  position: relative;
+  flex-direction: row;
+}
+
+.release-note-top-section {
+  height: 27px;
+  line-height: 27px;
+  padding: 0 15px;
+  flex: none;
+  color: var(--sys-color-on-surface);
+  background-color: var(--sys-color-cdt-base-container);
+  border-bottom: 1px solid var(--sys-color-divider);
+  overflow: hidden;
+  white-space: nowrap;
+  text-overflow: ellipsis;
+}
+
+.release-note-container {
+  display: flex;
+  flex-direction: column;
+  min-width: 350px;
+}
+
+.release-note-container ul {
+  display: flex;
+  padding: 10px 16px;
+  flex-direction: column;
+  flex: none;
+  margin: 4px 12px 0 2px;
+  max-width: 600px;
+}
+
+.release-note-container li {
+  display: flex;
+  flex-direction: column;
+  flex: none;
+  line-height: 200%;
+  font-size: 14px;
+}
+
+.release-note-container .release-note-link {
+  border: 1px solid var(--sys-color-divider);
+  padding-left: 8px;
+  padding-right: 8px;
+  margin-bottom: 4px;
+  text-decoration: none;
+  color: var(--sys-color-primary);
+}
+
+.release-note-container .release-note-link:hover {
+  box-shadow: 0 0 0 1px var(--box-shadow-outline-color) inset;
+}
+
+.release-note-title,
+.release-note-subtitle {
+  color: inherit;
+  text-decoration: none;
+}
+
+.release-note-subtitle {
+  font-size: 13px;
+  line-height: 125%;
+  padding-bottom: 8px;
+}
+
+devtools-button {
+  margin: 10px 0 20px 20px;
+}
+
+.release-note-container li:not(:hover) .release-note-subtitle {
+  color: var(--sys-color-token-subtle);
+}
+
+.release-note-image {
+  flex-shrink: 2;
+  margin: 30px 15px;
+  width: 260px;
+  height: 200px;
+}
+
+img {
+  width: 260px;
+  height: 200px;
+  flex: none;
+  box-shadow: var(--drop-shadow-depth-1);
+}
+
+img:hover {
+  box-shadow: var(--drop-shadow-depth-4);
+}
+
+@media (forced-colors: active) {
+  .release-note-container .release-note-link {
+    border-color: ButtonText;
+  }
+
+  .release-note-container .release-note-link:hover {
+    forced-color-adjust: none;
+    border-color: Highlight;
+  }
+
+  .release-note-container li .release-note-title,
+  .release-note-container li:not(:hover) .release-note-subtitle {
+    forced-color-adjust: none;
+    color: linktext;
+  }
+}

package/front_end/panels/whats_new/resources/WNDT.md

@@ -0,0 +1,6 @@
+### [AI assistance for Network, Performance, and Sources](ai-assistance)
+In the AI assistance panel, you can now chat with Gemini about network requests, source files, and performance traces.
+### [AI chat history](chat-history)
+While DevTools is open, you can now create and view several chats with AI.
+### [Interaction phases in live metrics](interaction-phases)
+The Interactions tab in live metrics in the Performance panel now shows you phases and their timings.

package/front_end/panels/whats_new/whats_new-meta.ts

@@ -0,0 +1,142 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Common from '../../core/common/common.js';
+import * as i18n from '../../core/i18n/i18n.js';
+import * as UI from '../../ui/legacy/legacy.js';
+
+// eslint-disable-next-line rulesdir/es_modules_import
+import type * as WhatsNew from './whats_new.js';
+
+const UIStrings = {
+  /**
+   *@description Title of the 'What's New' tool in the bottom drawer
+   */
+  whatsNew: 'What\'s new',
+  /**
+   *@description Command for showing the 'What's New' tool in the bottom drawer
+   */
+  showWhatsNew: 'Show what\'s new',
+  /**
+   *@description Title of an action in the 'What's New' tool to release notes
+   */
+  releaseNotes: 'Release notes',
+  /**
+   *@description Title of an action in the 'What's New' tool to file an issue
+   */
+  reportADevtoolsIssue: 'Report a DevTools issue',
+  /**
+   *@description A search term referring to a software defect (i.e. bug) that can be entered in the command menu
+   */
+  bug: 'bug',
+  /**
+   *@description Title of a setting under the Appearance category that can be invoked through the Command Menu
+   */
+  showWhatsNewAfterEachUpdate: 'Show what\'s new after each update',
+  /**
+   *@description Title of a setting under the Appearance category that can be invoked through the Command Menu
+   */
+  doNotShowWhatsNewAfterEachUpdate: 'Don\'t show what\'s new after each update',
+};
+
+const str_ = i18n.i18n.registerUIStrings('panels/whats_new/whats_new-meta.ts', UIStrings);
+
+const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
+
+let loadedHelpModule: (typeof WhatsNew|undefined);
+
+async function loadWhatsNewModule(): Promise<typeof WhatsNew> {
+  if (!loadedHelpModule) {
+    loadedHelpModule = await import('./whats_new.js');
+  }
+  return loadedHelpModule;
+}
+UI.ViewManager.maybeRemoveViewExtension('release-note');
+UI.ActionRegistration.maybeRemoveActionExtension('help.release-notes');
+UI.ActionRegistration.maybeRemoveActionExtension('help.report-issue');
+Common.Settings.maybeRemoveSettingExtension('help.show-release-note');
+UI.ContextMenu.maybeRemoveItem({
+  location: UI.ContextMenu.ItemLocation.MAIN_MENU_HELP_DEFAULT,
+  actionId: 'help.release-notes',
+  order: undefined,
+});
+UI.ContextMenu.maybeRemoveItem({
+  location: UI.ContextMenu.ItemLocation.MAIN_MENU_HELP_DEFAULT,
+  actionId: 'help.report-issue',
+  order: undefined,
+});
+
+Common.Runnable.maybeRemoveLateInitializationRunnable('whats-new');
+
+UI.ViewManager.registerViewExtension({
+  location: UI.ViewManager.ViewLocationValues.DRAWER_VIEW,
+  id: 'release-note',
+  title: i18nLazyString(UIStrings.whatsNew),
+  commandPrompt: i18nLazyString(UIStrings.showWhatsNew),
+  persistence: UI.ViewManager.ViewPersistence.CLOSEABLE,
+  order: 1,
+  async loadView() {
+    const WhatsNew = await loadWhatsNewModule();
+    return WhatsNew.ReleaseNoteView.ReleaseNoteViewWrapper.instance();
+  },
+});
+
+UI.ActionRegistration.registerActionExtension({
+  category: UI.ActionRegistration.ActionCategory.HELP,
+  actionId: 'help.release-notes',
+  title: i18nLazyString(UIStrings.releaseNotes),
+  async loadActionDelegate() {
+    const WhatsNew = await loadWhatsNewModule();
+    return WhatsNew.WhatsNew.ReleaseNotesActionDelegate.instance();
+  },
+});
+
+UI.ActionRegistration.registerActionExtension({
+  category: UI.ActionRegistration.ActionCategory.HELP,
+  actionId: 'help.report-issue',
+  title: i18nLazyString(UIStrings.reportADevtoolsIssue),
+  async loadActionDelegate() {
+    const WhatsNew = await loadWhatsNewModule();
+    return WhatsNew.WhatsNew.ReportIssueActionDelegate.instance();
+  },
+  tags: [i18nLazyString(UIStrings.bug)],
+});
+
+Common.Settings.registerSettingExtension({
+  category: Common.Settings.SettingCategory.APPEARANCE,
+  title: i18nLazyString(UIStrings.showWhatsNewAfterEachUpdate),
+  settingName: 'help.show-release-note',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: true,
+  options: [
+    {
+      value: true,
+      title: i18nLazyString(UIStrings.showWhatsNewAfterEachUpdate),
+    },
+    {
+      value: false,
+      title: i18nLazyString(UIStrings.doNotShowWhatsNewAfterEachUpdate),
+    },
+  ],
+});
+
+UI.ContextMenu.registerItem({
+  location: UI.ContextMenu.ItemLocation.MAIN_MENU_HELP_DEFAULT,
+  actionId: 'help.release-notes',
+  order: 10,
+});
+
+UI.ContextMenu.registerItem({
+  location: UI.ContextMenu.ItemLocation.MAIN_MENU_HELP_DEFAULT,
+  actionId: 'help.report-issue',
+  order: 11,
+});
+
+Common.Runnable.registerLateInitializationRunnable({
+  id: 'whats-new',
+  async loadRunnable() {
+    const WhatsNew = await loadWhatsNewModule();
+    return WhatsNew.WhatsNew.HelpLateInitialization.instance();
+  },
+});

package/front_end/panels/whats_new/whats_new.ts

@@ -0,0 +1,13 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as ReleaseNoteText from './ReleaseNoteText.js';
+import * as ReleaseNoteView from './ReleaseNoteView.js';
+import * as WhatsNew from './WhatsNewImpl.js';
+
+export {
+  ReleaseNoteText,
+  ReleaseNoteView,
+  WhatsNew,
+};

package/front_end/services/puppeteer/PuppeteerConnection.ts

@@ -2,9 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as puppeteer from '../../third_party/puppeteer/puppeteer.js';
-import type * as Protocol from '../../generated/protocol.js';
 import type * as SDK from '../../core/sdk/sdk.js';
+import type * as Protocol from '../../generated/protocol.js';
+import * as puppeteer from '../../third_party/puppeteer/puppeteer.js';
 
 class Transport implements puppeteer.ConnectionTransport {
   #connection: SDK.Connections.ParallelConnectionInterface;
@@ -84,9 +84,10 @@ export class PuppeteerConnectionHelper {
         [] /* contextIds */,
         false /* ignoreHTTPSErrors */,
         undefined /* defaultViewport */,
+        undefined /* DownloadBehavior */,
         undefined /* process */,
         undefined /* closeCallback */,
-        undefined,
+        undefined /* targetFilterCallback */,
         target => isPageTargetCallback((target as puppeteer.Target)._getTargetInfo()),
         false /* waitForInitiallyDiscoveredTargets */,
     );

package/front_end/testing/EnvironmentHelpers.ts

@@ -131,7 +131,6 @@ const REGISTERED_EXPERIMENTS = [
   Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE,
   Root.Runtime.ExperimentName.TIMELINE_SHOW_POST_MESSAGE_EVENTS,
   Root.Runtime.ExperimentName.TIMELINE_ENHANCED_TRACES,
-  Root.Runtime.ExperimentName.EXTENSION_STORAGE_VIEWER,
   Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
   Root.Runtime.ExperimentName.TIMELINE_DIM_UNRELATED_EVENTS,
   Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
@@ -287,7 +286,7 @@ export async function initializeGlobalVars({reset = true} = {}) {
     createSettingValue(
         Common.Settings.SettingCategory.CONSOLE, 'console-trace-expand', false, Common.Settings.SettingType.BOOLEAN),
     createSettingValue(
-        Common.Settings.SettingCategory.PERFORMANCE, 'flamechart-mouse-wheel-action', false,
+        Common.Settings.SettingCategory.PERFORMANCE, 'flamechart-selected-navigation', false,
         Common.Settings.SettingType.ENUM),
     createSettingValue(
         Common.Settings.SettingCategory.ELEMENTS, 'show-css-property-documentation-on-hover', false,
@@ -520,36 +519,18 @@ export function getGetHostConfigStub(config: Root.Runtime.HostConfig): sinon.Sin
       enabled: false,
       ...config.devToolsFreestyler,
     } as Root.Runtime.HostConfigFreestyler,
-    devToolsExplainThisResourceDogfood: {
-      modelId: '',
-      temperature: -1,
-      enabled: false,
-      ...config.devToolsExplainThisResourceDogfood,
-    } as Root.Runtime.HostConfigAiAssistanceNetworkAgent,
     devToolsAiAssistanceNetworkAgent: {
       modelId: '',
       temperature: -1,
       enabled: false,
       ...config.devToolsAiAssistanceNetworkAgent,
     } as Root.Runtime.HostConfigAiAssistanceNetworkAgent,
-    devToolsAiAssistanceFileAgentDogfood: {
-      modelId: '',
-      temperature: -1,
-      enabled: false,
-      ...config.devToolsAiAssistanceFileAgentDogfood,
-    } as Root.Runtime.HostConfigAiAssistanceFileAgent,
     devToolsAiAssistanceFileAgent: {
       modelId: '',
       temperature: -1,
       enabled: false,
       ...config.devToolsAiAssistanceFileAgent,
     } as Root.Runtime.HostConfigAiAssistanceFileAgent,
-    devToolsAiAssistancePerformanceAgentDogfood: {
-      modelId: '',
-      temperature: -1,
-      enabled: false,
-      ...config.devToolsAiAssistancePerformanceAgentDogfood,
-    } as Root.Runtime.HostConfigAiAssistancePerformanceAgent,
     devToolsAiAssistancePerformanceAgent: {
       modelId: '',
       temperature: -1,
@@ -564,6 +545,11 @@ export function getGetHostConfigStub(config: Root.Runtime.HostConfig): sinon.Sin
       enabled: false,
       ...config.devToolsPrivacyUI,
     } as Root.Runtime.HostConfigPrivacyUI,
+    devToolsEnableOriginBoundCookies: {
+      portBindingEnabled: false,
+      schemeBindingEnabled: false,
+      ...config.devToolsEnableOriginBoundCookies,
+    } as Root.Runtime.HostConfigEnableOriginBoundCookies,
     isOffTheRecord: false,
   });
 }

package/front_end/testing/InsightHelpers.ts

@@ -30,9 +30,9 @@ export function createContextForNavigation(
   };
 }
 
-export function getInsightOrError<InsightName extends keyof Trace.Insights.Types.InsightResults>(
+export function getInsightOrError<InsightName extends keyof Trace.Insights.Types.InsightModels>(
     insightName: InsightName, insights: Trace.Insights.Types.TraceInsightSets,
-    navigation?: Trace.Types.Events.NavigationStart): Trace.Insights.Types.InsightResults[InsightName] {
+    navigation?: Trace.Types.Events.NavigationStart): Trace.Insights.Types.InsightModels[InsightName] {
   let key;
   if (navigation) {
     if (!navigation.args.data?.navigationId) {
@@ -48,13 +48,13 @@ export function getInsightOrError<InsightName extends keyof Trace.Insights.Types
     throw new Error('missing navInsights');
   }
 
-  const insight = insightSets.data[insightName];
+  const insight = insightSets.model[insightName];
   if (insight instanceof Error) {
     throw insight;
   }
 
   // For some reason typescript won't narrow the type by removing Error, so do it manually.
-  return insight as Trace.Insights.Types.InsightResults[InsightName];
+  return insight as Trace.Insights.Types.InsightModels[InsightName];
 }
 
 export function getFirstOrError<T>(iterator: IterableIterator<T>): T {

package/front_end/testing/SourceMapEncoder.ts

@@ -141,22 +141,34 @@ export class OriginalScopeBuilder {
     this.#names = names;
   }
 
-  start(line: number, column: number, kind: string, name?: string, variables?: string[]): this {
+  start(
+      line: number, column: number,
+      options?: {name?: string, kind?: string, isStackFrame?: boolean, variables?: string[]}): this {
     if (this.#encodedScope !== '') {
       this.#encodedScope += ',';
     }
 
     const lineDiff = line - this.#lastLine;
     this.#lastLine = line;
-    const flags = (name !== undefined ? 0x1 : 0x0);
-
-    this.#encodedScope += encodeVlqList([lineDiff, column, this.#encodeKind(kind), flags]);
+    let flags = 0;
+    const nameIdxAndKindIdx: number[] = [];
 
-    if (name !== undefined) {
-      this.#encodedScope += encodeVlq(this.#nameIdx(name));
+    if (options?.name) {
+      flags |= SDK.SourceMapScopes.EncodedOriginalScopeFlag.HAS_NAME;
+      nameIdxAndKindIdx.push(this.#nameIdx(options.name));
     }
-    if (variables !== undefined) {
-      this.#encodedScope += encodeVlqList(variables.map(variable => this.#nameIdx(variable)));
+    if (options?.kind) {
+      flags |= SDK.SourceMapScopes.EncodedOriginalScopeFlag.HAS_KIND;
+      nameIdxAndKindIdx.push(this.#encodeKind(options?.kind));
+    }
+    if (options?.isStackFrame) {
+      flags |= SDK.SourceMapScopes.EncodedOriginalScopeFlag.IS_STACK_FRAME;
+    }
+
+    this.#encodedScope += encodeVlqList([lineDiff, column, flags, ...nameIdxAndKindIdx]);
+
+    if (options?.variables) {
+      this.#encodedScope += encodeVlqList(options.variables.map(variable => this.#nameIdx(variable)));
     }
 
     return this;
@@ -218,7 +230,8 @@ export class GeneratedRangeBuilder {
   }
 
   start(line: number, column: number, options?: {
-    isFunctionScope?: boolean,
+    isStackFrame?: boolean,
+    isHidden?: boolean,
     definition?: {sourceIdx: number, scopeIdx: number},
     callsite?: {sourceIdx: number, line: number, column: number},
     bindings?: (string|undefined|{line: number, column: number, name: string|undefined}[])[],
@@ -239,8 +252,11 @@ export class GeneratedRangeBuilder {
     if (options?.callsite) {
       flags |= SDK.SourceMapScopes.EncodedGeneratedRangeFlag.HAS_CALLSITE;
     }
-    if (options?.isFunctionScope) {
-      flags |= SDK.SourceMapScopes.EncodedGeneratedRangeFlag.IS_FUNCTION_SCOPE;
+    if (options?.isStackFrame) {
+      flags |= SDK.SourceMapScopes.EncodedGeneratedRangeFlag.IS_STACK_FRAME;
+    }
+    if (options?.isHidden) {
+      flags |= SDK.SourceMapScopes.EncodedGeneratedRangeFlag.IS_HIDDEN;
     }
     this.#encodedRange += encodeVlq(flags);
 

package/front_end/testing/TraceHelpers.ts

@@ -463,7 +463,7 @@ export class FakeFlameChartProvider implements PerfUI.FlameChart.FlameChartDataP
     return 3;
   }
 
-  prepareHighlightedEntryInfo(_entryIndex: number): Element|null {
+  preparePopoverElement(_entryIndex: number): Element|null {
     return null;
   }
 
@@ -609,7 +609,7 @@ export function getBaseTraceParseModelData(overrides: Partial<ParsedTrace> = {})
       performanceMeasures: [],
       timestampEvents: [],
     },
-    LargestImagePaint: new Map(),
+    LargestImagePaint: {imageByDOMNodeId: new Map(), lcpRequestByNavigation: new Map()},
     LargestTextPaint: new Map(),
     AuctionWorklets: {
       worklets: new Map(),
@@ -626,6 +626,7 @@ export function getBaseTraceParseModelData(overrides: Partial<ParsedTrace> = {})
     ImagePainting: {
       paintImageByDrawLazyPixelRef: new Map(),
       paintImageForEvent: new Map(),
+      paintImageEventForUrl: new Map(),
     },
     Initiators: {
       eventToInitiator: new Map(),

package/front_end/testing/TraceLoader.ts

@@ -31,6 +31,7 @@ const fileContentsCache = new Map<string, Trace.Types.File.Contents>();
 const traceEngineCache = new Map<string, Map<string, {
                                    parsedTrace: Trace.Handlers.Types.ParsedTrace,
                                    insights: Trace.Insights.Types.TraceInsightSets | null,
+                                   metadata: Trace.Types.File.MetaData | null,
                                    model: Trace.TraceModel.Model,
                                  }>>();
 
@@ -125,6 +126,7 @@ export class TraceLoader {
       config: Trace.Types.Configuration.Configuration = Trace.Types.Configuration.defaults()): Promise<{
     parsedTrace: Trace.Handlers.Types.ParsedTrace,
     insights: Trace.Insights.Types.TraceInsightSets|null,
+    metadata: Trace.Types.File.MetaData|null,
   }> {
     // Force the TraceBounds to be reset to empty. This ensures that in
     // tests where we are using the new engine data we don't accidentally
@@ -146,16 +148,17 @@ export class TraceLoader {
       TraceLoader.initTraceBoundsManager(fromCache.parsedTrace);
       Timeline.ModificationsManager.ModificationsManager.reset();
       Timeline.ModificationsManager.ModificationsManager.initAndActivateModificationsManager(fromCache.model, 0);
-      return {parsedTrace: fromCache.parsedTrace, insights: fromCache.insights};
+      return {parsedTrace: fromCache.parsedTrace, insights: fromCache.insights, metadata: fromCache.metadata};
     }
 
     const fileContents = await TraceLoader.fixtureContents(context, name);
     const parsedTraceData =
         await TraceLoader.executeTraceEngineOnFileContents(fileContents, /* emulate fresh recording */ false, config);
 
-    const cacheByName = traceEngineCache.get(name) || new Map<string, {
+    const cacheByName = traceEngineCache.get(name) ?? new Map<string, {
                           parsedTrace: Trace.Handlers.Types.ParsedTrace,
                           insights: Trace.Insights.Types.TraceInsightSets | null,
+                          metadata: Trace.Types.File.MetaData | null,
                           model: Trace.TraceModel.Model,
                         }>();
     cacheByName.set(configCacheKey, parsedTraceData);
@@ -167,6 +170,7 @@ export class TraceLoader {
     return {
       parsedTrace: parsedTraceData.parsedTrace,
       insights: parsedTraceData.insights,
+      metadata: parsedTraceData.metadata,
     };
   }
 

package/front_end/third_party/lighthouse/README.chromium

@@ -1,7 +1,7 @@
 Name: Lighthouse
 Short Name: lighthouse
-Version: 12.2.1
-Revision: 31bdd8ad2c0a9e2734fe230be0fbd7134296b8ed
+Version: 12.2.2
+Revision: b64b3534542c9dcaabb33d40b84ed7c93eefbd7d
 URL: https://github.com/GoogleChrome/lighthouse
 License: Apache License 2.0
 License File: LICENSE