activemerchant 1.79.2 → 1.80.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e03115d421b0031a4c73b44ed64febbc0f3df381
-  data.tar.gz: d85fde5fb880eced27ce54395af62f37e9dbd7d3
+  metadata.gz: 2a370014b9b3f630ef74788e39ed2f70166e825b
+  data.tar.gz: ada89dc3c89779f200933eb9ce9ec03af4e4b68b
 SHA512:
-  metadata.gz: cd18cb5c3152ba192c43ae33c764b778e288a98395f66f2a95950ea34832aded9ad77925dda23eedba356f9ef23c47dde7c7a357c18cf923fca2cef125a50a6a
-  data.tar.gz: 1d68b1b83141f74a72fa17e0ebb4cfddd476116fb1af1b3014351ff88d2041927b47c0146c9c25b97223268f55902b70ca50aabb26fda0293713f3c71b27506c
+  metadata.gz: 9e98a44739681282c53fd421e39903830656a97bab74dab4c8d7ea34cf103f09b2c091fd6941b97cc72962e43f1aba3f104c89074089b5b2d3c53ae215f26a33
+  data.tar.gz: 255f0dab0c7aaf55f4d111fac977e5cd058fa5e8a86b4d6f424fe87bdb056d730bc5ea50830887fa1f69f72c58c24929ce3c3bf296f05b3c0196803e5a2702b5

data/CHANGELOG

@@ -2,6 +2,39 @@
 
 == HEAD
 
+== Version 1.80.0 (July 4, 2018)
+* Default SSL min_version to TLS 1.1 to comply with June 30 PCI DSS deadline [bdewater] #2909
+* Paymentez: return a Result object even when the upstream server 500s [bpollack] #2871
+* Drop support for Ruby versions older than 2.3 [bpollack] #2863
+* Bridge Pay: don't throw an exception when bank account type is omitted [bpollack] #2873
+* Avoid making actual connections in Blue Snap and Mundipagg unit tests [bpollack] #2875
+* Avoid making actual connections in the connection unit tests [bpollack] #2876
+* Openpay: support payment installments [bpollack] #2865
+* First Pay: support recurring charges [bpollack] #2877
+* Bridge Pay: pass full name of account type for echeck transactions [bpollack] #2878
+* Kushki: do not send 0 for tax values if tax values are not provided [bpollack] #2886
+* Payflow: Update ACH tests [curiousepic] #2887
+* Credorax: support passing billing description [bpollack] #2889
+* MiGS: scrub 3DS fields [abarrak] #2771
+* Forte: avoid crashing when location_id or account_id have spaces [bpollack] #2890
+* Adyen: Support Network Tokenization Cards via mpiData fields [curiousepic] #2891
+* Moneris US: Add ACH [nfarve] #2888
+* Realex: Pass amount for captures [curiousepic] #2895
+* Card Connect: support storing cards [bpollack] #2896
+* Avoid mutating headers passed in for Active Merchant connections [grantbdev] #2892
+* Forte: add support for refunds [bpollack] #2898
+* Forte: fix a bug in logic for selecting billing names [whitby3001] #2381
+* Paymentez: allow capture amount to exceed authorization amount [bpollack] #2900
+* JetPay: fix typo in error messages [reynhout] #2749
+* Braintree: add support for Maestro cards [matthewheath] #2571
+* Visanet Peru: Refund on unsettled transactions [nfarve] #2772
+* Remove iDeal offsite gateway references [bdewater] #2807
+* Conekta: Allow customer application in headers [curiousepic] #2908
+* Payment Express: use testing URLs when testing [oklas] #2231
+* Redsys: Fix payments with cc token [Leonardo Diez] #2586
+* Redsys: Missing cardnumber params in xml_signed_fields [nerburish] #2628
+* Bogus: allow authorizing with a tokenized card [Azdaroth] #2703
+
 == Version 1.79.2 (June 2, 2018)
 * Fix Gateway#max_version= overwriting min_version [bdewater]
 

data/README.md

@@ -31,11 +31,15 @@ You can check out the latest source from git:
 
 Installation from RubyGems:
 
-    gem install activemerchant
+```console
+gem install activemerchant
+```
 
 Or, if you're using Bundler, just add the following to your Gemfile:
 
-    gem 'activemerchant'
+```ruby
+gem 'activemerchant'
+```
 
 ## Usage
 
@@ -232,3 +236,7 @@ The [ActiveMerchant Wiki](http://github.com/activemerchant/active_merchant/wikis
 ## API stability policy
 
 Functionality or APIs that are deprecated will be marked as such. Deprecated functionality is removed on major version changes - for example, deprecations from 2.x are removed in 3.x.
+
+## Ruby and Rails compatibility policies
+
+Because Active Merchant is a payment library, it needs to take security seriously. For this reason, Active Merchant guarantees compatibility only with actively supported versions of Ruby and Rails. At the time of this writing, that means that Ruby 2.3+ and Rails 4.2+ are supported.

data/lib/active_merchant.rb

@@ -51,7 +51,7 @@ require 'active_merchant/country'
 
 module ActiveMerchant
   def self.deprecated(message, caller=Kernel.caller[1])
-    warning = caller + ": " + message
+    warning = caller + ': ' + message
     if(respond_to?(:logger) && logger.present?)
       logger.warn(warning)
     else

data/lib/active_merchant/billing/check.rb

@@ -30,17 +30,17 @@ module ActiveMerchant #:nodoc:
         errors = []
 
         [:name, :routing_number, :account_number].each do |attr|
-          errors << [attr, "cannot be empty"] if empty?(self.send(attr))
+          errors << [attr, 'cannot be empty'] if empty?(self.send(attr))
         end
 
-        errors << [:routing_number, "is invalid"] unless valid_routing_number?
+        errors << [:routing_number, 'is invalid'] unless valid_routing_number?
 
         if(!empty?(account_holder_type) && !%w[business personal].include?(account_holder_type.to_s))
-          errors << [:account_holder_type, "must be personal or business"]
+          errors << [:account_holder_type, 'must be personal or business']
         end
 
         if(!empty?(account_type) && !%w[checking savings].include?(account_type.to_s))
-          errors << [:account_type, "must be checking or savings"]
+          errors << [:account_type, 'must be checking or savings']
         end
 
         errors_hash(errors)

data/lib/active_merchant/billing/compatibility.rb

@@ -27,7 +27,7 @@ module ActiveMerchant
 
       def self.humanize(lower_case_and_underscored_word)
         result = lower_case_and_underscored_word.to_s.dup
-        result.gsub!(/_id$/, "")
+        result.gsub!(/_id$/, '')
         result.gsub!(/_/, ' ')
         result.gsub(/([a-z\d]*)/i) { |match|
           match.downcase

data/lib/active_merchant/billing/credit_card.rb

@@ -1,6 +1,6 @@
 require 'time'
 require 'date'
-require "active_merchant/billing/model"
+require 'active_merchant/billing/model'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -65,7 +65,7 @@ module ActiveMerchant #:nodoc:
       attr_reader :number
 
       def number=(value)
-        @number = (empty?(value) ? value : value.to_s.gsub(/[^\d]/, ""))
+        @number = (empty?(value) ? value : value.to_s.gsub(/[^\d]/, ''))
       end
 
       # Returns or sets the expiry month for the card.
@@ -202,12 +202,12 @@ module ActiveMerchant #:nodoc:
       attr_accessor :encrypted_pin_ksn
 
       def type
-        ActiveMerchant.deprecated "CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead."
+        ActiveMerchant.deprecated 'CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead.'
         brand
       end
 
       def type=(value)
-        ActiveMerchant.deprecated "CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead."
+        ActiveMerchant.deprecated 'CreditCard#type is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand instead.'
         self.brand = value
       end
 
@@ -250,7 +250,7 @@ module ActiveMerchant #:nodoc:
       def name=(full_name)
         names = full_name.split
         self.last_name  = names.pop
-        self.first_name = names.join(" ")
+        self.first_name = names.join(' ')
       end
 
       %w(month year start_month start_year).each do |m|
@@ -326,20 +326,20 @@ module ActiveMerchant #:nodoc:
         errors = []
 
         if self.class.requires_name?
-          errors << [:first_name, "cannot be empty"] if first_name.blank?
-          errors << [:last_name,  "cannot be empty"] if last_name.blank?
+          errors << [:first_name, 'cannot be empty'] if first_name.blank?
+          errors << [:last_name,  'cannot be empty'] if last_name.blank?
         end
 
         if(empty?(month) || empty?(year))
-          errors << [:month, "is required"] if empty?(month)
-          errors << [:year,  "is required"] if empty?(year)
+          errors << [:month, 'is required'] if empty?(month)
+          errors << [:year,  'is required'] if empty?(year)
         else
-          errors << [:month, "is not a valid month"] if !valid_month?(month)
+          errors << [:month, 'is not a valid month'] if !valid_month?(month)
 
           if expired?
-            errors << [:year,  "expired"]
+            errors << [:year,  'expired']
           else
-            errors << [:year,  "is not a valid year"]  if !valid_expiry_year?(year)
+            errors << [:year,  'is not a valid year']  if !valid_expiry_year?(year)
           end
         end
 
@@ -350,17 +350,17 @@ module ActiveMerchant #:nodoc:
         errors = []
 
         if !empty?(brand)
-          errors << [:brand, "is invalid"]  if !CreditCard.card_companies.keys.include?(brand)
+          errors << [:brand, 'is invalid']  if !CreditCard.card_companies.keys.include?(brand)
         end
 
         if empty?(number)
-          errors << [:number, "is required"]
+          errors << [:number, 'is required']
         elsif !CreditCard.valid_number?(number)
-          errors << [:number, "is not a valid credit card number"]
+          errors << [:number, 'is not a valid credit card number']
         end
 
         if errors.empty?
-          errors << [:brand, "does not match the card number"] if !CreditCard.matching_brand?(number, brand)
+          errors << [:brand, 'does not match the card number'] if !CreditCard.matching_brand?(number, brand)
         end
 
         errors
@@ -374,7 +374,7 @@ module ActiveMerchant #:nodoc:
             errors << [:verification_value, "should be #{card_verification_value_length(brand)} digits"]
           end
         elsif requires_verification_value?
-          errors << [:verification_value, "is required"]
+          errors << [:verification_value, 'is required']
         end
         errors
       end
@@ -388,11 +388,11 @@ module ActiveMerchant #:nodoc:
 
           if((!valid_start_month || !valid_start_year) && !valid_issue_number?(issue_number))
             if empty?(issue_number)
-              errors << [:issue_number, "cannot be empty"]
-              errors << [:start_month, "is invalid"] if !valid_start_month
-              errors << [:start_year,  "is invalid"] if !valid_start_year
+              errors << [:issue_number, 'cannot be empty']
+              errors << [:start_month, 'is invalid'] if !valid_start_month
+              errors << [:start_year,  'is invalid'] if !valid_start_year
             else
-              errors << [:issue_number, "is invalid"] if !valid_issue_number?(issue_number)
+              errors << [:issue_number, 'is invalid'] if !valid_issue_number?(issue_number)
             end
           end
         end

data/lib/active_merchant/billing/credit_card_formatting.rb

@@ -14,8 +14,8 @@ module ActiveMerchant #:nodoc:
         return '' if number.blank?
 
         case option
-          when :two_digits  ; sprintf("%.2i", number.to_i)[-2..-1]
-          when :four_digits ; sprintf("%.4i", number.to_i)[-4..-1]
+          when :two_digits  then sprintf('%.2i', number.to_i)[-2..-1]
+          when :four_digits then sprintf('%.4i', number.to_i)[-4..-1]
           else number
         end
       end

data/lib/active_merchant/billing/credit_card_methods.rb

@@ -149,7 +149,7 @@ module ActiveMerchant #:nodoc:
         end
 
         def type?(number)
-          ActiveMerchant.deprecated "CreditCard#type? is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand? instead."
+          ActiveMerchant.deprecated 'CreditCard#type? is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#brand? instead.'
           brand?(number)
         end
 
@@ -171,7 +171,7 @@ module ActiveMerchant #:nodoc:
         end
 
         def matching_type?(number, brand)
-          ActiveMerchant.deprecated "CreditCard#matching_type? is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#matching_brand? instead."
+          ActiveMerchant.deprecated 'CreditCard#matching_type? is deprecated and will be removed from a future release of ActiveMerchant. Please use CreditCard#matching_brand? instead.'
           matching_brand?(number, brand)
         end
 

data/lib/active_merchant/billing/gateway.rb

@@ -58,8 +58,8 @@ module ActiveMerchant #:nodoc:
 
       DEBIT_CARDS = [ :switch, :solo ]
 
-      CREDIT_DEPRECATION_MESSAGE = "Support for using credit to refund existing transactions is deprecated and will be removed from a future release of ActiveMerchant. Please use the refund method instead."
-      RECURRING_DEPRECATION_MESSAGE = "Recurring functionality in ActiveMerchant is deprecated and will be removed in a future version. Please contact the ActiveMerchant maintainers if you have an interest in taking ownership of a separate gem that continues support for it."
+      CREDIT_DEPRECATION_MESSAGE = 'Support for using credit to refund existing transactions is deprecated and will be removed from a future release of ActiveMerchant. Please use the refund method instead.'
+      RECURRING_DEPRECATION_MESSAGE = 'Recurring functionality in ActiveMerchant is deprecated and will be removed in a future version. Please contact the ActiveMerchant maintainers if you have an interest in taking ownership of a separate gem that continues support for it.'
 
       # == Standardized Error Codes
       #
@@ -195,7 +195,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def scrub(transcript)
-        raise RuntimeError.new("This gateway does not support scrubbing.")
+        raise RuntimeError.new('This gateway does not support scrubbing.')
       end
 
       def supports_network_tokenization?
@@ -206,10 +206,10 @@ module ActiveMerchant #:nodoc:
 
       def normalize(field)
         case field
-          when "true"   then true
-          when "false"  then false
-          when ""       then nil
-          when "null"   then nil
+          when 'true'   then true
+          when 'false'  then false
+          when ''       then nil
+          when 'null'   then nil
           else field
         end
       end
@@ -243,7 +243,7 @@ module ActiveMerchant #:nodoc:
       def amount(money)
         return nil if money.nil?
         cents = if money.respond_to?(:cents)
-          ActiveMerchant.deprecated "Support for Money objects is deprecated and will be removed from a future release of ActiveMerchant. Please use an Integer value in cents"
+          ActiveMerchant.deprecated 'Support for Money objects is deprecated and will be removed from a future release of ActiveMerchant. Please use an Integer value in cents'
           money.cents
         else
           money
@@ -256,7 +256,7 @@ module ActiveMerchant #:nodoc:
         if self.money_format == :cents
           cents.to_s
         else
-          sprintf("%.2f", cents.to_f / 100)
+          sprintf('%.2f', cents.to_f / 100)
         end
       end
 
@@ -274,7 +274,7 @@ module ActiveMerchant #:nodoc:
         return amount unless non_fractional_currency?(currency) || three_decimal_currency?(currency)
         if non_fractional_currency?(currency)
           if self.money_format == :cents
-            sprintf("%.0f", amount.to_f / 100)
+            sprintf('%.0f', amount.to_f / 100)
           else
             amount.split('.').first
           end
@@ -282,7 +282,7 @@ module ActiveMerchant #:nodoc:
           if self.money_format == :cents
             amount.to_s
           else
-            sprintf("%.3f", (amount.to_f / 10))
+            sprintf('%.3f', (amount.to_f / 10))
           end
         end
       end
@@ -297,11 +297,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def split_names(full_name)
-        names = (full_name || "").split
+        names = (full_name || '').split
         return [nil, nil] if names.size == 0
 
         last_name  = names.pop
-        first_name = names.join(" ")
+        first_name = names.join(' ')
         [first_name, last_name]
       end
 

data/lib/active_merchant/billing/gateways/adyen.rb

@@ -44,7 +44,7 @@ module ActiveMerchant #:nodoc:
         post = init_post(options)
         add_invoice(post, money, options)
         add_payment(post, payment)
-        add_extra_data(post, options)
+        add_extra_data(post, payment, options)
         add_shopper_interaction(post, payment, options)
         add_address(post, options)
         add_installments(post, options) if options[:installments]
@@ -76,7 +76,7 @@ module ActiveMerchant #:nodoc:
         post = init_post(options)
         add_invoice(post, 0, options)
         add_payment(post, credit_card)
-        add_extra_data(post, options)
+        add_extra_data(post, credit_card, options)
         add_recurring_contract(post, options)
         add_address(post, options)
         commit('authorise', post)
@@ -97,26 +97,33 @@ module ActiveMerchant #:nodoc:
         transcript.
           gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]').
           gsub(%r(("number\\?":\\?")[^"]*)i, '\1[FILTERED]').
-          gsub(%r(("cvc\\?":\\?")[^"]*)i, '\1[FILTERED]')
+          gsub(%r(("cvc\\?":\\?")[^"]*)i, '\1[FILTERED]').
+          gsub(%r(("cavv\\?":\\?")[^"]*)i, '\1[FILTERED]')
       end
 
       private
 
-      def add_extra_data(post, options)
+      NETWORK_TOKENIZATION_CARD_SOURCE = {
+        'apple_pay' => 'applepay',
+        'android_pay' => 'androidpay',
+        'google_pay' => 'paywithgoogle'
+      }
+
+      def add_extra_data(post, payment, options)
         post[:shopperEmail] = options[:shopper_email] if options[:shopper_email]
         post[:shopperIP] = options[:shopper_ip] if options[:shopper_ip]
         post[:shopperReference] = options[:shopper_reference] if options[:shopper_reference]
         post[:fraudOffset] = options[:fraud_offset] if options[:fraud_offset]
-        post[:selectedBrand] = options[:selected_brand] if options[:selected_brand]
+        post[:selectedBrand] = options[:selected_brand] || NETWORK_TOKENIZATION_CARD_SOURCE[payment.source.to_s] if payment.is_a?(NetworkTokenizationCreditCard)
         post[:deliveryDate] = options[:delivery_date] if options[:delivery_date]
         post[:merchantOrderReference] = options[:merchant_order_reference] if options[:merchant_order_reference]
       end
 
       def add_shopper_interaction(post, payment, options={})
-        if payment.respond_to?(:verification_value) && payment.verification_value
-          shopper_interaction = "Ecommerce"
+        if (payment.respond_to?(:verification_value) && payment.verification_value) || payment.is_a?(NetworkTokenizationCreditCard)
+          shopper_interaction = 'Ecommerce'
         else
-          shopper_interaction = "ContAuth"
+          shopper_interaction = 'ContAuth'
         end
 
         post[:shopperInteraction] = options[:shopper_interaction] || shopper_interaction
@@ -153,10 +160,11 @@ module ActiveMerchant #:nodoc:
 
       def add_payment(post, payment)
         if payment.is_a?(String)
-          _, _, recurring_detail_reference = payment.split("#")
+          _, _, recurring_detail_reference = payment.split('#')
           post[:selectedRecurringDetailReference] = recurring_detail_reference
           add_recurring_contract(post, options)
         else
+          add_mpi_data_for_network_tokenization_card(post, payment) if payment.is_a?(NetworkTokenizationCreditCard)
           add_card(post, payment)
         end
       end
@@ -176,22 +184,30 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_reference(post, authorization, options = {})
-        _, psp_reference, _ = authorization.split("#")
+        _, psp_reference, _ = authorization.split('#')
         post[:originalReference] = single_reference(authorization) || psp_reference
       end
 
       def add_original_reference(post, authorization, options = {})
-        original_psp_reference, _, _ = authorization.split("#")
+        original_psp_reference, _, _ = authorization.split('#')
         post[:originalReference] = single_reference(authorization) || original_psp_reference
       end
 
+      def add_mpi_data_for_network_tokenization_card(post, payment)
+        post[:mpiData] = {}
+        post[:mpiData][:authenticationResponse] = 'Y'
+        post[:mpiData][:cavv] = payment.payment_cryptogram
+        post[:mpiData][:directoryResponse] = 'Y'
+        post[:mpiData][:eci] = payment.eci || '07'
+      end
+
       def single_reference(authorization)
-        authorization if !authorization.include?("#")
+        authorization if !authorization.include?('#')
       end
 
       def add_recurring_contract(post, options = {})
         recurring = {
-          contract: "RECURRING"
+          contract: 'RECURRING'
         }
 
         post[:recurring] = recurring
@@ -245,8 +261,8 @@ module ActiveMerchant #:nodoc:
 
       def request_headers
         {
-          "Content-Type" => "application/json",
-          "Authorization" => "Basic #{basic_auth}"
+          'Content-Type' => 'application/json',
+          'Authorization' => "Basic #{basic_auth}"
         }
       end