activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/allied_wallet.rb

@@ -1,13 +1,13 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class AlliedWalletGateway < Gateway
-      self.display_name = "Allied Wallet"
-      self.homepage_url = "https://www.alliedwallet.com"
+      self.display_name = 'Allied Wallet'
+      self.homepage_url = 'https://www.alliedwallet.com'
 
-      self.live_url = "https://api.alliedwallet.com/merchants/"
+      self.live_url = 'https://api.alliedwallet.com/merchants/'
 
-      self.supported_countries = ["US"]
-      self.default_currency = "USD"
+      self.supported_countries = ['US']
+      self.default_currency = 'USD'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :american_express, :discover,
                                   :diners_club, :jcb, :maestro]
@@ -104,7 +104,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_data(post, options)
-        post[:email] = options[:email] || "unspecified@example.com"
+        post[:email] = options[:email] || 'unspecified@example.com'
         post[:iPAddress] = options[:ip]
         if (billing_address = options[:billing_address])
           post[:firstName], post[:lastName] = split_names(billing_address[:name])
@@ -130,11 +130,11 @@ module ActiveMerchant #:nodoc:
 
 
       ACTIONS = {
-        purchase: "SALE",
-        authorize: "AUTHORIZE",
-        capture: "CAPTURE",
-        void: "VOID",
-        refund: "REFUND"
+        purchase: 'SALE',
+        authorize: 'AUTHORIZE',
+        capture: 'CAPTURE',
+        void: 'VOID',
+        refund: 'REFUND'
       }
 
       def commit(action, post)
@@ -146,14 +146,14 @@ module ActiveMerchant #:nodoc:
           response = parse(e.response.body)
         end
 
-        succeeded = success_from(response["status"])
+        succeeded = success_from(response['status'])
         Response.new(
           succeeded,
           message_from(succeeded, response),
           response,
-          authorization: response["id"],
-          :avs_result => AVSResult.new(code: response["avs_response"]),
-          :cvv_result => CVVResult.new(response["cvv2_response"]),
+          authorization: response['id'],
+          :avs_result => AVSResult.new(code: response['avs_response']),
+          :cvv_result => CVVResult.new(response['cvv2_response']),
           test: test?
         )
       rescue JSON::ParserError
@@ -161,20 +161,20 @@ module ActiveMerchant #:nodoc:
       end
 
       def unparsable_response(raw_response)
-        message = "Unparsable response received from Allied Wallet. Please contact Allied Wallet if you continue to receive this message."
+        message = 'Unparsable response received from Allied Wallet. Please contact Allied Wallet if you continue to receive this message.'
         message += " (The raw response returned by the API was #{raw_response.inspect})"
         return Response.new(false, message)
       end
 
       def headers
         {
-          "Content-type"  => "application/json",
-          "Authorization" => "Bearer " + @options[:token]
+          'Content-type'  => 'application/json',
+          'Authorization' => 'Bearer ' + @options[:token]
         }
       end
 
       def url(action)
-        live_url + CGI.escape(@options[:merchant_id]) + "/" + ACTIONS[action] + "transactions"
+        live_url + CGI.escape(@options[:merchant_id]) + '/' + ACTIONS[action] + 'transactions'
       end
 
       def parse(body)
@@ -190,14 +190,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response == "Successful"
+        response == 'Successful'
       end
 
       def message_from(succeeded, response)
         if succeeded
-          "Succeeded"
+          'Succeeded'
         else
-          response["message"] || "Unable to read error message"
+          response['message'] || 'Unable to read error message'
         end
       end
 

data/lib/active_merchant/billing/gateways/authorize_net.rb

@@ -89,10 +89,10 @@ module ActiveMerchant
           2 => /\A;(?<pan>[\d]{1,19}+)=(?<expiration>[\d]{0,4}|=)(?<service_code>[\d]{0,3}|=)(?<discretionary_data>.*)\?\Z/
       }.freeze
 
-      APPLE_PAY_DATA_DESCRIPTOR = "COMMON.APPLE.INAPP.PAYMENT"
+      APPLE_PAY_DATA_DESCRIPTOR = 'COMMON.APPLE.INAPP.PAYMENT'
 
-      PAYMENT_METHOD_NOT_SUPPORTED_ERROR = "155"
-      INELIGIBLE_FOR_ISSUING_CREDIT_ERROR = "54"
+      PAYMENT_METHOD_NOT_SUPPORTED_ERROR = '155'
+      INELIGIBLE_FOR_ISSUING_CREDIT_ERROR = '54'
 
       def initialize(options={})
         requires!(options, :login, :password)
@@ -102,11 +102,11 @@ module ActiveMerchant
       def purchase(amount, payment, options = {})
         if payment.is_a?(String)
           commit(:cim_purchase) do |xml|
-            add_cim_auth_purchase(xml, "profileTransAuthCapture", amount, payment, options)
+            add_cim_auth_purchase(xml, 'profileTransAuthCapture', amount, payment, options)
           end
         else
           commit(:purchase) do |xml|
-            add_auth_purchase(xml, "authCaptureTransaction", amount, payment, options)
+            add_auth_purchase(xml, 'authCaptureTransaction', amount, payment, options)
           end
         end
       end
@@ -114,11 +114,11 @@ module ActiveMerchant
       def authorize(amount, payment, options={})
         if payment.is_a?(String)
           commit(:cim_authorize) do |xml|
-            add_cim_auth_purchase(xml, "profileTransAuthOnly", amount, payment, options)
+            add_cim_auth_purchase(xml, 'profileTransAuthOnly', amount, payment, options)
           end
         else
           commit(:authorize) do |xml|
-            add_auth_purchase(xml, "authOnlyTransaction", amount, payment, options)
+            add_auth_purchase(xml, 'authOnlyTransaction', amount, payment, options)
           end
         end
       end
@@ -141,7 +141,7 @@ module ActiveMerchant
         return response if response.success?
         return response unless options[:force_full_refund_if_unsettled]
 
-        if response.params["response_reason_code"] == INELIGIBLE_FOR_ISSUING_CREDIT_ERROR
+        if response.params['response_reason_code'] == INELIGIBLE_FOR_ISSUING_CREDIT_ERROR
           void(authorization, options)
         else
           response
@@ -158,7 +158,7 @@ module ActiveMerchant
 
       def credit(amount, payment, options={})
         if payment.is_a?(String)
-          raise ArgumentError, "Reference credits are not supported. Please supply the original credit card or use the #refund method."
+          raise ArgumentError, 'Reference credits are not supported. Please supply the original credit card or use the #refund method.'
         end
 
         commit(:credit) do |xml|
@@ -222,7 +222,7 @@ module ActiveMerchant
 
       def supports_network_tokenization?
         card = Billing::NetworkTokenizationCreditCard.new({
-          :number => "4111111111111111",
+          :number => '4111111111111111',
           :month => 12,
           :year => 20,
           :first_name => 'John',
@@ -232,7 +232,7 @@ module ActiveMerchant
         })
 
         request = post_data(:authorize) do |xml|
-          add_auth_purchase(xml, "authOnlyTransaction", 1, card, {})
+          add_auth_purchase(xml, 'authOnlyTransaction', 1, card, {})
         end
         raw_response = ssl_post(url, request, headers)
         response = parse(:authorize, raw_response)
@@ -302,7 +302,7 @@ module ActiveMerchant
             add_tax_exempt_status(xml, options)
             add_po_number(xml, options)
             xml.refTransId(transaction_id_from(authorization))
-            add_invoice(xml, "capture", options)
+            add_invoice(xml, 'capture', options)
             add_user_fields(xml, amount, options)
           end
         end
@@ -320,7 +320,7 @@ module ActiveMerchant
               add_shipping_fields(xml, options)
               add_duty_fields(xml, options)
               xml.creditCardNumberMasked(card_number)
-              add_invoice(xml, "profileTransRefund", options)
+              add_invoice(xml, 'profileTransRefund', options)
               xml.transId(transaction_id)
             end
           end
@@ -396,38 +396,38 @@ module ActiveMerchant
         xml.transactionSettings do
           if options[:recurring]
             xml.setting do
-              xml.settingName("recurringBilling")
-              xml.settingValue("true")
+              xml.settingName('recurringBilling')
+              xml.settingValue('true')
             end
           end
           if options[:disable_partial_auth]
             xml.setting do
-              xml.settingName("allowPartialAuth")
-              xml.settingValue("false")
+              xml.settingName('allowPartialAuth')
+              xml.settingValue('false')
             end
           end
           if options[:duplicate_window]
             set_duplicate_window(xml, options[:duplicate_window])
           elsif self.class.duplicate_window
-            ActiveMerchant.deprecated "Using the duplicate_window class_attribute is deprecated. Use the transaction options hash instead."
+            ActiveMerchant.deprecated 'Using the duplicate_window class_attribute is deprecated. Use the transaction options hash instead.'
             set_duplicate_window(xml, self.class.duplicate_window)
           end
           if options.key?(:email_customer)
             xml.setting do
-              xml.settingName("emailCustomer")
-              xml.settingValue(options[:email_customer] ? "true" : "false")
+              xml.settingName('emailCustomer')
+              xml.settingValue(options[:email_customer] ? 'true' : 'false')
             end
           end
           if options[:header_email_receipt]
             xml.setting do
-              xml.settingName("headerEmailReceipt")
+              xml.settingName('headerEmailReceipt')
               xml.settingValue(options[:header_email_receipt])
             end
           end
           if options[:test_request]
             xml.setting do
-              xml.settingName("testRequest")
-              xml.settingValue("1")
+              xml.settingName('testRequest')
+              xml.settingValue('1')
             end
           end
         end
@@ -435,7 +435,7 @@ module ActiveMerchant
 
       def set_duplicate_window(xml, value)
         xml.setting do
-          xml.settingName("duplicateWindow")
+          xml.settingName('duplicateWindow')
           xml.settingValue(value)
         end
       end
@@ -444,13 +444,13 @@ module ActiveMerchant
         xml.userFields do
           if currency = (options[:currency] || currency(amount))
             xml.userField do
-              xml.name("x_currency_code")
+              xml.name('x_currency_code')
               xml.value(currency)
             end
           end
           if application_id.present?
             xml.userField do
-              xml.name("x_solution_id")
+              xml.name('x_solution_id')
               xml.value(application_id)
             end
           end
@@ -583,7 +583,7 @@ module ActiveMerchant
         end
       end
 
-      def add_shipping_address(xml, options, root_node="shipTo")
+      def add_shipping_address(xml, options, root_node='shipTo')
         address = options[:shipping_address] || options[:address]
         return unless address
 
@@ -615,7 +615,7 @@ module ActiveMerchant
         xml.order do
           xml.invoiceNumber(truncate(options[:order_id], 20))
           xml.description(truncate(options[:description], 255))
-          xml.purchaseOrderNumber(options[:po_number]) if options[:po_number] && transaction_type.start_with?("profileTrans")
+          xml.purchaseOrderNumber(options[:po_number]) if options[:po_number] && transaction_type.start_with?('profileTrans')
         end
 
         # Authorize.net API requires lineItems to be placed directly after order tag
@@ -697,9 +697,9 @@ module ActiveMerchant
             xml.email(options[:email]) unless empty?(options[:email])
 
             xml.paymentProfiles do
-              xml.customerType("individual")
+              xml.customerType('individual')
               add_billing_address(xml, credit_card, options)
-              add_shipping_address(xml, options, "shipToList")
+              add_shipping_address(xml, options, 'shipToList')
               xml.payment do
                 xml.creditCard do
                   xml.cardNumber(truncate(credit_card.number, 16))
@@ -728,7 +728,7 @@ module ActiveMerchant
       end
 
       def state_from(address, options)
-        if ["US", "CA"].include?(address[:country])
+        if ['US', 'CA'].include?(address[:country])
           address[:state] || 'NC'
         else
           address[:state] || 'n/a'
@@ -759,7 +759,7 @@ module ActiveMerchant
         avs_result = AVSResult.new(code: STANDARD_AVS_CODE_MAPPING[avs_result_code])
         cvv_result = CVVResult.new(response[:card_code])
         if using_live_gateway_in_test_mode?(response)
-          Response.new(false, "Using a live Authorize.net account in Test Mode is not permitted.")
+          Response.new(false, 'Using a live Authorize.net account in Test Mode is not permitted.')
         else
           Response.new(
             success_from(action, response),
@@ -776,7 +776,7 @@ module ActiveMerchant
       end
 
       def is_cim_action?(action)
-        action.to_s.start_with?("cim")
+        action.to_s.start_with?('cim')
       end
 
       def post_data(action)
@@ -790,17 +790,17 @@ module ActiveMerchant
 
       def root_for(action)
         if action == :cim_store
-          "createCustomerProfileRequest"
+          'createCustomerProfileRequest'
         elsif action == :cim_store_update
-          "createCustomerPaymentProfileRequest"
+          'createCustomerPaymentProfileRequest'
         elsif action == :cim_store_delete_customer
-          "deleteCustomerProfileRequest"
+          'deleteCustomerProfileRequest'
         elsif action == :verify_credentials
-          "authenticateTestRequest"
+          'authenticateTestRequest'
         elsif is_cim_action?(action)
-          "createCustomerProfileTransactionRequest"
+          'createCustomerProfileTransactionRequest'
         else
-          "createTransactionRequest"
+          'createTransactionRequest'
         end
       end
 
@@ -817,49 +817,49 @@ module ActiveMerchant
 
         response = {action: action}
 
-        response[:response_code] = if(element = doc.at_xpath("//transactionResponse/responseCode"))
+        response[:response_code] = if(element = doc.at_xpath('//transactionResponse/responseCode'))
           (empty?(element.content) ? nil : element.content.to_i)
         end
 
-        if(element = doc.at_xpath("//errors/error"))
-          response[:response_reason_code] = element.at_xpath("errorCode").content[/0*(\d+)$/, 1]
-          response[:response_reason_text] = element.at_xpath("errorText").content.chomp('.')
-        elsif(element = doc.at_xpath("//transactionResponse/messages/message"))
-          response[:response_reason_code] = element.at_xpath("code").content[/0*(\d+)$/, 1]
-          response[:response_reason_text] = element.at_xpath("description").content.chomp('.')
-        elsif(element = doc.at_xpath("//messages/message"))
-          response[:response_reason_code] = element.at_xpath("code").content[/0*(\d+)$/, 1]
-          response[:response_reason_text] = element.at_xpath("text").content.chomp('.')
+        if(element = doc.at_xpath('//errors/error'))
+          response[:response_reason_code] = element.at_xpath('errorCode').content[/0*(\d+)$/, 1]
+          response[:response_reason_text] = element.at_xpath('errorText').content.chomp('.')
+        elsif(element = doc.at_xpath('//transactionResponse/messages/message'))
+          response[:response_reason_code] = element.at_xpath('code').content[/0*(\d+)$/, 1]
+          response[:response_reason_text] = element.at_xpath('description').content.chomp('.')
+        elsif(element = doc.at_xpath('//messages/message'))
+          response[:response_reason_code] = element.at_xpath('code').content[/0*(\d+)$/, 1]
+          response[:response_reason_text] = element.at_xpath('text').content.chomp('.')
         else
           response[:response_reason_code] = nil
-          response[:response_reason_text] = ""
+          response[:response_reason_text] = ''
         end
 
-        response[:avs_result_code] = if(element = doc.at_xpath("//avsResultCode"))
+        response[:avs_result_code] = if(element = doc.at_xpath('//avsResultCode'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:transaction_id] = if(element = doc.at_xpath("//transId"))
+        response[:transaction_id] = if(element = doc.at_xpath('//transId'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:card_code] = if(element = doc.at_xpath("//cvvResultCode"))
+        response[:card_code] = if(element = doc.at_xpath('//cvvResultCode'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:authorization_code] = if(element = doc.at_xpath("//authCode"))
+        response[:authorization_code] = if(element = doc.at_xpath('//authCode'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:cardholder_authentication_code] = if(element = doc.at_xpath("//cavvResultCode"))
+        response[:cardholder_authentication_code] = if(element = doc.at_xpath('//cavvResultCode'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:account_number] = if(element = doc.at_xpath("//accountNumber"))
+        response[:account_number] = if(element = doc.at_xpath('//accountNumber'))
           (empty?(element.content) ? nil : element.content[-4..-1])
         end
 
-        response[:test_request] = if(element = doc.at_xpath("//testRequest"))
+        response[:test_request] = if(element = doc.at_xpath('//testRequest'))
           (empty?(element.content) ? nil : element.content)
         end
 
@@ -871,33 +871,33 @@ module ActiveMerchant
 
         doc = Nokogiri::XML(body).remove_namespaces!
 
-        if (element = doc.at_xpath("//messages/message"))
-          response[:message_code] = element.at_xpath("code").content[/0*(\d+)$/, 1]
-          response[:message_text] = element.at_xpath("text").content.chomp('.')
+        if (element = doc.at_xpath('//messages/message'))
+          response[:message_code] = element.at_xpath('code').content[/0*(\d+)$/, 1]
+          response[:message_text] = element.at_xpath('text').content.chomp('.')
         end
 
-        response[:result_code] = if(element = doc.at_xpath("//messages/resultCode"))
+        response[:result_code] = if(element = doc.at_xpath('//messages/resultCode'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:test_request] = if(element = doc.at_xpath("//testRequest"))
+        response[:test_request] = if(element = doc.at_xpath('//testRequest'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:customer_profile_id] = if(element = doc.at_xpath("//customerProfileId"))
+        response[:customer_profile_id] = if(element = doc.at_xpath('//customerProfileId'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:customer_payment_profile_id] = if(element = doc.at_xpath("//customerPaymentProfileIdList/numericString"))
+        response[:customer_payment_profile_id] = if(element = doc.at_xpath('//customerPaymentProfileIdList/numericString'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:customer_payment_profile_id] = if(element = doc.at_xpath("//customerPaymentProfileIdList/numericString") ||
-                                                              doc.at_xpath("//customerPaymentProfileId"))
+        response[:customer_payment_profile_id] = if(element = doc.at_xpath('//customerPaymentProfileIdList/numericString') ||
+                                                              doc.at_xpath('//customerPaymentProfileId'))
           (empty?(element.content) ? nil : element.content)
         end
 
-        response[:direct_response] = if(element = doc.at_xpath("//directResponse"))
+        response[:direct_response] = if(element = doc.at_xpath('//directResponse'))
           (empty?(element.content) ? nil : element.content)
         end
 
@@ -908,7 +908,7 @@ module ActiveMerchant
 
       def success_from(action, response)
         if cim?(action) || (action == :verify_credentials)
-          response[:result_code] == "Ok"
+          response[:result_code] == 'Ok'
         else
           [APPROVED, FRAUD_REVIEW].include?(response[:response_code]) && TRANSACTION_ALREADY_ACTIONED.exclude?(response[:response_reason_code])
         end
@@ -928,14 +928,14 @@ module ActiveMerchant
 
       def authorization_from(action, response)
         if cim?(action)
-          [response[:customer_profile_id], response[:customer_payment_profile_id], action].join("#")
+          [response[:customer_profile_id], response[:customer_payment_profile_id], action].join('#')
         else
-          [response[:transaction_id], response[:account_number], action].join("#")
+          [response[:transaction_id], response[:account_number], action].join('#')
         end
       end
 
       def split_authorization(authorization)
-        authorization.split("#")
+        authorization.split('#')
       end
 
       def cim?(action)
@@ -952,7 +952,7 @@ module ActiveMerchant
       end
 
       def using_live_gateway_in_test_mode?(response)
-        !test? && response[:test_request] == "1"
+        !test? && response[:test_request] == '1'
       end
 
       def map_error_code(response_code, response_reason_code)