activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/pay_hub.rb

@@ -19,32 +19,32 @@ module ActiveMerchant #:nodoc:
       }
 
       AVS_CODE_TRANSLATOR = {
-        '0' =>  "Approved, Address verification was not requested.",
-        'A' =>  "Approved, Address matches only.",
-        'B' =>  "Address Match. Street Address math for international transaction Postal Code not verified because of incompatible formats (Acquirer sent both street address and Postal Code)",
-        'C' =>  "Serv Unavailable. Street address and Postal Code not verified for international transaction because of incompatible formats (Acquirer sent both street and Postal Code).",
-        'D' =>  "Exact Match, Street Address and Postal Code match for international transaction.",
-        'F' =>  "Exact Match, Street Address and Postal Code match. Applies to UK only.",
-        'G' =>  "Ver Unavailable, Non-U.S. Issuer does not participate.",
-        'I' =>  "Ver Unavailable, Address information not verified for international transaction",
-        'M' =>  "Exact Match, Street Address and Postal Code match for international transaction",
-        'N' =>  "No - Address and ZIP Code does not match",
-        'P' =>  "Zip Match, Postal Codes match for international transaction Street address not verified because of incompatible formats (Acquirer sent both street address and Postal Code).",
-        'R' =>  "Retry - Issuer system unavailable",
-        'S' =>  "Serv Unavailable, Service not supported",
-        'U' =>  "Ver Unavailable, Address unavailable.",
-        'W' =>  "ZIP match - Nine character numeric ZIP match only.",
-        'X' =>  "Exact match, Address and nine-character ZIP match.",
-        'Y' =>  "Exact Match, Address and five character ZIP match.",
-        'Z' =>  "Zip Match, Five character numeric ZIP match only.",
-        '1' =>  "Cardholder name and ZIP match AMEX only.",
-        '2' =>  "Cardholder name, address, and ZIP match AMEX only.",
-        '3' =>  "Cardholder name and address match AMEX only.",
-        '4' =>  "Cardholder name match AMEX only.",
-        '5' =>  "Cardholder name incorrect, ZIP match AMEX only.",
-        '6' =>  "Cardholder name incorrect, address and ZIP match AMEX only.",
-        '7' =>  "Cardholder name incorrect, address match AMEX only.",
-        '8' =>  "Cardholder, all do not match AMEX only."
+        '0' =>  'Approved, Address verification was not requested.',
+        'A' =>  'Approved, Address matches only.',
+        'B' =>  'Address Match. Street Address math for international transaction Postal Code not verified because of incompatible formats (Acquirer sent both street address and Postal Code)',
+        'C' =>  'Serv Unavailable. Street address and Postal Code not verified for international transaction because of incompatible formats (Acquirer sent both street and Postal Code).',
+        'D' =>  'Exact Match, Street Address and Postal Code match for international transaction.',
+        'F' =>  'Exact Match, Street Address and Postal Code match. Applies to UK only.',
+        'G' =>  'Ver Unavailable, Non-U.S. Issuer does not participate.',
+        'I' =>  'Ver Unavailable, Address information not verified for international transaction',
+        'M' =>  'Exact Match, Street Address and Postal Code match for international transaction',
+        'N' =>  'No - Address and ZIP Code does not match',
+        'P' =>  'Zip Match, Postal Codes match for international transaction Street address not verified because of incompatible formats (Acquirer sent both street address and Postal Code).',
+        'R' =>  'Retry - Issuer system unavailable',
+        'S' =>  'Serv Unavailable, Service not supported',
+        'U' =>  'Ver Unavailable, Address unavailable.',
+        'W' =>  'ZIP match - Nine character numeric ZIP match only.',
+        'X' =>  'Exact match, Address and nine-character ZIP match.',
+        'Y' =>  'Exact Match, Address and five character ZIP match.',
+        'Z' =>  'Zip Match, Five character numeric ZIP match only.',
+        '1' =>  'Cardholder name and ZIP match AMEX only.',
+        '2' =>  'Cardholder name, address, and ZIP match AMEX only.',
+        '3' =>  'Cardholder name and address match AMEX only.',
+        '4' =>  'Cardholder name match AMEX only.',
+        '5' =>  'Cardholder name incorrect, ZIP match AMEX only.',
+        '6' =>  'Cardholder name incorrect, address and ZIP match AMEX only.',
+        '7' =>  'Cardholder name incorrect, address match AMEX only.',
+        '8' =>  'Cardholder, all do not match AMEX only.'
       }
 
       STANDARD_ERROR_CODE_MAPPING = {
@@ -173,7 +173,7 @@ module ActiveMerchant #:nodoc:
         begin
           raw_response = ssl_post(live_url, post.to_json, {'Content-Type' => 'application/json'} )
           response = parse(raw_response)
-          success = (response['RESPONSE_CODE'] == "00")
+          success = (response['RESPONSE_CODE'] == '00')
         rescue ResponseError => e
           raw_response = e.response.body
           response = response_error(raw_response)
@@ -200,13 +200,13 @@ module ActiveMerchant #:nodoc:
 
       def json_error(raw_response)
         {
-          error_message: "Invalid response received from the Payhub API.  Please contact wecare@payhub.com if you continue to receive this message." +
+          error_message: 'Invalid response received from the Payhub API.  Please contact wecare@payhub.com if you continue to receive this message.' +
             "  (The raw response returned by the API was #{raw_response.inspect})"
         }
       end
 
       def response_message(response)
-        (response['RESPONSE_TEXT'] || response["RESPONSE_CODE"] || response[:error_message])
+        (response['RESPONSE_TEXT'] || response['RESPONSE_CODE'] || response[:error_message])
       end
     end
   end

data/lib/active_merchant/billing/gateways/pay_junction.rb

@@ -101,19 +101,19 @@ module ActiveMerchant #:nodoc:
 
       class_attribute :test_url, :live_url
 
-      self.test_url = "https://www.payjunctionlabs.com/quick_link"
-      self.live_url = "https://payjunction.com/quick_link"
+      self.test_url = 'https://www.payjunctionlabs.com/quick_link'
+      self.live_url = 'https://payjunction.com/quick_link'
 
       TEST_LOGIN = 'pj-ql-01'
       TEST_PASSWORD = 'pj-ql-01p'
 
-      SUCCESS_CODES = ["00", "85"]
+      SUCCESS_CODES = ['00', '85']
       SUCCESS_MESSAGE = 'The transaction was approved.'
 
       FAILURE_MESSAGE = 'The transaction was declined.'
 
       DECLINE_CODES = {
-        "AE"  => 'Address verification failed because address did not match.',
+        'AE'  => 'Address verification failed because address did not match.',
         'ZE'  => 'Address verification failed because zip did not match.',
         'XE'  => 'Address verification failed because zip and address did not match.',
         'YE'  => 'Address verification failed because zip and address did not match.',
@@ -144,8 +144,8 @@ module ActiveMerchant #:nodoc:
         '96'  => 'Declined because of a system error.',
         'N7'  => 'Declined because of a CVV2/CVC2 mismatch.',
         'M4'  => 'Declined.',
-        "FE"  => "There was a format error with your Trinity Gateway Service (API) request.",
-        "LE"  => "Could not log you in (problem with dc_logon and/or dc_password).",
+        'FE'  => 'There was a format error with your Trinity Gateway Service (API) request.',
+        'LE'  => 'Could not log you in (problem with dc_logon and/or dc_password).',
         'NL'  => 'Aborted because of a system error, please try again later. ',
         'AB'  => 'Aborted because of an upstream system error, please try again later.'
       }
@@ -366,7 +366,7 @@ module ActiveMerchant #:nodoc:
         params[:version] = API_VERSION
         params[:transaction_type] = action
 
-        params.reject{|k,v| v.blank?}.collect{ |k, v| "dc_#{k.to_s}=#{CGI.escape(v.to_s)}" }.join("&")
+        params.reject{|k,v| v.blank?}.collect{ |k, v| "dc_#{k.to_s}=#{CGI.escape(v.to_s)}" }.join('&')
       end
 
       def parse(body)

data/lib/active_merchant/billing/gateways/pay_junction_v2.rb

@@ -1,14 +1,14 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PayJunctionV2Gateway < Gateway
-      self.display_name = "PayJunction"
-      self.homepage_url = "https://www.payjunction.com/"
+      self.display_name = 'PayJunction'
+      self.homepage_url = 'https://www.payjunction.com/'
 
-      self.test_url = "https://api.payjunctionlabs.com/transactions"
-      self.live_url = "https://api.payjunction.com/transactions"
+      self.test_url = 'https://api.payjunctionlabs.com/transactions'
+      self.live_url = 'https://api.payjunction.com/transactions'
 
-      self.supported_countries = ["US"]
-      self.default_currency = "USD"
+      self.supported_countries = ['US']
+      self.default_currency = 'USD'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
 
@@ -22,51 +22,51 @@ module ActiveMerchant #:nodoc:
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
 
-        commit("purchase", post)
+        commit('purchase', post)
       end
 
       def authorize(amount, payment_method, options={})
         post = {}
-        post[:status] = "HOLD"
+        post[:status] = 'HOLD'
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
 
-        commit("authorize", post)
+        commit('authorize', post)
       end
 
       def capture(amount, authorization, options={})
         post = {}
-        post[:status] = "CAPTURE"
+        post[:status] = 'CAPTURE'
         post[:transactionId] = authorization
         add_invoice(post, amount, options)
 
-        commit("capture", post)
+        commit('capture', post)
       end
 
       def void(authorization, options={})
         post = {}
-        post[:status] = "VOID"
+        post[:status] = 'VOID'
         post[:transactionId] = authorization
 
-        commit("void", post)
+        commit('void', post)
       end
 
       def refund(amount, authorization, options={})
         post = {}
-        post[:action] = "REFUND"
+        post[:action] = 'REFUND'
         post[:transactionId] = authorization
         add_invoice(post, amount, options)
 
-        commit("refund", post)
+        commit('refund', post)
       end
 
       def credit(amount, payment_method, options={})
         post = {}
-        post[:action] = "REFUND"
+        post[:action] = 'REFUND'
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
 
-        commit("credit", post)
+        commit('credit', post)
       end
 
       def verify(credit_card, options={})
@@ -129,7 +129,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def ssl_invoke(action, params)
-        if ["purchase", "authorize", "refund", "credit"].include?(action)
+        if ['purchase', 'authorize', 'refund', 'credit'].include?(action)
           ssl_post(url(), post_data(params), headers)
         else
           ssl_request(:put, url(params), post_data(params), headers)
@@ -138,10 +138,10 @@ module ActiveMerchant #:nodoc:
 
       def headers
         {
-          "Authorization" => "Basic " + Base64.encode64("#{@options[:api_login]}:#{@options[:api_password]}").strip,
-          "Content-Type"  => "application/x-www-form-urlencoded;charset=UTF-8",
-          "Accept"  => "application/json",
-          "X-PJ-Application-Key"  => "#{@options[:api_key]}"
+          'Authorization' => 'Basic ' + Base64.encode64("#{@options[:api_login]}:#{@options[:api_password]}").strip,
+          'Content-Type'  => 'application/x-www-form-urlencoded;charset=UTF-8',
+          'Accept'  => 'application/json',
+          'X-PJ-Application-Key'  => "#{@options[:api_key]}"
         }
       end
 
@@ -157,33 +157,33 @@ module ActiveMerchant #:nodoc:
         begin
           JSON.parse(body)
         rescue JSON::ParserError
-          message = "Invalid JSON response received from PayJunctionV2Gateway. Please contact PayJunctionV2Gateway if you continue to receive this message."
+          message = 'Invalid JSON response received from PayJunctionV2Gateway. Please contact PayJunctionV2Gateway if you continue to receive this message.'
           message += " (The raw response returned by the API was #{body.inspect})"
           {
-            "errors" => [{
-              "message" => message
+            'errors' => [{
+              'message' => message
             }]
           }
         end
       end
 
       def success_from(response)
-        return response["response"]["approved"] if response["response"]
+        return response['response']['approved'] if response['response']
         false
       end
 
       def message_from(response)
-        return response["response"]["message"] if response["response"]
+        return response['response']['message'] if response['response']
 
-        response["errors"].inject(""){ |message,error| error["message"] + "|" + message } if response["errors"]
+        response['errors'].inject(''){ |message,error| error['message'] + '|' + message } if response['errors']
       end
 
       def authorization_from(response)
-        response["transactionId"]
+        response['transactionId']
       end
 
       def error_from(response)
-        response["response"]["code"] if response["response"]
+        response['response']['code'] if response['response']
       end
     end
   end

data/lib/active_merchant/billing/gateways/pay_secure.rb

@@ -41,7 +41,7 @@ module ActiveMerchant #:nodoc:
       private
       # Used for capturing, which is currently not supported.
       def add_reference(post, identification)
-        auth, trans_id = identification.split(";")
+        auth, trans_id = identification.split(';')
         post[:authnum]    = auth
         post[:transid] = trans_id
       end
@@ -79,7 +79,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_from(response)
-        [ response[:authnum], response[:transid] ].compact.join(";")
+        [ response[:authnum], response[:transid] ].compact.join(';')
       end
 
       def test_response?(response)
@@ -93,7 +93,7 @@ module ActiveMerchant #:nodoc:
       def parse(body)
         response = {}
         body.to_s.each_line do |l|
-          key, value = l.split(":", 2)
+          key, value = l.split(':', 2)
           response[key.to_s.downcase.to_sym] = value.strip
         end
         response
@@ -104,7 +104,7 @@ module ActiveMerchant #:nodoc:
         parameters[:merchant_id]      = @options[:login]
         parameters[:password]         = @options[:password]
 
-        parameters.reject{|k,v| v.blank?}.collect { |key, value| "#{key.to_s.upcase}=#{CGI.escape(value.to_s)}" }.join("&")
+        parameters.reject{|k,v| v.blank?}.collect { |key, value| "#{key.to_s.upcase}=#{CGI.escape(value.to_s)}" }.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/paybox_direct.rb

@@ -21,20 +21,20 @@ module ActiveMerchant #:nodoc:
       }
 
       CURRENCY_CODES = {
-        "AUD"=> '036',
-        "CAD"=> '124',
-        "CZK"=> '203',
-        "DKK"=> '208',
-        "HKD"=> '344',
-        "ICK"=> '352',
-        "JPY"=> '392',
-        "NOK"=> '578',
-        "SGD"=> '702',
-        "SEK"=> '752',
-        "CHF"=> '756',
-        "GBP"=> '826',
-        "USD"=> '840',
-        "EUR"=> '978'
+        'AUD'=> '036',
+        'CAD'=> '124',
+        'CZK'=> '203',
+        'DKK'=> '208',
+        'HKD'=> '344',
+        'ICK'=> '352',
+        'JPY'=> '392',
+        'NOK'=> '578',
+        'SGD'=> '702',
+        'SEK'=> '752',
+        'CHF'=> '756',
+        'GBP'=> '826',
+        'USD'=> '840',
+        'EUR'=> '978'
       }
 
       SUCCESS_CODES = ['00000']
@@ -187,7 +187,7 @@ module ActiveMerchant #:nodoc:
           :archivage => parameters[:order_id]
         )
 
-        parameters.collect { |key, value| "#{key.to_s.upcase}=#{CGI.escape(value.to_s)}" }.join("&")
+        parameters.collect { |key, value| "#{key.to_s.upcase}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def unique_id(seed = 0)

data/lib/active_merchant/billing/gateways/payeezy.rb

@@ -159,8 +159,8 @@ module ActiveMerchant
       def add_echeck(params, echeck, options)
         tele_check = {}
 
-        tele_check[:check_number] = echeck.number || "001"
-        tele_check[:check_type] = "P"
+        tele_check[:check_number] = echeck.number || '001'
+        tele_check[:check_type] = 'P'
         tele_check[:routing_number] = echeck.routing_number
         tele_check[:account_number] = echeck.account_number
         tele_check[:accountholder_name] = "#{echeck.first_name} #{echeck.last_name}"
@@ -281,7 +281,7 @@ module ActiveMerchant
 
       def post_data(params)
         return nil unless params
-        params.reject { |k, v| v.blank? }.collect { |k, v| "#{k}=#{CGI.escape(v.to_s)}" }.join("&")
+        params.reject { |k, v| v.blank? }.collect { |k, v| "#{k}=#{CGI.escape(v.to_s)}" }.join('&')
       end
 
       def generate_hmac(nonce, current_timestamp, payload)
@@ -291,7 +291,7 @@ module ActiveMerchant
           current_timestamp.to_s,
           @options[:token],
           payload
-        ].join("")
+        ].join('')
         hash = Base64.strict_encode64(OpenSSL::HMAC.hexdigest('sha256', @options[:apisecret], message))
         hash
       end
@@ -379,7 +379,7 @@ module ActiveMerchant
       end
 
       def json_error(raw_response)
-        {"error" => "Unable to parse response: #{raw_response.inspect}"}
+        {'error' => "Unable to parse response: #{raw_response.inspect}"}
       end
     end
   end

data/lib/active_merchant/billing/gateways/payex.rb

@@ -1,4 +1,4 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -16,7 +16,7 @@ module ActiveMerchant #:nodoc:
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
       self.homepage_url = 'http://payex.com/'
       self.display_name = 'Payex'
-      self.default_currency = "EUR"
+      self.default_currency = 'EUR'
 
       TRANSACTION_STATUS = {
         sale:       '0',
@@ -360,11 +360,11 @@ module ActiveMerchant #:nodoc:
         response = {}
 
         xmldoc = Nokogiri::XML(xml)
-        body = xmldoc.xpath("//soap:Body/*[1]")[0].inner_text
+        body = xmldoc.xpath('//soap:Body/*[1]')[0].inner_text
 
         doc = Nokogiri::XML(body)
 
-        doc.root.xpath("*").each do |node|
+        doc.root.xpath('*').each do |node|
           if (node.elements.size == 0)
             response[node.name.downcase.to_sym] = node.text
           else

data/lib/active_merchant/billing/gateways/payflow.rb

@@ -56,8 +56,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def verify_credentials
-        response = void("0")
-        response.params["result"] != "26"
+        response = void('0')
+        response.params['result'] != '26'
       end
 
       # Adds or modifies a recurring Payflow profile.  See the Payflow Pro Recurring Billing Guide for more details:
@@ -252,8 +252,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def expdate(creditcard)
-        year  = sprintf("%.4i", creditcard.year.to_s.sub(/^0+/, ''))
-        month = sprintf("%.2i", creditcard.month.to_s.sub(/^0+/, ''))
+        year  = sprintf('%.4i', creditcard.year.to_s.sub(/^0+/, ''))
+        month = sprintf('%.2i', creditcard.month.to_s.sub(/^0+/, ''))
 
         "#{year}#{month}"
       end
@@ -309,10 +309,10 @@ module ActiveMerchant #:nodoc:
                 end
               end
               if action != :add
-                xml.tag! "ProfileID", options[:profile_id]
+                xml.tag! 'ProfileID', options[:profile_id]
               end
               if action == :inquiry
-                xml.tag! "PaymentHistory", ( options[:history] ? 'Y' : 'N' )
+                xml.tag! 'PaymentHistory', ( options[:history] ? 'Y' : 'N' )
               end
             end
           end
@@ -335,7 +335,7 @@ module ActiveMerchant #:nodoc:
 
       def format_rp_date(time)
         case time
-          when Time, Date then time.strftime("%m%d%Y")
+          when Time, Date then time.strftime('%m%d%Y')
         else
           time.to_s
         end