activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/orbital/orbital_soft_descriptors.rb

@@ -27,16 +27,16 @@ module ActiveMerchant #:nodoc:
       def validate
         errors = []
 
-        errors << [:merchant_name, "is required"] if self.merchant_name.blank?
-        errors << [:merchant_name, "is required to be 25 bytes or less"] if self.merchant_name.bytesize > 25
+        errors << [:merchant_name, 'is required'] if self.merchant_name.blank?
+        errors << [:merchant_name, 'is required to be 25 bytes or less'] if self.merchant_name.bytesize > 25
 
         if(!empty?(self.merchant_phone) && !self.merchant_phone.match(PHONE_FORMAT_1) && !self.merchant_phone.match(PHONE_FORMAT_2))
-          errors << [:merchant_phone, "is required to follow \"NNN-NNN-NNNN\" or \"NNN-AAAAAAA\" format"]
+          errors << [:merchant_phone, 'is required to follow "NNN-NNN-NNNN" or "NNN-AAAAAAA" format']
         end
 
         [:merchant_email, :merchant_url].each do |attr|
           unless self.send(attr).blank?
-            errors << [attr, "is required to be 13 bytes or less"] if(self.send(attr).bytesize > 13)
+            errors << [attr, 'is required to be 13 bytes or less'] if(self.send(attr).bytesize > 13)
           end
         end
 

data/lib/active_merchant/billing/gateways/pac_net_raven.rb

@@ -159,11 +159,11 @@ module ActiveMerchant #:nodoc:
         return response['Message'] if response['Message']
 
         if response['Status'] == 'Approved'
-          "This transaction has been approved"
+          'This transaction has been approved'
         elsif response['Status'] == 'Declined'
-          "This transaction has been declined"
+          'This transaction has been declined'
         elsif response['Status'] == 'Voided'
-          "This transaction has been voided"
+          'This transaction has been voided'
         else
           response['Status']
         end
@@ -179,12 +179,12 @@ module ActiveMerchant #:nodoc:
         post['RequestID']     = request_id
         post['Signature']     = signature(action, post, parameters)
 
-        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        request = post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
         request
       end
 
       def timestamp
-        Time.now.strftime("%Y-%m-%dT%H:%M:%S.Z")
+        Time.now.strftime('%Y-%m-%dT%H:%M:%S.Z')
       end
 
       def request_id

data/lib/active_merchant/billing/gateways/pagarme.rb

@@ -132,18 +132,18 @@ module ActiveMerchant #:nodoc:
             end
             post_data(h)
           elsif value.is_a?(Array)
-            value.map { |v| "#{key}[]=#{CGI.escape(v.to_s)}" }.join("&")
+            value.map { |v| "#{key}[]=#{CGI.escape(v.to_s)}" }.join('&')
           else
             "#{key}=#{CGI.escape(value.to_s)}"
           end
-        end.compact.join("&")
+        end.compact.join('&')
       end
 
       def headers(options = {})
         {
-          "Authorization" => "Basic " + Base64.encode64(@api_key.to_s + ":x").strip,
-          "User-Agent" => "Pagar.me/1 ActiveMerchant/#{ActiveMerchant::VERSION}",
-          "Accept-Encoding" => "deflate"
+          'Authorization' => 'Basic ' + Base64.encode64(@api_key.to_s + ':x').strip,
+          'User-Agent' => "Pagar.me/1 ActiveMerchant/#{ActiveMerchant::VERSION}",
+          'Accept-Encoding' => 'deflate'
         }
       end
 
@@ -186,61 +186,61 @@ module ActiveMerchant #:nodoc:
 		  msg = 'Resposta inválida retornada pela API do Pagar.me. Por favor entre em contato com suporte@pagar.me se você continuar recebendo essa mensagem.'
         msg += "  (A resposta retornada pela API foi #{raw_response.inspect})"
         {
-          "errors" => [{
-            "message" => msg
+          'errors' => [{
+            'message' => msg
           }]
         }
       end
 
       def success_from(response)
-        success_purchase = response.key?("status") && response["status"] == "paid"
-        success_authorize = response.key?("status") && response["status"] == "authorized"
-        success_refund = response.key?("status") && response["status"] == "refunded"
+        success_purchase = response.key?('status') && response['status'] == 'paid'
+        success_authorize = response.key?('status') && response['status'] == 'authorized'
+        success_refund = response.key?('status') && response['status'] == 'refunded'
 
         success_purchase || success_authorize || success_refund
       end
 
       def failure_from(response)
-        response.key?("status") && response["status"] == "refused"
+        response.key?('status') && response['status'] == 'refused'
       end
 
       def message_from(response)
         if success_from(response)
-          case response["status"]
-          when "paid"
-            "Transação aprovada"
-          when "authorized"
-            "Transação autorizada"
-          when "refunded"
-            "Transação estornada"
+          case response['status']
+          when 'paid'
+            'Transação aprovada'
+          when 'authorized'
+            'Transação autorizada'
+          when 'refunded'
+            'Transação estornada'
           else
             "Transação com status '#{response["status"]}'"
           end
         elsif failure_from(response)
-          "Transação recusada"
-        elsif response.key?("errors")
-          response["errors"][0]["message"]
+          'Transação recusada'
+        elsif response.key?('errors')
+          response['errors'][0]['message']
         else
           msg = json_error(response)
-          msg["errors"][0]["message"]
+          msg['errors'][0]['message']
         end
       end
 
       def authorization_from(response)
         if success_from(response)
-          response["id"]
+          response['id']
         end
       end
 
       def test?()
-        @api_key.start_with?("ak_test")
+        @api_key.start_with?('ak_test')
       end
 
       def error_code_from(response)
         if failure_from(response)
-          STANDARD_ERROR_CODE_MAPPING["refused"]
-        elsif response.key?("errors")
-          STANDARD_ERROR_CODE_MAPPING["processing_error"]
+          STANDARD_ERROR_CODE_MAPPING['refused']
+        elsif response.key?('errors')
+          STANDARD_ERROR_CODE_MAPPING['processing_error']
         end
       end
     end

data/lib/active_merchant/billing/gateways/pago_facil.rb

@@ -63,7 +63,7 @@ module ActiveMerchant #:nodoc:
         post[:apellidos] = credit_card.last_name
         post[:numeroTarjeta] = credit_card.number
         post[:cvt] = credit_card.verification_value
-        post[:mesExpiracion] = sprintf("%02d", credit_card.month)
+        post[:mesExpiracion] = sprintf('%02d', credit_card.month)
         post[:anyoExpiracion] = credit_card.year.to_s.slice(-2, 2)
       end
 
@@ -74,7 +74,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(body)
-        JSON.parse(body)["WebServices_Transacciones"]["transaccion"]
+        JSON.parse(body)['WebServices_Transacciones']['transaccion']
       rescue JSON::ParserError
         json_error(body)
       end
@@ -92,16 +92,16 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response["autorizado"] == "1" ||
-          response["autorizado"] == true
+        response['autorizado'] == '1' ||
+          response['autorizado'] == true
       end
 
       def message_from(response)
-        response["texto"]
+        response['texto']
       end
 
       def authorization_from(response)
-        response["autorizacion"]
+        response['autorizacion']
       end
 
       def post_data(parameters = {})
@@ -113,8 +113,8 @@ module ActiveMerchant #:nodoc:
 
       def json_error(response)
         {
-          "texto" => 'Invalid response received from the PagoFacil API.',
-          "raw_response" => response
+          'texto' => 'Invalid response received from the PagoFacil API.',
+          'raw_response' => response
         }
       end
     end

data/lib/active_merchant/billing/gateways/pay_conex.rb

@@ -3,15 +3,15 @@ module ActiveMerchant #:nodoc:
     class PayConexGateway < Gateway
       include Empty
 
-      self.test_url = "https://cert.payconex.net/api/qsapi/3.8/"
-      self.live_url = "https://secure.payconex.net/api/qsapi/3.8/"
+      self.test_url = 'https://cert.payconex.net/api/qsapi/3.8/'
+      self.live_url = 'https://secure.payconex.net/api/qsapi/3.8/'
 
       self.supported_countries = %w(US CA)
-      self.default_currency = "USD"
+      self.default_currency = 'USD'
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners_club]
 
-      self.homepage_url = "http://www.bluefincommerce.com/"
-      self.display_name = "PayConex"
+      self.homepage_url = 'http://www.bluefincommerce.com/'
+      self.display_name = 'PayConex'
 
       def initialize(options={})
         requires!(options, :account_id, :api_accesskey)
@@ -21,43 +21,43 @@ module ActiveMerchant #:nodoc:
       def purchase(money, payment_method, options={})
         post = {}
         add_auth_purchase_params(post, money, payment_method, options)
-        commit("SALE", post)
+        commit('SALE', post)
       end
 
       def authorize(money, payment_method, options={})
         post = {}
         add_auth_purchase_params(post, money, payment_method, options)
-        commit("AUTHORIZATION", post)
+        commit('AUTHORIZATION', post)
       end
 
       def capture(money, authorization, options={})
         post = {}
         add_reference_params(post, authorization, options)
         add_amount(post, money, options)
-        commit("CAPTURE", post)
+        commit('CAPTURE', post)
       end
 
       def refund(money, authorization, options={})
         post = {}
         add_reference_params(post, authorization, options)
         add_amount(post, money, options)
-        commit("REFUND", post)
+        commit('REFUND', post)
       end
 
       def void(authorization, options = {})
         post = {}
         add_reference_params(post, authorization, options)
-        commit("REVERSAL", post)
+        commit('REVERSAL', post)
       end
 
       def credit(money, payment_method, options={})
         if payment_method.is_a?(String)
-          raise ArgumentError, "Reference credits are not supported. Please supply the original credit card or use the #refund method."
+          raise ArgumentError, 'Reference credits are not supported. Please supply the original credit card or use the #refund method.'
         end
 
         post = {}
         add_auth_purchase_params(post, money, payment_method, options)
-        commit("CREDIT", post)
+        commit('CREDIT', post)
       end
 
       def verify(payment_method, options={})
@@ -70,7 +70,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method)
         add_address(post, options)
         add_common_options(post, options)
-        commit("STORE", post)
+        commit('STORE', post)
       end
 
       def supports_scrubbing?
@@ -88,8 +88,8 @@ module ActiveMerchant #:nodoc:
 
       def force_utf8(string)
         return nil unless string
-        binary = string.encode("BINARY", invalid: :replace, undef: :replace, replace: "?")   # Needed for Ruby 2.0 since #encode is a no-op if the string is already UTF-8. It's not needed for Ruby 2.1 and up since it's not a no-op there.
-        binary.encode("UTF-8", invalid: :replace, undef: :replace, replace: "?")
+        binary = string.encode('BINARY', invalid: :replace, undef: :replace, replace: '?')   # Needed for Ruby 2.0 since #encode is a no-op if the string is already UTF-8. It's not needed for Ruby 2.1 and up since it's not a no-op there.
+        binary.encode('UTF-8', invalid: :replace, undef: :replace, replace: '?')
       end
 
       def add_credentials(post)
@@ -134,7 +134,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credit_card(post, payment_method)
-        post[:tender_type] = "CARD"
+        post[:tender_type] = 'CARD'
         post[:card_number] = payment_method.number
         post[:card_expiration] = expdate(payment_method)
         post[:card_verification] = payment_method.verification_value
@@ -143,18 +143,18 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_token_payment_method(post, payment_method)
-        post[:tender_type] = "CARD"
+        post[:tender_type] = 'CARD'
         post[:token_id] = payment_method
         post[:reissue] = true
       end
 
       def add_card_present_payment_method(post, payment_method)
-        post[:tender_type] = "CARD"
+        post[:tender_type] = 'CARD'
         post[:card_tracks] = payment_method.track_data
       end
 
       def add_check(post, payment_method)
-        post[:tender_type] = "ACH"
+        post[:tender_type] = 'ACH'
         post[:first_name] = payment_method.first_name
         post[:last_name] = payment_method.last_name
         post[:bank_account_number] = payment_method.account_number
@@ -208,9 +208,9 @@ module ActiveMerchant #:nodoc:
           success_from(response),
           message_from(response),
           response,
-          authorization: response["transaction_id"],
-          :avs_result => AVSResult.new(code: response["avs_response"]),
-          :cvv_result => CVVResult.new(response["cvv2_response"]),
+          authorization: response['transaction_id'],
+          :avs_result => AVSResult.new(code: response['avs_response']),
+          :cvv_result => CVVResult.new(response['cvv2_response']),
           test: test?
         )
 
@@ -223,11 +223,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response["transaction_approved"] || !response["error"]
+        response['transaction_approved'] || !response['error']
       end
 
       def message_from(response)
-        success_from(response) ? response["authorization_message"] : response["error_message"]
+        success_from(response) ? response['authorization_message'] : response['error_message']
       end
 
       def post_data(action, params)
@@ -236,7 +236,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def unparsable_response(raw_response)
-        message = "Invalid JSON response received from PayConex. Please contact PayConex if you continue to receive this message."
+        message = 'Invalid JSON response received from PayConex. Please contact PayConex if you continue to receive this message.'
         message += " (The raw response returned by the API was #{raw_response.inspect})"
         return Response.new(false, message)
       end

data/lib/active_merchant/billing/gateways/pay_gate_xml.rb

@@ -102,45 +102,45 @@ module ActiveMerchant #:nodoc:
 
       DECLINE_CODES = {
         # Credit Card Errors - These RESULT_CODEs are returned if the transaction cannot be authorized due to a problem with the card.  The TRANSACTION_STATUS will be 2
-        900001  => "Call for Approval",
-        900002  => "Card Expired",
-        900003  => "Insufficient Funds",
-        900004  => "Invalid Card Number",
-        900005  => "Bank Interface Timeout",  # indicates a communications failure between the banks systems
-        900006  => "Invalid Card",
-        900007  => "Declined",
-        900009  => "Lost Card",
-        900010  => "Invalid Card Length",
-        900011  => "Suspected Fraud",
-        900012  => "Card Reported As Stolen",
-        900013  => "Restricted Card",
-        900014  => "Excessive Card Usage",
-        900015  => "Card Blacklisted",
-
-        900207  => "Declined; authentication failed",  # indicates the cardholder did not enter their MasterCard SecureCode / Verified by Visa password correctly
-
-        990020  => "Auth Declined",
-
-        991001  => "Invalid expiry date",
-        991002  => "Invalid amount",
+        900001  => 'Call for Approval',
+        900002  => 'Card Expired',
+        900003  => 'Insufficient Funds',
+        900004  => 'Invalid Card Number',
+        900005  => 'Bank Interface Timeout',  # indicates a communications failure between the banks systems
+        900006  => 'Invalid Card',
+        900007  => 'Declined',
+        900009  => 'Lost Card',
+        900010  => 'Invalid Card Length',
+        900011  => 'Suspected Fraud',
+        900012  => 'Card Reported As Stolen',
+        900013  => 'Restricted Card',
+        900014  => 'Excessive Card Usage',
+        900015  => 'Card Blacklisted',
+
+        900207  => 'Declined; authentication failed',  # indicates the cardholder did not enter their MasterCard SecureCode / Verified by Visa password correctly
+
+        990020  => 'Auth Declined',
+
+        991001  => 'Invalid expiry date',
+        991002  => 'Invalid amount',
 
         # Communication Errors - These RESULT_CODEs are returned if the transaction cannot be completed due to an unexpected error.  TRANSACTION_STATUS will be 0.
-        900205  => "Unexpected authentication result (phase 1)",
-        900206  => "Unexpected authentication result (phase 1)",
+        900205  => 'Unexpected authentication result (phase 1)',
+        900206  => 'Unexpected authentication result (phase 1)',
 
-        990001  => "Could not insert into Database",
+        990001  => 'Could not insert into Database',
 
-        990022  => "Bank not available",
+        990022  => 'Bank not available',
 
-        990053  => "Error processing transaction",
+        990053  => 'Error processing transaction',
 
         # Miscellaneous - Unless otherwise noted, the TRANSACTION_STATUS will be 0.
-        900209  => "Transaction verification failed (phase 2)",  # Indicates the verification data returned from MasterCard SecureCode / Verified by Visa has been altered
-        900210  => "Authentication complete; transaction must be restarted",  # Indicates that the MasterCard SecuerCode / Verified by Visa transaction has already been completed.  Most likely caused by the customer clicking the refresh button
+        900209  => 'Transaction verification failed (phase 2)',  # Indicates the verification data returned from MasterCard SecureCode / Verified by Visa has been altered
+        900210  => 'Authentication complete; transaction must be restarted',  # Indicates that the MasterCard SecuerCode / Verified by Visa transaction has already been completed.  Most likely caused by the customer clicking the refresh button
 
-        990024  => "Duplicate Transaction Detected.  Please check before submitting",
+        990024  => 'Duplicate Transaction Detected.  Please check before submitting',
 
-        990028  => "Transaction cancelled"  # Customer clicks the 'Cancel' button on the payment page
+        990028  => 'Transaction cancelled'  # Customer clicks the 'Cancel' button on the payment page
       }
 
       SUCCESS_CODES = %w( 990004 990005 990017 990012 990018 990031 )
@@ -210,7 +210,7 @@ module ActiveMerchant #:nodoc:
           when 'refundtx'
             build_refund(protocol, money, authorization, options)
           else
-            raise "no action specified for build_request"
+            raise 'no action specified for build_request'
           end
         end
 
@@ -265,7 +265,7 @@ module ActiveMerchant #:nodoc:
         response = parse(action, ssl_post(self.live_url, request))
         Response.new(successful?(response), message_from(response), response,
           :test           => test?,
-          :authorization  => authorization ? authorization : response[:tid]
+          :authorization  => authorization || response[:tid]
         )
       end