activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/psigate.rb

@@ -35,8 +35,8 @@ module ActiveMerchant #:nodoc:
     #   :email => 'jack@yahoo.com'
     # )
     class PsigateGateway < Gateway
-      self.test_url  = 'https://staging.psigate.com:17989/Messenger/XMLMessenger'
-      self.live_url  = 'https://secure.psigate.com:17934/Messenger/XMLMessenger'
+      self.test_url  = 'https://realtimestaging.psigate.com/xml'
+      self.live_url  = 'https://realtime.psigate.com/xml'
 
       self.supported_cardtypes = [:visa, :master, :american_express]
       self.supported_countries = ['CA']
@@ -53,18 +53,18 @@ module ActiveMerchant #:nodoc:
 
       def authorize(money, creditcard, options = {})
         requires!(options, :order_id)
-        options[:CardAction] = "1"
+        options[:CardAction] = '1'
         commit(money, creditcard, options)
       end
 
       def purchase(money, creditcard, options = {})
         requires!(options, :order_id)
-        options[:CardAction] = "0"
+        options[:CardAction] = '0'
         commit(money, creditcard, options)
       end
 
       def capture(money, authorization, options = {})
-        options[:CardAction] = "2"
+        options[:CardAction] = '2'
         options[:order_id], options[:trans_ref_number] = split_authorization(authorization)
         commit(money, nil, options)
       end
@@ -75,13 +75,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def refund(money, authorization, options = {})
-        options[:CardAction] = "3"
+        options[:CardAction] = '3'
         options[:order_id], options[:trans_ref_number] = split_authorization(authorization)
         commit(money, nil, options)
       end
 
       def void(authorization, options = {})
-        options[:CardAction] = "9"
+        options[:CardAction] = '9'
         options[:order_id], options[:trans_ref_number] = split_authorization(authorization)
         commit(nil, nil, options)
       end
@@ -115,11 +115,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def successful?(response)
-        response[:approved] == "APPROVED"
+        response[:approved] == 'APPROVED'
       end
 
       def parse(xml)
-        response = {:message => "Global Error Receipt", :complete => false}
+        response = {:message => 'Global Error Receipt', :complete => false}
 
         xml = REXML::Document.new(xml)
         xml.elements.each('//Result/*') do |node|
@@ -132,7 +132,7 @@ module ActiveMerchant #:nodoc:
       def post_data(money, creditcard, options)
         xml = REXML::Document.new
         xml << REXML::XMLDecl.new
-        root = xml.add_element("Order")
+        root = xml.add_element('Order')
 
         parameters(money, creditcard, options).each do |key, value|
           root.add_element(key.to_s).text = value if value
@@ -155,7 +155,7 @@ module ActiveMerchant #:nodoc:
           :TransRefNumber => options[:trans_ref_number],
 
           # Credit Card parameters
-          :PaymentType => "CC",
+          :PaymentType => 'CC',
           :CardAction => options[:CardAction],
 
           # Financial parameters
@@ -167,9 +167,9 @@ module ActiveMerchant #:nodoc:
         }
 
         if creditcard
-          exp_month = sprintf("%.2i", creditcard.month) unless creditcard.month.blank?
+          exp_month = sprintf('%.2i', creditcard.month) unless creditcard.month.blank?
           exp_year = creditcard.year.to_s[2,2] unless creditcard.year.blank?
-          card_id_code = (creditcard.verification_value.blank? ? nil : "1")
+          card_id_code = (creditcard.verification_value.blank? ? nil : '1')
 
           params.update(
             :CardNumber => creditcard.number,
@@ -206,11 +206,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(response)
-        if response[:approved] == "APPROVED"
+        if response[:approved] == 'APPROVED'
           return SUCCESS_MESSAGE
         else
           return FAILURE_MESSAGE if response[:errmsg].blank?
-          return response[:errmsg].gsub(/[^\w]/, ' ').split.join(" ").capitalize
+          return response[:errmsg].gsub(/[^\w]/, ' ').split.join(' ').capitalize
         end
       end
 
@@ -220,7 +220,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_authorization(response)
-        [response[:orderid], response[:transrefnumber]].join(";")
+        [response[:orderid], response[:transrefnumber]].join(';')
       end
     end
   end

data/lib/active_merchant/billing/gateways/psl_card.rb

@@ -63,21 +63,21 @@ module ActiveMerchant
       NOMINAL_AMOUNT = 101
 
       AVS_CODE = {
-        "ALL MATCH"	=> 'Y',
-        "SECURITY CODE MATCH ONLY" => 'N',
-        "ADDRESS MATCH ONLY" => 'Y',
-        "NO DATA MATCHES"	=> 'N',
-        "DATA NOT CHECKED"	=> 'R',
-        "SECURITY CHECKS NOT SUPPORTED"	=> 'X'
+        'ALL MATCH'	=> 'Y',
+        'SECURITY CODE MATCH ONLY' => 'N',
+        'ADDRESS MATCH ONLY' => 'Y',
+        'NO DATA MATCHES'	=> 'N',
+        'DATA NOT CHECKED'	=> 'R',
+        'SECURITY CHECKS NOT SUPPORTED'	=> 'X'
       }
 
       CVV_CODE = {
-        "ALL MATCH"	=> 'M',
-        "SECURITY CODE MATCH ONLY" => 'M',
-        "ADDRESS MATCH ONLY" => 'N',
-        "NO DATA MATCHES"	=> 'N',
-        "DATA NOT CHECKED"	=> 'P',
-        "SECURITY CHECKS NOT SUPPORTED"	=> 'X'
+        'ALL MATCH'	=> 'M',
+        'SECURITY CODE MATCH ONLY' => 'M',
+        'ADDRESS MATCH ONLY' => 'N',
+        'NO DATA MATCHES'	=> 'N',
+        'DATA NOT CHECKED'	=> 'P',
+        'SECURITY CHECKS NOT SUPPORTED'	=> 'X'
       }
 
       # Create a new PslCardGateway
@@ -296,7 +296,7 @@ module ActiveMerchant
 
         post.collect { |key, value|
           "#{key}=#{CGI.escape(value.to_s.tr('&=', ' '))}"
-        }.join("&")
+        }.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/qbms.rb

@@ -5,8 +5,8 @@ module ActiveMerchant #:nodoc:
 
       class_attribute :test_url, :live_url
 
-      self.test_url = "https://webmerchantaccount.ptc.quickbooks.com/j/AppGateway"
-      self.live_url = "https://webmerchantaccount.quickbooks.com/j/AppGateway"
+      self.test_url = 'https://webmerchantaccount.ptc.quickbooks.com/j/AppGateway'
+      self.live_url = 'https://webmerchantaccount.quickbooks.com/j/AppGateway'
 
       self.homepage_url = 'http://payments.intuit.com/'
       self.display_name = 'QuickBooks Merchant Services'
@@ -138,7 +138,7 @@ module ActiveMerchant #:nodoc:
 
         req = build_request(type, money, parameters)
 
-        data = ssl_post(url, req, "Content-Type" => "application/x-qbmsxml")
+        data = ssl_post(url, req, 'Content-Type' => 'application/x-qbmsxml')
         response = parse(type, data)
         message = (response[:status_message] || '').strip
 
@@ -163,20 +163,20 @@ module ActiveMerchant #:nodoc:
         xml = REXML::Document.new(body)
 
         signon = REXML::XPath.first(xml, "//SignonMsgsRs/#{hosted? ? 'SignonAppCertRs' : 'SignonDesktopRs'}")
-        status_code = signon.attributes["statusCode"].to_i
+        status_code = signon.attributes['statusCode'].to_i
 
         if status_code != 0
           return {
             :status_code    => status_code,
-            :status_message => signon.attributes["statusMessage"],
+            :status_message => signon.attributes['statusMessage'],
           }
         end
 
         response = REXML::XPath.first(xml, "//QBMSXMLMsgsRs/#{type}Rs")
 
         results = {
-          :status_code    => response.attributes["statusCode"].to_i,
-          :status_message => response.attributes["statusMessage"],
+          :status_code    => response.attributes['statusCode'].to_i,
+          :status_message => response.attributes['statusMessage'],
         }
 
         response.elements.each do |e|
@@ -200,16 +200,16 @@ module ActiveMerchant #:nodoc:
         xml.instruct!(:xml, :version => '1.0', :encoding => 'utf-8')
         xml.instruct!(:qbmsxml, :version => API_VERSION)
 
-        xml.tag!("QBMSXML") do
-          xml.tag!("SignonMsgsRq") do
-            xml.tag!(hosted? ? "SignonAppCertRq" : "SignonDesktopRq") do
-              xml.tag!("ClientDateTime", Time.now.xmlschema)
-              xml.tag!("ApplicationLogin", @options[:login])
-              xml.tag!("ConnectionTicket", @options[:ticket])
+        xml.tag!('QBMSXML') do
+          xml.tag!('SignonMsgsRq') do
+            xml.tag!(hosted? ? 'SignonAppCertRq' : 'SignonDesktopRq') do
+              xml.tag!('ClientDateTime', Time.now.xmlschema)
+              xml.tag!('ApplicationLogin', @options[:login])
+              xml.tag!('ConnectionTicket', @options[:ticket])
             end
           end
 
-          xml.tag!("QBMSXMLMsgsRq") do
+          xml.tag!('QBMSXMLMsgsRq') do
             xml.tag!("#{type}Rq") do
               method("build_#{type}").call(xml, money, parameters)
             end
@@ -223,47 +223,47 @@ module ActiveMerchant #:nodoc:
         cc = parameters[:credit_card]
         name = "#{cc.first_name} #{cc.last_name}"[0...30]
 
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardNumber", cc.number)
-        xml.tag!("ExpirationMonth", cc.month)
-        xml.tag!("ExpirationYear", cc.year)
-        xml.tag!("IsECommerce", "true")
-        xml.tag!("Amount", amount(money))
-        xml.tag!("NameOnCard", name)
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardNumber', cc.number)
+        xml.tag!('ExpirationMonth', cc.month)
+        xml.tag!('ExpirationYear', cc.year)
+        xml.tag!('IsECommerce', 'true')
+        xml.tag!('Amount', amount(money))
+        xml.tag!('NameOnCard', name)
         add_address(xml, parameters)
-        xml.tag!("CardSecurityCode", cc.verification_value) if cc.verification_value?
+        xml.tag!('CardSecurityCode', cc.verification_value) if cc.verification_value?
       end
 
       def build_CustomerCreditCardCapture(xml, money, parameters)
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardTransID", parameters[:transaction_id])
-        xml.tag!("Amount", amount(money))
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardTransID', parameters[:transaction_id])
+        xml.tag!('Amount', amount(money))
       end
 
       def build_CustomerCreditCardCharge(xml, money, parameters)
         cc = parameters[:credit_card]
         name = "#{cc.first_name} #{cc.last_name}"[0...30]
 
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardNumber", cc.number)
-        xml.tag!("ExpirationMonth", cc.month)
-        xml.tag!("ExpirationYear", cc.year)
-        xml.tag!("IsECommerce", "true")
-        xml.tag!("Amount", amount(money))
-        xml.tag!("NameOnCard", name)
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardNumber', cc.number)
+        xml.tag!('ExpirationMonth', cc.month)
+        xml.tag!('ExpirationYear', cc.year)
+        xml.tag!('IsECommerce', 'true')
+        xml.tag!('Amount', amount(money))
+        xml.tag!('NameOnCard', name)
         add_address(xml, parameters)
-        xml.tag!("CardSecurityCode", cc.verification_value) if cc.verification_value?
+        xml.tag!('CardSecurityCode', cc.verification_value) if cc.verification_value?
       end
 
       def build_CustomerCreditCardTxnVoidOrRefund(xml, money, parameters)
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardTransID", parameters[:transaction_id])
-        xml.tag!("Amount", amount(money))
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardTransID', parameters[:transaction_id])
+        xml.tag!('Amount', amount(money))
       end
 
       def build_CustomerCreditCardTxnVoid(xml, money, parameters)
-        xml.tag!("TransRequestID", parameters[:trans_request_id])
-        xml.tag!("CreditCardTransID", parameters[:transaction_id])
+        xml.tag!('TransRequestID', parameters[:trans_request_id])
+        xml.tag!('CreditCardTransID', parameters[:transaction_id])
       end
 
       # Called reflectively by build_request
@@ -272,30 +272,30 @@ module ActiveMerchant #:nodoc:
 
       def add_address(xml, parameters)
         if address = parameters[:billing_address] || parameters[:address]
-          xml.tag!("CreditCardAddress", (address[:address1] || "")[0...30])
-          xml.tag!("CreditCardPostalCode", (address[:zip] || "")[0...9])
+          xml.tag!('CreditCardAddress', (address[:address1] || '')[0...30])
+          xml.tag!('CreditCardPostalCode', (address[:zip] || '')[0...9])
         end
       end
 
       def cvv_result(response)
         case response[:card_security_code_match]
-        when "Pass"         then 'M'
-        when "Fail"         then 'N'
-        when "NotAvailable" then 'P'
+        when 'Pass'         then 'M'
+        when 'Fail'         then 'N'
+        when 'NotAvailable' then 'P'
         end
       end
 
       def avs_result(response)
         case "#{response[:avs_street]}|#{response[:avs_zip]}"
-        when "Pass|Pass"                 then "D"
-        when "Pass|Fail"                 then "A"
-        when "Pass|NotAvailable"         then "B"
-        when "Fail|Pass"                 then "Z"
-        when "Fail|Fail"                 then "C"
-        when "Fail|NotAvailable"         then "N"
-        when "NotAvailable|Pass"         then "P"
-        when "NotAvailable|Fail"         then "N"
-        when "NotAvailable|NotAvailable" then "U"
+        when 'Pass|Pass'                 then 'D'
+        when 'Pass|Fail'                 then 'A'
+        when 'Pass|NotAvailable'         then 'B'
+        when 'Fail|Pass'                 then 'Z'
+        when 'Fail|Fail'                 then 'C'
+        when 'Fail|NotAvailable'         then 'N'
+        when 'NotAvailable|Pass'         then 'P'
+        when 'NotAvailable|Fail'         then 'N'
+        when 'NotAvailable|NotAvailable' then 'U'
         end
       end
     end

data/lib/active_merchant/billing/gateways/quantum.rb

@@ -206,7 +206,7 @@ module ActiveMerchant #:nodoc:
         headers = { 'Content-Type' => 'text/xml' }
         response = parse(ssl_post(self.live_url, build_request(request, options), headers))
 
-        success = response[:request_status] == "Success"
+        success = response[:request_status] == 'Success'
         message = response[:request_message]
 
         if success # => checking for connectivity success first
@@ -231,19 +231,19 @@ module ActiveMerchant #:nodoc:
         begin
           xml = REXML::Document.new(xml)
 
-          root = REXML::XPath.first(xml, "//QGWRequest/ResponseSummary")
+          root = REXML::XPath.first(xml, '//QGWRequest/ResponseSummary')
           parse_element(reply, root)
           reply[:request_status] = reply[:Status]
           reply[:request_message] = "#{reply[:Status]}: #{reply[:StatusDescription]}"
 
-          if root = REXML::XPath.first(xml, "//QGWRequest/Result")
+          if root = REXML::XPath.first(xml, '//QGWRequest/Result')
             root.elements.to_a.each do |node|
               parse_element(reply, node)
             end
           end
         rescue Exception
           reply[:request_status] = 'Failure'
-          reply[:request_message] = "Failure: There was a problem parsing the response XML"
+          reply[:request_message] = 'Failure: There was a problem parsing the response XML'
         end
 
         return reply
@@ -254,7 +254,7 @@ module ActiveMerchant #:nodoc:
           node.elements.each{|e| parse_element(reply, e) }
         else
           if node.parent.name =~ /item/
-            parent = node.parent.name + (node.parent.attributes["id"] ? "_" + node.parent.attributes["id"] : '')
+            parent = node.parent.name + (node.parent.attributes['id'] ? '_' + node.parent.attributes['id'] : '')
             reply[(parent + '_' + node.name).to_sym] = node.text
           else
             reply[node.name.to_sym] = node.text

data/lib/active_merchant/billing/gateways/quickbooks.rb

@@ -10,7 +10,7 @@ module ActiveMerchant #:nodoc:
 
       self.homepage_url = 'http://payments.intuit.com'
       self.display_name = 'QuickBooks Payments'
-      ENDPOINT =  "/quickbooks/v4/payments/charges"
+      ENDPOINT =  '/quickbooks/v4/payments/charges'
       OAUTH_ENDPOINTS = {
         site: 'https://oauth.intuit.com',
         request_token_path: '/oauth/v1/get_request_token',
@@ -60,7 +60,7 @@ module ActiveMerchant #:nodoc:
         post = {}
         add_amount(post, money, options)
         add_charge_data(post, payment, options)
-        post[:capture] = "true"
+        post[:capture] = 'true'
 
         commit(ENDPOINT, post)
       end
@@ -69,7 +69,7 @@ module ActiveMerchant #:nodoc:
         post = {}
         add_amount(post, money, options)
         add_charge_data(post, payment, options)
-        post[:capture] = "false"
+        post[:capture] = 'false'
 
         commit(ENDPOINT, post)
       end
@@ -145,7 +145,7 @@ module ActiveMerchant #:nodoc:
       def add_creditcard(post, creditcard, options = {})
         card = {}
         card[:number] = creditcard.number
-        card[:expMonth] = "%02d" % creditcard.month
+        card[:expMonth] = '%02d' % creditcard.month
         card[:expYear] = creditcard.year
         card[:cvc] = creditcard.verification_value if creditcard.verification_value?
         card[:name] = creditcard.name if creditcard.name
@@ -218,7 +218,7 @@ module ActiveMerchant #:nodoc:
           oauth_nonce: generate_unique_id,
           oauth_timestamp: Time.now.to_i.to_s,
           oauth_signature_method: 'HMAC-SHA1',
-          oauth_version: "1.0",
+          oauth_version: '1.0',
           oauth_consumer_key: @options[:consumer_key],
           oauth_token: @options[:access_token]
         }
@@ -237,9 +237,9 @@ module ActiveMerchant #:nodoc:
         oauth_headers += oauth_parameters.map {|k, v| "#{k}=\"#{v}\""}
 
         {
-          "Content-type" => "application/json",
-          "Request-Id" => generate_unique_id,
-          "Authorization" => oauth_headers.join(', ')
+          'Content-type' => 'application/json',
+          'Request-Id' => generate_unique_id,
+          'Authorization' => oauth_headers.join(', ')
         }
       end
 
@@ -258,11 +258,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(response)
-        response['errors'].present? ? response["errors"].map {|error_hash| error_hash["message"] }.join(" ") : response['status']
+        response['errors'].present? ? response['errors'].map {|error_hash| error_hash['message'] }.join(' ') : response['status']
       end
 
       def errors_from(response)
-        response['errors'].present? ? STANDARD_ERROR_CODE_MAPPING[response["errors"].first["code"]] : ""
+        response['errors'].present? ? STANDARD_ERROR_CODE_MAPPING[response['errors'].first['code']] : ''
       end
 
       def authorization_from(response)

data/lib/active_merchant/billing/gateways/quickpay.rb

@@ -10,7 +10,7 @@ module ActiveMerchant #:nodoc:
       self.abstract_class = true
 
       def self.new(options = {})
-        options.fetch(:login) { raise ArgumentError.new("Missing required parameter: login") }
+        options.fetch(:login) { raise ArgumentError.new('Missing required parameter: login') }
 
         version = options[:login].to_i < 10000000 ? 10 : 7
         if version <= 7