activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/global_transport.rb

@@ -120,8 +120,8 @@ module ActiveMerchant #:nodoc:
         end
 
         ext_data = Nokogiri::HTML.parse(response[:extdata])
-        response[:approved_amount] = ext_data.xpath("//approvedamount").text
-        response[:balance_due] = ext_data.xpath("//balancedue").text
+        response[:approved_amount] = ext_data.xpath('//approvedamount').text
+        response[:balance_due] = ext_data.xpath('//balancedue').text
 
         response
       end
@@ -146,7 +146,7 @@ module ActiveMerchant #:nodoc:
         post[:TransType] = action
         post[:ExtData] = "<TermType>#{@options[:term_type]}</TermType>"
 
-        post.merge(params).map { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        post.merge(params).map { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def url
@@ -154,7 +154,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response[:result] == "0" || response[:result] == "200"
+        response[:result] == '0' || response[:result] == '200'
       end
 
       def message_from(response)

data/lib/active_merchant/billing/gateways/hdfc.rb

@@ -1,16 +1,16 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class HdfcGateway < Gateway
-      self.display_name = "HDFC"
-      self.homepage_url = "http://www.hdfcbank.com/sme/sme-details/merchant-services/guzh6m0i"
+      self.display_name = 'HDFC'
+      self.homepage_url = 'http://www.hdfcbank.com/sme/sme-details/merchant-services/guzh6m0i'
 
-      self.test_url = "https://securepgtest.fssnet.co.in/pgway/servlet/"
-      self.live_url = "https://securepg.fssnet.co.in/pgway/servlet/"
+      self.test_url = 'https://securepgtest.fssnet.co.in/pgway/servlet/'
+      self.live_url = 'https://securepg.fssnet.co.in/pgway/servlet/'
 
-      self.supported_countries = ["IN"]
-      self.default_currency = "INR"
+      self.supported_countries = ['IN']
+      self.default_currency = 'INR'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :discover, :diners_club]
 
@@ -25,7 +25,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
 
-        commit("purchase", post)
+        commit('purchase', post)
       end
 
       def authorize(amount, payment_method, options={})
@@ -34,7 +34,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
 
-        commit("authorize", post)
+        commit('authorize', post)
       end
 
       def capture(amount, authorization, options={})
@@ -43,7 +43,7 @@ module ActiveMerchant #:nodoc:
         add_reference(post, authorization)
         add_customer_data(post, options)
 
-        commit("capture", post)
+        commit('capture', post)
       end
 
       def refund(amount, authorization, options={})
@@ -52,22 +52,22 @@ module ActiveMerchant #:nodoc:
         add_reference(post, authorization)
         add_customer_data(post, options)
 
-        commit("refund", post)
+        commit('refund', post)
       end
 
       private
 
       CURRENCY_CODES = Hash.new{|h,k| raise ArgumentError.new("Unsupported currency for HDFC: #{k}")}
-      CURRENCY_CODES["AED"] = "784"
-      CURRENCY_CODES["AUD"] = "036"
-      CURRENCY_CODES["CAD"] = "124"
-      CURRENCY_CODES["EUR"] = "978"
-      CURRENCY_CODES["GBP"] = "826"
-      CURRENCY_CODES["INR"] = "356"
-      CURRENCY_CODES["OMR"] = "512"
-      CURRENCY_CODES["QAR"] = "634"
-      CURRENCY_CODES["SGD"] = "702"
-      CURRENCY_CODES["USD"] = "840"
+      CURRENCY_CODES['AED'] = '784'
+      CURRENCY_CODES['AUD'] = '036'
+      CURRENCY_CODES['CAD'] = '124'
+      CURRENCY_CODES['EUR'] = '978'
+      CURRENCY_CODES['GBP'] = '826'
+      CURRENCY_CODES['INR'] = '356'
+      CURRENCY_CODES['OMR'] = '512'
+      CURRENCY_CODES['QAR'] = '634'
+      CURRENCY_CODES['SGD'] = '702'
+      CURRENCY_CODES['USD'] = '840'
 
       def add_invoice(post, amount, options)
         post[:amt] = amount(amount)
@@ -127,14 +127,14 @@ EOA
       end
 
       def fix_xml(xml)
-        xml.gsub(/&(?!(?:amp|quot|apos|lt|gt);)/, "&amp;")
+        xml.gsub(/&(?!(?:amp|quot|apos|lt|gt);)/, '&amp;')
       end
 
       ACTIONS = {
-        "purchase" => "1",
-        "refund" => "2",
-        "authorize" => "4",
-        "capture" => "5",
+        'purchase' => '1',
+        'refund' => '2',
+        'authorize' => '4',
+        'capture' => '5',
       }
 
       def commit(action, post)
@@ -164,13 +164,13 @@ EOA
       end
 
       def url(action)
-        endpoint = "TranPortalXMLServlet"
+        endpoint = 'TranPortalXMLServlet'
         (test? ? test_url : live_url) + endpoint
       end
 
       def success_from(result)
         case result
-        when "CAPTURED", "APPROVED", "NOT ENROLLED", "ENROLLED"
+        when 'CAPTURED', 'APPROVED', 'NOT ENROLLED', 'ENROLLED'
           true
         else
           false
@@ -179,23 +179,23 @@ EOA
 
       def message_from(succeeded, response)
         if succeeded
-          "Succeeded"
+          'Succeeded'
         else
-          (response[:error_text] || response[:result] || "Unable to read error message").split("-").last
+          (response[:error_text] || response[:result] || 'Unable to read error message').split('-').last
         end
       end
 
       def authorization_from(request, response)
-        [response[:tranid], request[:member]].join("|")
+        [response[:tranid], request[:member]].join('|')
       end
 
       def split_authorization(authorization)
-        tranid, member = authorization.split("|")
+        tranid, member = authorization.split('|')
         [tranid, member]
       end
 
       def escape(string, max_length=250)
-        return "" unless string
+        return '' unless string
         if max_length
           string = string[0...max_length]
         end

data/lib/active_merchant/billing/gateways/hps.rb

@@ -1,4 +1,4 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -117,7 +117,7 @@ module ActiveMerchant #:nodoc:
         xml.hps :CardData do
           if card_or_token.respond_to?(:number)
             if card_or_token.track_data
-              xml.tag!("hps:TrackData", 'method'=>'swipe') do
+              xml.tag!('hps:TrackData', 'method'=>'swipe') do
                 xml.text! card_or_token.track_data
               end
               if options[:encryption_type]
@@ -202,7 +202,7 @@ module ActiveMerchant #:nodoc:
 
         doc = Nokogiri::XML(raw)
         doc.remove_namespaces!
-        if(header = doc.xpath("//Header").first)
+        if(header = doc.xpath('//Header').first)
           header.elements.each do |node|
             if (node.elements.size == 0)
               response[node.name] = node.text
@@ -213,13 +213,13 @@ module ActiveMerchant #:nodoc:
             end
           end
         end
-        if(transaction = doc.xpath("//Transaction/*[1]").first)
+        if(transaction = doc.xpath('//Transaction/*[1]').first)
           transaction.elements.each do |node|
             response[node.name] = node.text
           end
         end
-        if(fault = doc.xpath("//Fault/Reason/Text").first)
-          response["Fault"] = fault.text
+        if(fault = doc.xpath('//Fault/Reason/Text').first)
+          response['Fault'] = fault.text
         end
 
         response
@@ -250,22 +250,22 @@ module ActiveMerchant #:nodoc:
 
       def successful?(response)
         (
-          (response["GatewayRspCode"] == "0") &&
-          ((response["RspCode"] || "00") == "00" || response["RspCode"] == "85")
+          (response['GatewayRspCode'] == '0') &&
+          ((response['RspCode'] || '00') == '00' || response['RspCode'] == '85')
         )
       end
 
       def message_from(response)
-        if(response["Fault"])
-          response["Fault"]
-        elsif(response["GatewayRspCode"] == "0")
-          if(response["RspCode"] != "00" && response["RspCode"] != "85")
-            issuer_message(response["RspCode"])
+        if(response['Fault'])
+          response['Fault']
+        elsif(response['GatewayRspCode'] == '0')
+          if(response['RspCode'] != '00' && response['RspCode'] != '85')
+            issuer_message(response['RspCode'])
           else
             response['GatewayRspMsg']
           end
         else
-          (GATEWAY_MESSAGES[response["GatewayRspCode"]] || response["GatewayRspMsg"])
+          (GATEWAY_MESSAGES[response['GatewayRspCode']] || response['GatewayRspMsg'])
         end
       end
 
@@ -278,27 +278,27 @@ module ActiveMerchant #:nodoc:
       end
 
       ISSUER_MESSAGES = {
-        "13" => "Must be greater than or equal 0.",
-        "14" => "The card number is incorrect.",
-        "54" => "The card has expired.",
-        "55" => "The 4-digit pin is invalid.",
-        "75" => "Maximum number of pin retries exceeded.",
-        "80" => "Card expiration date is invalid.",
-        "86" => "Can't verify card pin number."
+        '13' => 'Must be greater than or equal 0.',
+        '14' => 'The card number is incorrect.',
+        '54' => 'The card has expired.',
+        '55' => 'The 4-digit pin is invalid.',
+        '75' => 'Maximum number of pin retries exceeded.',
+        '80' => 'Card expiration date is invalid.',
+        '86' => "Can't verify card pin number."
       }
       def issuer_message(code)
-        return "The card was declined." if %w(02 03 04 05 41 43 44 51 56 61 62 63 65 78).include?(code)
-        return "An error occurred while processing the card." if %w(06 07 12 15 19 12 52 53 57 58 76 77 91 96 EC).include?(code)
+        return 'The card was declined.' if %w(02 03 04 05 41 43 44 51 56 61 62 63 65 78).include?(code)
+        return 'An error occurred while processing the card.' if %w(06 07 12 15 19 12 52 53 57 58 76 77 91 96 EC).include?(code)
         return "The card's security code is incorrect." if %w(EB N7).include?(code)
         ISSUER_MESSAGES[code]
       end
 
       GATEWAY_MESSAGES = {
-        "-2" => "Authentication error. Please double check your service configuration.",
-        "12" => "Invalid CPC data.",
-        "13" => "Invalid card data.",
-        "14" => "The card number is not a valid credit card number.",
-        "30" => "Gateway timed out."
+        '-2' => 'Authentication error. Please double check your service configuration.',
+        '12' => 'Invalid CPC data.',
+        '13' => 'Invalid card data.',
+        '14' => 'The card number is not a valid credit card number.',
+        '30' => 'Gateway timed out.'
       }
     end
   end

data/lib/active_merchant/billing/gateways/iats_payments.rb

@@ -14,12 +14,12 @@ module ActiveMerchant #:nodoc:
       self.display_name = 'iATS Payments'
 
       ACTIONS = {
-        purchase: "ProcessCreditCardV1",
-        purchase_check: "ProcessACHEFTV1",
-        refund: "ProcessCreditCardRefundWithTransactionIdV1",
-        refund_check: "ProcessACHEFTRefundWithTransactionIdV1",
-        store: "CreateCreditCardCustomerCodeV1",
-        unstore: "DeleteCustomerCodeV1"
+        purchase: 'ProcessCreditCardV1',
+        purchase_check: 'ProcessACHEFTV1',
+        refund: 'ProcessCreditCardRefundWithTransactionIdV1',
+        refund_check: 'ProcessACHEFTRefundWithTransactionIdV1',
+        store: 'CreateCreditCardCustomerCodeV1',
+        unstore: 'DeleteCustomerCodeV1'
       }
 
       def initialize(options={})
@@ -145,19 +145,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def expdate(creditcard)
-        year  = sprintf("%.4i", creditcard.year)
-        month = sprintf("%.2i", creditcard.month)
+        year  = sprintf('%.4i', creditcard.year)
+        month = sprintf('%.2i', creditcard.month)
 
         "#{month}/#{year[-2..-1]}"
       end
 
       def creditcard_brand(brand)
         case brand
-        when "visa" then "VISA"
-        when "master" then "MC"
-        when "discover" then "DSC"
-        when "american_express" then "AMX"
-        when "maestro" then "MAESTR"
+        when 'visa' then 'VISA'
+        when 'master' then 'MC'
+        when 'discover' then 'DSC'
+        when 'american_express' then 'AMX'
+        when 'maestro' then 'MAESTR'
         else
           raise "Unhandled credit card brand #{brand}"
         end
@@ -178,12 +178,12 @@ module ActiveMerchant #:nodoc:
 
       def endpoints
         {
-          purchase: "ProcessLink.asmx",
-          purchase_check: "ProcessLink.asmx",
-          refund: "ProcessLink.asmx",
-          refund_check: "ProcessLink.asmx",
-          store: "CustomerLink.asmx",
-          unstore: "CustomerLink.asmx"
+          purchase: 'ProcessLink.asmx',
+          purchase_check: 'ProcessLink.asmx',
+          refund: 'ProcessLink.asmx',
+          refund_check: 'ProcessLink.asmx',
+          store: 'CustomerLink.asmx',
+          unstore: 'CustomerLink.asmx'
         }
       end
 
@@ -211,7 +211,7 @@ module ActiveMerchant #:nodoc:
       def hashify_xml!(xml, response)
         xml = REXML::Document.new(xml)
 
-        xml.elements.each("//IATSRESPONSE/*") do |node|
+        xml.elements.each('//IATSRESPONSE/*') do |node|
           recursively_parse_element(node, response)
         end
       end
@@ -229,7 +229,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response[:status] == "Success" && successful_result_message?(response)
+        response[:status] == 'Success' && successful_result_message?(response)
       end
 
       def message_from(response)
@@ -253,14 +253,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def split_authorization(authorization)
-        authorization.split("|")
+        authorization.split('|')
       end
 
       def envelope_namespaces
         {
-          "xmlns:xsi" => "http://www.w3.org/2001/XMLSchema-instance",
-          "xmlns:xsd" => "http://www.w3.org/2001/XMLSchema",
-          "xmlns:soap12" => "http://www.w3.org/2003/05/soap-envelope"
+          'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance',
+          'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema',
+          'xmlns:soap12' => 'http://www.w3.org/2003/05/soap-envelope'
         }
       end
 
@@ -269,7 +269,7 @@ module ActiveMerchant #:nodoc:
         xml.instruct!(:xml, :version => '1.0', :encoding => 'utf-8')
         xml.tag! 'soap12:Envelope', envelope_namespaces do
           xml.tag! 'soap12:Body' do
-            xml.tag! ACTIONS[action], { "xmlns" => "https://www.iatspayments.com/NetGate/" } do
+            xml.tag! ACTIONS[action], { 'xmlns' => 'https://www.iatspayments.com/NetGate/' } do
               xml.tag!('agentCode', @options[:agent_code])
               xml.tag!('password', @options[:password])
               parameters.each do |name, value|

data/lib/active_merchant/billing/gateways/inspire.rb

@@ -73,7 +73,7 @@ module ActiveMerchant #:nodoc:
       # CreditCard object.
       def update(vault_id, creditcard, options = {})
         post = {}
-        post[:customer_vault] = "update_customer"
+        post[:customer_vault] = 'update_customer'
         add_customer_vault_id(post, vault_id)
         add_creditcard(post, creditcard, options)
         add_address(post, creditcard, options)
@@ -84,7 +84,7 @@ module ActiveMerchant #:nodoc:
 
       def delete(vault_id)
         post = {}
-        post[:customer_vault] = "delete_customer"
+        post[:customer_vault] = 'delete_customer'
         add_customer_vault_id(post, vault_id)
         commit(nil, nil, post)
       end
@@ -141,7 +141,7 @@ module ActiveMerchant #:nodoc:
 
       def add_creditcard(post, creditcard,options)
         if options[:store]
-          post[:customer_vault] = "add_customer"
+          post[:customer_vault] = 'add_customer'
           post[:customer_vault_id] = options[:store] unless options[:store] == true
         end
         post[:ccnumber]  = creditcard.number
@@ -175,23 +175,23 @@ module ActiveMerchant #:nodoc:
 
         response = parse( ssl_post(self.live_url, post_data(action,parameters)) )
 
-        Response.new(response["response"] == "1", message_from(response), response,
-          :authorization => response["transactionid"],
+        Response.new(response['response'] == '1', message_from(response), response,
+          :authorization => response['transactionid'],
           :test => test?,
-          :cvv_result => response["cvvresponse"],
-          :avs_result => { :code => response["avsresponse"] }
+          :cvv_result => response['cvvresponse'],
+          :avs_result => { :code => response['avsresponse'] }
         )
 
       end
 
       def message_from(response)
-        case response["responsetext"]
-        when "SUCCESS","Approved"
-          "This transaction has been approved"
-        when "DECLINE"
-          "This transaction has been declined"
+        case response['responsetext']
+        when 'SUCCESS','Approved'
+          'This transaction has been approved'
+        when 'DECLINE'
+          'This transaction has been declined'
         else
-          response["responsetext"]
+          response['responsetext']
         end
       end
 
@@ -201,7 +201,7 @@ module ActiveMerchant #:nodoc:
         post[:password]   = @options[:password]
         post[:type]       = action if action
 
-        request = post.merge(parameters).map {|key,value| "#{key}=#{CGI.escape(value.to_s)}"}.join("&")
+        request = post.merge(parameters).map {|key,value| "#{key}=#{CGI.escape(value.to_s)}"}.join('&')
         request
       end
 
@@ -210,7 +210,7 @@ module ActiveMerchant #:nodoc:
         when source.is_a?(String) then :vault
         when CreditCard.card_companies.keys.include?(card_brand(source)) then :credit_card
         when card_brand(source) == 'check' then :check
-        else raise ArgumentError, "Unsupported funding source provided"
+        else raise ArgumentError, 'Unsupported funding source provided'
         end
       end
     end