activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/metrics_global.rb

@@ -20,8 +20,8 @@ module ActiveMerchant #:nodoc:
 
       class_attribute :test_url, :live_url
 
-      self.test_url = "https://secure.metricsglobalgateway.com/gateway/transact.dll?testing=true"
-      self.live_url = "https://secure.metricsglobalgateway.com/gateway/transact.dll"
+      self.test_url = 'https://secure.metricsglobalgateway.com/gateway/transact.dll?testing=true'
+      self.live_url = 'https://secure.metricsglobalgateway.com/gateway/transact.dll'
 
       class_attribute :duplicate_window
 
@@ -213,14 +213,14 @@ module ActiveMerchant #:nodoc:
         post[:version]        = API_VERSION
         post[:login]          = @options[:login]
         post[:tran_key]       = @options[:password]
-        post[:relay_response] = "FALSE"
+        post[:relay_response] = 'FALSE'
         post[:type]           = action
-        post[:delim_data]     = "TRUE"
-        post[:delim_char]     = ","
-        post[:encap_char]     = "$"
+        post[:delim_data]     = 'TRUE'
+        post[:delim_char]     = ','
+        post[:encap_char]     = '$'
         post[:solution_ID]    = application_id if application_id
 
-        request = post.merge(parameters).collect { |key, value| "x_#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        request = post.merge(parameters).collect { |key, value| "x_#{key}=#{CGI.escape(value.to_s)}" }.join('&')
         request
       end
 

data/lib/active_merchant/billing/gateways/micropayment.rb

@@ -2,13 +2,13 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class MicropaymentGateway < Gateway
 
-      self.display_name = "micropayment"
-      self.homepage_url = "https://www.micropayment.de/"
+      self.display_name = 'micropayment'
+      self.homepage_url = 'https://www.micropayment.de/'
 
-      self.test_url = self.live_url = "https://sipg.micropayment.de/public/creditcardpsp/v1/nvp/"
+      self.test_url = self.live_url = 'https://sipg.micropayment.de/public/creditcardpsp/v1/nvp/'
 
       self.supported_countries = %w(DE)
-      self.default_currency = "EUR"
+      self.default_currency = 'EUR'
       self.money_format = :cents
       self.supported_cardtypes = [:visa, :master, :american_express]
 
@@ -24,7 +24,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method, options)
         add_customer_data(post, options)
         add_address(post, options)
-        commit("purchase", post)
+        commit('purchase', post)
       end
 
       def authorize(amount, payment_method, options={})
@@ -33,27 +33,27 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method, options)
         add_customer_data(post, options)
         add_address(post, options)
-        commit("authorize", post)
+        commit('authorize', post)
       end
 
       def capture(amount, authorization, options={})
         post = {}
         add_reference(post, authorization)
         add_invoice(post, amount, options)
-        commit("capture", post)
+        commit('capture', post)
       end
 
       def void(authorization, options={})
         post = {}
         add_reference(post, authorization)
-        commit("void", post)
+        commit('void', post)
       end
 
       def refund(amount, authorization, options={})
         post = {}
         add_reference(post, authorization)
         add_invoice(post, amount, options)
-        commit("refund", post)
+        commit('refund', post)
       end
 
       def verify(credit_card, options={})
@@ -83,7 +83,7 @@ module ActiveMerchant #:nodoc:
           post[:currency] = options[:currency] || currency(money)
         end
         post[:project] = options[:project] if options[:project]
-        post["params[title]"] = options[:description] if options[:description]
+        post['params[title]'] = options[:description] if options[:description]
       end
 
       def add_payment_method(post, payment_method, options={})
@@ -93,24 +93,24 @@ module ActiveMerchant #:nodoc:
         post[:expiryYear] = format(payment_method.year, :four_digits)
         post[:expiryMonth] = format(payment_method.month, :two_digits)
 
-        post["params[firstname]"] = payment_method.first_name
-        post["params[surname]"] = payment_method.last_name
+        post['params[firstname]'] = payment_method.first_name
+        post['params[surname]'] = payment_method.last_name
       end
 
       def add_customer_data(post, options)
-        post["params[email]"] = options[:email] if options[:email]
-        post["params[ip]"] = options[:ip] || "1.1.1.1"
-        post["params[sendMail]"] = options[:send_mail] || 'false'
+        post['params[email]'] = options[:email] if options[:email]
+        post['params[ip]'] = options[:ip] || '1.1.1.1'
+        post['params[sendMail]'] = options[:send_mail] || 'false'
       end
 
       def add_address(post, options)
         address = options[:billing_address]
         return unless address
 
-        post["params[address]"] = address[:address1] if address[:address1]
-        post["params[zipcode]"] = address[:zip] if address[:zip]
-        post["params[town]"] = address[:city] if address[:city]
-        post["params[country]"] = address[:country] if address[:country]
+        post['params[address]'] = address[:address1] if address[:address1]
+        post['params[zipcode]'] = address[:zip] if address[:zip]
+        post['params[town]'] = address[:city] if address[:city]
+        post['params[country]'] = address[:country] if address[:country]
       end
 
       def add_reference(post, authorization)
@@ -122,7 +122,7 @@ module ActiveMerchant #:nodoc:
       def commit(action, params)
         params[:testMode] = 1 if test?
         params[:accessKey] = @options[:access_key]
-        params[:apiKey] = @options[:api_key] || "af1fd841af792f4c50131414ff76e004"
+        params[:apiKey] = @options[:api_key] || 'af1fd841af792f4c50131414ff76e004'
 
         response = parse(ssl_post(url(action), post_data(action, params), headers))
 
@@ -131,14 +131,14 @@ module ActiveMerchant #:nodoc:
           message_from(succeeded, response),
           response,
           authorization: authorization_from(response, params),
-          avs_result: AVSResult.new(code: response["some_avs_result_key"]),
-          cvv_result: CVVResult.new(response["some_cvv_result_key"]),
+          avs_result: AVSResult.new(code: response['some_avs_result_key']),
+          cvv_result: CVVResult.new(response['some_cvv_result_key']),
           test: test?
         )
       end
 
       def headers
-        { "Content-Type"  => "application/x-www-form-urlencoded;charset=UTF-8" }
+        { 'Content-Type'  => 'application/x-www-form-urlencoded;charset=UTF-8' }
       end
 
       def post_data(action, params)
@@ -152,32 +152,32 @@ module ActiveMerchant #:nodoc:
 
       def parse(body)
         body.split(/\r?\n/).inject({}) do |acc, pair|
-          key, value = pair.split("=")
+          key, value = pair.split('=')
           acc[key] = CGI.unescape(value)
           acc
         end
       end
 
       def success_from(response)
-        response["error"] == "0" &&
-          response["transactionResultCode"] == "00" &&
-          response["transactionStatus"] == "SUCCESS"
+        response['error'] == '0' &&
+          response['transactionResultCode'] == '00' &&
+          response['transactionStatus'] == 'SUCCESS'
       end
 
       def message_from(succeeded, response)
         if succeeded
-          "Succeeded"
+          'Succeeded'
         else
-          response["errorMessage"] || response["transactionResultMessage"]
+          response['errorMessage'] || response['transactionResultMessage']
         end
       end
 
       def split_authorization(authorization)
-        authorization.split("|")
+        authorization.split('|')
       end
 
       def authorization_from(response, request_params)
-        session_id = response["sessionId"] ? response["sessionId"] : request_params[:sessionId]
+        session_id = response['sessionId'] || request_params[:sessionId]
         "#{session_id}|#{response["transactionId"]}"
       end
     end

data/lib/active_merchant/billing/gateways/migs.rb

@@ -194,7 +194,7 @@ module ActiveMerchant #:nodoc:
 
         expected_secure_hash = calculate_secure_hash(response_hash, @options[:secure_hash])
         unless response_hash[:SecureHash] == expected_secure_hash
-          raise SecurityError, "Secure Hash mismatch, response may be tampered with"
+          raise SecurityError, 'Secure Hash mismatch, response may be tampered with'
         end
 
         response_object(response_hash)
@@ -213,7 +213,9 @@ module ActiveMerchant #:nodoc:
           gsub(%r((&?CardNum=)\d*(&?)), '\1[FILTERED]\2').
           gsub(%r((&?CardSecurityCode=)\d*(&?)), '\1[FILTERED]\2').
           gsub(%r((&?AccessCode=)[^&]*(&?)), '\1[FILTERED]\2').
-          gsub(%r((&?Password=)[^&]*(&?)), '\1[FILTERED]\2')
+          gsub(%r((&?Password=)[^&]*(&?)), '\1[FILTERED]\2').
+          gsub(%r((&?3DSXID=)[^&]*(&?)), '\1[FILTERED]\2').
+          gsub(%r((&?VerToken=)[^&]*(&?)), '\1[FILTERED]\2')
       end
 
       private
@@ -235,10 +237,10 @@ module ActiveMerchant #:nodoc:
       def add_3ds(post, options)
         post[:VerType] = options[:ver_type] if options[:ver_type]
         post[:VerToken] = options[:ver_token] if options[:ver_token]
-        post["3DSXID"] = options[:three_ds_xid] if options[:three_ds_xid]
-        post["3DSECI"] = options[:three_ds_eci] if options[:three_ds_eci]
-        post["3DSenrolled"] = options[:three_ds_enrolled] if options[:three_ds_enrolled]
-        post["3DSstatus"] = options[:three_ds_status] if options[:three_ds_status]
+        post['3DSXID'] = options[:three_ds_xid] if options[:three_ds_xid]
+        post['3DSECI'] = options[:three_ds_eci] if options[:three_ds_eci]
+        post['3DSenrolled'] = options[:three_ds_enrolled] if options[:three_ds_enrolled]
+        post['3DSstatus'] = options[:three_ds_status] if options[:three_ds_status]
       end
 
       def add_creditcard(post, creditcard)
@@ -270,10 +272,10 @@ module ActiveMerchant #:nodoc:
 
       def response_object(response)
         avs_response_code = response[:AVSResultCode]
-        avs_response_code = 'S' if avs_response_code == "Unsupported"
+        avs_response_code = 'S' if avs_response_code == 'Unsupported'
 
         cvv_result_code = response[:CSCResultCode]
-        cvv_result_code = 'P' if cvv_result_code == "Unsupported"
+        cvv_result_code = 'P' if cvv_result_code == 'Unsupported'
 
         Response.new(success?(response), response[:Message], response,
           :test => test?,
@@ -303,7 +305,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def post_data(post)
-        post.collect { |key, value| "vpc_#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        post.collect { |key, value| "vpc_#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def add_secure_hash(post)

data/lib/active_merchant/billing/gateways/modern_payments.rb

@@ -19,7 +19,7 @@ module ActiveMerchant #:nodoc:
         customer_response = cim.create_customer(options)
         return customer_response unless customer_response.success?
 
-        customer_id = customer_response.params["create_customer_result"]
+        customer_id = customer_response.params['create_customer_result']
 
         card_response = cim.modify_customer_credit_card(customer_id, credit_card)
         return card_response unless card_response.success?

data/lib/active_merchant/billing/gateways/modern_payments_cim.rb

@@ -1,20 +1,20 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class ModernPaymentsCimGateway < Gateway #:nodoc:
-      self.test_url = "https://secure.modpay.com/netservices/test/ModpayTest.asmx"
+      self.test_url = 'https://secure.modpay.com/netservices/test/ModpayTest.asmx'
       self.live_url = 'https://secure.modpay.com/ws/modpay.asmx'
 
-      LIVE_XMLNS = "https://secure.modpay.com/ws/"
-      TEST_XMLNS = "https://secure.modpay.com/netservices/test/"
+      LIVE_XMLNS = 'https://secure.modpay.com/ws/'
+      TEST_XMLNS = 'https://secure.modpay.com/netservices/test/'
 
       self.supported_countries = ['US']
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
       self.homepage_url = 'http://www.modpay.com'
       self.display_name = 'Modern Payments'
 
-      SUCCESS_MESSAGE = "Transaction accepted"
-      FAILURE_MESSAGE = "Transaction failed"
-      ERROR_MESSAGE   = "Transaction error"
+      SUCCESS_MESSAGE = 'Transaction accepted'
+      FAILURE_MESSAGE = 'Transaction failed'
+      ERROR_MESSAGE   = 'Transaction error'
 
       PAYMENT_METHOD = {
         :check => 1,
@@ -35,7 +35,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def modify_customer_credit_card(customer_id, credit_card)
-        raise ArgumentError, "The customer_id cannot be blank" if customer_id.blank?
+        raise ArgumentError, 'The customer_id cannot be blank' if customer_id.blank?
 
         post = {}
         add_customer_id(post, customer_id)
@@ -45,7 +45,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorize_credit_card_payment(customer_id, amount)
-        raise ArgumentError, "The customer_id cannot be blank" if customer_id.blank?
+        raise ArgumentError, 'The customer_id cannot be blank' if customer_id.blank?
 
         post = {}
         add_customer_id(post, customer_id)
@@ -55,7 +55,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def create_payment(customer_id, amount, options = {})
-        raise ArgumentError, "The customer_id cannot be blank" if customer_id.blank?
+        raise ArgumentError, 'The customer_id cannot be blank' if customer_id.blank?
 
         post = {}
         add_customer_id(post, customer_id)
@@ -67,7 +67,7 @@ module ActiveMerchant #:nodoc:
 
       private
       def add_payment_details(post, options)
-        post[:pmtDate] = (options[:payment_date] || Time.now.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
+        post[:pmtDate] = (options[:payment_date] || Time.now.utc).strftime('%Y-%m-%dT%H:%M:%SZ')
         post[:pmtType] = PAYMENT_METHOD[options[:payment_method] || :credit_card]
       end
 
@@ -118,9 +118,9 @@ module ActiveMerchant #:nodoc:
             'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance' } do
 
           xml.tag! 'env:Body' do
-            xml.tag! action, { "xmlns" => xmlns(action) } do
-              xml.tag! "clientId", @options[:login]
-              xml.tag! "clientCode", @options[:password]
+            xml.tag! action, { 'xmlns' => xmlns(action) } do
+              xml.tag! 'clientId', @options[:login]
+              xml.tag! 'clientCode', @options[:password]
               params.each {|key, value| xml.tag! key, value }
             end
           end
@@ -163,14 +163,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_key(action)
-        action == "AuthorizeCreditCardPayment" ? :trans_id : "#{action.underscore}_result".to_sym
+        action == 'AuthorizeCreditCardPayment' ? :trans_id : "#{action.underscore}_result".to_sym
       end
 
       def successful?(action, response)
         key = authorization_key(action)
 
         if key == :trans_id
-          response[:approved] == "true"
+          response[:approved] == 'true'
         else
           response[key].to_i > 0
         end
@@ -195,7 +195,7 @@ module ActiveMerchant #:nodoc:
           root.elements.to_a.each do |node|
             parse_element(response, node)
           end
-        elsif root = REXML::XPath.first(xml, "//soap:Fault")
+        elsif root = REXML::XPath.first(xml, '//soap:Fault')
           root.elements.to_a.each do |node|
             response[node.name.underscore.to_sym] = node.text
           end

data/lib/active_merchant/billing/gateways/monei.rb

@@ -151,7 +151,7 @@ module ActiveMerchant #:nodoc:
       # Private: Build XML wrapping code yielding to code to fill the transaction information
       def build_request
         builder = Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
-          xml.Request(:version => "1.0") do
+          xml.Request(:version => '1.0') do
             xml.Header { xml.Security(:sender => @options[:sender_id]) }
             xml.Transaction(:mode => test? ? 'CONNECTOR_TEST' : 'LIVE', :response => 'SYNC', :channel => @options[:channel_id]) do
               xml.User(:login => @options[:login], :pwd => @options[:pwd])
@@ -229,10 +229,10 @@ module ActiveMerchant #:nodoc:
       def parse(body)
         xml = Nokogiri::XML(body)
         {
-            :unique_id => xml.xpath("//Response/Transaction/Identification/UniqueID").text,
-            :status => translate_status_code(xml.xpath("//Response/Transaction/Processing/Status/@code").text),
-            :reason => translate_status_code(xml.xpath("//Response/Transaction/Processing/Reason/@code").text),
-            :message => xml.xpath("//Response/Transaction/Processing/Return").text
+            :unique_id => xml.xpath('//Response/Transaction/Identification/UniqueID').text,
+            :status => translate_status_code(xml.xpath('//Response/Transaction/Processing/Status/@code').text),
+            :reason => translate_status_code(xml.xpath('//Response/Transaction/Processing/Reason/@code').text),
+            :message => xml.xpath('//Response/Transaction/Processing/Return').text
         }
       end
 

data/lib/active_merchant/billing/gateways/moneris.rb

@@ -178,7 +178,7 @@ module ActiveMerchant #:nodoc:
       private # :nodoc: all
 
       def expdate(creditcard)
-        sprintf("%.4i", creditcard.year)[-2..-1] + sprintf("%.2i", creditcard.month)
+        sprintf('%.4i', creditcard.year)[-2..-1] + sprintf('%.2i', creditcard.month)
       end
 
       def add_payment_source(post, payment_method, options)
@@ -249,7 +249,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(xml)
-        response = { :message => "Global Error Receipt", :complete => false }
+        response = { :message => 'Global Error Receipt', :complete => false }
         hashify_xml!(xml, response)
         response
       end
@@ -264,9 +264,9 @@ module ActiveMerchant #:nodoc:
 
       def post_data(action, parameters = {})
         xml   = REXML::Document.new
-        root  = xml.add_element("request")
-        root.add_element("store_id").text  = options[:login]
-        root.add_element("api_token").text = options[:password]
+        root  = xml.add_element('request')
+        root.add_element('store_id').text  = options[:login]
+        root.add_element('api_token').text = options[:password]
         root.add_element(transaction_element(action, parameters))
 
         xml.to_s
@@ -304,10 +304,10 @@ module ActiveMerchant #:nodoc:
       def cvd_element(cvd_value)
         element = REXML::Element.new('cvd_info')
         if cvd_value
-          element.add_element('cvd_indicator').text = "1"
+          element.add_element('cvd_indicator').text = '1'
           element.add_element('cvd_value').text = cvd_value
         else
-          element.add_element('cvd_indicator').text = "0"
+          element.add_element('cvd_indicator').text = '0'
         end
         element
       end
@@ -320,29 +320,29 @@ module ActiveMerchant #:nodoc:
 
       def message_from(message)
         return 'Unspecified error' if message.blank?
-        message.gsub(/[^\w]/, ' ').split.join(" ").capitalize
+        message.gsub(/[^\w]/, ' ').split.join(' ').capitalize
       end
 
       def actions
         {
-          "purchase"           => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type, :avs_info, :cvd_info, :track2, :pos_code],
-          "preauth"            => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type, :avs_info, :cvd_info, :track2, :pos_code],
-          "command"            => [:order_id],
-          "refund"             => [:order_id, :amount, :txn_number, :crypt_type],
-          "indrefund"          => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type],
-          "completion"         => [:order_id, :comp_amount, :txn_number, :crypt_type],
-          "purchasecorrection" => [:order_id, :txn_number, :crypt_type],
-          "cavv_preauth"       => [:order_id, :cust_id, :amount, :pan, :expdate, :cavv, :crypt_type, :wallet_indicator],
-          "cavv_purchase"      => [:order_id, :cust_id, :amount, :pan, :expdate, :cavv, :crypt_type, :wallet_indicator],
-          "transact"           => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type],
-          "Batchcloseall"      => [],
-          "opentotals"         => [:ecr_number],
-          "batchclose"         => [:ecr_number],
-          "res_add_cc"         => [:pan, :expdate, :crypt_type],
-          "res_delete"         => [:data_key],
-          "res_update_cc"      => [:data_key, :pan, :expdate, :crypt_type],
-          "res_purchase_cc"    => [:data_key, :order_id, :cust_id, :amount, :crypt_type],
-          "res_preauth_cc"     => [:data_key, :order_id, :cust_id, :amount, :crypt_type]
+          'purchase'           => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type, :avs_info, :cvd_info, :track2, :pos_code],
+          'preauth'            => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type, :avs_info, :cvd_info, :track2, :pos_code],
+          'command'            => [:order_id],
+          'refund'             => [:order_id, :amount, :txn_number, :crypt_type],
+          'indrefund'          => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type],
+          'completion'         => [:order_id, :comp_amount, :txn_number, :crypt_type],
+          'purchasecorrection' => [:order_id, :txn_number, :crypt_type],
+          'cavv_preauth'       => [:order_id, :cust_id, :amount, :pan, :expdate, :cavv, :crypt_type, :wallet_indicator],
+          'cavv_purchase'      => [:order_id, :cust_id, :amount, :pan, :expdate, :cavv, :crypt_type, :wallet_indicator],
+          'transact'           => [:order_id, :cust_id, :amount, :pan, :expdate, :crypt_type],
+          'Batchcloseall'      => [],
+          'opentotals'         => [:ecr_number],
+          'batchclose'         => [:ecr_number],
+          'res_add_cc'         => [:pan, :expdate, :crypt_type],
+          'res_delete'         => [:data_key],
+          'res_update_cc'      => [:data_key, :pan, :expdate, :crypt_type],
+          'res_purchase_cc'    => [:data_key, :order_id, :cust_id, :amount, :crypt_type],
+          'res_preauth_cc'     => [:data_key, :order_id, :cust_id, :amount, :crypt_type]
         }
       end
     end