activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/cardknox.rb

@@ -112,7 +112,7 @@ module ActiveMerchant #:nodoc:
       private
 
       def split_authorization(authorization)
-        authorization.split(";")
+        authorization.split(';')
       end
 
       def add_reference(post, reference)
@@ -134,7 +134,7 @@ module ActiveMerchant #:nodoc:
 
       def source_type_from(authorization)
         _, _, source_type = split_authorization(authorization)
-        (source_type || "credit_card").to_sym
+        (source_type || 'credit_card').to_sym
       end
 
       def add_source(post, source)
@@ -294,10 +294,10 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(response)
-        if response[:status] == "Approved"
-          "Success"
+        if response[:status] == 'Approved'
+          'Success'
         elsif response[:error].blank?
-          "Unspecified error"
+          'Unspecified error'
         else
           response[:error]
         end
@@ -310,7 +310,7 @@ module ActiveMerchant #:nodoc:
       def post_data(command, parameters = {})
         initial_parameters = {
           Key: @options[:api_key],
-          Version: "4.5.4",
+          Version: '4.5.4',
           SoftwareName: 'Active Merchant',
           SoftwareVersion: "#{ActiveMerchant::VERSION}",
           Command: command,
@@ -321,7 +321,7 @@ module ActiveMerchant #:nodoc:
         initial_parameters[:Hash] = "s/#{seed}/#{hash}/n" unless @options[:pin].blank?
         parameters = initial_parameters.merge(parameters)
 
-        parameters.reject{|k, v| v.blank?}.collect{ |key, value| "x#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        parameters.reject{|k, v| v.blank?}.collect{ |key, value| "x#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/cardprocess.rb

@@ -189,7 +189,7 @@ module ActiveMerchant #:nodoc:
         post[:authentication][:password] = @options[:password]
         post[:authentication][:entityId] = @options[:entity_id]
         post[:paymentType] = action
-        dot_flatten_hash(post).map {|key, value| "#{key}=#{CGI.escape(value.to_s)}"}.join("&")
+        dot_flatten_hash(post).map {|key, value| "#{key}=#{CGI.escape(value.to_s)}"}.join('&')
       end
 
       def error_code_from(response)

data/lib/active_merchant/billing/gateways/cashnet.rb

@@ -3,13 +3,13 @@ module ActiveMerchant #:nodoc:
     class CashnetGateway < Gateway
       include Empty
 
-      self.live_url = "https://commerce.cashnet.com/"
-      self.test_url = "https://train.cashnet.com/"
+      self.live_url = 'https://commerce.cashnet.com/'
+      self.test_url = 'https://train.cashnet.com/'
 
-      self.supported_countries = ["US"]
+      self.supported_countries = ['US']
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb]
-      self.homepage_url        = "http://www.higherone.com/"
-      self.display_name        = "Cashnet"
+      self.homepage_url        = 'http://www.higherone.com/'
+      self.display_name        = 'Cashnet'
       self.money_format        = :dollars
       self.max_retries         = 0
 
@@ -34,7 +34,7 @@ module ActiveMerchant #:nodoc:
           :password,
           :merchant_gateway_name
         )
-        options[:default_item_code] ||= "FEE"
+        options[:default_item_code] ||= 'FEE'
         super
       end
 
@@ -92,9 +92,9 @@ module ActiveMerchant #:nodoc:
         post[:merchant]       = @options[:merchant]
         post[:operator]       = @options[:operator]
         post[:password]       = @options[:password]
-        post[:station]        = (@options[:station] || "WEB")
+        post[:station]        = (@options[:station] || 'WEB')
         post[:custcode]       = (@options[:custcode] || "ActiveMerchant/#{ActiveMerchant::VERSION}")
-        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def add_creditcard(post, creditcard)
@@ -142,14 +142,14 @@ module ActiveMerchant #:nodoc:
       def handle_response(response)
         if (200...300).include?(response.code.to_i)
           return response.body
-        elsif 302 == response.code.to_i
+        elsif response.code.to_i == 302
           return ssl_get(URI.parse(response['location']))
         end
         raise ResponseError.new(response)
       end
 
       def unparsable_response(raw_response)
-        message = "Unparsable response received from Cashnet. Please contact Cashnet if you continue to receive this message."
+        message = 'Unparsable response received from Cashnet. Please contact Cashnet if you continue to receive this message.'
         message += " (The raw response returned by the API was #{raw_response.inspect})"
         return Response.new(false, message)
       end

data/lib/active_merchant/billing/gateways/cc5.rb

@@ -148,7 +148,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def commit(request)
-        raw_response = ssl_post((test? ? self.test_url : self.live_url), "DATA=" + request)
+        raw_response = ssl_post((test? ? self.test_url : self.live_url), 'DATA=' + request)
 
         response = parse(raw_response)
 
@@ -182,7 +182,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success?(response)
-        (response[:response] == "Approved")
+        (response[:response] == 'Approved')
       end
 
       def normalize(text)
@@ -190,10 +190,8 @@ module ActiveMerchant #:nodoc:
 
         if ActiveSupport::Inflector.method(:transliterate).arity == -2
           ActiveSupport::Inflector.transliterate(text,'')
-        elsif RUBY_VERSION >= '1.9'
-          text.gsub(/[^\x00-\x7F]+/, '')
         else
-          ActiveSupport::Inflector.transliterate(text).to_s
+          text.gsub(/[^\x00-\x7F]+/, '')
         end
       end
     end

data/lib/active_merchant/billing/gateways/cecabank.rb

@@ -123,7 +123,7 @@ module ActiveMerchant #:nodoc:
 
         root = REXML::Document.new(body).root
 
-        response[:success] = (root.attributes['valor'] == "OK")
+        response[:success] = (root.attributes['valor'] == 'OK')
         response[:date] = root.attributes['fecha']
         response[:operation_number] = root.attributes['numeroOperacion']
         response[:message] = root.attributes['valor']
@@ -142,7 +142,7 @@ module ActiveMerchant #:nodoc:
           response[:error_code] = root.elements['ERROR/codigo'].text
           response[:error_message] = root.elements['ERROR/descripcion'].text
         else
-          if("000" == root.elements['OPERACION'].attributes['numeroOperacion'])
+          if root.elements['OPERACION'].attributes['numeroOperacion'] == '000'
             if(root.elements['OPERACION/numeroAutorizacion'])
               response[:authorization] = root.elements['OPERACION/numeroAutorizacion'].text
             end
@@ -155,7 +155,7 @@ module ActiveMerchant #:nodoc:
 
       rescue REXML::ParseException => e
         response[:success] = false
-        response[:message] = "Unable to parse the response."
+        response[:message] = 'Unable to parse the response.'
         response[:error_message] = e.message
         response
       end
@@ -195,15 +195,15 @@ module ActiveMerchant #:nodoc:
           else
             "#{key}=#{CGI.escape(value.to_s)}"
           end
-        end.compact.join("&")
+        end.compact.join('&')
       end
 
       def build_authorization(response)
-        [response[:reference], response[:authorization]].join("|")
+        [response[:reference], response[:authorization]].join('|')
       end
 
       def split_authorization(authorization)
-        authorization.split("|")
+        authorization.split('|')
       end
 
       def generate_signature(action, parameters)

data/lib/active_merchant/billing/gateways/cenpos.rb

@@ -1,15 +1,15 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CenposGateway < Gateway
-      self.display_name = "CenPOS"
-      self.homepage_url = "https://www.cenpos.com/"
+      self.display_name = 'CenPOS'
+      self.homepage_url = 'https://www.cenpos.com/'
 
-      self.live_url = "https://ww3.cenpos.net/6/transact.asmx"
+      self.live_url = 'https://ww3.cenpos.net/6/transact.asmx'
 
       self.supported_countries = %w(AD AI AG AR AU AT BS BB BE BZ BM BR BN BG CA HR CY CZ DK DM EE FI FR DE GR GD GY HK HU IS IN IL IT JP LV LI LT LU MY MT MX MC MS NL PA PL PT KN LC MF VC SM SG SK SI ZA ES SR SE CH TR GB US UY)
-      self.default_currency = "USD"
+      self.default_currency = 'USD'
       self.money_format = :dollars
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
 
@@ -24,7 +24,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
 
-        commit("Sale", post)
+        commit('Sale', post)
       end
 
       def authorize(amount, payment_method, options={})
@@ -33,7 +33,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
 
-        commit("Auth", post)
+        commit('Auth', post)
       end
 
       def capture(amount, authorization, options={})
@@ -42,7 +42,7 @@ module ActiveMerchant #:nodoc:
         add_reference(post, authorization)
         add_customer_data(post, options)
 
-        commit("SpecialForce", post)
+        commit('SpecialForce', post)
       end
 
       def void(authorization, options={})
@@ -53,7 +53,7 @@ module ActiveMerchant #:nodoc:
         add_tax(post, options)
         add_order_id(post, options)
 
-        commit("Void", post)
+        commit('Void', post)
       end
 
       def refund(amount, authorization, options={})
@@ -62,7 +62,7 @@ module ActiveMerchant #:nodoc:
         add_reference(post, authorization)
         add_customer_data(post, options)
 
-        commit("SpecialReturn", post)
+        commit('SpecialReturn', post)
       end
 
       def credit(amount, payment_method, options={})
@@ -70,7 +70,7 @@ module ActiveMerchant #:nodoc:
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
 
-        commit("Credit", post)
+        commit('Credit', post)
       end
 
       def verify(credit_card, options={})
@@ -156,9 +156,9 @@ module ActiveMerchant #:nodoc:
           xml = ssl_post(self.live_url, data, headers)
           raw = parse(xml)
         rescue ActiveMerchant::ResponseError => e
-          if(e.response.code == "500" && e.response.body.start_with?("<s:Envelope"))
+          if(e.response.code == '500' && e.response.body.start_with?('<s:Envelope'))
             raw = {
-              message: "See transcript for detailed error description."
+              message: 'See transcript for detailed error description.'
             }
           else
             raise
@@ -180,17 +180,17 @@ module ActiveMerchant #:nodoc:
 
       def headers
         {
-          "Accept-Encoding" => "identity",
-          "Content-Type"  => "text/xml;charset=UTF-8",
-          "SOAPAction"  => "http://tempuri.org/Transactional/ProcessCreditCard"
+          'Accept-Encoding' => 'identity',
+          'Content-Type'  => 'text/xml;charset=UTF-8',
+          'SOAPAction'  => 'http://tempuri.org/Transactional/ProcessCreditCard'
         }
       end
 
       def build_request(post)
         xml = Builder::XmlMarkup.new :indent => 8
-        xml.tag!("acr:MerchantId", post.delete(:MerchantId))
-        xml.tag!("acr:Password", post.delete(:Password))
-        xml.tag!("acr:UserId", post.delete(:UserId))
+        xml.tag!('acr:MerchantId', post.delete(:MerchantId))
+        xml.tag!('acr:Password', post.delete(:Password))
+        xml.tag!('acr:UserId', post.delete(:UserId))
         post.sort.each do |field, value|
           xml.tag!("acr1:#{field}", value)
         end
@@ -217,7 +217,7 @@ module ActiveMerchant #:nodoc:
 
         doc = Nokogiri::XML(xml)
         doc.remove_namespaces!
-        body = doc.xpath("//ProcessCreditCardResult")
+        body = doc.xpath('//ProcessCreditCardResult')
         body.children.each do |node|
           if (node.elements.size == 0)
             response[node.name.underscore.to_sym] = node.text
@@ -233,32 +233,32 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response == "0"
+        response == '0'
       end
 
       def message_from(succeeded, response)
         if succeeded
-          "Succeeded"
+          'Succeeded'
         else
-          response[:message] || "Unable to read error message"
+          response[:message] || 'Unable to read error message'
         end
       end
 
       STANDARD_ERROR_CODE_MAPPING = {
-        "211" => STANDARD_ERROR_CODE[:invalid_number],
-        "252" => STANDARD_ERROR_CODE[:invalid_expiry_date],
-        "257" => STANDARD_ERROR_CODE[:invalid_cvc],
-        "333" => STANDARD_ERROR_CODE[:expired_card],
-        "1" => STANDARD_ERROR_CODE[:card_declined],
-        "99" => STANDARD_ERROR_CODE[:processing_error],
+        '211' => STANDARD_ERROR_CODE[:invalid_number],
+        '252' => STANDARD_ERROR_CODE[:invalid_expiry_date],
+        '257' => STANDARD_ERROR_CODE[:invalid_cvc],
+        '333' => STANDARD_ERROR_CODE[:expired_card],
+        '1' => STANDARD_ERROR_CODE[:card_declined],
+        '99' => STANDARD_ERROR_CODE[:processing_error],
       }
 
       def authorization_from(request, response)
-        [ response[:reference_number], request[:CardLastFourDigits], request[:Amount] ].join("|")
+        [ response[:reference_number], request[:CardLastFourDigits], request[:Amount] ].join('|')
       end
 
       def split_authorization(authorization)
-        reference_number, last_four_digits, original_amount = authorization.split("|")
+        reference_number, last_four_digits, original_amount = authorization.split('|')
         [reference_number, last_four_digits, original_amount]
       end
 
@@ -275,14 +275,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def cvv_result_code(xml)
-        cvv = validation_result_element(xml, "CVV")
+        cvv = validation_result_element(xml, 'CVV')
         return nil unless cvv
         validation_result_matches?(*validation_result_element_text(cvv.parent)) ? 'M' : 'N'
       end
 
       def avs_result_code(xml)
-        billing_address_elem = validation_result_element(xml, "Billing Address")
-        zip_code_elem = validation_result_element(xml, "Zip Code")
+        billing_address_elem = validation_result_element(xml, 'Billing Address')
+        zip_code_elem = validation_result_element(xml, 'Zip Code')
 
         return nil unless billing_address_elem && zip_code_elem
 
@@ -312,10 +312,10 @@ module ActiveMerchant #:nodoc:
 
       def validation_result_element_text(element)
         result_text = element.elements.detect { |elem|
-          elem.name == "Result"
+          elem.name == 'Result'
         }.children.detect { |elem| elem.text }.text
 
-        result_text.split(";").collect(&:strip)
+        result_text.split(';').collect(&:strip)
       end
 
       def validation_result_matches?(present, match)

data/lib/active_merchant/billing/gateways/checkout.rb

@@ -164,8 +164,8 @@ module ActiveMerchant #:nodoc:
       def commit(action, amount=nil, options={}, &builder)
         response = parse_xml(ssl_post(live_url, build_xml(action, &builder)))
         Response.new(
-          (response[:responsecode] == "0"),
-          (response[:result] || response[:error_text] || "Unknown Response"),
+          (response[:responsecode] == '0'),
+          (response[:result] || response[:error_text] || 'Unknown Response'),
           response,
           authorization: authorization_from(response, action, amount, options),
           test: test?
@@ -184,7 +184,7 @@ module ActiveMerchant #:nodoc:
       def parse_xml(xml)
         response = {}
 
-        Nokogiri::XML(CGI.unescapeHTML(xml)).xpath("//response").children.each do |node|
+        Nokogiri::XML(CGI.unescapeHTML(xml)).xpath('//response').children.each do |node|
           if node.text?
             next
           elsif (node.elements.size == 0)
@@ -202,11 +202,11 @@ module ActiveMerchant #:nodoc:
 
       def authorization_from(response, action,  amount, options)
         currency = options[:currency] || currency(amount)
-        [response[:tranid], response[:trackid], action, amount, currency].join("|")
+        [response[:tranid], response[:trackid], action, amount, currency].join('|')
       end
 
       def split_authorization(authorization)
-        transid, trackid, action, amount, currency = authorization.split("|")
+        transid, trackid, action, amount, currency = authorization.split('|')
         [transid, trackid, action, amount, currency]
       end
     end

data/lib/active_merchant/billing/gateways/checkout_v2.rb

@@ -1,13 +1,13 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CheckoutV2Gateway < Gateway
-      self.display_name = "Checkout.com V2 Gateway"
-      self.homepage_url = "https://www.checkout.com/"
-      self.live_url = "https://api2.checkout.com/v2"
-      self.test_url = "https://sandbox.checkout.com/api2/v2"
+      self.display_name = 'Checkout.com V2 Gateway'
+      self.homepage_url = 'https://www.checkout.com/'
+      self.live_url = 'https://api2.checkout.com/v2'
+      self.test_url = 'https://sandbox.checkout.com/api2/v2'
 
       self.supported_countries = ['AD', 'AE', 'AT', 'BE', 'BG', 'CH', 'CY', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FO', 'FI', 'FR', 'GB', 'GI', 'GL', 'GR', 'HR', 'HU', 'IE', 'IS', 'IL', 'IT', 'LI', 'LT', 'LU', 'LV', 'MC', 'MT', 'NL', 'NO', 'PL', 'PT', 'RO', 'SE', 'SI', 'SM', 'SK', 'SJ', 'TR', 'VA']
-      self.default_currency = "USD"
+      self.default_currency = 'USD'
       self.money_format = :cents
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
 
@@ -30,7 +30,7 @@ module ActiveMerchant #:nodoc:
 
       def authorize(amount, payment_method, options={})
         post = {}
-        post[:autoCapture] = "n"
+        post[:autoCapture] = 'n'
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
@@ -99,7 +99,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_customer_data(post, options)
-        post[:email] = options[:email] || "unspecified@example.com"
+        post[:email] = options[:email] || 'unspecified@example.com'
         post[:customerIp] = options[:ip] if options[:ip]
         address = options[:billing_address]
         if(address && post[:card])
@@ -153,8 +153,8 @@ module ActiveMerchant #:nodoc:
 
       def headers
         {
-          "Authorization" => @options[:secret_key],
-          "Content-Type"  => "application/json;charset=UTF-8"
+          'Authorization' => @options[:secret_key],
+          'Content-Type'  => 'application/json;charset=UTF-8'
         }
       end
 
@@ -182,50 +182,50 @@ module ActiveMerchant #:nodoc:
         JSON.parse(body)
         rescue JSON::ParserError
           {
-            "message" => "Invalid JSON response received from CheckoutV2Gateway. Please contact CheckoutV2Gateway if you continue to receive this message.",
-            "raw_response" => scrub(body)
+            'message' => 'Invalid JSON response received from CheckoutV2Gateway. Please contact CheckoutV2Gateway if you continue to receive this message.',
+            'raw_response' => scrub(body)
           }
       end
 
       def success_from(response)
-        (response["responseCode"] == "10000" && !response["responseMessage"].start_with?("40")) || response["responseCode"] == "10100"
+        (response['responseCode'] == '10000' && !response['responseMessage'].start_with?('40')) || response['responseCode'] == '10100'
       end
 
       def message_from(succeeded, response)
         if succeeded
-          "Succeeded"
-        elsif response["errors"]
-          response["message"] + ": " + response["errors"].first
+          'Succeeded'
+        elsif response['errors']
+          response['message'] + ': ' + response['errors'].first
         else
-          response["responseMessage"] || response["message"] || "Unable to read error message"
+          response['responseMessage'] || response['message'] || 'Unable to read error message'
         end
       end
 
       STANDARD_ERROR_CODE_MAPPING = {
-        "20014" => STANDARD_ERROR_CODE[:invalid_number],
-        "20100" => STANDARD_ERROR_CODE[:invalid_expiry_date],
-        "20054" => STANDARD_ERROR_CODE[:expired_card],
-        "40104" => STANDARD_ERROR_CODE[:incorrect_cvc],
-        "40108" => STANDARD_ERROR_CODE[:incorrect_zip],
-        "40111" => STANDARD_ERROR_CODE[:incorrect_address],
-        "20005" => STANDARD_ERROR_CODE[:card_declined],
-        "20088" => STANDARD_ERROR_CODE[:processing_error],
-        "20001" => STANDARD_ERROR_CODE[:call_issuer],
-        "30004" => STANDARD_ERROR_CODE[:pickup_card]
+        '20014' => STANDARD_ERROR_CODE[:invalid_number],
+        '20100' => STANDARD_ERROR_CODE[:invalid_expiry_date],
+        '20054' => STANDARD_ERROR_CODE[:expired_card],
+        '40104' => STANDARD_ERROR_CODE[:incorrect_cvc],
+        '40108' => STANDARD_ERROR_CODE[:incorrect_zip],
+        '40111' => STANDARD_ERROR_CODE[:incorrect_address],
+        '20005' => STANDARD_ERROR_CODE[:card_declined],
+        '20088' => STANDARD_ERROR_CODE[:processing_error],
+        '20001' => STANDARD_ERROR_CODE[:call_issuer],
+        '30004' => STANDARD_ERROR_CODE[:pickup_card]
       }
 
       def authorization_from(raw)
-        raw["id"]
+        raw['id']
       end
 
       def error_code_from(succeeded, response)
         return if succeeded
-        if response["errorCode"] && response["errorMessageCodes"]
+        if response['errorCode'] && response['errorMessageCodes']
           "#{response["errorCode"]}: #{response["errorMessageCodes"].join(", ")}"
-        elsif response["errorCode"]
-          response["errorCode"]
+        elsif response['errorCode']
+          response['errorCode']
         else
-          STANDARD_ERROR_CODE_MAPPING[response["responseCode"]]
+          STANDARD_ERROR_CODE_MAPPING[response['responseCode']]
         end
       end
     end