activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/braintree_orange.rb

@@ -7,7 +7,7 @@ module ActiveMerchant #:nodoc:
       include BraintreeCommon
 
       self.display_name = 'Braintree (Orange Platform)'
-      self.supported_countries = ["US"]
+      self.supported_countries = ['US']
 
       self.live_url = self.test_url = 'https://secure.braintreepaymentgateway.com/api/transact.php'
 

data/lib/active_merchant/billing/gateways/bridge_pay.rb

@@ -1,16 +1,16 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class BridgePayGateway < Gateway
-      self.display_name = "BridgePay"
-      self.homepage_url = "http://www.bridgepaynetwork.com/"
+      self.display_name = 'BridgePay'
+      self.homepage_url = 'http://www.bridgepaynetwork.com/'
 
-      self.test_url = "https://gatewaystage.itstgate.com/SmartPayments/transact3.asmx"
-      self.live_url = "https://gateway.itstgate.com/SmartPayments/transact3.asmx"
+      self.test_url = 'https://gatewaystage.itstgate.com/SmartPayments/transact3.asmx'
+      self.live_url = 'https://gateway.itstgate.com/SmartPayments/transact3.asmx'
 
-      self.supported_countries = ["CA", "US"]
-      self.default_currency = "USD"
+      self.supported_countries = ['CA', 'US']
+      self.default_currency = 'USD'
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb]
 
 
@@ -20,10 +20,10 @@ module ActiveMerchant #:nodoc:
       end
 
       def purchase(amount, payment_method, options={})
-        post = initialize_required_fields("Sale")
+        post = initialize_required_fields('Sale')
 
         # Allow the same amount in multiple transactions.
-        post[:ExtData] = "<Force>T</Force>"
+        post[:ExtData] = '<Force>T</Force>'
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
@@ -32,7 +32,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorize(amount, payment_method, options={})
-        post = initialize_required_fields("Auth")
+        post = initialize_required_fields('Auth')
 
         add_invoice(post, amount, options)
         add_payment_method(post, payment_method)
@@ -42,7 +42,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def capture(amount, authorization, options={})
-        post = initialize_required_fields("Force")
+        post = initialize_required_fields('Force')
 
         add_invoice(post, amount, options)
         add_reference(post, authorization)
@@ -52,7 +52,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def refund(amount, authorization, options={})
-        post = initialize_required_fields("Return")
+        post = initialize_required_fields('Return')
 
         add_invoice(post, amount, options)
         add_reference(post, authorization)
@@ -61,7 +61,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def void(authorization, options={})
-        post = initialize_required_fields("Void")
+        post = initialize_required_fields('Void')
 
         add_reference(post, authorization)
 
@@ -114,36 +114,36 @@ module ActiveMerchant #:nodoc:
           post[:TransitNum] = payment_method.routing_number
           post[:AccountNum] = payment_method.account_number
           post[:NameOnCheck] = payment_method.name
-          post[:ExtData] = "<AccountType>#{payment_method.account_type.capitalize}</AccountType>"
+          post[:ExtData] = "<AccountType>#{payment_method.account_type.capitalize}</AccountType>" if payment_method.account_type
         end
       end
 
       def add_token(post, payment_method)
-        payment_method = payment_method.split("|")
+        payment_method = payment_method.split('|')
         post[:ExtData] = "<Force>T</Force><CardVault><Transaction>Read</Transaction><CustomerPaymentInfoKey>#{payment_method[1]}</CustomerPaymentInfoKey><Token>#{payment_method[0]}</Token><ExpDate>#{payment_method[2]}</ExpDate></CardVault>"
       end
 
       def initialize_required_fields(transaction_type)
         post = {}
         post[:TransType] = transaction_type
-        post[:Amount] = ""
-        post[:PNRef] = ""
-        post[:InvNum] = ""
-        post[:CardNum] = ""
-        post[:ExpDate] = ""
-        post[:MagData] = ""
-        post[:NameOnCard] = ""
-        post[:Zip] = ""
-        post[:Street] = ""
-        post[:CVNum] = ""
-        post[:MagData] = ""
-        post[:ExtData] = ""
-        post[:MICR] = ""
-        post[:DL] = ""
-        post[:SS] = ""
-        post[:DOB] = ""
-        post[:StateCode] = ""
-        post[:CheckType] = ""
+        post[:Amount] = ''
+        post[:PNRef] = ''
+        post[:InvNum] = ''
+        post[:CardNum] = ''
+        post[:ExpDate] = ''
+        post[:MagData] = ''
+        post[:NameOnCard] = ''
+        post[:Zip] = ''
+        post[:Street] = ''
+        post[:CVNum] = ''
+        post[:MagData] = ''
+        post[:ExtData] = ''
+        post[:MICR] = ''
+        post[:DL] = ''
+        post[:SS] = ''
+        post[:DOB] = ''
+        post[:StateCode] = ''
+        post[:CheckType] = ''
         post
       end
 
@@ -167,7 +167,7 @@ module ActiveMerchant #:nodoc:
         response = {}
 
         doc = Nokogiri::XML(xml)
-        doc.root.xpath("*").each do |node|
+        doc.root.xpath('*').each do |node|
           if (node.elements.size == 0)
             response[node.name.downcase.to_sym] = node.text
           else
@@ -208,7 +208,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response[:result] == "0"
+        response[:result] == '0'
       end
 
       def message_from(response)
@@ -217,14 +217,14 @@ module ActiveMerchant #:nodoc:
 
       def authorization_from(response)
         if response[:token]
-          [response[:token], response[:customerpaymentinfokey], response[:expdate]].join("|")
+          [response[:token], response[:customerpaymentinfokey], response[:expdate]].join('|')
         else
-          [response[:authcode], response[:pnref]].join("|")
+          [response[:authcode], response[:pnref]].join('|')
         end
       end
 
       def split_authorization(authorization)
-        authcode, pnref = authorization.split("|")
+        authcode, pnref = authorization.split('|')
         [authcode, pnref]
       end
 
@@ -238,7 +238,7 @@ module ActiveMerchant #:nodoc:
         {
           :UserName => @options[:user_name],
           :Password => @options[:password]
-        }.merge(post).collect{|k,v| "#{k}=#{CGI.escape(v.to_s)}"}.join("&")
+        }.merge(post).collect{|k,v| "#{k}=#{CGI.escape(v.to_s)}"}.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/cams.rb

@@ -1,7 +1,7 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CamsGateway < Gateway
-      self.live_url = "https://secure.centralams.com/gw/api/transact.php"
+      self.live_url = 'https://secure.centralams.com/gw/api/transact.php'
 
       self.supported_countries = ['US']
       self.default_currency = 'USD'
@@ -83,7 +83,7 @@ module ActiveMerchant #:nodoc:
           post[:transactionid] = split_authorization(payment)[0]
         end
 
-        commit("sale", post)
+        commit('sale', post)
       end
 
       def authorize(money, payment, options={})
@@ -156,8 +156,8 @@ module ActiveMerchant #:nodoc:
 
       def add_reference(post, authorization)
         transaction_id, authcode = split_authorization(authorization)
-        post["transactionid"] = transaction_id
-        post["authcode"]      = authcode
+        post['transactionid'] = transaction_id
+        post['authcode']      = authcode
       end
 
       def add_invoice(post, money, options)
@@ -172,10 +172,10 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(body)
-        kvs = body.split("&")
+        kvs = body.split('&')
 
         kvs.inject({}) { |h, kv|
-          k,v = kv.split("=")
+          k,v = kv.split('=')
           h[k] = v
           h
         }
@@ -199,19 +199,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def success_from(response)
-        response["response_code"] == "100"
+        response['response_code'] == '100'
       end
 
       def message_from(response)
-        response["responsetext"]
+        response['responsetext']
       end
 
       def authorization_from(response)
-        [response["transactionid"], response["authcode"]].join("#")
+        [response['transactionid'], response['authcode']].join('#')
       end
 
       def split_authorization(authorization)
-        transaction_id, authcode = authorization.split("#")
+        transaction_id, authcode = authorization.split('#')
         [transaction_id, authcode]
       end
 
@@ -219,11 +219,11 @@ module ActiveMerchant #:nodoc:
         parameters[:password] = @options[:password]
         parameters[:username] = @options[:username]
 
-        parameters.collect{|k,v| "#{k}=#{v}" }.join("&")
+        parameters.collect{|k,v| "#{k}=#{v}" }.join('&')
       end
 
       def error_code_from(response)
-        STANDARD_ERROR_CODE_MAPPING[response["response_code"]]
+        STANDARD_ERROR_CODE_MAPPING[response['response_code']]
       end
     end
   end

data/lib/active_merchant/billing/gateways/card_connect.rb

@@ -130,6 +130,21 @@ module ActiveMerchant #:nodoc:
         authorize(0, credit_card, options)
       end
 
+      def store(payment, options = {})
+        post = {}
+        add_payment(post, payment)
+        add_address(post, options)
+        add_customer_data(post, options)
+        commit('profile', post)
+      end
+
+      def unstore(authorization, options = {})
+        account_id, profile_id = authorization.split('|')
+        commit('profile', {},
+               verb: :delete,
+               path: "/#{profile_id}/#{account_id}/#{@options[:merchant_id]}")
+      end
+
       def supports_scrubbing?
         true
       end
@@ -175,13 +190,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_payment(post, payment)
-        post[:name] = payment.name
-        if card_brand(payment) == 'check'
-          add_echeck(post, payment)
+        if payment.is_a?(String)
+          account_id, profile_id = payment.split('|')
+          post[:profile] = profile_id
+          post[:acctid] = account_id
         else
-          post[:account] = payment.number
-          post[:expiry] = expdate(payment)
-          post[:cvv2] = payment.verification_value
+          post[:name] = payment.name
+          if card_brand(payment) == 'check'
+            add_echeck(post, payment)
+          else
+            post[:account] = payment.number
+            post[:expiry] = expdate(payment)
+            post[:cvv2] = payment.verification_value
+          end
         end
       end
 
@@ -237,18 +258,18 @@ module ActiveMerchant #:nodoc:
         JSON.parse(body)
       end
 
-      def url(action)
+      def url(action, path)
         if test?
-          test_url + action
+          test_url + action + path
         else
-          (@options[:domain] ? @options[:domain] : live_url) + action
+          (@options[:domain] || live_url) + action + path
         end
       end
 
-      def commit(action, parameters)
+      def commit(action, parameters, verb: :put, path: '')
         parameters[:merchid] = @options[:merchant_id]
-        url = url(action)
-        response = parse(ssl_request(:put, url, post_data(parameters), headers))
+        url = url(action, path)
+        response = parse(ssl_request(verb, url, post_data(parameters), headers))
 
         Response.new(
           success_from(response),
@@ -271,7 +292,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_from(response)
-        response['retref']
+        if response['profileid']
+          "#{response['acctid']}|#{response['profileid']}"
+        else
+          response['retref']
+        end
       end
 
       def post_data(parameters = {})

data/lib/active_merchant/billing/gateways/card_stream.rb

@@ -2,7 +2,7 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class CardStreamGateway < Gateway
 
-      THREEDSECURE_REQUIRED_DEPRECATION_MESSAGE = "Specifying the :threeDSRequired initialization option is deprecated. Please use the `:threeds_required => true` *transaction* option instead."
+      THREEDSECURE_REQUIRED_DEPRECATION_MESSAGE = 'Specifying the :threeDSRequired initialization option is deprecated. Please use the `:threeds_required => true` *transaction* option instead.'
 
       self.test_url = self.live_url = 'https://gateway.cardstream.com/direct/'
       self.money_format = :cents
@@ -13,96 +13,96 @@ module ActiveMerchant #:nodoc:
       self.display_name = 'CardStream'
 
       CURRENCY_CODES = {
-        "AED" => "784",
-        "ALL" => "008",
-        "AMD" => "051",
-        "ANG" => "532",
-        "ARS" => "032",
-        "AUD" => "036",
-        "AWG" => "533",
-        "BAM" => "977",
-        "BBD" => "052",
-        "BGN" => "975",
-        "BMD" => "060",
-        "BOB" => "068",
-        "BRL" => "986",
-        "BSD" => "044",
-        "BWP" => "072",
-        "BZD" => "084",
-        "CAD" => "124",
-        "CHF" => "756",
-        "CLP" => "152",
-        "CNY" => "156",
-        "COP" => "170",
-        "CRC" => "188",
-        "CZK" => "203",
-        "DKK" => "208",
-        "DOP" => "214",
-        "EGP" => "818",
-        "EUR" => "978",
-        "GBP" => "826",
-        "GEL" => "981",
-        "GIP" => "292",
-        "GTQ" => "320",
-        "GYD" => "328",
-        "HKD" => "344",
-        "HNL" => "340",
-        "HRK" => "191",
-        "HUF" => "348",
-        "ISK" => "352",
-        "IDR" => "360",
-        "ILS" => "376",
-        "INR" => "356",
-        "JPY" => "392",
-        "JMD" => "388",
-        "KES" => "404",
-        "KRW" => "410",
-        "KYD" => "136",
-        "LBP" => "422",
-        "LKR" => "144",
-        "MAD" => "504",
-        "MVR" => "462",
-        "MWK" => "454",
-        "MXN" => "484",
-        "MYR" => "458",
-        "NAD" => "516",
-        "NGN" => "566",
-        "NIO" => "558",
-        "NOK" => "578",
-        "NPR" => "524",
-        "NZD" => "554",
-        "PAB" => "590",
-        "PEN" => "604",
-        "PGK" => "598",
-        "PHP" => "608",
-        "PKR" => "586",
-        "PLN" => "985",
-        "PYG" => "600",
-        "QAR" => "634",
-        "RON" => "946",
-        "RSD" => "941",
-        "RUB" => "643",
-        "RWF" => "646",
-        "SAR" => "682",
-        "SEK" => "752",
-        "SGD" => "702",
-        "SRD" => "968",
-        "THB" => "764",
-        "TND" => "788",
-        "TRY" => "949",
-        "TTD" => "780",
-        "TWD" => "901",
-        "TZS" => "834",
-        "UAH" => "980",
-        "UGX" => "800",
-        "USD" => "840",
-        "UYU" => "858",
-        "VND" => "704",
-        "WST" => "882",
-        "XAF" => "950",
-        "XCD" => "951",
-        "XOF" => "952",
-        "ZAR" => "710"
+        'AED' => '784',
+        'ALL' => '008',
+        'AMD' => '051',
+        'ANG' => '532',
+        'ARS' => '032',
+        'AUD' => '036',
+        'AWG' => '533',
+        'BAM' => '977',
+        'BBD' => '052',
+        'BGN' => '975',
+        'BMD' => '060',
+        'BOB' => '068',
+        'BRL' => '986',
+        'BSD' => '044',
+        'BWP' => '072',
+        'BZD' => '084',
+        'CAD' => '124',
+        'CHF' => '756',
+        'CLP' => '152',
+        'CNY' => '156',
+        'COP' => '170',
+        'CRC' => '188',
+        'CZK' => '203',
+        'DKK' => '208',
+        'DOP' => '214',
+        'EGP' => '818',
+        'EUR' => '978',
+        'GBP' => '826',
+        'GEL' => '981',
+        'GIP' => '292',
+        'GTQ' => '320',
+        'GYD' => '328',
+        'HKD' => '344',
+        'HNL' => '340',
+        'HRK' => '191',
+        'HUF' => '348',
+        'ISK' => '352',
+        'IDR' => '360',
+        'ILS' => '376',
+        'INR' => '356',
+        'JPY' => '392',
+        'JMD' => '388',
+        'KES' => '404',
+        'KRW' => '410',
+        'KYD' => '136',
+        'LBP' => '422',
+        'LKR' => '144',
+        'MAD' => '504',
+        'MVR' => '462',
+        'MWK' => '454',
+        'MXN' => '484',
+        'MYR' => '458',
+        'NAD' => '516',
+        'NGN' => '566',
+        'NIO' => '558',
+        'NOK' => '578',
+        'NPR' => '524',
+        'NZD' => '554',
+        'PAB' => '590',
+        'PEN' => '604',
+        'PGK' => '598',
+        'PHP' => '608',
+        'PKR' => '586',
+        'PLN' => '985',
+        'PYG' => '600',
+        'QAR' => '634',
+        'RON' => '946',
+        'RSD' => '941',
+        'RUB' => '643',
+        'RWF' => '646',
+        'SAR' => '682',
+        'SEK' => '752',
+        'SGD' => '702',
+        'SRD' => '968',
+        'THB' => '764',
+        'TND' => '788',
+        'TRY' => '949',
+        'TTD' => '780',
+        'TWD' => '901',
+        'TZS' => '834',
+        'UAH' => '980',
+        'UGX' => '800',
+        'USD' => '840',
+        'UYU' => '858',
+        'VND' => '704',
+        'WST' => '882',
+        'XAF' => '950',
+        'XCD' => '951',
+        'XOF' => '952',
+        'ZAR' => '710'
       }
 
       CVV_CODE = {
@@ -118,11 +118,11 @@ module ActiveMerchant #:nodoc:
       # 4 - Postcode not matched.
       # 8 - Postcode partially matched.
       AVS_POSTAL_MATCH = {
-        "0" => nil,
-        "1" => nil,
-        "2" => "Y",
-        "4" => "N",
-        "8" => "N"
+        '0' => nil,
+        '1' => nil,
+        '2' => 'Y',
+        '4' => 'N',
+        '8' => 'N'
       }
 
       # 0 - No additional information available.
@@ -131,11 +131,11 @@ module ActiveMerchant #:nodoc:
       # 4 - Address numeric not matched.
       # 8 - Address numeric partially matched.
       AVS_STREET_MATCH = {
-        "0" => nil,
-        "1" => nil,
-        "2" => "Y",
-        "4" => "N",
-        "8" => "N"
+        '0' => nil,
+        '1' => nil,
+        '2' => 'Y',
+        '4' => 'N',
+        '8' => 'N'
       }
 
       def initialize(options = {})
@@ -189,7 +189,7 @@ module ActiveMerchant #:nodoc:
         return response if response.success?
         return response unless options[:force_full_refund_if_unsettled]
 
-        if response.params["responseCode"] == "65541"
+        if response.params['responseCode'] == '65541'
           void(authorization, options)
         else
           response
@@ -295,11 +295,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def normalize_line_endings(str)
-        str.gsub(/%0D%0A|%0A%0D|%0D/, "%0A")
+        str.gsub(/%0D%0A|%0A%0D|%0D/, '%0A')
       end
 
       def add_hmac(post)
-        result = post.sort.collect { |key, value| "#{key}=#{normalize_line_endings(CGI.escape(value.to_s))}" }.join("&")
+        result = post.sort.collect { |key, value| "#{key}=#{normalize_line_endings(CGI.escape(value.to_s))}" }.join('&')
         result = Digest::SHA512.hexdigest("#{result}#{@options[:shared_secret]}")
 
         add_pair(post, :signature, result)
@@ -307,9 +307,9 @@ module ActiveMerchant #:nodoc:
 
       def parse(body)
         result = {}
-        pairs = body.split("&")
+        pairs = body.split('&')
         pairs.each do |pair|
-          a = pair.split("=")
+          a = pair.split('=')
           # because some value pairs don't have a value
           result[a[0].to_sym] = a[1] == nil ? '' : CGI.unescape(a[1])
         end
@@ -327,8 +327,8 @@ module ActiveMerchant #:nodoc:
 
         response = parse(ssl_post(self.live_url, post_data(action, parameters)))
 
-        Response.new(response[:responseCode] == "0",
-                     response[:responseCode] == "0" ? "APPROVED" : response[:responseMessage],
+        Response.new(response[:responseCode] == '0',
+                     response[:responseCode] == '0' ? 'APPROVED' : response[:responseMessage],
                      response,
                      :test => test?,
                      :authorization => response[:xref],
@@ -341,14 +341,14 @@ module ActiveMerchant #:nodoc:
         postal_match = AVS_POSTAL_MATCH[response[:avscv2ResponseCode].to_s[1, 1]]
         street_match = AVS_STREET_MATCH[response[:avscv2ResponseCode].to_s[2, 1]]
 
-        code = if postal_match == "Y" && street_match == "Y"
-          "M"
-        elsif postal_match == "Y"
-          "P"
-        elsif street_match == "Y"
-          "A"
+        code = if postal_match == 'Y' && street_match == 'Y'
+          'M'
+        elsif postal_match == 'Y'
+          'P'
+        elsif street_match == 'Y'
+          'A'
         else
-          "I"
+          'I'
         end
 
         AVSResult.new({
@@ -364,7 +364,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def post_data(action, parameters = {})
-        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def add_pair(post, key, value, options = {})