activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/epay.rb

@@ -191,7 +191,7 @@ module ActiveMerchant #:nodoc:
 
       def do_authorize(params)
         headers = {}
-        headers['Referer'] = (options[:password] || "activemerchant.org")
+        headers['Referer'] = (options[:password] || 'activemerchant.org')
 
         response = raw_ssl_request(:post, live_url + 'auth/default.aspx', authorize_post_data(params), headers)
 
@@ -244,7 +244,7 @@ module ActiveMerchant #:nodoc:
       def make_headers(data, soap_call)
         {
           'Content-Type' => 'text/xml; charset=utf-8',
-          'Host' => "ssl.ditonlinebetalingssystem.dk",
+          'Host' => 'ssl.ditonlinebetalingssystem.dk',
           'Content-Length' => data.size.to_s,
           'SOAPAction' => self.live_url + 'remote/payment/' + soap_call
         }
@@ -274,12 +274,12 @@ module ActiveMerchant #:nodoc:
         params[:declineurl] = live_url + 'auth/default.aspx?decline=1'
         params[:merchantnumber] = @options[:login]
 
-        params.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        params.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       # Limited to 20 digits max
       def format_order_number(number)
-        number.to_s.gsub(/[^\w]/, '').rjust(4, "0")[0...20]
+        number.to_s.gsub(/[^\w]/, '').rjust(4, '0')[0...20]
       end
     end
   end

data/lib/active_merchant/billing/gateways/evo_ca.rb

@@ -301,7 +301,7 @@ module ActiveMerchant #:nodoc:
           post[:username] = options[:username]
           post[:password] = options[:password]
         end
-        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" unless value.nil? }.compact.join("&")
+        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" unless value.nil? }.compact.join('&')
       end
     end
   end

data/lib/active_merchant/billing/gateways/eway.rb

@@ -65,13 +65,13 @@ module ActiveMerchant #:nodoc:
 
       private
       def requires_address!(options)
-        raise ArgumentError.new("Missing eWay required parameters: address or billing_address") unless (options.has_key?(:address) or options.has_key?(:billing_address))
+        raise ArgumentError.new('Missing eWay required parameters: address or billing_address') unless (options.has_key?(:address) or options.has_key?(:billing_address))
       end
 
       def add_creditcard(post, creditcard)
         post[:CardNumber]  = creditcard.number
-        post[:CardExpiryMonth]  = sprintf("%.2i", creditcard.month)
-        post[:CardExpiryYear] = sprintf("%.4i", creditcard.year)[-2..-1]
+        post[:CardExpiryMonth]  = sprintf('%.2i', creditcard.month)
+        post[:CardExpiryYear] = sprintf('%.4i', creditcard.year)[-2..-1]
         post[:CustomerFirstName] = creditcard.first_name
         post[:CustomerLastName]  = creditcard.last_name
         post[:CardHoldersName] = creditcard.name
@@ -119,7 +119,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success?(response)
-        response[:ewaytrxnstatus] == "True"
+        response[:ewaytrxnstatus] == 'True'
       end
 
       def parse(xml)
@@ -134,7 +134,7 @@ module ActiveMerchant #:nodoc:
 
       def post_data(parameters = {})
         xml   = REXML::Document.new
-        root  = xml.add_element("ewaygateway")
+        root  = xml.add_element('ewaygateway')
 
         parameters.each do |key, value|
           root.add_element("eway#{key}").text = value
@@ -159,66 +159,66 @@ module ActiveMerchant #:nodoc:
       end
 
       MESSAGES = {
-        "00" => "Transaction Approved",
-        "01" => "Refer to Issuer",
-        "02" => "Refer to Issuer, special",
-        "03" => "No Merchant",
-        "04" => "Pick Up Card",
-        "05" => "Do Not Honour",
-        "06" => "Error",
-        "07" => "Pick Up Card, Special",
-        "08" => "Honour With Identification",
-        "09" => "Request In Progress",
-        "10" => "Approved For Partial Amount",
-        "11" => "Approved, VIP",
-        "12" => "Invalid Transaction",
-        "13" => "Invalid Amount",
-        "14" => "Invalid Card Number",
-        "15" => "No Issuer",
-        "16" => "Approved, Update Track 3",
-        "19" => "Re-enter Last Transaction",
-        "21" => "No Action Taken",
-        "22" => "Suspected Malfunction",
-        "23" => "Unacceptable Transaction Fee",
-        "25" => "Unable to Locate Record On File",
-        "30" => "Format Error",
-        "31" => "Bank Not Supported By Switch",
-        "33" => "Expired Card, Capture",
-        "34" => "Suspected Fraud, Retain Card",
-        "35" => "Card Acceptor, Contact Acquirer, Retain Card",
-        "36" => "Restricted Card, Retain Card",
-        "37" => "Contact Acquirer Security Department, Retain Card",
-        "38" => "PIN Tries Exceeded, Capture",
-        "39" => "No Credit Account",
-        "40" => "Function Not Supported",
-        "41" => "Lost Card",
-        "42" => "No Universal Account",
-        "43" => "Stolen Card",
-        "44" => "No Investment Account",
-        "51" => "Insufficient Funds",
-        "52" => "No Cheque Account",
-        "53" => "No Savings Account",
-        "54" => "Expired Card",
-        "55" => "Incorrect PIN",
-        "56" => "No Card Record",
-        "57" => "Function Not Permitted to Cardholder",
-        "58" => "Function Not Permitted to Terminal",
-        "59" => "Suspected Fraud",
-        "60" => "Acceptor Contact Acquirer",
-        "61" => "Exceeds Withdrawal Limit",
-        "62" => "Restricted Card",
-        "63" => "Security Violation",
-        "64" => "Original Amount Incorrect",
-        "66" => "Acceptor Contact Acquirer, Security",
-        "67" => "Capture Card",
-        "75" => "PIN Tries Exceeded",
-        "82" => "CVV Validation Error",
-        "90" => "Cutoff In Progress",
-        "91" => "Card Issuer Unavailable",
-        "92" => "Unable To Route Transaction",
-        "93" => "Cannot Complete, Violation Of The Law",
-        "94" => "Duplicate Transaction",
-        "96" => "System Error"
+        '00' => 'Transaction Approved',
+        '01' => 'Refer to Issuer',
+        '02' => 'Refer to Issuer, special',
+        '03' => 'No Merchant',
+        '04' => 'Pick Up Card',
+        '05' => 'Do Not Honour',
+        '06' => 'Error',
+        '07' => 'Pick Up Card, Special',
+        '08' => 'Honour With Identification',
+        '09' => 'Request In Progress',
+        '10' => 'Approved For Partial Amount',
+        '11' => 'Approved, VIP',
+        '12' => 'Invalid Transaction',
+        '13' => 'Invalid Amount',
+        '14' => 'Invalid Card Number',
+        '15' => 'No Issuer',
+        '16' => 'Approved, Update Track 3',
+        '19' => 'Re-enter Last Transaction',
+        '21' => 'No Action Taken',
+        '22' => 'Suspected Malfunction',
+        '23' => 'Unacceptable Transaction Fee',
+        '25' => 'Unable to Locate Record On File',
+        '30' => 'Format Error',
+        '31' => 'Bank Not Supported By Switch',
+        '33' => 'Expired Card, Capture',
+        '34' => 'Suspected Fraud, Retain Card',
+        '35' => 'Card Acceptor, Contact Acquirer, Retain Card',
+        '36' => 'Restricted Card, Retain Card',
+        '37' => 'Contact Acquirer Security Department, Retain Card',
+        '38' => 'PIN Tries Exceeded, Capture',
+        '39' => 'No Credit Account',
+        '40' => 'Function Not Supported',
+        '41' => 'Lost Card',
+        '42' => 'No Universal Account',
+        '43' => 'Stolen Card',
+        '44' => 'No Investment Account',
+        '51' => 'Insufficient Funds',
+        '52' => 'No Cheque Account',
+        '53' => 'No Savings Account',
+        '54' => 'Expired Card',
+        '55' => 'Incorrect PIN',
+        '56' => 'No Card Record',
+        '57' => 'Function Not Permitted to Cardholder',
+        '58' => 'Function Not Permitted to Terminal',
+        '59' => 'Suspected Fraud',
+        '60' => 'Acceptor Contact Acquirer',
+        '61' => 'Exceeds Withdrawal Limit',
+        '62' => 'Restricted Card',
+        '63' => 'Security Violation',
+        '64' => 'Original Amount Incorrect',
+        '66' => 'Acceptor Contact Acquirer, Security',
+        '67' => 'Capture Card',
+        '75' => 'PIN Tries Exceeded',
+        '82' => 'CVV Validation Error',
+        '90' => 'Cutoff In Progress',
+        '91' => 'Card Issuer Unavailable',
+        '92' => 'Unable To Route Transaction',
+        '93' => 'Cannot Complete, Violation Of The Law',
+        '94' => 'Duplicate Transaction',
+        '96' => 'System Error'
       }
     end
   end

data/lib/active_merchant/billing/gateways/eway_managed.rb

@@ -46,7 +46,7 @@ module ActiveMerchant #:nodoc:
         add_address(post, billing_address)
         add_misc_fields(post, options)
 
-        commit("CreateCustomer", post)
+        commit('CreateCustomer', post)
       end
 
       def update(billing_id, creditcard, options={})
@@ -64,7 +64,7 @@ module ActiveMerchant #:nodoc:
         add_address(post, billing_address)
         add_misc_fields(post, options)
 
-        commit("UpdateCustomer", post)
+        commit('UpdateCustomer', post)
       end
 
       # Process a payment in the given amount against the stored credit card given by billing_id
@@ -86,7 +86,7 @@ module ActiveMerchant #:nodoc:
         post[:amount]=money
         add_invoice(post, options)
 
-        commit("ProcessPayment", post)
+        commit('ProcessPayment', post)
       end
 
       # Get customer's stored credit card details given by billing_id
@@ -98,7 +98,7 @@ module ActiveMerchant #:nodoc:
         post = {}
         post[:managedCustomerID] = billing_id.to_s
 
-        commit("QueryCustomer", post)
+        commit('QueryCustomer', post)
       end
 
       # TODO: eWay API also provides QueryPayment
@@ -106,8 +106,8 @@ module ActiveMerchant #:nodoc:
       private
 
       def eway_requires!(hash)
-        raise ArgumentError.new("Missing eWay required parameter in `billing_address`: title") unless hash.has_key?(:title)
-        raise ArgumentError.new("Missing eWay required parameter in `billing_address`: country") unless hash.has_key?(:country)
+        raise ArgumentError.new('Missing eWay required parameter in `billing_address`: title') unless hash.has_key?(:title)
+        raise ArgumentError.new('Missing eWay required parameter in `billing_address`: country') unless hash.has_key?(:country)
       end
 
       def add_address(post, address)
@@ -140,8 +140,8 @@ module ActiveMerchant #:nodoc:
       # add credit card details to be stored by eway. NOTE eway requires "title" field
       def add_creditcard(post, creditcard)
         post[:CCNumber]  = creditcard.number
-        post[:CCExpiryMonth]  = sprintf("%.2i", creditcard.month)
-        post[:CCExpiryYear] = sprintf("%.4i", creditcard.year)[-2..-1]
+        post[:CCExpiryMonth]  = sprintf('%.2i', creditcard.month)
+        post[:CCExpiryYear] = sprintf('%.4i', creditcard.year)[-2..-1]
         post[:CCNameOnCard] = creditcard.name
         post[:FirstName] = creditcard.first_name
         post[:LastName]  = creditcard.last_name
@@ -150,7 +150,7 @@ module ActiveMerchant #:nodoc:
       def parse(body)
         reply = {}
         xml = REXML::Document.new(body)
-        if root = REXML::XPath.first(xml, "//soap:Fault") then
+        if root = REXML::XPath.first(xml, '//soap:Fault') then
            reply=parse_fault(root)
         else
           if root = REXML::XPath.first(xml, '//ProcessPaymentResponse/ewayResponse') then
@@ -173,12 +173,12 @@ module ActiveMerchant #:nodoc:
                     # ERROR: This state should never occur. If there is a problem,
                     #        a soap:Fault will be returned. The presence of this
                     #        element always means a success.
-                    raise StandardError, "Unexpected \"false\" in UpdateCustomerResult"
+                    raise StandardError, 'Unexpected "false" in UpdateCustomerResult'
                   end
                 else
                   # ERROR: This state should never occur currently. We have handled
                   #        responses for all the methods which we support.
-                  raise StandardError, "Unexpected response"
+                  raise StandardError, 'Unexpected response'
                 end
               end
             end

data/lib/active_merchant/billing/gateways/eway_rapid.rb

@@ -3,15 +3,15 @@ require 'json'
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class EwayRapidGateway < Gateway
-      self.test_url = "https://api.sandbox.ewaypayments.com/"
-      self.live_url = "https://api.ewaypayments.com/"
+      self.test_url = 'https://api.sandbox.ewaypayments.com/'
+      self.live_url = 'https://api.ewaypayments.com/'
 
       self.money_format = :cents
       self.supported_countries = ['AU', 'NZ', 'GB', 'SG', 'MY', 'HK']
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb]
-      self.homepage_url = "http://www.eway.com.au/"
-      self.display_name = "eWAY Rapid 3.1"
-      self.default_currency = "AUD"
+      self.homepage_url = 'http://www.eway.com.au/'
+      self.display_name = 'eWAY Rapid 3.1'
+      self.default_currency = 'AUD'
 
       class_attribute :partner_id
 
@@ -72,13 +72,13 @@ module ActiveMerchant #:nodoc:
         add_metadata(params, options)
         add_invoice(params, amount, options)
         add_reference(params, identification)
-        commit(url_for("CapturePayment"), params)
+        commit(url_for('CapturePayment'), params)
       end
 
       def void(identification, options = {})
         params = {}
         add_reference(params, identification)
-        commit(url_for("CancelAuthorisation"), params)
+        commit(url_for('CancelAuthorisation'), params)
       end
 
       # Public: Refund a transaction.
@@ -109,8 +109,8 @@ module ActiveMerchant #:nodoc:
       def refund(amount, identification, options = {})
         params = {}
         add_metadata(params, options)
-        add_invoice(params, amount, options, "Refund")
-        add_reference(params["Refund"], identification)
+        add_invoice(params, amount, options, 'Refund')
+        add_reference(params['Refund'], identification)
         add_customer_data(params, options)
         commit(url_for("Transaction/#{identification}/Refund"), params)
       end
@@ -140,7 +140,7 @@ module ActiveMerchant #:nodoc:
         add_customer_data(params, options)
         add_credit_card(params, payment_method, options)
         params['Method'] = 'CreateTokenCustomer'
-        commit(url_for("Transaction"), params)
+        commit(url_for('Transaction'), params)
       end
 
       # Public: Update a customer's data
@@ -170,7 +170,7 @@ module ActiveMerchant #:nodoc:
         add_credit_card(params, payment_method, options)
         add_customer_token(params, customer_token)
         params['Method'] = 'UpdateTokenCustomer'
-        commit(url_for("Transaction"), params)
+        commit(url_for('Transaction'), params)
       end
 
       def supports_scrubbing
@@ -197,7 +197,7 @@ module ActiveMerchant #:nodoc:
         params
       end
 
-      def add_invoice(params, money, options, key = "Payment")
+      def add_invoice(params, money, options, key = 'Payment')
         currency_code = options[:currency] || currency(money)
         params[key] = {
           'TotalAmount' => localized_amount(money, currency_code),
@@ -243,8 +243,8 @@ module ActiveMerchant #:nodoc:
           card_details = params['Customer']['CardDetails'] = {}
           card_details['Name'] = truncate(credit_card.name, 50)
           card_details['Number'] = credit_card.number
-          card_details['ExpiryMonth'] = "%02d" % (credit_card.month || 0)
-          card_details['ExpiryYear'] = "%02d" % (credit_card.year || 0)
+          card_details['ExpiryMonth'] = '%02d' % (credit_card.month || 0)
+          card_details['ExpiryYear'] = '%02d' % (credit_card.year || 0)
           card_details['CVN'] = credit_card.verification_value
         else
           add_customer_token(params, credit_card)
@@ -262,8 +262,8 @@ module ActiveMerchant #:nodoc:
 
       def commit(url, params)
         headers = {
-          "Authorization" => ("Basic " + Base64.strict_encode64(@options[:login].to_s + ":" + @options[:password].to_s).chomp),
-          "Content-Type" => "application/json"
+          'Authorization' => ('Basic ' + Base64.strict_encode64(@options[:login].to_s + ':' + @options[:password].to_s).chomp),
+          'Content-Type' => 'application/json'
         }
         request = params.to_json
         raw = parse(ssl_post(url, request, headers))
@@ -287,12 +287,12 @@ module ActiveMerchant #:nodoc:
       end
 
       def success?(response)
-        if response['ResponseCode'] == "00"
+        if response['ResponseCode'] == '00'
           true
         elsif response['TransactionStatus']
           (response['TransactionStatus'] == true)
-        elsif response["Succeeded"]
-          (response["Succeeded"] == true)
+        elsif response['Succeeded']
+          (response['Succeeded'] == true)
         else
           false
         end
@@ -311,9 +311,9 @@ module ActiveMerchant #:nodoc:
         elsif response['ResponseCode']
           ActiveMerchant::Billing::EwayGateway::MESSAGES[response['ResponseCode']]
         elsif succeeded
-          "Succeeded"
+          'Succeeded'
         else
-          "Failed"
+          'Failed'
         end
       end
 
@@ -326,12 +326,12 @@ module ActiveMerchant #:nodoc:
       def avs_result_from(response)
         verification = response['Verification'] || {}
         code = case verification['Address']
-        when "Valid"
-          "M"
-        when "Invalid"
-          "N"
+        when 'Valid'
+          'M'
+        when 'Invalid'
+          'N'
         else
-          "I"
+          'I'
         end
         {:code => code}
       end
@@ -339,12 +339,12 @@ module ActiveMerchant #:nodoc:
       def cvv_result_from(response)
         verification = response['Verification'] || {}
         case verification['CVN']
-        when "Valid"
-          "M"
-        when "Invalid"
-          "N"
+        when 'Valid'
+          'M'
+        when 'Invalid'
+          'N'
         else
-          "P"
+          'P'
         end
       end
 

data/lib/active_merchant/billing/gateways/exact.rb

@@ -3,15 +3,15 @@ module ActiveMerchant #:nodoc:
     class ExactGateway < Gateway
       self.live_url = self.test_url = 'https://secure2.e-xact.com/vplug-in/transaction/rpc-enc/service.asmx'
 
-      API_VERSION = "8.5"
+      API_VERSION = '8.5'
 
-      TEST_LOGINS = [ {:login => "A00049-01", :password => "test1"},
-                      {:login => "A00427-01", :password => "testus"} ]
+      TEST_LOGINS = [ {:login => 'A00049-01', :password => 'test1'},
+                      {:login => 'A00427-01', :password => 'testus'} ]
 
-      TRANSACTIONS = { :sale          => "00",
-                       :authorization => "01",
-                       :capture       => "32",
-                       :credit        => "34" }
+      TRANSACTIONS = { :sale          => '00',
+                       :authorization => '01',
+                       :capture       => '32',
+                       :credit        => '34' }
 
 
       ENVELOPE_NAMESPACES = { 'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema',
@@ -19,7 +19,7 @@ module ActiveMerchant #:nodoc:
                               'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance'
                             }
 
-      SEND_AND_COMMIT_ATTRIBUTES = { 'xmlns:n1' => "http://secure2.e-xact.com/vplug-in/transaction/rpc-enc/Request",
+      SEND_AND_COMMIT_ATTRIBUTES = { 'xmlns:n1' => 'http://secure2.e-xact.com/vplug-in/transaction/rpc-enc/Request',
                                      'env:encodingStyle' => 'http://schemas.xmlsoap.org/soap/encoding/'
                                    }
 
@@ -27,11 +27,11 @@ module ActiveMerchant #:nodoc:
                                             'xsi:type' => 'n2:Transaction'
                                           }
 
-      POST_HEADERS = { 'soapAction' => "http://secure2.e-xact.com/vplug-in/transaction/rpc-enc/SendAndCommit",
+      POST_HEADERS = { 'soapAction' => 'http://secure2.e-xact.com/vplug-in/transaction/rpc-enc/SendAndCommit',
                        'Content-Type' => 'text/xml'
                      }
 
-      SUCCESS = "true"
+      SUCCESS = 'true'
 
       SENSITIVE_FIELDS = [ :verification_str2, :expiry_date, :card_number ]
 
@@ -207,9 +207,9 @@ module ActiveMerchant #:nodoc:
         response = {}
         xml = REXML::Document.new(xml)
 
-        if root = REXML::XPath.first(xml, "//types:TransactionResult")
+        if root = REXML::XPath.first(xml, '//types:TransactionResult')
           parse_elements(response, root)
-        elsif root = REXML::XPath.first(xml, "//soap:Fault")
+        elsif root = REXML::XPath.first(xml, '//soap:Fault')
           parse_elements(response, root)
         end