activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/secure_net.rb

@@ -2,21 +2,21 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class SecureNetGateway < Gateway
 
-      API_VERSION = "4.0"
+      API_VERSION = '4.0'
 
       TRANSACTIONS = {
-        :auth_only                      => "0000",
-        :auth_capture                   => "0100",
-        :prior_auth_capture             => "0200",
-        :void                           => "0400",
-        :credit                         => "0500"
+        :auth_only                      => '0000',
+        :auth_capture                   => '0100',
+        :prior_auth_capture             => '0200',
+        :void                           => '0400',
+        :credit                         => '0500'
       }
 
       XML_ATTRIBUTES = {
-                        'xmlns' => "http://gateway.securenet.com/API/Contracts",
-                        'xmlns:i' => "http://www.w3.org/2001/XMLSchema-instance"
+                        'xmlns' => 'http://gateway.securenet.com/API/Contracts',
+                        'xmlns:i' => 'http://www.w3.org/2001/XMLSchema-instance'
                        }
-      NIL_ATTRIBUTE = { 'i:nil' => "true" }
+      NIL_ATTRIBUTE = { 'i:nil' => 'true' }
 
       self.supported_countries = ['US']
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
@@ -77,7 +77,7 @@ module ActiveMerchant #:nodoc:
       def commit(request)
         xml = build_request(request)
         url = test? ? self.test_url : self.live_url
-        data = ssl_post(url, xml, "Content-Type" => "text/xml")
+        data = ssl_post(url, xml, 'Content-Type' => 'text/xml')
         response = parse(data)
 
         Response.new(success?(response), message_from(response), response,
@@ -92,7 +92,7 @@ module ActiveMerchant #:nodoc:
         xml = Builder::XmlMarkup.new
 
         xml.instruct!
-        xml.tag!("TRANSACTION", XML_ATTRIBUTES) do
+        xml.tag!('TRANSACTION', XML_ATTRIBUTES) do
           xml << request
         end
 
@@ -116,7 +116,7 @@ module ActiveMerchant #:nodoc:
         transaction_id, amount_in_ref, last_four = split_authorization(authorization)
 
         xml.tag! 'AMOUNT', amount(money) || amount_in_ref
-        xml.tag!("CARD") do
+        xml.tag!('CARD') do
           xml.tag! 'CARDNUMBER', last_four
         end
 
@@ -128,7 +128,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credit_card(xml, creditcard)
-        xml.tag!("CARD") do
+        xml.tag!('CARD') do
           xml.tag! 'CARDCODE', creditcard.verification_value if creditcard.verification_value?
           xml.tag! 'CARDNUMBER', creditcard.number
           xml.tag! 'EXPDATE', expdate(creditcard)
@@ -149,7 +149,7 @@ module ActiveMerchant #:nodoc:
         return unless creditcard
 
         if address = options[:billing_address] || options[:address]
-          xml.tag!("CUSTOMER_BILL") do
+          xml.tag!('CUSTOMER_BILL') do
             xml.tag! 'ADDRESS', address[:address1].to_s
             xml.tag! 'CITY', address[:city].to_s
             xml.tag! 'COMPANY', address[:company].to_s
@@ -167,7 +167,7 @@ module ActiveMerchant #:nodoc:
         end
 
         if address = options[:shipping_address]
-          xml.tag!("CUSTOMER_SHIP") do
+          xml.tag!('CUSTOMER_SHIP') do
             xml.tag! 'ADDRESS', address[:address1].to_s
             xml.tag! 'CITY', address[:city].to_s
             xml.tag! 'COMPANY', address[:company].to_s
@@ -193,7 +193,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_merchant_key(xml, options)
-        xml.tag!("MERCHANT_KEY") do
+        xml.tag!('MERCHANT_KEY') do
           xml.tag! 'GROUPID', 0
           xml.tag! 'SECUREKEY', @options[:password]
           xml.tag! 'SECURENETID', @options[:login]
@@ -236,7 +236,7 @@ module ActiveMerchant #:nodoc:
       def parse(xml)
         response = {}
         xml = REXML::Document.new(xml)
-        root = REXML::XPath.first(xml, "//GATEWAYRESPONSE")
+        root = REXML::XPath.first(xml, '//GATEWAYRESPONSE')
         if root
           root.elements.to_a.each do |node|
             recurring_parse_element(response, node)
@@ -255,12 +255,12 @@ module ActiveMerchant #:nodoc:
       end
 
       def split_authorization(authorization)
-        transaction_id, amount, last_four = authorization.split("|")
+        transaction_id, amount, last_four = authorization.split('|')
         [transaction_id, amount, last_four]
       end
 
       def build_authorization(response)
-        [response[:transactionid], response[:transactionamount], response[:last4_digits]].join("|")
+        [response[:transactionid], response[:transactionamount], response[:last4_digits]].join('|')
       end
 
     end

data/lib/active_merchant/billing/gateways/secure_pay.rb

@@ -95,14 +95,14 @@ module ActiveMerchant #:nodoc:
         post[:version]        = API_VERSION
         post[:login]          = @options[:login]
         post[:tran_key]       = @options[:password]
-        post[:relay_response] = "FALSE"
+        post[:relay_response] = 'FALSE'
         post[:type]           = action
-        post[:delim_data]     = "TRUE"
-        post[:delim_char]     = ","
-        post[:encap_char]     = "$"
+        post[:delim_data]     = 'TRUE'
+        post[:delim_char]     = ','
+        post[:encap_char]     = '$'
         post[:solution_ID]    = application_id if application_id
 
-        request = post.merge(parameters).collect { |key, value| "x_#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        request = post.merge(parameters).collect { |key, value| "x_#{key}=#{CGI.escape(value.to_s)}" }.join('&')
         request
       end
 

data/lib/active_merchant/billing/gateways/secure_pay_au.rb

@@ -43,9 +43,9 @@ module ActiveMerchant #:nodoc:
       }
 
       PERIODIC_ACTIONS = {
-        :add_triggered    => "add",
-        :remove_triggered => "delete",
-        :trigger          => "trigger"
+        :add_triggered    => 'add',
+        :remove_triggered => 'delete',
+        :trigger          => 'trigger'
       }
 
       PERIODIC_TYPES = {
@@ -167,8 +167,8 @@ module ActiveMerchant #:nodoc:
 
           xml.tag! 'RequestType', 'Payment'
           xml.tag! 'Payment' do
-            xml.tag! 'TxnList', "count" => 1 do
-              xml.tag! 'Txn', "ID" => 1 do
+            xml.tag! 'TxnList', 'count' => 1 do
+              xml.tag! 'Txn', 'ID' => 1 do
                 xml.tag! 'txnType', TRANSACTIONS[action]
                 xml.tag! 'txnSource', 23
                 xml << body
@@ -226,8 +226,8 @@ module ActiveMerchant #:nodoc:
 
           xml.tag! 'RequestType', 'Periodic'
           xml.tag! 'Periodic' do
-            xml.tag! 'PeriodicList', "count" => 1 do
-              xml.tag! 'PeriodicItem', "ID" => 1 do
+            xml.tag! 'PeriodicList', 'count' => 1 do
+              xml.tag! 'PeriodicItem', 'ID' => 1 do
                 xml << body
               end
             end

data/lib/active_merchant/billing/gateways/secure_pay_tech.rb

@@ -8,15 +8,15 @@ module ActiveMerchant #:nodoc:
       self.live_url = self.test_url = 'https://tx.securepaytech.com/web/HttpPostPurchase'
 
       PAYMENT_GATEWAY_RESPONSES = {
-        1 => "Transaction OK",
-        2 => "Insufficient funds",
-        3 => "Card expired",
-        4 => "Card declined",
-        5 => "Server error",
-        6 => "Communications error",
-        7 => "Unsupported transaction type",
-        8 => "Bad or malformed request",
-        9 => "Invalid card number"
+        1 => 'Transaction OK',
+        2 => 'Insufficient funds',
+        3 => 'Card expired',
+        4 => 'Card declined',
+        5 => 'Server error',
+        6 => 'Communications error',
+        7 => 'Unsupported transaction type',
+        8 => 'Bad or malformed request',
+        9 => 'Invalid card number'
       }
 
       self.default_currency = 'NZD'

data/lib/active_merchant/billing/gateways/securion_pay.rb

@@ -44,7 +44,7 @@ module ActiveMerchant #:nodoc:
 
       def authorize(money, payment, options={})
         post = create_post_for_auth_or_purchase(money, payment, options)
-        post[:captured] = "false"
+        post[:captured] = 'false'
         commit('charges', post, options)
       end
 
@@ -79,7 +79,7 @@ module ActiveMerchant #:nodoc:
             #create customer and save card
             r.process { create_customer_add_card(r.authorization, options) }
             #void the charge
-            r.process(:ignore_result) { void(r.params["metadata"]["chargeId"], options) }
+            r.process(:ignore_result) { void(r.params['metadata']['chargeId'], options) }
           end
         else
           verify(credit_card, options)
@@ -183,14 +183,14 @@ module ActiveMerchant #:nodoc:
 
       def commit(url, parameters = nil, options = {}, method = nil)
         response = api_request(url, parameters, options, method)
-        success = !response.key?("error")
+        success = !response.key?('error')
 
         Response.new(success,
-          (success ? "Transaction approved" : response["error"]["message"]),
+          (success ? 'Transaction approved' : response['error']['message']),
           response,
           test: test?,
-          authorization: (success ? response["id"] : response["error"]["charge"]),
-          error_code: (success ? nil : STANDARD_ERROR_CODE_MAPPING[response["error"]["code"]])
+          authorization: (success ? response['id'] : response['error']['charge']),
+          error_code: (success ? nil : STANDARD_ERROR_CODE_MAPPING[response['error']['code']])
         )
       end
 
@@ -198,8 +198,8 @@ module ActiveMerchant #:nodoc:
         secret_key = options[:secret_key] || @options[:secret_key]
 
         headers = {
-          "Authorization" => "Basic " + Base64.encode64(secret_key.to_s + ":").strip,
-          "User-Agent" => "SecurionPay/v1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}"
+          'Authorization' => 'Basic ' + Base64.encode64(secret_key.to_s + ':').strip,
+          'User-Agent' => "SecurionPay/v1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}"
         }
         headers
       end
@@ -224,11 +224,11 @@ module ActiveMerchant #:nodoc:
             end
             post_data(h)
           elsif value.is_a?(Array)
-            value.map { |v| "#{key}[]=#{CGI.escape(v.to_s)}" }.join("&")
+            value.map { |v| "#{key}[]=#{CGI.escape(v.to_s)}" }.join('&')
           else
             "#{key}=#{CGI.escape(value.to_s)}"
           end
-        end.compact.join("&")
+        end.compact.join('&')
       end
 
       def api_request(endpoint, parameters = nil, options = {}, method = nil)
@@ -253,8 +253,8 @@ module ActiveMerchant #:nodoc:
         msg = 'Invalid response received from the SecurionPay API.'
         msg += "  (The raw response returned by the API was #{raw_response.inspect})"
         {
-          "error" => {
-            "message" => msg
+          'error' => {
+            'message' => msg
           }
         }
       end

data/lib/active_merchant/billing/gateways/skip_jack.rb

@@ -6,11 +6,11 @@ module ActiveMerchant #:nodoc:
     class SkipJackGateway < Gateway
       API_VERSION = '?.?'
 
-      self.live_url = "https://www.skipjackic.com"
-      self.test_url = "https://developer.skipjackic.com"
+      self.live_url = 'https://www.skipjackic.com'
+      self.test_url = 'https://developer.skipjackic.com'
 
-      BASIC_PATH = "/scripts/evolvcc.dll"
-      ADVANCED_PATH = "/evolvcc/evolvcc.aspx"
+      BASIC_PATH = '/scripts/evolvcc.dll'
+      ADVANCED_PATH = '/evolvcc/evolvcc.aspx'
 
       ACTIONS = {
         :authorization => 'AuthorizeAPI',
@@ -25,34 +25,34 @@ module ActiveMerchant #:nodoc:
       CARD_CODE_ERRORS = %w( N S "" )
 
       CARD_CODE_MESSAGES = {
-        "M" => "Card verification number matched",
-        "N" => "Card verification number didn't match",
-        "P" => "Card verification number was not processed",
-        "S" => "Card verification number should be on card but was not indicated",
-        "U" => "Issuer was not certified for card verification",
-        "" => "Transaction failed because incorrect card verification number was entered or no number was entered"
+        'M' => 'Card verification number matched',
+        'N' => "Card verification number didn't match",
+        'P' => 'Card verification number was not processed',
+        'S' => 'Card verification number should be on card but was not indicated',
+        'U' => 'Issuer was not certified for card verification',
+        '' => 'Transaction failed because incorrect card verification number was entered or no number was entered'
       }
 
       AVS_ERRORS = %w( A B C E I N O P R W Z )
 
       AVS_MESSAGES = {
-        "A" => "Street address matches billing information, zip/postal code does not",
-        "B" => "Street address match for international transaction. Postal code not verified due to incompatible formats",
-        "C" => "Street address and postal code not verified for internation transaction due to incompatible formats",
-        "D" => "Street address and postal code match for international transaction",
-        "E" => "Address verification service error",
-        "I" => "Address information not verified by international issuer",
-        "M" => "Street address and postal code match for international transaction",
-        "N" => "Neither street address nor zip/postal match billing information",
-        "O" => "Non-US issuer does not participate",
-        "P" => "Postal codes match for international transaction but street address not verified due to incompatible formats",
-        "R" => "Payment gateway was unavailable or timed out",
-        "S" => "Address verification service not supported by issuer",
-        "U" => "Address information is unavailable",
-        "W" => "9-digit zip/postal code matches billing information, street address does not",
-        "X" => "Street address and 9-digit zip/postal code matches billing information",
-        "Y" => "Street address and 5-digit zip/postal code matches billing information",
-        "Z" => "5-digit zip/postal code matches billing information, street address does not",
+        'A' => 'Street address matches billing information, zip/postal code does not',
+        'B' => 'Street address match for international transaction. Postal code not verified due to incompatible formats',
+        'C' => 'Street address and postal code not verified for internation transaction due to incompatible formats',
+        'D' => 'Street address and postal code match for international transaction',
+        'E' => 'Address verification service error',
+        'I' => 'Address information not verified by international issuer',
+        'M' => 'Street address and postal code match for international transaction',
+        'N' => 'Neither street address nor zip/postal match billing information',
+        'O' => 'Non-US issuer does not participate',
+        'P' => 'Postal codes match for international transaction but street address not verified due to incompatible formats',
+        'R' => 'Payment gateway was unavailable or timed out',
+        'S' => 'Address verification service not supported by issuer',
+        'U' => 'Address information is unavailable',
+        'W' => '9-digit zip/postal code matches billing information, street address does not',
+        'X' => 'Street address and 9-digit zip/postal code matches billing information',
+        'Y' => 'Street address and 5-digit zip/postal code matches billing information',
+        'Z' => '5-digit zip/postal code matches billing information, street address does not',
       }
 
       CHANGE_STATUS_ERROR_MESSAGES = {
@@ -355,7 +355,7 @@ module ActiveMerchant #:nodoc:
         add_credentials(params, action)
         add_amount(params, action, money)
         sorted_params = params.to_a.sort{|a,b| a.to_s <=> b.to_s}.reverse
-        sorted_params.collect { |key, value| "#{key.to_s}=#{CGI.escape(value.to_s)}" }.join("&")
+        sorted_params.collect { |key, value| "#{key.to_s}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def add_transaction_id(post, transaction_id)

data/lib/active_merchant/billing/gateways/smart_ps.rb

@@ -25,7 +25,7 @@ module ActiveMerchant #:nodoc:
         add_invoice(post, options)
         add_payment_source(post, creditcard,options)
         add_address(post, options[:billing_address] || options[:address])
-        add_address(post, options[:shipping_address], "shipping")
+        add_address(post, options[:shipping_address], 'shipping')
         add_customer_data(post, options)
         add_currency(post, money, options)
         add_taxes(post, options)
@@ -38,7 +38,7 @@ module ActiveMerchant #:nodoc:
         add_invoice(post, options)
         add_payment_source(post, payment_source, options)
         add_address(post, options[:billing_address] || options[:address])
-        add_address(post, options[:shipping_address], "shipping")
+        add_address(post, options[:shipping_address], 'shipping')
         add_customer_data(post, options)
         add_currency(post, money, options)
         add_taxes(post, options)
@@ -89,7 +89,7 @@ module ActiveMerchant #:nodoc:
       # CreditCard object.
       def update(vault_id, creditcard, options = {})
         post = {}
-        post[:customer_vault] = "update_customer"
+        post[:customer_vault] = 'update_customer'
         add_customer_vault_id(post, vault_id)
         add_creditcard(post, creditcard, options)
         add_address(post, options[:billing_address] || options[:address])
@@ -109,7 +109,7 @@ module ActiveMerchant #:nodoc:
 
       def delete(vault_id)
         post = {}
-        post[:customer_vault] = "delete_customer"
+        post[:customer_vault] = 'delete_customer'
         add_customer_vault_id(post, vault_id)
         commit(nil, nil, post)
       end
@@ -138,17 +138,17 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def add_address(post, address,prefix="")
-        prefix +="_" unless prefix.blank?
+      def add_address(post, address,prefix='')
+        prefix +='_' unless prefix.blank?
         unless address.blank? or address.values.blank?
-          post[prefix+"address1"]    = address[:address1].to_s
-          post[prefix+"address2"]    = address[:address2].to_s unless address[:address2].blank?
-          post[prefix+"company"]    = address[:company].to_s
-          post[prefix+"phone"]      = address[:phone].to_s
-          post[prefix+"zip"]        = address[:zip].to_s
-          post[prefix+"city"]       = address[:city].to_s
-          post[prefix+"country"]    = address[:country].to_s
-          post[prefix+"state"]      = address[:state].blank?  ? 'n/a' : address[:state]
+          post[prefix+'address1']    = address[:address1].to_s
+          post[prefix+'address2']    = address[:address2].to_s unless address[:address2].blank?
+          post[prefix+'company']    = address[:company].to_s
+          post[prefix+'phone']      = address[:phone].to_s
+          post[prefix+'zip']        = address[:zip].to_s
+          post[prefix+'city']       = address[:city].to_s
+          post[prefix+'country']    = address[:country].to_s
+          post[prefix+'state']      = address[:state].blank?  ? 'n/a' : address[:state]
         end
       end
 
@@ -182,7 +182,7 @@ module ActiveMerchant #:nodoc:
 
       def add_creditcard(post, creditcard, options)
         if options[:store]
-          post[:customer_vault] = "add_customer"
+          post[:customer_vault] = 'add_customer'
           post[:customer_vault_id] = options[:store] unless options[:store] == true
         end
         post[:ccnumber]  = creditcard.number
@@ -194,7 +194,7 @@ module ActiveMerchant #:nodoc:
 
       def add_check(post, check, options)
         if options[:store]
-          post[:customer_vault] = "add_customer"
+          post[:customer_vault] = 'add_customer'
           post[:customer_vault_id] = options[:store] unless options[:store] == true
         end
 
@@ -207,7 +207,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_sku(post,options)
-        post["product_sku_#"] = options[:sku] || options["product_sku_#"]
+        post['product_sku_#'] = options[:sku] || options['product_sku_#']
       end
 
       def add_transaction(post, auth)
@@ -231,31 +231,31 @@ module ActiveMerchant #:nodoc:
       def commit(action, money, parameters)
         parameters[:amount]  = localized_amount(money, parameters[:currency] || default_currency) if money
         response = parse( ssl_post(self.live_url, post_data(action,parameters)) )
-        Response.new(response["response"] == "1", message_from(response), response,
-          :authorization => (response["transactionid"] || response["customer_vault_id"]),
+        Response.new(response['response'] == '1', message_from(response), response,
+          :authorization => (response['transactionid'] || response['customer_vault_id']),
           :test => test?,
-          :cvv_result => response["cvvresponse"],
-          :avs_result => { :code => response["avsresponse"] }
+          :cvv_result => response['cvvresponse'],
+          :avs_result => { :code => response['avsresponse'] }
         )
 
       end
 
       def expdate(creditcard)
-        year  = sprintf("%.04i", creditcard.year)
-        month = sprintf("%.02i", creditcard.month)
+        year  = sprintf('%.04i', creditcard.year)
+        month = sprintf('%.02i', creditcard.month)
 
         "#{month}#{year[-2..-1]}"
       end
 
 
       def message_from(response)
-        case response["responsetext"]
-        when "SUCCESS", "Approved", nil # This is dubious, but responses from UPDATE are nil.
-          "This transaction has been approved"
-        when "DECLINE"
-          "This transaction has been declined"
+        case response['responsetext']
+        when 'SUCCESS', 'Approved', nil # This is dubious, but responses from UPDATE are nil.
+          'This transaction has been approved'
+        when 'DECLINE'
+          'This transaction has been declined'
         else
-          response["responsetext"]
+          response['responsetext']
         end
       end
 
@@ -265,7 +265,7 @@ module ActiveMerchant #:nodoc:
         post[:password]   = @options[:password]
         post[:type]       = action if action
 
-        request = post.merge(parameters).map {|key,value| "#{key}=#{CGI.escape(value.to_s)}"}.join("&")
+        request = post.merge(parameters).map {|key,value| "#{key}=#{CGI.escape(value.to_s)}"}.join('&')
         request
       end
 
@@ -274,7 +274,7 @@ module ActiveMerchant #:nodoc:
         when source.is_a?(String) then :vault
         when CreditCard.card_companies.keys.include?(card_brand(source)) then :credit_card
         when card_brand(source) == 'check' then :check
-        else raise ArgumentError, "Unsupported funding source provided"
+        else raise ArgumentError, 'Unsupported funding source provided'
         end
       end
     end