activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/barclaycard_smartpay.rb

@@ -160,11 +160,11 @@ module ActiveMerchant #:nodoc:
         authorization = [parameters[:originalReference], response['pspReference']].compact
 
         return nil if authorization.empty?
-        return authorization.join("#")
+        return authorization.join('#')
       end
 
       def parse_avs_code(response)
-        AVS_MAPPING[response["avsResult"][0..1].strip] if response["avsResult"]
+        AVS_MAPPING[response['avsResult'][0..1].strip] if response['avsResult']
       end
 
       def flatten_hash(hash, prefix = nil)
@@ -249,13 +249,13 @@ module ActiveMerchant #:nodoc:
       def parse_street(address)
         address_to_parse = "#{address[:address1]} #{address[:address2]}"
         street = address[:street] || address_to_parse.split(/\s+/).keep_if { |x| x !~ /\d/ }.join(' ')
-        street.empty? ? "Not Provided" : street
+        street.empty? ? 'Not Provided' : street
       end
 
       def parse_house_number(address)
         address_to_parse = "#{address[:address1]} #{address[:address2]}"
         house = address[:houseNumberOrName] || address_to_parse.split(/\s+/).keep_if { |x| x =~ /\d/ }.join(' ')
-        house.empty? ? "Not Provided" : house
+        house.empty? ? 'Not Provided' : house
       end
 
       def create_address_hash(address, house, street)
@@ -295,7 +295,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def psp_reference_from(authorization)
-        authorization.nil? ? nil : authorization.split("#").first
+        authorization.nil? ? nil : authorization.split('#').first
       end
 
       def payment_request(money, options)

data/lib/active_merchant/billing/gateways/barclays_epdq_extra_plus.rb

@@ -1,15 +1,15 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class BarclaysEpdqExtraPlusGateway < OgoneGateway
-      self.test_url = "https://mdepayments.epdq.co.uk/ncol/test/"
-      self.live_url = "https://payments.epdq.co.uk/ncol/prod/"
+      self.test_url = 'https://mdepayments.epdq.co.uk/ncol/test/'
+      self.live_url = 'https://payments.epdq.co.uk/ncol/prod/'
 
-      self.display_name = "Barclays ePDQ Extra Plus"
-      self.homepage_url = "http://www.barclaycard.co.uk/business/accepting-payments/epdq-ecomm/"
+      self.display_name = 'Barclays ePDQ Extra Plus'
+      self.homepage_url = 'http://www.barclaycard.co.uk/business/accepting-payments/epdq-ecomm/'
 
-      self.supported_countries = ["GB"]
+      self.supported_countries = ['GB']
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :discover, :jcb, :maestro]
-      self.default_currency = "GBP"
+      self.default_currency = 'GBP'
     end
   end
 end

data/lib/active_merchant/billing/gateways/be2bill.rb

@@ -1,4 +1,4 @@
-require "digest/sha2"
+require 'digest/sha2'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
@@ -72,7 +72,7 @@ module ActiveMerchant #:nodoc:
       def add_creditcard(post, creditcard)
         post[:CARDFULLNAME]     = creditcard ? creditcard.name : ''
         post[:CARDCODE]         = creditcard ? creditcard.number : ''
-        post[:CARDVALIDITYDATE] = creditcard ? "%02d-%02s" % [creditcard.month, creditcard.year.to_s[-2..-1]] : ''
+        post[:CARDVALIDITYDATE] = creditcard ? '%02d-%02s' % [creditcard.month, creditcard.year.to_s[-2..-1]] : ''
         post[:CARDCVV]          = creditcard ? creditcard.verification_value : ''
       end
 

data/lib/active_merchant/billing/gateways/beanstream.rb

@@ -170,7 +170,7 @@ module ActiveMerchant #:nodoc:
       #can't actually delete a secure profile with the supplicated API. This function sets the status of the profile to closed (C).
       #Closed profiles will have to removed manually.
       def delete(vault_id)
-        update(vault_id, false, {:status => "C"})
+        update(vault_id, false, {:status => 'C'})
       end
 
       alias_method :unstore, :delete

data/lib/active_merchant/billing/gateways/beanstream/beanstream_core.rb

@@ -62,69 +62,69 @@ module ActiveMerchant #:nodoc:
       }
 
       STATES = {
-        "ALBERTA" => "AB",
-        "BRITISH COLUMBIA" => "BC",
-        "MANITOBA" => "MB",
-        "NEW BRUNSWICK" => "NB",
-        "NEWFOUNDLAND AND LABRADOR" => "NL",
-        "NOVA SCOTIA" => "NS",
-        "ONTARIO" => "ON",
-        "PRINCE EDWARD ISLAND" => "PE",
-        "QUEBEC" => "QC",
-        "SASKATCHEWAN" => "SK",
-        "NORTHWEST TERRITORIES" => "NT",
-        "NUNAVUT" => "NU",
-        "YUKON" => "YT",
-        "ALABAMA" => "AL",
-        "ALASKA" => "AK",
-        "ARIZONA" => "AZ",
-        "ARKANSAS" => "AR",
-        "CALIFORNIA" => "CA",
-        "COLORADO" => "CO",
-        "CONNECTICUT" => "CT",
-        "DELAWARE" => "DE",
-        "FLORIDA" => "FL",
-        "GEORGIA" => "GA",
-        "HAWAII" => "HI",
-        "IDAHO" => "ID",
-        "ILLINOIS" => "IL",
-        "INDIANA" => "IN",
-        "IOWA" => "IA",
-        "KANSAS" => "KS",
-        "KENTUCKY" => "KY",
-        "LOUISIANA" => "LA",
-        "MAINE" => "ME",
-        "MARYLAND" => "MD",
-        "MASSACHUSETTS" => "MA",
-        "MICHIGAN" => "MI",
-        "MINNESOTA" => "MN",
-        "MISSISSIPPI" => "MS",
-        "MISSOURI" => "MO",
-        "MONTANA" => "MT",
-        "NEBRASKA" => "NE",
-        "NEVADA" => "NV",
-        "NEW HAMPSHIRE" => "NH",
-        "NEW JERSEY" => "NJ",
-        "NEW MEXICO" => "NM",
-        "NEW YORK" => "NY",
-        "NORTH CAROLINA" => "NC",
-        "NORTH DAKOTA" => "ND",
-        "OHIO" => "OH",
-        "OKLAHOMA" => "OK",
-        "OREGON" => "OR",
-        "PENNSYLVANIA" => "PA",
-        "RHODE ISLAND" => "RI",
-        "SOUTH CAROLINA" => "SC",
-        "SOUTH DAKOTA" => "SD",
-        "TENNESSEE" => "TN",
-        "TEXAS" => "TX",
-        "UTAH" => "UT",
-        "VERMONT" => "VT",
-        "VIRGINIA" => "VA",
-        "WASHINGTON" => "WA",
-        "WEST VIRGINIA" => "WV",
-        "WISCONSIN" => "WI",
-        "WYOMING" => "WY"
+        'ALBERTA' => 'AB',
+        'BRITISH COLUMBIA' => 'BC',
+        'MANITOBA' => 'MB',
+        'NEW BRUNSWICK' => 'NB',
+        'NEWFOUNDLAND AND LABRADOR' => 'NL',
+        'NOVA SCOTIA' => 'NS',
+        'ONTARIO' => 'ON',
+        'PRINCE EDWARD ISLAND' => 'PE',
+        'QUEBEC' => 'QC',
+        'SASKATCHEWAN' => 'SK',
+        'NORTHWEST TERRITORIES' => 'NT',
+        'NUNAVUT' => 'NU',
+        'YUKON' => 'YT',
+        'ALABAMA' => 'AL',
+        'ALASKA' => 'AK',
+        'ARIZONA' => 'AZ',
+        'ARKANSAS' => 'AR',
+        'CALIFORNIA' => 'CA',
+        'COLORADO' => 'CO',
+        'CONNECTICUT' => 'CT',
+        'DELAWARE' => 'DE',
+        'FLORIDA' => 'FL',
+        'GEORGIA' => 'GA',
+        'HAWAII' => 'HI',
+        'IDAHO' => 'ID',
+        'ILLINOIS' => 'IL',
+        'INDIANA' => 'IN',
+        'IOWA' => 'IA',
+        'KANSAS' => 'KS',
+        'KENTUCKY' => 'KY',
+        'LOUISIANA' => 'LA',
+        'MAINE' => 'ME',
+        'MARYLAND' => 'MD',
+        'MASSACHUSETTS' => 'MA',
+        'MICHIGAN' => 'MI',
+        'MINNESOTA' => 'MN',
+        'MISSISSIPPI' => 'MS',
+        'MISSOURI' => 'MO',
+        'MONTANA' => 'MT',
+        'NEBRASKA' => 'NE',
+        'NEVADA' => 'NV',
+        'NEW HAMPSHIRE' => 'NH',
+        'NEW JERSEY' => 'NJ',
+        'NEW MEXICO' => 'NM',
+        'NEW YORK' => 'NY',
+        'NORTH CAROLINA' => 'NC',
+        'NORTH DAKOTA' => 'ND',
+        'OHIO' => 'OH',
+        'OKLAHOMA' => 'OK',
+        'OREGON' => 'OR',
+        'PENNSYLVANIA' => 'PA',
+        'RHODE ISLAND' => 'RI',
+        'SOUTH CAROLINA' => 'SC',
+        'SOUTH DAKOTA' => 'SD',
+        'TENNESSEE' => 'TN',
+        'TEXAS' => 'TX',
+        'UTAH' => 'UT',
+        'VERMONT' => 'VT',
+        'VIRGINIA' => 'VA',
+        'WASHINGTON' => 'WA',
+        'WEST VIRGINIA' => 'WV',
+        'WISCONSIN' => 'WI',
+        'WYOMING' => 'WY'
       }
 
       def self.included(base)
@@ -206,7 +206,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def split_auth(string)
-        string.split(";")
+        string.split(';')
       end
 
       def add_amount(post, money)
@@ -386,8 +386,8 @@ module ActiveMerchant #:nodoc:
 
         # Clean up the message text if there is any
         if results[:messageText]
-          results[:messageText].gsub!(/<LI>/, "")
-          results[:messageText].gsub!(/(\.)?<br>/, ". ")
+          results[:messageText].gsub!(/<LI>/, '')
+          results[:messageText].gsub!(/(\.)?<br>/, '. ')
           results[:messageText].strip!
         end
 
@@ -413,7 +413,7 @@ module ActiveMerchant #:nodoc:
         response = parse(ssl_post((use_profile_api ? SECURE_PROFILE_URL : self.live_url), data))
         response[:customer_vault_id] = response[:customerCode] if response[:customerCode]
         build_response(success?(response), message_from(response), response,
-          :test => test? || response[:authCode] == "TEST",
+          :test => test? || response[:authCode] == 'TEST',
           :authorization => authorization_from(response),
           :cvv_result => CVD_CODES[response[:cvdId]],
           :avs_result => { :code => (AVS_CODES.include? response[:avsId]) ? AVS_CODES[response[:avsId]] : response[:avsId] }
@@ -445,7 +445,7 @@ module ActiveMerchant #:nodoc:
         if source.is_a?(String) or source.is_a?(Integer)
           post[:customerCode] = source
         else
-          card_brand(source) == "check" ? add_check(post, source) : add_credit_card(post, source)
+          card_brand(source) == 'check' ? add_check(post, source) : add_credit_card(post, source)
         end
       end
 
@@ -466,7 +466,7 @@ module ActiveMerchant #:nodoc:
         params[:vbvEnabled] = '0'
         params[:scEnabled] = '0'
 
-        params.reject{|k, v| v.blank?}.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        params.reject{|k, v| v.blank?}.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
     end

data/lib/active_merchant/billing/gateways/blue_pay.rb

@@ -155,7 +155,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>options</tt> -- A hash of parameters.
       def refund(money, identification, options = {})
         if(identification && !identification.kind_of?(String))
-          ActiveMerchant.deprecated "refund should only be used to refund a referenced transaction"
+          ActiveMerchant.deprecated 'refund should only be used to refund a referenced transaction'
           return credit(money, identification, options)
         end
 
@@ -163,7 +163,7 @@ module ActiveMerchant #:nodoc:
         post[:PAYMENT_ACCOUNT] = ''
         post[:MASTER_ID]  = identification
         post[:TRANS_TYPE] = 'REFUND'
-        post[:NAME1] = (options[:first_name] ? options[:first_name] : "")
+        post[:NAME1] = options[:first_name] || ''
         post[:NAME2] = options[:last_name] if options[:last_name]
         post[:ZIP] = options[:zip] if options[:zip]
         add_invoice(post, options)
@@ -174,7 +174,7 @@ module ActiveMerchant #:nodoc:
 
       def credit(money, payment_object, options = {})
         if(payment_object && payment_object.kind_of?(String))
-          ActiveMerchant.deprecated "credit should only be used to credit a payment method"
+          ActiveMerchant.deprecated 'credit should only be used to credit a payment method'
           return refund(money, payment_object, options)
         end
 
@@ -183,7 +183,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_object)
         post[:TRANS_TYPE] = 'CREDIT'
 
-        post[:NAME1] = (options[:first_name] ? options[:first_name] : "")
+        post[:NAME1] = options[:first_name] || ''
         post[:NAME2] = options[:last_name] if options[:last_name]
         post[:ZIP] = options[:zip] if options[:zip]
         add_invoice(post, options)
@@ -347,7 +347,7 @@ module ActiveMerchant #:nodoc:
         # The bp20api has max one value per form field.
         response_fields = Hash[CGI::parse(body).map{|k,v| [k.upcase,v.first]}]
 
-        if response_fields.include? "REBILL_ID"
+        if response_fields.include? 'REBILL_ID'
           return parse_recurring(response_fields)
         end
 
@@ -378,12 +378,12 @@ module ActiveMerchant #:nodoc:
           else
             message = message.chomp('.')
           end
-        elsif message == "Missing ACCOUNT_ID"
-          message = "The merchant login ID or password is invalid"
+        elsif message == 'Missing ACCOUNT_ID'
+          message = 'The merchant login ID or password is invalid'
         elsif message =~ /Approved/
-          message = "This transaction has been approved"
+          message = 'This transaction has been approved'
         elsif message =~  /Expired/
-          message =  "The credit card has expired"
+          message =  'The credit card has expired'
         end
         message
       end
@@ -418,13 +418,13 @@ module ActiveMerchant #:nodoc:
       end
 
       CHECK_ACCOUNT_TYPES = {
-        "checking" => "C",
-        "savings" => "S"
+        'checking' => 'C',
+        'savings' => 'S'
       }
 
       def add_check(post, check)
         post[:PAYMENT_TYPE]     = 'ACH'
-        post[:PAYMENT_ACCOUNT]  = [CHECK_ACCOUNT_TYPES[check.account_type], check.routing_number, check.account_number].join(":")
+        post[:PAYMENT_ACCOUNT]  = [CHECK_ACCOUNT_TYPES[check.account_type], check.routing_number, check.account_number].join(':')
         post[:NAME1]            = check.first_name
         post[:NAME2]            = check.last_name
       end
@@ -465,15 +465,15 @@ module ActiveMerchant #:nodoc:
         post[:version]        = '1'
         post[:login]          = ''
         post[:tran_key]       = ''
-        post[:relay_response] = "FALSE"
+        post[:relay_response] = 'FALSE'
         post[:type]           = action
-        post[:delim_data]     = "TRUE"
-        post[:delim_char]     = ","
-        post[:encap_char]     = "$"
+        post[:delim_data]     = 'TRUE'
+        post[:delim_char]     = ','
+        post[:encap_char]     = '$'
         post[:card_num]       = '4111111111111111'
         post[:exp_date]       = '1212'
         post[:solution_ID]    = application_id if application_id
-        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        post.merge(parameters).collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def expdate(creditcard)
@@ -494,7 +494,7 @@ module ActiveMerchant #:nodoc:
             post[:MASTER_ID],
             post[:NAME1],
             post[:PAYMENT_ACCOUNT]
-          ].join("")
+          ].join('')
         )
       end
 
@@ -505,7 +505,7 @@ module ActiveMerchant #:nodoc:
             @options[:login],
             post[:TRANS_TYPE],
             post[:REBILL_ID]
-          ].join("")
+          ].join('')
         )
       end
 

data/lib/active_merchant/billing/gateways/blue_snap.rb

@@ -3,8 +3,8 @@ require 'nokogiri'
 module ActiveMerchant
   module Billing
     class BlueSnapGateway < Gateway
-      self.test_url = "https://sandbox.bluesnap.com/services/2"
-      self.live_url = "https://ws.bluesnap.com/services/2"
+      self.test_url = 'https://sandbox.bluesnap.com/services/2'
+      self.live_url = 'https://ws.bluesnap.com/services/2'
       self.supported_countries = %w(US CA GB AT BE BG HR CY CZ DK EE FI FR DE GR HU IE IT LV LT LU MT NL PL PT RO SK SI ES SE)
 
       self.default_currency = 'USD'
@@ -14,11 +14,11 @@ module ActiveMerchant
       self.display_name = 'BlueSnap'
 
       TRANSACTIONS = {
-        purchase: "AUTH_CAPTURE",
-        authorize: "AUTH_ONLY",
-        capture: "CAPTURE",
-        void: "AUTH_REVERSAL",
-        refund: "REFUND"
+        purchase: 'AUTH_CAPTURE',
+        authorize: 'AUTH_ONLY',
+        capture: 'CAPTURE',
+        void: 'AUTH_REVERSAL',
+        refund: 'REFUND'
       }
 
       CVC_CODE_TRANSLATOR = {
@@ -105,8 +105,8 @@ module ActiveMerchant
       def store(credit_card, options = {})
         commit(:store) do |doc|
           add_personal_info(doc, credit_card, options)
-          doc.send("payment-sources") do
-            doc.send("credit-card-info") do
+          doc.send('payment-sources') do
+            doc.send('credit-card-info') do
               add_credit_card(doc, credit_card)
             end
           end
@@ -138,17 +138,17 @@ module ActiveMerchant
       private
 
       def add_auth_purchase(doc, money, payment_method, options)
-        doc.send("recurring-transaction", options[:recurring] ? "RECURRING" : "ECOMMERCE")
+        doc.send('recurring-transaction', options[:recurring] ? 'RECURRING' : 'ECOMMERCE')
         add_order(doc, options)
         add_amount(doc, money, options)
-        doc.send("transaction-fraud-info") do
-          doc.send("shopper-ip-address", options[:ip]) if options[:ip]
+        doc.send('transaction-fraud-info') do
+          doc.send('shopper-ip-address', options[:ip]) if options[:ip]
         end
 
         if payment_method.is_a?(String)
-          doc.send("vaulted-shopper-id", payment_method)
+          doc.send('vaulted-shopper-id', payment_method)
         else
-          doc.send("card-holder-info") do
+          doc.send('card-holder-info') do
             add_personal_info(doc, payment_method, options)
           end
           add_credit_card(doc, payment_method)
@@ -161,34 +161,34 @@ module ActiveMerchant
       end
 
       def add_personal_info(doc, credit_card, options)
-        doc.send("first-name", credit_card.first_name)
-        doc.send("last-name", credit_card.last_name)
+        doc.send('first-name', credit_card.first_name)
+        doc.send('last-name', credit_card.last_name)
         doc.email(options[:email]) if options[:email]
         add_address(doc, options)
       end
 
       def add_credit_card(doc, card)
-        doc.send("credit-card") do
-          doc.send("card-number", card.number)
-          doc.send("security-code", card.verification_value)
-          doc.send("expiration-month", card.month)
-          doc.send("expiration-year", card.year)
+        doc.send('credit-card') do
+          doc.send('card-number', card.number)
+          doc.send('security-code', card.verification_value)
+          doc.send('expiration-month', card.month)
+          doc.send('expiration-year', card.year)
         end
       end
 
       def add_description(doc, description)
-        doc.send("transaction-meta-data") do
-          doc.send("meta-data") do
-            doc.send("meta-key", "description")
-            doc.send("meta-value", truncate(description, 500))
-            doc.send("meta-description", "Description")
+        doc.send('transaction-meta-data') do
+          doc.send('meta-data') do
+            doc.send('meta-key', 'description')
+            doc.send('meta-value', truncate(description, 500))
+            doc.send('meta-description', 'Description')
           end
         end
       end
 
       def add_order(doc, options)
-        doc.send("merchant-transaction-id", truncate(options[:order_id], 50)) if options[:order_id]
-        doc.send("soft-descriptor", options[:soft_descriptor]) if options[:soft_descriptor]
+        doc.send('merchant-transaction-id', truncate(options[:order_id], 50)) if options[:order_id]
+        doc.send('soft-descriptor', options[:soft_descriptor]) if options[:soft_descriptor]
         add_description(doc, options[:description]) if options[:description]
       end
 
@@ -204,7 +204,7 @@ module ActiveMerchant
       end
 
       def add_authorization(doc, authorization)
-        doc.send("transaction-id", authorization)
+        doc.send('transaction-id', authorization)
       end
 
       def parse(response)
@@ -222,7 +222,7 @@ module ActiveMerchant
           end
         end
 
-        parsed["content-location-header"] = response['content-location']
+        parsed['content-location-header'] = response['content-location']
         parsed
       end
 
@@ -262,12 +262,12 @@ module ActiveMerchant
 
       def url(action = nil)
         base = test? ? test_url : live_url
-        resource = (action == :store) ? "vaulted-shoppers" : "transactions"
+        resource = (action == :store) ? 'vaulted-shoppers' : 'transactions'
         "#{base}/#{resource}"
       end
 
       def cvv_result(parsed)
-        CVVResult.new(CVC_CODE_TRANSLATOR[parsed["cvv-response-code"]])
+        CVVResult.new(CVC_CODE_TRANSLATOR[parsed['cvv-response-code']])
       end
 
       def avs_result(parsed)
@@ -283,31 +283,31 @@ module ActiveMerchant
       end
 
       def message_from(succeeded, parsed_response)
-        return "Success" if succeeded
-        parsed_response["description"]
+        return 'Success' if succeeded
+        parsed_response['description']
       end
 
       def authorization_from(action, parsed_response)
-        (action == :store) ? vaulted_shopper_id(parsed_response) : parsed_response["transaction-id"]
+        (action == :store) ? vaulted_shopper_id(parsed_response) : parsed_response['transaction-id']
       end
 
       def vaulted_shopper_id(parsed_response)
-        return nil unless parsed_response["content-location-header"]
-        parsed_response["content-location-header"].split("/").last
+        return nil unless parsed_response['content-location-header']
+        parsed_response['content-location-header'].split('/').last
       end
 
       def error_code_from(parsed_response)
-        parsed_response["code"]
+        parsed_response['code']
       end
 
       def root_attributes
         {
-          xmlns: "http://ws.plimus.com"
+          xmlns: 'http://ws.plimus.com'
         }
       end
 
       def root_element(action)
-        (action == :store) ? "vaulted-shopper" : "card-transaction"
+        (action == :store) ? 'vaulted-shopper' : 'card-transaction'
       end
 
       def headers
@@ -320,7 +320,7 @@ module ActiveMerchant
       def build_xml_request(action)
         builder = Nokogiri::XML::Builder.new
         builder.__send__(root_element(action), root_attributes) do |doc|
-          doc.send("card-transaction-type", TRANSACTIONS[action]) if TRANSACTIONS[action]
+          doc.send('card-transaction-type', TRANSACTIONS[action]) if TRANSACTIONS[action]
           yield(doc)
         end
         builder.doc.root.to_xml
@@ -336,7 +336,7 @@ module ActiveMerchant
       end
 
       def bad_authentication_response
-        { "description" => "Unable to authenticate.  Please check your credentials." }
+        { 'description' => 'Unable to authenticate.  Please check your credentials.' }
       end
     end
   end