activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/bogus.rb

@@ -7,15 +7,15 @@ module ActiveMerchant #:nodoc:
       AUTHORIZATION_EMV_SUCCESS = '8A023030'
       AUTHORIZATION_EMV_DECLINE = '8A023035'
 
-      SUCCESS_MESSAGE = "Bogus Gateway: Forced success"
-      FAILURE_MESSAGE = "Bogus Gateway: Forced failure"
-      NUMBER_ERROR_MESSAGE = "Bogus Gateway: Use CreditCard number ending in 1 for success, 2 for exception and anything else for error"
-      AMOUNT_ERROR_MESSAGE = "Bogus Gateway: Use amount ending in 00 for success, 05 for failure and anything else for exception"
-      UNSTORE_ERROR_MESSAGE = "Bogus Gateway: Use trans_id ending in 1 for success, 2 for exception and anything else for error"
-      CAPTURE_ERROR_MESSAGE = "Bogus Gateway: Use authorization number ending in 1 for exception, 2 for error and anything else for success"
-      VOID_ERROR_MESSAGE = "Bogus Gateway: Use authorization number ending in 1 for exception, 2 for error and anything else for success"
-      REFUND_ERROR_MESSAGE = "Bogus Gateway: Use trans_id number ending in 1 for exception, 2 for error and anything else for success"
-      CHECK_ERROR_MESSAGE = "Bogus Gateway: Use bank account number ending in 1 for success, 2 for exception and anything else for error"
+      SUCCESS_MESSAGE = 'Bogus Gateway: Forced success'
+      FAILURE_MESSAGE = 'Bogus Gateway: Forced failure'
+      NUMBER_ERROR_MESSAGE = 'Bogus Gateway: Use CreditCard number ending in 1 for success, 2 for exception and anything else for error'
+      AMOUNT_ERROR_MESSAGE = 'Bogus Gateway: Use amount ending in 00 for success, 05 for failure and anything else for exception'
+      UNSTORE_ERROR_MESSAGE = 'Bogus Gateway: Use trans_id ending in 1 for success, 2 for exception and anything else for error'
+      CAPTURE_ERROR_MESSAGE = 'Bogus Gateway: Use authorization number ending in 1 for exception, 2 for error and anything else for success'
+      VOID_ERROR_MESSAGE = 'Bogus Gateway: Use authorization number ending in 1 for exception, 2 for error and anything else for success'
+      REFUND_ERROR_MESSAGE = 'Bogus Gateway: Use trans_id number ending in 1 for exception, 2 for error and anything else for success'
+      CHECK_ERROR_MESSAGE = 'Bogus Gateway: Use bank account number ending in 1 for success, 2 for exception and anything else for error'
 
       self.supported_countries = []
       self.supported_cardtypes = [:bogus]
@@ -129,7 +129,7 @@ module ActiveMerchant #:nodoc:
       def authorize_swipe(money, paysource, options = {})
         money = amount(money)
         case normalize(paysource)
-        when /1$/
+        when /1$/, AUTHORIZATION
           Response.new(true, SUCCESS_MESSAGE, {:authorized_amount => money}, :test => true, :authorization => AUTHORIZATION )
         when /2$/
           Response.new(false, FAILURE_MESSAGE, {:authorized_amount => money, :error => FAILURE_MESSAGE }, :test => true, :error_code => STANDARD_ERROR_CODE[:processing_error])

data/lib/active_merchant/billing/gateways/borgun.rb

@@ -1,9 +1,9 @@
-require "nokogiri"
+require 'nokogiri'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class BorgunGateway < Gateway
-      self.display_name = "Borgun"
+      self.display_name = 'Borgun'
       self.homepage_url = 'http://www.borgun.com'
 
       self.test_url = 'https://gatewaytest.borgun.is/ws/Heimir.pub.ws:Authorization'
@@ -77,9 +77,9 @@ module ActiveMerchant #:nodoc:
       private
 
       CURRENCY_CODES = Hash.new{|h,k| raise ArgumentError.new("Unsupported currency for HDFC: #{k}")}
-      CURRENCY_CODES["ISK"] = "352"
-      CURRENCY_CODES["EUR"] = "978"
-      CURRENCY_CODES["USD"] = "840"
+      CURRENCY_CODES['ISK'] = '352'
+      CURRENCY_CODES['EUR'] = '978'
+      CURRENCY_CODES['USD'] = '840'
 
       def add_invoice(post, money, options)
         post[:TrAmount] = amount(money)
@@ -91,12 +91,12 @@ module ActiveMerchant #:nodoc:
         post[:PAN] = payment_method.number
         post[:ExpDate] = format(payment_method.year, :two_digits) + format(payment_method.month, :two_digits)
         post[:CVC2] = payment_method.verification_value
-        post[:DateAndTime] = Time.now.strftime("%y%m%d%H%M%S")
+        post[:DateAndTime] = Time.now.strftime('%y%m%d%H%M%S')
         post[:RRN] = 'AMRCNT' + six_random_digits
       end
 
       def add_reference(post, authorization)
-        dateandtime, batch, transaction, rrn, authcode, _, _, _ = split_authorization(authorization)
+        dateandtime, _batch, transaction, rrn, authcode, _, _, _ = split_authorization(authorization)
         post[:DateAndTime] = dateandtime
         post[:Transaction] = transaction
         post[:RRN] = rrn
@@ -151,7 +151,7 @@ module ActiveMerchant #:nodoc:
 
       def message_from(succeeded, response)
         if succeeded
-          "Succeeded"
+          'Succeeded'
         else
           response[:message] || "Error with ActionCode=#{response[:actioncode]}"
         end
@@ -167,11 +167,11 @@ module ActiveMerchant #:nodoc:
           response[:transtype],
           response[:tramount],
           response[:trcurrency]
-        ].join("|")
+        ].join('|')
       end
 
       def split_authorization(authorization)
-        dateandtime, batch, transaction, rrn, authcode, transtype, tramount, currency = authorization.split("|")
+        dateandtime, batch, transaction, rrn, authcode, transtype, tramount, currency = authorization.split('|')
         [dateandtime, batch, transaction, rrn, authcode, transtype, tramount, currency]
       end
 

data/lib/active_merchant/billing/gateways/bpoint.rb

@@ -185,7 +185,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def request_headers
-        { "Content-Type" => "application/soap+xml; charset=utf-8" }
+        { 'Content-Type' => 'application/soap+xml; charset=utf-8' }
       end
 
       def parse(body)

data/lib/active_merchant/billing/gateways/braintree/braintree_common.rb

@@ -1,7 +1,7 @@
 module BraintreeCommon
   def self.included(base)
     base.supported_countries = %w(US CA AD AT BE BG HR CY CZ DK EE FI FR GI DE GR GG HU IS IM IE IT JE LV LI LT LU MT MC NL NO PL PT RO SM SK SI ES SE CH TR GB SG HK MY AU NZ)
-    base.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners_club]
+    base.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners_club, :maestro]
     base.homepage_url = 'http://www.braintreepaymentsolutions.com'
     base.display_name = 'Braintree'
     base.default_currency = 'USD'
@@ -13,7 +13,7 @@ module BraintreeCommon
   end
 
   def scrub(transcript)
-    return "" if transcript.blank?
+    return '' if transcript.blank?
     transcript.
       gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]').
       gsub(%r((&?ccnumber=)\d*(&?)), '\1[FILTERED]\2').

data/lib/active_merchant/billing/gateways/braintree_blue.rb

@@ -1,9 +1,9 @@
 require 'active_merchant/billing/gateways/braintree/braintree_common'
 
 begin
-  require "braintree"
+  require 'braintree'
 rescue LoadError
-  raise "Could not load the braintree gem.  Use `gem install braintree` to install it."
+  raise 'Could not load the braintree gem.  Use `gem install braintree` to install it.'
 end
 
 unless Braintree::Version::Major == 2 && Braintree::Version::Minor >= 78
@@ -125,7 +125,7 @@ module ActiveMerchant #:nodoc:
             customer_exists_response = nil
             r.process{customer_exists_response = check_customer_exists(options[:customer])}
             r.process do
-              if customer_exists_response.params["exists"]
+              if customer_exists_response.params['exists']
                 add_credit_card_to_customer(creditcard, options)
               else
                 add_customer_with_credit_card(creditcard, options)
@@ -149,7 +149,7 @@ module ActiveMerchant #:nodoc:
               :cardholder_name => creditcard.name,
               :number => creditcard.number,
               :cvv => creditcard.verification_value,
-              :expiration_month => creditcard.month.to_s.rjust(2, "0"),
+              :expiration_month => creditcard.month.to_s.rjust(2, '0'),
               :expiration_year => creditcard.year.to_s
             }
           }, options)[:credit_card]
@@ -176,7 +176,7 @@ module ActiveMerchant #:nodoc:
           else
             @braintree_gateway.customer.delete(customer_vault_id)
           end
-          Response.new(true, "OK")
+          Response.new(true, 'OK')
         end
       end
       alias_method :delete, :unstore
@@ -187,7 +187,7 @@ module ActiveMerchant #:nodoc:
 
       def verify_credentials
         begin
-          @braintree_gateway.transaction.find("non_existent_token")
+          @braintree_gateway.transaction.find('non_existent_token')
         rescue Braintree::AuthenticationError
           return false
         rescue Braintree::NotFoundError
@@ -203,9 +203,9 @@ module ActiveMerchant #:nodoc:
         commit do
           begin
             @braintree_gateway.customer.find(customer_vault_id)
-            ActiveMerchant::Billing::Response.new(true, "Customer found", {exists: true}, authorization: customer_vault_id)
+            ActiveMerchant::Billing::Response.new(true, 'Customer found', {exists: true}, authorization: customer_vault_id)
           rescue Braintree::NotFoundError
-            ActiveMerchant::Billing::Response.new(true, "Customer not found", {exists: false})
+            ActiveMerchant::Billing::Response.new(true, 'Customer not found', {exists: false})
           end
         end
       end
@@ -220,7 +220,7 @@ module ActiveMerchant #:nodoc:
                 :cardholder_name => creditcard.name,
                 :number => creditcard.number,
                 :cvv => creditcard.verification_value,
-                :expiration_month => creditcard.month.to_s.rjust(2, "0"),
+                :expiration_month => creditcard.month.to_s.rjust(2, '0'),
                 :expiration_year => creditcard.year.to_s,
                 :token => options[:credit_card_token]
               }
@@ -254,7 +254,7 @@ module ActiveMerchant #:nodoc:
             cardholder_name: credit_card.name,
             number: credit_card.number,
             cvv: credit_card.verification_value,
-            expiration_month: credit_card.month.to_s.rjust(2, "0"),
+            expiration_month: credit_card.month.to_s.rjust(2, '0'),
             expiration_year: credit_card.year.to_s,
           }
           parameters[:billing_address] = map_address(options[:billing_address]) if options[:billing_address]
@@ -336,9 +336,9 @@ module ActiveMerchant #:nodoc:
 
       def message_from_result(result)
         if result.success?
-          "OK"
+          'OK'
         elsif result.errors.any?
-          result.errors.map { |e| "#{e.message} (#{e.code})" }.join(" ")
+          result.errors.map { |e| "#{e.message} (#{e.code})" }.join(' ')
         elsif result.credit_card_verification
           "Processor declined: #{result.credit_card_verification.processor_response_text} (#{result.credit_card_verification.processor_response_code})"
         else
@@ -377,41 +377,41 @@ module ActiveMerchant #:nodoc:
 
       def avs_mapping
         {
-          "street: M, zip: M" => "M",
-          "street: M, zip: N" => "A",
-          "street: M, zip: U" => "B",
-          "street: M, zip: I" => "B",
-          "street: M, zip: A" => "B",
-
-          "street: N, zip: M" => "Z",
-          "street: N, zip: N" => "C",
-          "street: N, zip: U" => "C",
-          "street: N, zip: I" => "C",
-          "street: N, zip: A" => "C",
-
-          "street: U, zip: M" => "P",
-          "street: U, zip: N" => "N",
-          "street: U, zip: U" => "I",
-          "street: U, zip: I" => "I",
-          "street: U, zip: A" => "I",
-
-          "street: I, zip: M" => "P",
-          "street: I, zip: N" => "C",
-          "street: I, zip: U" => "I",
-          "street: I, zip: I" => "I",
-          "street: I, zip: A" => "I",
-
-          "street: A, zip: M" => "P",
-          "street: A, zip: N" => "C",
-          "street: A, zip: U" => "I",
-          "street: A, zip: I" => "I",
-          "street: A, zip: A" => "I"
+          'street: M, zip: M' => 'M',
+          'street: M, zip: N' => 'A',
+          'street: M, zip: U' => 'B',
+          'street: M, zip: I' => 'B',
+          'street: M, zip: A' => 'B',
+
+          'street: N, zip: M' => 'Z',
+          'street: N, zip: N' => 'C',
+          'street: N, zip: U' => 'C',
+          'street: N, zip: I' => 'C',
+          'street: N, zip: A' => 'C',
+
+          'street: U, zip: M' => 'P',
+          'street: U, zip: N' => 'N',
+          'street: U, zip: U' => 'I',
+          'street: U, zip: I' => 'I',
+          'street: U, zip: A' => 'I',
+
+          'street: I, zip: M' => 'P',
+          'street: I, zip: N' => 'C',
+          'street: I, zip: U' => 'I',
+          'street: I, zip: I' => 'I',
+          'street: I, zip: A' => 'I',
+
+          'street: A, zip: M' => 'P',
+          'street: A, zip: N' => 'C',
+          'street: A, zip: U' => 'I',
+          'street: A, zip: I' => 'I',
+          'street: A, zip: A' => 'I'
         }
       end
 
       def message_from_transaction_result(result)
-        if result.transaction && result.transaction.status == "gateway_rejected"
-          "Transaction declined - gateway rejected"
+        if result.transaction && result.transaction.status == 'gateway_rejected'
+          'Transaction declined - gateway rejected'
         elsif result.transaction
           "#{result.transaction.processor_response_code} #{result.transaction.processor_response_text}"
         else
@@ -454,22 +454,22 @@ module ActiveMerchant #:nodoc:
 
       def customer_hash(customer, include_credit_cards=false)
         hash = {
-          "email" => customer.email,
-          "phone" => customer.phone,
-          "first_name" => customer.first_name,
-          "last_name" => customer.last_name,
-          "id" => customer.id
+          'email' => customer.email,
+          'phone' => customer.phone,
+          'first_name' => customer.first_name,
+          'last_name' => customer.last_name,
+          'id' => customer.id
         }
 
         if include_credit_cards
-          hash["credit_cards"] = customer.credit_cards.map do |cc|
+          hash['credit_cards'] = customer.credit_cards.map do |cc|
             {
-              "bin" => cc.bin,
-              "expiration_date" => cc.expiration_date,
-              "token" => cc.token,
-              "last_4" => cc.last_4,
-              "card_type" => cc.card_type,
-              "masked_number" => cc.masked_number
+              'bin' => cc.bin,
+              'expiration_date' => cc.expiration_date,
+              'token' => cc.token,
+              'last_4' => cc.last_4,
+              'card_type' => cc.card_type,
+              'masked_number' => cc.masked_number
             }
           end
         end
@@ -479,16 +479,16 @@ module ActiveMerchant #:nodoc:
 
       def transaction_hash(result)
         unless result.success?
-          return { "processor_response_code" => response_code_from_result(result) }
+          return { 'processor_response_code' => response_code_from_result(result) }
         end
 
         transaction = result.transaction
         if transaction.vault_customer
           vault_customer = {
           }
-          vault_customer["credit_cards"] = transaction.vault_customer.credit_cards.map do |cc|
+          vault_customer['credit_cards'] = transaction.vault_customer.credit_cards.map do |cc|
             {
-              "bin" => cc.bin
+              'bin' => cc.bin
             }
           end
         else
@@ -496,49 +496,49 @@ module ActiveMerchant #:nodoc:
         end
 
         customer_details = {
-          "id" => transaction.customer_details.id,
-          "email" => transaction.customer_details.email,
-          "phone" => transaction.customer_details.phone,
+          'id' => transaction.customer_details.id,
+          'email' => transaction.customer_details.email,
+          'phone' => transaction.customer_details.phone,
         }
 
         billing_details = {
-          "street_address"   => transaction.billing_details.street_address,
-          "extended_address" => transaction.billing_details.extended_address,
-          "company"          => transaction.billing_details.company,
-          "locality"         => transaction.billing_details.locality,
-          "region"           => transaction.billing_details.region,
-          "postal_code"      => transaction.billing_details.postal_code,
-          "country_name"     => transaction.billing_details.country_name,
+          'street_address'   => transaction.billing_details.street_address,
+          'extended_address' => transaction.billing_details.extended_address,
+          'company'          => transaction.billing_details.company,
+          'locality'         => transaction.billing_details.locality,
+          'region'           => transaction.billing_details.region,
+          'postal_code'      => transaction.billing_details.postal_code,
+          'country_name'     => transaction.billing_details.country_name,
         }
 
         shipping_details = {
-          "street_address"   => transaction.shipping_details.street_address,
-          "extended_address" => transaction.shipping_details.extended_address,
-          "company"          => transaction.shipping_details.company,
-          "locality"         => transaction.shipping_details.locality,
-          "region"           => transaction.shipping_details.region,
-          "postal_code"      => transaction.shipping_details.postal_code,
-          "country_name"     => transaction.shipping_details.country_name,
+          'street_address'   => transaction.shipping_details.street_address,
+          'extended_address' => transaction.shipping_details.extended_address,
+          'company'          => transaction.shipping_details.company,
+          'locality'         => transaction.shipping_details.locality,
+          'region'           => transaction.shipping_details.region,
+          'postal_code'      => transaction.shipping_details.postal_code,
+          'country_name'     => transaction.shipping_details.country_name,
         }
         credit_card_details = {
-          "masked_number"       => transaction.credit_card_details.masked_number,
-          "bin"                 => transaction.credit_card_details.bin,
-          "last_4"              => transaction.credit_card_details.last_4,
-          "card_type"           => transaction.credit_card_details.card_type,
-          "token"               => transaction.credit_card_details.token
+          'masked_number'       => transaction.credit_card_details.masked_number,
+          'bin'                 => transaction.credit_card_details.bin,
+          'last_4'              => transaction.credit_card_details.last_4,
+          'card_type'           => transaction.credit_card_details.card_type,
+          'token'               => transaction.credit_card_details.token
         }
 
         {
-          "order_id"                => transaction.order_id,
-          "amount"                  => transaction.amount.to_s,
-          "status"                  => transaction.status,
-          "credit_card_details"     => credit_card_details,
-          "customer_details"        => customer_details,
-          "billing_details"         => billing_details,
-          "shipping_details"        => shipping_details,
-          "vault_customer"          => vault_customer,
-          "merchant_account_id"     => transaction.merchant_account_id,
-          "processor_response_code" => response_code_from_result(result)
+          'order_id'                => transaction.order_id,
+          'amount'                  => transaction.amount.to_s,
+          'status'                  => transaction.status,
+          'credit_card_details'     => credit_card_details,
+          'customer_details'        => customer_details,
+          'billing_details'         => billing_details,
+          'shipping_details'        => shipping_details,
+          'vault_customer'          => vault_customer,
+          'merchant_account_id'     => transaction.merchant_account_id,
+          'processor_response_code' => response_code_from_result(result)
         }
       end
 
@@ -547,7 +547,7 @@ module ActiveMerchant #:nodoc:
           :amount => localized_amount(money, options[:currency] || default_currency).to_s,
           :order_id => options[:order_id],
           :customer => {
-            :id => options[:store] == true ? "" : options[:store],
+            :id => options[:store] == true ? '' : options[:store],
             :email => scrub_email(options[:email]),
             :phone => options[:phone] || (options[:billing_address][:phone] if options[:billing_address] &&
 	            options[:billing_address][:phone])
@@ -592,7 +592,7 @@ module ActiveMerchant #:nodoc:
             if credit_card_or_vault_id.source == :apple_pay
               parameters[:apple_pay_card] = {
                 :number => credit_card_or_vault_id.number,
-                :expiration_month => credit_card_or_vault_id.month.to_s.rjust(2, "0"),
+                :expiration_month => credit_card_or_vault_id.month.to_s.rjust(2, '0'),
                 :expiration_year => credit_card_or_vault_id.year.to_s,
                 :cardholder_name => credit_card_or_vault_id.name,
                 :cryptogram => credit_card_or_vault_id.payment_cryptogram,
@@ -602,7 +602,7 @@ module ActiveMerchant #:nodoc:
               parameters[:android_pay_card] = {
                 :number => credit_card_or_vault_id.number,
                 :cryptogram => credit_card_or_vault_id.payment_cryptogram,
-                :expiration_month => credit_card_or_vault_id.month.to_s.rjust(2, "0"),
+                :expiration_month => credit_card_or_vault_id.month.to_s.rjust(2, '0'),
                 :expiration_year => credit_card_or_vault_id.year.to_s,
                 :google_transaction_id => credit_card_or_vault_id.transaction_id,
                 :source_card_type => credit_card_or_vault_id.brand,
@@ -614,7 +614,7 @@ module ActiveMerchant #:nodoc:
             parameters[:credit_card] = {
               :number => credit_card_or_vault_id.number,
               :cvv => credit_card_or_vault_id.verification_value,
-              :expiration_month => credit_card_or_vault_id.month.to_s.rjust(2, "0"),
+              :expiration_month => credit_card_or_vault_id.month.to_s.rjust(2, '0'),
               :expiration_year => credit_card_or_vault_id.year.to_s,
               :cardholder_name => credit_card_or_vault_id.name
             }