activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/authorize_net_arb.rb

@@ -57,7 +57,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>:test</tt> -- +true+ or +false+. If true, perform transactions against the test server.
       #   Otherwise, perform transactions against the production server.
       def initialize(options = {})
-        ActiveMerchant.deprecated "ARB functionality in ActiveMerchant is deprecated and will be removed in a future version. Please contact the ActiveMerchant maintainers if you have an interest in taking ownership of a separate gem that continues support for it."
+        ActiveMerchant.deprecated 'ARB functionality in ActiveMerchant is deprecated and will be removed in a future version. Please contact the ActiveMerchant maintainers if you have an interest in taking ownership of a separate gem that continues support for it.'
         requires!(options, :login, :password)
         super
       end
@@ -377,7 +377,7 @@ module ActiveMerchant #:nodoc:
 
       def recurring_commit(action, request)
         url = test? ? test_url : live_url
-        xml = ssl_post(url, request, "Content-Type" => "text/xml")
+        xml = ssl_post(url, request, 'Content-Type' => 'text/xml')
 
         response = recurring_parse(action, xml)
 
@@ -395,7 +395,7 @@ module ActiveMerchant #:nodoc:
         response = {}
         xml = REXML::Document.new(xml)
         root = REXML::XPath.first(xml, "//#{RECURRING_ACTIONS[action]}Response") ||
-               REXML::XPath.first(xml, "//ErrorResponse")
+               REXML::XPath.first(xml, '//ErrorResponse')
         if root
           root.elements.to_a.each do |node|
             recurring_parse_element(response, node)

data/lib/active_merchant/billing/gateways/authorize_net_cim.rb

@@ -854,11 +854,11 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, request)
         url = test? ? test_url : live_url
-        xml = ssl_post(url, request, "Content-Type" => "text/xml")
+        xml = ssl_post(url, request, 'Content-Type' => 'text/xml')
 
         response_params = parse(action, xml)
 
-        message_element= response_params["messages"]["message"]
+        message_element= response_params['messages']['message']
         first_error = message_element.is_a?(Array) ? message_element.first : message_element
         message = first_error['text']
         test_mode = @options[:test_requests] || message =~ /Test Mode/
@@ -942,7 +942,7 @@ module ActiveMerchant #:nodoc:
       def parse(action, xml)
         xml = REXML::Document.new(xml)
         root = REXML::XPath.first(xml, "//#{CIM_ACTIONS[action]}Response") ||
-               REXML::XPath.first(xml, "//ErrorResponse")
+               REXML::XPath.first(xml, '//ErrorResponse')
         if root
           response = parse_element(root)
         end

data/lib/active_merchant/billing/gateways/axcessms.rb

@@ -1,8 +1,8 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class AxcessmsGateway < Gateway
-      self.test_url = "https://test.ctpe.io/payment/ctpe"
-      self.live_url = "https://ctpe.io/payment/ctpe"
+      self.test_url = 'https://test.ctpe.io/payment/ctpe'
+      self.live_url = 'https://ctpe.io/payment/ctpe'
 
       self.supported_countries = %w(AD AT BE BG BR CA CH CY CZ DE DK EE ES FI FO FR GB
                                     GI GR HR HU IE IL IM IS IT LI LT LU LV MC MT MX NL
@@ -10,18 +10,18 @@ module ActiveMerchant #:nodoc:
 
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :maestro, :solo]
 
-      self.homepage_url = "http://www.axcessms.com/"
-      self.display_name = "Axcess MS"
+      self.homepage_url = 'http://www.axcessms.com/'
+      self.display_name = 'Axcess MS'
       self.money_format = :dollars
-      self.default_currency = "GBP"
+      self.default_currency = 'GBP'
 
-      API_VERSION = "1.0"
-      PAYMENT_CODE_PREAUTHORIZATION = "CC.PA"
-      PAYMENT_CODE_DEBIT = "CC.DB"
-      PAYMENT_CODE_CAPTURE = "CC.CP"
-      PAYMENT_CODE_REVERSAL = "CC.RV"
-      PAYMENT_CODE_REFUND = "CC.RF"
-      PAYMENT_CODE_REBILL = "CC.RB"
+      API_VERSION = '1.0'
+      PAYMENT_CODE_PREAUTHORIZATION = 'CC.PA'
+      PAYMENT_CODE_DEBIT = 'CC.DB'
+      PAYMENT_CODE_CAPTURE = 'CC.CP'
+      PAYMENT_CODE_REVERSAL = 'CC.RV'
+      PAYMENT_CODE_REFUND = 'CC.RF'
+      PAYMENT_CODE_REBILL = 'CC.RB'
 
       def initialize(options={})
         requires!(options, :sender, :login, :password, :channel)
@@ -59,21 +59,21 @@ module ActiveMerchant #:nodoc:
       private
 
       def commit(paymentcode, money, payment, options)
-        options[:mode] ||= (test? ? "INTEGRATOR_TEST" : "LIVE")
+        options[:mode] ||= (test? ? 'INTEGRATOR_TEST' : 'LIVE')
         request = build_request(paymentcode, money, payment, options)
 
         headers = {
-          "Content-Type" => "application/x-www-form-urlencoded;charset=UTF-8"
+          'Content-Type' => 'application/x-www-form-urlencoded;charset=UTF-8'
         }
 
         response = parse(ssl_post((test? ? test_url : live_url), "load=#{CGI.escape(request)}", headers))
-        success = (response[:result] == "ACK")
+        success = (response[:result] == 'ACK')
         message = "#{response[:reason]} - #{response[:return]}"
         authorization = response[:unique_id]
 
         Response.new(success, message, response,
           :authorization => authorization,
-          :test => (response[:mode] != "LIVE")
+          :test => (response[:mode] != 'LIVE')
         )
       end
 
@@ -87,7 +87,7 @@ module ActiveMerchant #:nodoc:
           parse_element(response, node)
         end
 
-        response[:mode] = REXML::XPath.first(xml, "//Transaction").attributes["mode"]
+        response[:mode] = REXML::XPath.first(xml, '//Transaction').attributes['mode']
 
         response
       end
@@ -107,30 +107,30 @@ module ActiveMerchant #:nodoc:
       def build_request(payment_code, money, payment, options)
         xml = Builder::XmlMarkup.new :indent => 2
         xml.instruct!
-        xml.tag! "Request", "version" => API_VERSION do
-          xml.tag! "Header" do
-            xml.tag! "Security", "sender" => @options[:sender]
+        xml.tag! 'Request', 'version' => API_VERSION do
+          xml.tag! 'Header' do
+            xml.tag! 'Security', 'sender' => @options[:sender]
           end
-          xml.tag! "Transaction", "mode" => options[:mode], "channel" => @options[:channel], "response" => "SYNC" do
-            xml.tag! "User", "login" => @options[:login], "pwd" => @options[:password]
-            xml.tag! "Identification" do
-              xml.tag! "TransactionID", options[:order_id] || generate_unique_id
-              xml.tag! "ReferenceID", payment unless payment.respond_to?(:number)
+          xml.tag! 'Transaction', 'mode' => options[:mode], 'channel' => @options[:channel], 'response' => 'SYNC' do
+            xml.tag! 'User', 'login' => @options[:login], 'pwd' => @options[:password]
+            xml.tag! 'Identification' do
+              xml.tag! 'TransactionID', options[:order_id] || generate_unique_id
+              xml.tag! 'ReferenceID', payment unless payment.respond_to?(:number)
             end
 
-            xml.tag! "Payment", "code" => payment_code do
-              xml.tag! "Memo", options[:memo] unless options[:memo].blank?
-              xml.tag! "Presentation" do
-                xml.tag! "Amount", amount(money)
-                xml.tag! "Currency", (options[:currency] || currency(money))
-                xml.tag! "Usage", options[:description]
+            xml.tag! 'Payment', 'code' => payment_code do
+              xml.tag! 'Memo', options[:memo] unless options[:memo].blank?
+              xml.tag! 'Presentation' do
+                xml.tag! 'Amount', amount(money)
+                xml.tag! 'Currency', (options[:currency] || currency(money))
+                xml.tag! 'Usage', options[:description]
               end
             end
 
             if payment.respond_to?(:number)
               add_payment(xml, payment)
 
-              xml.tag! "Customer" do
+              xml.tag! 'Customer' do
                 add_customer_name(xml, payment)
                 add_address(xml, options[:billing_address] || options[:address])
                 add_contact(xml, options)
@@ -143,37 +143,37 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_contact(xml, options)
-        xml.tag! "Contact" do
-          xml.tag! "Email", (options[:email] || "unknown@example.com")
-          xml.tag! "Ip", (options[:ip] || "127.0.0.1")
+        xml.tag! 'Contact' do
+          xml.tag! 'Email', (options[:email] || 'unknown@example.com')
+          xml.tag! 'Ip', (options[:ip] || '127.0.0.1')
         end
       end
 
       def add_customer_name(xml, payment)
-        xml.tag! "Name" do
-          xml.tag! "Given", payment.first_name
-          xml.tag! "Family", payment.last_name
+        xml.tag! 'Name' do
+          xml.tag! 'Given', payment.first_name
+          xml.tag! 'Family', payment.last_name
         end
       end
 
       def add_payment(xml, payment)
-        xml.tag! "Account" do
-          xml.tag! "Number", payment.number
-          xml.tag! "Holder", payment.name
-          xml.tag! "Brand", payment.brand
-          xml.tag! "Expiry", "month" => payment.month, "year" => payment.year
-          xml.tag! "Verification", payment.verification_value
+        xml.tag! 'Account' do
+          xml.tag! 'Number', payment.number
+          xml.tag! 'Holder', payment.name
+          xml.tag! 'Brand', payment.brand
+          xml.tag! 'Expiry', 'month' => payment.month, 'year' => payment.year
+          xml.tag! 'Verification', payment.verification_value
         end
       end
 
       def add_address(xml, address)
-        raise ArgumentError.new("Address is required") unless address
-        xml.tag! "Address" do
-          xml.tag! "Street", "#{address[:address1]} #{address[:address2]}".strip
-          xml.tag! "City", address[:city]
-          xml.tag! "State", address[:state]
-          xml.tag! "Zip", address[:zip]
-          xml.tag! "Country", address[:country]
+        raise ArgumentError.new('Address is required') unless address
+        xml.tag! 'Address' do
+          xml.tag! 'Street', "#{address[:address1]} #{address[:address2]}".strip
+          xml.tag! 'City', address[:city]
+          xml.tag! 'State', address[:state]
+          xml.tag! 'Zip', address[:zip]
+          xml.tag! 'Country', address[:country]
         end
       end
     end

data/lib/active_merchant/billing/gateways/balanced.rb

@@ -17,7 +17,7 @@ module ActiveMerchant #:nodoc:
     #    live" button on the Balanced dashboard and fill in your marketplace
     #    details.
     class BalancedGateway < Gateway
-      VERSION = "2.0.0"
+      VERSION = '2.0.0'
 
       self.live_url = 'https://api.balancedpayments.com'
 
@@ -50,7 +50,7 @@ module ActiveMerchant #:nodoc:
           else
             payment_method
           end
-          r.process{commit("debits", "cards/#{card_identifier_from(identifier)}/debits", post)}
+          r.process{commit('debits', "cards/#{card_identifier_from(identifier)}/debits", post)}
         end
       end
 
@@ -67,7 +67,7 @@ module ActiveMerchant #:nodoc:
           else
             payment_method
           end
-          r.process{commit("card_holds", "cards/#{card_identifier_from(identifier)}/card_holds", post)}
+          r.process{commit('card_holds', "cards/#{card_identifier_from(identifier)}/card_holds", post)}
         end
       end
 
@@ -77,7 +77,7 @@ module ActiveMerchant #:nodoc:
         post[:description] = options[:description] if options[:description]
         add_common_params(post, options)
 
-        commit("debits", "card_holds/#{reference_identifier_from(identifier)}/debits", post)
+        commit('debits', "card_holds/#{reference_identifier_from(identifier)}/debits", post)
       end
 
       def void(identifier, options = {})
@@ -85,7 +85,7 @@ module ActiveMerchant #:nodoc:
         post[:is_void] = true
         add_common_params(post, options)
 
-        commit("card_holds", "card_holds/#{reference_identifier_from(identifier)}", post, :put)
+        commit('card_holds', "card_holds/#{reference_identifier_from(identifier)}", post, :put)
       end
 
       def refund(money, identifier, options = {})
@@ -94,7 +94,7 @@ module ActiveMerchant #:nodoc:
         post[:description] = options[:description]
         add_common_params(post, options)
 
-        commit("refunds", "debits/#{reference_identifier_from(identifier)}/refunds", post)
+        commit('refunds', "debits/#{reference_identifier_from(identifier)}/refunds", post)
       end
 
       def store(credit_card, options={})
@@ -108,7 +108,7 @@ module ActiveMerchant #:nodoc:
 
         add_address(post, options)
 
-        commit("cards", "cards", post)
+        commit('cards', 'cards', post)
       end
 
       private
@@ -117,18 +117,18 @@ module ActiveMerchant #:nodoc:
         case identifier
         when %r{\|}
           uri = identifier.
-            split("|").
+            split('|').
             detect{|part| part.size > 0}
-          uri.split("/")[2]
+          uri.split('/')[2]
         when %r{\/}
-          identifier.split("/")[5]
+          identifier.split('/')[5]
         else
           identifier
         end
       end
 
       def card_identifier_from(identifier)
-        identifier.split("/").last
+        identifier.split('/').last
       end
 
       def add_amount(post, money)
@@ -180,29 +180,29 @@ module ActiveMerchant #:nodoc:
         entity = (raw_response[entity_name] || []).first
         if(!entity)
           false
-        elsif((entity_name == "refunds") && entity.include?("status"))
-          %w(succeeded pending).include?(entity["status"])
-        elsif(entity.include?("status"))
-          (entity["status"] == "succeeded")
-        elsif(entity_name == "cards")
-          !!entity["id"]
+        elsif((entity_name == 'refunds') && entity.include?('status'))
+          %w(succeeded pending).include?(entity['status'])
+        elsif(entity.include?('status'))
+          (entity['status'] == 'succeeded')
+        elsif(entity_name == 'cards')
+          !!entity['id']
         else
           false
         end
       end
 
       def message_from(raw_response)
-        if(raw_response["errors"])
-          error = raw_response["errors"].first
-          (error["additional"] || error["message"] || error["description"])
+        if(raw_response['errors'])
+          error = raw_response['errors'].first
+          (error['additional'] || error['message'] || error['description'])
         else
-          "Success"
+          'Success'
         end
       end
 
       def authorization_from(entity_name, raw_response)
         entity = (raw_response[entity_name] || []).first
-        (entity && entity["id"])
+        (entity && entity['id'])
       end
 
       def parse(body)
@@ -211,8 +211,8 @@ module ActiveMerchant #:nodoc:
         message = 'Invalid response received from the Balanced API. Please contact support@balancedpayments.com if you continue to receive this message.'
         message += " (The raw response returned by the API was #{raw_response.inspect})"
         {
-          "errors" => [{
-            "message" => message
+          'errors' => [{
+            'message' => message
           }]
         }
       end
@@ -231,7 +231,7 @@ module ActiveMerchant #:nodoc:
           else
             "#{key}=#{CGI.escape(value.to_s)}"
           end
-        end.compact.join("&")
+        end.compact.join('&')
       end
 
       def headers
@@ -245,10 +245,10 @@ module ActiveMerchant #:nodoc:
         )
 
         {
-            "Authorization" => "Basic " + Base64.encode64(@options[:login].to_s + ":").strip,
-            "User-Agent" => "Balanced/v1.1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
-            "Accept" => "application/vnd.api+json;revision=1.1",
-            "X-Balanced-User-Agent" => @@ua,
+            'Authorization' => 'Basic ' + Base64.encode64(@options[:login].to_s + ':').strip,
+            'User-Agent' => "Balanced/v1.1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
+            'Accept' => 'application/vnd.api+json;revision=1.1',
+            'X-Balanced-User-Agent' => @@ua,
         }
       end
     end

data/lib/active_merchant/billing/gateways/bank_frick.rb

@@ -93,7 +93,7 @@ module ActiveMerchant #:nodoc:
         if address = options[:billing_address] || options[:address]
           post[:address] = address[:address1].to_s
           post[:company] = address[:company].to_s
-          post[:phone]   = address[:phone].to_s.gsub(/[^0-9]/, '') || "0000000"
+          post[:phone]   = address[:phone].to_s.gsub(/[^0-9]/, '') || '0000000'
           post[:zip]     = address[:zip].to_s
           post[:city]    = address[:city].to_s
           post[:country] = address[:country].to_s
@@ -121,11 +121,11 @@ module ActiveMerchant #:nodoc:
       def parse(body)
         results  = {}
         xml = Nokogiri::XML(body)
-        resp = xml.xpath("//Response/Transaction/Identification")
+        resp = xml.xpath('//Response/Transaction/Identification')
         resp.children.each do |element|
           results[element.name.downcase.to_sym] = element.text
         end
-        resp = xml.xpath("//Response/Transaction/Processing")
+        resp = xml.xpath('//Response/Transaction/Processing')
         resp.children.each do |element|
           results[element.name.downcase.to_sym] = element.text
         end

data/lib/active_merchant/billing/gateways/banwire.rb

@@ -40,13 +40,13 @@ module ActiveMerchant #:nodoc:
       private
 
       def add_response_type(post)
-        post[:response_format] = "JSON"
+        post[:response_format] = 'JSON'
       end
 
       def add_customer_data(post, options)
         post[:user] = @options[:login]
         post[:phone] = options[:billing_address][:phone]
-        post[:mail] = options[:email] || "unspecified@email.com"
+        post[:mail] = options[:email] || 'unspecified@email.com'
       end
 
       def add_order_data(post, options)
@@ -74,7 +74,7 @@ module ActiveMerchant #:nodoc:
 
       def card_brand(card)
         brand = super
-        ({"master" => "mastercard", "american_express" => "amex"}[brand] || brand)
+        ({'master' => 'mastercard', 'american_express' => 'amex'}[brand] || brand)
       end
 
       def parse(body)
@@ -90,25 +90,25 @@ module ActiveMerchant #:nodoc:
         end
 
         Response.new(success?(response),
-                     response["message"],
+                     response['message'],
                      response,
                      :test => test?,
-                     :authorization => response["code_auth"])
+                     :authorization => response['code_auth'])
       end
 
       def success?(response)
-        (response["response"] == "ok")
+        (response['response'] == 'ok')
       end
 
       def post_data(parameters = {})
-        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def json_error(raw_response)
         msg = 'Invalid response received from the Banwire API.  Please contact Banwire support if you continue to receive this message.'
         msg += "  (The raw response returned by the API was #{raw_response.inspect})"
         {
-          "message" => msg
+          'message' => msg
         }
       end
     end