activemerchant 1.79.2 → 1.80.0

data/lib/active_merchant/billing/gateways/ezic.rb

@@ -23,7 +23,7 @@ module ActiveMerchant
         add_payment(post, payment)
         add_customer_data(post, options)
 
-        commit("S", post)
+        commit('S', post)
       end
 
       def authorize(money, payment, options={})
@@ -34,7 +34,7 @@ module ActiveMerchant
         add_payment(post, payment)
         add_customer_data(post, options)
 
-        commit("A", post)
+        commit('A', post)
       end
 
       def capture(money, authorization, options={})
@@ -45,7 +45,7 @@ module ActiveMerchant
         add_authorization(post, authorization)
         add_pay_type(post)
 
-        commit("D", post)
+        commit('D', post)
       end
 
       def refund(money, authorization, options={})
@@ -56,7 +56,7 @@ module ActiveMerchant
         add_authorization(post, authorization)
         add_pay_type(post)
 
-        commit("R", post)
+        commit('R', post)
       end
 
       def void(authorization, options={})
@@ -66,7 +66,7 @@ module ActiveMerchant
         add_authorization(post, authorization)
         add_pay_type(post)
 
-        commit("U", post)
+        commit('U', post)
       end
 
       def verify(credit_card, options={})
@@ -143,7 +143,7 @@ module ActiveMerchant
       end
 
       def add_pay_type(post)
-        post[:pay_type] = "C"
+        post[:pay_type] = 'C'
       end
 
       def parse(body)
@@ -160,8 +160,8 @@ module ActiveMerchant
             message_from(response),
             response,
             authorization: authorization_from(response),
-            avs_result: AVSResult.new(code: response["avs_code"]),
-            cvv_result: CVVResult.new(response["cvv2_code"]),
+            avs_result: AVSResult.new(code: response['avs_code']),
+            cvv_result: CVVResult.new(response['cvv2_code']),
             test: test?
           )
         rescue ResponseError => e
@@ -170,24 +170,24 @@ module ActiveMerchant
       end
 
       def success_from(response)
-        response["status_code"] == "1" || response["status_code"] == "T"
+        response['status_code'] == '1' || response['status_code'] == 'T'
       end
 
       def message_from(response)
-        response["auth_msg"]
+        response['auth_msg']
       end
 
       def authorization_from(response)
-        response["trans_id"]
+        response['trans_id']
       end
 
       def post_data(parameters = {})
-        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        parameters.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def headers
         {
-          "User-Agent" => "ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
+          'User-Agent' => "ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
         }
       end
     end

data/lib/active_merchant/billing/gateways/fat_zebra.rb

@@ -3,8 +3,8 @@ require 'json'
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class FatZebraGateway < Gateway
-      self.live_url = "https://gateway.fatzebra.com.au/v1.0"
-      self.test_url = "https://gateway.sandbox.fatzebra.com.au/v1.0"
+      self.live_url = 'https://gateway.fatzebra.com.au/v1.0'
+      self.test_url = 'https://gateway.sandbox.fatzebra.com.au/v1.0'
 
       self.supported_countries = ['AU']
       self.default_currency = 'AUD'
@@ -61,14 +61,14 @@ module ActiveMerchant #:nodoc:
         post[:transaction_id] = txn_id
         add_order_id(post, options)
 
-        commit(:post, "refunds", post)
+        commit(:post, 'refunds', post)
       end
 
       def store(creditcard, options={})
         post = {}
         add_creditcard(post, creditcard)
 
-        commit(:post, "credit_cards", post)
+        commit(:post, 'credit_cards', post)
       end
 
       def supports_scrubbing?
@@ -100,7 +100,7 @@ module ActiveMerchant #:nodoc:
           post[:card_token] = creditcard
           post[:cvv] = options[:cvv]
         elsif creditcard.is_a?(Hash)
-          ActiveMerchant.deprecated "Passing the credit card as a Hash is deprecated. Use a String and put the (optional) CVV in the options hash instead."
+          ActiveMerchant.deprecated 'Passing the credit card as a Hash is deprecated. Use a String and put the (optional) CVV in the options hash instead.'
           post[:card_token] = creditcard[:token]
           post[:cvv] = creditcard[:cvv]
         else
@@ -110,7 +110,7 @@ module ActiveMerchant #:nodoc:
 
       def add_extra_options(post, options)
         extra = {}
-        extra[:ecm] = "32" if options[:recurring]
+        extra[:ecm] = '32' if options[:recurring]
         extra[:cavv] = options[:cavv] if options[:cavv]
         extra[:xid] = options[:xid] if options[:xid]
         extra[:sli] = options[:sli] if options[:sli]
@@ -124,14 +124,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_ip(post, options)
-        post[:customer_ip] = options[:ip] || "127.0.0.1"
+        post[:customer_ip] = options[:ip] || '127.0.0.1'
       end
 
       def commit(method, uri, parameters=nil)
         response = begin
           parse(ssl_request(method, get_url(uri), parameters.to_json, headers))
         rescue ResponseError => e
-          return Response.new(false, "Invalid Login") if(e.response.code == "401")
+          return Response.new(false, 'Invalid Login') if(e.response.code == '401')
           parse(e.response.body)
         end
 
@@ -140,34 +140,34 @@ module ActiveMerchant #:nodoc:
           success,
           message_from(response),
           response,
-          :test => response["test"],
+          :test => response['test'],
           :authorization => authorization_from(response, success)
         )
       end
 
       def success_from(response)
         (
-          response["successful"] &&
-          response["response"] &&
-          (response["response"]["successful"] || response["response"]["token"])
+          response['successful'] &&
+          response['response'] &&
+          (response['response']['successful'] || response['response']['token'])
         )
       end
 
       def authorization_from(response, success)
         if success
-          (response["response"]["id"] || response["response"]["token"])
+          (response['response']['id'] || response['response']['token'])
         else
           nil
         end
       end
 
       def message_from(response)
-        if !response["errors"].empty?
-          response["errors"].join(", ")
-        elsif response["response"]["message"]
-          response["response"]["message"]
+        if !response['errors'].empty?
+          response['errors'].join(', ')
+        elsif response['response']['message']
+          response['response']['message']
         else
-          "Unknown Error"
+          'Unknown Error'
         end
       end
 
@@ -178,22 +178,22 @@ module ActiveMerchant #:nodoc:
           msg = 'Invalid JSON response received from Fat Zebra. Please contact support@fatzebra.com.au if you continue to receive this message.'
           msg += "  (The raw response returned by the API was #{response.inspect})"
           {
-            "successful" => false,
-            "response" => {},
-            "errors" => [msg]
+            'successful' => false,
+            'response' => {},
+            'errors' => [msg]
           }
         end
       end
 
       def get_url(uri)
         base = test? ? self.test_url : self.live_url
-        base + "/" + uri
+        base + '/' + uri
       end
 
       def headers
         {
-          "Authorization" => "Basic " + Base64.strict_encode64(@options[:username].to_s + ":" + @options[:token].to_s).strip,
-          "User-Agent" => "Fat Zebra v1.0/ActiveMerchant #{ActiveMerchant::VERSION}"
+          'Authorization' => 'Basic ' + Base64.strict_encode64(@options[:username].to_s + ':' + @options[:token].to_s).strip,
+          'User-Agent' => "Fat Zebra v1.0/ActiveMerchant #{ActiveMerchant::VERSION}"
         }
       end
     end

data/lib/active_merchant/billing/gateways/federated_canada.rb

@@ -140,11 +140,11 @@ module ActiveMerchant #:nodoc:
       def message_from(response)
         case response['response'].to_i
         when APPROVED
-          "Transaction Approved"
+          'Transaction Approved'
         when DECLINED
-          "Transaction Declined"
+          'Transaction Declined'
         else
-          "Error in transaction data or system error"
+          'Error in transaction data or system error'
         end
       end
 

data/lib/active_merchant/billing/gateways/first_giving.rb

@@ -31,7 +31,7 @@ module ActiveMerchant #:nodoc:
         get = {}
         get[:transactionId] = identifier
         get[:tranType]     = 'REFUNDREQUEST'
-        commit("/transaction/refundrequest?" + encode(get))
+        commit('/transaction/refundrequest?' + encode(get))
       end
 
       private
@@ -39,13 +39,13 @@ module ActiveMerchant #:nodoc:
       def add_donation_data(post, money, options)
         post[:amount] = amount(money)
         post[:charityId] = @options[:charity_id]
-        post[:description] = (options[:description] || "Purchase")
+        post[:description] = (options[:description] || 'Purchase')
         post[:currencyCode] = (options[:currency] || currency(money))
       end
 
       def add_customer_data(post, options)
-        post[:billToEmail] = (options[:email] || "activemerchant@example.com")
-        post[:remoteAddr]  = (options[:ip] || "127.0.0.1")
+        post[:billToEmail] = (options[:email] || 'activemerchant@example.com')
+        post[:remoteAddr]  = (options[:ip] || '127.0.0.1')
       end
 
       def add_address(post, options)
@@ -76,7 +76,7 @@ module ActiveMerchant #:nodoc:
         response = {}
 
         xml = Nokogiri::XML(body)
-        element = xml.xpath("//firstGivingDonationApi/firstGivingResponse").first
+        element = xml.xpath('//firstGivingDonationApi/firstGivingResponse').first
 
         element.attributes.each do |name, attribute|
           response[name] = attribute.content
@@ -103,16 +103,16 @@ module ActiveMerchant #:nodoc:
         end
 
         Response.new(
-          (response["acknowledgement"] == "Success"),
-          (response["friendlyErrorMessage"] || response["verboseErrorMessage"] || response["acknowledgement"]),
+          (response['acknowledgement'] == 'Success'),
+          (response['friendlyErrorMessage'] || response['verboseErrorMessage'] || response['acknowledgement']),
           response,
-          authorization: response["transactionId"],
+          authorization: response['transactionId'],
           test: test?,
         )
       end
 
       def post_data(post)
-        post.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
+        post.collect { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join('&')
       end
 
       def encode(hash)
@@ -121,10 +121,10 @@ module ActiveMerchant #:nodoc:
 
       def creditcard_brand(brand)
         case brand
-        when "visa" then "VI"
-        when "master" then "MC"
-        when "discover" then "DI"
-        when "american_express" then "AX"
+        when 'visa' then 'VI'
+        when 'master' then 'MC'
+        when 'discover' then 'DI'
+        when 'american_express' then 'AX'
         else
           raise "Unhandled credit card brand #{brand}"
         end
@@ -132,9 +132,9 @@ module ActiveMerchant #:nodoc:
 
       def headers
         {
-          "User-Agent"        => "ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
-          "JG_APPLICATIONKEY" => "#{@options[:application_key]}",
-          "JG_SECURITYTOKEN"  => "#{@options[:security_token]}"
+          'User-Agent'        => "ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
+          'JG_APPLICATIONKEY' => "#{@options[:application_key]}",
+          'JG_SECURITYTOKEN'  => "#{@options[:security_token]}"
         }
       end
     end

data/lib/active_merchant/billing/gateways/first_pay.rb

@@ -21,7 +21,7 @@ module ActiveMerchant #:nodoc:
       def purchase(money, payment, options={})
         post = {}
         add_invoice(post, money, options)
-        add_payment(post, payment)
+        add_payment(post, payment, options)
         add_address(post, payment, options)
         add_customer_data(post, options)
 
@@ -31,7 +31,7 @@ module ActiveMerchant #:nodoc:
       def authorize(money, payment, options={})
         post = {}
         add_invoice(post, money, options)
-        add_payment(post, payment)
+        add_payment(post, payment, options)
         add_address(post, payment, options)
         add_customer_data(post, options)
 
@@ -87,11 +87,14 @@ module ActiveMerchant #:nodoc:
         post[:total] = amount(money)
       end
 
-      def add_payment(post, payment)
+      def add_payment(post, payment, options)
         post[:card_name] = payment.brand # Unclear if need to map to known names or open text field??
         post[:card_number] = payment.number
         post[:card_exp] = expdate(payment)
         post[:cvv2] = payment.verification_value
+        post[:recurring] = options[:recurring] if options[:recurring]
+        post[:recurringStartDate] = options[:recurring_start_date] if options[:recurring_start_date]
+        post[:recurringEndDate] = options[:recurring_end_date] if options[:recurring_end_date]
       end
 
       def add_reference(post, action, money, authorization)
@@ -104,7 +107,7 @@ module ActiveMerchant #:nodoc:
         response = {}
 
         doc = Nokogiri::XML(xml)
-        doc.root.xpath("//RESPONSE/FIELDS/FIELD").each do |field|
+        doc.root.xpath('//RESPONSE/FIELDS/FIELD').each do |field|
           response[field['KEY']] = field.text
         end unless doc.root.nil?
 

data/lib/active_merchant/billing/gateways/firstdata_e4.rb

@@ -2,45 +2,45 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class FirstdataE4Gateway < Gateway
       # TransArmor support requires v11 or lower
-      self.test_url = "https://api.demo.globalgatewaye4.firstdata.com/transaction/v11"
-      self.live_url = "https://api.globalgatewaye4.firstdata.com/transaction/v11"
+      self.test_url = 'https://api.demo.globalgatewaye4.firstdata.com/transaction/v11'
+      self.live_url = 'https://api.globalgatewaye4.firstdata.com/transaction/v11'
 
       TRANSACTIONS = {
-        sale:          "00",
-        authorization: "01",
-        verify:        "05",
-        capture:       "32",
-        void:          "33",
-        credit:        "34",
-        store:         "05"
+        sale:          '00',
+        authorization: '01',
+        verify:        '05',
+        capture:       '32',
+        void:          '33',
+        credit:        '34',
+        store:         '05'
       }
 
       POST_HEADERS = {
-        "Accepts" => "application/xml",
-        "Content-Type" => "application/xml"
+        'Accepts' => 'application/xml',
+        'Content-Type' => 'application/xml'
       }
 
-      SUCCESS = "true"
+      SUCCESS = 'true'
 
       SENSITIVE_FIELDS = [:verification_str2, :expiry_date, :card_number]
 
       BRANDS = {
         :visa => 'Visa',
-        :master => "Mastercard",
-        :american_express => "American Express",
-        :jcb => "JCB",
-        :discover => "Discover"
+        :master => 'Mastercard',
+        :american_express => 'American Express',
+        :jcb => 'JCB',
+        :discover => 'Discover'
       }
 
-      E4_BRANDS = BRANDS.merge({:mastercard => "Mastercard"})
+      E4_BRANDS = BRANDS.merge({:mastercard => 'Mastercard'})
 
-      DEFAULT_ECI = "07"
+      DEFAULT_ECI = '07'
 
       self.supported_cardtypes = BRANDS.keys
-      self.supported_countries = ["CA", "US"]
-      self.default_currency = "USD"
-      self.homepage_url = "http://www.firstdata.com"
-      self.display_name = "FirstData Global Gateway e4"
+      self.supported_countries = ['CA', 'US']
+      self.default_currency = 'USD'
+      self.homepage_url = 'http://www.firstdata.com'
+      self.display_name = 'FirstData Global Gateway e4'
 
       STANDARD_ERROR_CODE_MAPPING = {
       # Bank error codes: https://firstdata.zendesk.com/entries/471297-First-Data-Global-Gateway-e4-Bank-Response-Codes
@@ -132,8 +132,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def verify_credentials
-        response = void("0")
-        response.message != "Unauthorized Request. Bad or missing credentials."
+        response = void('0')
+        response.message != 'Unauthorized Request. Bad or missing credentials.'
       end
 
       def supports_scrubbing?
@@ -159,7 +159,7 @@ module ActiveMerchant #:nodoc:
         xml = Builder::XmlMarkup.new
 
         xml.instruct!
-        xml.tag! "Transaction", xmlns: "http://secure2.e-xact.com/vplug-in/transaction/rpc-enc/encodedTypes" do
+        xml.tag! 'Transaction', xmlns: 'http://secure2.e-xact.com/vplug-in/transaction/rpc-enc/encodedTypes' do
           add_credentials(xml)
           add_transaction_type(xml, action)
           xml << body
@@ -208,19 +208,19 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credentials(xml)
-        xml.tag! "ExactID", @options[:login]
-        xml.tag! "Password", @options[:password]
+        xml.tag! 'ExactID', @options[:login]
+        xml.tag! 'Password', @options[:password]
       end
 
       def add_transaction_type(xml, action)
-        xml.tag! "Transaction_Type", TRANSACTIONS[action]
+        xml.tag! 'Transaction_Type', TRANSACTIONS[action]
       end
 
       def add_identification(xml, identification)
-        authorization_num, transaction_tag, _ = identification.split(";")
+        authorization_num, transaction_tag, _ = identification.split(';')
 
-        xml.tag! "Authorization_Num", authorization_num
-        xml.tag! "Transaction_Tag", transaction_tag
+        xml.tag! 'Authorization_Num', authorization_num
+        xml.tag! 'Transaction_Tag', transaction_tag
       end
 
       def add_amount(xml, money, options)
@@ -231,13 +231,13 @@ module ActiveMerchant #:nodoc:
 
       def add_credit_card(xml, credit_card, options)
         if credit_card.respond_to?(:track_data) && credit_card.track_data.present?
-          xml.tag! "Track1", credit_card.track_data
-          xml.tag! "Ecommerce_Flag", "R"
+          xml.tag! 'Track1', credit_card.track_data
+          xml.tag! 'Ecommerce_Flag', 'R'
         else
-          xml.tag! "Card_Number", credit_card.number
-          xml.tag! "Expiry_Date", expdate(credit_card)
-          xml.tag! "CardHoldersName", credit_card.name
-          xml.tag! "CardType", card_type(credit_card.brand)
+          xml.tag! 'Card_Number', credit_card.number
+          xml.tag! 'Expiry_Date', expdate(credit_card)
+          xml.tag! 'CardHoldersName', credit_card.name
+          xml.tag! 'CardType', card_type(credit_card.brand)
 
           add_credit_card_eci(xml, credit_card, options)
           add_credit_card_verification_strings(xml, credit_card, options)
@@ -245,16 +245,16 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credit_card_eci(xml, credit_card, options)
-        eci = if credit_card.is_a?(NetworkTokenizationCreditCard) && credit_card.source == :apple_pay && card_brand(credit_card) == "discover"
+        eci = if credit_card.is_a?(NetworkTokenizationCreditCard) && credit_card.source == :apple_pay && card_brand(credit_card) == 'discover'
           # Discover requires any Apple Pay transaction, regardless of in-app
           # or web, and regardless of the ECI contained in the PKPaymentToken,
           # to have an ECI value explicitly of 04.
-          "04"
+          '04'
         else
           (credit_card.respond_to?(:eci) ? credit_card.eci : nil) || options[:eci] || DEFAULT_ECI
         end
 
-        xml.tag! "Ecommerce_Flag", eci.to_s =~ /^[0-9]+$/ ? eci.to_s.rjust(2, '0') : eci
+        xml.tag! 'Ecommerce_Flag', eci.to_s =~ /^[0-9]+$/ ? eci.to_s.rjust(2, '0') : eci
       end
 
       def add_credit_card_verification_strings(xml, credit_card, options)
@@ -262,15 +262,15 @@ module ActiveMerchant #:nodoc:
         if address
           address_values = []
           [:address1, :zip, :city, :state, :country].each { |part| address_values << address[part].to_s }
-          xml.tag! "VerificationStr1", address_values.join("|")
+          xml.tag! 'VerificationStr1', address_values.join('|')
         end
 
         if credit_card.is_a?(NetworkTokenizationCreditCard)
           add_network_tokenization_credit_card(xml, credit_card)
         else
           if credit_card.verification_value?
-            xml.tag! "CVD_Presence_Ind", "1"
-            xml.tag! "VerificationStr2", credit_card.verification_value
+            xml.tag! 'CVD_Presence_Ind', '1'
+            xml.tag! 'VerificationStr2', credit_card.verification_value
           end
 
           add_card_authentication_data(xml, options)
@@ -281,21 +281,21 @@ module ActiveMerchant #:nodoc:
         case card_brand(credit_card).to_sym
         when :american_express
           cryptogram = Base64.decode64(credit_card.payment_cryptogram)
-          xml.tag!("XID", Base64.encode64(cryptogram[20...40]))
-          xml.tag!("CAVV", Base64.encode64(cryptogram[0...20]))
+          xml.tag!('XID', Base64.encode64(cryptogram[20...40]))
+          xml.tag!('CAVV', Base64.encode64(cryptogram[0...20]))
         else
-          xml.tag!("XID", credit_card.transaction_id) if credit_card.transaction_id
-          xml.tag!("CAVV", credit_card.payment_cryptogram)
+          xml.tag!('XID', credit_card.transaction_id) if credit_card.transaction_id
+          xml.tag!('CAVV', credit_card.payment_cryptogram)
         end
       end
 
       def add_card_authentication_data(xml, options)
-        xml.tag! "CAVV", options[:cavv]
-        xml.tag! "XID", options[:xid]
+        xml.tag! 'CAVV', options[:cavv]
+        xml.tag! 'XID', options[:xid]
       end
 
       def add_credit_card_token(xml, store_authorization, options)
-        params = store_authorization.split(";")
+        params = store_authorization.split(';')
         credit_card = CreditCard.new(
           :brand      => params[1],
           :first_name => params[2],
@@ -303,37 +303,37 @@ module ActiveMerchant #:nodoc:
           :month      => params[4],
           :year       => params[5])
 
-        xml.tag! "TransarmorToken", params[0]
-        xml.tag! "Expiry_Date", expdate(credit_card)
-        xml.tag! "CardHoldersName", credit_card.name
-        xml.tag! "CardType", card_type(credit_card.brand)
+        xml.tag! 'TransarmorToken', params[0]
+        xml.tag! 'Expiry_Date', expdate(credit_card)
+        xml.tag! 'CardHoldersName', credit_card.name
+        xml.tag! 'CardType', card_type(credit_card.brand)
         add_card_authentication_data(xml, options)
       end
 
       def add_customer_data(xml, options)
-        xml.tag! "Customer_Ref", options[:customer] if options[:customer]
-        xml.tag! "Client_IP", options[:ip] if options[:ip]
-        xml.tag! "Client_Email", options[:email] if options[:email]
+        xml.tag! 'Customer_Ref', options[:customer] if options[:customer]
+        xml.tag! 'Client_IP', options[:ip] if options[:ip]
+        xml.tag! 'Client_Email', options[:email] if options[:email]
       end
 
       def add_address(xml, options)
         if address = (options[:billing_address] || options[:address])
-          xml.tag! "ZipCode", address[:zip]
+          xml.tag! 'ZipCode', address[:zip]
         end
       end
 
       def add_invoice(xml, options)
-        xml.tag! "Reference_No", options[:order_id]
-        xml.tag! "Reference_3",  options[:description] if options[:description]
+        xml.tag! 'Reference_No', options[:order_id]
+        xml.tag! 'Reference_3',  options[:description] if options[:description]
       end
 
       def add_tax_fields(xml, options)
-        xml.tag! "Tax1Amount",  options[:tax1_amount] if options[:tax1_amount]
-        xml.tag! "Tax1Number",  options[:tax1_number] if options[:tax1_number]
+        xml.tag! 'Tax1Amount',  options[:tax1_amount] if options[:tax1_amount]
+        xml.tag! 'Tax1Number',  options[:tax1_number] if options[:tax1_number]
       end
 
       def add_level_3(xml, options)
-        xml.tag!("Level3") { |x| x << options[:level_3] } if options[:level_3]
+        xml.tag!('Level3') { |x| x << options[:level_3] } if options[:level_3]
       end
 
       def expdate(credit_card)
@@ -379,9 +379,9 @@ module ActiveMerchant #:nodoc:
             response[:authorization_num],
             response[:transaction_tag],
             (response[:dollar_amount].to_f * 100).round
-          ].join(";")
+          ].join(';')
         else
-          ""
+          ''
         end
       end
 
@@ -394,7 +394,7 @@ module ActiveMerchant #:nodoc:
             credit_card.last_name,
             credit_card.month,
             credit_card.year
-            ].map { |value| value.to_s.gsub(/;/, "") }.join(";")
+            ].map { |value| value.to_s.gsub(/;/, '') }.join(';')
         else
           raise StandardError, "TransArmor support is not enabled on your #{display_name} account"
         end
@@ -408,10 +408,10 @@ module ActiveMerchant #:nodoc:
       def message_from(response)
         if(response[:faultcode] && response[:faultstring])
           response[:faultstring]
-        elsif(response[:error_number] && response[:error_number] != "0")
+        elsif(response[:error_number] && response[:error_number] != '0')
           response[:error_description]
         else
-          result = (response[:exact_message] || "")
+          result = (response[:exact_message] || '')
           result << " - #{response[:bank_message]}" if response[:bank_message].present?
           result
         end
@@ -419,7 +419,7 @@ module ActiveMerchant #:nodoc:
 
       def parse_error(error)
         {
-          :transaction_approved => "false",
+          :transaction_approved => 'false',
           :error_number => error.code,
           :error_description => error.body,
           :ecommerce_error_code => error.body.gsub(/[^\d]/, '')
@@ -434,7 +434,7 @@ module ActiveMerchant #:nodoc:
         response = {}
         xml = REXML::Document.new(xml)
 
-        if root = REXML::XPath.first(xml, "//TransactionResult")
+        if root = REXML::XPath.first(xml, '//TransactionResult')
           parse_elements(response, root)
         end
 
@@ -443,7 +443,7 @@ module ActiveMerchant #:nodoc:
 
       def parse_elements(response, root)
         root.elements.to_a.each do |node|
-          response[node.name.gsub(/EXact/, "Exact").underscore.to_sym] = (node.text || "").strip
+          response[node.name.gsub(/EXact/, 'Exact').underscore.to_sym] = (node.text || '').strip
         end
       end
     end